From nobody Sun Feb 8 10:03:49 2026 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EA3B30B50D for ; Fri, 31 Oct 2025 20:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761942162; cv=none; b=s8CU3KTiKHOFn8W4743wz/iwiE1wjyGkw6q2X/8XPUvhW78eoH1XJOh933bgomTlMbSuG5cFpW+3XVQ1uYYT5O1t6KHsrZWfTkRUG7PrDs78RRLDoMTbohRzZYW1fT8nZOBWhqbaLZ1v2WLf7d50MIrQOUNO2e9ODCMJZCUfwfc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761942162; c=relaxed/simple; bh=xG56qsMH2WuZG3c7wHt0lGtWrKdZNmLha+U2JMxWS24=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QSvz02orWUQ/0pU/vFrC9PlN/N6AN+Uks+khnsJYkO0YE0d+IIEfGUfZnVeow0jfA6Zf6RNKmTb6HAH78tmGB4/nePvDsLCClDJLQ2g/M0fM26oK1zksbA3xAIGO8Ka3fNfyeNVcAVlf5D6rMZZXAp7l+e7m591xcrQHSA2q/EY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Dnfmtsd/; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dnfmtsd/" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-592fa38fe60so3467871e87.3 for ; Fri, 31 Oct 2025 13:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761942158; x=1762546958; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qsZcwQVtwdhCivWDhKm/5zaUeqA1jP6eTb4+KpUSqwc=; b=Dnfmtsd/2UPto3N512HWy0p6HVN4bGZjYL80D0TJsw80Lzob49WkluayNIGeEEMG7s QIfpZvrkdhauNgYGLYvl7JdcAl4dio8McASFWffevhouzftHdwx0Gc+bVy263Lec9jGd A3r5C3il4z78pHaDC7EItw1PhSBe0uvi2uv2wAxCCz3Pl97oSmh4WX1keL+NC/u1f9mP zBhfZbD9pjr/2r0GKPwnDXLmUFCrSxEkt9A7FlxX+3v+uMbiy4ZXjrDF3i49MeeM0JQb 39+Eoc8bWsdxq9PNVmnzrwPrTNDKUzhaar+1Fswsu9bL5xp03+kd8B8fwAZgpmQGDKld OGvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761942158; x=1762546958; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qsZcwQVtwdhCivWDhKm/5zaUeqA1jP6eTb4+KpUSqwc=; b=LoA2MwJsqKr+DMA0+KtwqsMPoAZ8mjPQumBQCZ5ftK5mVtw9kWES7JcHgkAWWVkJYo BqsEdWNuklmXm/q+ZeFd00Fp0I3KI8B3xJMF1RZnwn4LFzE6XWeKmOk9S7WO3ObrLi7V lzEBxniXhpfBtMYYeOotN/21utzxjP7QY5Zjc7X/qGWn7N2WSlHCfH/uEiCEAZiAZKdc 5EBctrl6HrlloDJKZx1jIrshu4U+wJJ/GeelRU2EHPD96fjiYvyftFIBSAj8xYNr1Nzm L0TeFge3qF7TfpHhvWHkBMMfb0FZEa4QZkqyu7dj5cGvjO7/0jBOzNxnzDUy30ojw94d fUDQ== X-Gm-Message-State: AOJu0YzC1z3R+jJpxL7TlcqpDA6Q5QRJYbUlfTSsf9z5LSEAKEO6i0Mz J0uEYeSTzE1BeQLgomrl2ZbpeiMXEBlbm3xdO1YXDjmtHraahz9BaAPbKHU4aQoZ X-Gm-Gg: ASbGncs1SZl+nzFk9kJrzmPZVgNg1FfaD8FQzIB9RwwcIQtrzVeNef2iBsaKd/W6bC0 RZngzoxpalqC9tCAhun8GPLE+yR4nP4zHXF/0VelViWwbeqmgsUK2gKY9NONBt8ke8qyFaIe8lw CLNHVZ+sZxGs+U+rhUnG25xRlG5iayhHcpADCdiKoc5I4pOY+QOQs0eoRgmnaUjcXvSeoZ4AAkf vIGKxF9uZPLQwxJ2eqEGB9+UDQSK4Nufq59e529vtrR3P17pQp2DCECNPA968HW/6inqEwkTpYo cmS4qNgssn9srKvKD78tV6aprkN86qTvolJeOmrFsHNn+fz3nD3CbkNDaWOPS9o34NaCDYo92V4 Qu0qbNZvi1jXpu4U2IK79E/s2oIs/k+gKjhyXXxhO5sDaZzGkSBWUfmjicRyQKJw0UCRha7xY65 fKlR0= X-Google-Smtp-Source: AGHT+IEFROwv14v4VtNeXmBx07IO0llOFTdpkWeY0h878Ddr9Ngru7QFo7D5rPTu2YYfmOzcxZIaTQ== X-Received: by 2002:a05:6512:1384:b0:592:f814:7c94 with SMTP id 2adb3069b0e04-5941d5079a9mr1680972e87.1.1761942158041; Fri, 31 Oct 2025 13:22:38 -0700 (PDT) Received: from archlinux ([109.234.31.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5941f5b5d3csm706058e87.68.2025.10.31.13.22.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 13:22:36 -0700 (PDT) From: zntsproj X-Google-Original-From: zntsproj To: linux-kernel@vger.kernel.org Cc: bamv2005@gmail.com, shuah@kernel.org, linux-gpio@vger.kernel.org, linux-kselftest@vger.kernel.org, zntsproj Subject: [PATCH] gpio-selftests: replace fixed sleep with polling+timeout Date: Fri, 31 Oct 2025 23:22:26 +0300 Message-ID: <20251031202226.7148-1-vseokaktusah7@gmail.com> X-Mailer: git-send-email 2.51.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the hard-coded sleep 0.1 with a polling loop with timeout to check the sysfs GPIO value. This avoids timing-dependent flaky failures in CI and on slower machines. --- .../testing/selftests/gpio/gpio-aggregator.sh | 59 +++++++++++++++---- 1 file changed, 46 insertions(+), 13 deletions(-) diff --git a/tools/testing/selftests/gpio/gpio-aggregator.sh b/tools/testin= g/selftests/gpio/gpio-aggregator.sh index 9b6f80ad9..1e81e62e9 100755 --- a/tools/testing/selftests/gpio/gpio-aggregator.sh +++ b/tools/testing/selftests/gpio/gpio-aggregator.sh @@ -671,26 +671,59 @@ teardown_4() { agg_configfs_cleanup } =20 +# helper: wait for sysfs file to become a given value (timeout in seconds) +wait_for_sysfs_value() { + file=3D"$1" + expected=3D"$2" + timeout=3D"${3:-2}" # seconds + interval=3D"0.01" # seconds per poll + max=3D$((timeout * 100)) + i=3D0 + + while [ "$i" -lt "$max" ]; do + if [ "$(cat "$file")" =3D "$expected" ]; then + return 0 + fi + sleep "$interval" + i=3D$((i + 1)) + done + + return 1 +} + echo "4.1. Forwarding set values" setup_4 OFFSET=3D0 for SETTING in $SETTINGS; do - CHIP=3D$(echo "$SETTING" | cut -d: -f1) - BANK=3D$(echo "$SETTING" | cut -d: -f2) - LINE=3D$(echo "$SETTING" | cut -d: -f3) - DEVNAME=3D$(cat "$CONFIGFS_SIM_DIR/$CHIP/dev_name") - CHIPNAME=3D$(cat "$CONFIGFS_SIM_DIR/$CHIP/$BANK/chip_name") - VAL_PATH=3D"/sys/devices/platform/$DEVNAME/$CHIPNAME/sim_gpio${LINE}/valu= e" - test $(cat $VAL_PATH) =3D "0" || fail "incorrect value read from sysfs" - $BASE_DIR/gpio-mockup-cdev -s 1 "/dev/$(agg_configfs_chip_name agg0)" "$O= FFSET" & - mock_pid=3D$! - sleep 0.1 # FIXME Any better way? - test "$(cat $VAL_PATH)" =3D "1" || fail "incorrect value read from sysfs" - kill "$mock_pid" - OFFSET=3D$(expr $OFFSET + 1) + CHIP=3D$(echo "$SETTING" | cut -d: -f1) + BANK=3D$(echo "$SETTING" | cut -d: -f2) + LINE=3D$(echo "$SETTING" | cut -d: -f3) + DEVNAME=3D$(cat "$CONFIGFS_SIM_DIR/$CHIP/dev_name") + CHIPNAME=3D$(cat "$CONFIGFS_SIM_DIR/$CHIP/$BANK/chip_name") + VAL_PATH=3D"/sys/devices/platform/$DEVNAME/$CHIPNAME/sim_gpio${LINE}/v= alue" + + test "$(cat "$VAL_PATH")" =3D "0" || fail "incorrect value read from s= ysfs" + + $BASE_DIR/gpio-mockup-cdev -s 1 "/dev/$(agg_configfs_chip_name agg0)" = "$OFFSET" & + mock_pid=3D$! + + # wait up to 2s for value to flip to "1" + if ! wait_for_sysfs_value "$VAL_PATH" "1" 2; then + kill "$mock_pid" 2>/dev/null || true + wait "$mock_pid" 2>/dev/null || true + fail "timeout waiting for $VAL_PATH to become 1" + fi + + test "$(cat "$VAL_PATH")" =3D "1" || fail "incorrect value read from s= ysfs" + + kill "$mock_pid" 2>/dev/null || true + wait "$mock_pid" 2>/dev/null || true + + OFFSET=3D$((OFFSET + 1)) done teardown_4 =20 + echo "4.2. Forwarding set config" setup_4 OFFSET=3D0 --=20 2.51.2