From nobody Sun Feb 8 11:45:05 2026 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47FA12FD697 for ; Fri, 31 Oct 2025 16:56:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761929819; cv=none; b=ln9dnOUzRVq4oWpD8YWbkALr5G+bBxzC76ymTvjNzqDRSt/VIdM3wSZuK9KlfjQunwWmBMQtoJRmiwRIj9qbkwqG790RGVMJ1Ggcdu62Xf/BccdwyhWXsNjKMoDReeZtmMX134zlxpoxF3sAFn0E4MN+7x497H1FXs7CVxhDQfY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761929819; c=relaxed/simple; bh=WWnQxq9MvOz5vophT5mh709wnc18gU/QGh7BlY7BU44=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rWhXg1K9V6+K/zDUNWGS6WMYhUg61lVZ4s/eshaJJ76JxGOVAdh2+8Xqtznl7Q9KOEcizplfdIz/Q+ZJMKx0OSOA2zhQP4YN2vg9hHLSucgPjy3UG644ncD/0dEBSMVrasBhj+6MfhRuS+4IxOhr1Ow6y6REEm3Ikb1hKC14+So= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FqR3OA6F; arc=none smtp.client-ip=209.85.210.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FqR3OA6F" Received: by mail-pf1-f193.google.com with SMTP id d2e1a72fcca58-793021f348fso2294146b3a.1 for ; Fri, 31 Oct 2025 09:56:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761929817; x=1762534617; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=75H06cNN6UuN6pp1+AJHS92a14vydasjYoMYY7ki7eY=; b=FqR3OA6FfwdQNbQxzim1e1vH5+6Xs3MKk/QQCmJz9jzfhCUIZBT3Sw1+V14sG9xifS kirJtJsoTLMPsTL8iY/Zv5LBeoLsqvhOUtNpweK533m34iUNItowDZw9ud7Ob0OLVOyB Vfh2cc3qwPn0l9s8zrudPUmUC4GgzdMelqfgrplnmqlMGKW6Zjfi8sxcc8TpL2fHbrhe vMtoSWCl4z9zTtxB9AR515W0faQ3FOk4HEvY5DJhmwlb3GWLsvfiKRFw89/nXqKSzrvW xLKMcx5ov+uai1DhePx32Sq32pq6Vf6O5ZcMpDf625O1YQ9rgONLhDCyRRyOrY5Y421y uKHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761929817; x=1762534617; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=75H06cNN6UuN6pp1+AJHS92a14vydasjYoMYY7ki7eY=; b=Oe110LGYcwXPIs+ZyuqOjcxxZdHlARPERd23FFx1IcrEsf7bl4jY4jbSuisbzR21yu 341kTW6sXRWXjwqtIF4foxiO3vuJ5eGULMUbBpSOakbp5F3f1ImjjUJuDIwHRnsimqU8 QmBYlCp54kkUT5+oGmiAphgyHSqVx+mm9S8XKBI3SR03CkKyWGvUD5J1o++RA4paeQ7s pct9HBKphBCaVU9rTA8VbC0seJoiTShC+IHOny/MqQarTRD9rNgfwuSz5NZPfKrlbrEL 3y8hteP+ZCm4lwPsYdH5IloSoBd+wub9bjIbVYmUM5H1sof94crYINGnxlIbYIBnvdjb Lttg== X-Forwarded-Encrypted: i=1; AJvYcCWf4Hp5OTWyxPir35Tq0ff4DOPrEELtOk9YaBnAMlM/UN5j5eYSs8jnMsshpLasGPWr4uG4WR32YZFHFjo=@vger.kernel.org X-Gm-Message-State: AOJu0YxdNLnQ73/yzhP7auwmV/09GJTHbklUQ+StzDH1ZmXZXOdafiku j4kO9ZnnQ736QgfHFrvKhSyNIVAwQ8/kM8J8eBSWS1WnU3jKQAQTBF8H X-Gm-Gg: ASbGncsUADhIUGi79U2MHcWzNAPKtLihQZN2lNjeK9NJZngLSSUWs8TQNNFqg/FKl07 zDbBUUctEGSrIGY8b4S7d9vqPgj4g11sj8YGSwVZz5DhDLxHP3hoTyeDkWgP03IeFRXTXZFQulv V8eAWlRCfZWEbNcLFtJ+thNGMrqfKrMUZZbut5BjtYp56MgtU5d7EqgsCjkd89IuH3D4BZMD2yd zgn4MXXNIeZCylfllwSHleIgDHvQM5mNmIhK9/2LGnSXJmj4/Ike2siKxSmEs6f9OUoeFO5eAQ/ GTdc+n3S6+TsF4bbvX1VsqjzJLjpoa+tweqhOy1eLrXB2ocgjfbdedt26zPJlV+hJk00hWOmKvG LljZ6dK25brMVgPJ1dkkZo7vFNvwAQ5geIQTuXaLwXjFAXS5Cq9dAGpfNxp4zThBxQQUbjm4Rjk ngl9w= X-Google-Smtp-Source: AGHT+IEn9mRaFriZ4w42iWzEpFpTJw3pAZ5gIf/TLvCs2205ZF0F+XXD+dUdH9vCvuvbHC5KOkO2jw== X-Received: by 2002:a05:6a00:3e24:b0:781:24ec:c8f4 with SMTP id d2e1a72fcca58-7a776d97ed2mr4632190b3a.3.1761929817335; Fri, 31 Oct 2025 09:56:57 -0700 (PDT) Received: from Ubuntu24.. ([103.187.64.30]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7a7dbc5aa56sm2745572b3a.68.2025.10.31.09.56.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 09:56:56 -0700 (PDT) From: Shrikant Raskar To: hverkuil@kernel.org, mchehab@kernel.org Cc: skhan@linuxfoundation.org, david.hunter.linux@gmail.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, Shrikant Raskar Subject: [RFC PATCH v3] media: saa6588: Remove dprintk macro and use v4l2_info() Date: Fri, 31 Oct 2025 22:26:45 +0530 Message-ID: <20251031165645.6217-1-raskar.shree97@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The existing 'dprintk' macro used an unwrapped 'if' statement which was flagged by checkpatch, but instead of wrapping it, the debug handling can be simplified. This patch removes the 'dprintk' macro entirely and replaces all its usages with v4l2_info() helper. The unused 'PREFIX' macro is also removed. Signed-off-by: Shrikant Raskar --- Changelog: Changes since v2: - Fixed indentation issue reported by media CI robot. Link to v2: https://lore.kernel.org/all/20251025124107.4921-1-raskar.shree97@gmail.com/ --- drivers/media/i2c/saa6588.c | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/media/i2c/saa6588.c b/drivers/media/i2c/saa6588.c index fb09e4560d8a..90ae4121a68a 100644 --- a/drivers/media/i2c/saa6588.c +++ b/drivers/media/i2c/saa6588.c @@ -49,8 +49,6 @@ MODULE_LICENSE("GPL"); /* ---------------------------------------------------------------------- = */ =20 #define UNSET (-1U) -#define PREFIX "saa6588: " -#define dprintk if (debug) printk =20 struct saa6588 { struct v4l2_subdev sd; @@ -144,14 +142,14 @@ static bool block_from_buf(struct saa6588 *s, unsigne= d char *buf) =20 if (s->rd_index =3D=3D s->wr_index) { if (debug > 2) - dprintk(PREFIX "Read: buffer empty.\n"); + v4l2_info(&s->sd, "Read: buffer empty.\n"); return false; } =20 if (debug > 2) { - dprintk(PREFIX "Read: "); + v4l2_info(&s->sd, "Read: "); for (i =3D s->rd_index; i < s->rd_index + 3; i++) - dprintk("0x%02x ", s->buffer[i]); + v4l2_info(&s->sd, "0x%02x ", s->buffer[i]); } =20 memcpy(buf, &s->buffer[s->rd_index], 3); @@ -162,7 +160,7 @@ static bool block_from_buf(struct saa6588 *s, unsigned = char *buf) s->block_count--; =20 if (debug > 2) - dprintk("%d blocks total.\n", s->block_count); + v4l2_info(&s->sd, "%d blocks total.\n", s->block_count); =20 return true; } @@ -222,11 +220,11 @@ static void block_to_buf(struct saa6588 *s, unsigned = char *blockbuf) unsigned int i; =20 if (debug > 3) - dprintk(PREFIX "New block: "); + v4l2_info(&s->sd, "New block: "); =20 for (i =3D 0; i < 3; ++i) { if (debug > 3) - dprintk("0x%02x ", blockbuf[i]); + v4l2_info(&s->sd, "0x%02x ", blockbuf[i]); s->buffer[s->wr_index] =3D blockbuf[i]; s->wr_index++; } @@ -242,7 +240,7 @@ static void block_to_buf(struct saa6588 *s, unsigned ch= ar *blockbuf) s->block_count++; =20 if (debug > 3) - dprintk("%d blocks total.\n", s->block_count); + v4l2_info(&s->sd, "%d blocks total.\n", s->block_count); } =20 static void saa6588_i2c_poll(struct saa6588 *s) @@ -257,7 +255,7 @@ static void saa6588_i2c_poll(struct saa6588 *s) SAA6588 returns garbage otherwise. */ if (6 !=3D i2c_master_recv(client, &tmpbuf[0], 6)) { if (debug > 1) - dprintk(PREFIX "read error!\n"); + v4l2_info(&s->sd, "read error!\n"); return; } =20 @@ -267,7 +265,7 @@ static void saa6588_i2c_poll(struct saa6588 *s) blocknum =3D tmpbuf[0] >> 5; if (blocknum =3D=3D s->last_blocknum) { if (debug > 3) - dprintk("Saw block %d again.\n", blocknum); + v4l2_info(&s->sd, "Saw block %d again.\n", blocknum); return; } =20 @@ -370,12 +368,13 @@ static void saa6588_configure(struct saa6588 *s) break; } =20 - dprintk(PREFIX "writing: 0w=3D0x%02x 1w=3D0x%02x 2w=3D0x%02x\n", - buf[0], buf[1], buf[2]); + if (debug) + v4l2_info(&s->sd, "writing: 0w=3D0x%02x 1w=3D0x%02x 2w=3D0x%02x\n", + buf[0], buf[1], buf[2]); =20 rc =3D i2c_master_send(client, buf, 3); if (rc !=3D 3) - printk(PREFIX "i2c i/o error: rc =3D=3D %d (should be 3)\n", rc); + v4l2_info(&s->sd, "i2c i/o error: rc =3D=3D %d (should be 3)\n", rc); } =20 /* ---------------------------------------------------------------------- = */ base-commit: 6fab32bb6508abbb8b7b1c5498e44f0c32320ed5 --=20 2.43.0