From nobody Sun Feb 8 12:14:53 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B042337699 for ; Fri, 31 Oct 2025 10:09:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761905385; cv=none; b=NnWmWzFInwpQ0v/MgaBwQn8ffFzRY0hOupzfZ1uWR/y8Ixm3h3j9nNyxB773L+uuxQxhXilXty3S1hgU4l7KfXy19xVuhbkAEk/svXotlmQkbGAUf5R7uret21Nrn6zJEETKpO3LVkpbebMUb70irPJLZBskrjYw6iJ6jNsRBoE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761905385; c=relaxed/simple; bh=DzMdjQWo243IhosnLEhACo6mMZtVYlsYLbbRNFz18zo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mUXMifz2Xx5DHhTbVamvE1znqZRtze4v8UB3vT5ABDk6lQneiJ8gizdWsEst83qcRhhkTdeU4BS2MHapVVzlszzw6yN0M6Z3eJ7zw2P3FjTWEI4oqxfEU5ypfLz0qmL0sLFOXbMwoQeInBszIJ8gtr+XGB4v9uLlg9BnZUyMLTQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=F/951bL1; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="F/951bL1" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-475e01db75aso13625575e9.1 for ; Fri, 31 Oct 2025 03:09:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1761905378; x=1762510178; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=geErPXIF4l5oKM4a83yW4A9ZMeZpPoF80B9UfR8ZKv0=; b=F/951bL1N6KT3MlHwmO2hIOVizqX7OsQTzGdNGZOVZ8JyFQngi2BgQrcRlj8pN9oQw KQB3vraFAHPLh+m1QYSFXAmo352WzfeahCMaIcUbhU0c8G1JrNNVYh0cW9xlJiZUYZtD bxigI+f8FsnoQvqBaHj+tcfP4rDAFRRWIPiZNRgh4TR6Vp2/Jm3+JU+ZpZ2Yf06KB15i U6VHKE83ozxULROF6fbFJxKYYtHL2Zk5Mch4nhpvXjUIbwKHVS9kPQMVCe0iZDMzEROO MU/nmCHTFG8M3c4dBvQR9hv46S6Xk33/lnFJKkNi3aA5tFHkDtwCY80DUuFHLYb1ZV8e mW0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761905378; x=1762510178; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=geErPXIF4l5oKM4a83yW4A9ZMeZpPoF80B9UfR8ZKv0=; b=sPKxdjVOKS3Hsw8/fOwh1HCuwcd9Hf72orSghry6hTrKoshnmqFrP7JIFqY9EbWwaX ohyjjjtF/pSlyqfUJ8CHgieDJ7g6e3KMjOujh3iIRxA1/6JRDUGHe/yWpLuDTNCDL8zz qomqWa+GnNgED4JbB/FLs/YPfOukU9P8HKgiLoEFQkNvk8jRenP6uhG51RQextvxLH/Y F4kAhS0veTxZ4nkpL/mRQrdJNo2CbWDB5yZZwDod4onRYB4AasdyEWHklo5x9Q82M/sP bbgysKbXfYdk/ao0BtpPMZSxt2Xt4Q2+9FfbZW3TJBJiGzoiaqPNV15AKplWOhAMy5hB j6hg== X-Gm-Message-State: AOJu0YwvsKTCvFJ0Ll742VRYn4Zj/UpZGSpW6HEhKH+Sw4hqDnBLT1cB 5KFpvTRG6YbLjOZiVSBGww+Mnh2euMXKxuzWYDeosxtlgzUPpzAn2g18UqgdzM1US4k0zR0xKnC zPbr2 X-Gm-Gg: ASbGnctANrTfFfZzUm2AjwaCiiMnPWIKhgTCp+kO7kj/nngHWJJNk50MDK5IQRLJV1A hPw7+r4rA9o25pGO9TLdA1UHBNeguYpU9ctcE4STCSXWD4XZ5OQmJ/uoo6QmRiFIRTnuaCi1r6c jJsmlSGEoC4F3cnZcGiiud68gWOS4fXA+8RGJ4iH/qNFdCvJEshI1o4tzNWIQjrSLc4Zo6QBg5O CmVYEZXOBJtZIaWLI5Cjl74cDkzCJTD16kUC5mvB94m6JQ5Og4PUV346jqKJipiwODvMit6BWSf D2ypXRYj2iSuxRfET571BpW+U2ugCwLuynaZbFruAGY/h1vot46N0wQbapSp02bnaQAuspa746j KIJV0hgIZ8S9NUqSMqKE/ke2HyizadFG56Sf71pdrK2Wbvcl09MiEkOVsJEBb6Uw6jeQnWPJvMs +29wIP+h9BzgBgTUJbKowtoHHpg8go6ZYWp4I= X-Google-Smtp-Source: AGHT+IHeodxObcBBJn4QjePgORkM3nPGBaq2Yj+2iKThad3LaDctwhOITCPrMl3v8n0KUydBNlV4tw== X-Received: by 2002:a05:600c:3511:b0:477:a9e:859b with SMTP id 5b1f17b1804b1-4773089c496mr27121895e9.24.1761905377934; Fri, 31 Oct 2025 03:09:37 -0700 (PDT) Received: from localhost.localdomain ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429c13e1c9esm2839171f8f.22.2025.10.31.03.09.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 03:09:37 -0700 (PDT) From: Marco Crivellari To: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter Subject: [PATCH 1/3] drm/i915: replace use of system_unbound_wq with system_dfl_wq Date: Fri, 31 Oct 2025 11:09:21 +0100 Message-ID: <20251031100923.85721-2-marco.crivellari@suse.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251031100923.85721-1-marco.crivellari@suse.com> References: <20251031100923.85721-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistency cannot be addressed without refactoring the API. system_unbound_wq should be the default workqueue so as not to enforce locality constraints for random work whenever it's not required. Adding system_dfl_wq to encourage its use when unbound work should be used. The old system_unbound_wq will be kept for a few release cycles. Suggested-by: Tejun Heo Signed-off-by: Marco Crivellari --- drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- drivers/gpu/drm/i915/display/intel_tc.c | 4 ++-- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 2 +- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 4 ++-- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 4 ++-- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 6 +++--- drivers/gpu/drm/i915/i915_active.c | 2 +- drivers/gpu/drm/i915/i915_sw_fence_work.c | 2 +- drivers/gpu/drm/i915/i915_vma_resource.c | 2 +- drivers/gpu/drm/i915/pxp/intel_pxp.c | 2 +- drivers/gpu/drm/i915/pxp/intel_pxp_irq.c | 2 +- 11 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/g= pu/drm/i915/display/intel_display_power.c index da4babfd6bcb..002a7ba6f630 100644 --- a/drivers/gpu/drm/i915/display/intel_display_power.c +++ b/drivers/gpu/drm/i915/display/intel_display_power.c @@ -645,7 +645,7 @@ queue_async_put_domains_work(struct i915_power_domains = *power_domains, power.domains); drm_WARN_ON(display->drm, power_domains->async_put_wakeref); power_domains->async_put_wakeref =3D wakeref; - drm_WARN_ON(display->drm, !queue_delayed_work(system_unbound_wq, + drm_WARN_ON(display->drm, !queue_delayed_work(system_dfl_wq, &power_domains->async_put_work, msecs_to_jiffies(delay_ms))); } diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915= /display/intel_tc.c index c4a5601c5107..2677e25c42f2 100644 --- a/drivers/gpu/drm/i915/display/intel_tc.c +++ b/drivers/gpu/drm/i915/display/intel_tc.c @@ -1838,7 +1838,7 @@ bool intel_tc_port_link_reset(struct intel_digital_po= rt *dig_port) if (!intel_tc_port_link_needs_reset(dig_port)) return false; =20 - queue_delayed_work(system_unbound_wq, + queue_delayed_work(system_dfl_wq, &to_tc_port(dig_port)->link_reset_work, msecs_to_jiffies(2000)); =20 @@ -1919,7 +1919,7 @@ void intel_tc_port_unlock(struct intel_digital_port *= dig_port) struct intel_tc_port *tc =3D to_tc_port(dig_port); =20 if (!tc->link_refcount && tc->mode !=3D TC_PORT_DISCONNECTED) - queue_delayed_work(system_unbound_wq, &tc->disconnect_phy_work, + queue_delayed_work(system_dfl_wq, &tc->disconnect_phy_work, msecs_to_jiffies(1000)); =20 mutex_unlock(&tc->lock); diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c b/drivers/gpu/drm= /i915/gem/i915_gem_ttm_move.c index 2f6b33edb9c9..008d5909a010 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c @@ -408,7 +408,7 @@ static void __memcpy_cb(struct dma_fence *fence, struct= dma_fence_cb *cb) =20 if (unlikely(fence->error || I915_SELFTEST_ONLY(fail_gpu_migration))) { INIT_WORK(©_work->work, __memcpy_work); - queue_work(system_unbound_wq, ©_work->work); + queue_work(system_dfl_wq, ©_work->work); } else { init_irq_work(©_work->irq_work, __memcpy_irq_work); irq_work_queue(©_work->irq_work); diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/= gt/uc/intel_guc.c index 52ec4421a211..1c2764440323 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c @@ -624,7 +624,7 @@ int intel_guc_crash_process_msg(struct intel_guc *guc, = u32 action) else guc_err(guc, "Unknown crash notification: 0x%04X\n", action); =20 - queue_work(system_unbound_wq, &guc->dead_guc_worker); + queue_work(system_dfl_wq, &guc->dead_guc_worker); =20 return 0; } @@ -646,7 +646,7 @@ int intel_guc_to_host_process_recv_msg(struct intel_guc= *guc, guc_err(guc, "Received early exception notification!\n"); =20 if (msg & (INTEL_GUC_RECV_MSG_CRASH_DUMP_POSTED | INTEL_GUC_RECV_MSG_EXCE= PTION)) - queue_work(system_unbound_wq, &guc->dead_guc_worker); + queue_work(system_dfl_wq, &guc->dead_guc_worker); =20 return 0; } diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i9= 15/gt/uc/intel_guc_ct.c index 3e7e5badcc2b..9260bdd91f80 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c @@ -31,7 +31,7 @@ static void ct_dead_ct_worker_func(struct work_struct *w); do { \ if (!(ct)->dead_ct_reported) { \ (ct)->dead_ct_reason |=3D 1 << CT_DEAD_##reason; \ - queue_work(system_unbound_wq, &(ct)->dead_ct_worker); \ + queue_work(system_dfl_wq, &(ct)->dead_ct_worker); \ } \ } while (0) #else @@ -1241,7 +1241,7 @@ static int ct_handle_event(struct intel_guc_ct *ct, s= truct ct_incoming_msg *requ list_add_tail(&request->link, &ct->requests.incoming); spin_unlock_irqrestore(&ct->requests.lock, flags); =20 - queue_work(system_unbound_wq, &ct->requests.worker); + queue_work(system_dfl_wq, &ct->requests.worker); return 0; } =20 diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gp= u/drm/i915/gt/uc/intel_guc_submission.c index 68f2b8d363ac..364879a4d1d8 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c @@ -3385,7 +3385,7 @@ static void guc_context_sched_disable(struct intel_co= ntext *ce) } else if (!intel_context_is_closed(ce) && !guc_id_pressure(guc, ce) && delay) { spin_unlock_irqrestore(&ce->guc_state.lock, flags); - mod_delayed_work(system_unbound_wq, + mod_delayed_work(system_dfl_wq, &ce->guc_state.sched_disable_delay_work, msecs_to_jiffies(delay)); } else { @@ -3611,7 +3611,7 @@ static void guc_context_destroy(struct kref *kref) * take the GT PM for the first time which isn't allowed from an atomic * context. */ - queue_work(system_unbound_wq, &guc->submission_state.destroyed_worker); + queue_work(system_dfl_wq, &guc->submission_state.destroyed_worker); } =20 static int guc_context_alloc(struct intel_context *ce) @@ -5382,7 +5382,7 @@ int intel_guc_engine_failure_process_msg(struct intel= _guc *guc, * A GT reset flushes this worker queue (G2H handler) so we must use * another worker to trigger a GT reset. */ - queue_work(system_unbound_wq, &guc->submission_state.reset_fail_worker); + queue_work(system_dfl_wq, &guc->submission_state.reset_fail_worker); =20 return 0; } diff --git a/drivers/gpu/drm/i915/i915_active.c b/drivers/gpu/drm/i915/i915= _active.c index 6b0c1162505a..582e5099e980 100644 --- a/drivers/gpu/drm/i915/i915_active.c +++ b/drivers/gpu/drm/i915/i915_active.c @@ -193,7 +193,7 @@ active_retire(struct i915_active *ref) return; =20 if (ref->flags & I915_ACTIVE_RETIRE_SLEEPS) { - queue_work(system_unbound_wq, &ref->work); + queue_work(system_dfl_wq, &ref->work); return; } =20 diff --git a/drivers/gpu/drm/i915/i915_sw_fence_work.c b/drivers/gpu/drm/i9= 15/i915_sw_fence_work.c index d2e56b387993..366418108f78 100644 --- a/drivers/gpu/drm/i915/i915_sw_fence_work.c +++ b/drivers/gpu/drm/i915/i915_sw_fence_work.c @@ -38,7 +38,7 @@ fence_notify(struct i915_sw_fence *fence, enum i915_sw_fe= nce_notify state) if (test_bit(DMA_FENCE_WORK_IMM, &f->dma.flags)) fence_work(&f->work); else - queue_work(system_unbound_wq, &f->work); + queue_work(system_dfl_wq, &f->work); } else { fence_complete(f); } diff --git a/drivers/gpu/drm/i915/i915_vma_resource.c b/drivers/gpu/drm/i91= 5/i915_vma_resource.c index 53d619ef0c3d..a8f2112ce81f 100644 --- a/drivers/gpu/drm/i915/i915_vma_resource.c +++ b/drivers/gpu/drm/i915/i915_vma_resource.c @@ -202,7 +202,7 @@ i915_vma_resource_fence_notify(struct i915_sw_fence *fe= nce, i915_vma_resource_unbind_work(&vma_res->work); } else { INIT_WORK(&vma_res->work, i915_vma_resource_unbind_work); - queue_work(system_unbound_wq, &vma_res->work); + queue_work(system_dfl_wq, &vma_res->work); } break; case FENCE_FREE: diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.c b/drivers/gpu/drm/i915/px= p/intel_pxp.c index 27d545c4e6a5..b188c4deafb3 100644 --- a/drivers/gpu/drm/i915/pxp/intel_pxp.c +++ b/drivers/gpu/drm/i915/pxp/intel_pxp.c @@ -276,7 +276,7 @@ static void pxp_queue_termination(struct intel_pxp *pxp) spin_lock_irq(gt->irq_lock); intel_pxp_mark_termination_in_progress(pxp); pxp->session_events |=3D PXP_TERMINATION_REQUEST; - queue_work(system_unbound_wq, &pxp->session_work); + queue_work(system_dfl_wq, &pxp->session_work); spin_unlock_irq(gt->irq_lock); } =20 diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_irq.c b/drivers/gpu/drm/i91= 5/pxp/intel_pxp_irq.c index d81750b9bdda..735325e828bc 100644 --- a/drivers/gpu/drm/i915/pxp/intel_pxp_irq.c +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_irq.c @@ -48,7 +48,7 @@ void intel_pxp_irq_handler(struct intel_pxp *pxp, u16 iir) pxp->session_events |=3D PXP_TERMINATION_COMPLETE | PXP_EVENT_TYPE_IRQ; =20 if (pxp->session_events) - queue_work(system_unbound_wq, &pxp->session_work); + queue_work(system_dfl_wq, &pxp->session_work); } =20 static inline void __pxp_set_interrupts(struct intel_gt *gt, u32 interrupt= s) --=20 2.51.0 From nobody Sun Feb 8 12:14:53 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CA9B34D38D for ; Fri, 31 Oct 2025 10:09:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761905386; cv=none; b=pgsMYYdnwzv7Y5yzLRIltk4T/w6V8rJ1Km/DV1joqppOITRZL8tJiJPP3jwTznznqBhM8u9ZydZ7ySnEHxI2QJiICp2FmxJZhWXMFaArbhkBGr4GQWHrBuazgnp6G1N1GTccxQaPIiN0OCEH2dl0ZN8qpu5o4hjvuEMZ5XCeyIY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761905386; c=relaxed/simple; bh=XK+YeaIp0k6cloojSWsT+fjXxaO/2rEe2E4aSXG6N1M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rXanwAP7E7uC1x3oIkuS2fNqjIZOdYqI2DPaxbE0OsiyFqzmVAWo6RECBbPxC6k0U2yJSpwzlv99UfqdfR6FgtorHQxQrh+m2W2opXYGDFHw0oC7rJLyuEpTEgCrVZwx5b2DQ5VVCT0f8a66bvXdSrNFuCQC/XT8zdPIw8LjEuI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=EMAnQkQy; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="EMAnQkQy" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-477365fbdf9so1641495e9.1 for ; Fri, 31 Oct 2025 03:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1761905379; x=1762510179; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AR6DCodMEiRozMtWWQUdsBs+LPg+2s6MkeWZ5TMIU0g=; b=EMAnQkQyQOdiNa+vtDbNQhv3uG3pYjIv3x77GPmuXUP/imesHmF8ngbssVFvAqx9Fc v7GrTFo3wHk0Ld+Im02k8dR5j+5qOHBfv66XZIU4ntYhXvEBWCqynfIFcv9kfGYrxoDF YYvSABXnjZVnnCTUqyih+Pwxkz/adnZGRRcr/9pqtKwSvp2OysL9P2NyhK91t2+hItWG 9LiIhL35ihNvrlNIz6wNkSCEsZF4uSW8rcaSAztg3fwkGZpVzYG1Nw6PjVj3vN7Lb5MN Liv6u/QWBJuvtiNXFcTmoTLXkfNdwF6QMYxzkuFJjlz7/GCUNWO5lVlMOePhAPgNB01h w1rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761905379; x=1762510179; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AR6DCodMEiRozMtWWQUdsBs+LPg+2s6MkeWZ5TMIU0g=; b=JdcDuDcahgID4m5nXcbHuxdLVtlbLgeyj6tlCLyOVx6rJ9uq5Xyv5SjUpl15xUlozB lOhNitkSL2KfOdQ5oZzlRN6Ns7qQFHA54E84Vko4x8dzY6AeUkM2LvsoTK1x2LqdS3nv U7oniL0QxLGxMsBW3li4D9B4XfonT4LHnRqecVyZIr1r762HsOJcKcn71SVj/Poi1JbH j+U7zWM/5mMEcVRtRfz8IvI+tLm9MVu3CwGspb3pkfoCO5Tl4AGJDvNKIEaQ7QWQVVmX t/WeQ18jmyM+XBcMoxx/XFQLj4F7V6caXzLpO7DP6BkE3gyzv+/emljb5zo3ZJWk45oP v3wA== X-Gm-Message-State: AOJu0YzcOru2GUa46WqlCElB8uWgL1NuA1MVUFRlnsaQuKbBzIUJrxe1 bfGqx84cRlw1jCU/RpAjho63sNtq/V+VHc8TMergTlDpBBRgET1nHs/bMFiA8vo4QnwLkeXBoIk ZMlp+ X-Gm-Gg: ASbGncvbk8Reo+UBksBCVz6fbytvKTH9suLWt8r0rt8wfIBqj1yF0Q41dvOH/XqaWSU WxftXS7xldIWKt/hBC8Eth949Q2p9aEEPh8H6hoMV7ZsZc8lYy1Ye/7PLr9cgSbLl6pYlOK0x5l 9cJuEjCK1IuDhoSTyG7NLeYipcJX5qz5aI3bds1zjxvQhGmFpGR2651qIlM1/X4nu4C0IUbnIbq uUbJugj56XlXcVJhR/g91IojVHLZp+VfHUUnqg6FYxAA2k68ZwY+Tknl/vsWBSdHzvUqDLbOARG 67he8xG6jRhfG9eBKZ30VuWX3CjULcKo+elwe9YFE3QlFCFXxQcLRJWxD22O5yCgc4jMoBvArkj Lfc+ZTA6L/r4YSC1a10xPxcZd6yqoWIVEYkmi3r7LPdEguPMqjXF4WIQO3HUgxya/5hevq3cuGV LL7g593rqKAm77jm3jfpfm5sMF X-Google-Smtp-Source: AGHT+IF5CL1Q/oaHD87zPjFp4KiqyMUDxM2HoYOoLKtrm0XnT5ekaMI5s76J1xMKBksDY9h87GST6A== X-Received: by 2002:a05:600c:3e06:b0:475:dc58:39e5 with SMTP id 5b1f17b1804b1-4773089b541mr25699695e9.27.1761905378913; Fri, 31 Oct 2025 03:09:38 -0700 (PDT) Received: from localhost.localdomain ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429c13e1c9esm2839171f8f.22.2025.10.31.03.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 03:09:38 -0700 (PDT) From: Marco Crivellari To: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter Subject: [PATCH 2/3] drm/i915: replace use of system_wq with system_percpu_wq Date: Fri, 31 Oct 2025 11:09:22 +0100 Message-ID: <20251031100923.85721-3-marco.crivellari@suse.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251031100923.85721-1-marco.crivellari@suse.com> References: <20251031100923.85721-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistency cannot be addressed without refactoring the API. system_wq should be the per-cpu workqueue, yet in this name nothing makes that clear, so replace system_wq with system_percpu_wq. The old wq (system_wq) will be kept for a few release cycles. Suggested-by: Tejun Heo Signed-off-by: Marco Crivellari --- drivers/gpu/drm/i915/i915_driver.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915= _driver.c index a28c3710c4d5..0f33cdc11736 100644 --- a/drivers/gpu/drm/i915/i915_driver.c +++ b/drivers/gpu/drm/i915/i915_driver.c @@ -140,7 +140,7 @@ static int i915_workqueues_init(struct drm_i915_private= *dev_priv) /* * The unordered i915 workqueue should be used for all work * scheduling that do not require running in order, which used - * to be scheduled on the system_wq before moving to a driver + * to be scheduled on the system_percpu_wq before moving to a driver * instance due deprecation of flush_scheduled_work(). */ dev_priv->unordered_wq =3D alloc_workqueue("i915-unordered", 0, 0); diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_dr= v.h index 6a768aad8edd..d9f73b9995cf 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -256,7 +256,7 @@ struct drm_i915_private { * * This workqueue should be used for all unordered work * scheduling within i915, which used to be scheduled on the - * system_wq before moving to a driver instance due + * system_percpu_wq before moving to a driver instance due * deprecation of flush_scheduled_work(). */ struct workqueue_struct *unordered_wq; --=20 2.51.0 From nobody Sun Feb 8 12:14:53 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E72E337B8F for ; Fri, 31 Oct 2025 10:09:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761905387; cv=none; b=SIlidwDyxPTCCNeGDZtbIu4dkLnPQe3DtZ6mzIV6M7jgk5LkhMxJIg5VcriU2De35ZGT54jTe3Mu5CGlILyCTwnt3K9bv6XRCcj3cep8WQRAUhkOLOpxPa3oUBgdgBTEw3YAIjU6aN5DEE3yjl3INOGNFJqzfqzpug+D3yPqzmw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761905387; c=relaxed/simple; bh=iPFArMrJamTiHTE+8pUotcITyD91jaBL0nGmruRRbag=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pLTJ4OpvRBRmr3vdls8OHLkltMxH9uLQCQRFNgxluC30b+trlGb2Oul+x2ynlsTpAj/Ny4609w8RZtXlODg/5ehsHJxnMODbUKsEhXgY9pfcTrrF8YDDXUJQl5/DwNKFX4gPQ9x28EzjpBbbeCGJRyxTNOBeajTf88E4MpGeC/0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=dTrsjJoj; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="dTrsjJoj" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-475db4ad7e4so7889125e9.3 for ; Fri, 31 Oct 2025 03:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1761905380; x=1762510180; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uIEAHpZJgPenfQa0eR0eha1rgNHE8FkwlCwPAkqtADI=; b=dTrsjJojpuAVvQwrg2BK0EbY62E7KUzbVuJut5eHgOkIxUCzKn22CPQxWI9xeq1Jc+ 3feLbHKRiQ2mKL+/iyZiPk7REnQhUdqPyAC0vMjKHe+LsGRCPPdjdWDS9qum4K3VkkmO YerOw4n8hd6+G+c9+eRcwFDjmxcvJQ4CUdj89yyx5hI08PB6a7b1491loIolfL/WFSLh wyVvf0lB8OEiyeF/hLuys0EMtNMwwKxpeLaISbObU4sr0MShtGg4KtQ/F45Pn/vz9PIq LkWqi9Oo0FxmEcyl/lB8iJQhA0pulkAiHyiFqelyGgX6esiTDi8hDepe6LcJ0BAl08ib HnHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761905380; x=1762510180; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uIEAHpZJgPenfQa0eR0eha1rgNHE8FkwlCwPAkqtADI=; b=dhfSTa3qboxV9qOYdkML8u5UsNQDuL2boXlp1CNsP0DOG/tIz7MGip/6FR7U6oaljZ UtehSEYcPWzTRvUiBrcb6UcJreaMxVzs51YR6qx34GmUeYNlNNegwmdltycMWIgrODhK l3+YfMnJHSjU2CUoubibeOowA+rk5CGqcv9ehANx+krAmZFZ09F72dPx8L0APCVb531s HTFMojD18bHWz84pp/GpZ4Qe4Ud0furQiMDyGxF2stelDMjaug3iKBTIJGOea6uaVHK8 YsU6BnhF4sJ0rRZhdebQZBLw/4VgNtuxUnzqzfuixGFcDOxuXzISpYAOGZkTEDjvgNfv aegg== X-Gm-Message-State: AOJu0YxxbG/Gs17UZi88qCu9jq2DVkdyn1e8OSjsWzsBxi5GLKxhoW59 S2vzCsLbUqnqlHhayL4gfBMacLaxJ68LgQyGHpdlQoTypygmf8sS76v8n52RKSUTwiQTQ+PBgs5 BxVae X-Gm-Gg: ASbGncumwlVKA2Q7JDdxJeYKZxFbCLUdI2GzYxbC13dBmDo73RmBtsRGAVvWrvHl4G2 PGogImLE9dB2vDjYOe7PVxkvJHfTCGvoDEBHaAtdnXGl17U411LN/G5mI1l1jVSvwKo754X4EB0 BI0mfYrl6N5nNDX9CJ++h3WZpowUIFM7HvhfE+1NR9+JGJ5nzTzh9bHgFtpzPsMtrQbkHEg63mF KpAuGJi7C8kmqnbQczMYxCqGv8WwJuotB/U03Vrtat4ogFtI7rXPIBWhm7cSm/s7+kTMNWA5oxl pr0M2Ne1g+sS5lEevlgj1ohwOIkkytW15+X9orco/k+VLuX0bnmAcgwljctB3D7dpBW1XFsCV4e DMrepBTslZrDPn15NTgZ/KTnT+dHWZT1lTt0cy9oFRpMYe7fVY3kAAzEWduc2J6qODi7ynGLEtU c6IS0tA3LqOG4jJyBXcOE4hxozvepKELHktCxkhXhhxSEFQQ== X-Google-Smtp-Source: AGHT+IEuYSheTD0LAmCUTXMqTUnmXFPaQcuKHhOpSOYN7DCVbycYCPaNazgBhc5bsfGHuKVEiD6GEw== X-Received: by 2002:a05:600c:4695:b0:471:1774:3003 with SMTP id 5b1f17b1804b1-477308be7b3mr29933385e9.29.1761905379892; Fri, 31 Oct 2025 03:09:39 -0700 (PDT) Received: from localhost.localdomain ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429c13e1c9esm2839171f8f.22.2025.10.31.03.09.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 03:09:39 -0700 (PDT) From: Marco Crivellari To: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter Subject: [PATCH 3/3] drm/i915: WQ_PERCPU added to alloc_workqueue users Date: Fri, 31 Oct 2025 11:09:23 +0100 Message-ID: <20251031100923.85721-4-marco.crivellari@suse.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251031100923.85721-1-marco.crivellari@suse.com> References: <20251031100923.85721-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistentcy cannot be addressed without refactoring the API. alloc_workqueue() treats all queues as per-CPU by default, while unbound workqueues must opt-in via WQ_UNBOUND. This default is suboptimal: most workloads benefit from unbound queues, allowing the scheduler to place worker threads where they=E2=80=99re needed= and reducing noise when CPUs are isolated. This change adds a new WQ_PERCPU flag to explicitly request alloc_workqueue() to be per-cpu when WQ_UNBOUND has not been specified. With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND), any alloc_workqueue() caller that doesn=E2=80=99t explicitly specify WQ_UNB= OUND must now use WQ_PERCPU. Once migration is complete, WQ_UNBOUND can be removed and unbound will become the implicit default. Suggested-by: Tejun Heo Signed-off-by: Marco Crivellari --- drivers/gpu/drm/i915/display/intel_display_driver.c | 4 ++-- drivers/gpu/drm/i915/i915_driver.c | 3 ++- drivers/gpu/drm/i915/selftests/i915_sw_fence.c | 2 +- drivers/gpu/drm/i915/selftests/mock_gem_device.c | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_driver.c b/drivers/= gpu/drm/i915/display/intel_display_driver.c index cf1c14412abe..e12f9126b155 100644 --- a/drivers/gpu/drm/i915/display/intel_display_driver.c +++ b/drivers/gpu/drm/i915/display/intel_display_driver.c @@ -257,13 +257,13 @@ int intel_display_driver_probe_noirq(struct intel_dis= play *display) goto cleanup_wq_modeset; } =20 - display->wq.cleanup =3D alloc_workqueue("i915_cleanup", WQ_HIGHPRI, 0); + display->wq.cleanup =3D alloc_workqueue("i915_cleanup", WQ_HIGHPRI | WQ_P= ERCPU, 0); if (!display->wq.cleanup) { ret =3D -ENOMEM; goto cleanup_wq_flip; } =20 - display->wq.unordered =3D alloc_workqueue("display_unordered", 0, 0); + display->wq.unordered =3D alloc_workqueue("display_unordered", WQ_PERCPU,= 0); if (!display->wq.unordered) { ret =3D -ENOMEM; goto cleanup_wq_cleanup; diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915= _driver.c index 0f33cdc11736..380cb20a47c6 100644 --- a/drivers/gpu/drm/i915/i915_driver.c +++ b/drivers/gpu/drm/i915/i915_driver.c @@ -143,7 +143,8 @@ static int i915_workqueues_init(struct drm_i915_private= *dev_priv) * to be scheduled on the system_percpu_wq before moving to a driver * instance due deprecation of flush_scheduled_work(). */ - dev_priv->unordered_wq =3D alloc_workqueue("i915-unordered", 0, 0); + dev_priv->unordered_wq =3D alloc_workqueue("i915-unordered", WQ_PERCPU, + 0); if (dev_priv->unordered_wq =3D=3D NULL) goto out_free_wq; =20 diff --git a/drivers/gpu/drm/i915/selftests/i915_sw_fence.c b/drivers/gpu/d= rm/i915/selftests/i915_sw_fence.c index 8f5ce71fa453..b81d65c77458 100644 --- a/drivers/gpu/drm/i915/selftests/i915_sw_fence.c +++ b/drivers/gpu/drm/i915/selftests/i915_sw_fence.c @@ -526,7 +526,7 @@ static int test_ipc(void *arg) struct workqueue_struct *wq; int ret =3D 0; =20 - wq =3D alloc_workqueue("i1915-selftest", 0, 0); + wq =3D alloc_workqueue("i1915-selftest", WQ_PERCPU, 0); if (wq =3D=3D NULL) return -ENOMEM; =20 diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu= /drm/i915/selftests/mock_gem_device.c index fb8751bd5df0..684e6ca0f960 100644 --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c @@ -221,7 +221,7 @@ struct drm_i915_private *mock_gem_device(void) if (!i915->wq) goto err_drv; =20 - i915->unordered_wq =3D alloc_workqueue("mock-unordered", 0, 0); + i915->unordered_wq =3D alloc_workqueue("mock-unordered", WQ_PERCPU, 0); if (!i915->unordered_wq) goto err_wq; =20 --=20 2.51.0