From nobody Thu Dec 18 03:20:21 2025 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59AFA33B95B for ; Fri, 31 Oct 2025 08:05:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761897926; cv=none; b=Fhm+P6aNVCt5RXE5vKNtD6QCQmA1mVW4Jd3bpd4VG1CdK2Ht0zAHCCXS1aPa5p+MNP8U+LCCSj3wMsEbc3oeD6XsZhc+tMnrB1CqXh72yXRhdrJ8S+tg+BQWnuXvMkScqjrPqzcg0DVHgp1dKHmOle9SebXF40BrY5JKblqM70c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761897926; c=relaxed/simple; bh=tzEL/+eFohUsoGJMjgGf+3hkw6vtFhHimprapHHcNmc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Tl9hWqhlMnop3KjCrGtXJeGXg1nMebt/53FpGWbd08u5oEQ/qwJJstDo9IdGSs+dYnFh5aEXn9ApmNaUi2CvhJ/f1gRY9TUIwQ1IwqF5Zy9ik4vB9gFjHnWLY/ghFKD8HxLBbyFfFf73DSkyI9F7y1hJ6p2oDGjz3sdX4gXgYrA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=gsj4T3/a; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="gsj4T3/a" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id ED5E71A179F; Fri, 31 Oct 2025 08:05:22 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id B7D4760704; Fri, 31 Oct 2025 08:05:22 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id E4EDB1180FB68; Fri, 31 Oct 2025 09:05:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1761897921; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=QwpYT3cQId6kxLH+jgZ2Gj6zVCFYz82Z4Bfwux7jeYg=; b=gsj4T3/a4h8YgXAfUz6sN57qDAwNY8SPd9ng0nHMPSJlN03cRXxKdM4pFkmqgt4Vx5kqaY LeE58wDcGgX+p87+XojUDIvWHrMyG2iBJh+87A5FitdRaCb0HEuEQV88Q/Cy/gLn1Jpt4f OQHsF66BhNOxZRh5wGkCjY8inPg0Frs+bkC1EFuv3NtbYWlgKfUe1xjK+5jw3yLpixkmGc Pi9zaqI63L3JeOyyhBmcDPWeRQWtjaSi/9qJZtultYQA8t7pZDjtcCuUxGJlK+o0bTZY/t 5nhj2yFQMKW0YPwREDXZOs7z3iZVXwtcAj8MRsMoN6U4O4lm6MbJOgKz+ptrww== From: "Bastien Curutchet (eBPF Foundation)" Date: Fri, 31 Oct 2025 09:04:48 +0100 Subject: [PATCH bpf-next v7 12/15] selftests/bpf: test_xsk: Don't exit immediately if validate_traffic fails Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251031-xsk-v7-12-39fe486593a3@bootlin.com> References: <20251031-xsk-v7-0-39fe486593a3@bootlin.com> In-Reply-To: <20251031-xsk-v7-0-39fe486593a3@bootlin.com> To: =?utf-8?q?Bj=C3=B6rn_T=C3=B6pel?= , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Shuah Khan , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer Cc: Thomas Petazzoni , Alexis Lothore , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, "Bastien Curutchet (eBPF Foundation)" X-Mailer: b4 0.14.2 X-Last-TLS-Session-Version: TLSv1.3 __testapp_validate_traffic() calls exit_with_error() on failures. This exits the program immediately. It prevents the following tests from running and isn't compliant with the CI. Return TEST_FAILURE instead of calling exit_with_error(). Release the resource of the 1st thread if a failure happens between its creation and the creation of the second thread. Reviewed-by: Maciej Fijalkowski Signed-off-by: Bastien Curutchet (eBPF Foundation) --- tools/testing/selftests/bpf/test_xsk.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/bpf/test_xsk.c b/tools/testing/selftes= ts/bpf/test_xsk.c index 19182c1d9730191276084acd35da7118780b273e..0b69438826e3bb617f488aa829d= 5f8eb98d2b0f5 100644 --- a/tools/testing/selftests/bpf/test_xsk.c +++ b/tools/testing/selftests/bpf/test_xsk.c @@ -1772,12 +1772,12 @@ static int __testapp_validate_traffic(struct test_s= pec *test, struct ifobject *i err =3D test_spec_set_mtu(test, test->mtu); if (err) { ksft_print_msg("Error, could not set mtu.\n"); - exit_with_error(err); + return TEST_FAILURE; } =20 if (ifobj2) { if (pthread_barrier_init(&barr, NULL, 2)) - exit_with_error(errno); + return TEST_FAILURE; pkt_stream_reset(ifobj2->xsk->pkt_stream); } =20 @@ -1791,8 +1791,12 @@ static int __testapp_validate_traffic(struct test_sp= ec *test, struct ifobject *i =20 if (ifobj2) { pthread_barrier_wait(&barr); - if (pthread_barrier_destroy(&barr)) - exit_with_error(errno); + if (pthread_barrier_destroy(&barr)) { + pthread_kill(t0, SIGUSR1); + clean_sockets(test, ifobj1); + clean_umem(test, ifobj1, NULL); + return TEST_FAILURE; + } =20 /*Spawn TX thread */ pthread_create(&t1, NULL, ifobj2->func_ptr, test); --=20 2.51.0