From nobody Tue Dec 9 02:09:21 2025 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB5D232E133 for ; Fri, 31 Oct 2025 09:05:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901541; cv=none; b=U8/QQtTFjLDywnxWL2TdUkBFWnns/Rs3wU4IZ6TxYUyy+s1eX3fpubXMXDvoLnB3/cOBi8VbRPhTQoc/zp5jkZrf5adM64xtTF18Qz6tflAL+qR37Eq0cB+gEYa7OtYtr3LgFXxEVlsBuoynCSYwba6ll2jK0CxJT6B3h40BYZo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901541; c=relaxed/simple; bh=nro5ffECISZBxP47ojXf217UYA8LT/9kG6EOdNqFQ4w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HZCWr4A8RqdOUHj0RUn2WiUK1OXkZEL4ZcB8FxDzd1VJPH1wWi2ZHls7GuN6DDx3tPElyLHKMbNNMzmfaNM5ivGHq6ZBpje3G5LrV9Rdf+/mIZoampZimQDZyUxDcvt21DYLLltvunpnoMBCvFo0XSBYLeCpfbDY9wuE7iw1c5I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=In7LF65w; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="In7LF65w" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3f99ac9acc4so1980614f8f.3 for ; Fri, 31 Oct 2025 02:05:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761901538; x=1762506338; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=18hreP4xxLaFHfo0ItO/fnmo3JBInKcj9IQEHPw+gD0=; b=In7LF65wL29ARj9kwVZq1dwimDbZTe1jFDIk700bkD1BDSt4bt+xcHvN5SHblmXPjJ TOuixSk9tVuEDHIAqzafoR2IrtPsfZEDAu3pGqVTkZ3vG1Xh5tdMdv1cbDQAFlZ2Lsfm Ig+7Ytp3dAb0LEWCcikK2A4i7UoILT6via6Gs2O8H4ubAOObtNRl1qfkpYNP72+G33f1 xtYUphof77p//bFPy/49B13JhnCxkIeRzGJw/RQuywYR7ZKgwSiIZTfBfBLkA/xXkAbi Rb+EWlikXpkhV+FIO6eLJ2lfnycWkKd2R3EDchQ700BsoRoi08s+2JDJcjbBRBVmSgtw 3YzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761901538; x=1762506338; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=18hreP4xxLaFHfo0ItO/fnmo3JBInKcj9IQEHPw+gD0=; b=T9AUNtNRP5jjhyvag0pODocDwDe93gR016tnYCkgUFK3aL2SpHGFCrUQcrHdhPEbwQ qTBrWHq5mc9rUG0SY4YPNIRXjPnPALf0eb1fQYVjyBp51DDw4jviSXecXevSCssz76by yZOMsEnWhddkJcSYl9u9coJeugR+Uo2qBhUrDBLFxrmRDEKtRnaBB/U61hYeMyU/lffr x7FdqMxA0tIznlGfz08UsK4PfpXPmj15f7xxWaOA2onk5Kss/TezCCce4SGsfeY8xcLl sseZbQ7ywd5XD5XAk8FlrCAfvuKAZd3Qt+8vlHl6u1WmrG2jgCaOsFw8VPBIP/JjgtMM ynVw== X-Gm-Message-State: AOJu0Yz/o+IzOnoAQaberiRcpYrtyP0b49hyUs7o7+qeJLverokSa5/R qG+c9z1vq0Gn99+JYxcnYOR5z4PU+5nhHiEMtXEvZTGUTdKbVHu/3Xft X-Gm-Gg: ASbGncsiro5iDi32xaRfHVeh9ffMBeq+pQLIBmNvqoPTX5izYyy0p6Y1hnMRaKLiJ9B Ko4ot7q0jeyROvvVu6QGXXX4Arc08BkBuQOae89b9I0414LXcoLKnqrimAqo5EUhUkQwsLNeLl7 s+krMasublVO2ITJXzgW4WL+Qzf7b+3GAxwCmHqbJWdiEiZPdlA7U4ab5jdE6Pl7fjMU49Vy/DT XppXyJjNDuFlWnkbxNtryPwzt2w70Yf026gZLknUZiveIXmX46WhWhInGbzodZiWQYqyjMIkWSd +PsfNK/5x66NStzfk/PXnNWS5myR8kgeZqkdgS62NCyQa85PkcbHVxQxCuhedFt9KvaYT/6DwJt u+P+4L5E9esVt3VJ63fC1zHFdF/58tMzT5/TmAAGf7mWO4wYANhDMpm6GwNtn/Zu9HEjvyts+Mk gRgG2HJDFziFTvaEdQ18Qoo+6v+LBfVYorPl+5eNUq+g== X-Google-Smtp-Source: AGHT+IHNoK3cnUIF6KdTyd7IGy8y4YEq1qFpnGQ1VkRb4cjN2zo87WIQY2U8y6o5zmD6jrgtQ6cpUg== X-Received: by 2002:a5d:64e9:0:b0:426:ff7c:86e4 with SMTP id ffacd0b85a97d-429bd683568mr2152208f8f.19.1761901537817; Fri, 31 Oct 2025 02:05:37 -0700 (PDT) Received: from ipedrosa-thinkpadx1carbongen12.rmtes.csb ([5.225.139.156]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477289adaf8sm93454475e9.7.2025.10.31.02.05.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 02:05:37 -0700 (PDT) From: Iker Pedrosa Date: Fri, 31 Oct 2025 10:05:17 +0100 Subject: [PATCH v4 1/3] dt-bindings: display: sitronix,st7920: Add DT schema Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251031-st7920-v4-1-35291f8076b2@gmail.com> References: <20251031-st7920-v4-0-35291f8076b2@gmail.com> In-Reply-To: <20251031-st7920-v4-0-35291f8076b2@gmail.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Javier Martinez Canillas , Iker Pedrosa Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.2 Add binding for Sitronix ST7920 display. Signed-off-by: Iker Pedrosa Reviewed-by: Krzysztof Kozlowski --- .../bindings/display/sitronix,st7920.yaml | 58 ++++++++++++++++++= ++++ 1 file changed, 58 insertions(+) diff --git a/Documentation/devicetree/bindings/display/sitronix,st7920.yaml= b/Documentation/devicetree/bindings/display/sitronix,st7920.yaml new file mode 100644 index 0000000000000000000000000000000000000000..c4f006fc41e1f472939725bd82b= 86a649f9b3f56 --- /dev/null +++ b/Documentation/devicetree/bindings/display/sitronix,st7920.yaml @@ -0,0 +1,58 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/sitronix,st7920.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sitronix ST7920 LCD Display Controllers + +maintainers: + - Iker Pedrosa + +description: + The Sitronix ST7920 is a controller for monochrome dot-matrix graphical = LCDs, + most commonly used for 128x64 pixel displays. + +properties: + compatible: + const: sitronix,st7920 + + reg: + maxItems: 1 + + vdd-supply: + description: Regulator that provides 5V Vdd power supply + + reset-gpios: + maxItems: 1 + + spi-max-frequency: + maximum: 600000 + +required: + - compatible + - reg + - spi-max-frequency + +allOf: + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +unevaluatedProperties: false + +examples: + - | + #include + + spi { + #address-cells =3D <1>; + #size-cells =3D <0>; + + display@0 { + compatible =3D "sitronix,st7920"; + reg =3D <0>; + vdd-supply =3D <®_5v>; + reset-gpios =3D <&gpio 25 GPIO_ACTIVE_LOW>; + spi-max-frequency =3D <600000>; + spi-cs-high; + }; + }; --=20 2.51.0 From nobody Tue Dec 9 02:09:21 2025 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D96032E6B0 for ; Fri, 31 Oct 2025 09:05:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901544; cv=none; b=kSh5SxQC+4aUlwNIvcEejACfj7Q4qAnM9jvZL19SNYfnL/V0B6vblpbvZ049CBkwibE+mBv5Y5MXFNrXnScKNqx4smpkqRpr6U9DGlrLcJ2CCMeYEuugp/t5Qd5yqeMAakduKluItrChau45nto3FhXClRm1CmapsQpRkSxPKMQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901544; c=relaxed/simple; bh=OFd09NB8tWmKB8bAc+9gpKcnimj4aCNXkz1JvYjyogU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=idtWkdqCJAYIcwmrSor5pHxzBHMEtVTxzvaNXGgDnxTpI6JHZ1kNg1LUevWNRhlk9edl8jjQsuOs+wvsOr3zWY4dH6F810oQCqROuFP7gbhbnLRmjK7+IguVbMkPlVHNuC7rDGQlS/zvDS3DDTgW8d4bJ97vol5D1nogdpkxMW4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YhRQJ3Nr; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YhRQJ3Nr" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4770c34ca8eso17633455e9.0 for ; Fri, 31 Oct 2025 02:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761901540; x=1762506340; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=b22T8s85U82977X/0jq5K3b8edK1tltjlhXlFn6D+Js=; b=YhRQJ3Nr6STN4SBnSGMgQFLHUpOTgzTVmo6vXsUN27Ug/6eNTrL8eNzrszqeR3luHt ElbCqup40VpBwc/zLP8GmAtfUmzH0WokfH5UZgXx2W6tLvpc1r0O5ekalzhPYVePKpv6 sDLi7s49SjepQPuj9b/9nXIa3/aQal63bwAXzwMqzURByjRgQBqbimS9bvTeu/OZrXxI fp7tekP3QP6jHxhyZ9SsSlnOi+TF9Z8crdQJZweQ1Lou9SCM8h6EFEWiDDWjVgZ1wty5 etP6+qNQh866jesCCVnJuZYH3iwassduPja8MhxulhKbfzD8bQu7RiGQUurQCkjXlnGY uz5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761901540; x=1762506340; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b22T8s85U82977X/0jq5K3b8edK1tltjlhXlFn6D+Js=; b=g7YA8KHA7LmS9ErbjFign7zO5b0C6OuhExSjcCtHAf542XW83nVcDv03ZY2z2bSTMd eePGQ3kulO1d6+DPCK/lReYPvlvj78rPDs22BxFIDiEdvPxCePAx7bzbG4m6uasJoJdX eAMCOhzti/8108HkEjr4xrH0KmB8Fq8ZI3hOf4mVOaZ2E7VcMJgmcimVkk0ao/SnH9df eLLNEFvCY08hq8CUDYMV2/MxXvJCnVYhOUURCS1yZ7jsLg9CfQgWGj7BE+EUV3kS5/g4 Jbw3WNOXqbKDG+Nb/rZw6AM+IbRcOgL2XZcWo4ntbBHHbhZ+bg8CXt6WLIxm94r8Dgk5 Jk5g== X-Gm-Message-State: AOJu0YwgEAlXrfb0n5I9gnBJuor04QRBFKmfanNpQ50131nudGf7WXbq IsK6A4OWOce3Bv2At5PQ/Y56K9dprfY51Qpnqic3x2kd72GeW4gxBi8L X-Gm-Gg: ASbGncv0nUC0nWbrFWNTy+iUSYBABiSu2FMufRu+5a2bDLppQcalhEGV3rgeUw14jUX Bhi8Vc7TaQAei2mR0e0omyEdl6V9p6aZfJDIK3xbzyUmiVq+a9YC+SDoHqHbmoSeJxLjDSbf5MW 5N6q+hoYxqBlwh/4RMwOwbwd2y+M56Z8jOJry8/bTbAkE02S6E4XyFBRbmfI7HXiJHFKfIBE50o rFkDYNhDAm6ubKuhlDSHLOKG7HzXMfii1rSyBin+nq3ic5Jhu70XgHpgDjJYKZi8iUHCfXThT12 Wucp0dJ9e2z123N6nn7m8RQ1jZ7FQ9oPOyctBdSEU95tr2maCpM62X3ltagdHMuHbkDCLjyHW0y Er0mQHttsbJqSOvCqH+b239igHRfEz2T0+rfrt5W3NIXt6ThvWisrKnGLG7AIvZpKXi01NCfLt/ KdlAx50y9Id0+kRFijjwlJgUdmzOmSAdVhbdnHB5KVyxAkSbXof97s X-Google-Smtp-Source: AGHT+IH/GbUD3Q/jFvdqricLcGuojVJS+V99U6q90u3Gi4DSAoE4cbUKTQ+8ydsmfo+uKnn+2IMKrQ== X-Received: by 2002:a05:600c:5487:b0:46f:b42e:e3a0 with SMTP id 5b1f17b1804b1-477308c9016mr24028455e9.41.1761901539120; Fri, 31 Oct 2025 02:05:39 -0700 (PDT) Received: from ipedrosa-thinkpadx1carbongen12.rmtes.csb ([5.225.139.156]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477289adaf8sm93454475e9.7.2025.10.31.02.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 02:05:38 -0700 (PDT) From: Iker Pedrosa Date: Fri, 31 Oct 2025 10:05:18 +0100 Subject: [PATCH v4 2/3] drm: Add driver for Sitronix ST7920 LCD displays Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251031-st7920-v4-2-35291f8076b2@gmail.com> References: <20251031-st7920-v4-0-35291f8076b2@gmail.com> In-Reply-To: <20251031-st7920-v4-0-35291f8076b2@gmail.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Javier Martinez Canillas , Iker Pedrosa Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.2 Add a new DRM/KMS driver for displays using the Sitronix ST7920 controller connected via the SPI bus. This provides a standard framebuffer interface for these common monochrome LCDs. Signed-off-by: Iker Pedrosa --- drivers/gpu/drm/sitronix/Kconfig | 10 + drivers/gpu/drm/sitronix/Makefile | 1 + drivers/gpu/drm/sitronix/st7920.c | 905 ++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 916 insertions(+) diff --git a/drivers/gpu/drm/sitronix/Kconfig b/drivers/gpu/drm/sitronix/Kc= onfig index 6de7d92d9b74c72746915b945869dba91f161d2b..f14115350069849b668d75188f6= d504d56fa3dda 100644 --- a/drivers/gpu/drm/sitronix/Kconfig +++ b/drivers/gpu/drm/sitronix/Kconfig @@ -40,3 +40,13 @@ config DRM_ST7735R =20 If M is selected the module will be called st7735r. =20 +config DRM_ST7920 + tristate "DRM support for Sitronix ST7920 LCD displays" + depends on DRM && SPI && MMU + select DRM_GEM_SHMEM_HELPER + select DRM_KMS_HELPER + select REGMAP_SPI + help + DRM driver for the ST7920 Sitronix LCD controllers. + + If M is selected the module will be called st7920. diff --git a/drivers/gpu/drm/sitronix/Makefile b/drivers/gpu/drm/sitronix/M= akefile index bd139e5a6995fa026cc635b3c29782473d1efad7..2f064a518121bfee3cca73acd42= 589e8c54cd4d7 100644 --- a/drivers/gpu/drm/sitronix/Makefile +++ b/drivers/gpu/drm/sitronix/Makefile @@ -1,3 +1,4 @@ obj-$(CONFIG_DRM_ST7571_I2C) +=3D st7571-i2c.o obj-$(CONFIG_DRM_ST7586) +=3D st7586.o obj-$(CONFIG_DRM_ST7735R) +=3D st7735r.o +obj-$(CONFIG_DRM_ST7920)) +=3D st7920.o diff --git a/drivers/gpu/drm/sitronix/st7920.c b/drivers/gpu/drm/sitronix/s= t7920.c new file mode 100644 index 0000000000000000000000000000000000000000..15b6f99e64313cbeba474231c4e= f8649e8e50f9d --- /dev/null +++ b/drivers/gpu/drm/sitronix/st7920.c @@ -0,0 +1,905 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * DRM driver for Sitronix ST7920 LCD displays + * + * Copyright 2025 Iker Pedrosa + * + */ + +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define DRIVER_NAME "sitronix_st7920" +#define DRIVER_DESC "DRM driver for Sitronix ST7920 LCD displays" +#define DRIVER_DATE "20250723" +#define DRIVER_MAJOR 1 +#define DRIVER_MINOR 0 + +/* Display organization */ +#define DRM_PITCH 16 +#define DRM_SCANLINES 64 +#define BYTES_IN_DISPLAY (DRM_PITCH * DRM_SCANLINES) +#define BYTES_IN_SEGMENT 2 +#define PIXELS_PER_SEGMENT (BYTES_IN_SEGMENT * 8) + +/* Sync sequence */ +#define SYNC_BITS 0xF8 +#define RW_HIGH 0x04 +#define RS_HIGH 0x02 + +/* Commands */ +#define SET_DISPLAY_ON 0x0C +#define SET_DISPLAY_OFF 0x08 +#define SET_DISPLAY_CLEAR 0x01 +#define SET_BASIC_INSTRUCTION_SET 0x30 +#define SET_EXT_INSTRUCTION_SET 0x34 +#define SET_GRAPHICS_DISPLAY 0x36 +#define SET_GDRAM_ADDRESS 0x80 +#define SET_GDRAM_DATA 0xFF /* Driver internal command */ + +/* Masks */ +#define HIGH_DATA_MASK 0xF0 +#define LOW_DATA_MASK 0x0F +#define TOP_VERTICAL_ADDRESS 0x80 +#define BOTTOM_VERTICAL_ADDRESS 0x60 +#define TOP_HORIZONTAL_ADDRESS 0x00 +#define BOTTOM_HORIZONTAL_ADDRESS 0x80 + +#define CMD_SIZE 35 + +enum st7920_variants { + /* st7920 family */ + ST7920_ID +}; + +struct spi7920_error { + int errno; +}; + +struct st7920_deviceinfo { + u32 default_dclk_div; + u32 default_dclk_frq; + u32 default_width; + u32 default_height; +}; + +struct st7920_device { + struct drm_device drm; + struct device *dev; + struct drm_display_mode mode; + struct drm_plane primary_plane; + struct drm_crtc crtc; + struct drm_encoder encoder; + struct drm_connector connector; + struct spi_device *spi; + + struct regmap *regmap; + + const struct st7920_deviceinfo *device_info; + + struct gpio_desc *reset_gpio; + + u32 height; + u32 width; +}; + +const struct st7920_deviceinfo st7920_variants[] =3D { + [ST7920_ID] =3D { + .default_width =3D 128, + .default_height =3D 64, + } +}; +EXPORT_SYMBOL_NS_GPL(st7920_variants, DRM_ST7920); + +struct st7920_plane_state { + struct drm_shadow_plane_state base; + /* Intermediate buffer to convert pixels from XRGB8888 to HW format */ + u8 *buffer; +}; + +struct st7920_crtc_state { + struct drm_crtc_state base; + /* Buffer to store pixels in HW format and written to the panel */ + u8 *data_array; +}; + +static inline struct st7920_plane_state *to_st7920_plane_state(struct drm_= plane_state *state) +{ + return container_of(state, struct st7920_plane_state, base.base); +} + +static inline struct st7920_crtc_state *to_st7920_crtc_state(struct drm_cr= tc_state *state) +{ + return container_of(state, struct st7920_crtc_state, base); +} + +static inline struct st7920_device *drm_to_st7920(struct drm_device *drm) +{ + return container_of(drm, struct st7920_device, drm); +} + +static int st7920_store_gdram_address(const void *data, u8 *reg) +{ + const u8 y_addr =3D *(const u8 *)data; + bool bottom_screen =3D (y_addr >=3D 32); + int i =3D 0; + + reg[i++] =3D SYNC_BITS; + /* Set vertical address */ + if (!bottom_screen) + reg[i++] =3D TOP_VERTICAL_ADDRESS + (*(uint8_t *)data & HIGH_DATA_MASK); + else + reg[i++] =3D BOTTOM_VERTICAL_ADDRESS + (*(uint8_t *)data & HIGH_DATA_MAS= K); + + reg[i++] =3D *(uint8_t *)data << 4; + /* Set horizontal address */ + reg[i++] =3D SET_GDRAM_ADDRESS; + if (!bottom_screen) + reg[i++] =3D TOP_HORIZONTAL_ADDRESS; + else + reg[i++] =3D BOTTOM_HORIZONTAL_ADDRESS; + + return i; +} + +static int st7920_store_gdram_data(const void *data, u8 *reg) +{ + const u8 *line_data =3D data; + int i =3D 0, j =3D 0; + + reg[i++] =3D SYNC_BITS | RS_HIGH; + + for (j =3D 0; j < 16; j++) { + reg[i++] =3D line_data[j] & 0xF0; + reg[i++] =3D (line_data[j] << 4) & 0xF0; + } + + return i; +} + +static int st7920_store_others(int cmd, const void *data, u8 *reg) +{ + int i =3D 0; + + reg[i++] =3D SYNC_BITS; + reg[i++] =3D cmd & HIGH_DATA_MASK; + reg[i++] =3D (cmd & LOW_DATA_MASK) << 4; + + return i; +} + +static void st7920_spi_write(struct spi_device *spi, int cmd, const void *= data, + int delay_us, struct spi7920_error *err) +{ + u8 reg[CMD_SIZE] =3D {0}; + int size =3D 0; + int ret; + + if (err->errno) + return; + + /* + * First the sync bits are sent: 11111WS0. + * Where W is the read/write (RW) bit and S is the register/data (RS) bit. + * Then, every 8 bits instruction/data will be separated into 2 groups. + * Higher 4 bits (DB7~DB4) will be placed in the first section followed by + * 4 '0's. And lower 4 bits (DB3~DB0) will be placed in the second section + * followed by 4 '0's. + */ + if (cmd =3D=3D SET_GDRAM_ADDRESS) + size =3D st7920_store_gdram_address(data, reg); + else if (cmd =3D=3D SET_GDRAM_DATA) + size =3D st7920_store_gdram_data(data, reg); + else + size =3D st7920_store_others(cmd, data, reg); + + ret =3D spi_write(spi, reg, size); + if (ret) { + err->errno =3D ret; + return; + } + + if (delay_us) + udelay(delay_us); +} + +static const struct regmap_config st7920_spi_regmap_config =3D { + .reg_bits =3D 8, + .val_bits =3D 8, +}; + +static const struct of_device_id st7920_of_match[] =3D { + /* st7920 family */ + { + .compatible =3D "sitronix,st7920", + .data =3D &st7920_variants[ST7920_ID], + }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, st7920_of_match); + +/* + * The SPI core always reports a MODALIAS uevent of the form "spi:", = even + * if the device was registered via OF. This means that the module will no= t be + * auto loaded, unless it contains an alias that matches the MODALIAS repo= rted. + * + * To workaround this issue, add a SPI device ID table. Even when this sho= uld + * not be needed for this driver to match the registered SPI devices. + */ +static const struct spi_device_id st7920_spi_id[] =3D { + /* st7920 family */ + { "st7920", ST7920_ID }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(spi, st7920_spi_id); + +static void st7920_power_on(struct st7920_device *st7920, + struct spi7920_error *err) +{ + st7920_spi_write(st7920->spi, SET_DISPLAY_ON, NULL, 72, err); +} + +static void st7920_power_off(struct st7920_device *st7920, + struct spi7920_error *err) +{ + st7920_spi_write(st7920->spi, SET_DISPLAY_CLEAR, NULL, 1600, err); + st7920_spi_write(st7920->spi, SET_DISPLAY_OFF, NULL, 72, err); +} + +static void st7920_hw_reset(struct st7920_device *st7920) +{ + if (!st7920->reset_gpio) + return; + + gpiod_set_value_cansleep(st7920->reset_gpio, 0); + usleep_range(15, 20); + gpiod_set_value_cansleep(st7920->reset_gpio, 1); + msleep(40); +} + +static int st7920_init(struct st7920_device *st7920) +{ + struct spi7920_error err =3D {0}; + + st7920_spi_write(st7920->spi, SET_BASIC_INSTRUCTION_SET, NULL, 72, &err); + st7920_power_on(st7920, &err); + st7920_spi_write(st7920->spi, SET_GRAPHICS_DISPLAY, NULL, 72, &err); + st7920_spi_write(st7920->spi, SET_DISPLAY_CLEAR, NULL, 1600, &err); + + return err.errno; +} + +static int st7920_update_rect(struct st7920_device *st7920, + struct drm_rect *rect, u8 *buf, + u8 *data_array) +{ + struct spi7920_error err; + u32 array_idx =3D 0; + int i, j; + + /* + * The screen is divided in 64(Y)x8(X) segments and each segment is + * further divided in 2 bytes (D15~D0). + * + * Segment 0x0 is in the top-right corner, while segment 63x15 is in the + * bottom-left. They would be displayed in the screen in the following wa= y: + * 0x0 0x1 0x2 ... 0x15 + * 1x0 1x1 1x2 ... 1x15 + * ... + * 63x0 63x1 63x2 ... 63x15 + * + * The data in each byte is big endian. + */ + + for (i =3D 0; i < DRM_SCANLINES; i++) { + u8 *line_start =3D buf + (i * DRM_PITCH); + u8 line_buffer[DRM_PITCH]; + + for (j =3D 0; j < DRM_PITCH; j++) { + line_buffer[j] =3D bitrev8(line_start[j]); + data_array[array_idx++] =3D line_buffer[j]; + } + + st7920_spi_write(st7920->spi, SET_GDRAM_ADDRESS, &i, 72, &err); + st7920_spi_write(st7920->spi, SET_GDRAM_DATA, line_buffer, 72, &err); + } + + return err.errno; +} + +static void st7920_clear_screen(struct st7920_device *st7920, u8 *data_arr= ay) +{ + struct spi7920_error err; + + memset(data_array, 0, BYTES_IN_DISPLAY); + + st7920_spi_write(st7920->spi, SET_DISPLAY_CLEAR, NULL, 1600, &err); +} + +static int st7920_fb_blit_rect(struct drm_framebuffer *fb, + const struct iosys_map *vmap, + struct drm_rect *rect, + u8 *buf, u8 *data_array, + struct drm_format_conv_state *fmtcnv_state) +{ + struct st7920_device *st7920 =3D drm_to_st7920(fb->dev); + struct iosys_map dst; + unsigned int dst_pitch; + int ret; + + /* Align y to display page boundaries */ + rect->y1 =3D round_down(rect->y1, PIXELS_PER_SEGMENT); + rect->y2 =3D min_t(unsigned int, round_up(rect->y2, PIXELS_PER_SEGMENT), = st7920->height); + + dst_pitch =3D DIV_ROUND_UP(drm_rect_width(rect), 8); + + iosys_map_set_vaddr(&dst, buf); + drm_fb_xrgb8888_to_mono(&dst, &dst_pitch, vmap, fb, rect, fmtcnv_state); + + ret =3D st7920_update_rect(st7920, rect, buf, data_array); + + return ret; +} + +static int st7920_primary_plane_atomic_check(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct drm_device *drm =3D plane->dev; + struct st7920_device *st7920 =3D drm_to_st7920(drm); + struct drm_plane_state *plane_state =3D drm_atomic_get_new_plane_state(st= ate, plane); + struct st7920_plane_state *st7920_state =3D to_st7920_plane_state(plane_s= tate); + struct drm_shadow_plane_state *shadow_plane_state =3D &st7920_state->base; + struct drm_crtc *crtc =3D plane_state->crtc; + struct drm_crtc_state *crtc_state =3D NULL; + const struct drm_format_info *fi; + unsigned int pitch; + int ret; + + if (crtc) + crtc_state =3D drm_atomic_get_new_crtc_state(state, crtc); + + ret =3D drm_atomic_helper_check_plane_state(plane_state, crtc_state, + DRM_PLANE_NO_SCALING, + DRM_PLANE_NO_SCALING, + false, false); + if (ret) + return ret; + else if (!plane_state->visible) + return 0; + + fi =3D drm_format_info(DRM_FORMAT_R1); + if (!fi) + return -EINVAL; + + pitch =3D drm_format_info_min_pitch(fi, 0, st7920->width); + + if (plane_state->fb->format !=3D fi) { + void *buf; + + /* format conversion necessary; reserve buffer */ + buf =3D drm_format_conv_state_reserve(&shadow_plane_state->fmtcnv_state, + pitch, GFP_KERNEL); + if (!buf) + return -ENOMEM; + } + + st7920_state->buffer =3D kcalloc(pitch, st7920->height, GFP_KERNEL); + if (!st7920_state->buffer) + return -ENOMEM; + + return 0; +} + +static void st7920_primary_plane_atomic_update(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct drm_plane_state *plane_state =3D drm_atomic_get_new_plane_state(st= ate, plane); + struct drm_plane_state *old_plane_state =3D drm_atomic_get_old_plane_stat= e(state, plane); + struct drm_shadow_plane_state *shadow_plane_state =3D to_drm_shadow_plane= _state(plane_state); + struct drm_crtc_state *crtc_state =3D drm_atomic_get_new_crtc_state(state= , plane_state->crtc); + struct st7920_crtc_state *st7920_crtc_state =3D to_st7920_crtc_state(crt= c_state); + struct st7920_plane_state *st7920_plane_state =3D to_st7920_plane_state(p= lane_state); + struct drm_framebuffer *fb =3D plane_state->fb; + struct drm_atomic_helper_damage_iter iter; + struct drm_device *drm =3D plane->dev; + struct drm_rect dst_clip; + struct drm_rect damage; + int idx; + int ret; + + if (!drm_dev_enter(drm, &idx)) + return; + + if (drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE)) + goto out_drm_dev_exit; + + drm_atomic_helper_damage_iter_init(&iter, old_plane_state, plane_state); + drm_atomic_for_each_plane_damage(&iter, &damage) { + dst_clip =3D plane_state->dst; + + if (!drm_rect_intersect(&dst_clip, &damage)) + continue; + + ret =3D st7920_fb_blit_rect(fb, &shadow_plane_state->data[0], &dst_clip, + st7920_plane_state->buffer, + st7920_crtc_state->data_array, + &shadow_plane_state->fmtcnv_state); + if (ret) + drm_err_once(plane->dev, "Failed to write to device: %d.\n", ret); + } + + drm_gem_fb_end_cpu_access(fb, DMA_FROM_DEVICE); + +out_drm_dev_exit: + drm_dev_exit(idx); +} + +static void st7920_primary_plane_atomic_disable(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct drm_device *drm =3D plane->dev; + struct st7920_device *st7920 =3D drm_to_st7920(drm); + struct drm_plane_state *plane_state =3D drm_atomic_get_new_plane_state(st= ate, plane); + struct drm_crtc_state *crtc_state; + struct st7920_crtc_state *st7920_crtc_state; + int idx; + + if (!plane_state->crtc) + return; + + crtc_state =3D drm_atomic_get_new_crtc_state(state, plane_state->crtc); + st7920_crtc_state =3D to_st7920_crtc_state(crtc_state); + + if (!drm_dev_enter(drm, &idx)) + return; + + st7920_clear_screen(st7920, st7920_crtc_state->data_array); + + drm_dev_exit(idx); +} + +/* Called during init to allocate the plane's atomic state. */ +static void st7920_primary_plane_reset(struct drm_plane *plane) +{ + struct st7920_plane_state *st7920_state; + + drm_WARN_ON_ONCE(plane->dev, plane->state); + + st7920_state =3D kzalloc(sizeof(*st7920_state), GFP_KERNEL); + if (!st7920_state) + return; + + __drm_gem_reset_shadow_plane(plane, &st7920_state->base); +} + +static struct drm_plane_state *st7920_primary_plane_duplicate_state(struct= drm_plane *plane) +{ + struct drm_shadow_plane_state *new_shadow_plane_state; + struct st7920_plane_state *old_st7920_state; + struct st7920_plane_state *st7920_state; + + if (drm_WARN_ON_ONCE(plane->dev, !plane->state)) + return NULL; + + old_st7920_state =3D to_st7920_plane_state(plane->state); + st7920_state =3D kmemdup(old_st7920_state, sizeof(*st7920_state), GFP_KER= NEL); + if (!st7920_state) + return NULL; + + /* The buffer is not duplicated and is allocated in .atomic_check */ + st7920_state->buffer =3D NULL; + + new_shadow_plane_state =3D &st7920_state->base; + + __drm_gem_duplicate_shadow_plane_state(plane, new_shadow_plane_state); + + return &new_shadow_plane_state->base; +} + +static void st7920_primary_plane_destroy_state(struct drm_plane *plane, + struct drm_plane_state *state) +{ + struct st7920_plane_state *st7920_state =3D to_st7920_plane_state(state); + + kfree(st7920_state->buffer); + + __drm_gem_destroy_shadow_plane_state(&st7920_state->base); + + kfree(st7920_state); +} + +static const struct drm_plane_helper_funcs st7920_primary_plane_helper_fun= cs =3D { + DRM_GEM_SHADOW_PLANE_HELPER_FUNCS, + .atomic_check =3D st7920_primary_plane_atomic_check, + .atomic_update =3D st7920_primary_plane_atomic_update, + .atomic_disable =3D st7920_primary_plane_atomic_disable, +}; + +static const struct drm_plane_funcs st7920_primary_plane_funcs =3D { + .update_plane =3D drm_atomic_helper_update_plane, + .disable_plane =3D drm_atomic_helper_disable_plane, + .reset =3D st7920_primary_plane_reset, + .atomic_duplicate_state =3D st7920_primary_plane_duplicate_state, + .atomic_destroy_state =3D st7920_primary_plane_destroy_state, + .destroy =3D drm_plane_cleanup, +}; + +static enum drm_mode_status st7920_crtc_mode_valid(struct drm_crtc *crtc, + const struct drm_display_mode *mode) +{ + struct st7920_device *st7920 =3D drm_to_st7920(crtc->dev); + + return drm_crtc_helper_mode_valid_fixed(crtc, mode, &st7920->mode); +} + +static int st7920_crtc_atomic_check(struct drm_crtc *crtc, + struct drm_atomic_state *state) +{ + struct drm_crtc_state *crtc_state =3D drm_atomic_get_new_crtc_state(state= , crtc); + struct st7920_crtc_state *st7920_state =3D to_st7920_crtc_state(crtc_stat= e); + int ret; + + ret =3D drm_crtc_helper_atomic_check(crtc, state); + if (ret) + return ret; + + st7920_state->data_array =3D kmalloc(BYTES_IN_DISPLAY, GFP_KERNEL); + if (!st7920_state->data_array) + return -ENOMEM; + + return 0; +} + +static void st7920_crtc_atomic_enable(struct drm_crtc *crtc, + struct drm_atomic_state *state) +{ + struct drm_device *drm =3D crtc->dev; + struct st7920_device *st7920 =3D drm_to_st7920(drm); + int idx; + int ret; + + if (!drm_dev_enter(drm, &idx)) + return; + + st7920_hw_reset(st7920); + + ret =3D st7920_init(st7920); + if (ret) + dev_err(st7920->dev, "Failed to init hardware: %d\n", ret); + + drm_dev_exit(idx); +} + +static void st7920_crtc_atomic_disable(struct drm_crtc *crtc, + struct drm_atomic_state *state) +{ + struct spi7920_error err =3D {0}; + struct drm_device *drm =3D crtc->dev; + struct st7920_device *st7920 =3D drm_to_st7920(drm); + int idx; + + drm_dev_enter(drm, &idx); + + st7920_power_off(st7920, &err); + + drm_dev_exit(idx); +} + +/* Called during init to allocate the CRTC's atomic state. */ +static void st7920_crtc_reset(struct drm_crtc *crtc) +{ + struct st7920_crtc_state *st7920_state; + + drm_WARN_ON_ONCE(crtc->dev, crtc->state); + + st7920_state =3D kzalloc(sizeof(*st7920_state), GFP_KERNEL); + if (!st7920_state) + return; + + __drm_atomic_helper_crtc_reset(crtc, &st7920_state->base); +} + +static struct drm_crtc_state *st7920_crtc_duplicate_state(struct drm_crtc = *crtc) +{ + struct st7920_crtc_state *old_st7920_state; + struct st7920_crtc_state *st7920_state; + + if (drm_WARN_ON_ONCE(crtc->dev, !crtc->state)) + return NULL; + + old_st7920_state =3D to_st7920_crtc_state(crtc->state); + st7920_state =3D kmemdup(old_st7920_state, sizeof(*st7920_state), GFP_KER= NEL); + if (!st7920_state) + return NULL; + + /* The buffer is not duplicated and is allocated in .atomic_check */ + st7920_state->data_array =3D NULL; + + __drm_atomic_helper_crtc_duplicate_state(crtc, &st7920_state->base); + + return &st7920_state->base; +} + +static void st7920_crtc_destroy_state(struct drm_crtc *crtc, + struct drm_crtc_state *state) +{ + struct st7920_crtc_state *st7920_state =3D to_st7920_crtc_state(state); + + kfree(st7920_state->data_array); + + __drm_atomic_helper_crtc_destroy_state(state); + + kfree(st7920_state); +} + +/* + * The CRTC is always enabled. Screen updates are performed by + * the primary plane's atomic_update function. Disabling clears + * the screen in the primary plane's atomic_disable function. + */ +static const struct drm_crtc_helper_funcs st7920_crtc_helper_funcs =3D { + .mode_valid =3D st7920_crtc_mode_valid, + .atomic_check =3D st7920_crtc_atomic_check, + .atomic_enable =3D st7920_crtc_atomic_enable, + .atomic_disable =3D st7920_crtc_atomic_disable, +}; + +static const struct drm_crtc_funcs st7920_crtc_funcs =3D { + .reset =3D st7920_crtc_reset, + .destroy =3D drm_crtc_cleanup, + .set_config =3D drm_atomic_helper_set_config, + .page_flip =3D drm_atomic_helper_page_flip, + .atomic_duplicate_state =3D st7920_crtc_duplicate_state, + .atomic_destroy_state =3D st7920_crtc_destroy_state, +}; + +static const struct drm_encoder_funcs st7920_encoder_funcs =3D { + .destroy =3D drm_encoder_cleanup, +}; + +static int st7920_connector_get_modes(struct drm_connector *connector) +{ + struct st7920_device *st7920 =3D drm_to_st7920(connector->dev); + + return drm_connector_helper_get_modes_fixed(connector, &st7920->mode); +} + +static const struct drm_connector_helper_funcs st7920_connector_helper_fun= cs =3D { + .get_modes =3D st7920_connector_get_modes, +}; + +static const struct drm_connector_funcs st7920_connector_funcs =3D { + .reset =3D drm_atomic_helper_connector_reset, + .fill_modes =3D drm_helper_probe_single_connector_modes, + .destroy =3D drm_connector_cleanup, + .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, + .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, +}; + +static const struct drm_mode_config_funcs st7920_mode_config_funcs =3D { + .fb_create =3D drm_gem_fb_create_with_dirty, + .atomic_check =3D drm_atomic_helper_check, + .atomic_commit =3D drm_atomic_helper_commit, +}; + +static const uint32_t st7920_formats[] =3D { + DRM_FORMAT_XRGB8888, +}; + +DEFINE_DRM_GEM_FOPS(st7920_fops); + +static const struct drm_driver st7920_drm_driver =3D { + DRM_GEM_SHMEM_DRIVER_OPS, + DRM_FBDEV_SHMEM_DRIVER_OPS, + .name =3D DRIVER_NAME, + .desc =3D DRIVER_DESC, + .date =3D DRIVER_DATE, + .major =3D DRIVER_MAJOR, + .minor =3D DRIVER_MINOR, + .driver_features =3D DRIVER_ATOMIC | DRIVER_GEM | DRIVER_MODESET, + .fops =3D &st7920_fops, +}; + +static int st7920_init_modeset(struct st7920_device *st7920) +{ + struct drm_display_mode *mode =3D &st7920->mode; + struct device *dev =3D st7920->dev; + struct drm_device *drm =3D &st7920->drm; + unsigned long max_width, max_height; + struct drm_plane *primary_plane; + struct drm_crtc *crtc; + struct drm_encoder *encoder; + struct drm_connector *connector; + int ret; + + /* + * Modesetting + */ + + ret =3D drmm_mode_config_init(drm); + if (ret) { + dev_err(dev, "DRM mode config init failed: %d\n", ret); + return ret; + } + + mode->type =3D DRM_MODE_TYPE_DRIVER; + mode->clock =3D 1; + mode->hdisplay =3D st7920->device_info->default_width; + mode->htotal =3D st7920->device_info->default_width; + mode->hsync_start =3D st7920->device_info->default_width; + mode->hsync_end =3D st7920->device_info->default_width; + mode->vdisplay =3D st7920->device_info->default_height; + mode->vtotal =3D st7920->device_info->default_height; + mode->vsync_start =3D st7920->device_info->default_height; + mode->vsync_end =3D st7920->device_info->default_height; + mode->width_mm =3D 27; + mode->height_mm =3D 27; + + max_width =3D max_t(unsigned long, mode->hdisplay, DRM_SHADOW_PLANE_MAX_W= IDTH); + max_height =3D max_t(unsigned long, mode->vdisplay, DRM_SHADOW_PLANE_MAX_= HEIGHT); + + drm->mode_config.min_width =3D mode->hdisplay; + drm->mode_config.max_width =3D max_width; + drm->mode_config.min_height =3D mode->vdisplay; + drm->mode_config.max_height =3D max_height; + drm->mode_config.preferred_depth =3D 24; + drm->mode_config.funcs =3D &st7920_mode_config_funcs; + + /* Primary plane */ + + primary_plane =3D &st7920->primary_plane; + ret =3D drm_universal_plane_init(drm, primary_plane, 0, &st7920_primary_p= lane_funcs, + st7920_formats, ARRAY_SIZE(st7920_formats), + NULL, DRM_PLANE_TYPE_PRIMARY, NULL); + if (ret) { + dev_err(dev, "DRM primary plane init failed: %d\n", ret); + return ret; + } + + drm_plane_helper_add(primary_plane, &st7920_primary_plane_helper_funcs); + + drm_plane_enable_fb_damage_clips(primary_plane); + + /* CRTC */ + + crtc =3D &st7920->crtc; + ret =3D drm_crtc_init_with_planes(drm, crtc, primary_plane, NULL, + &st7920_crtc_funcs, NULL); + if (ret) { + dev_err(dev, "DRM crtc init failed: %d\n", ret); + return ret; + } + + drm_crtc_helper_add(crtc, &st7920_crtc_helper_funcs); + + /* Encoder */ + + encoder =3D &st7920->encoder; + ret =3D drm_encoder_init(drm, encoder, &st7920_encoder_funcs, + DRM_MODE_ENCODER_NONE, NULL); + if (ret) { + dev_err(dev, "DRM encoder init failed: %d\n", ret); + return ret; + } + + encoder->possible_crtcs =3D drm_crtc_mask(crtc); + + /* Connector */ + + connector =3D &st7920->connector; + ret =3D drm_connector_init(drm, connector, &st7920_connector_funcs, + DRM_MODE_CONNECTOR_Unknown); + if (ret) { + dev_err(dev, "DRM connector init failed: %d\n", ret); + return ret; + } + + drm_connector_helper_add(connector, &st7920_connector_helper_funcs); + + ret =3D drm_connector_attach_encoder(connector, encoder); + if (ret) { + dev_err(dev, "DRM attach connector to encoder failed: %d\n", ret); + return ret; + } + + drm_mode_config_reset(drm); + + return 0; +} + +static int st7920_probe(struct spi_device *spi) +{ + struct st7920_device *st7920; + struct regmap *regmap; + struct device *dev =3D &spi->dev; + struct drm_device *drm; + int ret; + + regmap =3D devm_regmap_init_spi(spi, &st7920_spi_regmap_config); + if (IS_ERR(regmap)) + return PTR_ERR(regmap); + + st7920 =3D devm_drm_dev_alloc(dev, &st7920_drm_driver, + struct st7920_device, drm); + if (IS_ERR(st7920)) + return PTR_ERR(st7920); + + drm =3D &st7920->drm; + + st7920->dev =3D dev; + st7920->regmap =3D regmap; + st7920->spi =3D spi; + st7920->device_info =3D device_get_match_data(dev); + st7920->width =3D st7920->device_info->default_width; + st7920->height =3D st7920->device_info->default_height; + + st7920->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HI= GH); + if (IS_ERR(st7920->reset_gpio)) { + ret =3D PTR_ERR(st7920->reset_gpio); + dev_err(dev, "Unable to retrieve reset GPIO: %d\n", ret); + return ret; + } + + spi_set_drvdata(spi, st7920); + + ret =3D st7920_init_modeset(st7920); + if (ret) + return ret; + + ret =3D drm_dev_register(drm, 0); + if (ret) + return dev_err_probe(dev, ret, "DRM device register failed\n"); + + drm_client_setup(drm, NULL); + + return 0; +} + +static void st7920_remove(struct spi_device *spi) +{ + struct st7920_device *st7920 =3D spi_get_drvdata(spi); + + drm_dev_unplug(&st7920->drm); + drm_atomic_helper_shutdown(&st7920->drm); +} + +static void st7920_shutdown(struct spi_device *spi) +{ + struct st7920_device *st7920 =3D spi_get_drvdata(spi); + + drm_atomic_helper_shutdown(&st7920->drm); +} + +static struct spi_driver st7920_spi_driver =3D { + .driver =3D { + .name =3D DRIVER_NAME, + .of_match_table =3D st7920_of_match, + }, + .id_table =3D st7920_spi_id, + .probe =3D st7920_probe, + .remove =3D st7920_remove, + .shutdown =3D st7920_shutdown, +}; +module_spi_driver(st7920_spi_driver); + +MODULE_DESCRIPTION(DRIVER_DESC); +MODULE_AUTHOR("Iker Pedrosa "); +MODULE_LICENSE("GPL v2"); --=20 2.51.0 From nobody Tue Dec 9 02:09:21 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 555CB32E755 for ; Fri, 31 Oct 2025 09:05:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901544; cv=none; b=lVfw2u/Y81AnonFnXoLZMyUptliDwyO/ZrwmnlsaxIb5PEjaAemwycP1p4C/kNo7lOlC3LSDt/XR8J5R6WAW/SqLjhuko26ARMu/peqHYlNBvJlxjmu6cBvwIJ+v13UhQBSdHWaruXxbgro9+aR0vQoq5wWXunROStOFepV85sQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901544; c=relaxed/simple; bh=3ngI3i1BG0C9azbqBN/4q7nJ2yCSJxmqD7ABvsTPKbo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=i7MEWLwrYIygKgnVL9T4MyJTKAzApszflvMLsUJlIouD27QLQjdRCCpaTaAjfBGD+K9NSDZ6emSsviSjOV+FJick6p690wqwieOcjRHB1UqbvVTo4ddj2wnjaj112beQ0Tm9eo1VVOidfwgjLMDcXNXpLgVS2LfkAO6UT9PdjKA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KPZsEXln; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KPZsEXln" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-475ca9237c2so11108095e9.3 for ; Fri, 31 Oct 2025 02:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761901541; x=1762506341; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=m97kyP3HTS70kAnw3EPRct0ZUapkHpzYxU+r81cO+AM=; b=KPZsEXlnVmIZuIwDkpzhvf+Nnez81AXn7aDwJVAyvcTzYtE3IjUfgw5IGQbMc1W4p9 iVbX/6DOnCKWDbjl64BkreB5ihQVdS7Q2kUh6kx3Hy/gra7RQ2gQ97fAdsxRVFDS20UI p2vcv5a4/xSyIbVWDuS+eW2a7oqtQBCBiX45zaVFfVNi/afiiD8rbSaf8OB7JltOzEtn DzUjsJ3hTrpID4P/qoAk57n+VHagqMlG0Mbkamihcp4QL3bTONzYcxPHH27S8srR6ZUR 3jlFPfEPaI5LRNSPR+8q8cFFkC8Pu9Jm2upMZ0Md6Yp1ngtUtjowUZox0LPEGz+YvSkR GTCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761901541; x=1762506341; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m97kyP3HTS70kAnw3EPRct0ZUapkHpzYxU+r81cO+AM=; b=dPW31Zvd5epj7OlgLt0rc2hMB5KbguNoLKbdnrEKWrZOMY5SvJHRfjgPbnZNEb8nxH UNjHghpMGBl8rBKYO47UIUikT002MNtf5ccnppEs9OWancd7unOzB6yunUQ7PrzWlaLm q2GX6s70LXoyiUKPxGPL0oMF8m6XQXub8+04QvqM7jl0F24GyPoZoRr/cZSPivyydaGW KAmfd3M+6ZnMpSESaOWLzVwRe0b9qqfCmLDMHGLEGxFvTvFasVRWASuT8g/68wxPu9cV QyyoyAIZ7t2+0Qx8qXX5FsOUDV4HaUpFO70sRPQXckoBY4z/qWE47fuP0ABznpLqUy4o B0Fw== X-Gm-Message-State: AOJu0YwJ/SoZIOxm4A6Qcb6Cr/mKpA8lIoie2p9Yws+MbvgOSTst//7Y 3yJbF7i2DciwPvxK0TTWBW9m8CD3ztM349gzBSFKLXoyYsX5CSpD3kHK X-Gm-Gg: ASbGncuHFTl8MVMADLIRpJPy5SWx+hDvIqbZ9UXGJmkY8wixgr/eEBpvC1xSGcRbM1Z s3xgKGco7y3nSJpTp2Kv2lE6ePA4S9zrPA35GTnwc7RXud3Cb6E9bUw7QRxOxARJbNHkQOo0d1V iMy9hEzE0kksw4Y97scdSZ19Iucrk341npcFmSFGAq+YomHsVV+dke3IAzajryLQAdS1/OK4XqD i600ajlfxRj4Ku8zcX+WZUFj2V+1g4QLzz9jtLJ69HdcMuNgavJ5l+QJofcblnalwHodJFfDFVx tD+mdZxq5ONbJvhTaeLwV0JY48bLCqtTMhTBDOU+28VfWaCLjUq6SJkFRoJ7aIDauLmgLF1z4tT vTd+pf8KXD259JMAtLUniyeWT1Bn9473mk8sDUnnT/z6UNPWynHqlykmHauB5F8R9RaeBJ+jNxD ZfhnWVUuXDukpkj1NuN5X8kNwyrEeZXaOgzW1iDH6KkNcg5W9sgRYX X-Google-Smtp-Source: AGHT+IHaEdfxWwYT2zJAyLRZyUAgi4BdK3quhN7NkvDh1BylxO25NofIDcQ0FfuX8++X59NClzV6hw== X-Received: by 2002:a05:600c:1e06:b0:477:1be1:9afe with SMTP id 5b1f17b1804b1-477307b879bmr22506295e9.9.1761901540395; Fri, 31 Oct 2025 02:05:40 -0700 (PDT) Received: from ipedrosa-thinkpadx1carbongen12.rmtes.csb ([5.225.139.156]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477289adaf8sm93454475e9.7.2025.10.31.02.05.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 02:05:39 -0700 (PDT) From: Iker Pedrosa Date: Fri, 31 Oct 2025 10:05:19 +0100 Subject: [PATCH v4 3/3] MAINTAINERS: Add entry for Sitronix ST7920 driver Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251031-st7920-v4-3-35291f8076b2@gmail.com> References: <20251031-st7920-v4-0-35291f8076b2@gmail.com> In-Reply-To: <20251031-st7920-v4-0-35291f8076b2@gmail.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Javier Martinez Canillas , Iker Pedrosa Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.2 Add Iker as ST7920 driver maintainer. Signed-off-by: Iker Pedrosa Reviewed-by: Thomas Zimmermann --- MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5ddf37f0acc960039422ef988cadfa7176972fc5..79b8a277e38b55ebcff05450d6c= 565c0d87c6b51 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7861,6 +7861,13 @@ T: git https://gitlab.freedesktop.org/drm/misc/kerne= l.git F: Documentation/devicetree/bindings/display/sitronix,st7735r.yaml F: drivers/gpu/drm/sitronix/st7735r.c =20 +DRM DRIVER FOR SITRONIX ST7920 LCD DISPLAYS +M: Iker Pedrosa +S: Maintained +T: git https://gitlab.freedesktop.org/drm/misc/kernel.git +F: Documentation/devicetree/bindings/display/sitronix,st7920.yaml +F: drivers/gpu/drm/sitronix/st7920.c + DRM DRIVER FOR SOLOMON SSD130X OLED DISPLAYS M: Javier Martinez Canillas S: Maintained --=20 2.51.0