From nobody Mon Feb 9 01:06:33 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EF9D2D2381; Fri, 31 Oct 2025 17:43:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761932606; cv=none; b=USreERZHUird66Pzdx7vdDz9IN1w2dDGtYci856HnIeQSYVe5dXbJKUq4tEB08tiZcOGiELWHBabbwDgqKUT9bjwTDsNU98AyCqqfUV/6TKTlj+ifc588JZjDHKpatKGlSlR1Ttfhh7j96zfUd0hHHQobi58sqgFeIIoIi/bTbY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761932606; c=relaxed/simple; bh=hOzRlMRlpIFq50j9dDHMLuFdaWiwUzshHPxiwOpWbK0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WlZFd76eeuWxuWp0Y+EuajlyaQCsw4ZzVoAo+2pa51d1Qq2yQqQwfnmQx/YCmh8eHOgS6f/UsPog/ykCI49iOmraVhlWf5cxewWalxx9q+aRArhHRllgq+p/YZfdVJhMZTZMTJFUZELBzDD/fk8s9TANQkTF2hPLuBOlGHAWjbA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04DC1C4CEF1; Fri, 31 Oct 2025 17:43:19 +0000 (UTC) From: Manivannan Sadhasivam Date: Fri, 31 Oct 2025 23:12:59 +0530 Subject: [PATCH 1/3] dt-bindings: PCI: amlogic: Fix the register name of the DBI region Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251031-pci-meson-fix-v1-1-ed29ee5b54f9@oss.qualcomm.com> References: <20251031-pci-meson-fix-v1-0-ed29ee5b54f9@oss.qualcomm.com> In-Reply-To: <20251031-pci-meson-fix-v1-0-ed29ee5b54f9@oss.qualcomm.com> To: Bjorn Helgaas , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Hanjie Lin , Yue Wang , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andrew Murray , Jingoo Han , Krishna Chaitanya Chundru Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, Manivannan Sadhasivam X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1877; i=manivannan.sadhasivam@oss.qualcomm.com; h=from:subject:message-id; bh=hOzRlMRlpIFq50j9dDHMLuFdaWiwUzshHPxiwOpWbK0=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBpBPUv+DpW+X31eYQDlq+xLMSoLGj8QHTWpr7cV bqBU5ZPb9WJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCaQT1LwAKCRBVnxHm/pHO 9eDJB/9csouOBq7gYpORCAxK+Pjw6U3fbv81XHaiJ5+j9AioSpKls7sMzhyOVMk5+M93jpZVw3j Z5AEMEDVIEz2G4/36rbdT8Hgz3iIgA4vxveurHRBPd0vFSOO0X84l0nl18oDH1Z4hf/LViT/gVw eU1+hHJl0sa2oi6cYVSFWqrKmngU89cDmjLRzYnZcY2+wxQUuxnEViNIJ5sIbKGYKsywMuJVZCu HJCvkiOIrjInrVDIA8hfnwb5gOvrkO/+Ami+zjM2ESLcaBI0qjGkHqTgb3a5EGySY8s9gGFOEFz MU+QmiA8Oe3ZnGWHZO9CXKzSAUKAx2vHD8wdNvZ/N/q0td+h X-Developer-Key: i=manivannan.sadhasivam@oss.qualcomm.com; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 Binding incorrectly specifies the 'DBI' region as 'ELBI'. DBI is a must have region for DWC controllers as it has the Root Port and controller specific registers, while ELBI has optional registers. Hence, fix the binding. Though this is an ABI break, this change is needed to accurately describe the PCI memory map. Fixes: 7cd210391101 ("dt-bindings: PCI: meson: add DT bindings for Amlogic = Meson PCIe controller") Signed-off-by: Manivannan Sadhasivam --- Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml b/= Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml index 79a21ba0f9fd62804ba95fe8a6cc3252cf652197..c8258ef4032834d87cf3160ffd1= d93812801b62a 100644 --- a/Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml @@ -36,13 +36,13 @@ properties: =20 reg: items: - - description: External local bus interface registers + - description: Data Bus Interface registers - description: Meson designed configuration registers - description: PCIe configuration space =20 reg-names: items: - - const: elbi + - const: dbi - const: cfg - const: config =20 @@ -113,7 +113,7 @@ examples: pcie: pcie@f9800000 { compatible =3D "amlogic,axg-pcie", "snps,dw-pcie"; reg =3D <0xf9800000 0x400000>, <0xff646000 0x2000>, <0xf9f00000 0x= 100000>; - reg-names =3D "elbi", "cfg", "config"; + reg-names =3D "dbi", "cfg", "config"; interrupts =3D ; clocks =3D <&pclk>, <&clk_port>, <&clk_phy>; clock-names =3D "pclk", "port", "general"; --=20 2.48.1 From nobody Mon Feb 9 01:06:33 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48DC12D0C99; Fri, 31 Oct 2025 17:43:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761932613; cv=none; b=TGjgMDWnh2CfOtKu7b8EV9AnNGDm/EImFKbKxMjPKFSrhyy8BvB44cMjz0Lb5FfUB4M5MrzhaAVxbKEUjiQgc2326ShX4BYq6z0AcB4/C7+Rbs21+FDk7VYrBkaG0zivvlqXCY7ufit2JJQULTxj/PimqCsj6Dtcuul6BD2qZGw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761932613; c=relaxed/simple; bh=VrcDCZTTzA+LINiKOMWUnoZKZnxjToLdODEk4F9zscM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=k1EQFeYqryW/0GvKNF5Nsqhrro8qjwYtTnN7P17ilk6boyi9m8QLCYYgorXCHS52WMghknY5DkAoBqOFeWT5c+4ZvDO361NS56qjm2HIHKqalErIeDT/2dnWHVrdx7NtCs7lAYcjlPyxyZrZELo9F0sb3HnCBLup/BEBjkVnMMY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92D29C4CEFD; Fri, 31 Oct 2025 17:43:26 +0000 (UTC) From: Manivannan Sadhasivam Date: Fri, 31 Oct 2025 23:13:00 +0530 Subject: [PATCH 2/3] arm64: dts: amlogic: Fix the register name of the 'DBI' region Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251031-pci-meson-fix-v1-2-ed29ee5b54f9@oss.qualcomm.com> References: <20251031-pci-meson-fix-v1-0-ed29ee5b54f9@oss.qualcomm.com> In-Reply-To: <20251031-pci-meson-fix-v1-0-ed29ee5b54f9@oss.qualcomm.com> To: Bjorn Helgaas , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Hanjie Lin , Yue Wang , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andrew Murray , Jingoo Han , Krishna Chaitanya Chundru Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, Manivannan Sadhasivam , stable+noautosel@kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2433; i=manivannan.sadhasivam@oss.qualcomm.com; h=from:subject:message-id; bh=VrcDCZTTzA+LINiKOMWUnoZKZnxjToLdODEk4F9zscM=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBpBPUvcQMtni6PxVu1WzyHwh/xmL2GTRT+gLMvD 3qm9hdeZ82JATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCaQT1LwAKCRBVnxHm/pHO 9QHMCACn74/yrdyNkuDb9Q8ggaq3DyPe6Lw0cvTnujyKrgJVZFf4BQSXH9tHZIJSo6rkn1gvzeU y7G/UdAy/xQuL5rnUfvUUgyAlL3A5HNyAcNQaXuyDQzIDOMWLqFKmOuby6gPQLus//caL+9OSuU 78GgAa726V7GAD1fDBNWct89KM/YCb2s9lDGBybJHhZH4rzLIkHtIUWu1ZccEOLbI+16JP8O4Np i8sXcpyBgm9fxygyysYjlqLNaAdnoeZIyp8Uz8xD8jpZSbmvnWua9BexejLp7QZjSJMqqmOr2i5 CHcpusmuKf0WpntZ0ePbBJixideGxYB3Ov5AAsFVLCbkuuc2 X-Developer-Key: i=manivannan.sadhasivam@oss.qualcomm.com; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 DT incorrectly specifies the 'DBI' region as 'ELBI'. DBI is a must have region for DWC controllers as it has the Root Port and controller specific registers, while ELBI has optional registers. Hence, fix the DT for both Meson platforms. Cc: stable+noautosel@kernel.org # Driver dependency Fixes: 5b3a9c20926e ("arm64: dts: meson-axg: add PCIe nodes") Fixes: 1f8607d59763 ("arm64: dts: meson-g12a: Add PCIe node") Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++-- arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/d= ts/amlogic/meson-axg.dtsi index 04fb130ac7c6a498f7e8029aeaa7e511cbfe815d..e95c91894968b2c8b3b8e96a5f5= e85cd60f3e085 100644 --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi @@ -208,7 +208,7 @@ pcieA: pcie@f9800000 { reg =3D <0x0 0xf9800000 0x0 0x400000>, <0x0 0xff646000 0x0 0x2000>, <0x0 0xf9f00000 0x0 0x100000>; - reg-names =3D "elbi", "cfg", "config"; + reg-names =3D "dbi", "cfg", "config"; interrupts =3D ; #interrupt-cells =3D <1>; interrupt-map-mask =3D <0 0 0 0>; @@ -234,7 +234,7 @@ pcieB: pcie@fa000000 { reg =3D <0x0 0xfa000000 0x0 0x400000>, <0x0 0xff648000 0x0 0x2000>, <0x0 0xfa400000 0x0 0x100000>; - reg-names =3D "elbi", "cfg", "config"; + reg-names =3D "dbi", "cfg", "config"; interrupts =3D ; #interrupt-cells =3D <1>; interrupt-map-mask =3D <0 0 0 0>; diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64= /boot/dts/amlogic/meson-g12-common.dtsi index dcc927a9da80246da43391f9f90049c3570f10d2..ca455f634834b5a52db8ff4e6eb= ca35a87ea17b7 100644 --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi @@ -138,7 +138,7 @@ pcie: pcie@fc000000 { reg =3D <0x0 0xfc000000 0x0 0x400000>, <0x0 0xff648000 0x0 0x2000>, <0x0 0xfc400000 0x0 0x200000>; - reg-names =3D "elbi", "cfg", "config"; + reg-names =3D "dbi", "cfg", "config"; interrupts =3D ; #interrupt-cells =3D <1>; interrupt-map-mask =3D <0 0 0 0>; --=20 2.48.1 From nobody Mon Feb 9 01:06:33 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 702B02777FC; Fri, 31 Oct 2025 17:43:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761932620; cv=none; b=s+Vn8D0XOlTpBlX1pZQG9zr40svONZbYWgU0uzYtKkL4sVKGBoi92PlG/l9eGaARSVs2X7aqSndAjRV0MDiJF2Ixa8oE1Fam9EiC0vI3YpHPB2BNFpCQgf1Z2q1NS5uBk6YMHs6z8hDcDbIjn+0mf6fVpKN7q8Ez2cwNRkI7ALY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761932620; c=relaxed/simple; bh=z6Ma1tu8vEZQke3NjkVPJHb01xM4bsdEHhx7cBiREVQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=o8+5yWyGdfWkKSIdfnt2Pwfn7Qu2VlItXuVrZhxJzJmi5HKLiDOncIG5IJP8W4Ykdfq0H/8zLzOzn8XsE2KDxOI9NCKHnZpr6oZ7Xzu05RUvjWg7z5zwEeTIMdqeVTWXWJzMbBvOCIkJ2U0Jumr+/fBMkniAGnEBm85ijJnHHww= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 720D2C4CEFD; Fri, 31 Oct 2025 17:43:33 +0000 (UTC) From: Manivannan Sadhasivam Date: Fri, 31 Oct 2025 23:13:01 +0530 Subject: [PATCH 3/3] PCI: meson: Fix parsing the DBI register region Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251031-pci-meson-fix-v1-3-ed29ee5b54f9@oss.qualcomm.com> References: <20251031-pci-meson-fix-v1-0-ed29ee5b54f9@oss.qualcomm.com> In-Reply-To: <20251031-pci-meson-fix-v1-0-ed29ee5b54f9@oss.qualcomm.com> To: Bjorn Helgaas , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Hanjie Lin , Yue Wang , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andrew Murray , Jingoo Han , Krishna Chaitanya Chundru Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, Manivannan Sadhasivam , stable@vger.kernel.org, Linnaea Lavia X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3414; i=manivannan.sadhasivam@oss.qualcomm.com; h=from:subject:message-id; bh=z6Ma1tu8vEZQke3NjkVPJHb01xM4bsdEHhx7cBiREVQ=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBpBPUvXsQtI6n1/ub7CgmXxGJ8JQaiffJFgXqJj IzTr9DiOUmJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCaQT1LwAKCRBVnxHm/pHO 9RqECACAesI/tWx6iPgaFUHpHOdBsklA2dKYzIq50VMZE8TITLoLok0QC1u/5MZaotv9fBwvVtz CFLVVss7W1lhqxX0tSMJ2PeeYX/vnjD/PKpNznfsAmv0T0vSgUuRArmunIH47Wdftrm8Kwgk/rY +djMmr21xzwda6XqDunl4TxYwjWRCCDfuZHfJkDgxKJYYoa+J1aFl9NRsks1J4pxeE71lIOPJhW 4V/43ur74Zo7cTo851njPWd/oXhe6dAsq7Ees/3POTB1/k4W5AmSe4spB/OKRUyBY4OgaIPXDq8 scPBWKL/psMaD/PHj11mY1V5tqnHYKE12zUU+PfChr+L8u00 X-Developer-Key: i=manivannan.sadhasivam@oss.qualcomm.com; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 First of all, the driver was parsing the 'dbi' register region as 'elbi'. This was due to DT mistakenly passing 'dbi' as 'elbi'. Since the DT is now fixed to supply 'dbi' region, this driver can rely on the DWC core driver to parse and map it. However, to support the old DTs, if the 'elbi' region is found in DT, parse and map the region as both 'dw_pcie::elbi_base' as 'dw_pcie::dbi_base'. This will allow the driver to work with both broken and fixed DTs. Also, skip parsing the 'elbi' region in DWC core if 'pci->elbi_base' was already populated. Cc: # 6.2 Reported-by: Linnaea Lavia Closes: https://lore.kernel.org/linux-pci/DM4PR05MB102707B8CDF84D776C39F22F= 2C7F0A@DM4PR05MB10270.namprd05.prod.outlook.com/ Fixes: 9c0ef6d34fdb ("PCI: amlogic: Add the Amlogic Meson PCIe controller d= river") Fixes: c96992a24bec ("PCI: dwc: Add support for ELBI resource mapping") Signed-off-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pci-meson.c | 18 +++++++++++++++--- drivers/pci/controller/dwc/pcie-designware.c | 12 +++++++----- 2 files changed, 22 insertions(+), 8 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controlle= r/dwc/pci-meson.c index 787469d1b396d4c7b3e28edfe276b7b997fb8aee..54b6a4196f1767a3c14c6c901bf= ee3505588134c 100644 --- a/drivers/pci/controller/dwc/pci-meson.c +++ b/drivers/pci/controller/dwc/pci-meson.c @@ -108,10 +108,22 @@ static int meson_pcie_get_mems(struct platform_device= *pdev, struct meson_pcie *mp) { struct dw_pcie *pci =3D &mp->pci; + struct resource *res; =20 - pci->dbi_base =3D devm_platform_ioremap_resource_byname(pdev, "elbi"); - if (IS_ERR(pci->dbi_base)) - return PTR_ERR(pci->dbi_base); + /* + * For the broken DTs that supply 'dbi' as 'elbi', parse the 'elbi' + * region and assign it to both 'pci->elbi_base' and 'pci->dbi_space' so + * that the DWC core can skip parsing both regions. + */ + res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "elbi"); + if (res) { + pci->elbi_base =3D devm_pci_remap_cfg_resource(pci->dev, res); + if (IS_ERR(pci->elbi_base)) + return PTR_ERR(pci->elbi_base); + + pci->dbi_base =3D pci->elbi_base; + pci->dbi_phys_addr =3D res->start; + } =20 mp->cfg_base =3D devm_platform_ioremap_resource_byname(pdev, "cfg"); if (IS_ERR(mp->cfg_base)) diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/con= troller/dwc/pcie-designware.c index c644216995f69cbf065e61a0392bf1e5e32cf56e..06eca858eb1b3c7a8a833df6616= febcdbe854850 100644 --- a/drivers/pci/controller/dwc/pcie-designware.c +++ b/drivers/pci/controller/dwc/pcie-designware.c @@ -168,11 +168,13 @@ int dw_pcie_get_resources(struct dw_pcie *pci) } =20 /* ELBI is an optional resource */ - res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "elbi"); - if (res) { - pci->elbi_base =3D devm_ioremap_resource(pci->dev, res); - if (IS_ERR(pci->elbi_base)) - return PTR_ERR(pci->elbi_base); + if (!pci->elbi_base) { + res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "elbi"); + if (res) { + pci->elbi_base =3D devm_ioremap_resource(pci->dev, res); + if (IS_ERR(pci->elbi_base)) + return PTR_ERR(pci->elbi_base); + } } =20 /* LLDD is supposed to manually switch the clocks and resets state */ --=20 2.48.1