From nobody Mon Feb 9 09:54:47 2026 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011017.outbound.protection.outlook.com [40.107.130.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91EE732ED3F; Fri, 31 Oct 2025 09:09:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.17 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901749; cv=fail; b=cb8hcE6SK2YaM87333uU8d5/FtabMjLv7jD6cfMYv6VEUG2kVSlYPejfzmmDHJE6UNfIpo1hbLzpJrC+JFM3VZt0t59GSNaygmjwncBEN76GnPLWqfth2VE/smGgb0smXhf8S30yzzrzowzbzZ9Tk+r9PCpUwTeDZlV6SziFqeQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901749; c=relaxed/simple; bh=ch0qifwT/Pt8FQBZ5noAwwdXf77N4VJw8KW65uwCMls=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=mrw0DoebnXO1twWZ2E8G52waEmXtco3E7K8CjH+hASsjEVIcE5n32rZDgjQ8s7XfpxvCkBleOdv89H1b5Cnh4D+oXXjgB0n7+Elr/M/FGjAPOR3NkYyLE1qoQMsPY9e1MNNoA06GdZ5j+vDeXOFt3Hky1M5fYpNk+FsQPatTc5g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=gaVejE92; arc=fail smtp.client-ip=40.107.130.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="gaVejE92" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XEwMK7C/ELRB1I168hZ3rJH0ShQ5dN3dUX5QhVSQIoPN7VNbNPcbWitAhVgDz/j7lvg4hmaHUqxx/bv1MfXUXwuKGgxYIB1Uqs4nRwj+U9eC3Khdm4LAY/MKM06kbP9iW9IbevIoUp1m8/iawSrM3WlPzIYOXBJHEs8JMQw3xjYKiOzUAlkq3SqcVYwi0NBBtPOPLGozC2cDuKSlVJS36ys6kzhWBHDOAdPnw2058SFyxyjPvsHvbJ8Dg7Uic6/umpfpR5YkuRdREHgWxC7bBaaxVzHeHQ6YQ+ulk1iF4O36jC8eTri8HCZBz9RyO58GV0YUdnSpgBQzNpiQyy/rDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ka3ykOu/j55SY8FjTzPQouTLl15Cs6mEZywfN97swuA=; b=LAJB2yysjtWhq6RI8jrL1/WNkwUDPJPDdevMy+bvGzuM+qSunk4rPUtrD17SuaUnP1EBuxBlOYgzTFFEwvLUf+jR62bYXZANrMAbPITwn6TItn3YjRFGaYp5iHSOej+YCROZlkTs21B7mpoxNvns2oQ8ucrBVN4ZShGCahbsZbuPBp8jSaac1VcV7Hm+M1clZNKW/SjxWh6jsRO1GLgTv5izQwwOmAfO/BbE5dbRF1gCYk4JvE4KTD2NDlPlQcXamBxuzm2TGfHNOr31qMFElHxQraM3u2giAyR4lGa3ZiRbK+IEU1jptZsxVKl2z05+EdSSCNgsquHzFirdX8F7jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ka3ykOu/j55SY8FjTzPQouTLl15Cs6mEZywfN97swuA=; b=gaVejE92xMJN5ZCvCGxEEu4HfLO/celb6WjLYWRW7bBmqha7q00zGqU7m8DAV7Z0xFJ8lKhPUDNtzbE8LYPaU87FPZQabt6F20OLjO+EG9cSWGlS+3bD7E45V4f0LODykzRNCb26URKsClRDijSLV6R2Mn+pEOt+cCLW8fwFpxYBITdlxuh8uDuYzVBJmw+cc/hOzduRGTt5O+5cMOiC/UuTHVy7aOZWvs2qPo3ceCy84ERDTdkMVubXR9hKVOBWRgbj+Q1oIFsCkFTc+zc0l8md4Cn1gg9BSBByKQ8gBEMQRoFlpA17B5h6Ewl4so5E5QGLWFBtblRVQeD26jN95A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by MRWPR04MB11495.eurprd04.prod.outlook.com (2603:10a6:501:78::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Fri, 31 Oct 2025 09:09:03 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9275.013; Fri, 31 Oct 2025 09:09:03 +0000 From: Peng Fan Date: Fri, 31 Oct 2025 17:08:30 +0800 Subject: [PATCH 01/11] remoteproc: imx_dsp_rproc: simplify power domain attach and error handling Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251031-imx-dsp-2025-10-31-v1-1-282f66f55804@nxp.com> References: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> In-Reply-To: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Shengjiu Wang , Frank Li , Daniel Baluta , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1761901729; l=2633; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=ch0qifwT/Pt8FQBZ5noAwwdXf77N4VJw8KW65uwCMls=; b=hDUXuPRxu8Y3MOeJTyxHmk/gzF/7RFMa1HjRfAGSfxcQWoCa59Hs/Aw+5jZWTKNLlvIsdkZjA NCTkwJpXRE1AJLnsR9wQiT6LO1Y1HmMFzq2b0E4rhx839EodjZ5cQk5 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0010.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|MRWPR04MB11495:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f9edf70-c64c-4b1d-3ed2-08de185d233f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|7416014|1800799024|19092799006|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eHBWbFd1WUhFWEVCMVRMZloxZXRQRWZoeXpKdk1mczRYL2Q5WVJzTEZxNm5q?= =?utf-8?B?cDdIQzJ1MFc0dzIvNnJFYSs4V2YrS1dlTVdtTjBNUDREQ3JwYzF2SG82d2dv?= =?utf-8?B?cWE3dk51anBLczkxYU5SZWp6eU52djFzeUxzNmFCS25ZeG5YWXdDQUlLQ0gz?= =?utf-8?B?SlNpd1N5RGZOVE1iRmpxRm9IQkhlcmJCSXpEcFlLTUliLys3N2Nsd3hEQ1ps?= =?utf-8?B?UmZGU3lOMjZxc0xkSHl4TVVGUXBTdmdSWlYwNXl4WDIzWWd5S0JGZlRpS21a?= =?utf-8?B?aTJuMTlIUGVhd3h1VFBlVHo0cWJvTjFVMmgvTGt3Ulk2dHRvcEhZN08xS0RP?= =?utf-8?B?RWRGTlBkZWhBVVkrSmpBcGRUL3FSYVlwOWhiZnRGdS8xRVh4eGRtS1BSLytw?= =?utf-8?B?SnF6UlRFblRBZExVcTFhRzJKaGJCNFFybnA5cWhDemdWalAvM2hJOThpMWJH?= =?utf-8?B?aS9HNjI5a01DeCthMEk1L0dUL2R0cUpuRWJkMlYzcEd6QjFlVktncXYvS1BK?= =?utf-8?B?cGs1TW9qajdCdko5SXJwRWVSTWgrWkxhQU10MXpDSnVDV1FPdUliSDNDbzgz?= =?utf-8?B?TjJCZFY3ZkZiTCs3bjVjR2hhb3N6T3dOR3E1ZThTT0R4WkRIMDY1UmtrUTI4?= =?utf-8?B?MzdsNFhTZFNyR0NRVlNMLzRWcXRTSEprMGkzS3RQRHY4S2FGNkpvTjJFaUpV?= =?utf-8?B?dFpGbE9EVHA2dHNrYkFwcmpZRDBMYi9haFRzdS9MOTFiZ3pwb2VtdmJaUzYz?= =?utf-8?B?RXY4SHpQQ1BWV1RLT3A5VzZNUjBIR0tIQUhEdTA5OFlXaUorSXhDTk0wTTJa?= =?utf-8?B?V1liY0hISkIxRCtJWjJXSTY3SlZqQkRmeiswUWsyZFRJbTdIUUd4V3UvaG1u?= =?utf-8?B?aTRuckdhS2piSDNJVUtDdVRwc0R0WEtmRjdITmVoUXVRenhRUXh2N0YzZWpa?= =?utf-8?B?MENENUViTjhncFdLN25wY2JWeDFjWUFpWkJsaTBEVmZ5V2R4ZWtvOVJ3K0sv?= =?utf-8?B?SHIwZGFaV09SY01mT0EzRllyZDVVdExpN1BBL2taWGh0VlNwcXlzcXRYSTlx?= =?utf-8?B?TTFsYXh6K2dTZWdMNEhvanlMSUtyM1d0UDZJbG9BVkVzSHdMN252UU1sd3Bj?= =?utf-8?B?QUdGVW1KRXM5S0c5bG5RVEdmUkVVeXdZeWVVcmNPTzlkWm03OHJNL3Y3ZHlM?= =?utf-8?B?TE16L204cjYyYzVHUkJBa0w0MHFMaDZuM0t1ek95cXRvRFo5UTJhajhKMlU5?= =?utf-8?B?dU5wMlNZSWxIeXB3MDZTTi9GRTl1OEFpUmtNOG1IWnppd25SMEdVdTFqSE9u?= =?utf-8?B?MEF3YnJaUG83ZG9SS3Bnb1dQWmpwcm9LRjRRd0c1bTdQMEd5Y3F5SFpWVG5Q?= =?utf-8?B?THBNOHF2dGdDUTJYSUYzcG9icjdmRlAvNUVPNjFQTHp4T0g1SFlsUmYyQlVy?= =?utf-8?B?dmExQk1wYVJUZ2tJMWsweTBjdjR0Nkl6YktSaVRyK24veEd1M2liUzFHQitt?= =?utf-8?B?b1BZTnFvRkQ1R21NK3oyM3ZFQyttbmdLVWhJSVMwTEcyQUgyQS9PdTdNZmFX?= =?utf-8?B?ZnVMVmNVM1FWZUlLSCt1T3FYWmFCZTM4KzI2NEpiVk1MRGErUlB3cSsyTXlh?= =?utf-8?B?bVQvRmxER3pSc0RFWERhWEZzdGs2QitzYy9rcCtkc3VGQ01SSVVMejZ5Y1lL?= =?utf-8?B?V0wrQlBDM1NEODFoS2R0MFNoOGR3czB5YUZEb0U3c1BkRzVCTXFLVlJ5SFQr?= =?utf-8?B?NG8wT3hscVJaVDZWTi83SFFsbzZXa3ZkNlZoT20vaXlwMmlvTE13WlNMSUlu?= =?utf-8?B?RDJXRndIMDN2VEI4RFAyL1NMbHFTRjMyWkl4M1l2dE5ZSzlBa29Bd0ZQUkYx?= =?utf-8?B?RUJqNWl3Y2FFb0k1WjQ3eXdvS0w2bnNMeURsYjdVWUI2czNhYTBicjFFMnBr?= =?utf-8?B?RUVMZktnRzZHWVlmdkNaVmJvKzdYbXdNd0tIM04zeVUxbE1jd0QxR0R2Zk1R?= =?utf-8?B?aDIxSXcxNTBXT2RaaFFITEI3amZremRpWm5YS0ZVR1BOWTRJNzZnRS93L0l6?= =?utf-8?B?RUpTWGh6L1NNNmlEVXV0ai9jeWZIZnJlbFJsZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(7416014)(1800799024)(19092799006)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGR2MnhrRE1FY3VRWlBMK0QzN3prWlpNZUNmMzhYZEFZeVBnZEhueHRvTU0x?= =?utf-8?B?VWNqZ1hUMEVheDZFRUpsT0JUMDhIRVUwZTliaHVkMmhiazl6WmN4ZGtTSWFu?= =?utf-8?B?TE9hdUlXVDdua1VmNC9PVThINHRiaUVvcURtMkF0ZC90R2ozUUFOODNwWnRF?= =?utf-8?B?c3ZxT3VxUGxqY0I3eGY0SG0vdERaSUlKUkpGSEFCTmF2b3ZnY3NEQ2Q3cDBu?= =?utf-8?B?bjdhZlQ2NXJhWXVIcXlUV3RrbWJQekRNem1pbk55c1AzSDJPTGFvOHAxZ3JV?= =?utf-8?B?UkZKVHFoOEtNL0tUSVN4OXVOdStRUUI2K3BMWHRCNW8yN29QSEJPd3EzUmVx?= =?utf-8?B?aEpEcE1mcFRSWGlBYXY3c3didDNreU92bEFraUp1RU1qZGZObjJTam1xNGdM?= =?utf-8?B?cGNDbUNlOTNWU0pDS2VxSzlRV0hXV0tFdEFaUmRQNFFaTlFBM0czbGxnMnUx?= =?utf-8?B?cnh0WkZmZjNKQmM5TC81KzYvVG03V2h0dGdSdDNlSzJGU0pGb25aTENkdHZL?= =?utf-8?B?UXg2eUJkUk5CblpQMDdmSEFyT1FJMmNBWlJHR3hTc0kwencxUTFkK0l2ck1J?= =?utf-8?B?Vm9LQm5UbHoxUEM1Wmd0aHo4K0JhVjRjODhNd1VuZVJudVBvK0VJYkZ5Snpv?= =?utf-8?B?MlF2d1BqUnpmNEhpem13dkwzU2RBd29Bd094UHdQYzEwYmg2SWkzZ1lBOFBi?= =?utf-8?B?NUFVajVENUw0MTQ4OSsrTHY3NTQzaDlXaFlkenhRRnZIVnJldDVHS01OK2d0?= =?utf-8?B?cWRLdWxrUCtwUytOcWtPZFpOc2ZBY1lWaUNkRmZYL1NtdCtqTkFhamVtWHZT?= =?utf-8?B?WGRxOWI1bk1NMFJENnFDUWs2K0IrQmJkbXZSYks0UkR1UXJONTVsTUpFaFNI?= =?utf-8?B?Z3EzVVltN3lBQVVybEd4UEdTSlNSRkhIbG0xSmdGYWpMSUFvOVdPWjBjbVJx?= =?utf-8?B?ZjczcnVqUTlwLzNkYXdJSDgrRzNsbXRRNDQvUlNETVJkRXUvNGRGWlZEVkEy?= =?utf-8?B?U3F6blZzeFhJL2psSkNhcXRmanozNER5SjRtWFhic2hFL0puUllGMThNaDVM?= =?utf-8?B?amRhVUxTb1RIWm8rNk5uUE1rSnF4aXZOQTVLcFNqQlkvcjVnOE1TcUFwSjZ0?= =?utf-8?B?dXZzT29uMGIyaVNYNG4yS3FsZGx4VHRsMTVrUTFxT0JlVUQ4cUUzQWpNYnc0?= =?utf-8?B?YlJvbzB6ck9oZUNObVNzVkN4QzlCNWh2WFVkbkZmU0NoWE9mQi9mWk1nNXk4?= =?utf-8?B?SlJVa25MSVo0VVNIWnB6eTdFQUVoS05PM01UL1Bhb1VBSjliRjRzR2tqZUww?= =?utf-8?B?SW03aWdEVEgvb0dFaEpHUmVEMkdnVmNiMTVCSHBXUGJVT0dsUnhLeWt6cmFk?= =?utf-8?B?UlY0NTNNWVdqRStvUEdtcFYvTFhFUnBxeDFudEl5eUZJYlhSNkpWbE5HeEh5?= =?utf-8?B?Y1hqOGlnc2dlVW4yckdQRG1PNUpWQVIvRGQwL1VHNzZJeXRzY1BTTWhXQW81?= =?utf-8?B?ZDlFcXZDcVlBSlRDcTVlMDVMbFpoazNwdk8vaDluNUczZVZTWHdqQnFQVjU3?= =?utf-8?B?TS9zQk5hR20xYzU2cHZRMzNhWnorK1hCdXhVWi96MEE5QmhUYk52SDEwMnRM?= =?utf-8?B?Nm0yejNuMTdmOGtiL3I4RDNmRCtjcWduM3p1cW1DVzhZK2RFaktnT0I2MnBN?= =?utf-8?B?QkVvVWp1dzZzMlJTQndBZ2twQ2JidFB4TG90Yk1paTJickdqSUh5N1hXTTJJ?= =?utf-8?B?VGtEdHZUZEU5dlZPOTN5Wm5ZdDZLNFF5NStuZ3VLQ1pZb1NRb3hiMkh1UEpt?= =?utf-8?B?NFo1WVRCV2xwbVYwVGFPcmo3QUVZcTU0bjNBSDhHWis2WUx5eURIMXROOVZs?= =?utf-8?B?VkpjMUFSZDVEWmNXODB5Z09YS2IveHZEeFFjaWVRVEw1OWtMN3k2ZkpqNDhS?= =?utf-8?B?cUh3bUlrQWFybE5hZ0M4czlrZEdxOGZtNFF0NUNKYXFLUEFVbnAxQU5HOVYw?= =?utf-8?B?UUttMm9MbUpsSXU2aURRU3JBd2Z0T0FXVkd3c1VWeTRJWjRQcXdMaFJyR1E1?= =?utf-8?B?TGVZY1F0Tm5wN2FyNHRNaGMwajNSeE5POHNnQ2J0Sy96cEh2U29BN1c3UTc0?= =?utf-8?Q?6QMkq7isH1+4Uu9mwHIXKk/bR?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f9edf70-c64c-4b1d-3ed2-08de185d233f X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2025 09:09:03.7510 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qjG+Ol81TP0icntn50XhOY/L0WreleeRnfL9BlOhjugGSOCMbZ0D6IqL5No+Q2baKlwIkSX6LYWxyvyewV32MQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MRWPR04MB11495 Refactor imx_dsp_attach_pm_domains() to use devm_pm_domain_attach_list() directly, removing manual detach logic and simplifying resource management. Also replace verbose error handling in imx_dsp_rproc_probe() with dev_err_probe() for cleaner and more consistent error reporting. No functional changes. Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta Reviewed-by: Frank Li Reviewed-by: Shengjiu Wang --- drivers/remoteproc/imx_dsp_rproc.c | 29 ++++++++--------------------- 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 6e78a01755c7bdc28cd93f00fe6f74affc3d96b0..c466363debbebe8f91b908b3bff= aa32e9bf8b9a6 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -1062,14 +1062,12 @@ static const struct rproc_ops imx_dsp_rproc_ops =3D= { static int imx_dsp_attach_pm_domains(struct imx_dsp_rproc *priv) { struct device *dev =3D priv->rproc->dev.parent; - int ret; =20 /* A single PM domain is already attached. */ if (dev->pm_domain) return 0; =20 - ret =3D dev_pm_domain_attach_list(dev, NULL, &priv->pd_list); - return ret < 0 ? ret : 0; + return devm_pm_domain_attach_list(dev, NULL, &priv->pd_list); } =20 /** @@ -1186,35 +1184,25 @@ static int imx_dsp_rproc_probe(struct platform_devi= ce *pdev) =20 /* There are multiple power domains required by DSP on some platform */ ret =3D imx_dsp_attach_pm_domains(priv); - if (ret) { - dev_err(dev, "failed on imx_dsp_attach_pm_domains\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "failed on imx_dsp_attach_pm_domains\n"); + /* Get clocks */ ret =3D imx_dsp_rproc_clk_get(priv); - if (ret) { - dev_err(dev, "failed on imx_dsp_rproc_clk_get\n"); - goto err_detach_domains; - } + if (ret) + return dev_err_probe(dev, ret, "failed on imx_dsp_rproc_clk_get\n"); =20 init_completion(&priv->pm_comp); rproc->auto_boot =3D false; ret =3D rproc_add(rproc); - if (ret) { - dev_err(dev, "rproc_add failed\n"); - goto err_detach_domains; - } + if (ret) + return dev_err_probe(dev, ret, "rproc_add failed\n"); =20 rproc_coredump_set_elf_info(rproc, ELFCLASS32, EM_XTENSA); =20 pm_runtime_enable(dev); =20 return 0; - -err_detach_domains: - dev_pm_domain_detach_list(priv->pd_list); - - return ret; } =20 static void imx_dsp_rproc_remove(struct platform_device *pdev) @@ -1224,7 +1212,6 @@ static void imx_dsp_rproc_remove(struct platform_devi= ce *pdev) =20 pm_runtime_disable(&pdev->dev); rproc_del(rproc); - dev_pm_domain_detach_list(priv->pd_list); } =20 /* pm runtime functions */ --=20 2.37.1 From nobody Mon Feb 9 09:54:47 2026 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013029.outbound.protection.outlook.com [40.107.162.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3677330B1E; Fri, 31 Oct 2025 09:09:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901755; cv=fail; b=EvdAqK/OHGopvkdQcSJYqzAth8RcCZYVRr4vc7hYinyehdTgSYkIUxh8vbJZGfqZuTLo/VqrsuDGW3dsj/wmF6z9OG1Yyv/FeyF3PYeQMc11KoKRkpxYJBwFuf2y9B2HvoAXaz+mHH92V3jUKV06Bw2TlPL8a5i0031SlwhUECs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901755; c=relaxed/simple; bh=o6K9Q2Aw99fSgol7//9P/aCOL+QNJWqllQMeV8X+hEE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=hMtXXcKeUr8wFWMJXfFmqwdct8A37N7NsTViC6cyPbtzYui9GtQxSfLO2+2C4P+n1NT4o6Tspnb8V4L6mSI4aEg6PrMEN49Fmdc4bgqbhzPGro3bKCbt4sZr1yM7MHC8ef0ZSEaATw2jkzx7r0dbFaEulJI8EyiY/V55JHLJ+RQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=bHL7WGsP; arc=fail smtp.client-ip=40.107.162.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="bHL7WGsP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CAyfUEVxHYOeXL2dJEVoabGnnJOXJ92fm7k8+qQm/6uf0XpAgDBwiDm65FSqEIk8/Z50MP1FS0ABBNN1sM/llQKoUIQPIkpwc3jvTsNDA0Z+qMzMfYPI4JEkBCrhbMq5kSUua2MmBGICR7t52PgpZxMDNjofpK86rgVQU1XCaaQNVvY/TuBsWkALffaejhUpGPUuJLS41cgiGiyuO3XctDLyxgKXbixC1CUIu3NNXHpXioHUb0Pm05CVCS2vksFV82ofINIDS0FtP97bMxdo8+podwLyUINGjOLPzGVQUPbhER2FGgYc1MmToSV1WSAnFy5vZTHYH0Z5USnq6FvjxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3ZRLExtj3Fih9WrCAFpST8cS3eG4qMgPE/Kvnk03WFM=; b=TmIyoLI3FxQGaIN8tLLRKYewYuAOPLY66Yc8qeqoKEOIUD+qKmKT3mJI+awWyFVpgVJxaJxwzkk8pwYIevY41WXdHnS7t346g+O4YXi9HizDaYx+4zJ/aXorIOabMFTRXt4VUn91nwNt5GTcU1oy6c0kgViaPD1JsjzMGEmQOS7u2v72+NPRO/3mZez7jawLzPRYd9xTqTjqRcasKuc5EzVHbVUfkqATRrAruhCxabgvBibRPJ/taYwlCEauk2DcQHf1uEdfqZ9aQSfXR9qMUOxWmBTKAQg0LxiNABjYjJ4gzUaMsq4f0btR15w/yxQ7+W//OV1meIO3In3SdT7s1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ZRLExtj3Fih9WrCAFpST8cS3eG4qMgPE/Kvnk03WFM=; b=bHL7WGsPsnomd4f7hVugRSGtlEtkD1k3vffLdqingfUKVzPdhVk17d68I6/f2a7/5m4kqm9Cv0dJT2LsjsnHpMlZnualnSgzT++BH7nKUFJVxjnfBrBnfRXgFuud6eZ7DMYfB+UWaB4+qzVTkCsoxg0OtJwf4xafjw+Ie3oxhle0GF1EOlktqtkMgufhvaIJC9uyzKmZ412AUsor05U4BCZYwW0rC1nLiVws6K+Q/VSKRLHAN1rNutAtHi/vk1Z8Ja2Ah5Mnc71NW0KGsuYnO973dnXpzoQNllE1EvfXhxjwT+qJDt1mY8xwZIHj+rV6GeEWt9cLjGVboQe+DceTOw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8093.eurprd04.prod.outlook.com (2603:10a6:102:1c9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Fri, 31 Oct 2025 09:09:08 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9275.013; Fri, 31 Oct 2025 09:09:08 +0000 From: Peng Fan Date: Fri, 31 Oct 2025 17:08:31 +0800 Subject: [PATCH 02/11] remoteproc: imx_dsp_rproc: Use devm_rproc_add() helper Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251031-imx-dsp-2025-10-31-v1-2-282f66f55804@nxp.com> References: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> In-Reply-To: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Shengjiu Wang , Frank Li , Daniel Baluta , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1761901729; l=1163; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=o6K9Q2Aw99fSgol7//9P/aCOL+QNJWqllQMeV8X+hEE=; b=tW8EcuZhQJLS0wxr/XBOt9JxRg/1Wd1Xk98Px395dBabDjosRQEsgBTJPKpjZFA9uX63K4W5Z L5g+PwOtFxxB8a/MZkhaXIjerGSsftgroe1Ab3gRCGlc45auPo3KvGU X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0010.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8093:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c65632c-abab-451a-cecd-08de185d2621 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|19092799006|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?K0NVS0hxQ1FJQVVPYUMwb292U3JMQVpSa1hSUHlPRWVRYVNIWEdoS2p3RnJn?= =?utf-8?B?cXNZaFBhVXFrQVhzUXUvajF1RDVuamJTdGp1TVBkUk1zTGEzZUxiZENYdmlW?= =?utf-8?B?N3lIRFNFTFJVa29iOTJoa3BsQnJ6THlOM004Vy9oNVVlNFF4WjZsZExMd0pZ?= =?utf-8?B?M2JOQ2liNEdkSUJLQVdDS0gyUFdPU2RveG5kZzlBRFA1Zk5IcFJkTSt4czE5?= =?utf-8?B?NFpTTGFNbHZCRGkyRkdpZXFuUksrV21nYUN1Q08vRENUZEEwNE9FdG1ZTWRK?= =?utf-8?B?K2VrNmlRKzMrbllBWnYyM1YwU0liQzE3VlZQYXI1U1BzRWlBV2Rvblpkcjk5?= =?utf-8?B?alZTVWdDNk9pU1R2aCtncmxudE16L3Z0ZUg4TjJHdGFTaXJ2NUYrT0RRNENz?= =?utf-8?B?QU91RVIwUXhFWFFtTE5rVDlYNHlMc2U3VVlFQ3ZkRmNjZWJWcU5BUUlhWS90?= =?utf-8?B?UVlrTVExZlQ5SjAyNDlaZGh4UktvS2RtaTBieVlaSDZFL0dhcytZUUN0eDlm?= =?utf-8?B?RUFwTm85NUhrSjdLWjluUmpVdVh3MHhsd0V6T0wrV1B0Vi8rVUg4d3o5M0J6?= =?utf-8?B?ZFNXS2M1MmVFcFRWaFFETHI2dXdKbVJZQlB3MGxLQnhNWFJOYW5qdUlrdVNC?= =?utf-8?B?YzBXdUtLZ0lnanFwTlg4Wm9nZ0dYTVVQZ1lQMkVPMEVidFU4dEJMWWpzZDhp?= =?utf-8?B?cG9TMzlnNkJiaU5HbEhMcnJTSThiOWxhdXNJdmV4dXV3K2pXN0xTUWdhYTJq?= =?utf-8?B?M0QraFhjMFZaakYyMmx2ZStrT3c2MnZadkg3UUdqVlZSVXVCM2FHZi8rQVhn?= =?utf-8?B?SmVQcXNMN250a0FMSU81QXB1dVRCQ21OVnlJOGY1eWgxU2l4Unphbi9CaDQ0?= =?utf-8?B?ai9YM3FGVEpqM0ZMUXhQSkdmM0NldnFuVyt2dkZzeWRzZWtkazJxTjgzVWlF?= =?utf-8?B?OHBjQm1YN2ZRbWNrbG00MTc5ODZ3THlCVzlvV1RHblFnTWd5Ry8zKy9EbXFY?= =?utf-8?B?aWVmbXUvYmRJYzh6ZzR1Y3VZYTh6ZnJsd1o3T1FyTFMrTmlZWXFnYllRR29p?= =?utf-8?B?cU95eUhhR0tHc2h4MVl1QmhJbWZEU25NSlNvZG0vdW9XTUhPYzhGZTdBcDQx?= =?utf-8?B?cjQ3bjJ6bkQzYnM1TG9sbTArVVRZb00rejlHSTdiQ3VTUmM1Ukwzckd2MDNQ?= =?utf-8?B?Q041eElDQWE5VTErV0l0WXVjaGVPSlh2SWdXSzVEOWFFMlVBTmNoUzhCMUtL?= =?utf-8?B?dEtyNy9rYTh3R3dDY1ZjVW1ONkUxVGNhMG40ZEhpdjRGTTBLOVdqeWdqWkFz?= =?utf-8?B?cTNZWmJERUpZUjNERnQ3MzUzYTZNaXdPejY1WWhOWEVrZmczcjNCSXUreUpD?= =?utf-8?B?cForM0NwNUtiVVZ5V09MenRoN0tLcGV1TkdFb2dxZmYyZDlvUk9GZ1pVeEhQ?= =?utf-8?B?U0dxK3lNVzdYYlhLa0tpaHJ5bloxSlVJSDYzZTBtOTVmSEZOWWJZM0FseVZj?= =?utf-8?B?bjIvNWw1UW9iYVNGVm1xelh4RFdRdU1xUjMxUERhUFFDS0ZxcXF0UXlGSWJG?= =?utf-8?B?MEZmdU4wVktLdGs1U0dmY2Q0Q0hBZkFKb2RnN1cxSUMzVUQyQWExZ2c2OEpk?= =?utf-8?B?NXhaQ3pYdTRoekFTSmpWeXFsV2pFdkVac0E1MUJ3cG13WEpHMkJFamlLVXNQ?= =?utf-8?B?UXAreVFVRTN5cDlubDZFMXdyM1FkZWRWZWJ0VzMvdW0xQnpVekFDbXpWbkRq?= =?utf-8?B?YitOeUtVV2ExYm4rdU9PSkRPSjlDSGFIMHhPUlBVT0FOcDlMQmlQVW1PeDIw?= =?utf-8?B?TGMycDRWZUdIUGRrOUl0b3NKZi9pcHN0UHc4c3R3RGlQdWZlUW9kRTNGQVVk?= =?utf-8?B?cE1VK0dzS1B0R25iWWwxYk5EWUx3V0FmQUxhRFpIL3hjSkpFRGIvZFNWeVJV?= =?utf-8?B?LytNWHFjaWc5WmxtaUJ6SnYrMGFVQVk2bVdPNlordVl6QmZINE12RlY4dDN2?= =?utf-8?B?NlM5eW1YQU94WnYwdHhGam1ZNjNuRVp6anN0UHJEMXVsdVlPd1NSZzN0UXNR?= =?utf-8?B?N1RqVmZUb0dIQkkrU2FjUmRWT3dPczdxa0wrUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(19092799006)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlNCRitMZGJVTUpNNm84YmRFWmQwNTJpdlJkSysvbnpxSGg2V2FHdk1mSy9p?= =?utf-8?B?WHhTZE1oWGthTS8veEx6bGM0ZEp2c21OT0xuMkMweHNNQUZJekdkTWJnSzFq?= =?utf-8?B?czVnWFdId2RJVVlPakxTcXpBOG5xQjlJY1JOV3M2TGRsMGs4TEVqTUExREw0?= =?utf-8?B?ZXlHcGRiVGNPczY2aUM0R0x1MnlNY3VPSXd5VEk4bG1GdUxoTmErUE5hcWhC?= =?utf-8?B?NERFRE5iQVp3TU1MMUpwMUxlWmRFL0hVREVqd2QvYWNxcjRBdkJlT0YxZUtM?= =?utf-8?B?QjNOblFGU1BNYlFwMzNlNnJST3JObDhXMlhsdnpBM25oMVdwaXEwUUc1QmVq?= =?utf-8?B?ekJMZVgzY0hPL0UwV0Mxb2Z1bkRvSVBvNGlONTNIRytjZmxtNDJKSys2TlBw?= =?utf-8?B?aENXd3QvQkkwNjh5eEhUU0ZPY2t0dFJkcnlpdGNyYU8ycVNOL2FEeUpheGRJ?= =?utf-8?B?d2l5UXFxWTlQejF3N0hkaXl6TC9lUzB3bHZLbDc3RGs5SzlBdVY0cERUK2FE?= =?utf-8?B?NTlVVjJUUmNteHN0MmpHUnl3R3VJSkpqUXQwbmlsNk1DbXNnT2ZZdkxNb2J0?= =?utf-8?B?NGpnblVGS21rc0h1R2xZbWg5WFRsdHFJUm9iV2RxVzBvTTZsYjFhcGVhMWlG?= =?utf-8?B?cUVyTGVCaHZuL0VFRy91aENqaE1zK3NLYmc3OXpPY2J1VjRyV2JHRDlWWG1v?= =?utf-8?B?WHhGK0NlRTFJVkd1Z3h5T3FHMHFLcXArSnRhcFBhWi82SjRobFBmdmU0N0ZH?= =?utf-8?B?WTBiSk03a2dpRkQzSjI1UjJvM2NGS244NXl2ejJLV0ZYS05oOHlCK0NoRTcv?= =?utf-8?B?ODAwNmFXK3Q0UHpaVk9xVFBsQXl4QnZGVXQ2Mm03MHBDeHIyNGZha2RqUUdC?= =?utf-8?B?emtpOEtPU3RjeWtoZkVHeTM2QVlDNVNCYitKQUp2SFpRM1Rmd1c0SW5XZlBk?= =?utf-8?B?SS9WY2tVUTFQd1ZsZE1pcWdqeUJFNFYxZVIyVmVZaWNxc1J1M01PUTQvdTh0?= =?utf-8?B?MHdaL240NTdzZ29ha0dCK0UzdnRWNzdOaFZDVmpDVGJUUkd3RVc1UGhhZzZN?= =?utf-8?B?V3NOV3dkaXgzWXdWM3htQlNBSTRRQmxBMG1WTWNzK1drNzk2d2hwQUNOcUh4?= =?utf-8?B?dW9yUHBSTlVaL2lrRFN1ZzgvZXJ2c1p0YnlBNzZNV0VQRWlpVzJoUHlvaGNs?= =?utf-8?B?dDV6VVZVL1J6TGRtYXAwV3VIMDQ2emlyM3p0Rm16WVUra0NKQ0dTVHBya21h?= =?utf-8?B?VXlqUGEvTytWMWkyTTNJYTVOL2ZuWU9Zekc1dXR0L2pZTnpmMmxFelBqVlVo?= =?utf-8?B?c3lSbnZ1Q2oyMnBuRW5PanR1eDJyOHp6aW1aTmVXMFlGMWNJRm9RL3Z1MzR4?= =?utf-8?B?UXVvbXBZWHVCN2JqZzAwN3B2bjNlNEtJSDNFZ09tWEdDSEhhRDN3dUgyZWNC?= =?utf-8?B?UFlWb0c3d0Y2ZUdDcFFveU5Oa1Q1UkRNUXp4dEFzK2xzSzFlM0dWbk1RR0t3?= =?utf-8?B?T3hBQkhndTVMUWY0V2l2SzRFbnJxZk1IbjllOGtxMnJwblhjbVhnQmFrLzRL?= =?utf-8?B?L05PQkE0TmsxSGY5MWYzRm1BZFRJVzhxSjAzT1lOMFJZL2hBTlpHNXpERUtq?= =?utf-8?B?SXg3ejVFZEVzQTIwbkN3REphZ0lVcWlwdTBPSjAxcHlRMVIyR1BzRjhoTlVC?= =?utf-8?B?WkhqbXpDWDU4WUE0UW5kTHF2WlFydko5Z2trMjFCZkMybFFkWUFXU3RKV3dt?= =?utf-8?B?QWZ6UWs3aURjZjdiSFdWQ3NCNWpyMVdLL1dPcjhMSUYxQlYwcy9sSko3aExp?= =?utf-8?B?Z0ZPUVdETGx5L0lTV0lHSHlEbDdEZllWcmdNaVlVM2psK25vUDRrNE1ocUlC?= =?utf-8?B?RjUzRTlnY012eGd4UDlhVEI0RHVzQUtwRDZnTnRGcHg5OUNFMk9DZ2FIcEJD?= =?utf-8?B?VittNmtwSVhZMnVvc01JcW9ZTSt4NVBqeXh2aWhzTTVJZm5PbWxMRjJJS3ZB?= =?utf-8?B?NDlwK0ZOTUJlZ0FQdXNMdEhqSU1YMUlZd3ZUNHVETTZyZ1BraDI1cDZhSGhL?= =?utf-8?B?aEJRRGgxcDJMT3pPV0NFQzNtOTVudnorRTBRMWpjYWhZNjN0dG9Kb0xxRkZw?= =?utf-8?Q?9YWhjdEkfC0JX3o1ZFVA3PdA8?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c65632c-abab-451a-cecd-08de185d2621 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2025 09:09:08.5410 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EN5qQa1BrVKGf3whYEjnryE+o9fS/ekfeeiGW0MRmhJwaHJcd/P7QzYA0xNmRnzeTybT3uX9Dwgo2fjTEsvTYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8093 Replace manual rproc_add() and cleanup logic with devm_rproc_add(), which ties the remoteproc lifecycle to the device's lifecycle. This simplifies error handling and ensures proper cleanup. No functional changes. Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta Reviewed-by: Frank Li Reviewed-by: Shengjiu Wang --- drivers/remoteproc/imx_dsp_rproc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index c466363debbebe8f91b908b3bffaa32e9bf8b9a6..df6a4126538d22ff6e02145edb5= ac13c2d72c949 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -1194,7 +1194,7 @@ static int imx_dsp_rproc_probe(struct platform_device= *pdev) =20 init_completion(&priv->pm_comp); rproc->auto_boot =3D false; - ret =3D rproc_add(rproc); + ret =3D devm_rproc_add(dev, rproc); if (ret) return dev_err_probe(dev, ret, "rproc_add failed\n"); =20 @@ -1211,7 +1211,6 @@ static void imx_dsp_rproc_remove(struct platform_devi= ce *pdev) struct imx_dsp_rproc *priv =3D rproc->priv; =20 pm_runtime_disable(&pdev->dev); - rproc_del(rproc); } =20 /* pm runtime functions */ --=20 2.37.1 From nobody Mon Feb 9 09:54:47 2026 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013029.outbound.protection.outlook.com [40.107.162.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE33F330B1D; Fri, 31 Oct 2025 09:09:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901757; cv=fail; b=HByL1P1SwStwhbCK7bnue8Qywvod+mFTugVWc+46JN9IZSAjnu2DD+u9krjfFHWs76KGVQNxd0bWxKTGHq0Y+871WA0H/amSTLdbuMiE9TRxhvtpo9DLHmHVSpB1z1TYVoz9gNQyG/2GcSV9DxEUzf4s23JBU/keUMg+imuSx94= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901757; c=relaxed/simple; bh=P49jMcAhuQNOpzbP+Ee7b6odmMCnmPgHnhwU/gp7vGQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=YxLC1qspxWLXJkxKRwptQB293oNDHJXaZPlcJ7uD8f09vOaJOkiGSFBg41tXKOjt50VmM4AuNX4+/cKCj3AdIDqaDsyEMQAlOF+XaC80ceDN16X0FqiWENzWcr5iOYY0/wZQ5yMY+2SOZJy8PetIxatH84DIR5MmkpsOYHC2cLQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=bhQZPGxa; arc=fail smtp.client-ip=40.107.162.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="bhQZPGxa" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tX5dJIBgVTnvd+My8PUH26XtjBVjgjV1XvSxsWXZg0MuQrUq9OjhcH0tMFAvDJlgoyZH9d+eNbIStLXJsdkWOlSIXnszZ5HFZ6n5F90mI/T6pRcIXAVzaNKVN3vWY97lbMOFOwzRupdS7zYfw5kWuejPLMQHxuboBfRfbAeC30BCb2mHXM2OLIhR5rPH43LLfvo8dQNjhMbxunHS/VKnmZ8qodmKeGCXe7ytLovp+cnzvGL+ROEVsJmtzjeJrvDDpZeYP/GyEfa7d2MigESYT6ezDLlgR3GCfcsIJaBH4Cqwa049K2/NUlsOaNpesBfWk5CMw7zpNlc9aMHIWeVBfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dm4LCG7ijjZwfMwGcnBduvL9vOrcgjeWIYQgJ5G24cc=; b=a8gswIgC0WSdJIUqhDH1DNMEaJF07aQ3LsHcGU8wUMpMn/MHUz6tStfenoNS78VNl0SBjHY6xx/QSyflTOSjzwrN6ePrZqaUBTa+Eva736LWPUNPIyFmNK03+ry3u3NTwzSueAn5VErHNfv0+aPMu0CGX0OakXSwEvjhW4kuT/KKgjV3nR9vc8vWpJxtEbXI2YgIBrc1OTeu/Z7Co3SPvplmaPHb4tngFTvxozVsZgb8k0ZPwgASlMeOooi71ajcRFZkChkFvaW6Opg/PVVbI7jlxGCwD2iZrv9AGKAWwuif2daa+COWfX+zDllnOwdtHuqBK0aUfp/DPd6Lr0EIyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dm4LCG7ijjZwfMwGcnBduvL9vOrcgjeWIYQgJ5G24cc=; b=bhQZPGxad/bcaYynig4f0q+Y/NroaWbj70gSTgi9amNT0q6IeWemxHL/1YagP7QgEX6IyOVMAt2xsTnoD/tkJOKvYzMMNoAuBH0P7GCnvxjrhTlM6dQNazPO9+f78t3cNsa4jV9qNKqqLXAiuCU+cVrcARs1kc5aJHSc8ozf2LgQTdP5NE/K4C4GdpIzwBNZV1P617d0tOzVg+wUT4tjAUVM2I5r/uYfYCO7dKI8jQ2LYRMSKvaBIkwp6m22LbMctjSqa6CE6uSaXFOJlN4PcM0IBsU5+2JL7dKkwz4Gb8b66TtkvPbE91n2mvvz7ftGxzhwUiuDeHJ70mYwfNgeMA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8093.eurprd04.prod.outlook.com (2603:10a6:102:1c9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Fri, 31 Oct 2025 09:09:13 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9275.013; Fri, 31 Oct 2025 09:09:13 +0000 From: Peng Fan Date: Fri, 31 Oct 2025 17:08:32 +0800 Subject: [PATCH 03/11] remoteproc: imx_dsp_rproc: Use devm_pm_runtime_enable() helper Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251031-imx-dsp-2025-10-31-v1-3-282f66f55804@nxp.com> References: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> In-Reply-To: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Shengjiu Wang , Frank Li , Daniel Baluta , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1761901729; l=1669; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=P49jMcAhuQNOpzbP+Ee7b6odmMCnmPgHnhwU/gp7vGQ=; b=TSkwrslPis+CuScOJTND08FN7gNXFpvNQ5G6MtZpodst5geSnz1p45HUS4mrPoquJgemyh6dL j/SZFryF9laA83tLuIOZVlO620xUY7GakMlghphFJsaFpxJZuXDlCiG X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0010.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8093:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e6b282b-1d23-4715-b1ea-08de185d28d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|19092799006|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TDdXV2Z0WDZKMVM5THVYcVhzQmpPRlVqZFNyZEVWNDRaVlNtd0diVVpTc3Bz?= =?utf-8?B?aXRQdmc2dUdxbEVOTXUwUTZRZjBxSnZtdGdOb29CRjJDQnIwYWNVbUVaZUkz?= =?utf-8?B?ODNtTXdveFNZSWFTT1VMTU5aU1pWYlgxTFZXMFIvZklNcFg0ckR5T2M3aWtK?= =?utf-8?B?clVlS0tyQ0RxQm5tUmdGb2lwNFhxb2RtRC9kTVZZR3JjQnRJOGxRMTJ0cEg3?= =?utf-8?B?aEY2QW1hbW5jVm1NV0pwdWJQc3F1bEcxaVYrWGZCdWZBUE5aR1B0eHNhbzQx?= =?utf-8?B?WkdLNEpwcHpKQXVTTnFTdTJyRVBzRnBrMk90YmZWQkovNlhyM254K1VtalFR?= =?utf-8?B?WjFKSjVFbzMrVXdSRnE2Q0FtRS9KV1BGaTYwM01uYkJyUEdROXFvK2g0cTMz?= =?utf-8?B?TVhGU2xidi9PTm52V1RwcGFKZTlEKzZqQk52eHAzcGhFZG1SMFdnK0c3cVRa?= =?utf-8?B?ZXp1QlNCMVd1c3hqdVdnVWZkOWFnNkhBalo5d0YxVXhhQjh3R2dRN2N3bThK?= =?utf-8?B?clVCTDVWTTNDeDB6c1JySDRtS2NpVk1Rd1VFSlZMd3pRTWNrVG5LaExIeHRt?= =?utf-8?B?d2w2TUZXUlZ0UzlqTmtIc1g2QXpnMXAzY3VneEhMRW5xQ2w5QTViaG1ESFNX?= =?utf-8?B?Uzhyc0FacGpWeEl3WGhvVEJOelNCQlZGc3MvaVBDUnpURVpCSFNSY29HbnBh?= =?utf-8?B?a3BkYXd2QXFsb3E2dG1DRjFCSlFTVXE2bXlCN1p6OHF2QWRPY29FWXcvNnZH?= =?utf-8?B?OU4zMUJxTm5FVmlsTmtnS01PcEhKZGNDUHBzQWlMc2d3RGNYM0NuTjgzM3ZZ?= =?utf-8?B?eStSbEg3Mk9KblhEditKYXlFQkQxazByRzk1aDZEL0d6MlgvWDg2UlpldG5p?= =?utf-8?B?U0JlZzJzeGtWSjZlZkl6bVVLTVh6Tk5sbitmU3dmejhYd2xuMTB0c2lGNThE?= =?utf-8?B?Q2NZRmxTSUEwSzZMdTd1bFhSTDZWNzdGUklFbHZpekR1d3J3MTBCOURWdUFi?= =?utf-8?B?eC93eDlSeksycWJjQWFmQ0tHdFdVaXVMUWtzZXNEdWdtdTlteE8zNU1Xa1Mx?= =?utf-8?B?NGFHamtwam00RnBJTkRxMzJhUmVYVU5LdWJ3OUVnZUwxbWh3RDA0UTNnTmRE?= =?utf-8?B?MFg5d01NSTQ1ZTd3ZHROakZ1SW4zOVl3enZ2aXRlNjd3SGIrMXZQMzhTc05n?= =?utf-8?B?Qk9Bc0gvMURvSXBWaGdkMkpkUml6eHQ1Y0RxMVBDQnJtbk15NTBNdVBoRUMx?= =?utf-8?B?S2o3WElHTFJTcXZ2UlYxRndmNlJsN2NTSzhMN2M4OWZRK1lFUVdzaVF4ZWpC?= =?utf-8?B?VWk0UzloamJ5a0NMb3U5RDYvcStZeFo5OTNqOHYzNVJYZXY4RGpZaUxFSkti?= =?utf-8?B?a1M5MEpHemlXelR3RVMvTXNpVVZLMkxDd0Rlay81SXN6Y0g3TzZHTjZJUkIz?= =?utf-8?B?L0o4ZzQyeWQ2N1k4TmtyczJxR2c1NXgrdllyV3YvQ29NTGFXaGhnZWhYRDl4?= =?utf-8?B?L29YdVBYcDVzRWFnY240TTNuN1Z0K2RUYnVXRlVkUVViS0dFZVRlelZ1d3gv?= =?utf-8?B?OEN0Tkl0d2Qzbk1Wb1duTkpxdHVxMW41bWp0ZjhoTjFUQ0ZWN3Y2RXJoNmpy?= =?utf-8?B?Syt4MXNkNGNXUDF5QVQxblJ4UTBFZEFjKzJ2VXVWQkVpTmhIYUtoSHZXU1NK?= =?utf-8?B?M0w5d0kzVUdqY1ErVVZ1UVk0MG51ZDRhKzZwaTRId2FVM1pBUEZobTB0Z3h6?= =?utf-8?B?V1ZrWm9CT2xWT2ZndXZpQXg1Q01KWTRqcXBpT2l5SVk5WWlKZmZ5NUlkakNh?= =?utf-8?B?WGtaeWl0bUVvL2RielNPUjhkSTBlalg4UGRLbVRmdExhc3ZYWWE4ZWUvZmVJ?= =?utf-8?B?UkhJMUhxRlExUWhBR3YvZHQ0VS9OY0g1WVBOUFEzS0IrWnlUTXdtb0ZyNEpH?= =?utf-8?B?VktCZnFFNkNadFlsdHQxZCtCVlpwR1BoTTVGRDJ2WERxQlBDWUI2c1d1Nk82?= =?utf-8?B?WWVrWGd4SnBlczcxcnBTMU9lUm9BK1UrSWtjcEtWOTdSS1dQV0F4WXZvYW1Y?= =?utf-8?B?QlkvRndMRUM5aXgrR2hZZW41VzJRdkZVRll4dz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(19092799006)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVJGU0MzUmRPTmw0ZUJZdUk3LzY4OUhQdDFYUGVLam5MYjNpZlZEZ1JVWVpJ?= =?utf-8?B?NGlzMFNmVWVub3V0NmpRQ0kyeGliRVQxS1MxMFR1RC9YakVBV0V1d29vejVB?= =?utf-8?B?QjhBTHNNYUdJdktsS2dCOXFrQ21KTEdreW8rekdXaDB0U2tDeHEwejJNbXN0?= =?utf-8?B?clJCNE56UFNaTkdFKzRUOEswNmxiR2ViMVhVVkt5M3dBNFQxcWxMRDB5TFZx?= =?utf-8?B?Tzg3UEdYdUozRjE4cVRVci9odVlwbXhUV0wrMjVpTXphYTlSVWZxNjFsS1hO?= =?utf-8?B?ODNtbUhHa3c0ampGNUZWNUxHYW0wM3Y0bmJtOTZYS3lLQll3bTE4NXV0dnFE?= =?utf-8?B?SlNId3VIMkJISEFDTWU2WjU0ekc1TWlDTkVXTXd0dUFZYjc5ajcxNExTSUNi?= =?utf-8?B?NHMvVlI0azZOOHBRQWJZUTRTYVZ0RGs5ei9LRGxtNVc0c0svbGpDMXhVcGlC?= =?utf-8?B?VWx3MTBuUklCL2ZRWnVzWFNTVHZOZU9iRFUzcUJMV2hlVHN1Y1JONUpPU2xB?= =?utf-8?B?Um03STRzaGZwRFMyKzhMV0RTZWdlWkRSbGV6VVBPZ3FuOWxnbXFpTExSSG5T?= =?utf-8?B?UHhQeTRWNTQ2dUY5ZHB4NmE3VVVYTlFQVkFXYmtCUlhCLzBmNTFDeGVyVktH?= =?utf-8?B?SFRUNENoS3Z1STFRYXNCNUthV3RZWHNDQ2lxQWZsbkJpY3o1a2dOM2VwZTdZ?= =?utf-8?B?dmhTSGkzbXpwNkRoN2RnSUVEZHBBb1VLamJKM2l0aGJYRzZ6UE1FczAyRytn?= =?utf-8?B?VXBraDBhL0ZrNzBTa25nemk4S2xscW1mUDJXMEIvUW02Q2NlR1gxMllmTlNw?= =?utf-8?B?UjVKVzhwbWE4ckhiOXEwVDRqMnoyQi9oVUY0UEptbm12dEFoWWdudzlpbGVI?= =?utf-8?B?QTBmK0Rndm9ZenRlanEreGw0dkRYNjk2ZmRoM0cvYytacEZVTVdJMnp5M1ZR?= =?utf-8?B?d3NqNlRBR0dkbW9YN2N6U0dWNGJmU2N3U0VLdlhvNGREbjRFVlZTZ1pnME5t?= =?utf-8?B?a2lMamRIcklaUXpXS3J4VCtVOVBHd0pFUGZJQUtFN0g1KzY0T0JQWTlvQjVM?= =?utf-8?B?bG9mR3dFa3dQdmozYkN4RE1CcHd4S1puOXE2dnhMMlRqbHBrVHc2NVJ1WDJ1?= =?utf-8?B?WDduNUFVbmZHUzgrb1luMGpHc25DZU0zYUlWRHdDZzJPUXoxdUVwei9QT1BV?= =?utf-8?B?WUxSSHAwUTNPMTFRMzE5emtWbkwvc216UytqR0J1cmNKZCt4TFlwa3pWMmg4?= =?utf-8?B?MlovOGZXaTFjSlZ1NUtHOFVHWFZVcjM4eU5IM3Z4eUNmdkZvWE9xaTByQm53?= =?utf-8?B?a21Gb0lZcGNnVGpIOGZlSGtGY3NQT1dOa3BzY2o0WXpZcGtqVTd1UEFyZUJI?= =?utf-8?B?NG1DdENXMXVoaXNTbGRNSFd5bHhBT1ZzSG52VG13ME9OUG82SUM5M1lrcUE2?= =?utf-8?B?TXdxL3FqTjdLZkxoY1JBUXc4dENkRHU5b2lOdEtEUXVFKy83alc3d2FtR085?= =?utf-8?B?QUljK0dOOWlnUzVtak9BOGUrMVZXd3FxUjcrMks3Nm5EeFNSZGpRM0oyRUJR?= =?utf-8?B?QUh3WWRTcFR5Zkd1UjRYTzQvNDUwY05ocGJTcUwxS2VNV2pUaWJYNWV1TDc2?= =?utf-8?B?TnQxM1ZwQWFlUjVMMlRiMU45QjdwT20vYm5PZDRjN1JuUGcxUlNSTkwrSTBi?= =?utf-8?B?NkVZWUtOYVI1N3VleTJRb0h4RVFYbnpla2Qydkg3VzVac0xUUnNUc3ZFdFNU?= =?utf-8?B?d0VyaGZEZ3l5RFh1UEZwS3FPbkpoMnNXbHUycXFXcXlzVXVXK0FIZERiRkFh?= =?utf-8?B?cjMxcU85aVBqSmFyKytOelVFakZVa3BWbnI1cFA2ejEyRlBCUmJFYjY2dWh3?= =?utf-8?B?dVc2Wlo3Zk9zVFphb3RzdzJJRUpza2dqWEp6OC81dTJOTnBCdVd3Y1FRZjhI?= =?utf-8?B?bmFrazVkUHAwTEdjSVlPWkROZGdwbkY1K24wcyt0WDVjVmo0VTA5QjhoUUdB?= =?utf-8?B?TjJYVElvU1V0Yzh3KzZXZ2JrT1JxM2VYa04wOVF5cDU3SllOVEdYemZCQ1dn?= =?utf-8?B?TXNBNUphM0d1YjE1eGZBQ0plbUhabEIzT1Z0VHVpdlBwV0duVmJKVW1IRTVW?= =?utf-8?Q?C3U1DyX3BEtV5Z0N3pscu1eX9?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e6b282b-1d23-4715-b1ea-08de185d28d8 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2025 09:09:13.0942 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pm+YRZr4ch4hFdN3nhR67SgYzgdMZdHG213lkdW+2KXOD5LFUZmPXDoBdbbL8wYpWutJ8HEyl+sAZ5QUey5PFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8093 Replace manual pm_runtime_enable() with devm_pm_runtime_enable() to leverage device-managed cleanup and simplify resource handling. pm_runtime_disable_action() not only calls pm_runtime_disable(), but also calls pm_runtime_dont_use_autosuspend(). The current driver only calls pm_runtime_disable(). But this should be fine here to use devm_pm_runtime_enable(). As a result, the .remove callback is no longer needed, reducing boilerplate code. Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta Reviewed-by: Frank Li Reviewed-by: Shengjiu Wang --- drivers/remoteproc/imx_dsp_rproc.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index df6a4126538d22ff6e02145edb5ac13c2d72c949..f5d0aec52c56664d6074272e276= edb0c4175c9ea 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -1200,17 +1200,7 @@ static int imx_dsp_rproc_probe(struct platform_devic= e *pdev) =20 rproc_coredump_set_elf_info(rproc, ELFCLASS32, EM_XTENSA); =20 - pm_runtime_enable(dev); - - return 0; -} - -static void imx_dsp_rproc_remove(struct platform_device *pdev) -{ - struct rproc *rproc =3D platform_get_drvdata(pdev); - struct imx_dsp_rproc *priv =3D rproc->priv; - - pm_runtime_disable(&pdev->dev); + return devm_pm_runtime_enable(dev); } =20 /* pm runtime functions */ @@ -1361,7 +1351,6 @@ MODULE_DEVICE_TABLE(of, imx_dsp_rproc_of_match); =20 static struct platform_driver imx_dsp_rproc_driver =3D { .probe =3D imx_dsp_rproc_probe, - .remove =3D imx_dsp_rproc_remove, .driver =3D { .name =3D "imx-dsp-rproc", .of_match_table =3D imx_dsp_rproc_of_match, --=20 2.37.1 From nobody Mon Feb 9 09:54:47 2026 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012054.outbound.protection.outlook.com [52.101.66.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AC6C331A61; Fri, 31 Oct 2025 09:09:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901763; cv=fail; b=EIEaPr1M+ribxPuFAeR71BpkLLBjiNDYRYmk7WUP0yLxo3oQnsd1jqrbD3FYc049hZ7SGw8wgV2MbgdmdMb7m5j/NiCOB8ClGXAY0cAxrUrDdVRxSNSFd43fvDY8+hGjJdPqZ4cBcqf/qHc1viLwyeEZAwSF2FAMw2RpyR9WjAA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901763; c=relaxed/simple; bh=RlzGlQnFPc/KkSI6YYktzK6jfPoQbFAXSfX40/k3MaI=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=XtN0J+lB52qkgH8/WIvaCiNpB/ZMiMsZf3vhAXrhwxADHevz0Iet8PzyaueUIjn+hzSHd63nTwIUbOsvt8w8Tx/57ldaEK4kN7wb7pEtpopKyyV+YZlGU4urJLgDKFIOqiXfUWyplUbXZrSMucXDHiSpdxkLphkrkRtqSBrgBUc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=KieAgvKq; arc=fail smtp.client-ip=52.101.66.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="KieAgvKq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XgV26JhJxKX5iXdYL/zW52CUU+XOY+pY1vZcuFdmTN0aueFhoLNRY6+oZG28Qe0J5Byc2380EsG3f3od2gZqPESxLx5mKAGMI0b+UPjfEKZ3fve0+jB4GXnM8Je3f5cbXfGvOndJlbLNW4ibO2iWOuUBZND2fGysXOrW60eMUWUZA5BtPnJzD3LOLK+W09Xpe5OOxqxAadbPPLakXmZDNZmSjPtq4R+ASFMMamyygOPkG+PCx7Wsv0e8npHtFZbesV68V8emnyOz3eqSsGML/vJuLDmTRZfMlh3tQ4Ontkbgl1BIRZtnFdVEDkAzl9qO1CagqDE/+8bdRE80nUbl8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cBpOkBubN4heEExReyxthkzYdvVbPXcR5hSXAD2vzMI=; b=sPGIKotwVqtFAyaMhBI9iLms6j/pMBnwVeeTDm2BNkmT7iiveRAxyHCGAAD2KJWpQ7qjuFLE8XuX7hsqeOcnGeQ5TXg/waIOiboeLgmyRMnkvrVAGKXND2J406vW9UEHICi6Wr6P8Q2hyvHhoM/9sgTker1a3QqTbMx6k+tDBwLQuS4JrzOBZQtHsSAMRflbvQqMER1WvUfYrMwgH+tfKzZ7ubUYogiCU4XBX200141tjyk44ZWJLEjXmhw7nBfpmRn35RiNABbGO/4Ggap8B/aSQ7Q5F5mjFVjfm8Y05qQg5tkey8URZybhsrAXNVo90KChm2ij0fsVDFvu/AxWrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cBpOkBubN4heEExReyxthkzYdvVbPXcR5hSXAD2vzMI=; b=KieAgvKqYfMwu9zM/IiCr2MVc+NLT3PI7/gPGxWBVgPb64a7/qCRgdarxzIEsNytLZJ48m/lob4nFsNKng1uiDmOR9PBOmMAt1kcbFYmEPiFpplw0MnpHOv8CiektAOZWGcOaD/fM5hnHHzQlasp5FsRvN5NzFI8E+t6bEUiBCyx6CgIDMOqDD0cvh3wU5kpoiThK+ZIcKW1Ak6XdZeUU1BF1e7TCP8AfCAQTi27Ila7Z0CKOu7RXfaqEziMnd/XdNMhngGrxi5+L/91hz181TQBVeXXAItueCyETjcJd9l0swQXtotUE0qyl6xHM9sqHK2Gm6srBBCeTgGfQbLFAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8093.eurprd04.prod.outlook.com (2603:10a6:102:1c9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Fri, 31 Oct 2025 09:09:17 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9275.013; Fri, 31 Oct 2025 09:09:17 +0000 From: Peng Fan Date: Fri, 31 Oct 2025 17:08:33 +0800 Subject: [PATCH 04/11] remoteproc: imx_dsp_rproc: Use dev_err_probe() for firmware and mode errors Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251031-imx-dsp-2025-10-31-v1-4-282f66f55804@nxp.com> References: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> In-Reply-To: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Shengjiu Wang , Frank Li , Daniel Baluta , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1761901729; l=1665; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=RlzGlQnFPc/KkSI6YYktzK6jfPoQbFAXSfX40/k3MaI=; b=2bgP9b5cs09ncO7y4AxPhrQCMP2D7SULjKCb0+/MGCAn6b/ZRXI/1FefjfRXARB4+IUH6gtA8 6zM5tN1TEmlD9OeTPWA9TPFKD4u+G1RyPRT74Jv7wk/C4Hu7BpL7Di6 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0010.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8093:EE_ X-MS-Office365-Filtering-Correlation-Id: fb0e5cf9-e938-4dba-9fd3-08de185d2b94 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|19092799006|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eW9rZzErZWNoSUJqWkhSTWRNSnR6S2xreDJxT0xpUGFLblhyOU80cmVnMWJK?= =?utf-8?B?MGlsTDBXbGJpald2RG43TEFJMGxVZ1Y0YXNCQ1RhSml5akxQSjNvaURpUHRW?= =?utf-8?B?YlhZWHVzcWx3WC9ZOWdJbkd5RG96NnJBNDdlcXVuY3RJN3lzSzBONERKbVUr?= =?utf-8?B?SEVrNmFWS0FYakFuaEpMUlB6M3ByR3JWcVg0OFVLVE9FeUdGVzNXaUFodnJi?= =?utf-8?B?YlNJK3BKNjMyUnp1QytMVG9ZZ1FCRnRkb2VIbWdWQUpROVduU2Vwa1dQRnU1?= =?utf-8?B?UTdNeGlhWFp2ZHlTSUdVQ05IQThBWTBDNjRpMTE1eXZMemphTGJrVWRXa0xF?= =?utf-8?B?Yndld0p4b3NyUy9PRkswNGVrVk9KTEVPd3ludHhOZGd1bklXWEtSTW5vMVBI?= =?utf-8?B?d1RpU0YxazNtT2hobkdHMmhJUXV4dUFHd2xGekVnS1Y0eFhDVGxtMFRHcnE0?= =?utf-8?B?TFc1dStBcmdRSkRnUnpBdmpoZ0dsTmdISmpCMUdDUGdRYWZHTnlzTHc2a2VS?= =?utf-8?B?MWR5amFSRGZaTVl4QUhzTGMzTklVUDZIcXZjMXhzSnR0WmlDcHROU3hhRjRj?= =?utf-8?B?cm1nMFB4czhwQ05vSWxqL1hIMnNjQU9PZlRETGlXRVhJeHhUMUVXaEV5WXNP?= =?utf-8?B?ZlFNZ1VDbDZNK2VJVC9aekYyZWlqdjE5SkdzNWxWWmJsbWhQNUNQU3puRVJQ?= =?utf-8?B?KzF4NC9iUGo1MHJqcHE1QVk4SkNSQmJKN3JSRXFISUs1WkZCWjJrblpLRGlY?= =?utf-8?B?enFIMFM5UDFtTlpoakNqUER3VXJiZUdDS25OdFZ0cTdxQjU2MnVqdDNGNzRO?= =?utf-8?B?bndpS29QTzlyclM5ZEgxeW4vNmkxOTFUWFAzd003TjU0NjFkS2pxRnQzSHNF?= =?utf-8?B?SngvZEQ1UlUyYmVzV2V5Y1VtL21lTk0zZFdhN0dFOU1XUCtYS3JLSFBnN0l4?= =?utf-8?B?WUFGSjFvZ0ViN3I2Y2d0dzlvODUvWGg1T3lESFhSSEhOS0E0eitRQzdBYXZY?= =?utf-8?B?cGVUOStpUmM3QXdJaDFnbzFRUDRrN2dkODljSk91STdKaVUvVXo4bW1nbHNJ?= =?utf-8?B?YzNkaEg0RkJJWEFjNjF1ODhEby9kOFBWNXZOWTk1ck5ORXVpUGxkQW1pZ0ho?= =?utf-8?B?RHp1V3ZiZ2JOcFJHd3Z5c28zckEzWEVXZXpaREs4cXdoV09PS00vWWgzYm1G?= =?utf-8?B?V2trTnYzcFJqTTFRTkFCYTdYNHhWZ01uazVHd29XUVJra05KWnRlTXB1d1RR?= =?utf-8?B?Rm1IM2xyTDg4M2JRSGtiWEh6c1B1ZnlVZ2NWZjFhbHd5Lzk5M2NWQzBBOHVl?= =?utf-8?B?RXpkdjNnZFRoR3pSVDVvemhjVlA4MEVNR2ZjSFRvaHE2OG1kLzNnNGVqTjFa?= =?utf-8?B?REtDK2J5Z2NTK3BsNmJiUGZPSnFFQkR2MWdBa2l3OHZSbElYRXpGT3lmV2Z2?= =?utf-8?B?a2k0M2M5ZkZUYm0vQmEzaGMyZHc0TGlYcmYrRHYwWlMreEhmT09RWWZkS211?= =?utf-8?B?SjY1dld2Tk5ieUNhTDVaTkpudU9iN1czbm1uVnA3d3puWmtoT2o0cnVveHZE?= =?utf-8?B?dHJudVBDVG81aHJmMGR1MVlaT2x5Mm5iTk1ydkZDb0JiUnJRQUU4TXBXL2tC?= =?utf-8?B?VXBib2tPU05JeDJBOGlXSzFHaTJON3NnaC94cWMra0dNMFJtZ3d6R1d6bXFo?= =?utf-8?B?U1hvVDBOZktGYWgrb3h6VEFjeDN3dWlIYkFONHVTT1NRUnBnVzBnWGpENllt?= =?utf-8?B?c1NNQWgwVmU3M0tPRktxSlRBVmFUNlJsbUVYRkJGdG8zZTA5MExobElxQmFS?= =?utf-8?B?dkpXekJwdXVZcXpIeHlxOXhqSkErdnM4TXBWcmw5RGVHTHJNUmxpeTFOWVox?= =?utf-8?B?YWZERXVGS05UVzRrS2xHY0tXZlZWREREVEFzM1JwdC8rMGE1YnFlU1pOaGVt?= =?utf-8?B?RDZxeEJiQ2V5SW41OWpMVmhrWCtiZGthaXlCY1FKcmNhWUV1U005VmRwaGJ2?= =?utf-8?B?bWVmVWVNcTBiQlg0Q2dYNGhRVnhHYUYwSlRNNnAyWHBpYi9jVnc2V2Q0TGQ3?= =?utf-8?B?QlVpeWFoWm1FcENMMGpLUm5wNWJtMkt1MTJyQT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(19092799006)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEFpVVYvVmNacUpGY2pDYUZtZXFDcSs1NUdtcmFJUTFTN0xVMEMyUXFscDBa?= =?utf-8?B?WjNhcDJBNzF5NVg1WW55dGlYT2hMVWhMbksyblJlK09rQU5IdVplZkhFWEQ5?= =?utf-8?B?dTJyQTUxYkMxNVZWQUFlb21mS1FhNkwzQ0NqZVhZaUx2UDhYNjdVejZTdmpv?= =?utf-8?B?cVJKZW5NMDFEMGtteEhRYmZoT1pNZmFlL0Q3M0JXUEluWjZmMGFYK2g2OXVy?= =?utf-8?B?ckNEa1plYXFUR2hBcXBWeGE0ZmRsVzlmdzg3dFB4YW5DcHRGaFltT3RMUWtx?= =?utf-8?B?T1AxQ1pORExIblliWHMyaUhwVTdmOXhlT1BIdDRoa3BjR1BPSThMR3AzWVZz?= =?utf-8?B?eWFoOWFKK2YyK2swVTNXSGVaQVNldjFOcWx5c1lmZ2lMdDhqa0RhMTgrRFJH?= =?utf-8?B?d1NsSVNUUXJtU3dDVUVFUTBPSFdEL3JVR2UvYzhwRU9mcGRUbzBwdDZySHZZ?= =?utf-8?B?VHZnU3NORU9hb2tnMGUwTnI0QitMWERDaU9pOThrR2RicGVRNm5JaGgyZHNN?= =?utf-8?B?QmNFU1h5ejJxZTdld0lHVWNXY0pIY0dNVEZaY3l2bXBhdGo2ZzhSWWFvQ0E0?= =?utf-8?B?Ty84RkNvb1V1SzdObFZMT2JlNXZFb0I5YjVYNFlheFVBcnBtM3ZwSFZrdjcz?= =?utf-8?B?SERHL2lra2xxck5DanJKSHBVUGRYQjNZdHdxalhEajgyWU5kdUFWOGxZckxF?= =?utf-8?B?M3krRzZ1R2VtYS9oS3V6cTdIL2FQOUhEdGwwa1pFbnNBN3FYL0lpRDVZNW9p?= =?utf-8?B?OVBNanp6NW80YnZMcndPMFM2bTN6YlY4LzEwUTZsWEtibUJicDFWNldwK21Z?= =?utf-8?B?UlZQRGpIcERwVURNOW82R3BXVkZCM2kwRlNzS3M1aHpiZmVPUWwreDRLZ05L?= =?utf-8?B?YWhWc0xUN29PQXZRN01IK0JwT3RDWTBkSkx3MUhYZTA0RXNDaVJaRTdTRUdR?= =?utf-8?B?Z01BU0lwcWFzaGt3OXZ3WGZaa0kxM1dtNmVydWZXSG8zeGRXNkhpZ3lycStT?= =?utf-8?B?aWZId3hnUnVPQnZzTS91NitXN2pudkIxQU90bEJwczlkTlo3WS9uamVCdk5k?= =?utf-8?B?NDlrS0Yra2tNMldzZ1ZIY0gxVGhOOVRIRVNhNUZEaUhsbFR3TUxzSU5qUWRL?= =?utf-8?B?MU9lNGh6VGFIYVpnVCtkRVJmd2JwN1B3dFlUWWVCTlppakFEa0pQUWVMTzRC?= =?utf-8?B?S0p4djh5bndwTG5tUHVaWjkwSzRQM3hVTDhYciswRjNZQnpoSUxZNUZ4bDRP?= =?utf-8?B?QVJ0R1EvNk5YUTZTSDlobGZLNW1BV2sxR0psalZ0eXo5QldIWlpSdno0S1JS?= =?utf-8?B?YWtmUUY5MjFjQk55MVBhVlIzaHNiK2hjRVVRNTJvalZPZ3hUOE1oNjVjcEYr?= =?utf-8?B?aXRWZHdxeDdRZEx2M2JxMFNuNFhGMFo3SEhCWUtWVERvZW9SUW9nZUZCUHl6?= =?utf-8?B?bWh4cWh2eitLOUNsYkh5Nmh2TmlwU2JJRTNONE4xSHBmempRcmdad25qamNP?= =?utf-8?B?bDJMQy9WaDlNZVczY2VsTEhCR1RKanJVZVlmL3gvN3Nray80OG1FRVU4Unhw?= =?utf-8?B?WkU5NTh3aVhXdjk0WUVGRloxdTdBVWxoQXZFUzJoUDlTK3dJWW1ycnY5Mm5l?= =?utf-8?B?SGwzQWtWZnIvSitJUTR5V3o1Slo2N1VLVGhhNTJma2ErL0xZYlJHREVXeUJQ?= =?utf-8?B?ZzF3MlJGWHBZaWx5cVE5UUxKNGNtRTErNHhKUHpHWmE5SFE4UnRETWtZRWNH?= =?utf-8?B?alNXNUU0cHhKTXVDcmg2UzhROTlsODhXMEdoUkJSUHgxeXUwbzMwWE9hQ0NV?= =?utf-8?B?S2sxaXJaaWlpZWwwcTNFWWJFZzlpZUVIZWE2RE5wTy8vd1hicWE0Wm04ZnAw?= =?utf-8?B?NjhZeTVMVFBjampVSGNGN3o5b0wreVcyM3NMK29vTnk2REZveVpmZzhOK0I0?= =?utf-8?B?MGJlanh1ZUZBSmxvT1lLRGIrc09xeVFJd3pNeXMvSWZoTkQwMUtLaExsN0Q0?= =?utf-8?B?b25RRHAvVlVVekNEQlRNZzVnZXNXblRUaFNrN1R5QmpXQjhkckVJeHRKQTk5?= =?utf-8?B?TlE0Vmx2VHAzNXI3bXhJSVowUEtudXFyZkZ1K1M0aDMwejFEdVpmYXlFMHM0?= =?utf-8?Q?ZaPJ5+XGrI5ty9xZkFbb6hUE8?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb0e5cf9-e938-4dba-9fd3-08de185d2b94 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2025 09:09:17.7012 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ycUylTRPQ+mwQHgJYtIv8uWYbBUaBiLJvb+xB+tcZvlCkox3KYRmpV5466lOxClNa3cEFxh+YxzGLQCQnlQkjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8093 Replace error logging and return handling in rproc_of_parse_firmware() and imx_dsp_rproc_detect_mode() with dev_err_probe() to streamline error reporting and improve consistency. Reduces boilerplate and aligns with modern kernel error handling practices. Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang --- drivers/remoteproc/imx_dsp_rproc.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index f5d0aec52c56664d6074272e276edb0c4175c9ea..87f4a026c05fbf1c9371058290b= 2d33cb94b9e54 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -1150,11 +1150,8 @@ static int imx_dsp_rproc_probe(struct platform_devic= e *pdev) return -ENODEV; =20 ret =3D rproc_of_parse_firmware(dev, 0, &fw_name); - if (ret) { - dev_err(dev, "failed to parse firmware-name property, ret =3D %d\n", - ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to parse firmware-name property\n= "); =20 rproc =3D devm_rproc_alloc(dev, "imx-dsp-rproc", &imx_dsp_rproc_ops, fw_name, sizeof(*priv)); @@ -1177,10 +1174,8 @@ static int imx_dsp_rproc_probe(struct platform_devic= e *pdev) INIT_WORK(&priv->rproc_work, imx_dsp_rproc_vq_work); =20 ret =3D imx_dsp_rproc_detect_mode(priv); - if (ret) { - dev_err(dev, "failed on imx_dsp_rproc_detect_mode\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed on imx_dsp_rproc_detect_mode\n"); =20 /* There are multiple power domains required by DSP on some platform */ ret =3D imx_dsp_attach_pm_domains(priv); --=20 2.37.1 From nobody Mon Feb 9 09:54:47 2026 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012054.outbound.protection.outlook.com [52.101.66.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D280332EAD; Fri, 31 Oct 2025 09:09:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901766; cv=fail; b=qgh5sux9eloW/pNBchguqn9o1SaXjBGywzTXJGi5hWspKcYrz0SmpitFbO1qe4nLSi2gLVk+Qvr+pGkuVxAdrqcLAkDpj0a3oCOtPrQC57efl2Jip3+s0LWm0cTiggWQABmmwDlSb0sClcClD6zdK8amtE4aNprWx5BTpgkb0zM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901766; c=relaxed/simple; bh=V1wY2whHoYIs6LbpNSL/+L2nJSdPC8RsEInrOIRqgk0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=ThBLSqO1J24fQ5wijGA71asnMPTv1d8U3ExomIYwDlDPH0Csr5HfYw1elYlSaaVzfzn3rBpgDRJ6raqDfqB9QnHN4VkMlsdO+FOZpSNzTiFGZbqV5TEJ0K6hApFb9nTD2g6MGvxm+inMq89rMVZOPYL+CVkY5/GTQY0AldDZXMs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=h2OpX47H; arc=fail smtp.client-ip=52.101.66.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="h2OpX47H" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dS1mr7QYzjyhmvvhjQPr9V2kkNUDJx0oxvGEz4iFas/LY8zhcsTqKjf6NNRY9cUrL/KF+hnGMIhydxh2DAS8i2xSBImpvDquQ9/5q3Jy9DSxMmI1KERAdqHKp/6J9kALJpC/63kGhoAbnw8rcrjuQZXblHFh88hMoQMsehyrM84szZdm/j2GdyiAe1g06ooLNXDpXY2YFCQ9C2pE6WHSAr4vkZZ6kGWlpQl3q+rPGu13kyb9F8McdgbUujjWOdH7AF0XLi5ZkBf98CpcRLjVrrqMhOBYiAe9l/aaZY4v1C+BX7pO8fzPMOn3RnGafsHNrJHZmOMWywHqkPRQKoC3mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iifP2+n4W8WztHeb1dwl8zJOUZ/WW8C6A3vbODMHHkI=; b=RDg9MzvPb386wK1uF/2g+mcZ2HHAi31fqzO9qOIna3csmeJkvQMX5LK1tswd4Jhxgcwg+4/v1uOPBQvEj4PGeu7gqOfIVo8qSJEK765V85rQDQANIFB3rNkNr8i+/AvvzyndXAo4VC9l0LMJqGQCKXYXsVyvR250AFoD7gKCBu/9z0ZLONR8xwznuAvDPzx2DVWu54mk2QnKth02tbf0bG4+30um53OKXmX0b/PZJ76qqw/YDHtXiMfZhqzyrDgkaE2XdW0BS3kDyKm7VqU5nSnsQzP2ioNO/OohBVOzD83RubkL1o6PVr22PGA97re9jI4P4ERY7V35aGzkYpcS7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iifP2+n4W8WztHeb1dwl8zJOUZ/WW8C6A3vbODMHHkI=; b=h2OpX47HSXlE08+UyiufVITtdI4NfVmGF5nh5yVcEnn6/BwLd5uxGQOtUYlLgqOx0m9INL6YlLUciDKxOui7mUHBtw9SfB+4SBr+ZbQRZRRanIa1f2FRueaHxiYaL1h5A5CfU+0r3QECVEciTjBWbz0QSZiAnUAkoOecJemRmQrh1KnnnbizZ505D2YkuH2UAQZwSztD8hBccAEYrIg+yeySJZNpc4tQvcDcupuHub1YMAx8so1rWMpVCQjXT1GLsRS6TJSGYfa0XVHhgISPqkkzeRI//52qase1CbXqLzz5OpucX68af2czk2gQr9jfLMokPN9keZe7nrKLd9Wgtw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8093.eurprd04.prod.outlook.com (2603:10a6:102:1c9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Fri, 31 Oct 2025 09:09:22 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9275.013; Fri, 31 Oct 2025 09:09:22 +0000 From: Peng Fan Date: Fri, 31 Oct 2025 17:08:34 +0800 Subject: [PATCH 05/11] remoteproc: imx_dsp_rproc: Drop extra space Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251031-imx-dsp-2025-10-31-v1-5-282f66f55804@nxp.com> References: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> In-Reply-To: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Shengjiu Wang , Frank Li , Daniel Baluta , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1761901729; l=856; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=V1wY2whHoYIs6LbpNSL/+L2nJSdPC8RsEInrOIRqgk0=; b=SvYSMuZvZ5YdXntMbFqFk026ZbPW3nmuBEfk7Wt3mylhPjJJ4WJhAYCbBTBMJK3y32UmDxDtE g4744W6/1HCA+8R6sNVaZDjRXyL13yOqNCLzrSF4zfxfQwkJ15jGviA X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0010.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8093:EE_ X-MS-Office365-Filtering-Correlation-Id: 797b0f0d-0252-4f2d-bc12-08de185d2e50 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|19092799006|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?N05wK2VDdW83bHJZNkFuU29hWC9Yb3VSUzgxQlBqODF6TTZqSTVzUTJEaktz?= =?utf-8?B?eTg2NDRFcERHL2RFZWpJOG5lOEFYUHdDaXlobklqSTdoMUg4MkZrUVRjcElh?= =?utf-8?B?MGNUZ2VwMzhrVHFBVkliS0hjZXR2NnI0cTJxUW1sVE84NVZBL3B4MXFYWEJp?= =?utf-8?B?c3haV3JqNjV5eUNqNVo2Nlc0Z1YydkVzWTFJdFhkQzhSV0cydEtXMmVoR3Z4?= =?utf-8?B?VzdwV0x3S25tVk1tTXd5bkpDUEx2b0x6SVNzZ0xqOWk2dnBaVDkxQXFZL3hv?= =?utf-8?B?MmlSNlNjcnlncUhwdTZQUjJwb1p0dGs3dXRscGFYb3E2TUR3dGdxdEFkUmh6?= =?utf-8?B?Q0I5NDQ4R2pHcytRdnZxL0ZEOXJ2RVN3MGg0T2ptZWlWaTVRK3BFZlhueTBs?= =?utf-8?B?Z1ZNQStEcXZEdGhoWkc3UGR6LzdTSlRnZnltZnJRNzQ1UjB0dXhNWGlldmRF?= =?utf-8?B?ZDdYQVRROVlnd3B5V1hCd0FjMEJFRGtZbXNYa3lCVmdETVA3SkpXTkw2L0JB?= =?utf-8?B?K1J4TDd2bHR5a0I2VVBpejBGVEFUcnhCY2xmajNFQk9TZDFWOTlMZFB6YXB5?= =?utf-8?B?RXFpSlpsMnFJR2ZkNHY1QjhpVWhXalZCNW8ydGpMZzlZL1FVdUtGSjNwamxF?= =?utf-8?B?aEphTlBLQzZlVXVBV1AzK0l0WndxVkRYT0dOU0owNDl0alpIbkJOUVJqWm92?= =?utf-8?B?a2gwVVBtYStLMXhLdUxxMVIveUIvWjBFSDdjaGZaSHRWVEU4L3BnL2U3M3Jn?= =?utf-8?B?WXhMc3ltTTQybnpsdit1dTQ3MHhTZTZXUEh5R0YyVTFYT0RJOXhaRUlLcU5w?= =?utf-8?B?Sk5vSStXL0t5MFRTODF6R0pCNDljc0dTK1Zua2x0bW1QVG41dWtHTzFVRGE2?= =?utf-8?B?YnBJTytaMmd3eUhQYUZEQ3JQT3k1bWd5Lzk4ZWljK0JKWnpCWHRNT1lsRmRh?= =?utf-8?B?a3NETHg1K2U4N0pYRWw5VGlub0ZGYlNOMEh2Y2tNaTJQZWxhSDEvRXdpYUtJ?= =?utf-8?B?c2w1bk4xRjVTZmRZLzQ5NEpzbEVYOWMwNlFaV2RMS3JCSVFYOFhRMzZDK0Jn?= =?utf-8?B?em5LSWc2SGVLR0RwMDJzK0Zzc1R6VmYxMm9SeXNqWXpUUnNQb2Q5dGkwUnR2?= =?utf-8?B?dHVuTzAzZU9rTXRpZkFVRFNyaU1FWEwrOEpGbGdNRjA5T0VnVXdyMndIZHV1?= =?utf-8?B?ZVdkZU1ReGR1ck12V2xha202WUxyZXpXbWRZcG5HTUU0TlFJTXpUdExHTmFM?= =?utf-8?B?WGpVV2VWR0ZNNDVQZ2x1OGx1UUluLzhSdjFKTkQ0R1BwYkFVWUdkMzlTZC8r?= =?utf-8?B?USsrLzR3UThpVVp6YlNtY2VQNWRRSmlsYmtzTEN4OUI4cU9SSmo2TThmRHJX?= =?utf-8?B?MDdvTFk0dXhIeWx2WmdrcEdvL25oWENISnBQTjlHYlZUcEpMeDRnR3loa01a?= =?utf-8?B?QnZRd3p2US9QTDd1anRUUitJdmxEaTI0eVphTy9yUTd0WEREbVpGazNjSTBH?= =?utf-8?B?Y2wyaEN0K1VydDIwYTh3K1FBclhXa04zdUNSd3QyajNscXhlWlUxVUJxbjBX?= =?utf-8?B?ZU1PbmZDbWprU1RDU2pyamFSWjNZaHZHcFM5Q1J2N2tHVTFCeHBLaG83UUt1?= =?utf-8?B?ZCtjeHVncVUvNHFvSWhzdmg1NkU3NGZXSkFVU1FKbHhBcWVMV243a011a0Jw?= =?utf-8?B?QnJmN0hUQlBMazZmZ0hreEpUVUllU2FyQjVKNFkyR3hkZmpDaFdVdkNVSktk?= =?utf-8?B?aW1JRkdFQzlDSWxmUTVEOXByM1RzcHZSNm5uRXlPUndQeFhLTWY5OWRDL0FC?= =?utf-8?B?V09nR0N2OGJpZ0MxYjZrdzFlT2MzblhDbVN2QndsNnFRMTEvMDZ5aVE2dlFr?= =?utf-8?B?ajJkSndWY2YreDFIVU96c2pnSWpXUUpjRmpLRmtWMzZMRGdrVE1sTTZ1Umcr?= =?utf-8?B?bHU0dVFpQTRwSFJsMm9VclFrcHM4TDJkUlN1MzNZZVhLZHRMKzgyZ3ZCbGtM?= =?utf-8?B?THVLT1BPT2picUUzSEFEY0swaTZuZCtVU0pmUFdtVlRBYVNJb3NxTjJjWmZt?= =?utf-8?B?QUFTQkQyZXlhSTBqM3dOeGJOZlYvdDNud3VOdz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(19092799006)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2VYVWZpR042RGhIZklBRkVxbk1pcGQxQVlBTUcxWlZsZXFCV2RKVUMwQlZr?= =?utf-8?B?Ky9JRmpnOUVKRE5ZeEE3SVUxRld5S2VtNHFjSFRVSjY2TWxEU3VZRktMcTdD?= =?utf-8?B?bXVIc2xDZmJoKzREdWRZUVV3WEZSYXdKdllPUEh0cWV6N0ZFNDNmQWJOMW1t?= =?utf-8?B?MFJLWTdBU29HWnNsU0xZL0xYbUZWSEM1MTgwRmJQVk1rT3R5eFlqRTF4MTA3?= =?utf-8?B?bU95MUozQitRZ0Irczh5UVpneWtzYmV4OHNkUE1iaGl1bEpFYnRkZXlaVTVy?= =?utf-8?B?My9CWksvZHVHOVEyQ053U2pwQk5nYThrcW1mcmp2UXZjV3NaVzNOdWxEOGNW?= =?utf-8?B?QThYR0FwbXZUNk9Gd21yc09uS0dwU1lkSWViL2lrU1J6d1RXbjU3a3dNM3Ri?= =?utf-8?B?Q2hXNFlwdVFJcjdteU1WRC9TWklyZUFVdHBMUCtoa2p2d09tTkVVeWJtY3hJ?= =?utf-8?B?Y0hMYWFqNGhCUmNOTGhZREQwRmtiQ0tRNGIwVmJ1UXNiZmx5RUYyZ29SRDI0?= =?utf-8?B?RC9Yd01rTHJ4aDVDZWNtU2hQbndTVlhkVWdocW41YVg1WU1OYStEOVI5NzZG?= =?utf-8?B?VVJWaS8vU25ScXFkK096YUpseEdYRTlXanpCOXhqTGR5OTdoek9TUVVKdFkr?= =?utf-8?B?dlA4RytWQ1ZNYitWdmZRUzR5YStzZSt6UHlyZDY2ZEd4RkJEdHlXams3M1Y4?= =?utf-8?B?RGtESTN6eFVKQitDMTJVaDlzakF6RE92MnB0a3AvK1NRSGp0R2FiNmUwU282?= =?utf-8?B?SkVKblZHSitVZVBRSjQrR250Y3d2bERhMzVIcFN5R3RUenQ0UkRDaWZ4SFJZ?= =?utf-8?B?L2tyRy90Y0JXVnJlZG9HdldJMWdObjBJRUhycFFNYnhNaXZ3ODFBN1NTRmpq?= =?utf-8?B?RkFHc3NzU3lpK0xLQUhxWWVDdk1FTnVZdlpKTUMwcmJ0alc2OVZZR0FmdytR?= =?utf-8?B?MXFSWGdQMXFuM3B6aEU5czlpNVNZT3VHZnpZSndFS2p5OVhpVkJJRGMzd1lL?= =?utf-8?B?TWxVUmhoVkZnZTZqbElGRHZ4dlJIV1lKSnQvT1ozZ01IVFc4Rk5vZjZUc3U1?= =?utf-8?B?NmowQjRDWGd4L21vTWtWeEVsbGlvd0pNanVidnh5SW1tUzJKd0JCQ05OODBQ?= =?utf-8?B?TUo4ZXoxUXRybElsanh6QlBuVzJndnoweGhjUDRVWkptTlhQMlk4QTdON2gv?= =?utf-8?B?WS9ydEkyemZoZUZiTmgvYUZYZDBQbEZWeHRxdlRMMGF1RmNxMVJIRDBQYWNq?= =?utf-8?B?WDRHNzNSVUVoSFVYQ085M0VSN05SR0d0RDR3cFVzODlSRW5sR1QyQVNtZU1C?= =?utf-8?B?Q1Rmdzd0enVna2dNNE42Z2UrOWsvaWVaR0FmbWR3WFg1cU4ya3ZETjlpMHZz?= =?utf-8?B?UTBvYUF2OUVRK0NqdnZIdWJ6VmE4bnQ1cVcxRy9qUGJtL0N0TnZFNkRTU1Fh?= =?utf-8?B?S1JlenJjSzRPSVJvR2gwNWRIRjVKdVhEL3cvbDFGRTBaWjdDVG1BdVdKQnRq?= =?utf-8?B?b1hEVFdGSWVGenYvOXBoT2dnTXpJWTZhWko4SDJ0RXdUT0d6RnBJTkFPTFVS?= =?utf-8?B?d3RhNnlBSVY5UVNxVGVMMTh1eWdpMjNTbmxaaWNLck9kdit1cTRDVFhzRXlU?= =?utf-8?B?TnlLNkVsUm9VSDVFR0RiTjZpMTFtVVBRb2xaRGVoakFaWUpiS2wrRk9uY1Jl?= =?utf-8?B?emxmT1FDaEFKTFVOb3RDQ0pONHo0cE5tNm9RRkw4WkxBUXFUTnR0cXFjQnVM?= =?utf-8?B?UWlLOHAvcHY0YlZsbWsxWDJwbk1NdEpZNHF3UHlUaENocHpmL2xiYktXUFJI?= =?utf-8?B?bFFMcDNtaFdwKy9xelVKaDBHL2lYSXRDZTBHdVNSdnQ5OVhCc3FjRzdPMEZk?= =?utf-8?B?cEhwMUphY2l3LzVrdHJaTW9oSDE2aGtlaGpJQ1BER25uWnpGNFh4Y3NSM3Qx?= =?utf-8?B?dk5wdmhlSzJodnBQUzZjUTJIeEUwNks4YmJLdExJMmdzTGRiaXBPaUxPM2Vl?= =?utf-8?B?M3ZvdzBxSHg1UnM1TlMrbTVLWHYzZzlqcStmMm1ITERrc3ZSeTRTY0JkZDNH?= =?utf-8?B?ZDROY2tYNHJtMWJ0ZGY0cHVYRVFEZlJaMnkrNjlKajNCUDY4Yis0SlZPcWFt?= =?utf-8?Q?Z7cVQZCbKUNv8Db7PLGgQaj+6?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 797b0f0d-0252-4f2d-bc12-08de185d2e50 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2025 09:09:22.2937 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w5T3Vc0e5nR0zbO4gY4EcnVFLKJ2GQdF6PNAXDPP2z66Ze4eW9x+XXHmFWSrLurDxPuy9kpo9vY/ROAK+97AiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8093 Drop extra space between return and zero. Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta Reviewed-by: Frank Li Reviewed-by: Shengjiu Wang --- drivers/remoteproc/imx_dsp_rproc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 87f4a026c05fbf1c9371058290b2d33cb94b9e54..1726aaa1eafb9ac1a913e3e2cae= a73801b86dc09 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -784,7 +784,7 @@ static int imx_dsp_rproc_prepare(struct rproc *rproc) =20 pm_runtime_get_sync(dev); =20 - return 0; + return 0; } =20 /* Unprepare function for rproc_ops */ @@ -792,7 +792,7 @@ static int imx_dsp_rproc_unprepare(struct rproc *rproc) { pm_runtime_put_sync(rproc->dev.parent); =20 - return 0; + return 0; } =20 /* Kick function for rproc_ops */ --=20 2.37.1 From nobody Mon Feb 9 09:54:47 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010016.outbound.protection.outlook.com [52.101.84.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97AA5332EC7; Fri, 31 Oct 2025 09:09:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.16 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901771; cv=fail; b=j7Ue2CPnMN4IMQLhtcQGXmlhBJ4BWi2IEBSwQd4klwyl2jLeY960Gbbdz3wL6zF6Rykk/PW3JKFarFY2QAsH1aMnnHccFjfhELjN4pKrEVjZhsitTG3f2W2eyZmYA7jiyf1eQnHtAHJrJqvChNGHblUG4pOQv+SDlvchK6hOvnE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901771; c=relaxed/simple; bh=a5bjtYi1dCgVkA6kJZOKMqe6plO4lSpIcgHrVPzVNAQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=fP5EzpVsvBDq7O7Na4Te/bazyEi5HjJcJ+iYZEd9EQpyMkb2F4iQCLYXIr5cxSyTBKbj8lX96rgcnS6HYtVxowt9+07FlOJ3IyoN98IiWpYVQ5TQbInP7audY+aXQh4TZM+hG9b7xdbjzzWVwNukQFHv0f6hg/HLL3E5sn8O2GU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=YEreZ6op; arc=fail smtp.client-ip=52.101.84.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="YEreZ6op" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UAuX4BGAEBOFgApj8IujHfR0WR3zDEGNQbVT8VaqWd13Yj9C/cttEinHPgpEd6MkdpBmhd7t2MDWv/DCD95e1jOfMRnxsjGDavRYhQag3L6oz+kb3wsO0IesQcQL41nWxvudFxRm+Eh6heFc0Vxzyji4XxuHWI+LrIDVGRK3s8VaYg9Z0h9GF8BQg2s0fIaFxpdIyfKH878rahafqR98B0L/+tpCxS5DCzpNJBXvniF/xW4izMvhzlH3Oh4HbBaaqXsFMugVcKwKx73IwpzXONLUPj9j0PZe/h4UaNsislJSGE/PpNptEd/GvXTiq60Ru6GNnLETFZZKoQfAPEmW3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/JuE3n0WDwBu2eoMypY9OssqVbIsm4+tCSEGcBtdldA=; b=yIA18ggO5l5oNz2IcW8nGf7nnFyWHgMJTvAZphp+mJxN09TDC3hoFTtYg91CnJHRdGEVCvoyaRHp6ltg8ip5pnHpIPfuvQ7iDn8xG67ss83mYhwbGwCIhaFz4UgBwO0r7Wm8Ad1ijrYd0siKB1ChIiM9BN6T9GoTifhYjKwSHUUvj7zkYbwG14Fz+DdiuEiOcbF2P83BWMB4sJzK1KSEgffHsPyV6GpmT+hJ6ZZs2CM8YQS9qKIPvmv2CRMEDeMW/FmqiZKvQe+ZKwuNA2wC1l//M+jbXXEJ86xP9jewPFIMDT/wIYwuB1n1RHsQeqINrIK22Ttsw13eSvW/2c1tzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/JuE3n0WDwBu2eoMypY9OssqVbIsm4+tCSEGcBtdldA=; b=YEreZ6op77biPfowHSeZZPMV3y2o5j3iG6Vc3lpLaEooldN1pgBxbQAGBEnfEo2CPR1+8bORYFJwrB1WmjCzdlOeeC9ahRiN2S5XgfWIBC7WI7hLINUwnOcJCPvAHlIXHoNnZsJUWvzLc88bQS3FoPa6bT1JfCABm+rQiJbRGPF5s0CJYQhlD+RgZjd/+CEEISySBq8Bp9jM52U7Za8BBGF7cT/VDD43QGBtctoI5BUgXZbN/Da9z9rAik3Vczv1Jt0nfxZ7hcW9ip72/WHIAB7fkVcySYk2+s/M4JzTMkivfRpdaOq9Ep0Csa32kRj1CTeoqQyUh55bDeFUOYdt6g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8093.eurprd04.prod.outlook.com (2603:10a6:102:1c9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Fri, 31 Oct 2025 09:09:27 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9275.013; Fri, 31 Oct 2025 09:09:27 +0000 From: Peng Fan Date: Fri, 31 Oct 2025 17:08:35 +0800 Subject: [PATCH 06/11] remoteproc: imx_dsp_rproc: Use start/stop/detect_mode ops from imx_rproc_dcfg Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251031-imx-dsp-2025-10-31-v1-6-282f66f55804@nxp.com> References: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> In-Reply-To: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Shengjiu Wang , Frank Li , Daniel Baluta , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1761901729; l=2356; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=a5bjtYi1dCgVkA6kJZOKMqe6plO4lSpIcgHrVPzVNAQ=; b=zJCpJcJ+FtQVU4DlcstNQBboHHHNMC246rrcIU5PfOzkrtdv5FTmF0xGDBcIyCNqwDhaEMeNk /12f0AW03aRD8DytgAwAVeaFoOpAJyIDYQyaxbKDVG11dLVlmJJIAC/ X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0010.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8093:EE_ X-MS-Office365-Filtering-Correlation-Id: d4631155-2123-4c97-1a6d-08de185d311a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|19092799006|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?S3ZrL3NOYTkxWUpjeXg0cE9WZnk3Qk04WUpuRkd3blpRdjdoR1FkcS9NNGYx?= =?utf-8?B?WFVaWFVlQkZvTGM2UTV1RjVrZ29VeSt6U3BOY3NRbnFCQVZSNG5USXJ6ZFlu?= =?utf-8?B?WGloVjNGc3hsdFExcktSZWJIZW1oUzlFRVRsK0FFRDBhU1l5a29xNW0zUUlL?= =?utf-8?B?THhSY2JNY3RGVUpFajV2QmVYSE1LVGJ1Zmx6MkpIdmt1OW9rc2JYWTJoWi95?= =?utf-8?B?anVhdjFWR2pQeHgyYlFPWU5PRDlqa0h1SzJCWW84eTBSMHJ2diswY2Rrd1dD?= =?utf-8?B?amNKU0JSQjJZYjIwdGVIclhmb1BaT1RtbUxtbDh2dTVnL0JWdjhPSFdUVjVT?= =?utf-8?B?VzA5dUVUVDBBNnNGU3ZBNnNPckZuOEx3N0hwRDdkMS9peHNnK05kUGdYNFhB?= =?utf-8?B?M2tTK1pVSEhuRmw2K012a2NWZVJsblZVRTluM3dzZE1USm8weGlLV2pRbzI5?= =?utf-8?B?akJ5azZwYTFwaDVWdENvTDVQYVl6THltdVczU0M4RFdmcTByNTJHQS9kbmhB?= =?utf-8?B?Y3E2Mm94RjA1azJxR0VMT2ZMWE9TMGZUNDFQWTJKdk9INXcwY0UvT2Q3Tmdz?= =?utf-8?B?Vm1MUzFDZkJndlVEQkNSZFNqRVh5S29JbzRSVG0rbGhoNUw1QTVDVnAxbHI5?= =?utf-8?B?UUhVTklZd3NRb2ZyZ1dWcEdxL1Y4TVZEb1ZJZGxCUlVWZzJhOHp1aUxJenM5?= =?utf-8?B?K29sN1NnZ0tvck5uUzh2VXRMaHhwalFFZFE4UFlKNWFKd3hkWkRyZVA3V1B5?= =?utf-8?B?LytZcG5YOHFOeExKVU85OVhic29DZlFYVkg4cFhpMXZ4RHhNbm14RlA0cnE4?= =?utf-8?B?bzhzc1Nqb2ZVMEQ3NVgwUlFKNGltRXBMclBicXFQQXlxNU5vT0tPTmpZS1kv?= =?utf-8?B?czg4RlMwZ0thSC9TQWhSazk3SkwyVXptS2RtU0hTTFJtOURNYXJRT0F0Q0or?= =?utf-8?B?OUc1Smd5U2ZQTHlqelBjVEZCWVJOYjdoMHY4cWgrbmlzcklEc3A3ZG1ERUhL?= =?utf-8?B?dHJBM242NEJ6YVdVYlhRTWxuTGJvQjFhUDJmUlZPa1R1LzF3ZkE0YitMQ0Jt?= =?utf-8?B?eGhIZElsVFlsWGdZOE10UXNBc1ZrbFhyR0w5THlyR2Y4VEt1Tk56NzJjWXpa?= =?utf-8?B?OEFNdjJQT09jUnhERFJibmdRS09wczBMN2g1eFVyOTAxcm1pTzZCaWRVK1lH?= =?utf-8?B?Y3k5RmUrYTJOR1JQRit6dytoVVRJRDhZM1VYVkJjeWtPUVVjNjYrWlRoUzdF?= =?utf-8?B?Y2kzanZlVTdQMEEvSGlxTHVqbVRyTkxZN1RiRDhXSWFnaXpnWW5iaGxtOFF5?= =?utf-8?B?TDlJRjQzc2Z0MlBwV0dCc09mV3ZDUGdFM3lCWmtJdFV2blFrSUg3Rms5WDho?= =?utf-8?B?QzhNYkV1UkVjcVpxOFZidWFOU3FrcllwbDJ1RjJoZ0R1TE54NHI1NDB1Q2VV?= =?utf-8?B?d3lwLzExZEtzL0NRVXlPRUM0bFpPdEFQQkpkMEl0VzV4dm9OYktXdW04UVBT?= =?utf-8?B?Zm1wYnpBR2hDamU2czgzZ3JlRmZkUGREdFJyNnVYcGY2SWhZeEdiR3R6N01S?= =?utf-8?B?SzhvMHpZY21oMFk2czk5cjU2K1h0UDVkWHE4TWFUTFVQcTYzWU54UmlJbVFN?= =?utf-8?B?eW85SjlPZFpCeW5OVzh4RWgyU3g2NE90SjdHLzhYM0tmNk5KbjZ4YzcxcEVz?= =?utf-8?B?TDBKQUFXbFZETWNBUDNLTlgvZmRUSHRPYXVscS9mRVdVR1grMjVmSitaR284?= =?utf-8?B?YU43bU9UUHVVbENZd043YXBsNFR1R2Y0WG43aWdNV0xPU3NlNEdLcHRmanhD?= =?utf-8?B?SUk5TGNzTkJBcUkvczVIOFV4TnM0Z2dwNVdPbHJRMFpmVTV4QlFjVG16ei9l?= =?utf-8?B?Q0pJcVU1SHBMcFlGdFU4TEFnWXhQZCtRZDBCMTZlUnJUTFVSSWlRcDJoVzQv?= =?utf-8?B?cTltK0YwbjYyUXhkbFp0MUVFZkxSRWtMZmJwZXpYczk0Uk1XTkZxTUwyaGJm?= =?utf-8?B?SWlOODVaRTdvb01Nb1RjQ1Z3V2dnTU4weXpCc2ZyVWMrd0ttSUI3Q0FEZlJW?= =?utf-8?B?Tk5lVEpxNWxMc3JPUnVjMzk5djJtREhrVG1TZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(19092799006)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDBTdkw3bnNKcFk0b1BBUzcvR1hKc2pyWEVFbld1bWcvZG1aMjg2S1VYMlo2?= =?utf-8?B?ZnNkZElxc1NWNTVDZ3JydDlVbWlFL2l3MVhqUEV5MGhyTDFWeklicnRoUkc3?= =?utf-8?B?bW8xYXM4RTJ6aXdtc2xLNTlMdXZUSnJCVGxjeDg2L1pIWUkxWXo3NFZHMmds?= =?utf-8?B?bXJQS3dVa1JYT3k0V3pGbVE1ZWF1V05JQXpjQ0xuV3NmMXI4SXdDSWE3cGw4?= =?utf-8?B?OW5Vekx2VEpxVEIrbEFHOTEvU3BLS1VzVXY5ZGY5K09vOUZLQy81SzVRcFhM?= =?utf-8?B?WUdkL2Q2YkNJdzdsaUwreStTRzI4aDNWcjhacUE1aXd3dCtsY1BSTk1DaExu?= =?utf-8?B?UktOTk1ncVZrOFJnSDFrYXlod2Y0SC9lUERWek1nMTZSK2syZFlzR2tQWlhi?= =?utf-8?B?MXVXNDhML0NtVmtrRVlMZ1pNZ3Z6K1B5aGFrcTRVeTJJMUwxM2hablR1RHBS?= =?utf-8?B?R0hMUG5BOUpkWWVMcFMrY01JUXhkT2ZQK2xmcndWbmNHMUd4dE1nY0VDQmpT?= =?utf-8?B?S3Z2U2NDck5lQVY2R2RuRmtRdVlqSGVMSGswNXVtdk5aRm9ndlAyL2MzMkRh?= =?utf-8?B?QUJhOG14eFpvdGNIeWNsaGx5S25RZ2FTVWJkWGJqQ25yVmVERE1HVER4bzdp?= =?utf-8?B?bDZsUWNEN25KR3dQOThrTFcrSTZIazVZZHhHTWNOUHkvVHppczFIOXBsMEU5?= =?utf-8?B?RmwrRkRnSEF2RHAyT0EycFNDbVRKbmM5VCtXeURGb0JQSkNZK0IvTEZJSFh4?= =?utf-8?B?Y2F2Z2VDaFFhOUh6MGxvdzJ0K0xDOWxDOEYxQlZlR3NwcHc1Y0ZDV0hQZzRa?= =?utf-8?B?enhyMU01SHlGakljN0I3YlN3eWl6dVh4czJudXRWejZEc2tiYTFsalI3RVlC?= =?utf-8?B?WXA4U1R5YnFmQnh6MTRDRHVSUHZmNy9XYTd4OW1halNrWWxzeXVpZnB1WkZE?= =?utf-8?B?LzJqOGRDMjFPOVhqTG9wbHdPdnVVTTBqVHJMNTBJOVpaOWdsTUw0Tk1IeUVz?= =?utf-8?B?SUFIamgvYnlvOG15MElpYjMxMndjUnpTWTQ3WEIxZWo0K29ERlRNakM5VU8z?= =?utf-8?B?THpvTjB5d0U0bmVhWHhoY1F6c3J4T1BBYnlmaXhWR0t1c1JCYTdPVkc4R3Np?= =?utf-8?B?Rm5rbXFKa0hPdGcxaHdHOGNrWUdEWGtqSVk3dHZjKzM4VVUzZHoycVRQQ1BU?= =?utf-8?B?bjZtZXZCSmhaUjhpV01oL1VyRS9ubDNBbEgyb1o1RjdQV0ZLK1MzWWN5VzF3?= =?utf-8?B?eCtnS21BdkRCRE9SWVptNVJuOFI0bTB6VVVXMEZmbTNYalAvN1oxNWFBK2pX?= =?utf-8?B?Tmw4R2tXck9TTzd4WjJoZ0ZEWWV2ZjhMQkpsWVpKZHlKY3lReUhKdS9OTkVk?= =?utf-8?B?cnhZc1k3RkZmRUFhQnA2d2E1alpUTEJGZ2tLYmRMU1lqTnpEcUQ3ZUJkTWZV?= =?utf-8?B?eVdyTitPQjJhMXB1TDRScGhxY0loa1dCWTZnL3RlN3BwVjJSWUtvVlJiUkl2?= =?utf-8?B?VzZUZ1RBMGhYaHdrMVpra1hpMkxSVjcyL2g1ZEpFZkNWcnRNV1g3czJTb0ho?= =?utf-8?B?dDJmYkMvTVVFMFFTQ0kwWWtnUWlhbnVUVmdxcURKU0M0RXZUNVVVc0J5V3NW?= =?utf-8?B?ZmpCWTdvWWpDRWlTbnNtS0Q2OVZMenVYTGsrWXpkbmdoTVJsU051NEhwMGI3?= =?utf-8?B?Q1Q4aU5DOFlsOXVqdytBTEp2bFFrZXZncVlXRnUxN3NLZUlOZFZacTQ1UVB3?= =?utf-8?B?UjR0OVhycFF2ekt0ZGtUa2hBeEtpOSs2TXFkK0Z4Z3JPY01VNTFCS0JsTnNi?= =?utf-8?B?S2RkdUZ5RXgzSkd6UnNUdWhZUlg1MXpVc1hYQmJvK1UyVXRCNEFQdXg0dmlD?= =?utf-8?B?VUZWczF2Wnd4YjJCV1ZZZjZoMFY5ZDdwOGlQcVByTUk2Rm1YM3ByVE5WbVZx?= =?utf-8?B?aDN1czAzRTdxQ3dFeCtvdE1sTXQ3VUpaS3JNVXBRZFR0Z1diUlYyeTNDK21L?= =?utf-8?B?WlRxeG9nakZnNUdkRkVNZ01oanprT0wyMUYvRzlKb1dkcEhvTkJMa3JHZ05j?= =?utf-8?B?dFFiUUlZSFMveUtsR0czYUc5REwyandoSHpmdG50Um5ldWpmcFhPazJ5UFpz?= =?utf-8?Q?Y07f6XyvsE5YXOBbwXxA+HcaL?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4631155-2123-4c97-1a6d-08de185d311a X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2025 09:09:26.9982 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HFAbpzmrTE4Gw2leFoFbKpacpj5LoLhmIAtDb+awQYScr2Hyd4xVDLLnEG3IZvZvtsXjByvqBn9Gl85kR2Pmrw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8093 Allow each platform to provide its own implementation of start/stop/ detect_mode operations, and prepare to eliminate the need for multiple switch-case statements. Improve code readability and maintainability by encapsulating platform-specific behavior. No functional changes. Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang --- drivers/remoteproc/imx_dsp_rproc.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 1726aaa1eafb9ac1a913e3e2caea73801b86dc09..833b1bd4019614157f0bedf09bd= 348caab802eef 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -404,6 +404,11 @@ static int imx_dsp_rproc_start(struct rproc *rproc) struct device *dev =3D rproc->dev.parent; int ret; =20 + if (dcfg->ops && dcfg->ops->start) { + ret =3D dcfg->ops->start(rproc); + goto start_ret; + } + switch (dcfg->method) { case IMX_RPROC_MMIO: ret =3D regmap_update_bits(priv->regmap, @@ -424,6 +429,7 @@ static int imx_dsp_rproc_start(struct rproc *rproc) return -EOPNOTSUPP; } =20 +start_ret: if (ret) dev_err(dev, "Failed to enable remote core!\n"); else if (priv->flags & WAIT_FW_READY) @@ -449,6 +455,11 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) return 0; } =20 + if (dcfg->ops && dcfg->ops->stop) { + ret =3D dcfg->ops->stop(rproc); + goto stop_ret; + } + switch (dcfg->method) { case IMX_RPROC_MMIO: ret =3D regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, @@ -467,6 +478,7 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) return -EOPNOTSUPP; } =20 +stop_ret: if (ret) dev_err(dev, "Failed to stop remote core\n"); else @@ -1085,10 +1097,14 @@ static int imx_dsp_attach_pm_domains(struct imx_dsp= _rproc *priv) static int imx_dsp_rproc_detect_mode(struct imx_dsp_rproc *priv) { const struct imx_dsp_rproc_dcfg *dsp_dcfg =3D priv->dsp_dcfg; + const struct imx_rproc_dcfg *dcfg =3D dsp_dcfg->dcfg; struct device *dev =3D priv->rproc->dev.parent; struct regmap *regmap; int ret =3D 0; =20 + if (dcfg->ops && dcfg->ops->detect_mode) + return dcfg->ops->detect_mode(priv->rproc); + switch (dsp_dcfg->dcfg->method) { case IMX_RPROC_SCU_API: ret =3D imx_scu_get_handle(&priv->ipc_handle); --=20 2.37.1 From nobody Mon Feb 9 09:54:47 2026 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11013071.outbound.protection.outlook.com [40.107.159.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D0CA33372A; Fri, 31 Oct 2025 09:09:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.159.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901777; cv=fail; b=YRw43NsQHOWs/aeFInDT/3wXzCIyvZCi1FvLlFtvq+3eO9l4zspO3N8x3ZPRK6cKusYXjNLbhmxqfgMJD3Lz+dYB4FSOaWEBDQDF8jxIu1KK9RriQQKaDQG43nJ9zF+F2iXk1PtmCwT7HDtcmnXi9iK6VAHEQCF2vadbKXQKEVo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901777; c=relaxed/simple; bh=E4gT9XaiPMroMEbSj380oC/IHz5e6QzbNplypztn7pc=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=YJXVAC+EHd8CJgfZ/70SgUDS4K7vasRgDBdP2+LK4lw7vVF1jXVPuZWmmciDvXkKa4AsFJJfI6Jq7yWrUEmPCBFwMLjWBDngXrlLq1aUFflGayvaREDh3/+XIxy6G4ZhkqhOwwHXrgwbPccsluLDX4TbazYEAof3e+xuJ5BUR/A= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=oF359/8i; arc=fail smtp.client-ip=40.107.159.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="oF359/8i" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=alF93C+rZd4nHdsSuaJIExRJuA56DLzgLh//QGvElZ4BTjMQj9fOhxZOI6a+vWcvpxZpEEI0Hllk+VXsqXSbk+27xqPMy2//XoY+i2MnOYCNIx/HHwaA2w5XKxl+S6jp5GuDj6GTD77zCE5g82Ld7BOq/hnduIJnTJEEqNrswcyGN1uFnfp4Vk4473l6zwT1cE6rgAEaSDgyA69v87js8DsLpI/ZJyoIUVxp6OYTS6ldtHjfPVvcxiZOT/iOfq0ITVdrV1baYl4DrRmsxZU/4XAA0pyWpP2gTFzbeimc6SE+5gJq0aOk5zMa/L2nzAFep+msML4TsAxGWsPt+PZdJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OLnBsvijneuqlywXdu5x0PjgFg26stPI2nSJffLAUNo=; b=xXjEoMsKkheGfg/851MerDBP+Vl698cZAOMo4nHLZIaRYzKkhtHjhkEyHvL4lYCTvFfc7kDyRbZUVUcWod4t4fd7MWUHd1tt+FcDfpA9hasmsADkGtvXc2HZJ8rRNwmilav275NOLjh7LFthukGnV1iN/BLrcDGTmN+L/NEG8WiBsBxcEPyTzdpBNhokcTfGlyPJONht29NbWAjitmAAirVqJoEjiKI298HMtX5+RufwtM3dB6DqH3cJfby1fhfAbhARNIITWiyfiSe9dCnuyN1LCS2HygCKTpkff9mPRNrg1s5lRsDsN57R3cp1OqdDw0NW/EpoxpRmzGxoOi0o/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OLnBsvijneuqlywXdu5x0PjgFg26stPI2nSJffLAUNo=; b=oF359/8iijid2Wda+913TSC+8P2x5aYTwdKtrWk483umF/lNe1JvbLE06oKiS3wEf2J2mK2x9LIbPkaZniqyel6aN8ZrlpPIHKT7rNV4k5uyBKJcO9rwxd/PZljyv2lSrDHNrmqwzExJSA+7hSNuLO++bqplZa6BccrRyxyZoAtad0hP2qN3Gt5w4HqR80nQDJsiY6SuwZaQsSL3XzZJ49e9Lyin04OLh25hSiNS0GHaN1OMibnh4MSYmPc1Ab5y3YUtTsuTiqR1pP4DpClZduDokHA1wxKRs5sXhZtawBOwyXEE6nOM7cgEPE0q3ZmwreF79MCHQ2XxIYvCMj1wCQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8093.eurprd04.prod.outlook.com (2603:10a6:102:1c9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Fri, 31 Oct 2025 09:09:31 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9275.013; Fri, 31 Oct 2025 09:09:31 +0000 From: Peng Fan Date: Fri, 31 Oct 2025 17:08:36 +0800 Subject: [PATCH 07/11] remoteproc: imx_dsp_rproc: Move imx_dsp_rproc_dcfg closer to imx_dsp_rproc_of_match Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251031-imx-dsp-2025-10-31-v1-7-282f66f55804@nxp.com> References: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> In-Reply-To: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Shengjiu Wang , Frank Li , Daniel Baluta , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1761901729; l=4720; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=E4gT9XaiPMroMEbSj380oC/IHz5e6QzbNplypztn7pc=; b=+xuduDw7mLfHkPmAX6MqvLFcazYFhZKnHrwQEGk1X3axJRBn7RXm5kNS4+lQ/FOFxMB7MP4kj 3SMcSY8iXztDYYMsTTTcR9tePlGnstLNzwtcCp/+zOr2QgqlxYmpZ20 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0010.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8093:EE_ X-MS-Office365-Filtering-Correlation-Id: 708d0475-2df9-44c2-386d-08de185d33df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|19092799006|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZFl6Q1JPYmdDSlk0WHYrZFBwdzNSQmdOVWs3eDlmRkxLZEVDa0NnVUFHajJB?= =?utf-8?B?VlNHbW5SR2VHRm1SRkt0UHZUeEdTb1B3QnIvYWFkeFlES3NLRmVLZDdpZi85?= =?utf-8?B?TUpwNURTZ1RxaXhocTNsVGhLbm5mMStlODFxR0pPU2RBVkpOT3M0OHByTVRT?= =?utf-8?B?REtvWitnTDJBUzcyejZZNW1HYXVxcldkc1doNkVkTFNxRnV4NlRJeUNkY0NO?= =?utf-8?B?TVVEVEoyWHNEbGFpeFJJaGxnWmQvMHZna3FoZ2lMTG8weHloeFBObXFZK0xF?= =?utf-8?B?MGFObURZOWRqMVVnUnNQQnBZNkU2YWhiMVF3VEM0a1ZEOGNLb2ltem13dUxW?= =?utf-8?B?SVNXdjdWeGV2TW5qOW1RWVluYjhyM21HcHpPL0NHS3E0aHA1SS9NaXRVOXd4?= =?utf-8?B?TnFyU1huOUxkajlUOHJBeGJWZ3NLSkRWZlFLL2F5REhPUHoxUUlsVFJreWhH?= =?utf-8?B?NTh1MU94RnZPS2tZZjNNcjRINDlOMEZqTS9DUEVLdkp0Q3JmbmsxTnBZdUhG?= =?utf-8?B?OVFMaGx4UUVYVjVZcW9BaXFtTUs3Ymp1L2U5R2hSWnp1MVhDWjgyYTg1V2h0?= =?utf-8?B?M0NOQjZJVzh1d0RHRk5iOUI2aHRZbHg5SVpFV2dWVXgxVi90bzREaWluWFFH?= =?utf-8?B?UG1IODJROXhOZUhydlg4UUpUK09uYVJwUnpMMHdnZE1NTVV1QnhJSzhZSHMr?= =?utf-8?B?U1liMGE4UTB3VEtGeW5DNGlObHdDY1cxeW1BSHZqMUFQOS96eEMxUDVyWVpk?= =?utf-8?B?bmtXNzM2dkg0eUtpRG5NeFRtclh1alRMdkRobXFVQmtmZ3p2UWxWNm1XdzVR?= =?utf-8?B?N1RPZjFxUnhGaGUvb3lSS3Yra0NSN0taNGZ1VVY5R3V1UWhXL2VDbVRhMW5Q?= =?utf-8?B?bVBLYUIxSXhZMWlMbkwvOXZoUDIzNGlIbkpNb1krTEJkZDkreVRXeHN4TGwr?= =?utf-8?B?WG5qSCsrRUR6eUZwVWtTRkxpak5BeERvclI5SFQzSjlCR2JCZENINW5JeHhI?= =?utf-8?B?OElvR2JJb3lVemZibXFnQUo3UVM3dTJBUWo5ZzQzZnU3NTYrSFNpOWMzL3kw?= =?utf-8?B?Zlg1a3M4MDJzaDZHOTVydmlWYXMrODhISUNrbTRHVUxnZjlQQXNHUFlGdzVv?= =?utf-8?B?MjRRcFo0QUlkTmF5dG56MVJwWUkxTkpVbG5GVHdoREpNZW0rVFhaaDlRZ3lp?= =?utf-8?B?QWlEKzl1Z1FmK0M1T3pDc3hYVEJKTG1LQXNEYW9lVzNhcEczaFpOMVFzVi9X?= =?utf-8?B?TzBnZ2FXK3JZTUtkR0MwaVRKek9TRUNtblkrMkNRaGcyaTFHVi9rR2lxenVy?= =?utf-8?B?Q3ZhNnZoWmRqVS9FV3FUNlI0dzd0QnJDQWRYNUE3dGxselJ2bUhrSytzQTJh?= =?utf-8?B?SFE3U3E4ZHFaWlhMZnFCUGN4V2xUWi9ndkQ2L2JIa3YzcTFHSzJqT3NNVDJ3?= =?utf-8?B?cG9FaTdGQ2kxbFBSZWFSWDVvVXF2SFFpUm9kN2RqNmc2am84cGYyaVFYWUdG?= =?utf-8?B?UXhnYTh0QTBYYlpjVFZHRmdLQlc2SzQvWlowNHZtcDlPQXFYZ1doNGlTZGpm?= =?utf-8?B?eThsZ3d4Ly9DNjNIT25Gbk9sWGdOM1ZZbGhMUTY3OXB5bmZudG9xM1JoeDE0?= =?utf-8?B?R0prZFdIc1VKUGxtYUpxNmZIQytIWlJKaWFVZmVHeEpyVnBhMnFjWjJHcUk2?= =?utf-8?B?cTRMd1FiTEdVSTN1bFhZR3R2ekNHYzZBRnhYSXJOeUJLazIxWDJXZldXTnpN?= =?utf-8?B?bjdBY2hYUlRrVTRTbkhiSCtDMGpHY0twYk4wN2x0RHZOdE5kWUNHZENrNTkr?= =?utf-8?B?NERmTmd2UTdYTzNUMU5sUHVjaE1RMEwrb2puaEJ1a1Y3Q0YrYmY1Z29OM2Zp?= =?utf-8?B?YUloNVExS0pZS3VrdUY3V3UxWjlXN0gwQnh6MDZaamFId3Jxd1hKRnhSU2hL?= =?utf-8?B?STJ1SS9Rb2dSZDNONS9vazRwcGg3VnpJNXJxQ2FSVGloV2hOM2d3SHF1ZXJE?= =?utf-8?B?NEtEVktleUNKYmFFTzVCNDlxTEVYSnRNQjVGUzVDUVdYd2d3OVdVMVlFNkc0?= =?utf-8?B?QXBHSzdVZmtFd2dhTnQxUlFTV3JMTkZjamQ4UT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(19092799006)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTVmSEJGL0I3L29BblNwNDliOGIzTTVPbHNldVJPVlh3WWIrOUttL3YwcTFU?= =?utf-8?B?NWtDb3VzeWlnTGhEVGZVb1hlbkxndzk5YmN3Q1Q5dll1NXNqZnlvLzduRHhQ?= =?utf-8?B?R0ZYY3hHYnl3c29UM2JQTW9aSDl2RGFoY094di9HMUpTN2Q4cjlUMjhxYnJ6?= =?utf-8?B?bncrLzFJOXFVUTIra1hXTWtVUzlJNDE5dUFpRmgzaUc1YmpINkw4M3ZlN0N1?= =?utf-8?B?R0ZuMkt0UlNxYTVWTHJpQWJEMnY4YTBTZTg0MStxYkRHRENyTkx5VXJyeGVw?= =?utf-8?B?V0MvY091UjMyc1JZYkJlbkRBY29hWU5Ba0lKMThCQkdLZDNEYm5GQlozaG54?= =?utf-8?B?NFRUbTFsdVNycW9pKzRFK09uSGRuN0IwbGR4MDJ4T3pLR1pqamlXeXFNS3JW?= =?utf-8?B?aDVkVWdFdTlGK0J2UnVtK0dsa1JRbTdOSDU0SEFqQlIyUWJkMUVOSm5JZTZH?= =?utf-8?B?cnhKbHJ5VGJiM1NmbTlwbFA5TlcyeWRrYU5WeEdaUnFETndnM0NQdXV4NVd4?= =?utf-8?B?Z08zbDVHcVJxU0x2K3lyZGh0YjNRNVJlYUFoYlZJdmJjTnVVSHRuYjc2RHZM?= =?utf-8?B?WkJYcnlHakc5VmhuK2pVU1RuMWZkd251UGRqUHhFNVRaeDZ2K1lQeGNTcisx?= =?utf-8?B?bDBhT2VsZlIvbmRrdk91THFHN1QzamdiSU85TXQrYXdLaGIvTkpVbkloNnpy?= =?utf-8?B?Mi9UejhwaGVkY1NMb1dkVzNmaVdLRDlqTXNabFY2bUVzdC91WFVKT29jaUY0?= =?utf-8?B?alpQYlBSRGNLMnh5eVVKK3N0SXNuOXRGaWcvYlNXblZETiswOXh0dGZpSjBE?= =?utf-8?B?UVhnRW5oM3p3bDNLRStzWDlLV3VJaU1nSjM3V0RheFJ2SEJnZTRsMDcyWVJy?= =?utf-8?B?NGRDQ2dXSnZDTUlsRkZESG9GMVF2Q3lqdmhNbURZbDJ6MFA2cW9lTjkwTmJU?= =?utf-8?B?MURHSGw3WjJOZngxMlhYNWFURG1PS2RXWFVwcHdNQUpXSnNSVnpLN0h3aEhT?= =?utf-8?B?eHFQUkF2L2hiK0VOUDVpdXlJZHRyUWhKeEFkK0szNDgxWEowSjVrUEUwSytp?= =?utf-8?B?MlhhUjE5Q3lTclVhejZIeHdlbHdCWDlVOU9nMmErTVF5M3BwQzNyWWs3TDB5?= =?utf-8?B?eHJiSEl4RE90aEVKL3ViV0h6QU94RWF1UTdMUlZJMUJES1dTTXRqWmprcXZ2?= =?utf-8?B?OFd2ajdxeHNCSExTeDM0UTgrMUxoUVp0UzR4bFB3T2hvblZXbGs4V3RjZkFU?= =?utf-8?B?R0V4N1pKVXhNWEhvMml6Mm5zTUVIcGRyUXNZTkhOM0N3SmdRWGlsdG5MS3hO?= =?utf-8?B?Kzhob3Z4eTZ2aEZud3A1dC9udVlGRFVPV1A1cGc5bmQwQ1dMcC9qTHliaU1m?= =?utf-8?B?M1Y2YU1IVTJqQ0l2Y0VKOENrODcvVTlDR3FwUFR1TFRjdW80amE3VVFveUdq?= =?utf-8?B?UHV3OUpxZW1teGFDdG1NUnVkendldU9YUWpEck1DRFBiQWlHbnBGckRtQ2Fo?= =?utf-8?B?YlBHZHE1ZzNkNUN0VWp1aXo3aUlCb2trc1RwT0tqazlseXR0aTJOQ0dyVzhi?= =?utf-8?B?SWlkNjV5U0txSE5obzV5NG1ZUFVQMGlWSG9hVmUyMWhHNEVUMTROVWZZY1Rj?= =?utf-8?B?OHJLR0MwU29kMVdYSUZKUkFFSXJpVVB5RllpSEswaUZad2NEYWVDa2dkUXpU?= =?utf-8?B?TGsxT000ZnRqaUpPVkVHTlZsR0NjY0J1YVBZallpNUtubzc0TjVCWFRQVkpT?= =?utf-8?B?SE55Zk9TM0lMWWdjYitrQnpDcE83Z1hYWEdIdWh2akZ1Yk9aazJUeW95aUNj?= =?utf-8?B?Qk9XUkxaSUlGajZDRDZXNDlQUG5jdU5vTFVIYmFMNEFHUlFFNklOSy8rU0l3?= =?utf-8?B?ZlcvTkRQb0tNVXQxbW03UXBOL2dsTGIvdEtjeVl2TFZqVVU3YkorMitGZFdj?= =?utf-8?B?RVVnMjdFNkh4akJBaHRHWlB5Z0tMQnkwaG1xRXpJM0VVekJPZ2MrcTdTeDdk?= =?utf-8?B?a1ZjeHZML1ViTDNDWEVWSUlEdENFVkpzNlpLOTJBSmx3UkV3cDlsQ2ptOElp?= =?utf-8?B?ZWcraFZ6b0tyVTl1SEE4YzJvNnlwY1dOUTZLdUYvQ0orRTBCaTlwRFZWUXB6?= =?utf-8?Q?ezw8Vy2t7F0X6f4r25qv9A2R4?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 708d0475-2df9-44c2-386d-08de185d33df X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2025 09:09:31.6599 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pfRU9LnEtLj7SxvDm4NGf0CtrROsFB/LrwLTW8uMCY3Ye6xDyeFqges4NMYGPk8NA4TAbpfLbfljRCfi5XvO8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8093 Move the imx_dsp_rproc_dcfg structure definitions closer to imx_dsp_rproc_of_match to prepare for adding start/stop/detect_mode ops for each i.MX variant. Avoids the need to declare function prototypes such as 'static int imx_dsp_rproc_mbox_init(struct imx_dsp_rproc *priv)' at the beginning of the file, improving code organization and readability. No functional changes. Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta Reviewed-by: Frank Li Reviewed-by: Shengjiu Wang --- drivers/remoteproc/imx_dsp_rproc.c | 100 ++++++++++++++++++---------------= ---- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 833b1bd4019614157f0bedf09bd348caab802eef..f28d25cab3f1d89e5cde37a04b5= 28870a59abeed 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -261,56 +261,6 @@ static int imx8ulp_dsp_reset(struct imx_dsp_rproc *pri= v) return 0; } =20 -/* Specific configuration for i.MX8MP */ -static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { - .att =3D imx_dsp_rproc_att_imx8mp, - .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8mp), - .method =3D IMX_RPROC_RESET_CONTROLLER, -}; - -static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8mp =3D { - .dcfg =3D &dsp_rproc_cfg_imx8mp, - .reset =3D imx8mp_dsp_reset, -}; - -/* Specific configuration for i.MX8ULP */ -static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8ulp =3D { - .src_reg =3D IMX8ULP_SIM_LPAV_REG_SYSCTRL0, - .src_mask =3D IMX8ULP_SYSCTRL0_DSP_STALL, - .src_start =3D 0, - .src_stop =3D IMX8ULP_SYSCTRL0_DSP_STALL, - .att =3D imx_dsp_rproc_att_imx8ulp, - .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8ulp), - .method =3D IMX_RPROC_MMIO, -}; - -static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8ulp =3D { - .dcfg =3D &dsp_rproc_cfg_imx8ulp, - .reset =3D imx8ulp_dsp_reset, -}; - -/* Specific configuration for i.MX8QXP */ -static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qxp =3D { - .att =3D imx_dsp_rproc_att_imx8qxp, - .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qxp), - .method =3D IMX_RPROC_SCU_API, -}; - -static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qxp =3D { - .dcfg =3D &dsp_rproc_cfg_imx8qxp, -}; - -/* Specific configuration for i.MX8QM */ -static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qm =3D { - .att =3D imx_dsp_rproc_att_imx8qm, - .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qm), - .method =3D IMX_RPROC_SCU_API, -}; - -static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qm =3D { - .dcfg =3D &dsp_rproc_cfg_imx8qm, -}; - static int imx_dsp_rproc_ready(struct rproc *rproc) { struct imx_dsp_rproc *priv =3D rproc->priv; @@ -1351,6 +1301,56 @@ static const struct dev_pm_ops imx_dsp_rproc_pm_ops = =3D { RUNTIME_PM_OPS(imx_dsp_runtime_suspend, imx_dsp_runtime_resume, NULL) }; =20 +/* Specific configuration for i.MX8MP */ +static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { + .att =3D imx_dsp_rproc_att_imx8mp, + .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8mp), + .method =3D IMX_RPROC_RESET_CONTROLLER, +}; + +static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8mp =3D { + .dcfg =3D &dsp_rproc_cfg_imx8mp, + .reset =3D imx8mp_dsp_reset, +}; + +/* Specific configuration for i.MX8ULP */ +static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8ulp =3D { + .src_reg =3D IMX8ULP_SIM_LPAV_REG_SYSCTRL0, + .src_mask =3D IMX8ULP_SYSCTRL0_DSP_STALL, + .src_start =3D 0, + .src_stop =3D IMX8ULP_SYSCTRL0_DSP_STALL, + .att =3D imx_dsp_rproc_att_imx8ulp, + .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8ulp), + .method =3D IMX_RPROC_MMIO, +}; + +static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8ulp =3D { + .dcfg =3D &dsp_rproc_cfg_imx8ulp, + .reset =3D imx8ulp_dsp_reset, +}; + +/* Specific configuration for i.MX8QXP */ +static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qxp =3D { + .att =3D imx_dsp_rproc_att_imx8qxp, + .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qxp), + .method =3D IMX_RPROC_SCU_API, +}; + +static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qxp =3D { + .dcfg =3D &dsp_rproc_cfg_imx8qxp, +}; + +/* Specific configuration for i.MX8QM */ +static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qm =3D { + .att =3D imx_dsp_rproc_att_imx8qm, + .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qm), + .method =3D IMX_RPROC_SCU_API, +}; + +static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qm =3D { + .dcfg =3D &dsp_rproc_cfg_imx8qm, +}; + static const struct of_device_id imx_dsp_rproc_of_match[] =3D { { .compatible =3D "fsl,imx8qxp-hifi4", .data =3D &imx_dsp_rproc_cfg_imx8q= xp }, { .compatible =3D "fsl,imx8qm-hifi4", .data =3D &imx_dsp_rproc_cfg_imx8q= m }, --=20 2.37.1 From nobody Mon Feb 9 09:54:47 2026 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11013071.outbound.protection.outlook.com [40.107.159.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07828333737; Fri, 31 Oct 2025 09:09:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.159.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901780; cv=fail; b=b1J6GdqOZlAFUFaAmLDwVPJ5UT1ChtVYqwlgl8PaNpOkmsJEJnbItACN6ox3v6dHuxoN/TEYKIU+XT9YPqIsmuC7FNK0sGsoFsrkpM8ZRC3ZbrGAwqIa+/U/fnVE0i6zAbOb94uWbjE7IHIda3QAsVc3vkdjFEaVmkqphEy+NZE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901780; c=relaxed/simple; bh=F0Pu5PbYhXCcMNpvc6dhR3qAgy30IsI3/b/n/oMTBRs=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=c1Ybv1348M/n4Piy4bJi8EDQHGgITjGSgFpXVC3pC+zAbfENvv4vkj0Qp8J/5y1vyqveltT7ZhMAxUmTz36yZguAvFAUVP66gFx6zzNDxAiID6K4uQBBGwkXzfT4q1P0qw1vS+I11xdCMiMLuLnUuou37USAiC6ATBJOzbLvz5o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=dMcwazh2; arc=fail smtp.client-ip=40.107.159.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="dMcwazh2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LN7p2omyfi8LYiN1pKOg0Gnhd+d4b+HYSb1CHoiYztnD6HMNUCkpgmDykmNvNPt7wCmbhLh+i4+YZdNju7+ADPZSTCFbSje/qmAsBgRamk7U77lU37ugvJER/5KHDEqhHmq5b+sgXWNrSKLDNFfiS4qyb9rSAYeP0G6P5X7XY/V22TrnWeaRDC8mCwSjyxEXcMrRKnPmlQFWDIl0dUERirKCv4mhUxwzZlX5fIXoqNj6siRhmxcMcOvcUiior3we+DTH9ZgT0vO7d6bneFMZfL0HuOtIpQfsACugoH3M5geno2XBpzffZY2iQLX9LPQHea0wdjVyRTf4SS0VFpq0ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=88S7jDrrnTqx6/BA7hoV+yGW7u4XQudImA9CZUvwv0k=; b=jA0LUsdIT3ZP6DrEZM+bkw5U6XfjV4Yxeud/7YKKySgBOLdDJ0WMUbiRxRaXo84XDiiDPKCoRcvqYKh0Iter4C/DLj5aCZjnozI3E46Y1yh6Q8WixdnnFGNQXpQlGpnHFCgQRaKs160k5J5EIEjgCOCsB4KWfQBj4MD4U895lT/VNjbv6Zl5ROG4z1kskknaXCcx8VR7DfnhbRWWY/qf9OILcVHnps78tJbDxLDO+coca+9f+WR3c6bhDmCWyC3Tb84CArPcFe2tG0xRIHXgKLmYjv5pBpAkEMmZbixP7T/0EwF/HYt1jBh6vchvSaNlBoFrBY0WcqbADVm3B1z08w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=88S7jDrrnTqx6/BA7hoV+yGW7u4XQudImA9CZUvwv0k=; b=dMcwazh2BwXOpquuZYtXo8aV370QUIPKJhegnRSOo8euUO2RmnXXpWTbZoKie2t30negqkuSfwGayktFV/tnKWyaA/q5gEZkT41OIKCwHba2IWoJg8rbdY5zlr5sALJnYrLIXJrgJQrzHZM8TJy03wPWVCm53A5F3dNZXgtEVSa74fCMykqS6coAsvzhf4Eg6iAwvQFQeim4FvTTPjyGGc2LWpCHeb7WhUi2quXD2mSMoHJlDgbXtkqgUBPjK/RfHOqbIAOT2TNT+qHTJE5WzepitSTf+/9NtWI2/ZsaMfr1zmDNC98v1PJYRQH5wO8ou21lyAku+GcUPlqb4VXg1Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8093.eurprd04.prod.outlook.com (2603:10a6:102:1c9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Fri, 31 Oct 2025 09:09:36 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9275.013; Fri, 31 Oct 2025 09:09:36 +0000 From: Peng Fan Date: Fri, 31 Oct 2025 17:08:37 +0800 Subject: [PATCH 08/11] remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_MMIO switch case Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251031-imx-dsp-2025-10-31-v1-8-282f66f55804@nxp.com> References: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> In-Reply-To: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Shengjiu Wang , Frank Li , Daniel Baluta , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1761901729; l=5462; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=F0Pu5PbYhXCcMNpvc6dhR3qAgy30IsI3/b/n/oMTBRs=; b=o76M9stiHtHymzmEZ6mGEnYdukqVsnem9h8BPYWglg+8jEb25eGubauLgEFhKUtnkymMj8bVq SXlV2fAncLtBaiXM0qIJn1jAVnl5XwFgkUWT6S3ogfIwC/BO6tZ8OzN X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0010.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8093:EE_ X-MS-Office365-Filtering-Correlation-Id: cf1eff44-f7b9-4019-d713-08de185d36ab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|19092799006|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ck9xYTBpUWpsWTd3RE1ZSGNLeG80RDNrY25sRFNnU2RSeTV1dFVVVWNvTk5Y?= =?utf-8?B?M0pIb2VWdmFIcEdmR3NFL3pLK0RCZ3R6VFM2ZEJtTzl0RGhQOEx5VWRaV1ZC?= =?utf-8?B?SkRzc3F4Rjh5akNuS2NMWEV2TE14L2pHdjhoN2xjb2J6TWZram0zd0RyZ1dJ?= =?utf-8?B?T3R1dmU2cVNDelkyYjZBVUJWenl6YnVRZzV1UzVTaEJ4ejZCTmVzaUNidmhk?= =?utf-8?B?d2JjMHQzZ3dYWnVCOExvVzFueVpVRk5JRDg3Y3dUS01icElkSHpWajNkUURm?= =?utf-8?B?ZkpxTlBHMUZLR1VNVFhCbk5nNzdYRVdpRThyQnpQS3dzZVJodS9JK3I3VXc0?= =?utf-8?B?UGREd3o4ZHppdG5vdGN5bHRvVlBaNWxoV25XczJCYlJDTjJjL1FNd0wvQXFr?= =?utf-8?B?VzZFVi83TnNDTjVkL3piNnVNcFpxZkJySGJjMml0aHZUNzVYNlE4bWNjR2RW?= =?utf-8?B?ZkxWaXVLN2JsV1hpZi9CZk5jbDBMT2N1UFplOTdiSWJqNitJNEtheTVwMG9Y?= =?utf-8?B?bE5JWnB1T3lldGZKRW9EdGhVblZJL3YwYWJyOUV0MlQxT3ZsOGZETjFMUWhh?= =?utf-8?B?UkF1QW56bnVkNjRMelAyQ0NZUVpJYllZaDJIeVUvL2wyMzM2bk5xUXFxZFVV?= =?utf-8?B?bUdqaWY4VzNGejRmR1lwVDVOamNNRVF4L0w1NTVRQkNwd3NYRGdOUzd3UUZr?= =?utf-8?B?Qit4YU9qcE1sbWJxRjVMTWtKTGpqQmpLZGRtdmVIdlFKeTZ5V2VRWWczQ1hV?= =?utf-8?B?Z3RhSXhxVWZ2WWgvczVUMFF4b2dBTnBCMmpPRkVpcTFkZExPelhrcEhXd3ps?= =?utf-8?B?UVlIUmo3Q05FaVdGV2E4bng2SWovSC8rUnpaZ1kyUURodU9UYXFBbCtCdjhV?= =?utf-8?B?SnlIdGpvdGZPQnVpR09oMk9IYW5ZMmhXZEE4UHlpK3pIYlJUaXh1em1oZkpo?= =?utf-8?B?K0VKcno0NExIa0ppSWM3U0pVWGhTT2VFTTRGUzI2RmJLRU5nMzFVa09RZ24x?= =?utf-8?B?REtDSXhvT2NZK3N1czNGd2VXYWhSVXdab0xrdlF1UlZDelZibTdkYXFpa2tn?= =?utf-8?B?cDFCK1BtV0VWY0tPNWVDVHlTUEN0NlFoa0x6UVRGTFZxWVJVSnN5aUVkMXBE?= =?utf-8?B?RmtGa1l3K25rNmZLK2pXYnJ2bXhlVjZTdTV2cHQwQ0hrVnNWYzlCRHgvcGZH?= =?utf-8?B?TGRZMkE1bEVyUXZkVEl5ZVlPS1Vac016MzFvcFZLSCs3WHNSVVRBejR6aURa?= =?utf-8?B?OFExb3BaODlNREtWZERUNGU1RmNjOWtOUGx4TVg5Z3BEL1l0ZXVIbUR0eFZS?= =?utf-8?B?bVhicGRydU1LelROa0o2cUtMZ25iUjI1M050bXRyeUpYRUJLTzc5NkF3WXVJ?= =?utf-8?B?QzJjV1ArSkhZNDJzT0EzQ1BlT1dJcklCN01lSDJXYmtqVkRDZzh3ajFyZ0RH?= =?utf-8?B?TmZhR090YlBOQXh5VzJ3c1RPVms1NFhrc1BZSlJEWU9JVXlzYW81VFZGSmpP?= =?utf-8?B?M1R4dWNQV1BuaUQrNGI2WHQ1U09jS21sc0FYT1lNYVlQa3hNd1FIMVg5cWti?= =?utf-8?B?UzhmUnpBWnlraUtMNXdISFNqcGVMZnhYY1d3M0liZXFGZDVtbFluNDZYWkdy?= =?utf-8?B?RXY3cjZEWllEQTg1ajUxVEtjaVdxNDQ4QWpENk00cTNoTlUwYXlaclg4QWdw?= =?utf-8?B?Z09QdkxPSFkzRGxGUFFmUzN6eXEvYWwzbHlKQXlwc2hrNHdnSHNZZXo5NVND?= =?utf-8?B?d20rV29FOUIyL2ZxUFdYS241SlpUeUgrbndjbm1zaWsyck1yWVFjdGEvaDZs?= =?utf-8?B?a2xRY2ljTVJ6b3RTTjFKU3FOMlJFaThQVUtJOCtSZXJJckNHbFNRbWQ0ODB5?= =?utf-8?B?eVVFcmNyTG9QTmZZdjZ5ZFlnQkd0eXE5MTBTeHQ5VHQwM2RydlpNTTdHZTNW?= =?utf-8?B?SFV5QmJJRVlVZ1JJV05CTjMvWXlIMlNXRVE2UlFBbkZkMVl1dVEreElxVHYy?= =?utf-8?B?M1VPUzZYdTlxd3FxWUYrbk13VTNudDdLREtPbTZuWFo3YVFtdkp3dHJVdFJF?= =?utf-8?B?bTkwRnIxTzVySVA5WjBDYkJiRm5sU3YzbWxtQT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(19092799006)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cUlXSlZvbk5QditiQ09kQVZMVE03cU5weFhZb2I3cmNJRlQxdHR3QWM5QXRk?= =?utf-8?B?L2JYN3FvdE54cjU4c1BVVjJMZ1VBQmFHaXQwNUlpVGwyZUVxZm9lcmFLRzVv?= =?utf-8?B?bTd3TGpoVDVsaDhJVkc3MGs5dEFIVEdPNXMyMFRrTUlhU3FYaEdFT3JDRHZM?= =?utf-8?B?V1crSFppTFR5SGpDZUlrSUFFbElBK09GRHBmTFMwVWIxbVpmbmNUU3c3bVBh?= =?utf-8?B?L0h0dTlTbkpkbm8yR0wxVUZDNVMzSHplSGRLNm4rZnEyN1JhZStOblovQXhk?= =?utf-8?B?dWo5bHNDSnA1N1poRk9mQVp1Rzd6SWlleXkvVU9oRjgyOGVhdVdzcUlNOW9C?= =?utf-8?B?ci8yaDVpUlR6NUNNQ0hRMWhod1NTY1dhS2YxbUtYQmRBMWFFQVYvOW9iOCsv?= =?utf-8?B?N0xTdWlrMWtLb3JmUUQ0OVhSenBGUG1SOW1LUEwwbjMraFphbVZQSDE5T1Zl?= =?utf-8?B?dVVzbGlDVG9jSzhNdXVhTmpLK0hEOEE0ajlrRTVJTWx5Z2xicEgrbEtqbkpv?= =?utf-8?B?VS9qWG0xcTV3UmIxWVlYY0MrZm9QWEYvSlNHak9CbmJxaVVTUlZvbi9DTG5S?= =?utf-8?B?QS9DVThZWXltRW05dzc4VmxGeFJ5R0dUVzJLelBkR0hTT0N0WmdwK3NZK2t6?= =?utf-8?B?aU5vUldWbzcrSlZBMVVqNkNhYmhxNzhrVi93YnFuREdzU0V6NjB3aGlUd3c1?= =?utf-8?B?M05MWCtIbzg1UjJxS1NqeEZWb2d2TXplSFJZZW9nQ2JjcWVSY2tOS0pvRS9H?= =?utf-8?B?WEdTMm1LMldLTkpPcUVQWEZReHFrc1NMRGlpUmcxK2Uya3hSOVE4SWFXZW1s?= =?utf-8?B?NE9aYnc4MktuNFZaZXBMS29VWkgyY01zOFEzTG0vUlJmK1hlTjJVZUowaW54?= =?utf-8?B?Q3hWaWYrSHgzWmxMS1VPUm5hZHZueC9yL2F0TFg1am9HcmJtSVpzemxtQXNE?= =?utf-8?B?bmEwcHNoL1YwVGQrUitZUzVPQk1RWjNkNUFKMFJkTHVxaDRTZWphbUh3bHFP?= =?utf-8?B?NlFQSjRjbk1OaFpXb1UwT296dmZvWWpLd1ZoRWNZU0dncU9kZUZvWWpJTElv?= =?utf-8?B?VXNtZzR4bU1NZ0RFTGhsRitXOUlOdWl5MnBqYWducEZKWEQ0TGdlMXFESXNZ?= =?utf-8?B?dldIWno4enBiWklvY3JONUkxRGRDK1RFTWxXQWpURXNiczBzZnp1eGZLN1du?= =?utf-8?B?RXkvcmFIeVIrMnRBNUM3ZVJOdkRWRURjdVlCalRmREE1TElab250Y2djYmtW?= =?utf-8?B?Y0hicE96a2ZlWUxydnVtMW9KMWFVR1hZWGdadmhydHY5L1dqTmR6b3ZSbVU2?= =?utf-8?B?b0ptZVhMS3VrVkZhdHR2Tklsd0RnYlVKQkR2d0xOM2twRkh3TGp4NVF6cUpF?= =?utf-8?B?djFuS05naVU0V2U5dkpSeWUzNFQ5RjFPYlhQL3BFNi92M0VyeXV0eEpidlZ5?= =?utf-8?B?MUEwb1labnhBN3ZBTlJMdGZ3K2M2b2g4YW9LaGhFQ0tiQ1JnMHVSaWIxVmFm?= =?utf-8?B?VUsrcjlibXQyN0VLRWtTcVdDaExIN1ZQclh2Qjlwd0Y0QmxndWp4TGRKZ0Mr?= =?utf-8?B?MVh5UkdFSS90RWpwMmZZeGpiRko0dnNTS2RBN200VDdNemVDZHhlS2YzZHBv?= =?utf-8?B?dm5zMmpWOGxyQUQyOTlzSjVBbStacVlLbkRUb0o4cnpFa1dqMjlud1dsNjJB?= =?utf-8?B?UGwwd0RlVXY2bHQ4ZTUrVGlzdWxMdTJUN0tCSEZhWElreGkzR1JNeDN1dSti?= =?utf-8?B?cTRIb21mTFpjdENKMXB6K1BBY3J2M1FMaFlEaUlLZHIrOUdlNzNmYzh1OGlU?= =?utf-8?B?VFBrazh3d1lxNXNCMFg0allpbTlQelJTSzQwNCt6NktVRWNpUTZkZ1E5Vjlh?= =?utf-8?B?eEhIVXBTaDh2VjVoMkwvUERUTm9PUmpRbDFFSjVKcW1CZjlKQUtYT1lFTXZz?= =?utf-8?B?Zmlxc3pCZzhOSG1MQW9Ib1gvL05iMFhjTENZeWpCSkVXRFFOY1VXZVFlVi93?= =?utf-8?B?eTRCYmg2SkxYdG51bExsclYzWTZKVWZCZFRIL08rZ204TlA3OFBhVGdPTm1l?= =?utf-8?B?Vlo2a2ZhRXhZbVJjWXFRcmpHSVJHVzcrNWg3R1JMZVZNcytBNDFtc24rcC9B?= =?utf-8?Q?TArL0afJZmGOazy/CSTimZh3Z?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf1eff44-f7b9-4019-d713-08de185d36ab X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2025 09:09:36.4645 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IDERwc9cZIPWWQZnXbncwP3h2z0EsS0ZED6ULspl1KKegfs8jcv274jDXhEuEXWTSEtVxJsWfanUTorMXAt3Vg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8093 Introduce imx_dsp_rproc_mmio_{start, stop, detect_mode}() helper functions for i.MX variants using IMX_RPROC_MMIO to manage remote processors. Allows the removal of the IMX_RPROC_MMIO switch-case blocks from imx_dsp_rproc_[start,stop,detect_mode](), resulting in cleaner and more maintainable code. No functional changes. Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang --- drivers/remoteproc/imx_dsp_rproc.c | 63 +++++++++++++++++++++++++---------= ---- drivers/remoteproc/imx_rproc.h | 2 -- 2 files changed, 42 insertions(+), 23 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index f28d25cab3f1d89e5cde37a04b528870a59abeed..456a46f163d3d823a25d16d11fb= 79fa9fceb2ddb 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -338,6 +338,15 @@ static int imx_dsp_rproc_handle_rsc(struct rproc *rpro= c, u32 rsc_type, return RSC_HANDLED; } =20 +static int imx_dsp_rproc_mmio_start(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + const struct imx_dsp_rproc_dcfg *dsp_dcfg =3D priv->dsp_dcfg; + const struct imx_rproc_dcfg *dcfg =3D dsp_dcfg->dcfg; + + return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_start); +} + /* * Start function for rproc_ops * @@ -360,12 +369,6 @@ static int imx_dsp_rproc_start(struct rproc *rproc) } =20 switch (dcfg->method) { - case IMX_RPROC_MMIO: - ret =3D regmap_update_bits(priv->regmap, - dcfg->src_reg, - dcfg->src_mask, - dcfg->src_start); - break; case IMX_RPROC_SCU_API: ret =3D imx_sc_pm_cpu_start(priv->ipc_handle, IMX_SC_R_DSP, @@ -388,6 +391,15 @@ static int imx_dsp_rproc_start(struct rproc *rproc) return ret; } =20 +static int imx_dsp_rproc_mmio_stop(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + const struct imx_dsp_rproc_dcfg *dsp_dcfg =3D priv->dsp_dcfg; + const struct imx_rproc_dcfg *dcfg =3D dsp_dcfg->dcfg; + + return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_stop); +} + /* * Stop function for rproc_ops * It clears the REMOTE_IS_READY flags @@ -411,10 +423,6 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) } =20 switch (dcfg->method) { - case IMX_RPROC_MMIO: - ret =3D regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, - dcfg->src_stop); - break; case IMX_RPROC_SCU_API: ret =3D imx_sc_pm_cpu_start(priv->ipc_handle, IMX_SC_R_DSP, @@ -1032,6 +1040,23 @@ static int imx_dsp_attach_pm_domains(struct imx_dsp_= rproc *priv) return devm_pm_domain_attach_list(dev, NULL, &priv->pd_list); } =20 +static int imx_dsp_rproc_mmio_detect_mode(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + struct device *dev =3D rproc->dev.parent; + struct regmap *regmap; + + regmap =3D syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,dsp-ctrl"); + if (IS_ERR(regmap)) { + dev_err(dev, "failed to find syscon\n"); + return PTR_ERR(regmap); + } + + priv->regmap =3D regmap; + + return 0; +} + /** * imx_dsp_rproc_detect_mode() - detect DSP control mode * @priv: private data pointer @@ -1049,7 +1074,6 @@ static int imx_dsp_rproc_detect_mode(struct imx_dsp_r= proc *priv) const struct imx_dsp_rproc_dcfg *dsp_dcfg =3D priv->dsp_dcfg; const struct imx_rproc_dcfg *dcfg =3D dsp_dcfg->dcfg; struct device *dev =3D priv->rproc->dev.parent; - struct regmap *regmap; int ret =3D 0; =20 if (dcfg->ops && dcfg->ops->detect_mode) @@ -1061,15 +1085,6 @@ static int imx_dsp_rproc_detect_mode(struct imx_dsp_= rproc *priv) if (ret) return ret; break; - case IMX_RPROC_MMIO: - regmap =3D syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,dsp-ctrl"); - if (IS_ERR(regmap)) { - dev_err(dev, "failed to find syscon\n"); - return PTR_ERR(regmap); - } - - priv->regmap =3D regmap; - break; case IMX_RPROC_RESET_CONTROLLER: priv->run_stall =3D devm_reset_control_get_exclusive(dev, "runstall"); if (IS_ERR(priv->run_stall)) { @@ -1301,6 +1316,12 @@ static const struct dev_pm_ops imx_dsp_rproc_pm_ops = =3D { RUNTIME_PM_OPS(imx_dsp_runtime_suspend, imx_dsp_runtime_resume, NULL) }; =20 +static const struct imx_rproc_plat_ops imx_dsp_rproc_ops_mmio =3D { + .start =3D imx_dsp_rproc_mmio_start, + .stop =3D imx_dsp_rproc_mmio_stop, + .detect_mode =3D imx_dsp_rproc_mmio_detect_mode, +}; + /* Specific configuration for i.MX8MP */ static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { .att =3D imx_dsp_rproc_att_imx8mp, @@ -1321,7 +1342,7 @@ static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8= ulp =3D { .src_stop =3D IMX8ULP_SYSCTRL0_DSP_STALL, .att =3D imx_dsp_rproc_att_imx8ulp, .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8ulp), - .method =3D IMX_RPROC_MMIO, + .ops =3D &imx_dsp_rproc_ops_mmio, }; =20 static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8ulp =3D { diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h index aeed08bdfb5619c7afd7201589f417cfd6745818..912827c39c0dedeed76c13740ef= d42a8e7cf9c45 100644 --- a/drivers/remoteproc/imx_rproc.h +++ b/drivers/remoteproc/imx_rproc.h @@ -18,8 +18,6 @@ struct imx_rproc_att { /* Remote core start/stop method */ enum imx_rproc_method { IMX_RPROC_NONE, - /* Through syscon regmap */ - IMX_RPROC_MMIO, /* Through ARM SMCCC */ IMX_RPROC_SMC, /* Through System Control Unit API */ --=20 2.37.1 From nobody Mon Feb 9 09:54:47 2026 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11013031.outbound.protection.outlook.com [40.107.159.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08EBD33374D; Fri, 31 Oct 2025 09:09:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.159.31 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901786; cv=fail; b=OppMf/Rb98dVdmmOVENsVgn+vhpyOHRMNobFNMtKGeoIjwbOSL36lUKL7cvbDTEgH7zYAkiAvEHGN77rCoglfPobpLWvvBO9UTCOBA8HBsMsW10MEGEBHWZccpIM2Fvs43yr5SsEnNulyLSGtDcQIIOQ0r+lTRVq07FXNpdAJXY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901786; c=relaxed/simple; bh=8CdnUppDBO0Dz8YmLGwT/h0Pc+sRSW5ROgezwbwF544=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=qjSn2L9EPqX3fSfROopwuCXyQK23+J2DN61XDklzQS/LIw3/I9LO/WAbb0U8LkVuDlDnD8FYA8bxx4eRYtTW+xM3DZFZXMUUb5/TCOdofZDYEJccwmicrtRNh7vV0Sx8F3xKSJ7tGXfiO8J9SUiYtuvDAUx3eUtOzuC2M1n0YuE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=Gn48MN5L; arc=fail smtp.client-ip=40.107.159.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="Gn48MN5L" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vDlQYw9NDcJ/PsYDlTBZvzieEhGT18x6GuXXLGl2WAYPOeMg3mskJ+41cZgGHxqKdKykbaGqYp4SgH2/JSoZ2HrMp+hc4GBmYzXM6HPfzDEEHZEfv8t2k0iFQKrEUOrEWBLOVsOeUn5mCMg6s1eci/1pHVPIJUXMGfduXSoCGR8f7ujZuzc88EizY6l1j8XkAG3HLAIyHHHMQvfqXKV3DJ58d706sGCL6DU9QTVTLhi3EUa7oBmaBVUDQ20OGG9THM/606Yt/Vn+5Y+Thoweh1gf0gfGH5CVLiQhXuOm4j2982BC2m/aSR6bzoNvQDsTU/LxROFjs9VplJ4h3TeE6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Yb4XEJh46wl+8ohfpGQztVn4iFwSPnrj7H7spt26Y4=; b=CjENT2URR2MFtPFoH2mZB3KFHXac3HIXU7MQ0QmpT02QWX/4aVKKvHls8Jpv0w6HtbRDBidu+BoktDUgiImS6nlbK9dRBhHY/4ry7ZOs2wwsATM6Lj5W8/bGl+JbYSf2VKqaGDkReAkGMNJDw7Cv0fBky5VXsXfntIgmmo1GpsZaqm6gV6P44OIeLMIYMNwCZjMSCduEEUUy1pUNtVuEQimoHg9gCNLpvTDOCQHbZ1MiOa8WoQHuWVQgUijNYlEal7jFhhXPF0EbNFK9p8iyKekJybFWOX1At0hleMsYNIeGHQz4YPmoYGLfUIrj0/3Lwa2kmQvEMNDoBy04TKRi5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Yb4XEJh46wl+8ohfpGQztVn4iFwSPnrj7H7spt26Y4=; b=Gn48MN5Lsl9eVeEW6BirW3ZQ2qXGGVdiw9OaJKe0sHWQgwk4pydLexjQHLnSf5kQITvkRH4JVknVCbTvPI91aKnKgXM0do7x14HgW3YIqdZ0J4nmNYVbMVCFvkf569dCMU2ZxDb3U0vIPRIhL25nQ+skZeLkRsnPradLNdHBf8RPFcXmd3KJqH9mFS7CbHbbsUHzJmGlIUKvbkJT2yVdQDSTPOIUBt9diFAPiMDk3xP8Rp4QuDiZF0gkFs+ykl2nHwbpJslrHnrCShQH1KZ/6NRv0zU0lSp2DsBwLc4BLPTTQQjedkSwZsOTouiqNNjYRP+HZ/rPF9yhB24Q1qeNzw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8093.eurprd04.prod.outlook.com (2603:10a6:102:1c9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Fri, 31 Oct 2025 09:09:41 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9275.013; Fri, 31 Oct 2025 09:09:41 +0000 From: Peng Fan Date: Fri, 31 Oct 2025 17:08:38 +0800 Subject: [PATCH 09/11] remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_SCU_API switch case Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251031-imx-dsp-2025-10-31-v1-9-282f66f55804@nxp.com> References: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> In-Reply-To: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Shengjiu Wang , Frank Li , Daniel Baluta , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1761901729; l=5071; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=8CdnUppDBO0Dz8YmLGwT/h0Pc+sRSW5ROgezwbwF544=; b=uxjunjYaNZxKKvSk8sshGlJy1PjDcIsxI3bV7+XEle7sEXxwWHl5/yRzHOiOs53XgBbeV/8sW 4dL+lUWqWDWD/aob1kXiQpTmnlr7lOv6UGR9s1JQqlUzsXWBB3aA6W7 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0010.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8093:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f58edf6-2496-4d7a-01a5-08de185d3999 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|19092799006|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MVlKZmtkQ2s4NGIwL3M3bFQwWmtWTU5ubVlaMUlvUFk0NjNGNjJWK1JValRw?= =?utf-8?B?WG1jbHY5eVJ6WEtIaTJPL2QvTGE3TkhRbHA0RFBVMzQ5elVGaXdPeEJ6K2Ni?= =?utf-8?B?dlRFaVNySm9ZZExQdFdVeXllTkZTQkRQcnRlbFNGTFZKblZ5ZmZXa1doR0s1?= =?utf-8?B?VWVRVVZoMEcwbnp2VWZkRTNnMjFZdndib3pwTHRhVVo0NE5Tb2piSStLNTAw?= =?utf-8?B?OHhWS0pKZE05NzBEU3BPZkdyYUNYR29pM2VsaDN4UGNNUWRiWXNjaVl6ZVdr?= =?utf-8?B?eUJ3clJ2dC9nUnRMeHBWcFBLRE1HYjlLcDM3Z0xhMzdiU3N5eCtYb2lqODlP?= =?utf-8?B?aWFiWmRKR0dSVFdrSUpFUjlXVC9VeFBJZElhV3RVR0FJRHRaekxzdTExb2hp?= =?utf-8?B?REluTGd6aVB2S2ZERWxVcVVEWld4ckFnTWxNTmRtWWRYQVpxcWMzZG5mOVda?= =?utf-8?B?RVoyZFlqTUNYc0tHYlBoTzU5K1BkQlhsbXVlYWhTakZyMkRVLzBZTmRCUkVG?= =?utf-8?B?UHBaVHRsQlJLVkFycSsrczM4b2hiOTBTSzNNSmFhRlF1RTJZbTlwWGZpRzNq?= =?utf-8?B?R1BZQU9NMXdodXJhT2RwVUdpbDdKQkNiNXdFbTJhZFpkaTRrMFFvTGc0SnRr?= =?utf-8?B?ZGNkakpOQUM4KytPbFBGM05LT1JMeVNkazg4bDF1SmZEa1B4bXR0Q3J5TXh4?= =?utf-8?B?NnRhOCtxZFFXYVNHNzMxNUtkQmpoM1R6WTJ5a2paektNcDdpdDZybGtFS0dZ?= =?utf-8?B?UVhzZ3pCQXc3bS9MNi91aVBva0MyYUdxK25GUFhwOERjOUc3MmNZYWJDdzB5?= =?utf-8?B?YTFpKzVQVGNlWDFpcE9PMFpUYml0eTRxUjByd05kVlh6Q1FJcWd4b1VUa3BH?= =?utf-8?B?MkFxQ2o5d3lpYTk1U29tLy9LOHhxT2RSbE0reWR2Q2RpZlVVdDZybWI2ZWs4?= =?utf-8?B?N1dWSGhWdmdQN3BWS01ETXFhbE53UytWY3hNR1loOUJ3QU5pYTRyZEI0SGRm?= =?utf-8?B?Rm5iNWdQejAwTUNYb3A1WTJzTkJIaDl1TzlXaWZhd1ZSWmtnWmxOdExPRVpr?= =?utf-8?B?dTEydVVkbGJaeXlUWDVwTFdPWEY1bU9MQWhUeGRGMTd5TWNOK1o3dDdFYnB0?= =?utf-8?B?UHlBUk5yK0tkbWdOZldJVVRXY2FJNkxEUkNva2FZUlVncW1OM3NUc3FybS91?= =?utf-8?B?U3VSNU1ENTdDaE02ZXdkcFpzODAwV2FWVGNnaVNPL252U0FBd04xQ2Nxb0Np?= =?utf-8?B?TGpzVWxZVkNGdDRZbmZLdnZGVm9YTzdHQVNFQndOckxYaGVITWt5by9OWVRU?= =?utf-8?B?allQTS92NmhPVVhqU3U1V0F4QUZNNWZXUDZUelFORFNjdzZuOVZ1c0VHN1ZU?= =?utf-8?B?clN2TXErVTJ1NGJFZGN3aktCQTJPdHdaQnVaZEZ4L3N2a0pDREhFMjh4RUdC?= =?utf-8?B?R1hXR0tWLzVKVlYrYmZZL0ZhL2grSXBJZzJpalRnRVFhRFNPQlNBVGhjTGtD?= =?utf-8?B?Y1RlTGxvaEVKdVlnRU02S292Y2R4NnF4MFJlTk9VR2tMYUFKcklWNmt5RHEy?= =?utf-8?B?Y2hmblIxamtRM3VCaEE0cURxTWVoYTRZbC9WcERFaGZ4S1B6Y09YVjRXNjBl?= =?utf-8?B?U0duNTUvbkpHMysxVDRrRWU0Z25PUGxlbmZJRHVZeFZwWXFUMktLQTJTTkxY?= =?utf-8?B?V0pLUWtyenZJdWFhODljbFdXTHNJd2t6TnJ2cGdCQWkxSEZERWJZeWlMa1Jn?= =?utf-8?B?MmpyQ0wrNkY3UnlOK1FrcHhhVi9qSHMwemZFcnhKSEJQdE81SXJqbVRnUkp5?= =?utf-8?B?ZkdKdkJPNlJmdVg3blVEdm4wZU5FMGV5bUVUK2Z2ZnJyK1BzYXVYUVlFWWdQ?= =?utf-8?B?R01WZlVjbW8zQWU4d3kzWTFyQjU2TGVDaDNtU2ZRQlVGOTRyL05CQXg4ODRl?= =?utf-8?B?blc2RXJtajJVMUNPZGVXYkIwTGhFdzRrQ2oxMjd3WGQ3NklFeURiZmxMeGtY?= =?utf-8?B?aU9maWdtZEdqV3RIKzRyNHdNNWozcngxaFpvUkhnSUdQbkVyQUxJWDdub2F1?= =?utf-8?B?NWxtamFzbWlYSG5ZRzhSRC9Qc1JubWVMeFUyUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(19092799006)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bWR1MUZtbWdnaFM0T2s2bTZ3WHhkekxneVZNU09oRjR4bG4rTEFkelJZUUJX?= =?utf-8?B?VW85V0FnSk5lZmdNRVhQbmNLWVlJRitHNUpGU3U3b0pOZDFtYWkweldnV1VH?= =?utf-8?B?eVkzN1k5NzdoMXV4cHVza2lNVUtMbmpiMThEUk5xbFdnOHhkRlZsWTdLV0o4?= =?utf-8?B?Y0ppdjk5c0s4NVpHalJGVi93UXRzU1dBY0RiMndqbHY5ZnhuTGxrLzRTTHV4?= =?utf-8?B?YlpabWtrZHBuNTcyNTYzNUFzQWdBM3F1cG90K1piWlBXaHhSZ2lLSUlhUHpH?= =?utf-8?B?L3NBWXBTdkdCZzFMZDdnVjhaSUwyd0ZTNjRNQzg4S3l5L0ZsMFRxa0w0eUVS?= =?utf-8?B?eW5Pcmx5U0lLS2E0RTVUQ2dZUlZuTDdnVlNCQTluUDlyVVFndXcwMDMvcVRY?= =?utf-8?B?UmNhbHB2NFQzVGgvSXEyaUI5Y3BaVGpRWU5mK2VXVzlDYzJJNWRDckswaklD?= =?utf-8?B?SjhRc0ZJMTdUNFp5Zk1mYU1TaHBwK0VDelNSRzdCUTBCRWxjcU9rdlpQc0tZ?= =?utf-8?B?KzlGOFNOYWVNNm8yNHg3K0xiZkRJcGRidXlySE9LT2RxK2JtSDhNeWo4c3RO?= =?utf-8?B?dGVMUWUzMVlKK0p5QTRLcGMwbjg3c2ZSTENRNEFlemlONjNaUlcxNEl6MVRv?= =?utf-8?B?d2IvejFSUS9pL1JqRUd3KzdpV0VkT1BuRmVPL2R1WlNYcTR1aEVJS3hGbkp3?= =?utf-8?B?Y1hNTG5BeWVSL0dza0dYNDl0cC9EQmN0eUJWbFdiVnRySTlUVExaM0NFN0hr?= =?utf-8?B?bjBLc2pxOGl3eXQvY2FReXN0OW92MGxHS3BxTjltVGVNN1oxT05Kc0sxb2N4?= =?utf-8?B?UDc2eDdXSWhFczBFcEEybGVJNnRHbENxMFhhZ2VLdFF6QzRvaFc5Sko4b2JI?= =?utf-8?B?andDVVJDQUJ0M05wWkFqbm5aWEhaMXIxajE1UUdSai90Z3l6L3crZytzWFBZ?= =?utf-8?B?S1UybmtadjM1bHYwMU5lNkdZOXdLWnpJM2plMG9ubUtQZGFnUnVaRFJSdHFm?= =?utf-8?B?T2pqQzB3dElreElPdXlnbXNzM2JWdGw0dEhqdjQ0K2NtcVZTd3FEenlnenJY?= =?utf-8?B?Z0FoT1FxVXZtbXFhalFKMS9aRG5waXdYK0VDUzRkVGoxS2NTRmNpaXFodVpu?= =?utf-8?B?NDY2YlhSZmRBR1k4VXl6SmV5clRyYTQzZmtRTjEzOTgydlJ5T0x0TENMUkRn?= =?utf-8?B?VVNUMEx4TWFaUkw3R0JHYzdIYWZvMzV2OThlak52RWN6eUxWZGlWSU83S2Ex?= =?utf-8?B?ajRyNG1XL0tzYWpqYUZhNTRTWDFScXlVOGU4T2VoSktXM20vcWlKUWJSNlo3?= =?utf-8?B?VE41eHFYNUxlZFdMV0g4U25Dd1B5TGhjUXRCTG9hbmtkOHlidS84YjMwN0pz?= =?utf-8?B?WnhLUTEwdGhvUmtURVBkdXJoc3VLYkwvajFaMmVVZDBEeWhQRi9IaUFySVcy?= =?utf-8?B?K0hEVXZDTnc2UnBYK1hSUGlpZS9XVC9RTGUwK0xmcW90a3dRd01YYUVKVWto?= =?utf-8?B?QjcxUlVZbSs1OE5tVFFnUUFvU0NkTU9jeVNucy9UbERJYi8yV1NtS3Fpc05i?= =?utf-8?B?TkdnTEZ3Vm1uWkVhTUdNd3pnSFVDMGRrNDU5VGZHbkhMVlBlMVMxR3VDUkRK?= =?utf-8?B?S1BaQUIvSWdkTG5xV2RkMEdDaUM4RVBEZG1VaXdoS2ZSWlJPZTRYUG96SjNs?= =?utf-8?B?ckh5QkJmSDRUdVVRc0NJSHFhK1Z3UjEzM3NjYWhxbjBkc0lMQm83UkZFOGp1?= =?utf-8?B?MVZqV2lvUHQ5UkY3KzNLVXhMM0ZMRjMvSWRha1g2SUFZTUtVaStjWjl2RXpD?= =?utf-8?B?K2xraXN2YzFnQTY0STRhLzhTejRjTUR4YVN6ZldwaEsvdlR5VFVuTUE5NlZN?= =?utf-8?B?Zzl4Z3B2RzRTUzdKR1ZNVUNqUmR6MmdvV3B2czQ0VkQ1TWpyYVlXeGNEelFF?= =?utf-8?B?U1RxYm1SdCtEVnRWUnQvUW54akpDOVdGMHZSK1Y5TkNpdmZwc3V3MmJpdjIw?= =?utf-8?B?Nm82ZkYwY1FrTkJiaTlxMGRtdktzZDZOYW4rdExsK3VCMUlDRWphS253RWYy?= =?utf-8?B?RnQ5bXc2bkNObnQ2VWhadXhsM0dqTTNKKzBTbDQzV2RkRExNaFZTMVEyR2ly?= =?utf-8?Q?foC7aYlRektzaZt3tLz5tTCNj?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f58edf6-2496-4d7a-01a5-08de185d3999 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2025 09:09:41.2218 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +ez5T2r8fughPJoz0UWgfgf6IWJVDtGPmUEi8U4kG+8gyqCnN5db6gEA9de7WLxfIO/D8nLFZmWeiwdaLPxFHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8093 Introduce imx_dsp_rproc_scu_api_{start, stop, detect_mode}() helper functions for i.MX variants using IMX_RPROC_SCU_API to manage remote processors. Allows the removal of the IMX_RPROC_SCU_API switch-case blocks from imx_dsp_rproc_[start,stop,detect_mode](), resulting in cleaner and more maintainable code. No functional changes. Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta Reviewed-by: Frank Li Reviewed-by: Shengjiu Wang --- drivers/remoteproc/imx_dsp_rproc.c | 48 +++++++++++++++++++++++-----------= ---- drivers/remoteproc/imx_rproc.h | 2 -- 2 files changed, 29 insertions(+), 21 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 456a46f163d3d823a25d16d11fb79fa9fceb2ddb..56e94754d5c5feba112227c45b0= f99a4fe868926 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -347,6 +347,13 @@ static int imx_dsp_rproc_mmio_start(struct rproc *rpro= c) return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_start); } =20 +static int imx_dsp_rproc_scu_api_start(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return imx_sc_pm_cpu_start(priv->ipc_handle, IMX_SC_R_DSP, true, rproc->b= ootaddr); +} + /* * Start function for rproc_ops * @@ -369,12 +376,6 @@ static int imx_dsp_rproc_start(struct rproc *rproc) } =20 switch (dcfg->method) { - case IMX_RPROC_SCU_API: - ret =3D imx_sc_pm_cpu_start(priv->ipc_handle, - IMX_SC_R_DSP, - true, - rproc->bootaddr); - break; case IMX_RPROC_RESET_CONTROLLER: ret =3D reset_control_deassert(priv->run_stall); break; @@ -400,6 +401,13 @@ static int imx_dsp_rproc_mmio_stop(struct rproc *rproc) return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_stop); } =20 +static int imx_dsp_rproc_scu_api_stop(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return imx_sc_pm_cpu_start(priv->ipc_handle, IMX_SC_R_DSP, false, rproc->= bootaddr); +} + /* * Stop function for rproc_ops * It clears the REMOTE_IS_READY flags @@ -423,12 +431,6 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) } =20 switch (dcfg->method) { - case IMX_RPROC_SCU_API: - ret =3D imx_sc_pm_cpu_start(priv->ipc_handle, - IMX_SC_R_DSP, - false, - rproc->bootaddr); - break; case IMX_RPROC_RESET_CONTROLLER: ret =3D reset_control_assert(priv->run_stall); break; @@ -1057,6 +1059,13 @@ static int imx_dsp_rproc_mmio_detect_mode(struct rpr= oc *rproc) return 0; } =20 +static int imx_dsp_rproc_scu_api_detect_mode(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return imx_scu_get_handle(&priv->ipc_handle); +} + /** * imx_dsp_rproc_detect_mode() - detect DSP control mode * @priv: private data pointer @@ -1080,11 +1089,6 @@ static int imx_dsp_rproc_detect_mode(struct imx_dsp_= rproc *priv) return dcfg->ops->detect_mode(priv->rproc); =20 switch (dsp_dcfg->dcfg->method) { - case IMX_RPROC_SCU_API: - ret =3D imx_scu_get_handle(&priv->ipc_handle); - if (ret) - return ret; - break; case IMX_RPROC_RESET_CONTROLLER: priv->run_stall =3D devm_reset_control_get_exclusive(dev, "runstall"); if (IS_ERR(priv->run_stall)) { @@ -1322,6 +1326,12 @@ static const struct imx_rproc_plat_ops imx_dsp_rproc= _ops_mmio =3D { .detect_mode =3D imx_dsp_rproc_mmio_detect_mode, }; =20 +static const struct imx_rproc_plat_ops imx_dsp_rproc_ops_scu_api =3D { + .start =3D imx_dsp_rproc_scu_api_start, + .stop =3D imx_dsp_rproc_scu_api_stop, + .detect_mode =3D imx_dsp_rproc_scu_api_detect_mode, +}; + /* Specific configuration for i.MX8MP */ static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { .att =3D imx_dsp_rproc_att_imx8mp, @@ -1354,7 +1364,7 @@ static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_= cfg_imx8ulp =3D { static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qxp =3D { .att =3D imx_dsp_rproc_att_imx8qxp, .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qxp), - .method =3D IMX_RPROC_SCU_API, + .ops =3D &imx_dsp_rproc_ops_scu_api, }; =20 static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qxp =3D { @@ -1365,7 +1375,7 @@ static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_= cfg_imx8qxp =3D { static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qm =3D { .att =3D imx_dsp_rproc_att_imx8qm, .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qm), - .method =3D IMX_RPROC_SCU_API, + .ops =3D &imx_dsp_rproc_ops_scu_api, }; =20 static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qm =3D { diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h index 912827c39c0dedeed76c13740efd42a8e7cf9c45..a6b4625e8be76c6eb6a5d8ef45e= b5f3aec5fe375 100644 --- a/drivers/remoteproc/imx_rproc.h +++ b/drivers/remoteproc/imx_rproc.h @@ -20,8 +20,6 @@ enum imx_rproc_method { IMX_RPROC_NONE, /* Through ARM SMCCC */ IMX_RPROC_SMC, - /* Through System Control Unit API */ - IMX_RPROC_SCU_API, /* Through Reset Controller API */ IMX_RPROC_RESET_CONTROLLER, }; --=20 2.37.1 From nobody Mon Feb 9 09:54:47 2026 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013055.outbound.protection.outlook.com [40.107.162.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6CB032E139; Fri, 31 Oct 2025 09:09:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901790; cv=fail; b=Hb+fsWfU1IqH7tHobF4m1dtq4octalmycRwfGNeKRvE9nSUhafyqgKyKPojqx5WuHRKZYQ27MNvWvasyoMbr4YvC6dvCrdO7MAU1gvIGy6rybeXB8Vsfnn6INu0Rx8lCJi6cpodf03hTfjxVWrQW9NEuvhzAA3C2oJ3N829EOLo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901790; c=relaxed/simple; bh=ASF9ewtxnhsHZWFfjAEgwtIXAbL1as5l5GSNwowaqBE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=bnhdiYpxGoBRna1rliTWEd7KPY9LbZkQCYbHunp5osRpPfQPVkIm4xhMHhATg1/k0FhC59U5d6U3wrOPcbNkJxnUKzaplkYBQueM03+u+Oemg7gfdkRio0U6CIFDFm0fnMtscZGUBTqyKriDwVqzjUY6wKt7Lw5SmzkMLO42Vto= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=FUZbpkl8; arc=fail smtp.client-ip=40.107.162.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="FUZbpkl8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lCA1nNI5z2W6+87yQKCPEgv073jezfKj2hP57D/QbfFjZT8rmTlrOaxMnrvLH6QoS5UrsTe85P4IqG9kt9FyEyNct3++JB1QU4lk3wrAc7cmJi+oXiBUNLqzuiFr6WiI3azKhebAl8s1DQBtlzzrRsREJ3eEjiYx0EjljrZYV0hDTgTsHySbMly8m9aH6UaYuf+01eqKlD9GBRq3lhysivLjwfxmn1lMnuI5i02nBC8d1cBR9l91N4uvObJWaQik4A2+X+Erl2WY5RyEqVPLPS/OGdHAJehB8XQGM6+BQq8vdH+Eq/mTU3V80gLOev0kKs6dovX0WQayZqqIrG3lKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M3sqegU4U//A6dohScseCufvcIV850AyUuNBrZWAUss=; b=KjLqPq4+SU7hYHfRkrZWg/B6rYnuztSfVi/6wyy5s1RNSTS201QN0AGCTD5LTcja7UcszIkLTs777mk9i6SQ+aATZ6iUcnno/d65FzNtv5BJv23JSa8tmizIU5pGZPWto6ca0M/YjwBEEb84/4B0U8LSEqSIXfdndp1wGVyhkKqASlYXmGQpVzXQowR7trPd2HF59mT9eyOxK1bNabMRzlSpqtqOfp1f+OI2iC2BNO9blSc0FgNqbqIFWYyFa31e9T0fSgIgUzHowzbUzNzHRnC8BPNUIpHH8A6DbOTxHdoUJL9jP9Vdl3+wHKM3XM4/O5cAh7JXAuR6ILL3/z2Myw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M3sqegU4U//A6dohScseCufvcIV850AyUuNBrZWAUss=; b=FUZbpkl85gx4JLw0XTyWvx22KxBeZXm9HI2BXI2RO6wCHdZ5EWKewnOH3tk9K1tr9NBZySVzXjU+usVFrnfquWb8E8P51hKOmBaBkIBF8M6U9zaRRFkkwELK/Ys27qD/dJFj8uKJoyfyme9ZJ9C3Gd5/tMaarCsMBQVHh0MxGK7V1K6Io7mgJHK0iELx4udyeVY7quW+ZCGvg4irnM3wz/xfDgrh3z2E6lvc7lctkgvviJBDPQg5tWM6XGLpzfhi9MQJVC0J48WACx7y4ueOfsx2O3xWWHVzRllfBkk2sYQ/TgFsacZaZlbRjFiU+uWos9LHwDN5QcRu1nmfXkri9Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8093.eurprd04.prod.outlook.com (2603:10a6:102:1c9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Fri, 31 Oct 2025 09:09:46 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9275.013; Fri, 31 Oct 2025 09:09:45 +0000 From: Peng Fan Date: Fri, 31 Oct 2025 17:08:39 +0800 Subject: [PATCH 10/11] remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_RESET_CONTROLLER switch case Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251031-imx-dsp-2025-10-31-v1-10-282f66f55804@nxp.com> References: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> In-Reply-To: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Shengjiu Wang , Frank Li , Daniel Baluta , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1761901729; l=5281; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=ASF9ewtxnhsHZWFfjAEgwtIXAbL1as5l5GSNwowaqBE=; b=rmOe+TQyU7rKw7EtOhfyvSJYpxv8FT6ROrlZ3TgU60tOuylTM3ofkg991yls3wDBwQgYDwMbg 9U1292+++IED1JZOnZNPoMQU/udce+Ag9dn1iMAOUIuERdiaSk/GjBw X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0010.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8093:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c9a02e2-c9bd-40ef-35de-08de185d3c56 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|19092799006|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UG5MREdqY2REdkVVa2dCOFF6a2N1SElINkZRam41aVVLMVc5M2FuZEhzYlVm?= =?utf-8?B?YWxqWTBERDBNb0xBeU91czYzQ2VMazRTeGFTek5CNXR0TmowZFRhZmEyVWJu?= =?utf-8?B?N2hiMExOQ0M1UTA2ZEtKQjJWMG41a0dIb0grS3p4dVMrbzBTMDZKdnd5U2px?= =?utf-8?B?VGtDMDVnR2JEQ3A5dEZUbnRMcWl3M0tHN0FmdzRDZXhnZVNCSk94Z1FBL0U0?= =?utf-8?B?NTd5STFYMzlLQ2ZyRXFUZVgrTjRMbzdtZUtxQi9TMDY4TkI4VUtZYkl4UGlK?= =?utf-8?B?L3lDSlpVTy83M0RhMGNFQnhqalcxdkIycjZuRnJxYStCL2l4b1BWaUtrdGpY?= =?utf-8?B?dldDdUZQR3ZMNytHV2J4MlJ2cHdhM0Uxcm82YVE5T2JnZDBrRXFualNTanQ2?= =?utf-8?B?L282aExIbDA5bDdZWjNIaGFSVEoyS3p3ZUR1ZFVHa1ZGQlhJaHNhWFBwUTc0?= =?utf-8?B?MjFtdXQ1emk2czhkb3BxSzU1c3B2bU1tL1V6OGpjL2dFbnJpVWhXZXI0QzBs?= =?utf-8?B?Lzg5NUU0Y1hwYTJ5eU5vMWU0cS84TjBGOEJqQXkwZlJ1YU0wVDdocUNUT2gz?= =?utf-8?B?a0RwL25xYmhmR0dCSi93U3RhVEhoeEVwY09hZ21mVGd2V2psL0JPOG5kS2RP?= =?utf-8?B?MWorSTJDK0Z6dWMyVHg5QXFEQnBkK04yVWlVWG0vQVREUWQwNU9Hb011MC9P?= =?utf-8?B?MFR6ZlFzdzJvZkt2QXhXR1N4Tjhkem45N3dBSlBES0pSTVpndUZSSklqaE9t?= =?utf-8?B?M1JTNWl4TjAzcXFGU0J1SmpBQkRvQjJOWFBLT1liSU5MKzlIUFBkRmV4Rllx?= =?utf-8?B?bGJaK3VZTW8xeUpaQzFYUVByL0hNbTMyUUVtVHQyeHFWWGNUcC93NXVJUXBS?= =?utf-8?B?cTYwUmw0OHNDUFJQbXg2MytIU01wWWw5YW9jK2g1ZGVXeHlqZDk2eitubFpH?= =?utf-8?B?ZkxDY1FpTWdma2xRQWhEc1p4WGtlVlRFbnFwOWVYRUhGVm1BYjRWek5OdFFi?= =?utf-8?B?VlZLYm9OVjVTVUFUWlpWZmxHVGxlUDNZcUh3ZVBlcDA0dS9xUllsZHdkU0FU?= =?utf-8?B?dEhESnJlWHQ5bDJOcDBkYjJiQ3lSMnBIVHZrVFVGM3duRTVSNndBcEsxaDMr?= =?utf-8?B?bUVtbGxpZk93bi9qN0hMZDRJaDd0bW5pYmpGc28vMDZTKytya3JCM0owTWNw?= =?utf-8?B?bCtRdURBVkNvejhKZzVrb0FTQzJPcFNhQ2JFMUlpZlZJSGFEUUFLMWRHaVVM?= =?utf-8?B?cXQzcndTVXE2UEFuNERCemxMNzJMNXdLajYvWktzTjJtbkZIaDQ1ZzkrcnN0?= =?utf-8?B?ZlcxWE15N0QzOUtZaVRRV2dWcnBvZm8ya3Jjc0xySS9XbDc2dWQ2eXpuZ1A5?= =?utf-8?B?YW1lbWVHOFJlRzJhNDc1cnQxOWNTby8vaVR5SitFNmUxemZPYUIrNEU1S3Z1?= =?utf-8?B?SGR6V2Q3dkxBeFhBc25Zd3FROW9QK2czOTRZUzNUTXZxSC9YRnhlUXdvbVR5?= =?utf-8?B?WHhvNFZNd2FOQmxYUFBES045WDM5MGlZY0VmSTEzSW4zY0tjYVlLOFh3ekJN?= =?utf-8?B?bkxQSGdQcUg2TEl4TThUdzV5ZU1LWWllRmtxZ0ZTQ05MeW5LcSszYkQ4ZWZ3?= =?utf-8?B?U1cyMEpsVjBJQUh1OW83OXhjd01pdkNSTmVDSlVvS2pDL3hTNkdEbzFrQUFU?= =?utf-8?B?UGh3TlFDYlhuS0ZJVVZveWh5eTdHWlB2N0NDdXJoVXhpY2QxU2pieXBlOFE2?= =?utf-8?B?T2tRYk5hRnhnakV0aEZMM0FCTWNBZERXS1BaRGlzMHlzZlA1NmU4eElHSzM0?= =?utf-8?B?Nkh0eXlYOWpOa2lrbExyb2c2UllvcVY2Zm1ab0RyQjZDaEJvZHJHa05UbEcx?= =?utf-8?B?TDlFcUdRN25zekZsTkNOVUF6bnlGaEwya242WVdEd2hrckdRSU1Bb2VZdUJV?= =?utf-8?B?VmlGT3dUbitHQTI4UEV0ZnBCVlRPVmoxVFVUNldYQXZpamppb044RkVPVzc3?= =?utf-8?B?WGJvb2V6TE4zcHBWc1MxMWl2bzJyRU81dHBrdEFSQWpDZ3NLcmdFcW9BTENY?= =?utf-8?B?MkpqYzkvWi9SY2xYQWZGMGp5Tkcydlhmcm5Bdz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(19092799006)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXFVN3NjdGZaT1pLN0poek1VMGJsMlNUbVZmLy9OelZaald5SUtma0FHSEFJ?= =?utf-8?B?Z1pSRkRIekF4Nm1vV1lJS2JTbFV4a0pJdXVyMlJleEpUZVJhWGFYNFcxTWJQ?= =?utf-8?B?bHlEQlVJNEZGbC9jRmxDSEF3SElDK3FnTU5XQmZIa25qem5JOG9teU8waUNs?= =?utf-8?B?M01ka1VNWnVWdVJYTkJDRGt6UmYxWmpkK3JuWTUwVEVDOUtNVzBDcGhqbHh6?= =?utf-8?B?endLeTcyM0lzejI2OXpyNUU3dXRCbjA5c2VQNENSYXc3RTRvdE0vRnI2WkU1?= =?utf-8?B?YjNZaGNIdlRpaTJBWXRhS3RvZ01tVXBmWXBPVUtRRzEraVhNV2Z1SndXZnI3?= =?utf-8?B?SnJ2K0RFcXBmS2ZaZW5zNjMrUDZTRTg0NDhsMUFUYkNHVklkSGNGbzJSNW1P?= =?utf-8?B?cjhhaDBmR0Nwc29hTTF0NzF3QVVRNFAzVVlrTWNBWVR4MmFLRzZJdVpvZk94?= =?utf-8?B?Z1JiVmRTZXF0Q2k3aEE1YTEwbnpOUWFEUnR3N3RqOXU3QWVnYklkVXJGdUdQ?= =?utf-8?B?R2FmbG5ON05BZUdZanljT3hrckZkbnVIamFnRnJSc01TcnZQVWpRcDZzczZG?= =?utf-8?B?MFp6WWZKM01uc29FOU5PMUxXTy9tR1dGcWhEZWgybHZIZ29hWlBqUWo0aHFl?= =?utf-8?B?VFZtVHlNZDF2K3dYZDNUM3JqV3VQZDNHekV0KzIwYS9YZ0pUL2dTcDJra0Mr?= =?utf-8?B?WkRwWEwyQXF0L3FaMTVteE5qVXIzM3NmTE5WeWdHaGxmV1J3MXRLR05PVDFY?= =?utf-8?B?eDNkMndkWnZPMUplY01nK2ZnSnB6dnNXN2RHbVh4NEo5RFN6bk0vRzMreWRw?= =?utf-8?B?K1JxRDNvbzgwMnVhVWdkS1hUcjBzeHFvQU84UTFEaFd3UW9QajlQekIrcmRo?= =?utf-8?B?ZGpCcXh0OGs4a3dKTC83WjMwVmE3RkdyaHpqWVdaVjVsM25RVWoxbG0ramV6?= =?utf-8?B?aGdkNytOYXFwYi9CeWdrMWRJT0pzK3dYWVRpZnIzUXM3OGFDYlVDRUc5NzRL?= =?utf-8?B?N3JBTm9pcytvNmxuNnFNazMxRm5ZVE5XaWZlZ2tZVU9DSVFEVG51a1ZnK21Z?= =?utf-8?B?ZTRkZnVHSHRpWnFvN2p2MWNvUWpVekJXYlFkOUNYNXVLN2VYVXdWS1BBSTV2?= =?utf-8?B?K1VheDhvWkIrYVRsNkF6L3ViekJXUWxTRUE1ZFUvTmlwS3ZaNHVZVkdaNjly?= =?utf-8?B?cjFiNDdHK3lldHZvUndkY3kwWmZ3dVVJRFpXN3hFM1hQMkIrQUR1a01LUm03?= =?utf-8?B?cFBXSk5nckQxRVJkOEI2a09ZM0hiUGpEdHZjUHgvMDRldzRVUHZ2cTdJVFpo?= =?utf-8?B?K2ZMQW10Rlk4SGdWTEN3TXFyQjRISEFYSDN6QVVxUGFYRlFOSkt6U0Vob2oy?= =?utf-8?B?MVlUNUNXMW1vM2ZWK3c4d1ZNazEyTm5Va3JNOHVGc1N5RFBqSzhnZGhJZ0dQ?= =?utf-8?B?SHphYXdFUzNVUUFGOGNuR0ltLzNsdGdONXdhTkhvQ2RSbnZtZko1cXdzYWRv?= =?utf-8?B?VjRrTkhRQzNnZDBpWXNYZ3dmQnpXVkcwQ0tFclk5dmhzU1B6R2hnSCtlT1Nl?= =?utf-8?B?aUVua0U3WkkxSzc3VitlcDFlNGFtTUJJVktMRmNHK2pRZkFnY0J6NDlYQXdF?= =?utf-8?B?bHJKSXNuMCswVEdjby9aK21Pdzh0MXd3b0VBRURkSW42Ly8zTnBLcEJqYlkw?= =?utf-8?B?RERZb0JBSC9MK2krK2x0NnVlWU1TWEU2dmhNbElGNFRsOW1nUVd6WU1YYldF?= =?utf-8?B?VlBoUWY0QStxQkhkU1JaV1lYQ0VkbzQ2TVVnTHBIRFBMZ2QyNnI2c2dabVBx?= =?utf-8?B?SGxJMUFEZkpxZVFRaE1IUUJ3Znh3NmpwTk9mOTB1ZUZHdzlVNDU3UFArNE8w?= =?utf-8?B?Y1ZNK0FxdEF2K1ZoQ2pPaUNKbDZzMEtDMUNORmNFemVTb0s0RDdaS2dGM0JI?= =?utf-8?B?ZTRScE5kY0NUU1JTRUxkNG9EcUVYaldKZHEzVlF5YklkTlg5ajRQM0JiUlRC?= =?utf-8?B?bjF6SUlSWEoxeVZiQkRKM291L2VUTFp2VXV2RUpJWFM0amN6ZUJJMUpjSWg4?= =?utf-8?B?VlFuMkZXSVUxRXVTSE40OFRTUDdZeEVSZ01YMHN2QnExdHFnWmFweDd1anZF?= =?utf-8?Q?xvRtxdVQvRmmAc2MYFqfDihN/?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c9a02e2-c9bd-40ef-35de-08de185d3c56 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2025 09:09:45.8768 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XlrL2mqeKFMem3wxUf/yZvvaRoYuGqbhxl5GCA7hE4Ci3Se9ea9p7zgJH1XQBxI1hsq/HhbPBr6WgOUgxhe2KA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8093 Introduce imx_dsp_rproc_reset_ctr_{start, stop, detect_mode}() helper functions for i.MX variants using IMX_RPROC_RESET_CONTROLLER to manage remote processors. Allows the removal of the IMX_RPROC_RESET_CONTROLLER switch-case blocks from imx_dsp_rproc_[start,stop,detect_mode](), resulting in cleaner and more maintainable code. No functional changes. Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta Reviewed-by: Frank Li Reviewed-by: Shengjiu Wang --- drivers/remoteproc/imx_dsp_rproc.c | 69 +++++++++++++++++++++-------------= ---- drivers/remoteproc/imx_rproc.h | 2 -- 2 files changed, 38 insertions(+), 33 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 56e94754d5c5feba112227c45b0f99a4fe868926..009e08df8fd42e1bf6ca00393e9= 40071d33ec518 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -347,6 +347,13 @@ static int imx_dsp_rproc_mmio_start(struct rproc *rpro= c) return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_start); } =20 +static int imx_dsp_rproc_reset_ctrl_start(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return reset_control_deassert(priv->run_stall); +} + static int imx_dsp_rproc_scu_api_start(struct rproc *rproc) { struct imx_dsp_rproc *priv =3D rproc->priv; @@ -375,13 +382,7 @@ static int imx_dsp_rproc_start(struct rproc *rproc) goto start_ret; } =20 - switch (dcfg->method) { - case IMX_RPROC_RESET_CONTROLLER: - ret =3D reset_control_deassert(priv->run_stall); - break; - default: - return -EOPNOTSUPP; - } + return -EOPNOTSUPP; =20 start_ret: if (ret) @@ -401,6 +402,13 @@ static int imx_dsp_rproc_mmio_stop(struct rproc *rproc) return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_stop); } =20 +static int imx_dsp_rproc_reset_ctrl_stop(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return reset_control_assert(priv->run_stall); +} + static int imx_dsp_rproc_scu_api_stop(struct rproc *rproc) { struct imx_dsp_rproc *priv =3D rproc->priv; @@ -430,13 +438,7 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) goto stop_ret; } =20 - switch (dcfg->method) { - case IMX_RPROC_RESET_CONTROLLER: - ret =3D reset_control_assert(priv->run_stall); - break; - default: - return -EOPNOTSUPP; - } + return -EOPNOTSUPP; =20 stop_ret: if (ret) @@ -1059,6 +1061,20 @@ static int imx_dsp_rproc_mmio_detect_mode(struct rpr= oc *rproc) return 0; } =20 +static int imx_dsp_rproc_reset_ctrl_detect_mode(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + struct device *dev =3D rproc->dev.parent; + + priv->run_stall =3D devm_reset_control_get_exclusive(dev, "runstall"); + if (IS_ERR(priv->run_stall)) { + dev_err(dev, "Failed to get DSP runstall reset control\n"); + return PTR_ERR(priv->run_stall); + } + + return 0; +} + static int imx_dsp_rproc_scu_api_detect_mode(struct rproc *rproc) { struct imx_dsp_rproc *priv =3D rproc->priv; @@ -1082,26 +1098,11 @@ static int imx_dsp_rproc_detect_mode(struct imx_dsp= _rproc *priv) { const struct imx_dsp_rproc_dcfg *dsp_dcfg =3D priv->dsp_dcfg; const struct imx_rproc_dcfg *dcfg =3D dsp_dcfg->dcfg; - struct device *dev =3D priv->rproc->dev.parent; - int ret =3D 0; =20 if (dcfg->ops && dcfg->ops->detect_mode) return dcfg->ops->detect_mode(priv->rproc); =20 - switch (dsp_dcfg->dcfg->method) { - case IMX_RPROC_RESET_CONTROLLER: - priv->run_stall =3D devm_reset_control_get_exclusive(dev, "runstall"); - if (IS_ERR(priv->run_stall)) { - dev_err(dev, "Failed to get DSP runstall reset control\n"); - return PTR_ERR(priv->run_stall); - } - break; - default: - ret =3D -EOPNOTSUPP; - break; - } - - return ret; + return -EOPNOTSUPP; } =20 static const char *imx_dsp_clks_names[DSP_RPROC_CLK_MAX] =3D { @@ -1326,6 +1327,12 @@ static const struct imx_rproc_plat_ops imx_dsp_rproc= _ops_mmio =3D { .detect_mode =3D imx_dsp_rproc_mmio_detect_mode, }; =20 +static const struct imx_rproc_plat_ops imx_dsp_rproc_ops_reset_ctrl =3D { + .start =3D imx_dsp_rproc_reset_ctrl_start, + .stop =3D imx_dsp_rproc_reset_ctrl_stop, + .detect_mode =3D imx_dsp_rproc_reset_ctrl_detect_mode, +}; + static const struct imx_rproc_plat_ops imx_dsp_rproc_ops_scu_api =3D { .start =3D imx_dsp_rproc_scu_api_start, .stop =3D imx_dsp_rproc_scu_api_stop, @@ -1336,7 +1343,7 @@ static const struct imx_rproc_plat_ops imx_dsp_rproc_= ops_scu_api =3D { static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { .att =3D imx_dsp_rproc_att_imx8mp, .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8mp), - .method =3D IMX_RPROC_RESET_CONTROLLER, + .ops =3D &imx_dsp_rproc_ops_reset_ctrl, }; =20 static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8mp =3D { diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h index a6b4625e8be76c6eb6a5d8ef45eb5f3aec5fe375..6a7359f05178a937d02b027fe41= 66319068bd65c 100644 --- a/drivers/remoteproc/imx_rproc.h +++ b/drivers/remoteproc/imx_rproc.h @@ -20,8 +20,6 @@ enum imx_rproc_method { IMX_RPROC_NONE, /* Through ARM SMCCC */ IMX_RPROC_SMC, - /* Through Reset Controller API */ - IMX_RPROC_RESET_CONTROLLER, }; =20 /* dcfg flags */ --=20 2.37.1 From nobody Mon Feb 9 09:54:47 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010036.outbound.protection.outlook.com [52.101.84.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77C8A32ED37; Fri, 31 Oct 2025 09:09:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.36 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901795; cv=fail; b=OK306EutxzW8K4Y1ouXJOVmM1oA8BLH1c1iFK/jRzna+yETzU9bT0k54jqpzcNtseOOSIq58MPmStJ0ofelyemVeYr/oBgoDSE1ak+IK/7CZ8DcnukSsLgesuC0GrctEBhSmk851OZkOiRAnNQUVTlh+2uTyjagHQzy65HXzIjs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901795; c=relaxed/simple; bh=tMWvhvweWATfEdw9pDPpp7wadcOT7LgCnVS1SEBgiEw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=TIpYYSk4pT6RYu4zLmFcAlcp/1DAmQjstfm2OArzaO3DBjlOrXVYgNPaTls4gbYHVEMSnW6XFy1DoWBYynoohlqYez+31ecAetqyEJsVFhzElNxq6h4zdesBB6CKoKSAA+kj+s+ccuT9asNzvbOP3kh9QviNu9X4ylFqaktzdpQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=GK27HjEq; arc=fail smtp.client-ip=52.101.84.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="GK27HjEq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PhsDMf3T7co9FQQbrP0OXeYQYJZZZ3H/4LuvvE63u96z6p2RjhBHWqD68RsELp2dJAUFbi7LDsdE8N7utX8tHYE740I0sSHyMUITBQf+98DUkprq4wcPxfagSewsxxkdnjYule2Ab+W/uuOzR0L3fMsptpuyeKnuD1Qe5tOCKmGN45h65snK1lsxjcCvUI/auEvJsuJBiaJQLAgl2fWO0/dg92K7f/V3jHGWyw5mBM/FP7b/yDeLzM3693QRxdzDhQVqQ9iDJ+dixw83RcocibxeamfaGG/VKMyPL55ocAw13fVCugmbAbwS5bWUDiyuz6erXXWLhUQbA7VnvLR39A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GwcGBx4ZFWyd6XYjlrNGGWD6diTLLMtT0sm+zgz08AE=; b=t9Tq6/5fM9/NVzN85DxLBkOXVyt+VSDBOeBu+CWqdxc5fYxJ0moGxM5kOmqHsVdcc/rgSnq7vYRRD4zxG9ZtiEKQJz5dgbzMFnUwT+smV+omLGBYkLs5lGnQYqJNuINtBYd2Ylwe1BAqDuqWnzWtQdQ2RIZ7aktMAYFOUzjfeRWz8RgD7OmQOifV8ZDeCZrLRAGb9EGq3oLZOW7Jc/P7mFzABaiGCK/GcGH58bGMmArBubWSbPTYm/z+gUYSGGcz8b3hPd3F/TQeMF+gIicXvOJTMRXq22/l7o9KFMSPH1dtFrsBDZmXDS64BCQVEUKGfCsQljx6sXBHodbmmsCjAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GwcGBx4ZFWyd6XYjlrNGGWD6diTLLMtT0sm+zgz08AE=; b=GK27HjEqgOyPU9AnfO7omr7CqnaqunrmFljrIgVZIQUXDezI7Ri7Y02pbfJXN8OKAlvqLC1x6XBiEAxogMczAmzS2rC6Ug0xvQu2m8SF4iImbUCl8cKDe5ApaM2iwN6pX0aWeEUWGEqPBAopLQejFd93Ee5Ejo4AiYnkIbDyHq8y6wVqWaCAOGZiPTc0mDdzNpitSKB9aTFbKJs+L37j+lrm3D7MIXCTlQCTreH2+OGrMoNJNv5sqvkdGRVdlZmpn2Ch4zLdyeAu0CzcJOoU+Lcs3WQTvREDuQTncnutkQ19bPCfahXKl+agQmiGbq/PcniLgnSmk4RjQWfh7KRVzA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8093.eurprd04.prod.outlook.com (2603:10a6:102:1c9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Fri, 31 Oct 2025 09:09:51 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9275.013; Fri, 31 Oct 2025 09:09:51 +0000 From: Peng Fan Date: Fri, 31 Oct 2025 17:08:40 +0800 Subject: [PATCH 11/11] remoteproc: imx_rproc: Remove enum imx_rproc_method Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251031-imx-dsp-2025-10-31-v1-11-282f66f55804@nxp.com> References: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> In-Reply-To: <20251031-imx-dsp-2025-10-31-v1-0-282f66f55804@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Shengjiu Wang , Frank Li , Daniel Baluta , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1761901729; l=1006; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=tMWvhvweWATfEdw9pDPpp7wadcOT7LgCnVS1SEBgiEw=; b=KdXkbBzjL3los8XHF12IKuxRBNwZf6X6auUKwjoqCjcG2zO0hbddV5A9v5OU+FLcND0s0MY7J BiVTh5nd7mDBSSxcLtyNJXnoTfknpLILrqD7cl7+t2eu3sI746ervMR X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0010.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8093:EE_ X-MS-Office365-Filtering-Correlation-Id: 30ffa2df-fb41-4e23-0b67-08de185d3f1b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|19092799006|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?T0lTdXduZVpRZUpQYkd2QWo2QlF3NVZlUGkwNGY1ZENGMGZsZ21oU0lRYy91?= =?utf-8?B?MVFoNjBsMWZaVmlKRTVFTVFTZWtab2VEY1VHUkVrbkNlZEJySHB3TXZTWjJs?= =?utf-8?B?Z1ZGVWNVZHZEVDhUOHh1R0NpZXRjUGtZVXYxUXAwNitFMysxZHlCcmxmVFF6?= =?utf-8?B?enJnQU05OGVmOW5kSTFPOWZyNlZvWGRGd2lzd1VUNTlwNExvYnZhWTZJcFkr?= =?utf-8?B?VlZHVDM5VVAramp3Qit4YVRKdnNDYVBuUnZraU1pQ2IvZGpmYjBYd2wzaFgv?= =?utf-8?B?Qk1CdGRGOFVkZVJWMHJVdFplQW9Nd2NWUEt3SnkyZjgwREQvdXRqYUcvd1pN?= =?utf-8?B?dHd3eGxhbjcrZGxLcUw3ajJ4NFZtL3hMRFhoQUlhejBzQ25zdVBRYjVsZEh1?= =?utf-8?B?SDFtdTk3ZGI3VEFCMXBKdzdQRkhwS1N2R1dRSUt1K1ZsOXpjNkFqeUNVZEho?= =?utf-8?B?Smg2VlNERWVMMm5RYUcrNDlSNHhYMTBTRmg5WEQzWWJNM0Y2S0lrQjVaUHdN?= =?utf-8?B?bEhMMUlDOUFzblRwU3lBNm1ETCtWMkdqWlh5Z29BOStxaldUUGo1MWwyK2tH?= =?utf-8?B?ME1yM2N5OUhiYU1CKzlzcDBQTXlKT0ZWZWQ2b0lBd0RwNjl4Z2RwdWJrMTFq?= =?utf-8?B?b2pZS0xzWUExR1ZmTXlselM1SkR0OW9xSWxXMjUvZGhDZVNYVzd4eVp0NFR4?= =?utf-8?B?cThWVDVGNUQ5NVdwVmYzYyt5N2kycllSUVNxejliV3FNUkNldW94WlNSTzE5?= =?utf-8?B?NklWN2oyWmtRclgrRUdvQ3I5TGxqVjJNVnV0ZVBERG9qb2lGK1JTaDBGSUJF?= =?utf-8?B?TFlicm4wangwbUhJTFdvcldRR3NwUzdBSWV5Wjcra05MY3hEVk9lRUpDbzE3?= =?utf-8?B?MFczdWE2MWMyMWJGYTlDZmNzSk9LWDZKdzAzQ1ZVUWlPRExOeVl5Y2lpa0hP?= =?utf-8?B?S0VuaVI2bHNtRDlUdlpUdFQ4UjByZ3M1RjdEdy9zcjE3Vkh0Q2d4dk93V253?= =?utf-8?B?c29hQ3c2a1JESS9PRFRzeU5DZEtzZjcxMFlEbHFxZDd3VzF4VEJCR2FEWE94?= =?utf-8?B?RElkME5mbVpwdExDWnE4VmR6dlJpelR6cE15RWRyaGViVGFWZ1R3dGxHeG9h?= =?utf-8?B?R0c5L2xVa1Ard0tETEhaNnkvWE1VQnZpNUZablZ2U0tJTXFuQS9ZVnpEcm93?= =?utf-8?B?My9pL2ZDT0lwT04wMWdzbGQ1bDFiVXhmb3Z3ejVjV0hZY1hnd3ZnNi9pU3Js?= =?utf-8?B?bUlsdlRKaDhIUmtTSFh5UGx2OXlnUEpzcDgxdXNvck44bXZwbDUxNXJxd0la?= =?utf-8?B?ajJrb2Z5djBna1d0ZXJzSEpURFdqS25lSWU0ZnNXWUpSaTYwZm9vQnQySXpI?= =?utf-8?B?NTBqMHp1Q1lZbllubmtyT3BTNWw5SnBTMjYxL3crVkEyM0JPYm9mWE15Sjgw?= =?utf-8?B?Q2VGRWhYYTYzS1JVM08vREhvQnFyTCs2NGNSMWVkekdrbTVqQVZGUGI5NGEx?= =?utf-8?B?KzRMdG5OWDNjVGQ4bXlxdys3Nzh5N1QyWVlUV1gxd3plamRPY1BGemM1QzBK?= =?utf-8?B?b1NWd1laZ2lQWklsYnoycEdVSCs5eERtc3VRUmdnNUszUm1QdUh6eDNPTWJW?= =?utf-8?B?UmN0V0w1dERpUDBwMTFHWnlpSzBoRHlQd0V4RWNRbEJOZWszTHBNYm53Vk5m?= =?utf-8?B?NExOcUxrSWlBeUY4VjZRWWk2cURjc0p3MHpPLy9aRlNTTHFtdHR2SUZIRCs5?= =?utf-8?B?OThlOFJNQmVLOHo3ZStqOFZmSHFUUnRIWXdLZytiRjZod3ZLNmI0RHJrTTFr?= =?utf-8?B?VE5mOHpNaWV5aWdnTitoRmY4OW0walRnenM0dlc4T3dHVkRFVGFXZnRlTGRJ?= =?utf-8?B?bDExa3dDMWYycDBkUjluN0xoRVBNTlB4clIxMWkrdmJjNTdFMHY2Z2RqVnE3?= =?utf-8?B?VDB5SDhZVkh2RC81NnJrSFdSTnBzaGlGbW1oU0hZdkJHU3ZiV0M0ZytDWEdy?= =?utf-8?B?L0cvWjhDbkNPZnd0YjhiY1R1VjIvbEowTkxLa05rOUZSejlYSXlLeVduenk3?= =?utf-8?B?K2w1ajRvZGFRay9tTGhLZXVpK0VWZTNPU1d4Zz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(19092799006)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGd3UWMvTllnNFdkTzJadzhqL0JFTDZ4S3VDYlozNHRBVDJhWEtBMmhjeVo3?= =?utf-8?B?VTFZZVhHQTdhT09BNVk5OG53Ly9ycjZHOUZQYUtybys4YVBhT0p3MEJjVXFP?= =?utf-8?B?Y1VJZDVWK05LUGN0T0JHRTNia05mVXR0ZUJZOENOa09FWFUyL0NEeFRDZjI4?= =?utf-8?B?SkpQbnlzZGxlUmhSZXdZWWoxUnNrcyt0d2s2bTBwOFZSY1poNmZ1OWpIWWdC?= =?utf-8?B?d0I4K25TeDF3R3o3Sm1WbkpvUW5PNzhXMXh0b1VJS0VIVVZHckMvRGhuMElR?= =?utf-8?B?WTMvNUhtYmxEY1FCbm1QSlh3TDBEcUlsU2Zzc2VaKzZneGFveU5VRmpEZFFw?= =?utf-8?B?MG9tVlcxbkJlZ3VrUWxXeXNnWjdVYjJpV1kwZktXeVdUN2N4SlRtZmI1TjVK?= =?utf-8?B?R2M3djhFby90RGZsTW0zOVRHTWtrN1pLN1QyVmhDUWlDZW52U2Voam1OMVR3?= =?utf-8?B?Y01Qci9MY3hPNGp5alpEenhULzhYT2xpc2pXakZUUDU5SkhQZkhKT1RWSDNv?= =?utf-8?B?Y1RTWkY5RzRnMlllM1BjVStGaDh3d3N4bTNuc05lYTVFMm9hTDl1dzJhMVND?= =?utf-8?B?T2pBTllzRVY0YjFIUTgrQkppQmMyZ2xmb1ROby9IWVRKNWJRK08rT0FLQnFH?= =?utf-8?B?UTE2bE5pM05aanNsS2tYakNIZzFkb2JvRGhnUW56RVY4WDRGK0NhWGoraFhJ?= =?utf-8?B?NENiZytvc1RnWW9FS0xhRExtMjBEZ1FuemVzLzlwaDEzYVJGTlEya3hEbzAx?= =?utf-8?B?a1MwQ2hpdGpLd0hOclBlOWJMZHM0N1Q2cWc5dElHa3pMamE5alYybnVwLytt?= =?utf-8?B?eTJjeHdzWWNkZEFqekdUVGoxYitsZjE1RU96dnZPZlVEMTB4UGFiMlpqMFd3?= =?utf-8?B?K3B5aU5ZZ2dSTDBmUXREb2tzVndsVkRaNlAwb0NQNmlva082azFGTzlEU2xa?= =?utf-8?B?UldnaGZodXhtUDhCdU5PTnV0Wnh4MXo4UlNhd3ZkczlCVWs0eDRzdHEzblVR?= =?utf-8?B?Wm5tNG1BVk0xRUdzZk5WM2hLS2k2QUdKL1puVldIK0N3Sk9KYzcrTCsxRDVF?= =?utf-8?B?eUt2aUU2MWwwOGhZUnZXZ3lYUkd6RXUrRDhZaUx0blJJellPRWVWelRUYW5y?= =?utf-8?B?ekNRVzZNcUZwbFdkYURWS3pXTXVob3c4K3ZGQ2hLT2ZjN2xrVStCL2Q0WDM4?= =?utf-8?B?QjFMY2R2SFQydjdYbG9rVncyRXFSSDRhbEYvdFY4UmNId1hsdzhnL3dkZjlj?= =?utf-8?B?U25aUjdPUE1BbTlITU9Bdk1INk9xL3JRMUhKdU9NTjN2OFEwWG51Y3VuRk83?= =?utf-8?B?b1ZuQVhQS3pWSHJpUWJpL2E2TzZxZU9VU3craW1LbVBLMHRtbHM5YnZHOEEy?= =?utf-8?B?UzFFMGNYVmVuVHFnTWNySXM4QmRCelNpUUFVUmZaaTJ4SEZNdGhkdXFaTXFD?= =?utf-8?B?Z04xT1haeCtBa0xCTU5VWVc4MVBEMmpXVEZWOG5rZmNRMFNPWHdsSUFUWmpR?= =?utf-8?B?RE1NUDVDNzdMS3gzOW5ZT0htcjgyRm15aVBzTWR1OVhhQjlZOUdTVXl4QUxp?= =?utf-8?B?ODExVWRkNmN6c0RvUVBqbkxEVDhPeUo4SjJocy9YaHMvM0psWHlicVNOUFEz?= =?utf-8?B?b1R6ZUhaWlJiVUh5NmlIMWZ5d2t6ci9LUThZNjJzMXVIVFZRQWFMWGpDV2l1?= =?utf-8?B?TG9SdWtTbXBGZ0RQNDdHUmJGa05VN1lOdDBYVS9URkZhQmNIM05nNHZ2OUNV?= =?utf-8?B?RFpxc1hMTHdiRXhTOWpwL3hURUFtSUNJNE1BSmhET0h2MUkxZjJaOGd0ZFFs?= =?utf-8?B?bC8yUVAzeWI3RUpCdDVSL1JDcXBLWHRsN21FMWJxVHYxT3BpQUcrTG1zMFlu?= =?utf-8?B?Vm1YMWRQSUxlZTVDUlNGck9oNXkwaXM5KzhYckhBb2JBRlFzODdVeVczT1Vs?= =?utf-8?B?ZUJTWnRIMTBmWWhVOGVzcWpUUXRXZEF0Z01CT1ZLNjFXVFloamZqMUJmL3g3?= =?utf-8?B?U0U1MTR2UHloTmlSTlFuY0RqTytqUmpETWZDdW91YVBOMHVQaUs3ZkthM0hz?= =?utf-8?B?NTRKbklCNnZWV1pjOGpFTnVUdVRIS0xuZEVNL3BzWWdKVnh3U0llU3lDcWs3?= =?utf-8?Q?tLOXJPx2uKO0MY5eR8C2p3DV/?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30ffa2df-fb41-4e23-0b67-08de185d3f1b X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2025 09:09:50.8298 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FV2oA3hypskXXWOILSbRvhLqz3cuJx4Fpmr/dtjofb/QaizwZmkXZ1aeR+fOcoXnhj3V3JzEfXN0iJ2eLhUTSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8093 There is no user of enum imx_rproc_method after moved to ops based method. Remove it. Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta Reviewed-by: Frank Li Reviewed-by: Shengjiu Wang --- drivers/remoteproc/imx_rproc.h | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h index 6a7359f05178a937d02b027fe4166319068bd65c..1b2d9f4d6d19dcdc215be97f7e2= ab3488281916a 100644 --- a/drivers/remoteproc/imx_rproc.h +++ b/drivers/remoteproc/imx_rproc.h @@ -15,13 +15,6 @@ struct imx_rproc_att { int flags; }; =20 -/* Remote core start/stop method */ -enum imx_rproc_method { - IMX_RPROC_NONE, - /* Through ARM SMCCC */ - IMX_RPROC_SMC, -}; - /* dcfg flags */ #define IMX_RPROC_NEED_SYSTEM_OFF BIT(0) #define IMX_RPROC_NEED_CLKS BIT(1) @@ -42,7 +35,6 @@ struct imx_rproc_dcfg { u32 gpr_wait; const struct imx_rproc_att *att; size_t att_size; - enum imx_rproc_method method; u32 flags; const struct imx_rproc_plat_ops *ops; }; --=20 2.37.1