From nobody Tue Feb 10 05:44:46 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C7D633BBC9 for ; Thu, 30 Oct 2025 23:04:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761865476; cv=none; b=SyXwQwhIxWin4fxK+d8JWSL5DtxKBE2ZLmHrR1b0iYl2Kni6V1ukwLv/Y8v3bJejWkQbiVS8DKdB2CwVGY9BEXxF2RoPdtdyKqDSKYcpeORCOdi/66U7MqxGwcTrFPVAlyaHKLUdO6f+/2E/k3yysLC/N3h7jbWfvw0Ln5wmUbg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761865476; c=relaxed/simple; bh=6nn2VeqdLzRcwL7AKTuuXeR8rESQolA47ksnBgHsmQw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s14ClKClJQMgS5nz6Cx9XhCZccTN5/WQKQBP179tx/wUEggCooreEh6fabN9SIj2dUVuT7is4/gL7M74HEDanq2Fs7dBHtiNUhpdTeKBw4s/AJLrkWghCbdWBJYaec5iIzMARMU+EKgLFvkYO5jMoHNrPaK5GmNeMkG10DIA8h4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gWWzE2j6; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gWWzE2j6" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4711b95226dso20562975e9.0 for ; Thu, 30 Oct 2025 16:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761865472; x=1762470272; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ultisk0LTvrj8uqMnV5HKpTwdWn+r1ljzwjarHhGTc0=; b=gWWzE2j6TnYkxwahZzLhSDTPIfhieXwwCNQZ93lAfp56pZ95KcPn/X3F6m7wd4gEw9 WBNzcVf/0jec2DWHuYhSc/2nudagdFg3rwSOf/4Nq84PED5TfxKMWVx8PqmlHzRwiJso om4LjyAEcb0Z+9JZLD1XHZx8dInMBHqGP1H6+lGIYIJj7pNkcoby30yZfX1wRm60XX74 SV2fpSXyM5Xiz9tWyU+wqLF+DGwSWnppRgdUhSKEEh31XOdEzn1xl6wiGcS/HAxB5Obj JZNeWrhxvrcuhryhUn2LczyRSukznAZSa+Krzv0YxsxKZZ0Z0+LSXZePbdaKeW6U9mb7 faTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761865472; x=1762470272; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ultisk0LTvrj8uqMnV5HKpTwdWn+r1ljzwjarHhGTc0=; b=lE31Jz42ucJv36fcWDpzVCJ3KCL2LRq9GdShsv9Se/zjXW4tT93tpV7F17dYn5W/LE O0N/om2r5tWbbKk+F5u05mXGdzx6stmc/sYvgiwp6RfJ6tA8YgwsE9dZ1SWipHNdgVBe y4i/Q0gKfmdsfqtkH0QIwAXY6gJGvBy30NswYkd3QtMAOiZrhpzx/AtBRNFrAQq0lBKw 9fD8A88/g7luxIzqTNtPiexqjL+89TOVLjNVjYbbp2+2tGwk853jWUbfdZ4diqkl1qLp n6A8yZRrhBSaH0bYjX9SC1xwYuDBVlxtR5GDn8owL+Je1yhJyb/YZPyW9U7J53h634oH pV7Q== X-Gm-Message-State: AOJu0YzmGQ2iKFuOAW4G7eROYevFIVh4UilBU3hGRPBh/g/JLxwTfdPc xB67Tl8RM1JzWB9BPQW7wahAlbe9jn2obY1Elo/k8pimnHbsoOwp9G2pFcrg1NtZ X-Gm-Gg: ASbGncvHPaPhfGXZ6Ykh8pWWT6CRUZ7PRO2WeifW8vqPCOVvBQJ3gRU1lhm0R63V14u KSlGjbu4rc9Ja5wNLJkzJ9xpfs0kMkd3K8/yw9C4PefpMe92NyCBE9VnXlS+bMFvOOKRqSA/VCD jAVTy7hnn8VpubREdfrrdbN9vLQ3Mabe0mmN+NnLphmg5jDkxUwEHwjn1TIVtl7TO81rVplBqEq UC+7ZFVv+WbDwjOhBINn3aKo5l/GLshlYWA7/WMPjoq8nvTxAN/LW378j5Po9vUvJ3bSM7CaERp yULWhnhMN8Rar7zSipSJJTF4y3BP+PRdysSk/gf0UV2bGk/9z5xRFHnaPfvNZZP/PBWVyc/qZHG fo6zSH7VZhsuTFQ7bVnEZwLeDo6kYLnYzCM0X1gfj+uSO97fFROrzx7M37kzFpi1vNpTpJ9Z3T8 SUPJClKjatI6jFlimeI1BKcrhTQci8f1Lk X-Google-Smtp-Source: AGHT+IFlWust8iq3x6eNp1+tkDyEzKkeBYIiGz+XhjWpGCSMYnkzi9Rvv4VNhEjjagfH257BWjyiZA== X-Received: by 2002:a05:600c:83c8:b0:477:1ae1:fa5d with SMTP id 5b1f17b1804b1-4773087b0d0mr10710235e9.20.1761865471717; Thu, 30 Oct 2025 16:04:31 -0700 (PDT) Received: from fedora ([154.182.161.198]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47732ff8235sm2227025e9.14.2025.10.30.16.04.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Oct 2025 16:04:29 -0700 (PDT) From: Mohamed Ahmed To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Mary Guillemard , Faith Ekstrand , Lyude Paul , Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , nouveau@lists.freedesktop.org, Ben Skeggs , Mohamed Ahmed Subject: [PATCH v3 3/5] drm/nouveau/mmu/gp100: Remove unused/broken support for compression Date: Fri, 31 Oct 2025 01:03:55 +0200 Message-ID: <20251030230357.45070-4-mohamedahmedegypt2001@gmail.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251030230357.45070-1-mohamedahmedegypt2001@gmail.com> References: <20251030230357.45070-1-mohamedahmedegypt2001@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ben Skeggs From GP100 onwards it's not possible to initialise comptag RAM without PMU firmware, which nouveau has no support for. As such, this code is essentially a no-op and will always revert to the equivalent non-compressed kind due to comptag allocation failure. It's also broken for the needs of VM_BIND/Vulkan. Remove the code entirely to make way for supporting compression on GPUs that support GSM-RM. Signed-off-by: Ben Skeggs Signed-off-by: Mohamed Ahmed Reviewed-by: Lyude Paul --- .../drm/nouveau/nvkm/subdev/mmu/vmmgp100.c | 39 ++----------------- .../drm/nouveau/nvkm/subdev/mmu/vmmgp10b.c | 4 +- 2 files changed, 6 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c b/drivers/g= pu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c index 851fd847a2a9..ecff1096a1bb 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c @@ -21,9 +21,7 @@ */ #include "vmm.h" =20 -#include #include -#include #include #include =20 @@ -117,8 +115,6 @@ gp100_vmm_pgt_pte(struct nvkm_vmm *vmm, struct nvkm_mmu= _pt *pt, { u64 data =3D (addr >> 4) | map->type; =20 - map->type +=3D ptes * map->ctag; - while (ptes--) { VMM_WO064(pt, vmm, ptei++ * 8, data); data +=3D map->next; @@ -142,7 +138,6 @@ gp100_vmm_pgt_dma(struct nvkm_vmm *vmm, struct nvkm_mmu= _pt *pt, while (ptes--) { const u64 data =3D (*map->dma++ >> 4) | map->type; VMM_WO064(pt, vmm, ptei++ * 8, data); - map->type +=3D map->ctag; } nvkm_done(pt->memory); return; @@ -200,8 +195,6 @@ gp100_vmm_pd0_pte(struct nvkm_vmm *vmm, struct nvkm_mmu= _pt *pt, { u64 data =3D (addr >> 4) | map->type; =20 - map->type +=3D ptes * map->ctag; - while (ptes--) { VMM_WO128(pt, vmm, ptei++ * 0x10, data, 0ULL); data +=3D map->next; @@ -411,8 +404,6 @@ gp100_vmm_valid(struct nvkm_vmm *vmm, void *argv, u32 a= rgc, struct gp100_vmm_map_vn vn; struct gp100_vmm_map_v0 v0; } *args =3D argv; - struct nvkm_device *device =3D vmm->mmu->subdev.device; - struct nvkm_memory *memory =3D map->memory; u8 kind, kind_inv, priv, ro, vol; int kindn, aper, ret =3D -ENOSYS; const u8 *kindm; @@ -450,30 +441,8 @@ gp100_vmm_valid(struct nvkm_vmm *vmm, void *argv, u32 = argc, } =20 if (kindm[kind] !=3D kind) { - u64 tags =3D nvkm_memory_size(memory) >> 16; - if (aper !=3D 0 || !(page->type & NVKM_VMM_PAGE_COMP)) { - VMM_DEBUG(vmm, "comp %d %02x", aper, page->type); - return -EINVAL; - } - - if (!map->no_comp) { - ret =3D nvkm_memory_tags_get(memory, device, tags, - nvkm_ltc_tags_clear, - &map->tags); - if (ret) { - VMM_DEBUG(vmm, "comp %d", ret); - return ret; - } - } - - if (!map->no_comp && map->tags->mn) { - tags =3D map->tags->mn->offset + (map->offset >> 16); - map->ctag |=3D ((1ULL << page->shift) >> 16) << 36; - map->type |=3D tags << 36; - map->next |=3D map->ctag; - } else { - kind =3D kindm[kind]; - } + /* Revert to non-compressed kind. */ + kind =3D kindm[kind]; } =20 map->type |=3D BIT(0); @@ -592,8 +561,8 @@ gp100_vmm =3D { { 47, &gp100_vmm_desc_16[4], NVKM_VMM_PAGE_Sxxx }, { 38, &gp100_vmm_desc_16[3], NVKM_VMM_PAGE_Sxxx }, { 29, &gp100_vmm_desc_16[2], NVKM_VMM_PAGE_Sxxx }, - { 21, &gp100_vmm_desc_16[1], NVKM_VMM_PAGE_SVxC }, - { 16, &gp100_vmm_desc_16[0], NVKM_VMM_PAGE_SVxC }, + { 21, &gp100_vmm_desc_16[1], NVKM_VMM_PAGE_SVxx }, + { 16, &gp100_vmm_desc_16[0], NVKM_VMM_PAGE_SVxx }, { 12, &gp100_vmm_desc_12[0], NVKM_VMM_PAGE_SVHx }, {} } diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp10b.c b/drivers/g= pu/drm/nouveau/nvkm/subdev/mmu/vmmgp10b.c index e081239afe58..5791d134962b 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp10b.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp10b.c @@ -34,8 +34,8 @@ gp10b_vmm =3D { { 47, &gp100_vmm_desc_16[4], NVKM_VMM_PAGE_Sxxx }, { 38, &gp100_vmm_desc_16[3], NVKM_VMM_PAGE_Sxxx }, { 29, &gp100_vmm_desc_16[2], NVKM_VMM_PAGE_Sxxx }, - { 21, &gp100_vmm_desc_16[1], NVKM_VMM_PAGE_SxHC }, - { 16, &gp100_vmm_desc_16[0], NVKM_VMM_PAGE_SxHC }, + { 21, &gp100_vmm_desc_16[1], NVKM_VMM_PAGE_SxHx }, + { 16, &gp100_vmm_desc_16[0], NVKM_VMM_PAGE_SxHx }, { 12, &gp100_vmm_desc_12[0], NVKM_VMM_PAGE_SxHx }, {} } --=20 2.51.1