From nobody Sun Feb 8 09:32:15 2026 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06E8A3655FB for ; Thu, 30 Oct 2025 16:10:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761840626; cv=none; b=ECqi5I6//g+tpk1SWTH+ygDZe0h9QGSyRI/ZAU29oLqhaDmk2qmIRb2RVOJX0vi3jdiZZigEHKyuxdQR8EwNV0DOom6ATIaFTp51a/h9v6RczqbOhgkQop9a9g+BzBnUxKSa3YQclkbDiFMZ6SKd/quxr6BEHT/kkQUgpvQsrfA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761840626; c=relaxed/simple; bh=2CRHRjYIG8N3UT6Uqg+4yPTH2iUR9Mqyj2TfzEyLThw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ng4etJOXtAM8XM6heFoaZErMJwErrnbizmSx/JRnhrggU5gKUcsnYcQgee0aeHXUCRZ6Tn4l10/MOX3HP4w69P4ZKSI0ixV0S0/XvxZK53+0ZXDg4zw7T0sVZy/i16ffFgkzJLYw3ELID/h+aMrLcHoTG8Jn4FgJ/xNap/M6gw0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Bgft3vQq; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Bgft3vQq" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-421851bcb25so742771f8f.2 for ; Thu, 30 Oct 2025 09:10:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1761840622; x=1762445422; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zTPZsf+rmUI4vnLNPtXQcosAXrq3VoTes6fLwzo6HcE=; b=Bgft3vQqT/VssFbJHKY5bmj/kj6LG1fLkLBS3L/rITBl/Kjkq1EUP9Y++1T2m7jmCj X/jzVUfB7qjYyZr1JznYHsm79Fo/qRxmfoYHZeGDjAwxmvPWdSHzJhijRd1ZfWLWpkGW nX9NcHlD7ZerzV7kVnugEGKFmRrLoYjit8TPHnWZdlR3frzYZ83NHZC6F3puotyyzu1o jxpcrAq8k+CuUrhMq0Hc5OGL7n2d/EDu/7YSAs6J4wu/Cyg2ll10zWcupa+Q3KFJeb8d kOLJ1ihPBY9nqNLrAi+7O+wlXPLz2lmLeULYpFBfDY/Mc1mU62Q2OGFSbsImVUW25vYj oq8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761840622; x=1762445422; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zTPZsf+rmUI4vnLNPtXQcosAXrq3VoTes6fLwzo6HcE=; b=cChQG87q5vXGj637LOE6zjKexBXqdDLIp6G0xwg6M1qhAKXTZ6doDhBd5dHFLDJLXi N6V7wO5qbY1Ax31PKpMChZngW4flmhBW5Zi2XRQ7a3BOJUO5M4mfS80Pfv5EUGPCEwr4 ClSMkwU4aLffUWGcHdZcXOcCurUdl0WBsfG+/bIQR7yZtGROJ+CLz05VVZ4gvMU7FsWp 67XoG0RQwV6Q2SdA8kiDgxO23lP67C3HE+qlzAp4WLl8vILAJ5CwD8Oiyvg64Wo5PG7L LKbmCXXbp/e06vAWASJKJpQoUFPoTbmJ9m2bHyj5lTDG+J7VL7yR3kpA7RGzeAxLorR3 dRTA== X-Gm-Message-State: AOJu0YxAQhIETdPJ0MuRG1SN0nmxtpYxqAdoufKGFRIpXmHFclQLLsfu ONuJTtj+W65DEDVKtM0qj3uyzXiCT1M+XebBWlvUzkD1QCAjpydByQw3sMyzC+jH5nFW278HgjF ec3c8 X-Gm-Gg: ASbGncsEeXVCkPFE9Uhe3nYQQ1VgLxN3Qz8bendStxNzb159qjuWE7IViinChyV0CLY GSnyg3NXsGZ9gSeWNoYkOMFKhU5BkkTaF7whPuRxx9lD9Z+TD09/+L69jw6XuNXCk/qJVfCt1j8 ro//gSbl+utXXujsZjKzGl3w5mX5f0VdJhcERCp3Y2sRS8VdUBJFPI3bOWSsf8NNEIoFvQ/d8YH A0LbbDf7rIJbQmFt6tu2a+BfI+r4ObpEra+1UpKZol0xX8oEWXYMUbfuCymlXeKytlnwuthDdqR xJXgr/H21uci41lVeJQOE5KI/J8VQmTfC3Kl28FByW7gu5CPWK1acFleFEugo1WP01t2y6kkHL+ G4cqM66uqiswOCVadtuHj1P6HEEwx1p122NE81sh0LZ2ACXf0hU3ITZf1KsKlUrqQrQYDXHAKi4 lUdqmQhSDv/r616BjwvEyKW4qR9g== X-Google-Smtp-Source: AGHT+IFyyXNW5PdLb1EAji6FZwxk9z7oFuqaX4IQuCCEMfZdy25gAvQgNKkIYiereVgd1Zd4VZyqew== X-Received: by 2002:a5d:5847:0:b0:427:7cd:7b1d with SMTP id ffacd0b85a97d-429bd6a4d9fmr100959f8f.40.1761840621896; Thu, 30 Oct 2025 09:10:21 -0700 (PDT) Received: from linux.fritz.box ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429952b7a7csm33124857f8f.8.2025.10.30.09.10.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Oct 2025 09:10:21 -0700 (PDT) From: Marco Crivellari To: linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter Subject: [PATCH 1/4] drm/amdgpu: replace use of system_unbound_wq with system_dfl_wq Date: Thu, 30 Oct 2025 17:10:08 +0100 Message-ID: <20251030161011.282924-2-marco.crivellari@suse.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251030161011.282924-1-marco.crivellari@suse.com> References: <20251030161011.282924-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistency cannot be addressed without refactoring the API. system_unbound_wq should be the default workqueue so as not to enforce locality constraints for random work whenever it's not required. Adding system_dfl_wq to encourage its use when unbound work should be used. The old system_unbound_wq will be kept for a few release cycles. Suggested-by: Tejun Heo Signed-off-by: Marco Crivellari --- drivers/gpu/drm/amd/amdgpu/aldebaran.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/aldebaran.c b/drivers/gpu/drm/amd/a= mdgpu/aldebaran.c index 9569dc16dd3d..7957e6c4c416 100644 --- a/drivers/gpu/drm/amd/amdgpu/aldebaran.c +++ b/drivers/gpu/drm/amd/amdgpu/aldebaran.c @@ -175,7 +175,7 @@ aldebaran_mode2_perform_reset(struct amdgpu_reset_contr= ol *reset_ctl, list_for_each_entry(tmp_adev, reset_device_list, reset_list) { /* For XGMI run all resets in parallel to speed up the process */ if (tmp_adev->gmc.xgmi.num_physical_nodes > 1) { - if (!queue_work(system_unbound_wq, + if (!queue_work(system_dfl_wq, &tmp_adev->reset_cntl->reset_work)) r =3D -EALREADY; } else diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/a= md/amdgpu/amdgpu_device.c index 7a899fb4de29..8c4d79f6c14f 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -6033,7 +6033,7 @@ int amdgpu_do_asic_reset(struct list_head *device_lis= t_handle, list_for_each_entry(tmp_adev, device_list_handle, reset_list) { /* For XGMI run all resets in parallel to speed up the process */ if (tmp_adev->gmc.xgmi.num_physical_nodes > 1) { - if (!queue_work(system_unbound_wq, + if (!queue_work(system_dfl_wq, &tmp_adev->xgmi_reset_work)) r =3D -EALREADY; } else diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c b/drivers/gpu/drm/am= d/amdgpu/amdgpu_reset.c index 28c4ad62f50e..9c4631608526 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c @@ -116,7 +116,7 @@ static int amdgpu_reset_xgmi_reset_on_init_perform_rese= t( /* Mode1 reset needs to be triggered on all devices together */ list_for_each_entry(tmp_adev, reset_device_list, reset_list) { /* For XGMI run all resets in parallel to speed up the process */ - if (!queue_work(system_unbound_wq, &tmp_adev->xgmi_reset_work)) + if (!queue_work(system_dfl_wq, &tmp_adev->xgmi_reset_work)) r =3D -EALREADY; if (r) { dev_err(tmp_adev->dev, --=20 2.51.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 078E23655FE for ; Thu, 30 Oct 2025 16:10:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761840627; cv=none; b=QBgk/alxZC0lc+eAaQM0zsz7HU3dX0+5oHuJWCCJxyBxdPWXlRulBmWtzH9dlzFRDoefU/VB4RQC4jWBmQNfUtY50byntd5ta7T1nzq7f42mSn4xlieGpC+aedwr6CImSTcT1DFE+ti9G3f2JZfmGQrMoiTd42ghXk5U1VqE1RM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761840627; c=relaxed/simple; bh=H4IwhcwbBrf3+paFzmD/85/Pn963V60WpXXajyPuM7c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ggFqfW5NIVSklJIGF8TzxbeiIPhCVUlGUnJu0ZIL6xEvdT15zekpeJvaiYJhD4fR6rQLlU0N20kgnAmgy0SVWuFh4YJ0iona2HMlBg7iRnv8fejJObTze0oYwvrie8jn/kg0zZak8drsmsllcGBfl84+OKcQlwa5enSO9hF29RY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=FzI9ENtF; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="FzI9ENtF" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4710022571cso14574985e9.3 for ; Thu, 30 Oct 2025 09:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1761840623; x=1762445423; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2i47abyZfZz1bsH2DYwFEj9nyP4hs0s7U+jv9iT3E+I=; b=FzI9ENtFFNX9cfyHHTU/In6xKrq2LD888CWrLTRsYqerRFYltIGEG/CfqEMlzzOB9g 0Z7RPha89b+ZLQo2O5qc0H38fuXOuRZG6ARJ2JzKFResnidZv9155guI3lv2eYn9SXVD Ky76bBSOAlraLemvxFr/DadNi8a12d6R0liFhnRSp6dcq6zJ9op8RycvSUxLNZAjaOcI rQ0aiQ1ONnE5exB2vbJ7e+YuyIkrwAM9GI8flynnCvRNeIxqSCOUKJNX4qhOxUO0yLw7 tyRsIrZAIIYeRS8TN06Krl1N+ZwXDgdBRwGLYL9OlAiCILW/oClZAXFRlchpe5EXBGjB KtwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761840623; x=1762445423; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2i47abyZfZz1bsH2DYwFEj9nyP4hs0s7U+jv9iT3E+I=; b=bReQWR0ckGWZUg68dKJhjSiagJZwBOvs7BmKvIQltHqsrHF0OedFrJynLiv7g6qPhw a+XGVQ3li4itCznGo0wOZ8ucBsCsUppEIxpPdOroIzzI3OpU6i2fCfAxFBzNdQhBPyj2 5p67R0ah6f7hjG8KC9ApOL8QiMEwCLxrPNdx3azPcSSKYQDKk5+Uikt2TIVUIBjg6US9 GzryXC0Rwq2OANQok8Zp7oEotikvOCehdkcb1uMt8VMt3GnLYxjx8rCbJKkBhOFTOyYj rA9hW8kWpPnoQmuaISSgKDkW9BEcBBm1TnYovfvkTJ3+Kz3TfM8UnoDgNlj4c6hrPE16 BcHg== X-Gm-Message-State: AOJu0Yzz0e8FmJ7bIwtnxhuJDVeUqmOu4+jwY210svNtzhydvtglQ6iF 4j+EUB5TEtutGW965y7hgdmDzanaMI4DgZI8HOJlzDZ20pPQqvgnjWmYf4h/bf5oX59BFj/TGyA fxWAu X-Gm-Gg: ASbGncu+N1C/3+fdZyIzpSxW/Sq4M/ZCWGHO6RnN7UUVQCiJPT1BiUJvanPrRQS8Owo woR2upmHvGuMBex43hQYHbYOp/F+81Mi1ewYz3hwaD6MPpPOcBPSCQZprLSQfbK0XAbAQe/Kz1c rT49y4bF7A2ySe9aQEO7jQl2jZhddzmb1fvrx14I3NaxZNLbKGkxiUUlMQfJ0dD7dzHO0jx8+yT uEArOwaiCAUrKJtm7fEvpBZWXBbqLJgdw6idnFSGyXPkp2lmfVPTNeCTMcKbTlPECvI8WW74kOU cvHk7/sHDo2GKP/Ckw9vwbxGI8Fe0mKP570wc0TjrRm0jzZ8Siv/ftfivMaWKKTjUXHUOTWH+Zy KXWs86HbSD+R1CfzM7azcEmscNbn2hy6UcxNAhxXelW2hogdgjC3fW5OwS4THnj5rmtuzaz71nr wE9GE0BVMuNaSPVeE= X-Google-Smtp-Source: AGHT+IGAga75c6sY1Q+McZyix+GUEVEkjmtz7d93ls2cdpw2dE67igG9rZbHtTGqPlGirMSJ37N0Bg== X-Received: by 2002:a05:600c:8b30:b0:471:15df:9fc7 with SMTP id 5b1f17b1804b1-4773086d57cmr2259475e9.26.1761840622930; Thu, 30 Oct 2025 09:10:22 -0700 (PDT) Received: from linux.fritz.box ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429952b7a7csm33124857f8f.8.2025.10.30.09.10.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Oct 2025 09:10:22 -0700 (PDT) From: Marco Crivellari To: linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter Subject: [PATCH 2/4] drm/amdgpu: replace use of system_wq with system_percpu_wq Date: Thu, 30 Oct 2025 17:10:09 +0100 Message-ID: <20251030161011.282924-3-marco.crivellari@suse.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251030161011.282924-1-marco.crivellari@suse.com> References: <20251030161011.282924-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistency cannot be addressed without refactoring the API. system_wq should be the per-cpu workqueue, yet in this name nothing makes that clear, so replace system_wq with system_percpu_wq. The old wq (system_wq) will be kept for a few release cycles. Suggested-by: Tejun Heo Signed-off-by: Marco Crivellari --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/a= md/amdgpu/amdgpu_device.c index 8c4d79f6c14f..2f8160702f9a 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -4798,7 +4798,7 @@ int amdgpu_device_init(struct amdgpu_device *adev, } /* must succeed. */ amdgpu_ras_resume(adev); - queue_delayed_work(system_wq, &adev->delayed_init_work, + queue_delayed_work(system_percpu_wq, &adev->delayed_init_work, msecs_to_jiffies(AMDGPU_RESUME_MS)); } =20 @@ -5328,7 +5328,7 @@ int amdgpu_device_resume(struct drm_device *dev, bool= notify_clients) if (r) goto exit; =20 - queue_delayed_work(system_wq, &adev->delayed_init_work, + queue_delayed_work(system_percpu_wq, &adev->delayed_init_work, msecs_to_jiffies(AMDGPU_RESUME_MS)); exit: if (amdgpu_sriov_vf(adev)) { --=20 2.51.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 069ED365D21 for ; Thu, 30 Oct 2025 16:10:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761840628; cv=none; b=RcXe3sNH7INxfQdyfQZATVKflpSeXoMdD7oq1OhkWvaSUqVtlbSmEkRU4XemKub5TK8UP8ZJH7JL+SRm1GYUKqhFZBB4j+R/Le9diXJWlj7UvYqRhEZfthzEiUedgcS5qH/OhsL85D2BfwTLOE7maGJs3Z65KyLI79dR/+avuRE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761840628; c=relaxed/simple; bh=pitwEdfA3nrBdh1BiRCp4D3Z4tLTcR3JkelahY7Hs9M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oAij+AbE7qjT1W5VaFfOyOmDQRfXsTHm8jS47fTfvtv/CHnx+t310s/gorTnSK+tIqX6OBN1RcV1OB+6z8XkOdm+JVzQWYMswDiVEfJxv0MGwdyIBHv1L8rycJLuGncgbUm0yELXnnF33za08I1l9P16u6H3S4mnAfl1puwi24g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=VI/EtZmQ; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="VI/EtZmQ" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-475d9de970eso8922265e9.1 for ; Thu, 30 Oct 2025 09:10:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1761840624; x=1762445424; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1mzPZhnW69Ma46xdkUZL4rvYZEGa/gCP35bg1gX0aRM=; b=VI/EtZmQNv4WDwD8Lg1bJSRScPipTIbBHpNrFa9j6ndey5bnhmxQSC75pREDZ+NjhG 35qUD/F64FFb1QYV7oqMuFFH5otLWObPxBTitNFne2lkYCBwaomgzsJqNSBe6K7872Ye INKuy7asXRPuBTpfJMrJzWMHN2O3F9An/L3NN8RmYQWv+MnBXv/eQMAPalCUZpeR6tA/ w64/t9TXwjB9kb/ZgtP5KXOG6JTG2WLrfeaVK6gQJ2kLFYVaTvn7uKcTbt4xvtxSJVrI WDrsY7vcgHe6ZeOS5sqR7eV0zs93brw02oWyPuz1n1HkWQr6Vb9M5GlXLstg8aTA7SCa VjaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761840624; x=1762445424; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1mzPZhnW69Ma46xdkUZL4rvYZEGa/gCP35bg1gX0aRM=; b=LmopvlW7CyfLpRCcteTIYhL1NK3gZbHJis5HU2kMs1oGNeuYDhTp3/yYSnrAhty5qP XxK3s4Kl0iO8875gFQU2yp9u7Ai7U8Xsib3bGuXd/agUxSdgvuNU5bSWtrwgDaXTPcTH 63B9ASyHCCdxnTaE7v/PH7Mv1Z4ossSZxQC0V/g2FXiIWVj1fmOpRy9v1nAMwbVTkfHD SYQXgunV6EgqV65BnOybaHm/c5X/8oyVtFSY124f7gjbveM6qsggUR+A/BEIByTnkUuR Odh2dpOm5Oi2Q5KBUwiXsGS8FH02hBztpHyiqMmV3Eh6i5nKPa9/1lBjL+Xytt/xnae1 8T0g== X-Gm-Message-State: AOJu0YxBgEzkqk/sItQG8z4YmMQFpIx36tEDPZ64Stj8Q0r+xJdDvdyU ZtuYg4HJh7oirvcpTHmx4EDPLjZ4CnQXm5lQqZAM4+bAqtZ+ZDyL+Jsy0nzvaV7ZHggiQCGqcrh 2+1S4 X-Gm-Gg: ASbGncv8lGqXJVFQ4WpCxf9GBfp6vudFX+ZADDuG+7fy3UL80K9lMogjEkeFe7kJaOw oWXIVZEFIkgIXvrPzO4J0MtrGPyXOQoh34gSJTfUL0JvQdkn8XakvFC5HmXHb+kJDlaQHplBOof kXy3x+4NrQBKJ1B3ieg37rvZ15o90Xc63fr3rlUnWGiJrWLKEuO/tOSU8GWshWNIIAzmyfEPTXs /GvmJRE/bDP96nssfCLaiOwt27kw1f0EqRfI6/X2zpE2WnmBP4zIe0zY/E9U7DRGAXEzSz07jDI HYioxtlj2IFkqMhjV06zyV03JJPvSe3y5x2rRBLxwhMUFX/1kJZb6/FEZO6aZMasA+hloEK7SWR zCRKLcOgov55jlVlD105I99w7k867EX0Bl7IZlEMr0ySa4n+hPczEgEtGGJvT6snjyll+LZppA7 yyNwz7vt/51E0UrfA= X-Google-Smtp-Source: AGHT+IFroBmfAiCGL5XJxbZgL6hgq0wEFDb+ooauLfTFeIekjVl2CAAel/J5c/moOLtcfk84yd6I0g== X-Received: by 2002:a05:600c:4e43:b0:477:e66:406e with SMTP id 5b1f17b1804b1-4773088be60mr3082305e9.29.1761840624032; Thu, 30 Oct 2025 09:10:24 -0700 (PDT) Received: from linux.fritz.box ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429952b7a7csm33124857f8f.8.2025.10.30.09.10.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Oct 2025 09:10:23 -0700 (PDT) From: Marco Crivellari To: linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter Subject: [PATCH 3/4] amd/amdkfd: WQ_PERCPU added to alloc_workqueue users Date: Thu, 30 Oct 2025 17:10:10 +0100 Message-ID: <20251030161011.282924-4-marco.crivellari@suse.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251030161011.282924-1-marco.crivellari@suse.com> References: <20251030161011.282924-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistentcy cannot be addressed without refactoring the API. alloc_workqueue() treats all queues as per-CPU by default, while unbound workqueues must opt-in via WQ_UNBOUND. This default is suboptimal: most workloads benefit from unbound queues, allowing the scheduler to place worker threads where they=E2=80=99re needed= and reducing noise when CPUs are isolated. This change adds a new WQ_PERCPU flag to explicitly request alloc_workqueue() to be per-cpu when WQ_UNBOUND has not been specified. With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND), any alloc_workqueue() caller that doesn=E2=80=99t explicitly specify WQ_UNB= OUND must now use WQ_PERCPU. Once migration is complete, WQ_UNBOUND can be removed and unbound will become the implicit default. Suggested-by: Tejun Heo Signed-off-by: Marco Crivellari --- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd= /amdkfd/kfd_process.c index ddfe30c13e9d..ebc9925f4e66 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c @@ -690,7 +690,8 @@ void kfd_procfs_del_queue(struct queue *q) int kfd_process_create_wq(void) { if (!kfd_process_wq) - kfd_process_wq =3D alloc_workqueue("kfd_process_wq", 0, 0); + kfd_process_wq =3D alloc_workqueue("kfd_process_wq", WQ_PERCPU, + 0); if (!kfd_restore_wq) kfd_restore_wq =3D alloc_ordered_workqueue("kfd_restore_wq", WQ_FREEZABLE); --=20 2.51.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17E1C365D34 for ; Thu, 30 Oct 2025 16:10:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761840629; cv=none; b=ZsGv0ZlC2VPBa4pYni2DDRb9uWWYcDZg/8lPfqvIArqGYJ19VSuaD3FCsHFG65n4Zrxc7AmcQxYiL9Y2KzoHOJvT6Idv0is/WbGcMWzDY4hopjLMgzXjRz3gVcIJ5lDHf9KOdGXaQPK1TegVbFMI2Mv1PoalkucfQNURnEs+MSQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761840629; c=relaxed/simple; bh=lKjDJt4O/H35TLYg6iUN24lXu3yise5Gp9iVcTWfvgM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hhKd8UnNjD8JxPBD1HIgEvwxsl/v9RExa6e/6swAjiqYG87qbVQQmkrsk1ICBciQ2XGhu2jBl0MOXtBal/qCUj7fDjnU0QB47mwt9uZhr8AcQ0BcXA0tAPoNsuqAg+ZQ20+RocMzK6r55iDCjeLgAwdRphDdgXcgFPiBWmyosj8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=O1yScdwW; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="O1yScdwW" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-475dd559b0bso16485585e9.1 for ; Thu, 30 Oct 2025 09:10:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1761840625; x=1762445425; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qUyLe55hA4hNh5avFZjcyEPUTCpSS8nAfdCLlggpt5s=; b=O1yScdwWRkFyK01BvoWW2eHOq7RKpb46MK0bs8HQ/53EgwcRG+VxJRicmJaSfbtsUg uoL0ifO3Wmf6J/70Os997kJ1g3QDxyEVaTnPzc8mpIjANBfRODraM+yuNaAD/pzIhTeR EnepzWUuu2HGk/FDdbNDSsja0N56qc0pXCDYicOXS51vu0JwhqR4HO3sUu5Suq8e6DEq o2grTxPMftopfFTslZoUbwihpZTrbe1GpT6+z4QhedzmXWL8N+RBMVRN/Od/JfUKvrO+ /ofGGdeuJWf0yWng5iNWbHWCqE6DAMhRujeczX7wzz9TxmMmwxBPgaM75h0JJJIeKiFJ YBDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761840625; x=1762445425; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qUyLe55hA4hNh5avFZjcyEPUTCpSS8nAfdCLlggpt5s=; b=tWqJmBBFvjoAbcRc/mGlcFUt4zifYI/nus2AHP+LuhT/X7mIaZwBWCX1wpPO/QGQVy RL3Mk78YXZbnP+CWJ0xzb2fnMAEXSDOWrJuznutAgWfZjzPEFjeNUfEgGgXXKm5EGyxF MhMQ6PctNjxTS8yNgkgM9BPHomAbdp0xnoscKsxeuwotpOB/6WAHc9t7b4xgEWzcrAri 3yCQBOYchO0MV4CevwVBgHg3FSCkOelkpZbiuX1yrOGsUWsnueWUyhXCqQx9zxwMjlRT cVqLdFAwbYrHrWlzPQRpxQgK3aaz4nGK1X22pmsC40K9+x8zPiuM0aE50jxmoS//9MyF g5ag== X-Gm-Message-State: AOJu0YxqWejnZUQH9T3+Zdt/lGqOo5OotAOqMaHcYtd7kFDeDQbCNUps TiJ0dgE+dfXLD6QKPADPT7u7tYpcJaB83W9ggTVQuBNICkbeH71BDc8lnr4ekACxjlxrpk1OhZY vyoDr X-Gm-Gg: ASbGncu1UgbLmI3Vot+fk91tcOJ7DkbfoEFZmPE0j98UnpXtzOU04SZngA7vGVMdisx /8s2iMmNSpZfA3bTbugOmGzgfO/1xMrfggNEh5PphOzwhwL9w5KtBnfArEhu9MelTXFiZL2XIgv 4uHcegySnnSVoVd4w6vpb6KnAlDt+cmVyz9Jb6pO+NhPUbNKbRkQxpEP7kalH349ie0W9wuMmND 0gN6qzLYXvThkaF2IXBnUnVyrONrmEP4Sq1/wKuZyXHbpNDO+kc2J3TenFQF8jMXy6XL4lBNE5+ +HI7YlEv/BgTCNqZChuGWjNdB6HEbwZsI8ApGSEh9JkPWgWrWTnDd6EQB5682Ht9iU12lEoDXls 41OpGnAnVcquBZUJz6xVPFZLcnj4oL9V8GraT3caNzaHleAfg/cEcNCkk/4STKLrCyx+NdmXDuC Nu1ODM9tbwjO0Zu9A= X-Google-Smtp-Source: AGHT+IFyE5J11xUKBnyXYND4mxJaazGINsyI2NsqELziu7PEPOdM/yL8Wk6KNj6+t9t3bygj4S8Ayw== X-Received: by 2002:a05:600c:6986:b0:46e:7247:cbc0 with SMTP id 5b1f17b1804b1-47730859cefmr2359355e9.18.1761840625061; Thu, 30 Oct 2025 09:10:25 -0700 (PDT) Received: from linux.fritz.box ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429952b7a7csm33124857f8f.8.2025.10.30.09.10.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Oct 2025 09:10:24 -0700 (PDT) From: Marco Crivellari To: linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter Subject: [PATCH 4/4] drm/radeon: WQ_PERCPU added to alloc_workqueue users Date: Thu, 30 Oct 2025 17:10:11 +0100 Message-ID: <20251030161011.282924-5-marco.crivellari@suse.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251030161011.282924-1-marco.crivellari@suse.com> References: <20251030161011.282924-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistentcy cannot be addressed without refactoring the API. alloc_workqueue() treats all queues as per-CPU by default, while unbound workqueues must opt-in via WQ_UNBOUND. This default is suboptimal: most workloads benefit from unbound queues, allowing the scheduler to place worker threads where they=E2=80=99re needed= and reducing noise when CPUs are isolated. This change adds a new WQ_PERCPU flag to explicitly request alloc_workqueue() to be per-cpu when WQ_UNBOUND has not been specified. With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND), any alloc_workqueue() caller that doesn=E2=80=99t explicitly specify WQ_UNB= OUND must now use WQ_PERCPU. Once migration is complete, WQ_UNBOUND can be removed and unbound will become the implicit default. Suggested-by: Tejun Heo Signed-off-by: Marco Crivellari --- drivers/gpu/drm/radeon/radeon_display.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/rade= on/radeon_display.c index 351b9dfcdad8..3c8aa5274c51 100644 --- a/drivers/gpu/drm/radeon/radeon_display.c +++ b/drivers/gpu/drm/radeon/radeon_display.c @@ -687,7 +687,8 @@ static void radeon_crtc_init(struct drm_device *dev, in= t index) if (radeon_crtc =3D=3D NULL) return; =20 - radeon_crtc->flip_queue =3D alloc_workqueue("radeon-crtc", WQ_HIGHPRI, 0); + radeon_crtc->flip_queue =3D alloc_workqueue("radeon-crtc", + WQ_HIGHPRI | WQ_PERCPU, 0); if (!radeon_crtc->flip_queue) { kfree(radeon_crtc); return; --=20 2.51.0