From nobody Sun Feb 8 06:22:10 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 527FB307AC4 for ; Thu, 30 Oct 2025 10:49:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761821393; cv=none; b=g8T9cqPPaPd96sAuhULlAlgH6Db5UC1P1V+TySdlsUTR1uZ+1kyMT0ZhkLPja6RYwvM/491Agu76B6zqRpd7UWeDkBSFahckNDBanIDdO98rR+R4uj090pR8vLU+MxRUTHEVpEADos/3Ce+NxM9kS+s3rH6W09kXqNWjUh2Z248= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761821393; c=relaxed/simple; bh=VTIGLJoqL09T3qdqKCWT95vPfPOyfhp3sKIJURo8kec=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jb2KWDrFyPbt3yLBwlsLDB2Z3FAdz2mA1QI3ARDURc9TzVv+FGFZJrhG2NQuZcKgi1c9RC/6fXrnk3EbyolICyROlwxtAsNk1h9+GKOvuT2A1NeTwmsa2+ddRg5HR7u7QqJYO7fq0DVVUFS9mP2wsFlnD3cnilMdFRAPdpn5yAc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PVn6MkF5; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PVn6MkF5" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-780fc3b181aso694379b3a.2 for ; Thu, 30 Oct 2025 03:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761821392; x=1762426192; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I3p2yqAWOCqYWEXlmFTpGQJoAadTNkNOwJpC5qXOYbs=; b=PVn6MkF5bwbrksfoO7vlX8x/1JzAkAOf/4MbPNeeb3558hEBSyEstX7WP+fuyy8dGe +lSt2nL4K36uzzbfMWgbrv9n2A/JuSyJ+rrG+l0YILSmP6BUTV1z9JY9gPRZie6C/1p8 BmP2O0k2d+2GcPKXFKBLdH4C0JIWrt/EBtC7tEf8EHWFzCLR/fF7BYchlMBtmWf0JKSH GjSgLXwRVbD9WqSX7ERxzw0ivWQTpK8oW5H1mo8urSVbxPDuKlwh5DlgEMNXKyhuuFjs Y970H5fbV13iScc4HnGtM+kBCzJK3dmEZwC/suGQskNntYQCWlg/WW3xmFEOr2Im+ybz UT7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761821392; x=1762426192; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I3p2yqAWOCqYWEXlmFTpGQJoAadTNkNOwJpC5qXOYbs=; b=AYcIN/H3h1tdLw0BSvgknSigr/P/cs7phZylJv+FppwPUkqNY7RANj6o7RNJ5KSIIi KhTWlxnwaQBhI4/re9qyYu1K8wTqzlDgXjd6uMORFIq0hBajwNNcTAgxCqUWOSXBPyU7 pfraoCsQx/SBBQ/QrXbDwdaKyhKUYV36zvX69f8YX3PDAuXQrg9X7qR7HklOxqHyardw nBSop/xt+n6o+TnRn5nJ0uhCyJIEDWzUR9UUNvPKpWK2AfO0DdQyYvr3u4KldOPX4LqR odU4JesCsoMWtmp0EgwMkbH9wJkmxgbJI5pcbev+9ghyfuEeKGrFwnU/noCzwotRBbpl AqZw== X-Forwarded-Encrypted: i=1; AJvYcCWF+l6ZAIkHFeSoTNrnlJOxjzD9Gvru4mf8j4Cm633Y6W1q2YXfn3wKXaTQXoIqsnjvWMq2lo3L3fM73J4=@vger.kernel.org X-Gm-Message-State: AOJu0YzMnCd9xJKZUdYyhGolnirXIoTFf3PvWOj97KY7Xs3cUqI181Qk REtcgrQaSWki1g1TpTjbQD5yBYarm2obBp7+80SVxobDY6/Tw2WWAomx X-Gm-Gg: ASbGnctQIzNHGOmD7x/j3THBrPuZsk4OQDHdF7IY+dI6v3dqsxv/n/aTVEz9wKhqhKr SP990rQJVWWOn2Tj1mJZNcHG09nbd53xN7GlweH7LRHrcUXCZsxsus1r7Jg34cC3NPdFuWn2ZiY uWm3YPbNmkGY2y6olRrB+1ljI1rCAfQsn67ny5zcUaEwYKNGVYVLhosi70YGKGlKuszC34b/xOk TTW69zfNLcL6HWXkEpo5k0wWD3tbfJ2RclV9O3Jm0LabFyz0GJ7DAML773auJiCUNkAZCz4a4uY 4/EZarzdq+qfsrmPMQeaHMGPXrUz9cIDiidQ1lnqxpJWN+7bbmQmFMTmsWOwQze847bIoYQcygX 5nW49N0mPbi6Z+znB9iAiVmfiZQ6Z/pzQLC/QJ1AeJmWdwZJ+af0Lspd/Xsdvm1o6XItAJo4tsK T4XJGZykS6KJUSMdWVnKSHvg== X-Google-Smtp-Source: AGHT+IGU7fXKMPGFniTXJxT+Y1B4SNOc8ney/kiF1ZfNDyydbRHCeKanSDnjrz8dd8tokm2NLVK8SQ== X-Received: by 2002:a17:902:d512:b0:294:ccc6:cd2c with SMTP id d9443c01a7336-294dee491f3mr72004445ad.22.1761821390964; Thu, 30 Oct 2025 03:49:50 -0700 (PDT) Received: from ustb520lab-MS-7E07.. ([115.25.44.221]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29498d273cdsm181053915ad.55.2025.10.30.03.49.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Oct 2025 03:49:50 -0700 (PDT) From: Jiaming Zhang To: kory.maincent@bootlin.com Cc: davem@davemloft.net, edumazet@google.com, horms@kernel.org, kuba@kernel.org, kuniyu@google.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, r772577952@gmail.com, sdf@fomichev.me, stable@vger.kernel.org, syzkaller@googlegroups.com, vladimir.oltean@nxp.com Subject: [PATCH v2] net: core: prevent NULL deref in generic_hwtstamp_ioctl_lower() Date: Thu, 30 Oct 2025 10:49:42 +0000 Message-Id: <20251030104942.18561-1-r772577952@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251030111445.0fe0b313@kmaincent-XPS-13-7390> References: <20251030111445.0fe0b313@kmaincent-XPS-13-7390> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The ethtool tsconfig Netlink path can trigger a null pointer dereference. A call chain such as: tsconfig_prepare_data() -> dev_get_hwtstamp_phylib() -> vlan_hwtstamp_get() -> generic_hwtstamp_get_lower() -> generic_hwtstamp_ioctl_lower() results in generic_hwtstamp_ioctl_lower() being called with kernel_cfg->ifr as NULL. The generic_hwtstamp_ioctl_lower() function does not expect a NULL ifr and dereferences it, leading to a system crash. Fix this by adding a NULL check for kernel_cfg->ifr in generic_hwtstamp_get/set_lower(). If ifr is NULL, return -EOPNOTSUPP to prevent the call to the legacy IOCTL helper. Fixes: 6e9e2eed4f39 ("net: ethtool: Add support for tsconfig command to get= /set hwtstamp config") Closes: https://lore.kernel.org/lkml/cd6a7056-fa6d-43f8-b78a-f5e811247ba8@l= inux.dev/T/#mf5df538e21753e3045de98f25aa18d948be07df3 Signed-off-by: Jiaming Zhang --- net/core/dev_ioctl.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c index ad54b12d4b4c..a32e1036f12a 100644 --- a/net/core/dev_ioctl.c +++ b/net/core/dev_ioctl.c @@ -474,6 +474,10 @@ int generic_hwtstamp_get_lower(struct net_device *dev, return err; } =20 + /* Netlink path with unconverted lower driver */ + if (!kernel_cfg->ifr) + return -EOPNOTSUPP; + /* Legacy path: unconverted lower driver */ return generic_hwtstamp_ioctl_lower(dev, SIOCGHWTSTAMP, kernel_cfg); } @@ -498,6 +502,10 @@ int generic_hwtstamp_set_lower(struct net_device *dev, return err; } =20 + /* Netlink path with unconverted lower driver */ + if (!kernel_cfg->ifr) + return -EOPNOTSUPP; + /* Legacy path: unconverted lower driver */ return generic_hwtstamp_ioctl_lower(dev, SIOCSHWTSTAMP, kernel_cfg); } --=20 2.34.1