From nobody Sun Feb 8 22:22:00 2026 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C1DD338584; Thu, 30 Oct 2025 07:52:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761810781; cv=none; b=h7+rZoIrbds5RsEgFfyF8IysBBuI1Jaj3sfU0Bbj+xIdP6MuS7a+V81AVOwDHHSDJusLhgklS23cYzHeaT1v8Lv5eRL05G0tC/y8IOyGohsK+AS6is1qkPUo0yCa5hxZsEToxWBTbE2B+CuRYljqC1/79V0rPf4eTq2rmSXoiDQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761810781; c=relaxed/simple; bh=VzTHB6uwUrUYHIbZ6C1sj1SfLBTRnPQuiLbkWA/dx0A=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gviwemcsARl2uWrRKzHGRRoRiptNhwqwe6MdLN8eSeAhZBr4Uw8clHM/RtNcJZGBcW7fCC98LqyXpNjD/O2khfLjnG/+tnWVsCQ+hsKjN8w4TMsbOKrqVHz/Hpwnys7BIZWUJT3RkhIeys4Ojg4IPIP6OVgk5QLu743NrbR5n+k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=CSKX94O2; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="CSKX94O2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1761810780; x=1793346780; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=VzTHB6uwUrUYHIbZ6C1sj1SfLBTRnPQuiLbkWA/dx0A=; b=CSKX94O2NB7A49yrLqrRoZetCqbIHJJ4PHNXlPcPXVCCnKigCXcvPw0B HVMZLDEaeFjnDxLwhza90ZDZweuWw5qWnMx1qzGm856e7+z4h0diNj/bh /TouUdh1kqOau28MrC0DRoH52VNqr8622+j3Lb9K97qdhpdmI91ekOrQl QsQfP8FTuaUaygoFXTIoJqQi/HXtLys0FEWzTM3Au0OSJb0rkS7JEXl8O 9/owHZSpv8DYv8SCNqqJrwas/vjtzgVavLIYGTG0wAEPEcmiRH4s1ERGP suv4mDQmuBnmesaOcQQe4vwvsOV4O3nM9mk2ddE6AABsIQ0NNOrcoEfhi g==; X-CSE-ConnectionGUID: hWk4P1TPRtmfKCCnTJHFMw== X-CSE-MsgGUID: CYXbvUIvSlySK+4RULBSVw== X-IronPort-AV: E=Sophos;i="6.19,266,1754982000"; d="scan'208";a="48455738" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Oct 2025 00:52:57 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.58; Thu, 30 Oct 2025 00:52:28 -0700 Received: from DEN-DL-M31836.microchip.com (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Thu, 30 Oct 2025 00:52:26 -0700 From: Horatiu Vultur To: , , , , , , CC: , , Horatiu Vultur Subject: [PATCH net v3 1/2] net: phy: micrel: lan8842 errata Date: Thu, 30 Oct 2025 08:49:40 +0100 Message-ID: <20251030074941.611454-2-horatiu.vultur@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251030074941.611454-1-horatiu.vultur@microchip.com> References: <20251030074941.611454-1-horatiu.vultur@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add errata for lan8842. The errata document can be found here [1]. This is fixing the module 2 ("Analog front-end not optimized for PHY-side shorted center taps"). [1] https://ww1.microchip.com/downloads/aemDocuments/documents/UNG/ProductD= ocuments/Errata/LAN8842-Errata-DS80001172.pdf Fixes: 5a774b64cd6a ("net: phy: micrel: Add support for lan8842") Reviewed-by: Andrew Lunn Signed-off-by: Horatiu Vultur --- drivers/net/phy/micrel.c | 149 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 149 insertions(+) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 604b5de0c1581..504c715b7db90 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -2853,6 +2853,13 @@ static int ksz886x_cable_test_get_status(struct phy_= device *phydev, */ #define LAN8814_PAGE_PORT_REGS 5 =20 +/** + * LAN8814_PAGE_POWER_REGS - Selects Extended Page 28. + * + * This page contains analog control registers and power mode registers. + */ +#define LAN8814_PAGE_POWER_REGS 28 + /** * LAN8814_PAGE_SYSTEM_CTRL - Selects Extended Page 31. * @@ -5884,6 +5891,143 @@ static int lan8842_probe(struct phy_device *phydev) return 0; } =20 +#define LAN8814_POWER_MGMT_MODE_3_ANEG_MDI 0x13 +#define LAN8814_POWER_MGMT_MODE_4_ANEG_MDIX 0x14 +#define LAN8814_POWER_MGMT_MODE_5_10BT_MDI 0x15 +#define LAN8814_POWER_MGMT_MODE_6_10BT_MDIX 0x16 +#define LAN8814_POWER_MGMT_MODE_7_100BT_TRAIN 0x17 +#define LAN8814_POWER_MGMT_MODE_8_100BT_MDI 0x18 +#define LAN8814_POWER_MGMT_MODE_9_100BT_EEE_MDI_TX 0x19 +#define LAN8814_POWER_MGMT_MODE_10_100BT_EEE_MDI_RX 0x1a +#define LAN8814_POWER_MGMT_MODE_11_100BT_MDIX 0x1b +#define LAN8814_POWER_MGMT_MODE_12_100BT_EEE_MDIX_TX 0x1c +#define LAN8814_POWER_MGMT_MODE_13_100BT_EEE_MDIX_RX 0x1d +#define LAN8814_POWER_MGMT_MODE_14_100BTX_EEE_TX_RX 0x1e + +#define LAN8814_POWER_MGMT_DLLPD_D BIT(0) +#define LAN8814_POWER_MGMT_ADCPD_D BIT(1) +#define LAN8814_POWER_MGMT_PGAPD_D BIT(2) +#define LAN8814_POWER_MGMT_TXPD_D BIT(3) +#define LAN8814_POWER_MGMT_DLLPD_C BIT(4) +#define LAN8814_POWER_MGMT_ADCPD_C BIT(5) +#define LAN8814_POWER_MGMT_PGAPD_C BIT(6) +#define LAN8814_POWER_MGMT_TXPD_C BIT(7) +#define LAN8814_POWER_MGMT_DLLPD_B BIT(8) +#define LAN8814_POWER_MGMT_ADCPD_B BIT(9) +#define LAN8814_POWER_MGMT_PGAPD_B BIT(10) +#define LAN8814_POWER_MGMT_TXPD_B BIT(11) +#define LAN8814_POWER_MGMT_DLLPD_A BIT(12) +#define LAN8814_POWER_MGMT_ADCPD_A BIT(13) +#define LAN8814_POWER_MGMT_PGAPD_A BIT(14) +#define LAN8814_POWER_MGMT_TXPD_A BIT(15) + +#define LAN8814_POWER_MGMT_C_D (LAN8814_POWER_MGMT_DLLPD_D | \ + LAN8814_POWER_MGMT_ADCPD_D | \ + LAN8814_POWER_MGMT_PGAPD_D | \ + LAN8814_POWER_MGMT_DLLPD_C | \ + LAN8814_POWER_MGMT_ADCPD_C | \ + LAN8814_POWER_MGMT_PGAPD_C) + +#define LAN8814_POWER_MGMT_B_C_D (LAN8814_POWER_MGMT_C_D | \ + LAN8814_POWER_MGMT_DLLPD_B | \ + LAN8814_POWER_MGMT_ADCPD_B | \ + LAN8814_POWER_MGMT_PGAPD_B) + +#define LAN8814_POWER_MGMT_VAL1 (LAN8814_POWER_MGMT_C_D | \ + LAN8814_POWER_MGMT_ADCPD_B | \ + LAN8814_POWER_MGMT_PGAPD_B | \ + LAN8814_POWER_MGMT_ADCPD_A | \ + LAN8814_POWER_MGMT_PGAPD_A) + +#define LAN8814_POWER_MGMT_VAL2 LAN8814_POWER_MGMT_C_D + +#define LAN8814_POWER_MGMT_VAL3 (LAN8814_POWER_MGMT_C_D | \ + LAN8814_POWER_MGMT_DLLPD_B | \ + LAN8814_POWER_MGMT_ADCPD_B | \ + LAN8814_POWER_MGMT_PGAPD_A) + +#define LAN8814_POWER_MGMT_VAL4 (LAN8814_POWER_MGMT_B_C_D | \ + LAN8814_POWER_MGMT_ADCPD_A | \ + LAN8814_POWER_MGMT_PGAPD_A) + +#define LAN8814_POWER_MGMT_VAL5 LAN8814_POWER_MGMT_B_C_D + +static int lan8842_erratas(struct phy_device *phydev) +{ + int ret; + + /* Magjack center tapped ports */ + ret =3D lanphy_write_page_reg(phydev, LAN8814_PAGE_POWER_REGS, + LAN8814_POWER_MGMT_MODE_3_ANEG_MDI, + LAN8814_POWER_MGMT_VAL1); + if (ret < 0) + return ret; + + ret =3D lanphy_write_page_reg(phydev, LAN8814_PAGE_POWER_REGS, + LAN8814_POWER_MGMT_MODE_4_ANEG_MDIX, + LAN8814_POWER_MGMT_VAL1); + if (ret < 0) + return ret; + + ret =3D lanphy_write_page_reg(phydev, LAN8814_PAGE_POWER_REGS, + LAN8814_POWER_MGMT_MODE_5_10BT_MDI, + LAN8814_POWER_MGMT_VAL1); + if (ret < 0) + return ret; + + ret =3D lanphy_write_page_reg(phydev, LAN8814_PAGE_POWER_REGS, + LAN8814_POWER_MGMT_MODE_6_10BT_MDIX, + LAN8814_POWER_MGMT_VAL1); + if (ret < 0) + return ret; + + ret =3D lanphy_write_page_reg(phydev, LAN8814_PAGE_POWER_REGS, + LAN8814_POWER_MGMT_MODE_7_100BT_TRAIN, + LAN8814_POWER_MGMT_VAL2); + if (ret < 0) + return ret; + + ret =3D lanphy_write_page_reg(phydev, LAN8814_PAGE_POWER_REGS, + LAN8814_POWER_MGMT_MODE_8_100BT_MDI, + LAN8814_POWER_MGMT_VAL3); + if (ret < 0) + return ret; + + ret =3D lanphy_write_page_reg(phydev, LAN8814_PAGE_POWER_REGS, + LAN8814_POWER_MGMT_MODE_9_100BT_EEE_MDI_TX, + LAN8814_POWER_MGMT_VAL3); + if (ret < 0) + return ret; + + ret =3D lanphy_write_page_reg(phydev, LAN8814_PAGE_POWER_REGS, + LAN8814_POWER_MGMT_MODE_10_100BT_EEE_MDI_RX, + LAN8814_POWER_MGMT_VAL4); + if (ret < 0) + return ret; + + ret =3D lanphy_write_page_reg(phydev, LAN8814_PAGE_POWER_REGS, + LAN8814_POWER_MGMT_MODE_11_100BT_MDIX, + LAN8814_POWER_MGMT_VAL5); + if (ret < 0) + return ret; + + ret =3D lanphy_write_page_reg(phydev, LAN8814_PAGE_POWER_REGS, + LAN8814_POWER_MGMT_MODE_12_100BT_EEE_MDIX_TX, + LAN8814_POWER_MGMT_VAL5); + if (ret < 0) + return ret; + + ret =3D lanphy_write_page_reg(phydev, LAN8814_PAGE_POWER_REGS, + LAN8814_POWER_MGMT_MODE_13_100BT_EEE_MDIX_RX, + LAN8814_POWER_MGMT_VAL4); + if (ret < 0) + return ret; + + return lanphy_write_page_reg(phydev, LAN8814_PAGE_POWER_REGS, + LAN8814_POWER_MGMT_MODE_14_100BTX_EEE_TX_RX, + LAN8814_POWER_MGMT_VAL4); +} + static int lan8842_config_init(struct phy_device *phydev) { int ret; @@ -5896,6 +6040,11 @@ static int lan8842_config_init(struct phy_device *ph= ydev) if (ret < 0) return ret; =20 + /* Apply the erratas for this device */ + ret =3D lan8842_erratas(phydev); + if (ret < 0) + return ret; + /* Even if the GPIOs are set to control the LEDs the behaviour of the * LEDs is wrong, they are not blinking when there is traffic. * To fix this it is required to set extended LED mode --=20 2.34.1 From nobody Sun Feb 8 22:22:00 2026 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A5F98F5B; Thu, 30 Oct 2025 07:52:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761810766; cv=none; b=cWpEK2Qz6oyQGYG6LSZBkzArRFSZWVummpgmqirteJ177niTbsIz29MaYvUy6eV7tbuXCjJ4M0ixt/yQFrZCi5f9xi3CyrzfER6wBq1y0zKpmQnaPh89rIybNNtBnzegKjymt956cTp1ED31zrM8gCJp0k2NVH8yDh3drMoHXI4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761810766; c=relaxed/simple; bh=4brPCS6Z+GhMLQ+QXdncx2uLcqx1yYNpz/2tWj5/whk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=r39gYlbhkuUfU1SMGlVmQ5hOIMceuzj55H1w8jw/y3Rm/HbpvbPBEvDlY5BFGOLrF3N8EopK5jzZMjO2fBMQi1DuT9f1xV8WQc4W9JdHZWoJ+Cuklp1bAUnOvq6TGbN8YlWnsEyCoyyXVSpubQ+oV2UO/JkFoVRIENQ5TEss50E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=RKRZ8ljE; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="RKRZ8ljE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1761810765; x=1793346765; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4brPCS6Z+GhMLQ+QXdncx2uLcqx1yYNpz/2tWj5/whk=; b=RKRZ8ljEKx7Bn4rZ4Vz0EPwiVwoIUnh5ZiNfHldMd5Si7mfX1rgBL201 TBtvMhRZ0iV8oRIj69ZP5NZmWE6QGKsFqjQUsqlmv1fpjsSFVoJpvjP7C TFw+BeFxhXgm17EWL7nbS3OvUZlVOsEi5/w6SYM9y0dIC6fLVxQmZL0Y9 eRnTqMUpICEr0B8mjQ1pb8VWI7jU8Bpwf42Df+kpHS5Xu3LZU+sqtZpnA qSLLrHxGVjhROSeaOzJVV0ZbniGKf2ZPmkvekrTEzYg4TIk6QRwSL9Vsz NeOKw5Lc5fFHWrbtTpQBS5JLxdIjPHDxIee0lY0F+1sBOdPFHGoYKZr0R A==; X-CSE-ConnectionGUID: GIlKJHtsT5WfM3AzSiISvg== X-CSE-MsgGUID: saPEV6GpTTSfiOHD5Sbi4A== X-IronPort-AV: E=Sophos;i="6.19,266,1754982000"; d="scan'208";a="54760039" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2025 00:52:44 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.87.71) by chn-vm-ex4.mchp-main.com (10.10.87.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.29; Thu, 30 Oct 2025 00:52:30 -0700 Received: from DEN-DL-M31836.microchip.com (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Thu, 30 Oct 2025 00:52:28 -0700 From: Horatiu Vultur To: , , , , , , CC: , , Horatiu Vultur Subject: [PATCH net v3 2/2] net: phy: micrel: lan8842 errata Date: Thu, 30 Oct 2025 08:49:41 +0100 Message-ID: <20251030074941.611454-3-horatiu.vultur@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251030074941.611454-1-horatiu.vultur@microchip.com> References: <20251030074941.611454-1-horatiu.vultur@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add errata for lan8842. The errata document can be found here [1]. This is fixing the module 7 ("1000BASE-T PMA EEE TX wake PHY-side shorted center taps") [1] https://ww1.microchip.com/downloads/aemDocuments/documents/UNG/ProductD= ocuments/Errata/LAN8842-Errata-DS80001172.pdf Fixes: 5a774b64cd6a ("net: phy: micrel: Add support for lan8842") Reviewed-by: Andrew Lunn Signed-off-by: Horatiu Vultur --- drivers/net/phy/micrel.c | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 504c715b7db90..b0f5941fddb0a 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -2835,6 +2835,13 @@ static int ksz886x_cable_test_get_status(struct phy_= device *phydev, */ #define LAN8814_PAGE_PCS_DIGITAL 2 =20 +/** + * LAN8814_PAGE_EEE - Selects Extended Page 3. + * + * This page contains EEE registers + */ +#define LAN8814_PAGE_EEE 3 + /** * LAN8814_PAGE_COMMON_REGS - Selects Extended Page 4. * @@ -5952,6 +5959,9 @@ static int lan8842_probe(struct phy_device *phydev) =20 #define LAN8814_POWER_MGMT_VAL5 LAN8814_POWER_MGMT_B_C_D =20 +#define LAN8814_EEE_WAKE_TX_TIMER 0x0e +#define LAN8814_EEE_WAKE_TX_TIMER_MAX_VAL 0x1f + static int lan8842_erratas(struct phy_device *phydev) { int ret; @@ -6023,9 +6033,16 @@ static int lan8842_erratas(struct phy_device *phydev) if (ret < 0) return ret; =20 - return lanphy_write_page_reg(phydev, LAN8814_PAGE_POWER_REGS, - LAN8814_POWER_MGMT_MODE_14_100BTX_EEE_TX_RX, - LAN8814_POWER_MGMT_VAL4); + ret =3D lanphy_write_page_reg(phydev, LAN8814_PAGE_POWER_REGS, + LAN8814_POWER_MGMT_MODE_14_100BTX_EEE_TX_RX, + LAN8814_POWER_MGMT_VAL4); + if (ret < 0) + return ret; + + /* Refresh time Waketx timer */ + return lanphy_write_page_reg(phydev, LAN8814_PAGE_EEE, + LAN8814_EEE_WAKE_TX_TIMER, + LAN8814_EEE_WAKE_TX_TIMER_MAX_VAL); } =20 static int lan8842_config_init(struct phy_device *phydev) --=20 2.34.1