From nobody Sun Feb 8 00:16:34 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9F4017B50F for ; Thu, 30 Oct 2025 06:47:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761806864; cv=none; b=IBalK/1NVY68AKxBtxASJ9g8euBcEgJhxe2BOxwge5agI6cfOD8nCKqHjj32FsN9QYHAUCsu0qMWMJJRtrIt55MLOXTK2wL7vyiCIUl3NIQJ4goYBJOWSToV9oTr4bdTqFGSNsXzqXZB5EocJvuGTzKK5PF5I/DDIoiss680kOw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761806864; c=relaxed/simple; bh=Me3DvE2ugI06H5NnuFqscw90MT7ZGQysOgv6CrNFg7c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pbM/MrW3D0luVObwbOhSfkdFA+BM6qx1Pp2QzwfHfs7mEZj+7SS3+ohwKYDcQIgCecnrMFf64S93fB+A8ZcqXlU2LfL4neMKXWv7VZ9oL8cxwJFiXK9KvVE6VLmZQVoRJ1ql8vm82EwCWc5qCs/M20PigVMI23szzbsRzzduQoU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Xzb/iaxs; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xzb/iaxs" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-7a4176547bfso697117b3a.2 for ; Wed, 29 Oct 2025 23:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761806862; x=1762411662; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Am9qB9+YZXgr5yZPmS0eVlJwMZhmLJXC12be2I9616g=; b=Xzb/iaxsuyLAEW7w2FsEl0n1/OdunvACjnQh157BAyjM53zFU8BfAcqqWmqSyNCibg Ed7SZNruy6V3HgTi2miNhDG3vE+MXp7qtR1W4d3eQEW/dQFGbaqjd8yV8JjwMGkfi3c9 WFWD5tzoXRCOaC7o05O1kh4bV7JaBtGA0TCJAYdmGh30h0PnxveZNPbek+yhOhXGT9Cr DoBG2Rjy5ZbgyEyN9q9JaOHH2LY86iRd/bGO5wBSeOadD2YpGAI205f2Mhqe/AWQwUC3 ZJfxqsnSI27j83LkDhn+lP/Ab69hDP+2QZ1EEeGkB1qItKA9M6CviK4CB9wtZUt4mNfC pj5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761806862; x=1762411662; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Am9qB9+YZXgr5yZPmS0eVlJwMZhmLJXC12be2I9616g=; b=cMnQVt67wqVRQeszg3Y3M+iDxGKHlgtqARDkfhQfVFLESmoWEwbO5I9CxkDzeOOj6u xcmUZVpSoGdrigPw8hpkZjLC6RqvVL+YZhIVmAMZyHtoxqszz+TgymqipePB3u9dKVfF szs0+5X6caD1kQbV44a7gixNtCzbrK0b9X4eoefpWjZLB+TFBWZZiuncXKaRghJFgcGI buSRRj81H+JAhyoFELWDGuZm2IyUFU3TQq5yA2st28STZ7KQmW2/x/32yEGP8EGOtfTD XpcHrKQ19E8RZ0KYXBNt4aMoE4rBoozRBt5ozMjWb+bKJah74jLUOrJgsE1utL3IWHbY ZS4g== X-Forwarded-Encrypted: i=1; AJvYcCUb9Ijo7cRThkVWVNvg6B4o8mDtmxKVL29chfZg09kG/B/qq1Ey+IMYKPh+KcGXNKazVJzkyPxhOxhwhI4=@vger.kernel.org X-Gm-Message-State: AOJu0YzoR3m+iQ2+rwgSA9gmPNFAUzRULRCp4LnqR2Kn6A/WMxESJW59 /JA7bJiywjX8ObZtUbYHCzm46T4GuZdNxvmKNIh8gnr1Dn836qOIPA7+ X-Gm-Gg: ASbGncvODzrdxQgfzIii6kBmOstW5qB3L2/AgApKxbceJ75LcDSC75lLoBGYLj4R/OX Yx7Ih/+vvbyHWuBW3EX1EKRHYG8MM/h85hhYzieuTs7tNUPUrdqRLBjTklxzi9458Ndt7XRXZBu IEkKeiWPycrjkM0o7Uc2gGMOimYe8AWdWZJFV7sgR3UAu6V0qiR2rymBbwJW4Xknfm8VMGz0MsL lyvF+15crJl9QAy74UdpQw779L3Fh1yPiRrM70TiLuZ7Vh5eE4CYtgXudo1XVcuWb7w4bhikfgZ T7BXzteMNwVYELrjzP/5/kymUEf7kw1IXtWvfCyYDvmATsuJRA8rHcKBFqDGYZrkc20QcT8YF19 DOVkBjN2yhbqet6uat5nI3fV9Bvw8W4U+T6P0E8hnQPU0rhk0GZDe X-Google-Smtp-Source: AGHT+IGoeDNjZsXbO3LdK/V2YvdvGX0ZgT9GuusUDEYT4fkoC2bi4mVxlbYzrfAWfqpRdk3dt9E7Mg== X-Received: by 2002:a05:6a20:3d86:b0:33b:625:36be with SMTP id adf61e73a8af0-34654ee8c72mr7062588637.38.1761806862086; Wed, 29 Oct 2025 23:47:42 -0700 (PDT) Received: from gmail.com ([2a09:bac5:1f0a:28::4:372]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7a414012c40sm17799563b3a.6.2025.10.29.23.47.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Oct 2025 23:47:41 -0700 (PDT) From: Qingfang Deng To: Namjae Jeon , Steve French , Sergey Senozhatsky , Tom Talpey , Ronnie Sahlberg , Hyunchul Lee , linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org Cc: netdev@vger.kernel.org Subject: [PATCH] ksmbd: server: avoid busy polling in accept loop Date: Thu, 30 Oct 2025 14:47:36 +0800 Message-ID: <20251030064736.24061-1-dqfext@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The ksmbd listener thread was using busy waiting on a listening socket by calling kernel_accept() with SOCK_NONBLOCK and retrying every 100ms on -EAGAIN. Since this thread is dedicated to accepting new connections, there is no need for non-blocking mode. Switch to a blocking accept() call instead, allowing the thread to sleep until a new connection arrives. This avoids unnecessary wakeups and CPU usage. Also remove: - TCP_NODELAY, which has no effect on a listening socket. - sk_rcvtimeo and sk_sndtimeo assignments, which only caused accept() to return -EAGAIN prematurely. Fixes: 0626e6641f6b ("cifsd: add server handler for central processing and = tranport layers") Signed-off-by: Qingfang Deng --- fs/smb/server/transport_tcp.c | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/fs/smb/server/transport_tcp.c b/fs/smb/server/transport_tcp.c index 7a1e3dcc2cde..57a6aa98e7de 100644 --- a/fs/smb/server/transport_tcp.c +++ b/fs/smb/server/transport_tcp.c @@ -46,11 +46,6 @@ static struct interface *alloc_iface(char *ifname); #define TCP_TRANS(t) ((struct tcp_transport *)container_of(t, \ struct tcp_transport, transport)) =20 -static inline void ksmbd_tcp_nodelay(struct socket *sock) -{ - tcp_sock_set_nodelay(sock->sk); -} - static inline void ksmbd_tcp_reuseaddr(struct socket *sock) { sock_set_reuseaddr(sock->sk); @@ -241,15 +236,10 @@ static int ksmbd_kthread_fn(void *p) mutex_unlock(&iface->sock_release_lock); break; } - ret =3D kernel_accept(iface->ksmbd_socket, &client_sk, - SOCK_NONBLOCK); + ret =3D kernel_accept(iface->ksmbd_socket, &client_sk, 0); mutex_unlock(&iface->sock_release_lock); - if (ret) { - if (ret =3D=3D -EAGAIN) - /* check for new connections every 100 msecs */ - schedule_timeout_interruptible(HZ / 10); + if (ret) continue; - } =20 if (!server_conf.max_ip_connections) goto skip_max_ip_conns_limit; @@ -455,10 +445,6 @@ static void tcp_destroy_socket(struct socket *ksmbd_so= cket) if (!ksmbd_socket) return; =20 - /* set zero to timeout */ - ksmbd_tcp_rcv_timeout(ksmbd_socket, 0); - ksmbd_tcp_snd_timeout(ksmbd_socket, 0); - ret =3D kernel_sock_shutdown(ksmbd_socket, SHUT_RDWR); if (ret) pr_err("Failed to shutdown socket: %d\n", ret); @@ -505,7 +491,6 @@ static int create_socket(struct interface *iface) release_sock(ksmbd_socket->sk); } =20 - ksmbd_tcp_nodelay(ksmbd_socket); ksmbd_tcp_reuseaddr(ksmbd_socket); =20 ret =3D sock_setsockopt(ksmbd_socket, @@ -529,9 +514,6 @@ static int create_socket(struct interface *iface) goto out_error; } =20 - ksmbd_socket->sk->sk_rcvtimeo =3D KSMBD_TCP_RECV_TIMEOUT; - ksmbd_socket->sk->sk_sndtimeo =3D KSMBD_TCP_SEND_TIMEOUT; - ret =3D kernel_listen(ksmbd_socket, KSMBD_SOCKET_BACKLOG); if (ret) { pr_err("Port listen() error: %d\n", ret); --=20 2.43.0