From nobody Mon Feb 9 15:26:36 2026 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52A0F32E122 for ; Thu, 30 Oct 2025 15:14:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761837285; cv=none; b=n7gg6wn8V0qrNDi5OC76idlMir4A4KtcmbkRMU38YNxw+/8QFsUToq7J0U+CsfDIXHVGoTRxneOzsJmtvO3mKdh7Aors1zrgkGCxlRHgopQC9e6U/x7zpCfw/qSbV8cxdZdSJF9hlb4mwQzdiXRvDZYXXvCn3nNqoGNhIpwnkgg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761837285; c=relaxed/simple; bh=WueqPrt9PcU5UOs3/n/eywvcdgK3zO0SwyWhjHm1VB8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=SohOStKqGi/C59UDUG9Fw99FkDJyH8x4HVMgqFrr2k2pb2lFW0UWt8zMm8XTm3hIRTsDxO/0UxjxiR8gZa/S3pLKhkxBiBDHFnmIZK4/m4n5/oJR4oahq+SL3EipIKWMdGtSiXKIL1cIdrUiXR8Oa8yKq3yMG1MMu2emDR8MZA0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--khtsai.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=tWhBEaKS; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--khtsai.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tWhBEaKS" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-b57cf8dba28so899181a12.1 for ; Thu, 30 Oct 2025 08:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1761837283; x=1762442083; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=lRXCLymhr/IzWTqsnVoHqbEbb803ekNgoGS0KjH34wQ=; b=tWhBEaKS73ObveaESw+PdHDH6y4fPqDXrb2+YBN1VG+yKtE4LtprxObnwLL0C55JT+ dSgBT5pVEbR8zF475n8zZHQvitrgO7Cu9/WhZ/pZDOfsXo5U7JmSdzdZJ49AYhi3fZ1O VsFWqVTnFo+Ivi1iN9uu/LPbCq6LHg0ZlDdBuFzQ2SskyfgAjDfeC6MB2zFxmVlZRgI9 VaqoapxkJgee5DR96PC5P5Y2q1vXtu0hpFQfeTWXSnOOo/U/pTAXRm4yfRNqD/B1BmQ6 7fPtbPZ0LKy5mJ+9JVIv0K8YnnxeEsaZ81hBqVPnf1s3ZouSluzGGmSg8nzCOQrwyYFG bu2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761837283; x=1762442083; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lRXCLymhr/IzWTqsnVoHqbEbb803ekNgoGS0KjH34wQ=; b=VNixfTJwAsBbvvUf8T+G5pLD3X4r9SjbuqXsnFTmZX1hVJ9QCZ7sqRdFYEthUNXnmz 7x7ND821RXrvCa2y5vVJ+H27K/Ou+1Il3QwrYrWuVvU9RTGDz0i2zwW/l+SrCWIUQSpu RcLjBRVHh23jkM5r1tEbVSCd3Q2upZtsFll+SWX2R2M8Lr/ihA94NC3CGZD6wtV8tEi/ PN5YHGb6Sk6rFd+50e1kYKuPFoKl+PPoMJhO8vM0TZWK/TnatWQaRVWiA0QFWJQY6BI/ vrAyRuEwRyBY9j6kZWxQ0gF4oP5H1UT0KF7pjf93VCuwUTMKTJlM2DQVNAsCTWV8Osj5 J6pQ== X-Forwarded-Encrypted: i=1; AJvYcCVQcnPhpGcluAyYsttXfXtZW5vAGnwFbbfVkYLqqbkx3ssI2mu9eru/ebAaJrY04X4QDJeRgdDNg3zmzVc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywm5JVrp7sgAc8Ys14wiZlgydoZEV6t5MIFjBzVKE+AbbV41qO8 NbYUDBgEXkQrTjwepxU/5m6JMVS51Kua975+Q5M7FnPBlFCPTFpXUWvCWWZo9N/Q7hJYzwhoeAs LURT+CQ== X-Google-Smtp-Source: AGHT+IEBtKmRUWaO2GNwcap42mmQ1ywV3rSvOmFQAJJPExluSwBKsC0Atoqd3JmNEkv44E2DXEhyBeksJfQ= X-Received: from plkg14.prod.google.com ([2002:a17:903:19ce:b0:290:d4c5:90ad]) (user=khtsai job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:1103:b0:290:dd1f:3d60 with SMTP id d9443c01a7336-2951a49de0amr928475ad.51.1761837283473; Thu, 30 Oct 2025 08:14:43 -0700 (PDT) Date: Thu, 30 Oct 2025 23:14:20 +0800 In-Reply-To: <20251030-auto-cleanup-v1-0-db30584fadfd@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251030-auto-cleanup-v1-0-db30584fadfd@google.com> X-Developer-Key: i=khtsai@google.com; a=ed25519; pk=abA4Pw6dY2ZufSbSXW9mtp7xiv1AVPtgRhCFWJSEqLE= X-Developer-Signature: v=1; a=ed25519-sha256; t=1761837277; l=2782; i=khtsai@google.com; s=20250916; h=from:subject:message-id; bh=WueqPrt9PcU5UOs3/n/eywvcdgK3zO0SwyWhjHm1VB8=; b=6ueaX8sq1lNgoMah3k+GxkT1TUasXnrHj6yuhEYnrosVPWFY9rHWt2WEtsp7xWojuHqzjsk+x cyKY86DIf2gA6j0Brz1NNbRKN1eTGaIaENcnoDgBq2Z8wvxGb8/I15C X-Mailer: b4 0.14.2 Message-ID: <20251030-auto-cleanup-v1-2-db30584fadfd@google.com> Subject: [PATCH 2/2] usb: gadget: f_loopback: Use auto-cleanup for usb_request From: Kuen-Han Tsai To: Greg Kroah-Hartman , Thinh Nguyen Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kuen-Han Tsai Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Refactor f_loopback.c to use auto-cleanup mechanism for usb_request allocations in alloc_requests(). The shared buffer between in_req and out_req is handled by nullifying in_req->buf before returning on usb_ep_queue failure, ensuring the buffer is only freed once by the out_req cleanup. Signed-off-by: Kuen-Han Tsai --- drivers/usb/gadget/function/f_loopback.c | 30 +++++++++++++---------------= -- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/drivers/usb/gadget/function/f_loopback.c b/drivers/usb/gadget/= function/f_loopback.c index 49b009a7d5d79285c2397c7aebb8c8fcd3b7dafb..cdf42d8b3d774e5324e83dc308a= a5caa265eac3b 100644 --- a/drivers/usb/gadget/function/f_loopback.c +++ b/drivers/usb/gadget/function/f_loopback.c @@ -8,6 +8,7 @@ =20 /* #define VERBOSE_DEBUG */ =20 +#include #include #include #include @@ -308,9 +309,8 @@ static inline struct usb_request *lb_alloc_ep_req(struc= t usb_ep *ep, int len) static int alloc_requests(struct usb_composite_dev *cdev, struct f_loopback *loop) { - struct usb_request *in_req, *out_req; int i; - int result =3D 0; + int result; =20 /* * allocate a bunch of read buffers and queue them all at once. @@ -318,16 +318,16 @@ static int alloc_requests(struct usb_composite_dev *c= dev, * for out transfer and reuse them in IN transfers to implement * our loopback functionality */ - for (i =3D 0; i < loop->qlen && result =3D=3D 0; i++) { - result =3D -ENOMEM; - - in_req =3D usb_ep_alloc_request(loop->in_ep, GFP_ATOMIC); + for (i =3D 0; i < loop->qlen; i++) { + struct usb_request *in_req __free(free_usb_request) =3D + usb_ep_alloc_request(loop->in_ep, GFP_ATOMIC); if (!in_req) - goto fail; + return -ENOMEM; =20 - out_req =3D lb_alloc_ep_req(loop->out_ep, loop->buflen); + struct usb_request *out_req __free(free_usb_request) =3D + lb_alloc_ep_req(loop->out_ep, loop->buflen); if (!out_req) - goto fail_in; + return -ENOMEM; =20 in_req->complete =3D loopback_complete; out_req->complete =3D loopback_complete; @@ -339,20 +339,16 @@ static int alloc_requests(struct usb_composite_dev *c= dev, =20 result =3D usb_ep_queue(loop->out_ep, out_req, GFP_ATOMIC); if (result) { + in_req->buf =3D NULL; ERROR(cdev, "%s queue req --> %d\n", loop->out_ep->name, result); - goto fail_out; + return result; } + retain_and_null_ptr(in_req); + retain_and_null_ptr(out_req); } =20 return 0; - -fail_out: - free_ep_req(loop->out_ep, out_req); -fail_in: - usb_ep_free_request(loop->in_ep, in_req); -fail: - return result; } =20 static int enable_endpoint(struct usb_composite_dev *cdev, --=20 2.51.1.851.g4ebd6896fd-goog