From nobody Mon Dec 15 19:00:33 2025 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4677D31076A for ; Wed, 29 Oct 2025 08:11:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761725480; cv=none; b=qFpSM/1opcqhM2uc4iPysaxeuxGkUz6ck3GsTfElJ1gdM8OE1vm3jfhqfGXXWN+n+Q0Ecc/pKr2thG6rVc19AzcpEA7SY7QztP6Wg4yw1tKUzqJKRapCRHQuBP9COE8QAAuD0TXWtdDb16udlQu5xSNANa4MEjJNT+l7uW1QbMg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761725480; c=relaxed/simple; bh=giZlxB/y1esW0KSceZAKpr2ebJTr4TN9pxOQBz199Ek=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=AE8xZ3DBHzVVHj+oOqbsh88uSHGYeNbhrbK2L6iusnMHgu1qOFFjdaZUGJ4qbH0mHgp8HPhbkgLIP3GBqwQOflXD6GILDj34iIfIqQDmaC7uEDpdIeT8tDApM8KQVUUeCd85aP2SyzRCX6CYI4DpRUSSpjaqWa+ib5ERimIF85k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=compal.corp-partner.google.com; spf=pass smtp.mailfrom=compal.corp-partner.google.com; dkim=pass (2048-bit key) header.d=compal-corp-partner-google-com.20230601.gappssmtp.com header.i=@compal-corp-partner-google-com.20230601.gappssmtp.com header.b=j809uwdQ; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=compal.corp-partner.google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=compal.corp-partner.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=compal-corp-partner-google-com.20230601.gappssmtp.com header.i=@compal-corp-partner-google-com.20230601.gappssmtp.com header.b="j809uwdQ" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-290dc630a07so50080315ad.1 for ; Wed, 29 Oct 2025 01:11:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=compal-corp-partner-google-com.20230601.gappssmtp.com; s=20230601; t=1761725478; x=1762330278; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cy9XTv2i4jQBLP7k+Sr4EyrGNjL9Wpf6xvz0spYyufM=; b=j809uwdQGy1tW+FjAk8rTUo5OEWdkBcxA74XWoMc7p6ewaMVUYf7SmupXpTV3/7111 zvXU+ZvAkpVHUUmYPvI8krdDYD0FtizABxhLNTJtQxJbaetNBeCquKhYzl4sVLyZti1W Loau9uQoCgmacZpo6bzro4AIrvAwGxa0FFxFcEXbtqHq9CDguuQ1aWMamZedxAX0Tl1u 4z+WQAz0KDrqu+V8BvPklsReKHGoApONjki0RNnViegcN4kAkQ9ONBzh/K8YTX5sIXt4 ekU03BToCcYQsuEjSZ3to9NSlnwpD9RoH+CYt0rqy6BqvrpBZvygIHiwBDVCLP8OH9T1 U1+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761725478; x=1762330278; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cy9XTv2i4jQBLP7k+Sr4EyrGNjL9Wpf6xvz0spYyufM=; b=b8Xazn33ct5wV7oNj/NLe2OSozYqMIObGLP68REavy61N23N2Jaywr5SiCCCO5vkT5 OK6ipEZnDi/jLCckGGkp65m4pHFIqHSGSfHhf0R2OE8LDp99V4Pyh/4/gQKFw4ggWm6w TOSPE6Z2tV+As6uLGbyatO4F56Tu+GvkN5VxVzdYY6tFMo6R6ISHZUWwhls9Q0y7QTbe o38b1AHKRMomnfenIFliV1yP0M1GiaU4YUbKeWaLVYLAvw0HZwLdIIp1x6/OWdlsO4Zx aZbVriF7o5077ap15EBWTTHIuvi6SyMYJsB1RhYZf7JmPGEDN8UxigXsaojQTNIKKIAp svww== X-Gm-Message-State: AOJu0YzKOtMrXoXlCI5KvDkRIQMhoK9ALeOFCpL9UxnhNaxovYmgWLkj 2SErKWWcF2R9IQ4okWnkKSr9IcU+4+I5RCAO3ME1sTtMi5cybCKCuvjyuWBT+LRo+qVzgmXE/We DKq5PD5rl6w== X-Gm-Gg: ASbGncu/VoNRLPxlANrQIXqqDnMFjMU4AinWmR9QmTdw+sNWxYopz8NWsVkkOJnTv7M WZit+ZXJPofrjVK26mkHRHRiDItq/DrVB9ooii4g5vz/y4JTi2hBkIiOSKo88iSPCgktSSN/CRQ 3WcotvHAu/Xj6fxAnmTLK+zFAhrCfxJHpvAVSPrAwiN9rVA2Dd4bEqJqXBDUFVMS/EFsSo2R71M GFfA0/csekWCv5y0l2ulka6KXPK49xclQ8vIMJaQnc8W3vjuXpIWpK6kbEVXiuwZ0LNKkjdl/JF J0v9BIpmJw6onc7TN18qI7ubupoEfI7/Ru89fqktOnM0YgbNijCvIxrgipLaWbDesERTLpFBaKl J2tB+SHH5e61zL61iLtLUhSHjbtN6rd5/sLe7NrywWfJe8uHedm9kS5K+gj2Mz1SAePN518yB/P dmSaVt7T75Lv9EIuCC4qQSZEr1hnZa8PyM5Vurw7yHyqUTS2ked5GN6VGUjVUdmnu9Nu3Ec4bW+ GI/g/QDMOwPGSDNboJmacEq X-Google-Smtp-Source: AGHT+IE47ekKNBF9kXK/AfwFXT2q/NNP+Zhgqx+yPTGDTly8eePWmvpucVyygnjntJlajk3c9jzzuA== X-Received: by 2002:a17:902:ea0d:b0:254:70cb:5b36 with SMTP id d9443c01a7336-294dedd0e80mr20877055ad.8.1761725478290; Wed, 29 Oct 2025 01:11:18 -0700 (PDT) Received: from ajye-OMEN-by-HP-Laptop-S.compal.com (61-219-175-100.hinet-ip.hinet.net. [61.219.175.100]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29498d23226sm143988155ad.49.2025.10.29.01.11.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Oct 2025 01:11:17 -0700 (PDT) From: Ajye Huang To: linux-kernel@vger.kernel.org Cc: Douglas Anderson , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, Ajye Huang , jazhan@google.com Subject: [PATCH v1 1/2] drm/panel-edp: Add override bpc quirk for generic edp Date: Wed, 29 Oct 2025 16:10:47 +0800 Message-Id: <20251029081048.162374-2-ajye_huang@compal.corp-partner.google.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20251029081048.162374-1-ajye_huang@compal.corp-partner.google.com> References: <20251029081048.162374-1-ajye_huang@compal.corp-partner.google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adding override bpc to EDP_PANEL_ENTRY3 quirk. Signed-off-by: Ajye Huang Reviewed-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-edp.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/pane= l-edp.c index 944c7c70de55..da3e8f223ec3 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -218,6 +218,9 @@ struct edp_panel_entry { =20 /** @override_edid_mode: Override the mode obtained by edid. */ const struct drm_display_mode *override_edid_mode; + + /** @override_bpc: Override the Bits per color obtained by edid. */ + unsigned int override_bpc; }; =20 struct panel_edp { @@ -586,6 +589,9 @@ static int panel_edp_get_modes(struct drm_panel *panel, bool has_override_edid_mode =3D p->detected_panel && p->detected_panel !=3D ERR_PTR(-EINVAL) && p->detected_panel->override_edid_mode; + bool has_override_bpc =3D p->detected_panel && + p->detected_panel !=3D ERR_PTR(-EINVAL) && + p->detected_panel->override_bpc; =20 /* probe EDID if a DDC bus is available */ if (p->ddc) { @@ -611,6 +617,9 @@ static int panel_edp_get_modes(struct drm_panel *panel, } else { num +=3D drm_edid_connector_add_modes(connector); } + + if (has_override_bpc) + connector->display_info.bpc =3D p->detected_panel->override_bpc; } =20 pm_runtime_mark_last_busy(panel->dev); @@ -1871,6 +1880,17 @@ static const struct panel_delay delay_80_500_e50_d50= =3D { .override_edid_mode =3D _mode \ } =20 +#define EDP_PANEL_ENTRY3(vend_chr_0, vend_chr_1, vend_chr_2, product_id, _= delay, _name, _bpc) \ +{ \ + .ident =3D { \ + .name =3D _name, \ + .panel_id =3D drm_edid_encode_panel_id(vend_chr_0, vend_chr_1, vend_chr_= 2, \ + product_id), \ + }, \ + .delay =3D _delay, \ + .override_bpc =3D _bpc \ +} + /* * This table is used to figure out power sequencing delays for panels that * are detected by EDID. Entries here may point to entries in the --=20 2.25.1 From nobody Mon Dec 15 19:00:33 2025 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41FB121FF3B for ; Wed, 29 Oct 2025 08:11:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761725496; cv=none; b=I8thqHhI3fxarmdcIoRSoIP+d421ey9FB1GfVNkoSO7O+3hDT9fonlyKovLk9qfCQcBunDNB2ooL2Do9EojxndGCNrMv9mpj9h8RtGbt/oe7MCmW67Vp2JYtBIxy1Wz9+v3teBF7Tzo2RpZ7K+Yb3FHNDHE5jfkKtxKK5v+CQGs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761725496; c=relaxed/simple; bh=xJP1n/a3C3nYIbNTN0ASn7af/rI7B9UEFbfidJwADik=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=M/N222C4ypPNg9ObOv/bwa3q56xptlxIykzd4gvXTZwdkmtIXapL1Fjgulm8+TU3iOlx7PKujInOknsce2os4v9/rhwt+yogqFXMElKkrM1QNZxb4uNKOTdm2V2dZ+h1Ta0510tBKJK1ZSgpcdNUs2dswnstF8U801NgqGxL4Hg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=compal.corp-partner.google.com; spf=pass smtp.mailfrom=compal.corp-partner.google.com; dkim=pass (2048-bit key) header.d=compal-corp-partner-google-com.20230601.gappssmtp.com header.i=@compal-corp-partner-google-com.20230601.gappssmtp.com header.b=RgmAvGzM; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=compal.corp-partner.google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=compal.corp-partner.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=compal-corp-partner-google-com.20230601.gappssmtp.com header.i=@compal-corp-partner-google-com.20230601.gappssmtp.com header.b="RgmAvGzM" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-b608df6d2a0so6375590a12.1 for ; Wed, 29 Oct 2025 01:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=compal-corp-partner-google-com.20230601.gappssmtp.com; s=20230601; t=1761725494; x=1762330294; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uPNxLxt9UFuIm8EyMGboZ19yWXNZhoYOkYVl+88dGJ8=; b=RgmAvGzMOccwjoGOZAu1oR9wp3SpZooIJqhUjEXJpo6iz+BfcQP1zQME7rwD6X/UK8 W1rDLDfD0gDnFcvuTXOpQLttfArWpkZwz0H2yQYxuwBcQKuT5T5SRc2B7clSa67C5IVv zbfohogqtckOPMceR4xFEbNw8ZZsCUh9RbQGMk4a/NiYIYpFQN754uYfq3KvuQzTzW90 /itcT0WB3iYlEPnkU4n83UJtxvqdhcLenZcYJGAbLpuDOn/jFO02hFWcD8DqRQoN4RHR L2rEkpAH5BGE8ZTO2Q1EIPttbp4aKfjTTaE7NnCuru8UVDyZhZIAPRMs4/ZItftvtHNb HALw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761725494; x=1762330294; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uPNxLxt9UFuIm8EyMGboZ19yWXNZhoYOkYVl+88dGJ8=; b=fK8tX74azUKkkCo5ib7ixAV+AAN2r2uU4QCN/o9oFb9CFwnTjukM1oSH3FUVeoR5DR DoAe/SgBL3icJ5+LhaSV6HZHjM28RIhHbzFNSJGJDmwsV2DrOIhHZk12ohQya0tOkfGN VvNA/E+/Ugk/0Sq4tHXwKuO6pgOur+oms6SRCAyiRAUyuuF8cc+Dk+fI10npYtZkMGDS RHJd/ES5Ko8j4xh2TjM/JGU5f9TdNOj9c3tO5FC9noQdG73MtTcYERbHLQCB+Qt7n3q3 kMczFtTet4iAS9OEFCveChf+WNu5O6gzoIqGSa2TVyIQ9tO7PxbQhwiUcfstRW2Sva4z yRVA== X-Gm-Message-State: AOJu0Yw2nwXT3FeMmsmVGUHpd8fcUH+Wgt4CZ9xG0blyegV9rGC5AC8N zvECKUwNQJZzqqANDS7aG5LMIVLIH/XwAuoNUFYAgtLlXC+2v8KgYMQZAZqmmdgHKhDWbMEMi+M L5tjnpv7t5Q== X-Gm-Gg: ASbGncuzuyzfbMWH6JKomA0PrCUSZEBC8kns0h6UjeSGPEl8mZLdqvFB9sJosW12J0u H6dsNU3F28jRXoSeBFxou5yB1ALdJYrxiQALXetioagXFmrOY53XFiFd9CUJLFB1CIw5oUNioGY q+J3TPe+Nr76jd4W/0vHMppvbupPcqoHX3DQKihBgAUxsyoTFxdXmWLQjx+PvO96Q0LsQaUnj4w WuQBCla1DmD05Pn8TXfts/d/9h3WbL+1W64/rC+CrlEPX+ppI/T5ndL5M1apeY5XQ0GAHo22mQn xdPlR5uOObg/Q4/8xCB4ILbb5d3ZpDOUiGbdpAQcaHAgQ6/xb7mAENDaNuOmYIhRtf/2LIxsLBN TSgjnLXagf8J/q/YrYD/KN4xRSDszrrlqhAxtYCY+PsS2xMEVST8qj2HOs+jJRlwaD/yqbhH0Ir yqFctu0TBiMcOoc9BfEqH6nVpK6YD2tVqUR3KX4+lzAwJ5sGvZjY4rRYXL0FWpc95NcXCqAY9I8 qz90qcipmy9w3SrpzTVKYkS X-Google-Smtp-Source: AGHT+IEMzPuQ84Yst9JnKoJdLmf5H7SKCpoyZzuKbvoGK7sUDl7n6fuflS9kU+3WtdCFpWiOXbuokQ== X-Received: by 2002:a17:902:e809:b0:290:9332:eebd with SMTP id d9443c01a7336-294dee0e654mr24011855ad.10.1761725494261; Wed, 29 Oct 2025 01:11:34 -0700 (PDT) Received: from ajye-OMEN-by-HP-Laptop-S.compal.com (61-219-175-100.hinet-ip.hinet.net. [61.219.175.100]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29498d23226sm143988155ad.49.2025.10.29.01.11.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Oct 2025 01:11:33 -0700 (PDT) From: Ajye Huang To: linux-kernel@vger.kernel.org Cc: Douglas Anderson , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, Ajye Huang , jazhan@google.com Subject: [PATCH v1 2/2] drm/panel-edp: Modify LQ116M1JW10 panel's bpc to 6 Date: Wed, 29 Oct 2025 16:10:48 +0800 Message-Id: <20251029081048.162374-3-ajye_huang@compal.corp-partner.google.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20251029081048.162374-1-ajye_huang@compal.corp-partner.google.com> References: <20251029081048.162374-1-ajye_huang@compal.corp-partner.google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The link training is failed when bpc value is 8. It sure seems like the panel simply doesn't like 8bpp, Changing the bpc to 6 allows link training to succeed. The 8bpc log shows that link training failed. 6bpc Reviewed-by: Douglas Anderson ---- rate_mhz: 1620 valid rates: 30 bit_rate_khz: 2399760, dp_rate_mhz: 1500, ti_sn_bridge_calc_min_dp_rate_idx= return: 1 8bpc ---- rate_mhz: 2160 valid rates: 30 bit_rate_khz: 3199680, dp_rate_mhz: 2000, ti_sn_bridge_calc_min_dp_rate_idx= return: 2 Link training failed, link is off. Disable the PLL if we failed. Signed-off-by: Ajye Huang --- drivers/gpu/drm/panel/panel-edp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/pane= l-edp.c index da3e8f223ec3..13755168cd75 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -2094,7 +2094,7 @@ static const struct edp_panel_entry edp_panels[] =3D { EDP_PANEL_ENTRY('S', 'H', 'P', 0x1511, &delay_200_500_e50, "LQ140M1JW48"), EDP_PANEL_ENTRY('S', 'H', 'P', 0x1523, &delay_80_500_e50, "LQ140M1JW46"), EDP_PANEL_ENTRY('S', 'H', 'P', 0x153a, &delay_200_500_e50, "LQ140T1JH01"), - EDP_PANEL_ENTRY('S', 'H', 'P', 0x154c, &delay_200_500_p2e100, "LQ116M1JW1= 0"), + EDP_PANEL_ENTRY3('S', 'H', 'P', 0x154c, &delay_200_500_p2e100, "LQ116M1JW= 10", 6), EDP_PANEL_ENTRY('S', 'H', 'P', 0x158f, &delay_200_500_p2e100, "LQ134Z1"), EDP_PANEL_ENTRY('S', 'H', 'P', 0x1593, &delay_200_500_p2e100, "LQ134N1"), =20 --=20 2.25.1