From nobody Mon Feb 9 11:29:52 2026 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6230E3446B5 for ; Wed, 29 Oct 2025 13:30:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761744650; cv=none; b=Ao32pTp3ba+ZPuB/eiQfOrRrOqLWeLor/1lhmnWXhZCYQUhASEz9JZS3trZpWG0Rr5srSf4nTdOlaAPFMGobFMq5cdPZLE6e5FgQ77KPwj2eb5QfTh6YIlbn8Ascpioh2B6gI5rUYkAuSilscmDXq+Cs7UkSVlRViJRHhAV8ogc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761744650; c=relaxed/simple; bh=kRHIbdbfnhVWw5i8K9kmqCMqIgSkq6c1b5MfkOrcekc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=f0Z4jROB1mwTF4FBz/u77Yv17TZD5T72F7AKwYCbISWqmfNZAmMSqWxNzyv1qIuL9eagxc457dYKJ2ITuXiaMZyWXZWA7DqSDfadP5X5XPDXwF1EeTSViQyXLvmDDk2I8jQy2Dvw62+QxnGf0koXGf9cHvCMHmi3z2blgswiASM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=J9SuWYbC; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="J9SuWYbC" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 5FBABC0DB01; Wed, 29 Oct 2025 13:30:25 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id B6CE9606E8; Wed, 29 Oct 2025 13:30:45 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 82E11117F80A2; Wed, 29 Oct 2025 14:30:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1761744644; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=lzv0r4HbW8ZPDlxxuNQc4DxHoOKfZX5QaG27pmKoI4k=; b=J9SuWYbCDfkuKUyM1KhZvr8jO8fSys1Ld/nGBbhDfz2+n9zRB4dKflK/kD7sBTb7K17/Fx YxYVDA2bIYONarVN1dwRGZtAHo2qPk/PPpOf3E5lquEpNPDGdBMFRkmea3h1wHXAJW6c+M QNSh1+T/vXYZB5HjXwsICm8U095MXr2pjZ9NHMp0AXVgfC1r0zrYtuMaVGuJXxDqoTbUZ0 mDXJDFlH1gCx9M07Qc6blxGlGMEdNE7A/W6jq7jN5cspnIxLyjpb4S6OuU7Gxx1wh4ZxiB nCWWbN7n0B7tmM4PkPSe+o9KdkYsUqS+//YxAbVEuVJ8pW5XReztbw5YnhB/+w== From: Louis Chauvet Date: Wed, 29 Oct 2025 14:30:22 +0100 Subject: [PATCH v2 12/32] drm/vkms: Introduce configfs for plane color encoding Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251029-vkms-all-config-v2-12-be20b9bf146e@bootlin.com> References: <20251029-vkms-all-config-v2-0-be20b9bf146e@bootlin.com> In-Reply-To: <20251029-vkms-all-config-v2-0-be20b9bf146e@bootlin.com> To: Haneen Mohammed , Simona Vetter , Melissa Wen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , jose.exposito89@gmail.com, Jonathan Corbet Cc: victoria@system76.com, sebastian.wick@redhat.com, victoria@system76.com, airlied@gmail.com, thomas.petazzoni@bootlin.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=5578; i=louis.chauvet@bootlin.com; h=from:subject:message-id; bh=kRHIbdbfnhVWw5i8K9kmqCMqIgSkq6c1b5MfkOrcekc=; b=owEBbQKS/ZANAwAKASCtLsZbECziAcsmYgBpAhbq6dPIKPQC1u+XPhmpbq22jb90+94b0IVxQ TNlx8lgkdGJAjMEAAEKAB0WIQRPj7g/vng8MQxQWQQgrS7GWxAs4gUCaQIW6gAKCRAgrS7GWxAs 4v4MD/9hRkM4jGPJ0wHcTHYF2Un73zUgv4H4IqRKs3KVb1mEeZhFvCL2StTsbUA+DdlpqQPN4ad 1+RlBll9GRKTXomk5MEY3N5fchsEVERQmk9JvIHhsLfs93dHHlvlGv9PSt7AA15Bm4O+mm06CGT ReMhWWuqQoYZBRf/8rdAwq5OfX/EiJyeUwTzOnZfJLK3L3gF6iWwRBfXX31YdCsBCA2DzUIwjLF Eie38uSgo5DsM67uukW3jqD3yH8/nVK0GFdFlO5J68UTdKydkZ62vgO/IfM2Po+tU787QBx30Wn lMkj+fdyODxU2A6buEqwZjRmbbOIx2EiNMtJJWpc0igWU9Bufvgh+06/f0IMsBX/WOpQSaHnNsT bQr50vKjAq8egjxrntIhPD76U2WVWDiJX4HgDz6Bp45i6PJhAf3IxOCCNiu4jMDa0pZYtfswqEW vuqkL7kKwyVxVEDRk7fDc+0kxUkNHVu2FjDFWSri51R+CIKzZQ6JMLDsZMXRTx4AXj6BA3hFVuE Wpzz26Fy/kyOCi/F5zWmog3IVJLQ6mamK+vHW9r66qer3PRmXZxIuhPlgGxYTWXA3mQZK5DLDm6 NRq2irlzzdbAEQj1qTTlP7yGDit3l0GXQYxslvu6FA3WGVc6RhLa+GLo6Yrhjf2yL4oC6Oy7Eun RBndah3f/RDFBGw== X-Developer-Key: i=louis.chauvet@bootlin.com; a=openpgp; fpr=8B7104AE9A272D6693F527F2EC1883F55E0B40A5 X-Last-TLS-Session-Version: TLSv1.3 To allows the userspace to test many hardware configuration, introduce a new interface to configure the available color encoding per planes. VKMS supports multiple color encoding, so the userspace can choose any combination. The supported color encoding are configured by writing a color encoding bitmask to the file `supported_color_encoding` and the default color encoding is chosen by writing a color encoding bitmask to `default_color_encoding`. Signed-off-by: Louis Chauvet --- Documentation/gpu/vkms.rst | 7 ++- drivers/gpu/drm/vkms/vkms_configfs.c | 98 ++++++++++++++++++++++++++++++++= ++++ 2 files changed, 104 insertions(+), 1 deletion(-) diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst index eac1a942d6c4..dab6811687a2 100644 --- a/Documentation/gpu/vkms.rst +++ b/Documentation/gpu/vkms.rst @@ -87,7 +87,7 @@ Start by creating one or more planes:: =20 sudo mkdir /config/vkms/my-vkms/planes/plane0 =20 -Planes have 4 configurable attributes: +Planes have 6 configurable attributes: =20 - type: Plane type: 0 overlay, 1 primary, 2 cursor (same values as those exposed by the "type" property of a plane) @@ -97,6 +97,11 @@ Planes have 4 configurable attributes: (same values as those exposed by the "rotation" property of a plane) - default_rotation: Default rotation presented to the userspace, same valu= es as possible_rotations. +- supported_color_encoding: Available encoding for a plane, as a bitmask: + 0x01 YCBCR_BT601, 0x02: YCBCR_BT709, 0x04 YCBCR_BT2020 (same values as t= hose exposed + by the COLOR_ENCODING property of a plane) +- default_color_encoding: Default color encoding presented to the userspac= e, same + values as supported_color_encoding =20 Continue by creating one or more CRTCs:: =20 diff --git a/drivers/gpu/drm/vkms/vkms_configfs.c b/drivers/gpu/drm/vkms/vk= ms_configfs.c index 7cc8ba315ef0..ee2e8d141f9e 100644 --- a/drivers/gpu/drm/vkms/vkms_configfs.c +++ b/drivers/gpu/drm/vkms/vkms_configfs.c @@ -439,16 +439,114 @@ static ssize_t plane_default_rotation_store(struct c= onfig_item *item, return count; } =20 +static ssize_t plane_supported_color_encodings_show(struct config_item *it= em, char *page) +{ + struct vkms_configfs_plane *plane; + unsigned int supported_color_encoding; + + plane =3D plane_item_to_vkms_configfs_plane(item); + + scoped_guard(mutex, &plane->dev->lock) { + supported_color_encoding =3D vkms_config_plane_get_supported_color_encod= ings(plane->config); + } + + return sprintf(page, "%u", supported_color_encoding); +} + +static ssize_t plane_supported_color_encodings_store(struct config_item *i= tem, + const char *page, size_t count) +{ + struct vkms_configfs_plane *plane =3D plane_item_to_vkms_configfs_plane(i= tem); + int ret, val =3D 0; + + ret =3D kstrtouint(page, 10, &val); + if (ret) + return ret; + + /* Should be a supported value */ + if (val & ~(BIT(DRM_COLOR_YCBCR_BT601) | + BIT(DRM_COLOR_YCBCR_BT709) | + BIT(DRM_COLOR_YCBCR_BT2020))) + return -EINVAL; + /* Should at least provide one color range */ + if ((val & (BIT(DRM_COLOR_YCBCR_BT601) | + BIT(DRM_COLOR_YCBCR_BT709) | + BIT(DRM_COLOR_YCBCR_BT2020))) =3D=3D 0) + return -EINVAL; + + scoped_guard(mutex, &plane->dev->lock) { + /* Ensures that the default rotation is included in supported rotation */ + if (plane->dev->enabled) + return -EINVAL; + + vkms_config_plane_set_supported_color_encodings(plane->config, val); + } + + return count; +} + +/* Plane default_color_encoding : vkms//planes//default_col= or_encoding */ + +static ssize_t plane_default_color_encoding_show(struct config_item *item,= char *page) +{ + struct vkms_configfs_plane *plane; + unsigned int default_color_encoding; + + plane =3D plane_item_to_vkms_configfs_plane(item); + + scoped_guard(mutex, &plane->dev->lock) { + default_color_encoding =3D vkms_config_plane_get_default_color_encoding(= plane->config); + } + + return sprintf(page, "%u", default_color_encoding); +} + +static ssize_t plane_default_color_encoding_store(struct config_item *item, + const char *page, size_t count) +{ + struct vkms_configfs_plane *plane =3D plane_item_to_vkms_configfs_plane(i= tem); + int ret, val =3D 0; + + ret =3D kstrtouint(page, 10, &val); + if (ret) + return ret; + + /* Should be a supported value */ + if (val & ~(BIT(DRM_COLOR_YCBCR_BT601) | + BIT(DRM_COLOR_YCBCR_BT709) | + BIT(DRM_COLOR_YCBCR_BT2020))) + return -EINVAL; + /* Should at least provide one color range */ + if ((val & (BIT(DRM_COLOR_YCBCR_BT601) | + BIT(DRM_COLOR_YCBCR_BT709) | + BIT(DRM_COLOR_YCBCR_BT2020))) =3D=3D 0) + return -EINVAL; + + scoped_guard(mutex, &plane->dev->lock) { + /* Ensures that the default rotation is included in supported rotation */ + if (plane->dev->enabled) + return -EINVAL; + + vkms_config_plane_set_default_color_encoding(plane->config, val); + } + + return count; +} + CONFIGFS_ATTR(plane_, type); CONFIGFS_ATTR(plane_, name); CONFIGFS_ATTR(plane_, supported_rotations); CONFIGFS_ATTR(plane_, default_rotation); +CONFIGFS_ATTR(plane_, supported_color_encodings); +CONFIGFS_ATTR(plane_, default_color_encoding); =20 static struct configfs_attribute *plane_item_attrs[] =3D { &plane_attr_type, &plane_attr_name, &plane_attr_supported_rotations, &plane_attr_default_rotation, + &plane_attr_supported_color_encodings, + &plane_attr_default_color_encoding, NULL, }; =20 --=20 2.51.0