From nobody Sun Dec 14 19:54:47 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6572E345753; Wed, 29 Oct 2025 17:57:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761760626; cv=none; b=ETvHJITsxlKMkYZ6u714N/BTOQvmkHZX9k3na4mSQvDohKZ4eHveJxwsmGDMoFrzTsp9w5URJtkR11x/GDNJ0ckyFxOjvloz62HM8+im6wrHEzFDjAwgadhKPeSFqXHRlFFhOAQS2Xg2Ir6JzaCH4TyWkr1bHMG4n3P+5KVaqXI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761760626; c=relaxed/simple; bh=Ra0i+Wp3K8/16SuE0WP8++cHCg9npNLPkxIz/SvpPzw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PtAOsOAYw6vPVAgTA5hwcI7csmi0RxG2XnxjfT6cz5jqg2U15ERzuQkWCtjEXUZ0k/5gKP+qCJU2f1ibb6FER5fctWhd7WarmI3CLSH7EacKL+lolzV3qrwEMELdfGTcvAsXap4QkfdeGDqtHkuRqRiaOCBcz4i3sLMhMm9vQRw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=kcRqOuMe; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="kcRqOuMe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1761760622; bh=Ra0i+Wp3K8/16SuE0WP8++cHCg9npNLPkxIz/SvpPzw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=kcRqOuMexzz5qgpkcAXBFkVxcpKq2VzLU6/CMOIRabhxUj/XMGRU5pLMMjKKhXQPF 1j1B1/shxucmhUvZOEaOLPQ5cMX9cKwusGAJQGNVj1QmNInfCiAz6SzgGc/swIYU1C sJSjI689ENcryzqcp9kZ5UdiozyO6jeJ1kNhLqG7B8ZNm+2MR6nXNlaszOvTsWQE0d aOecjHoZ2653hb33Ymz2B0J7sigsV2gOYwbLC1cdNckvl5JzlLXXEhJH5r7kdLU3r6 WDSKJn+rlqm2nZWCUOY2HCs+x4z28KA9QuhsD0GWinmxkf1FwvVw5Bx3Zvqnockyeh +w5IBH9rLKNyw== Received: from jupiter.universe (dyndsl-091-248-085-053.ewe-ip-backbone.de [91.248.85.53]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: sre) by bali.collaboradmins.com (Postfix) with ESMTPSA id 9AF3917E1396; Wed, 29 Oct 2025 18:57:02 +0100 (CET) Received: by jupiter.universe (Postfix, from userid 1000) id 1E6D048004C; Wed, 29 Oct 2025 18:57:02 +0100 (CET) From: Sebastian Reichel Date: Wed, 29 Oct 2025 18:56:42 +0100 Subject: [PATCH v4 3/9] PCI: dw-rockchip: Move devm_phy_get out of phy_init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251029-rockchip-pcie-system-suspend-v4-3-ce2e1b0692d2@collabora.com> References: <20251029-rockchip-pcie-system-suspend-v4-0-ce2e1b0692d2@collabora.com> In-Reply-To: <20251029-rockchip-pcie-system-suspend-v4-0-ce2e1b0692d2@collabora.com> To: Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Philipp Zabel , Jingoo Han , Shawn Lin Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Sebastian Reichel X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1528; i=sebastian.reichel@collabora.com; h=from:subject:message-id; bh=Ra0i+Wp3K8/16SuE0WP8++cHCg9npNLPkxIz/SvpPzw=; b=owJ4nAFtApL9kA0DAAoB2O7X88g7+poByyZiAGkCVW35BAkuWyyv4n1/D8lG9T4dxxXpLX84S lQ0yAAwPOYTe4kCMwQAAQoAHRYhBO9mDQdGP4tyanlUE9ju1/PIO/qaBQJpAlVtAAoJENju1/PI O/qacykP/3VQwPyTdZ8x+76VWzJjNmgurwAKulw8T/aBbWtjucZPQGoNo/2j7kseMHRtLpy9PAQ otVtaSht4MXeexlxjS9XYupUE/UoMsxdYJE9KVxP6tAMeiJow3gTP6SZe3SAGWjApf+Fmv+Cc30 R/s8pDIHeehYL7x7ZnlgVdSqAyktmwkLSwAHo3eGpXIW5sbb6dBi0/7JD7y6gb6I9Jnl8tvhAVs 2Z0tGCXYN1X9SLU1G8AYHpsg4OK4ixjbZdctR7Q9JqTttY2IKJKEJVvP9uspBokz8nEfAoJYHws TpvMNSPTjnSsbbjFE2bS2DTIqXMQ5EfgcY/DuTLA0lPXnLNqaf8z8tJt887yKCfGnosN5E1kJgt BmtuAQl9UFIzqGNDsWkpzcBAw0lBdUKkiBKBO5FVYPAJBi6DWQZZZrGAtEMq4Sdh9UovwgnojVk 3p9k3BRVr2WlEY6oWq5k0aAWFUHLz6yZt4VYyOufjivuA/FPaHzr9EyFGs1Ksi5GrY1FSAg6O71 UEEptPqAbq6QyI3Loo2gINJRQTAIH53Yw55OI+HhG3lOvkDi93bi3Zu1ib9AHmm6qwwyzVU1yzS GnIxwNiKnmKNi8cMoE48TeKWX0JJjKXYYp0yc5yS3uw18YTvWW0KseWScxW5Izrta8l2UMv3sPb fKtOu0VcMxB3pY/KM7+wn4g== X-Developer-Key: i=sebastian.reichel@collabora.com; a=openpgp; fpr=EF660D07463F8B726A795413D8EED7F3C83BFA9A By moving devm_phy_get() to the probe routine, rockchip_pcie_phy_init() can be used to re-initialize the PCIe PHY, which is for example needed after a system suspend/resume cycle. Signed-off-by: Sebastian Reichel --- drivers/pci/controller/dwc/pcie-dw-rockchip.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/co= ntroller/dwc/pcie-dw-rockchip.c index e3d7792f7819..8e584016e244 100644 --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c @@ -425,14 +425,8 @@ static int rockchip_pcie_resource_get(struct platform_= device *pdev, =20 static int rockchip_pcie_phy_init(struct rockchip_pcie *rockchip) { - struct device *dev =3D rockchip->pci.dev; int ret; =20 - rockchip->phy =3D devm_phy_get(dev, "pcie-phy"); - if (IS_ERR(rockchip->phy)) - return dev_err_probe(dev, PTR_ERR(rockchip->phy), - "missing PHY\n"); - ret =3D phy_init(rockchip->phy); if (ret < 0) return ret; @@ -674,6 +668,13 @@ static int rockchip_pcie_probe(struct platform_device = *pdev) "failed to enable vpcie3v3 regulator\n"); } =20 + rockchip->phy =3D devm_phy_get(dev, "pcie-phy"); + if (IS_ERR(rockchip->phy)) { + ret =3D PTR_ERR(rockchip->phy); + dev_err_probe(dev, ret, "missing PHY\n"); + goto disable_regulator; + } + ret =3D rockchip_pcie_phy_init(rockchip); if (ret) goto disable_regulator; --=20 2.51.0