From nobody Sun Feb 8 12:20:47 2026 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 078DE25A62E for ; Tue, 28 Oct 2025 17:28:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761672521; cv=none; b=r5tLrBgI7o8/HTdeEcLRJnYbyWPqqbTf4d8zNlVrY2/NKW3HyxVlXO033Ui1yOzlZtsBAEmp1EEpD9TfxFV2gS2XW1CPyu92JZrDY4zHhWFZjegAdUZnIartD2/B5SI7TdjVmhdVoMR1D/1F7xzHArQpwhhE3Ax5lraJYrKqYyk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761672521; c=relaxed/simple; bh=/vI3WWLhioT2cdRqkCZiQHeFoXA5LZnnSbuAX4SgWfA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=neyostW5Qlyca3jPZoSX7W4xHLYFaEgZr9rtJBcyEdsAz7mQ+taQj5Leos4TNnim8S8kbkU4/iw3l4iaHKcQVnWXNs39IuY5QsQt0MnzMg+oWh+fEbQuPlXVmUFsqz9uhn0cBtZBEgJDhI0ckjxIb4BJ2iljEdGTu7l+KjZ6ixs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from DESKTOP-L0HPE2S (unknown [114.245.38.183]) by APP-03 (Coremail) with SMTP id rQCowAC3Ol9A_QBpSuWKBA--.610S2; Wed, 29 Oct 2025 01:28:32 +0800 (CST) From: Haotian Zhang To: Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, Linus Walleij , Haotian Zhang Subject: [PATCH] regulator: fixed: fix GPIO descriptor leak on register failure Date: Wed, 29 Oct 2025 01:28:28 +0800 Message-ID: <20251028172828.625-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: rQCowAC3Ol9A_QBpSuWKBA--.610S2 X-Coremail-Antispam: 1UD129KBjvdXoWruFWrZFykAF1UKw1xGF13twb_yoWkJFX_Gr yY9a92grZ29r4rCw48AF4avrySyF1DGay3Jr4FgrWfK34DZF15Jas7Zr9xCr4DXw4DJFyD ZFnrXFW7Zry3WjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbcAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr0_Gr 1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkF7I0En4kS14v26r12 6r1DMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI 0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y 0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxV WUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1l IxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjfUehL0UUUUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiDAgJA2kA275RWAAAsL Content-Type: text/plain; charset="utf-8" In the commit referenced by the Fixes tag, devm_gpiod_get_optional() was replaced by manual GPIO management, relying on the regulator core to release the GPIO descriptor. However, this approach does not account for the error path: when regulator registration fails, the core never takes over the GPIO, resulting in a resource leak. Add gpiod_put() before returning on regulator registration failure. Fixes: 5e6f3ae5c13b ("regulator: fixed: Let core handle GPIO descriptor") Signed-off-by: Haotian Zhang --- drivers/regulator/fixed.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c index 1cb647ed70c6..a2d16e9abfb5 100644 --- a/drivers/regulator/fixed.c +++ b/drivers/regulator/fixed.c @@ -334,6 +334,7 @@ static int reg_fixed_voltage_probe(struct platform_devi= ce *pdev) ret =3D dev_err_probe(&pdev->dev, PTR_ERR(drvdata->dev), "Failed to register regulator: %ld\n", PTR_ERR(drvdata->dev)); + gpiod_put(cfg.ena_gpiod); return ret; } =20 --=20 2.50.1.windows.1