From nobody Wed Dec 17 14:09:09 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D76A9302143; Tue, 28 Oct 2025 10:05:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761645926; cv=none; b=bCYI8ybgqM9Gr0xmmWrYNpQb6D/xE+A+zCnVJQGLMFyfG3ShL7Y9ykfsGp6hivouHQI7enwiG6fyTxC2CHSeRen1axi62dcjhIUTIbZueZEPyivifkM+VFofCjnVw29RoNnWLn+IlpOYVq/jm5u2owzeRfi8SrOaGN3PFm+wkxQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761645926; c=relaxed/simple; bh=TfW/tywFiRgcc0zHJ++gyx/6TvQ8+E3j1OKY3czA0Jk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CtJ7KcPnxiIxHcsIPWD0ZDYy+wFgEGoUYE1xVs+1bgogsdwBiDCdP7eXkU4AUrs1loZbIBP0TN2v2J6PIbG0QIV+l+6682eiYYsRNCE8cBPdXQn1Xzr4DK7+hicb5c7Jm4QznDSVUZLkr0FKDUgg45TA81R5PUWUblfmN/m1rrE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V4x9RZLd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V4x9RZLd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 509C2C116B1; Tue, 28 Oct 2025 10:05:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761645925; bh=TfW/tywFiRgcc0zHJ++gyx/6TvQ8+E3j1OKY3czA0Jk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V4x9RZLdIKkGYFssGzVS5imlOjLkTcnWQtzdWBnNcs1N8nT5SZnAkEmSeRUCv1IQi Eu7Ps1wf/Kiyp22faeVDqi6FfUMG2xhSmvHPHqn3IQjN03KSSX4DrR0fYWxytA8bsz Dhmlush1lyIjr/7DgEfdnjt74llmbN7HvLUXVnwKFHZ0A8l908+F871P3qdH/mscW5 A1YlFujrZrD9QaMv6ie25uFz/akUUUZrD5LDDRmJXKOByx4EP1gWqbPuoBT8M3to1Y fqHfIAV37cBM5ySXxZNJS2Ndeq/1P8vg/NFebw43PyVzIjKlhRkutpXcVw+1pAXjB8 M+6k/nwvmTP1g== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vDga0-0000000014i-3i9z; Tue, 28 Oct 2025 11:05:28 +0100 From: Johan Hovold To: Minghsiu Tsai , Houlong Wei , Andrew-CT Chen Cc: Mauro Carvalho Chehab , Matthias Brugger , AngeloGioacchino Del Regno , Tiffany Lin , Yunfei Dong , Nicolas Dufresne , linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH v2 1/2] media: mediatek: mdp: fix device leak on probe Date: Tue, 28 Oct 2025 11:04:53 +0100 Message-ID: <20251028100454.4086-2-johan@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251028100454.4086-1-johan@kernel.org> References: <20251028100454.4086-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the reference taken when looking up the VPU firmware device during probe on probe failure (e.g. probe deferral) and on driver unbind. Fixes: c8eb2d7e8202 ("[media] media: Add Mediatek MDP Driver") Cc: stable@vger.kernel.org # 4.10 Cc: Minghsiu Tsai Signed-off-by: Johan Hovold --- drivers/media/platform/mediatek/mdp/mtk_mdp_core.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mediatek/mdp/mtk_mdp_core.c b/drivers/m= edia/platform/mediatek/mdp/mtk_mdp_core.c index 80fdc6ff57e0..5c7dcf4090f4 100644 --- a/drivers/media/platform/mediatek/mdp/mtk_mdp_core.c +++ b/drivers/media/platform/mediatek/mdp/mtk_mdp_core.c @@ -198,7 +198,7 @@ static int mtk_mdp_probe(struct platform_device *pdev) VPU_RST_MDP); if (ret) { dev_err(&pdev->dev, "Failed to register reset handler\n"); - goto err_m2m_register; + goto err_put_vpu; } =20 platform_set_drvdata(pdev, mdp); @@ -206,7 +206,7 @@ static int mtk_mdp_probe(struct platform_device *pdev) ret =3D vb2_dma_contig_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(32)); if (ret) { dev_err(&pdev->dev, "Failed to set vb2 dma mag seg size\n"); - goto err_m2m_register; + goto err_put_vpu; } =20 pm_runtime_enable(dev); @@ -214,6 +214,8 @@ static int mtk_mdp_probe(struct platform_device *pdev) =20 return 0; =20 +err_put_vpu: + put_device(&mdp->vpu_dev->dev); err_m2m_register: v4l2_device_unregister(&mdp->v4l2_dev); =20 @@ -241,6 +243,7 @@ static void mtk_mdp_remove(struct platform_device *pdev) struct mtk_mdp_comp *comp, *comp_temp; =20 pm_runtime_disable(&pdev->dev); + put_device(&mdp->vpu_dev->dev); vb2_dma_contig_clear_max_seg_size(&pdev->dev); mtk_mdp_unregister_m2m_device(mdp); v4l2_device_unregister(&mdp->v4l2_dev); --=20 2.51.0