From nobody Sat Feb 7 17:56:02 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77F2329AAE3 for ; Tue, 28 Oct 2025 06:08:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761631728; cv=none; b=mKwa9u2TA88siGn05h6dYtwxzPp+0I2o0Yv4j8WDGzU74PH37dM867bmXeuKPuRmmS1jETP1wXthxqNxZjJH+H6aY5hZIWBcdU9k+hbNaFNR+jr3DS/Duz0FPv5U9F2f3M8pgbZ/1Lw1jX9FNe4NRzAdp4Y90G92y6oDOs4ds5o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761631728; c=relaxed/simple; bh=q7Tc2QsMBaN+HdSGE3XhX0GNjhdhA21Ns2bjotQEtBA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=a0ah4iahGrdsq68Ig313Ff8b5EAxEsMRFilaZLi8uiVn6XeNqYB4trgxzlSyES/pq8/dxMX+e8emhHVgeT6yY2ia0wYONLUUmkOb/yCLvZIBd97d3uOOMNQ71L0QErpQYk/xAR6OHqCfBMIoxcdEhL8Mr6P3GQ4qetgKsC491X0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BwVffNQz; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BwVffNQz" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-33ba5d8f3bfso4991411a91.3 for ; Mon, 27 Oct 2025 23:08:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761631727; x=1762236527; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EtQOQB0/xeiaea1mof+0CkoSu6y09kgD2fJAIO20kBU=; b=BwVffNQzNrjA44edQduAm31/Ty1+eD1ko+O4xUYxdOqVIm1Mcbq5LNZ51gZFDMx6oz yctWAtLsp8LlKZAQUrtgGHv/Y8h6qntuXD/bqkBiJTQCMoZYk805s1rJwaM+9VPs26mu EElDlKL01yxVt0sem3jv4wlmkEvUZKk6sm9HZDEuYja18cKdmkQavc9w5/nR4zlc8o9X bddjEKSReP54w+lofIR/6jTmQtVWEhrpWsPDlNaLlkhmpNG6oZe5UKEG3a6xojMM3NS6 m8xP8Iud3W/RU/JGX2luB62fvOYulnRbS7bX5QnMHtjbnQAeFDcpTIL4wF527QkBG6Ev DjWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761631727; x=1762236527; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EtQOQB0/xeiaea1mof+0CkoSu6y09kgD2fJAIO20kBU=; b=pgLiNPRhzab0BFoubuxya+mjHgRdaQpPBxewnbV5nuDuIEpOBvJg73XESuP7mPM9lN xSZIQgcuiqf3bLnZ3wPDgKPjSYkNFfmuMEYmlrLErbH9sDFz953pPWDWVL5jSMaAIFiK k8lcqKnEVHZlpfP4oI3Yr4LKGB9IFgyP78xsBmaWltZm8qaQrLThzlvZfTdWxs02519K w6xAAUI0i/Lx2+m7qloQJBrqj7qyZVZ4GgCwT8xMY7gpQUOCEfMf2/6Krir3JucqREIk QZM0SISQBdCYcbWoUR7sZIM34QsAi9UGPlrrjLKPVSCFPCK0Vx8yQOX9yCc2l6IKuxD6 HpKQ== X-Forwarded-Encrypted: i=1; AJvYcCW46+EOVOjVwS1icVXEohPWVjT+nOl+aVIdX883wvf7ZDu+6a+QfXutU5AF8MspwMpflKmCDYKW12cxBE4=@vger.kernel.org X-Gm-Message-State: AOJu0YwK0VZlKQv1IZqkD08/Sh/s9ItQAtuiNZfCHJOPkc/3/QxXqgtl LPMYchH5RqqPadI74vMvT1ejhceYBMxRGz36bUX79NURO3893O6g5cEfYDxCOXYyiFUaXQ== X-Gm-Gg: ASbGnctdlAH+wPfdR/DHgymqS4HUKJDlApMcFm6IZVueMwqLlBK8mrrzP2vefz9w/YV xK+MBdWs9g16qUU2SnUD/nsbVwwrkWTckhp8hWPp3NZiM8ATLDs7LEglNyygdUvGbJACmI6qvSV LtYOLaXaWhrLZIhdR130ZigTHpNS74H+fGBMF+1ynrpumEaLEBkNd6cjN7vmOTjiXoK8h880KsC tkP3hasgg5j2LVPSmOhQM0e/qX2siQF9zeUdu5wWu5FSQoIwBeUP2Ur+vOZW/Jp5OJC7xiAA7ss hAWJ2HKc1l47TAVRs5ZZx1x/lBTr6WPtOuNxvG6MxGIep2MtNWfeNo4ie4SY5KPijO3PeSS2v6o vJFhNvhep2+6OwA1jivu4Mw/BF0WPmHvOASUcOe6ixugxNWDQNne6vnsycntn+g63gplp6EZ51C yvOiRInOLl1+6mCjOR9OomUQ== X-Google-Smtp-Source: AGHT+IGM18PVXmk/Ly4QV9wJ4WdGZzC+O29UfRf1c8szMur4qUVhZWR85AkuIgff1YJgN9jGYRTafQ== X-Received: by 2002:a17:90b:58f0:b0:32e:2059:ee83 with SMTP id 98e67ed59e1d1-340279e5f8bmr3103225a91.7.1761631726760; Mon, 27 Oct 2025 23:08:46 -0700 (PDT) Received: from localhost.localdomain ([124.77.218.104]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-b71268bdb2dsm9533462a12.5.2025.10.27.23.08.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 27 Oct 2025 23:08:46 -0700 (PDT) From: Miaoqian Lin To: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com, stable@vger.kernel.org Subject: [PATCH] thermal: thermal_of: Fix device node reference leak in thermal_of_cm_lookup Date: Tue, 28 Oct 2025 14:08:29 +0800 Message-Id: <20251028060829.65434-1-linmq006@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In thermal_of_cm_lookup(), of_parse_phandle() returns a device node with its reference count incremented. The caller is responsible for releasing this reference when the node is no longer needed. Add of_node_put(tr_np) to fix the reference leaks. Found via static analysis. Fixes: 3fd6d6e2b4e8 ("thermal/of: Rework the thermal device tree initializa= tion") Cc: stable@vger.kernel.org Signed-off-by: Miaoqian Lin --- drivers/thermal/thermal_of.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c index 1a51a4d240ff..2bb1b8e471cf 100644 --- a/drivers/thermal/thermal_of.c +++ b/drivers/thermal/thermal_of.c @@ -284,8 +284,11 @@ static bool thermal_of_cm_lookup(struct device_node *c= m_np, int count, i; =20 tr_np =3D of_parse_phandle(child, "trip", 0); - if (tr_np !=3D trip->priv) + if (tr_np !=3D trip->priv) { + of_node_put(tr_np); continue; + } + of_node_put(tr_np); =20 /* The trip has been found, look up the cdev. */ count =3D of_count_phandle_with_args(child, "cooling-device", --=20 2.39.5 (Apple Git-154)