From nobody Mon Feb 9 02:13:19 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E444C221FA4 for ; Tue, 28 Oct 2025 00:39:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761611961; cv=none; b=Uf5PIgGjSec+097TRUKNBbH4xuXRpgGzwMo8fPH5dmDvCp8Wq7AKVFj9oBYTwqdIcILVKt59JD8JgEC2pCwpdCUChB2JglUpa3+11y+7EQO+V62p6K0XrQBekyxXxS6Yu2+LDdfO8pu13ppiQ5R35ueaIDIbfEAMvxS90vzDslo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761611961; c=relaxed/simple; bh=P2La+FoJZ35MJzEo8yVcVLSFzhQhJljTmUai3XD3wr8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D5//Etf50VsE/mM2qIu6vC+jDP5WzyfDoPix06TeuC6JGUUyMhfnNnPHJ1PdQqqKAZqCZzOMw+Mal2f1kdMqF0Sx4zkt8PdJtcCOU/3e+tG4yyhyRFlkoeOCJ1u1Q7WoWyO7xbcXP/PBkZY2SBy5Wx9tpzcMHNOoimx+M3/2/pA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kyLj3jlO; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kyLj3jlO" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-29470bc80ceso58873295ad.1 for ; Mon, 27 Oct 2025 17:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761611958; x=1762216758; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6e+TNG8HQKWjELTx3r9i/rdMStiwaJjw+wxw++IoG08=; b=kyLj3jlOXnyy+JK+pViciZ6OEQLzjc5aQXaTggD/u7s/4upxNm1YBBkEDpel0IUENC CsqKfBdlsIpvCNI7oklzKeImxuWjcB+TK9k8c8rl5VZpeZZNyiLtVIf/8MI8NYRqz7Rl fp/eL0lDfXXydXlsaM94g2XGwWgxmiWMSlJcLAdhKoR+4MvUVwwbhTMOqTDX4wmB3w8m GPgB0vp5hX3swmXuyonnYnvVsfXLyNxLM4ptt+L5+ukorSARSDoSySZ1Wbc+DAasiHaC QNStNfszdjt3bfrsynGehySUs4gUQE89JPNAm78p6MGar6FCXDNpWzSC/p+uPOvjE6/N eyxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761611958; x=1762216758; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6e+TNG8HQKWjELTx3r9i/rdMStiwaJjw+wxw++IoG08=; b=d0sfeDbmLA7nzWEuBUKHE/4VxYCINzOP2ueJFgKR9sbpJhUaCNjWTg8dnFweavvzdZ lbBl1jZMnv0Rp6n0oivF2tr63GWijNBDfKoGYkC/C9syDAAyJNplfjsFDkALjpYE1bcJ scg/0mSj+dGE40EX6xHdnu/adAPkn4DMKPkqyhWrOfk+c1ieWjUH+RBtAQxxs3GDKIVx lGl4DdtQInpEp0bmWLlLLqPy2Xa5eiZK7y7gA1leLkvRKNx/PdQuMs5LiWY6f8RCMlHB u27W+LHoHK/CJbpReCSam+d9z0wqL+PgeBd1TOEa8hbCz8tUnMgzTBxDYIyA0c9rLwYI O/sg== X-Forwarded-Encrypted: i=1; AJvYcCWY5eG70jmjg32u3FGh7hRE4nXjatdjOyZVzdIBMh6bDIA1RFPilNj3qyg+LiyRNWcvellz8aohRMmsLU0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2Fn9LJwAFJjcRI77aVpXi7IsSQ52+k4oZVlp78pFPe8CxmIwW lKltHkByK6ya9LydnNlufJKBEFGrvLENZzh/qlezhEBtsTYjAmGm400B X-Gm-Gg: ASbGncvRDUriR8qtEg51+g9u4dO0KvJbUzPhdJMWvRs2DC9Eky20HPYRTzrkkveL0Ux ZXCSTmGF7sJwoMptOpWhH4jKs3qCG2dpd9exSwbpVnCXg0sijkl4lS6W1lcwq6k+jPfvKoKA/Lk 8wJIjX/A7/VJaVHS/dkcYySaBpX7YgpqXyrfIKDdmi8oU5hkJKU7NgKY+vo9clFh9ZAAgpEvAVo /ZtOTO86crQPJwMNylz/K7be/xASGC0TCZZZwFI8ce+vLggc8Ptm22/PaMxw6RYY7O+L2fjAO4A gWG2zFa7dSTGUu5M4jshVoAJxnv3qnNAo5SGH04VHUWB7IL6tmh32DfoNG3/jc831DTZWJwvjMR xr/24HQCiUDrOoaSj6eoa/UDpDLtQ/+40cpDzUqnkAievfqfF/7YI6z8RlRI4UBTGmyHrfLcoZC c2p4FRz710Qw== X-Google-Smtp-Source: AGHT+IGvU4zqUoctToOTJAwyDs9+4diulCuRP+v5NnW7F2ld07v4djcWl4rSSI6JXslPZV+bpZFdZA== X-Received: by 2002:a17:902:ea0a:b0:271:fa2d:534c with SMTP id d9443c01a7336-294cc74e4dfmr14030645ad.22.1761611956679; Mon, 27 Oct 2025 17:39:16 -0700 (PDT) Received: from localhost ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29498cf3bbcsm94917065ad.15.2025.10.27.17.39.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 17:39:16 -0700 (PDT) From: Inochi Amaoto To: Han Gao , Icenowy Zheng , Vivian Wang , Yao Zi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Inochi Amaoto , Maxime Coquelin , Alexandre Torgue , Heiner Kallweit , Russell King , "Russell King (Oracle)" Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, sophgo@lists.linux.dev, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Yixun Lan , Longbin Li Subject: [PATCH v4 3/3] net: stmmac: dwmac-sophgo: Add phy interface filter Date: Tue, 28 Oct 2025 08:38:58 +0800 Message-ID: <20251028003858.267040-4-inochiama@gmail.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251028003858.267040-1-inochiama@gmail.com> References: <20251028003858.267040-1-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As the SG2042 has an internal rx delay, the delay should be removed when initializing the mac, otherwise the phy will be misconfigurated. Fixes: 543009e2d4cd ("net: stmmac: dwmac-sophgo: Add support for Sophgo SG2= 042 SoC") Signed-off-by: Inochi Amaoto Tested-by: Han Gao --- .../ethernet/stmicro/stmmac/dwmac-sophgo.c | 20 ++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sophgo.c b/drivers/n= et/ethernet/stmicro/stmmac/dwmac-sophgo.c index 3b7947a7a7ba..7f0ca4249a13 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sophgo.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sophgo.c @@ -7,11 +7,16 @@ =20 #include #include +#include #include #include =20 #include "stmmac_platform.h" =20 +struct sophgo_dwmac_data { + bool has_internal_rx_delay; +}; + static int sophgo_sg2044_dwmac_init(struct platform_device *pdev, struct plat_stmmacenet_data *plat_dat, struct stmmac_resources *stmmac_res) @@ -32,6 +37,7 @@ static int sophgo_sg2044_dwmac_init(struct platform_devic= e *pdev, static int sophgo_dwmac_probe(struct platform_device *pdev) { struct plat_stmmacenet_data *plat_dat; + const struct sophgo_dwmac_data *data; struct stmmac_resources stmmac_res; struct device *dev =3D &pdev->dev; int ret; @@ -50,11 +56,23 @@ static int sophgo_dwmac_probe(struct platform_device *p= dev) if (ret) return ret; =20 + data =3D device_get_match_data(&pdev->dev); + if (data && data->has_internal_rx_delay) { + plat_dat->phy_interface =3D phy_fix_phy_mode_for_mac_delays(plat_dat->ph= y_interface, + false, true); + if (plat_dat->phy_interface =3D=3D PHY_INTERFACE_MODE_NA) + return -EINVAL; + } + return stmmac_dvr_probe(dev, plat_dat, &stmmac_res); } =20 +static struct sophgo_dwmac_data sg2042_dwmac_data =3D { + .has_internal_rx_delay =3D true, +}; + static const struct of_device_id sophgo_dwmac_match[] =3D { - { .compatible =3D "sophgo,sg2042-dwmac" }, + { .compatible =3D "sophgo,sg2042-dwmac", .data =3D &sg2042_dwmac_data }, { .compatible =3D "sophgo,sg2044-dwmac" }, { /* sentinel */ } }; --=20 2.51.1