From nobody Sun Feb 8 09:10:18 2026 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4148325F7A5 for ; Mon, 27 Oct 2025 13:30:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761571825; cv=none; b=RiteJewfu26MIXFrDfu/yblIopMNyg0hpSJ/RNvz4ol5OhCQ9d8N5H3wdjDJvrwARRNlFRMK6sR7J9m5q3vw3EvuNIh+L0vKgPziqvEv0lK9wsFlvwXeSlbVbNPZCzxiMRlCn9x93Y0NWlvsq21/UyV0PnXGmF2hc3zY5g00LvI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761571825; c=relaxed/simple; bh=irpydtjBnNGkoYUkduEdVKqR1Dq2M0mmWm+e59RVSDs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lBLxc+AszJ6uxkM6JW0XdL/EzZPlVS1r0wZB9M+MTu8/TAJ/PXhXca1+vBYPdftMKQOiqcFJ7W8dGkoXDppKBDDF1OjWOdwEYR+VBS4Cqi/pg/FibQlu4ePwucSgy1M8sq/FOWC5VjlEr4BheH6vqKIkIKJqglUJnWsfAQJwgqw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=tPiPBn7X; arc=none smtp.client-ip=209.85.166.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="tPiPBn7X" Received: by mail-io1-f43.google.com with SMTP id ca18e2360f4ac-940f8a73275so541830939f.1 for ; Mon, 27 Oct 2025 06:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1761571822; x=1762176622; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WwBrji1LVVqX5QLhYIQg8MHPDU19g5B0S1hpvpp4hEc=; b=tPiPBn7X2yd1/B/lsF2mH6Jef2O2lF11qrqQoQ0OX4KrDNRUEAWqK5lHqlWZpakjwq hxcR4DwnEqPqK6TBCNCHUe12tTVhoBB4f/X4u2uJzFaL2fsBCoGEPhAqqRC7cASZoE8s 53of9LLSbmPxEz5CQ8aRNfxx9vDK/brH4xTPV7UCmlqCINzJs6gUJlHM+pb2JefDhsdp 2Id+lN2aRrayfXuYhtcm1UI3r03iLP5zKmesZbXrnVjn4Od9SHW7YtjjlEvjFw+LeFEu WfrR0LSxDXdwOE5nMFkwiZSz5+jcj7Htz4DCnk+ZWiH9+uNx+25VaqXF/VWxZUeirHSO hnxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761571822; x=1762176622; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WwBrji1LVVqX5QLhYIQg8MHPDU19g5B0S1hpvpp4hEc=; b=Cl1pPK1W6b7HCKWbB9jXk606oawRVE3+UUe+ONiiWzKQC4o8jh4/jMdMp8jEJpzP+w uAHavWwvZsWOozyoEPhpVr1qs3DVe5qPE9gM14RGSuDrO0ex4XIeHZr0mP6dcEyuuxI+ Qu4hKlaRVX0K59QcSd/nGwgxaAZiN7WLzATyWJoNxr/6YrgSdMcitAaX1ob62i0+ZgKQ lHzB426gSJtO0TukFjXpei63qWeMrawciAvXAWe5VuoXcVqASEcjXjwq23WLkYZaKTbj QRSWQf7dtIFIplHfUhuZ47LHsSk0O1Aij6SzHp5RURvltK/PUGmJLBt8xzXMQn1smbMA JeBQ== X-Forwarded-Encrypted: i=1; AJvYcCWeVyKf33tNXcrI3CFe+SAly5Mwd/BFlKCEwt+jmJjyO2Mtg+QxRSkXFi/2XZEC67fkis20apMZjZNnLCE=@vger.kernel.org X-Gm-Message-State: AOJu0YzowiFnoODuxY93fqlEKAEs7ciRKVTEXEZXqiiF9BjIBagLdH2C hVimvAml9BMRaXZ7p+5zK8n4/maosbMOhGvZn8FjjFFJmeApGMHp55uZ5ZVwwaUu1bk= X-Gm-Gg: ASbGncslL9ysWCXR2/rHBRKviyHMEpN/Cr/xibUHmSec6h56AzETkwZfhcSZ+PG5Xow n+5fzK3sbPwkIVBGQp3b4g+zlQ2gjR4t7TWtUPcEy0PLWclyvbbOBX/Ir/yOgG6MuLtY18avdrO 76BWJEj5CWaey29CbxdwrFf/UbC0uZQCLmQ0sxc1Ra+U/9O6UlbqC2tLdQ6I38+itwdBzYMvy4Z wEhhVAzA+h8iVtTq/wCk+gB3JcO8m8TmFF85+PRr9dVhl64lOqMasdSgUNbcVsFg9AY0Xj6an1M yCtlDoGQRXY+XHV+mAVBoH6zlFQQTAaAjirWUyGmf65KrH0rzKPMxxfDCR1r8p8DpYyfjlFY0Vf i+lRm0+N5jsU67SdVWGhAFpMy9neGRBMQ5qRtmfiGRWvWV57vf06/+7OqYt93nVf6XD5KqTXkip lCvuQmOCaWZZF2Q0dB4od+/aotcd7oWtULwzlBv0on7+0NKSV+F/+bYYbhlM1bogLp X-Google-Smtp-Source: AGHT+IEea/t006sDIUwyJirb8lhRy1y9vqvFLUYDpT5bn8joxV7TPLkwITOKKA0xlex/9Fj770b8Lw== X-Received: by 2002:a05:6602:1687:b0:93e:8c1e:cc5d with SMTP id ca18e2360f4ac-945b819d91amr15227739f.5.1761571821923; Mon, 27 Oct 2025 06:30:21 -0700 (PDT) Received: from zippy.localdomain (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-5aea78e2fd4sm3093057173.26.2025.10.27.06.30.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 06:30:21 -0700 (PDT) From: Alex Elder To: han.xu@nxp.com, broonie@kernel.org Cc: dlan@gentoo.org, Frank.li@nxp.com, guodong@riscstar.com, linux-spi@vger.kernel.org, imx@lists.linux.dev, spacemit@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li Subject: [PATCH v4 5/9] spi: fsl-qspi: add a clock disable quirk Date: Mon, 27 Oct 2025 08:30:03 -0500 Message-ID: <20251027133008.360237-6-elder@riscstar.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20251027133008.360237-1-elder@riscstar.com> References: <20251027133008.360237-1-elder@riscstar.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The SpacemiT K1 SoC QSPI implementation needs to avoid shutting off the clock when changing its rate. Add a new quirk to indicate that disabling and enabling the clock should be skipped when changing its rate. Reviewed-by: Frank Li Signed-off-by: Alex Elder --- v4: - Added Frank Li's Reviewed-by drivers/spi/spi-fsl-qspi.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-fsl-qspi.c b/drivers/spi/spi-fsl-qspi.c index 1944e63169d36..2c030dd6facc7 100644 --- a/drivers/spi/spi-fsl-qspi.c +++ b/drivers/spi/spi-fsl-qspi.c @@ -197,6 +197,11 @@ */ #define QUADSPI_QUIRK_USE_TDH_SETTING BIT(5) =20 +/* + * Do not disable the "qspi" clock when changing its rate. + */ +#define QUADSPI_QUIRK_SKIP_CLK_DISABLE BIT(6) + struct fsl_qspi_devtype_data { unsigned int rxfifo; unsigned int txfifo; @@ -306,6 +311,11 @@ static bool needs_tdh_setting(struct fsl_qspi *q) return !!(q->devtype_data->quirks & QUADSPI_QUIRK_USE_TDH_SETTING); } =20 +static bool needs_clk_disable(struct fsl_qspi *q) +{ + return !(q->devtype_data->quirks & QUADSPI_QUIRK_SKIP_CLK_DISABLE); +} + /* * An IC bug makes it necessary to rearrange the 32-bit data. * Later chips, such as IMX6SLX, have fixed this bug. @@ -536,15 +546,18 @@ static void fsl_qspi_select_mem(struct fsl_qspi *q, s= truct spi_device *spi, if (needs_4x_clock(q)) rate *=3D 4; =20 - fsl_qspi_clk_disable_unprep(q); + if (needs_clk_disable(q)) + fsl_qspi_clk_disable_unprep(q); =20 ret =3D clk_set_rate(q->clk, rate); if (ret) return; =20 - ret =3D fsl_qspi_clk_prep_enable(q); - if (ret) - return; + if (needs_clk_disable(q)) { + ret =3D fsl_qspi_clk_prep_enable(q); + if (ret) + return; + } =20 q->selected =3D spi_get_chipselect(spi, 0); =20 --=20 2.48.1