From nobody Sat Feb 7 15:09:59 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D780B2F7471 for ; Mon, 27 Oct 2025 09:03:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761555809; cv=none; b=u/UReO05XbIaT+MPV9jn7DtGgVPHGb5H/sMpn+YQMwOhIIGKAFOlEtcKjYoKeLroCgg0uhW6dAWpYKfk9a2yrabmxrQoDqbB8G/oOlr8JiSLZuF64DG/cn0H0yuWqzq6XYfrQM/kOb+vC3h36Bb5ja/7z96xzyWxFeEfakHO06g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761555809; c=relaxed/simple; bh=eogBR5sxD05fZ6c/zTfkTbZBgKCFI/Gyw8bMtmzrf/E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZyvJjUH8ciTixcStJbhg62eZ8KkRhs8iw/KoE7AN8II3jCdT4iDMSXRCucUSybsUOGPuolaDgOx62hW5ZGh8xK9yysoamew7RTqY7zzihuJ5Smg7ZssLQvipaYupWd2uIcMImOT+nIahe4og8bvbaUdkzq+BuYzpkGAEplu2DKg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P0t1wjFz; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P0t1wjFz" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-269af38418aso50250055ad.1 for ; Mon, 27 Oct 2025 02:03:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761555806; x=1762160606; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cDCevJO/jn4uxha5g3iGQ0Gi4sz+BoDakhPsr84awrg=; b=P0t1wjFzzv8xKGXVHp5WRpuE+lUaI+Z7UVZ47m56PohjaWjv2M3CYbUvshRfsrF7tw BTyHijKitPi2zRGmHL9SADRQr3CBGAlbgNuT58FAtDVD2F3ywc844KtX7MsyFaamynL5 XGQyPIS/nfjhiTcMdtO5r0NehjmnebDUOYnZbL1fBkW639zW8ihbP6HbcRKOUtTF2SqW pkMmsQkCDABRqrQ0lPSzJNlmshzaqSMqohmpUB3u291GjR71qsMqP9cGicDN55MYVdgM eHHr4JGG/m8rb7Mtz2uiA4wIWxlqvTsJz9Zf57sQ3eqUN05UQe12B/fLed1DvGb8CetI +wFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761555806; x=1762160606; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cDCevJO/jn4uxha5g3iGQ0Gi4sz+BoDakhPsr84awrg=; b=JuiXlzGn53qvWOhdyEPcsErbeeuHrZg3XMGlXmrTE8VXeTau4MFHjyxShO6a2CBCxE LlOTxkj3oEIru4DTfQmhm8nbMhnLX2HkE5IV7YkhHkhD0ktaBeCKukY+ZrefhUzI3mI7 bUFvVE5dxQYbCxoObY3oBgbeUrt1e92vdbVDugUib/Gbu0sEW358Vqk7IULHrzBpsfAW PlolMtPEt9hhsbekRRHA1BGOJO1TIqJQR+kFtsw6voUN1hdT/97hU/eeFxEZxmXprYb6 atcjRghEewKtIrmd6jrdPpnqp2ysdSn1OgciSr2KzpFhsMsem1Jj+M+6AglOujCc8tiU AsoA== X-Forwarded-Encrypted: i=1; AJvYcCWvSz0tJQls3Q7xQMH8uVY8OrMir5QCIULua7n0drz6GUzdzVQJuxtDsE0BQq4rzuOPuOgKeZEjKBt0TIs=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4nTxqtE3GebE3jWtIzXJi8/tXKA8J4SmrEhZVOW6Wh2ry01rk f0zAeT+NYuENVzu7tkuZh0B5bs5VeZilXi4X30Ji2A2MtZRorWm/DeOu X-Gm-Gg: ASbGncu1L1shBQc2pSSG/xqQbG4yDWZloXyehHI9Vmorfh5zly6Y921p9UY6cz2CFy1 TVW6asnVwBaZM8t79nekAZO5dYKK6knvn2fGaYLqwvYG4Fcls/fTnd2aAJhP14/ZWbGOHBG1S0F 19F12MEPZNhHQgQWkab8zHj9+43TLJdalA7MgG5ATnHWSJM5QnF9LHbhUGD19v1V2qLEUyF9Hq2 4MdQSaFyBDxOXnZX0VlKKdjeIs5GcHL+w/lx/3OD7p/IkncEz0Gwa3BLCBl63jGa7tUm1r17DOf fo8kYsV6nSQ72x4rBCoeLqD+EdamGB53z368PNaSGREQr0XO2CKhGLLD5e02stU+fmWl0kwOjtM IU2N/t/4kT3Mmvebzv+BZ4wkpOsGVqduG/FhB4OR97au4rk2XwM66OZyTIqKZusYRalkQsKGEEC n+jQDs6tCbPuiyJFK6O2Y= X-Google-Smtp-Source: AGHT+IHmIUD2h1GuwjjhJJdGb/O47J3PxX86EGpWbLGZgnTd2IndPXIXzCHY76GqEBfYMKQNDQz7ww== X-Received: by 2002:a17:902:e84b:b0:290:c0ed:de42 with SMTP id d9443c01a7336-290caf8582emr559508755ad.36.1761555806053; Mon, 27 Oct 2025 02:03:26 -0700 (PDT) Received: from rockpi-5b ([45.112.0.108]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29498cf3433sm73881335ad.21.2025.10.27.02.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 02:03:25 -0700 (PDT) From: Anand Moon To: Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , linux-omap@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-pci@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-arm-kernel@lists.infradead.org (moderated list:PCI DRIVER FOR TI DRA7XX/J721E), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon , Markus Elfring , Dan Carpenter Subject: [PATCH v3 1/2] PCI: j721e: Use devm_clk_get_optional_enabled() to get the clock Date: Mon, 27 Oct 2025 14:33:05 +0530 Message-ID: <20251027090310.38999-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251027090310.38999-1-linux.amoon@gmail.com> References: <20251027090310.38999-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use devm_clk_get_optional_enabled() helper instead of calling devm_clk_get_optional() and then clk_prepare_enable(). It simplifies the clk_prepare_enable() and clk_disable_unprepare() with proper error handling and makes the code more compact. The result of devm_clk_get_optional_enabled() is now assigned directly to pcie->refclk. This removes a superfluous local clk variable, improving code readability and compactness. The functionality remains unchanged, but the code is now more streamlined. Cc: Siddharth Vadapalli Signed-off-by: Anand Moon Reviewed-by: Siddharth Vadapalli --- v3: Clock needs to be disabled on Suspend and enabled on Resume. v2: Rephase the commit message and use proper error pointer PTR_ERR(pcie->refclk) to return error. v1: Drop explicit clk_disable_unprepare as it handled by devm_clk_get_optional_enabled, Since devm_clk_get_optional_enabled internally manages clk_prepare_enable and clk_disable_unprepare as part of its lifecycle, the explicit call to clk_disable_unprepare is redundant and can be safely removed. --- drivers/pci/controller/cadence/pci-j721e.c | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/contr= oller/cadence/pci-j721e.c index 5bc5ab20aa6d..a88b2e52fd78 100644 --- a/drivers/pci/controller/cadence/pci-j721e.c +++ b/drivers/pci/controller/cadence/pci-j721e.c @@ -479,7 +479,6 @@ static int j721e_pcie_probe(struct platform_device *pde= v) struct cdns_pcie_ep *ep =3D NULL; struct gpio_desc *gpiod; void __iomem *base; - struct clk *clk; u32 num_lanes; u32 mode; int ret; @@ -603,19 +602,13 @@ static int j721e_pcie_probe(struct platform_device *p= dev) goto err_get_sync; } =20 - clk =3D devm_clk_get_optional(dev, "pcie_refclk"); - if (IS_ERR(clk)) { - ret =3D dev_err_probe(dev, PTR_ERR(clk), "failed to get pcie_refclk\n"); + pcie->refclk =3D devm_clk_get_optional_enabled(dev, "pcie_refclk"); + if (IS_ERR(pcie->refclk)) { + ret =3D dev_err_probe(dev, PTR_ERR(pcie->refclk), + "failed to enable pcie_refclk\n"); goto err_pcie_setup; } =20 - ret =3D clk_prepare_enable(clk); - if (ret) { - dev_err_probe(dev, ret, "failed to enable pcie_refclk\n"); - goto err_pcie_setup; - } - pcie->refclk =3D clk; - /* * Section 2.2 of the PCI Express Card Electromechanical * Specification (Revision 5.1) mandates that the deassertion @@ -629,10 +622,8 @@ static int j721e_pcie_probe(struct platform_device *pd= ev) } =20 ret =3D cdns_pcie_host_setup(rc); - if (ret < 0) { - clk_disable_unprepare(pcie->refclk); + if (ret < 0) goto err_pcie_setup; - } =20 break; case PCI_MODE_EP: @@ -679,7 +670,6 @@ static void j721e_pcie_remove(struct platform_device *p= dev) =20 gpiod_set_value_cansleep(pcie->reset_gpio, 0); =20 - clk_disable_unprepare(pcie->refclk); cdns_pcie_disable_phy(cdns_pcie); j721e_pcie_disable_link_irq(pcie); pm_runtime_put(dev); --=20 2.50.1 From nobody Sat Feb 7 15:09:59 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE0602F9DAA for ; Mon, 27 Oct 2025 09:03:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761555814; cv=none; b=UKIi6Ny0uZV1Q0cU++RoSh/kMFIDFs4ofuDEZ/LxhzokjGII1YIuTct8h1t2fZf/4VACHd9LrAYZwz4g6J/Cpwb2dX8pJnqHRcSwi53U4siAK+u3mrCArWWYUMDDkmMkmOo1xIhFcBqNs/TRM3OpQr8mbrVyY9+INsdN4tkJ130= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761555814; c=relaxed/simple; bh=OvUDbo5pGuUu7qotyzejFUWD0f6M8h+6eVPsJH2aFMY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qxYfWRtkx1oGLKoCbjp2wNB3OwzAz2yfM9wcNH4/5WIIiA0+wkQawgQDHYg0rifCa49+sXKBB3YclY3tVDjFVwmsc0WsHFWdAdtW1WkZaH8DCNbZz/R0lnja9LlR7WqyFBvSdC/J4ZJBF194H/Hop35w8QJl52D+bZl9/1aQIZI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dMV1rXdU; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dMV1rXdU" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-28a5b8b12a1so44679285ad.0 for ; Mon, 27 Oct 2025 02:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761555812; x=1762160612; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zoTpyL8LPqpthgwVzy0CiG0xAa+lw5VtWyKYbKOT8QE=; b=dMV1rXdUJDSL7ZIEqmUbuTc4SonyFxw7qN50GjxH3wPhCs8Sv8qiPUZ1azC+us72AI FOnyGPVBRD1T9VQxK0Z8G971Hrn/Q1NsDXCPLovscO1GEn5/V46aaiBtQJ4lWLYtaaCZ adDgsxrjKq6tPoJQoDK6ng6WZYHZgIDfmUK3vcyqKjpRgmd7ra3EUu28jyXTP+GDf5Kh IPEMYq2mX2x9XMiPtMuI+Jg94aBUu0ui9LGLtvx2f8FSEPYzWGh5tr9kYlzrbw5TSQdt /cizUhs7mo7MLLayxQt8GnyRmEN8l2GfC41DfIezpWurU+yrUTnesMbpf+zYLOMphrv8 slVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761555812; x=1762160612; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zoTpyL8LPqpthgwVzy0CiG0xAa+lw5VtWyKYbKOT8QE=; b=o/AAEKzkWWmNROcvuV9nRj7wmuYrkDn728W7PUlzjdR+gVB3Db/C146gGm5PT2y3Fm 9JhPGICalbTD3wmtS3AtEiw4a3ipqY4mg9Yw0pz6zappC1TRODK/sUGWNHYooDm5uRBG NciE7fYAohw7QZWnarxuMhqCgQvnvLyv/nV2nReRjzK6OFWoSHMTXrBIG67e2nv19Lc1 n13XtRrK1/6rkGeWTZ3azc611fzTyszHwAT2OEqnbkoaZr67MhvDvzCf69ZiBVA3H80b QeQ7gRAwFX0KTcW2lqCI1jnsP3vaa4gK/KFd9fFiA6COFp/vnXs8RPsHJZEn3l0VbTMm Hswg== X-Forwarded-Encrypted: i=1; AJvYcCW86dEvNCSADLiamHAmsiE1hayZRk5CWQC2N2FlEFibnp6MA1QflRBoMO/tGfy1xzM/iovox+v8B9GCWik=@vger.kernel.org X-Gm-Message-State: AOJu0Yxc/0NKESlMkEzqbmC78sSDmhgsuA7cvglE5ODFsVd0aIfSgB0X hc6jx0UDbtnHVjEyOEv2Ox0MSV3baJY+z4tqitrTB96zFoiqgO/xq6dm X-Gm-Gg: ASbGnctmSsyEt+kVbUI3q8o296HkQ22RGJir1DYp6QXvirmLDOY69HV3mFCm1nKePLZ bmYKnEtB4sG09jL0/al8vhRQDH5mPjG3k7MqHEUcpMy9IvYptLmxlJ2gknVBQnpwdLDdxhbXW16 J1S6zHJ7/9wateMAI/zgFc6rjS7d5uOV1PxUJ1JTEPCrq6dQxBt5HbkKvbsin16wFboDWaobdkh d8UZzOpm62y38M0z7LnLLI0rLzNDQHWn4Kgx4SvjtBmm/qep/e5oTbW0GiBWYfj+quiNnilnJZQ woehfdypPTgIAkmQzMMNnkPf4Hg4YFTDyX6tWEctCiRKlCAu2SixFeLkiAOFIk4UZQM+zUI3+w9 GSpzGStxvwG9EMjgqnz8SGol+6GXKcBrPtDSguf6LSUDFuXvvh7uFC8UARwXqK6RS0/G+njuXzC KtqRivy6HF/WNi81ioSA4= X-Google-Smtp-Source: AGHT+IGXwneCAjsjJPL0hWiNqGqUVbp6EE3p4IZGCMQRdN0SZJ+QzldDOpFCpQQntrr/66rhZtbW2Q== X-Received: by 2002:a17:902:e944:b0:290:b14c:4f36 with SMTP id d9443c01a7336-290cba4edaemr464679185ad.31.1761555812013; Mon, 27 Oct 2025 02:03:32 -0700 (PDT) Received: from rockpi-5b ([45.112.0.108]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29498cf3433sm73881335ad.21.2025.10.27.02.03.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 02:03:31 -0700 (PDT) From: Anand Moon To: Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , linux-omap@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-pci@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-arm-kernel@lists.infradead.org (moderated list:PCI DRIVER FOR TI DRA7XX/J721E), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon , Markus Elfring , Dan Carpenter Subject: [PATCH v3 2/2] PCI: j721e: Use inline reset GPIO assignment and drop local variable Date: Mon, 27 Oct 2025 14:33:06 +0530 Message-ID: <20251027090310.38999-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251027090310.38999-1-linux.amoon@gmail.com> References: <20251027090310.38999-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The result of devm_gpiod_get_optional() is now assigned directly assigned to pcie->reset_gpio. This removes a superfluous local gpiod variable, improving code readability and compactness. The functionality remains unchanged, but the code is now more streamlined Cc: Siddharth Vadapalli Reviewed-by: Siddharth Vadapalli Signed-off-by: Anand Moon --- drivers/pci/controller/cadence/pci-j721e.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/contr= oller/cadence/pci-j721e.c index a88b2e52fd78..ecd1b0312400 100644 --- a/drivers/pci/controller/cadence/pci-j721e.c +++ b/drivers/pci/controller/cadence/pci-j721e.c @@ -477,7 +477,6 @@ static int j721e_pcie_probe(struct platform_device *pde= v) struct j721e_pcie *pcie; struct cdns_pcie_rc *rc =3D NULL; struct cdns_pcie_ep *ep =3D NULL; - struct gpio_desc *gpiod; void __iomem *base; u32 num_lanes; u32 mode; @@ -589,12 +588,12 @@ static int j721e_pcie_probe(struct platform_device *p= dev) =20 switch (mode) { case PCI_MODE_RC: - gpiod =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); - if (IS_ERR(gpiod)) { - ret =3D dev_err_probe(dev, PTR_ERR(gpiod), "Failed to get reset GPIO\n"= ); + pcie->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW= ); + if (IS_ERR(pcie->reset_gpio)) { + ret =3D dev_err_probe(dev, PTR_ERR(pcie->reset_gpio), + "Failed to get reset GPIO\n"); goto err_get_sync; } - pcie->reset_gpio =3D gpiod; =20 ret =3D cdns_pcie_init_phy(dev, cdns_pcie); if (ret) { @@ -616,9 +615,9 @@ static int j721e_pcie_probe(struct platform_device *pde= v) * This shall ensure that the power and the reference clock * are stable. */ - if (gpiod) { + if (pcie->reset_gpio) { msleep(PCIE_T_PVPERL_MS); - gpiod_set_value_cansleep(gpiod, 1); + gpiod_set_value_cansleep(pcie->reset_gpio, 1); } =20 ret =3D cdns_pcie_host_setup(rc); --=20 2.50.1