From nobody Mon Feb 9 09:54:30 2026 Received: from smtp1.ms.mff.cuni.cz (smtp-in1.ms.mff.cuni.cz [195.113.20.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3C6A2F12A2; Sun, 26 Oct 2025 18:28:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.113.20.234 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761503284; cv=none; b=qFW03/H/7tA8TXUCHp4pRgykmucJ3CLZ4zDIMUlZ9AUKbOfsHWg4TJNwV6anyQ7qFQMWHQutXoZnsYtl6BqXabiTrgeWzsfvIoUuyVWCG1H91eYWD3AfwbxVt56UNEdNPk8K9T7uQd//WTwz2OIcqLilc9WiluYFixT/q6AA/QQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761503284; c=relaxed/simple; bh=nZiwVmQfDQUswqxjX9/bMuoqQdriwuT83oSTAs/8OEg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AnDaOI1AQ+bphzoYFmoz/gkl0dPTRnBUwmFLJDFT80tVUAsfrhinAyXXWSNtq51sxoVmztQ4KasY/teaLjlVZmMV5edD+16JNcn48EQ92zRor6GMtAy89SWZC988shmPMSIVw2P5fRdQX1mZjiP/OeiLoVaDzSwid9UZ3VKvJPw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=matfyz.cz; spf=pass smtp.mailfrom=matfyz.cz; dkim=pass (2048-bit key) header.d=mff.cuni.cz header.i=@mff.cuni.cz header.b=U9uYyCo3; arc=none smtp.client-ip=195.113.20.234 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=matfyz.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=matfyz.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mff.cuni.cz header.i=@mff.cuni.cz header.b="U9uYyCo3" X-SubmittedBy: id balejk@matfyz.cz subject /postalCode=110+2000/O=Univerzita+20Karlova/street=Ovocn+5CxC3+5CxBD+20trh+20560/5/ST=Praha,+20Hlavn+5CxC3+5CxAD+20m+5CxC4+5Cx9Bsto/C=CZ/CN=Karel+20Balej/emailAddress=balejk@matfyz.cz serial F5FD910E8FE2121B897F7E55B84E351D issued by /C=NL/O=GEANT+20Vereniging/CN=GEANT+20Personal+20CA+204 auth type TLS.CUNI DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mff.cuni.cz; s=submission; t=1761503218; x=1762803218; bh=7knLhnUchA+ati7SLm2q26i7FYnluYm8NgHElvQxLQY=; h=From; b=U9uYyCo3Qg/GydPmzPlED9CyjKKdXcUc35kpn52nE7y6TscLMF+VEAz6TZWes6jH4 L9cOqoFF529RgOpxl7KjyS0dfbwmIOpw4hrMt4T1vcX2mh1JXOU9teaPc9fOIPv2Ht yXb2d8mlo9sEElwGi2JppgXe2ZYcgJ+NyZPlaV4Cyp6SgxEzetZRiAPzRdHZ0FvPIq 7f9i/uUwnfsU1FuJtc864OFxIGnT8gV4qFkBz9rOQIC9G6A0iRa+bFIfKXkuWw1PoT TDJqU9jQor4eo4q5L0Kyg+Rjgexp2jDTOG5ki3E2h3rBp+pwdtOQ96Yx1pnKRd4moD J7gjGItfzLJCw== Received: from localhost (internet5.mraknet.com [185.200.108.250]) (authenticated) by smtp1.ms.mff.cuni.cz (8.16.1/8.16.1) with ESMTPS id 59QIQueO043052 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=OK); Sun, 26 Oct 2025 19:26:58 +0100 (CET) (envelope-from balejk@matfyz.cz) From: Karel Balej To: Johannes Berg , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?q?Duje=20Mihanovi=C4=87?= , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Brian Norris , Francesco Dolcini , Ulf Hansson , Frank Li , linux-wireless@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Karel Balej , Jeff Chen , Peng Fan Subject: [DONOTAPPLY RFC PATCH v2 1/4] dt-bindings: mwifiex: document use with the SD8777 chipset Date: Sun, 26 Oct 2025 19:20:38 +0100 Message-ID: <20251026182602.26464-2-balejk@matfyz.cz> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251026182602.26464-1-balejk@matfyz.cz> References: <20251026182602.26464-1-balejk@matfyz.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Document the corresponding compatible string for the use of this driver with the Marvell SD8777 wireless chipset. Signed-off-by: Karel Balej Acked-by: Brian Norris --- .../devicetree/bindings/net/wireless/marvell,sd8787.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/wireless/marvell,sd8787.= yaml b/Documentation/devicetree/bindings/net/wireless/marvell,sd8787.yaml index 930b700b73d0..d31ff38f57d1 100644 --- a/Documentation/devicetree/bindings/net/wireless/marvell,sd8787.yaml +++ b/Documentation/devicetree/bindings/net/wireless/marvell,sd8787.yaml @@ -18,6 +18,7 @@ description: properties: compatible: enum: + - marvell,sd8777 - marvell,sd8787 - marvell,sd8897 - marvell,sd8978 --=20 2.51.1 From nobody Mon Feb 9 09:54:30 2026 Received: from smtp1.ms.mff.cuni.cz (smtp-in1.ms.mff.cuni.cz [195.113.20.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CFDF2EC563; Sun, 26 Oct 2025 18:27:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.113.20.234 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761503282; cv=none; b=XC9yJMzjtb4IDrSWQitt4z2Gh7cnCUnL1AgKfrHeKIP/t7frm6f6MsTXx9WVjRNDQtNQmTjO/Mu2PPaE8+G1A6QOshSCY8JcPIpXrTIXr9aOhY2SbIlHg4klL1sFmccxRdRXN7GYt2wCncHxhKxdqdabBXAAj1ywGPtVSD0lSew= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761503282; c=relaxed/simple; bh=yFASgLRDtRYXPG3h1mK4uhOiMIbjSF5JoGsaQ9e4l2w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V/iowJ6fiaiNT3bBnXdVJkLjUK+Eh/hmnxs23jkfsrojmdRr722Teb6w5lYq0Wa19RvNUnVKa+xxbK17dmWkKASGDokx/bha3aR35RkMZrW1sAQ0Ak/islft70I0lGx9/KeQDx2HUkA2/l4eeR2EgixCXbIJUR4eaUVpgbHX68o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=matfyz.cz; spf=pass smtp.mailfrom=matfyz.cz; dkim=pass (2048-bit key) header.d=mff.cuni.cz header.i=@mff.cuni.cz header.b=nc/kNpfL; arc=none smtp.client-ip=195.113.20.234 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=matfyz.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=matfyz.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mff.cuni.cz header.i=@mff.cuni.cz header.b="nc/kNpfL" X-SubmittedBy: id balejk@matfyz.cz subject /postalCode=110+2000/O=Univerzita+20Karlova/street=Ovocn+5CxC3+5CxBD+20trh+20560/5/ST=Praha,+20Hlavn+5CxC3+5CxAD+20m+5CxC4+5Cx9Bsto/C=CZ/CN=Karel+20Balej/emailAddress=balejk@matfyz.cz serial F5FD910E8FE2121B897F7E55B84E351D issued by /C=NL/O=GEANT+20Vereniging/CN=GEANT+20Personal+20CA+204 auth type TLS.CUNI DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mff.cuni.cz; s=submission; t=1761503221; x=1762803221; bh=kXvC+cpea6VJnQ0B5yli7LjVJmmWX99wab1EyMVPdqM=; h=From; b=nc/kNpfLOmnmOYmYHzI1PNp5IcU//eVt2rbfKh2nJ9dwaGyvovdduaF9oa/oAealW B/272boPVasQRGutlh3EnNq+lK8HQih7Dgf90cXevSdCjIVEw0QjYJ9/ZMVXmQiT4a tOxXxgcxsCcGNlwRojtO9jQKC6CPVrtKn+0wsFLtH3FliEm4rtW2OWb2dVtNc1j3LB 7kX87C19oeSEiYQb/6b1QWqrBR12qrpNamOuNuwkwldv/nQTIoAP0uWoB9ykdqQQGs HoWQLoSvtppXNsKdZ5Zdg387LugtXV35q8jpjS1evZxN30TvhiGDvEaXgYRxeOs3d9 sZEI9qXFqOfng== Received: from localhost (internet5.mraknet.com [185.200.108.250]) (authenticated) by smtp1.ms.mff.cuni.cz (8.16.1/8.16.1) with ESMTPS id 59QIR0MQ043059 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=OK); Sun, 26 Oct 2025 19:27:01 +0100 (CET) (envelope-from balejk@matfyz.cz) From: Karel Balej To: Johannes Berg , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?q?Duje=20Mihanovi=C4=87?= , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Brian Norris , Francesco Dolcini , Ulf Hansson , Frank Li , linux-wireless@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Karel Balej , Jeff Chen , Peng Fan Subject: [DONOTAPPLY RFC PATCH v2 2/4] net: mwifiex: add support for the SD8777 chipset Date: Sun, 26 Oct 2025 19:20:39 +0100 Message-ID: <20251026182602.26464-3-balejk@matfyz.cz> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251026182602.26464-1-balejk@matfyz.cz> References: <20251026182602.26464-1-balejk@matfyz.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Marvell SD8777 is a wireless chipset used for instance in the PXA1908 SoC found for example in the samsung,coreprimevelte smartphone, with which this was tested. The driver seems to be compatible with this chipset so enable this support by adding the necessary information based on the downstream code. Signed-off-by: Karel Balej --- drivers/net/wireless/marvell/mwifiex/sdio.c | 21 +++++++++++++++++++++ drivers/net/wireless/marvell/mwifiex/sdio.h | 1 + include/linux/mmc/sdio_ids.h | 1 + 3 files changed, 23 insertions(+) diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wire= less/marvell/mwifiex/sdio.c index f039d6f19183..a1adb78fabaf 100644 --- a/drivers/net/wireless/marvell/mwifiex/sdio.c +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c @@ -318,6 +318,23 @@ static const struct mwifiex_sdio_card_reg mwifiex_reg_= sd89xx =3D { 0x68, 0x69, 0x6a}, }; =20 +static const struct mwifiex_sdio_device mwifiex_sdio_sd8777 =3D { + .firmware =3D SD8777_DEFAULT_FW_NAME, + .reg =3D &mwifiex_reg_sd87xx, + .max_ports =3D 16, + .mp_agg_pkt_limit =3D 8, + .tx_buf_size =3D MWIFIEX_TX_DATA_BUF_SIZE_2K, + .mp_tx_agg_buf_size =3D MWIFIEX_MP_AGGR_BUF_SIZE_16K, + .mp_rx_agg_buf_size =3D MWIFIEX_MP_AGGR_BUF_SIZE_16K, + .supports_sdio_new_mode =3D false, + .has_control_mask =3D true, + .can_dump_fw =3D false, + .can_auto_tdls =3D true, + .can_ext_scan =3D true, + .fw_ready_extra_delay =3D false, + .host_mlme =3D false, +}; + static const struct mwifiex_sdio_device mwifiex_sdio_sd8786 =3D { .firmware =3D SD8786_DEFAULT_FW_NAME, .reg =3D &mwifiex_reg_sd87xx, @@ -516,6 +533,7 @@ static struct memory_type_mapping mem_type_mapping_tbl[= ] =3D { }; =20 static const struct of_device_id mwifiex_sdio_of_match_table[] __maybe_unu= sed =3D { + { .compatible =3D "marvell,sd8777" }, { .compatible =3D "marvell,sd8787" }, { .compatible =3D "marvell,sd8897" }, { .compatible =3D "marvell,sd8978" }, @@ -954,6 +972,8 @@ static void mwifiex_sdio_coredump(struct device *dev) =20 /* WLAN IDs */ static const struct sdio_device_id mwifiex_ids[] =3D { + {SDIO_DEVICE(SDIO_VENDOR_ID_MARVELL, SDIO_DEVICE_ID_MARVELL_8777_WLAN), + .driver_data =3D (unsigned long)&mwifiex_sdio_sd8777}, {SDIO_DEVICE(SDIO_VENDOR_ID_MARVELL, SDIO_DEVICE_ID_MARVELL_8786_WLAN), .driver_data =3D (unsigned long) &mwifiex_sdio_sd8786}, {SDIO_DEVICE(SDIO_VENDOR_ID_MARVELL, SDIO_DEVICE_ID_MARVELL_8787_WLAN), @@ -3201,6 +3221,7 @@ MODULE_AUTHOR("Marvell International Ltd."); MODULE_DESCRIPTION("Marvell WiFi-Ex SDIO Driver version " SDIO_VERSION); MODULE_VERSION(SDIO_VERSION); MODULE_LICENSE("GPL v2"); +MODULE_FIRMWARE(SD8777_DEFAULT_FW_NAME); MODULE_FIRMWARE(SD8786_DEFAULT_FW_NAME); MODULE_FIRMWARE(SD8787_DEFAULT_FW_NAME); MODULE_FIRMWARE(SD8797_DEFAULT_FW_NAME); diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.h b/drivers/net/wire= less/marvell/mwifiex/sdio.h index 65d142286c46..c6425191ad84 100644 --- a/drivers/net/wireless/marvell/mwifiex/sdio.h +++ b/drivers/net/wireless/marvell/mwifiex/sdio.h @@ -18,6 +18,7 @@ =20 #include "main.h" =20 +#define SD8777_DEFAULT_FW_NAME "mrvl/sd8777_uapsta.bin" #define SD8786_DEFAULT_FW_NAME "mrvl/sd8786_uapsta.bin" #define SD8787_DEFAULT_FW_NAME "mrvl/sd8787_uapsta.bin" #define SD8797_DEFAULT_FW_NAME "mrvl/sd8797_uapsta.bin" diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h index 673cbdf43453..61e95b5a528c 100644 --- a/include/linux/mmc/sdio_ids.h +++ b/include/linux/mmc/sdio_ids.h @@ -95,6 +95,7 @@ #define SDIO_DEVICE_ID_MARVELL_8797_BT 0x912a #define SDIO_DEVICE_ID_MARVELL_8897_WLAN 0x912d #define SDIO_DEVICE_ID_MARVELL_8897_BT 0x912e +#define SDIO_DEVICE_ID_MARVELL_8777_WLAN 0x9131 #define SDIO_DEVICE_ID_MARVELL_8887_F0 0x9134 #define SDIO_DEVICE_ID_MARVELL_8887_WLAN 0x9135 #define SDIO_DEVICE_ID_MARVELL_8887_BT 0x9136 --=20 2.51.1 From nobody Mon Feb 9 09:54:30 2026 Received: from smtp1.ms.mff.cuni.cz (smtp-in1.ms.mff.cuni.cz [195.113.20.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D476A202C30; Sun, 26 Oct 2025 18:27:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.113.20.234 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761503282; cv=none; b=b89XIOvmwmfgqV2rQqMzoYYIldCqsGWJDUrhZqasKRBbaFOO6GjnqJmeU2J63/nR756e98+OKhWch2x/pXn8ReCJAv9ynj0Xod/qrjD1HKdw2lc4plHylkJrdgO0ZDVb0gZ78Trb8zRkMz9ZtZIR+R6MMMVKrCZAQVTHlxvkJAo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761503282; c=relaxed/simple; bh=rIFwJxfwTvpeOWM0RSVIgbkTg+0MDNJ3holbFfMWeKQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QSmgX364R70IjgDS08r3ghf32NdWW6/30PxLGIEFe8H2NZ7jY+rD0wgs1ei6Kr0dZ4zzjSD9Aj93AR06km/MrKinvA0vKXNAxGFBYaWuMRebCztvGBQd7jzFFNW0AwEnIUgjFDzf8rHEYj5TMsaXbxI1l15W00LcqX/HY9q3/1o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=matfyz.cz; spf=pass smtp.mailfrom=matfyz.cz; dkim=pass (2048-bit key) header.d=mff.cuni.cz header.i=@mff.cuni.cz header.b=oXCdWBef; arc=none smtp.client-ip=195.113.20.234 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=matfyz.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=matfyz.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mff.cuni.cz header.i=@mff.cuni.cz header.b="oXCdWBef" X-SubmittedBy: id balejk@matfyz.cz subject /postalCode=110+2000/O=Univerzita+20Karlova/street=Ovocn+5CxC3+5CxBD+20trh+20560/5/ST=Praha,+20Hlavn+5CxC3+5CxAD+20m+5CxC4+5Cx9Bsto/C=CZ/CN=Karel+20Balej/emailAddress=balejk@matfyz.cz serial F5FD910E8FE2121B897F7E55B84E351D issued by /C=NL/O=GEANT+20Vereniging/CN=GEANT+20Personal+20CA+204 auth type TLS.CUNI DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mff.cuni.cz; s=submission; t=1761503225; x=1762803225; bh=YzhIdawRjO+AxQtjLDEcxwAEGsa8XhjWBxl0gSxmXBk=; h=From; b=oXCdWBefexpIjIu2/qhYmEu/vgffAyYS4FX4lWPOIW+y64TrsDE9IUg9OFhfytbmq 9Hsdp4InwQ0Z7GuTjmmjLa7x+UnRI6g5Vo0Zlzp0y+k6Al3CBfYN3RBZ0PbiDy7UMo tNrjABO/hqDRu6ZKpYW8zML0em8iZG26hKpNxZDv8AUplvuJEIE5Oc3M+UNZXRJFZi F5HgosUD+j6iN4U2f0Ry1mb4V3NnkjLxqRLS+ce0ixrHka6KZOHQ4vOWBjxZeqztPT crFok3nG2e5KgJ5vSiv+ulUqrdrwd+Vwt+i8595pucDAVG9s333TBiBB1+WmSLD4kR sCUC91xhxlnjw== Received: from localhost (internet5.mraknet.com [185.200.108.250]) (authenticated) by smtp1.ms.mff.cuni.cz (8.16.1/8.16.1) with ESMTPS id 59QIR3Pt043068 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=OK); Sun, 26 Oct 2025 19:27:04 +0100 (CET) (envelope-from balejk@matfyz.cz) From: Karel Balej To: Johannes Berg , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?q?Duje=20Mihanovi=C4=87?= , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Brian Norris , Francesco Dolcini , Ulf Hansson , Frank Li , linux-wireless@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Karel Balej , Jeff Chen , Peng Fan Subject: [DONOTAPPLY RFC PATCH v2 3/4] DONOTMERGE: net: mwifiex: fix timeouts with the SD8777 chip Date: Sun, 26 Oct 2025 19:20:40 +0100 Message-ID: <20251026182602.26464-4-balejk@matfyz.cz> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251026182602.26464-1-balejk@matfyz.cz> References: <20251026182602.26464-1-balejk@matfyz.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It has been observed with the samsung,coreprimevelte smartphone which uses this wireless chip that the driver would irrecoverably fail upon certain operations, usually after timing out on a FW command such as with these logs: [ 2101.209913] mwifiex_sdio mmc2:0001:1: mwifiex_cmd_timeout_func: Timeout= cmd id =3D 0xa4, act =3D 0x0 [ 2101.209941] mwifiex_sdio mmc2:0001:1: num_data_h2c_failure =3D 0 [ 2101.209949] mwifiex_sdio mmc2:0001:1: num_cmd_h2c_failure =3D 0 [ 2101.209957] mwifiex_sdio mmc2:0001:1: is_cmd_timedout =3D 1 [ 2101.209964] mwifiex_sdio mmc2:0001:1: num_tx_timeout =3D 0 [ 2101.209971] mwifiex_sdio mmc2:0001:1: last_cmd_index =3D 1 [ 2101.209978] mwifiex_sdio mmc2:0001:1: last_cmd_id: 16 00 a4 00 75 00 a4= 00 7f 00 [ 2101.209988] mwifiex_sdio mmc2:0001:1: last_cmd_act: 00 00 00 00 02 00 0= 0 00 00 00 [ 2101.209995] mwifiex_sdio mmc2:0001:1: last_cmd_resp_index =3D 0 [ 2101.210003] mwifiex_sdio mmc2:0001:1: last_cmd_resp_id: 16 80 a4 80 75 = 80 a4 80 7f 80 [ 2101.210010] mwifiex_sdio mmc2:0001:1: last_event_index =3D 4 [ 2101.210018] mwifiex_sdio mmc2:0001:1: last_event: 0b 00 0a 00 0b 00 0a = 00 1c 00 [ 2101.210025] mwifiex_sdio mmc2:0001:1: data_sent=3D1 cmd_sent=3D1 [ 2101.210033] mwifiex_sdio mmc2:0001:1: ps_mode=3D1 ps_state=3D0 [ 2101.210089] mwifiex_sdio mmc2:0001:1: failed to get signal information [ 2101.210761] mwifiex_sdio mmc2:0001:1: PREP_CMD: FW is in bad state [ 2101.210786] mwifiex_sdio mmc2:0001:1: failed to get signal information [ 2101.211162] mwifiex_sdio mmc2:0001:1: =3D=3D=3Dmwifiex driverinfo dump = start=3D=3D=3D [ 2101.211178] mwifiex_sdio mmc2:0001:1: info: MWIFIEX VERSION: mwifiex 1.= 0 (14.75.33.p119) [ 2101.211202] mwifiex_sdio mmc2:0001:1: SDIO register dump start [ 2101.211482] mwifiex_sdio mmc2:0001:1: SDIO Func0 (0x0-0x9): 32 02 02 02= 03 00 00 02 03 00 [ 2101.211649] mwifiex_sdio mmc2:0001:1: SDIO Func1 (0x0-0x9): 02 3f 03 00= 00 00 00 00 92 00 [ 2101.211740] mwifiex_sdio mmc2:0001:1: SDIO Func1: (0x28) 00 (0x30) 08 (= 0x34) 07 (0x38) 11 (0x3c) 00 [ 2101.211921] mwifiex_sdio mmc2:0001:1: SDIO Func1 (0x60-0x6a): dc fe 5f = 81 ca 04 00 79 79 00 30 [ 2101.314135] mwifiex_sdio mmc2:0001:1: SDIO Func1 (0x60-0x6a): dc fe 5f = 81 ca 04 00 79 79 00 30 [ 2101.314168] mwifiex_sdio mmc2:0001:1: SDIO register dump end [ 2101.314300] mwifiex_sdio mmc2:0001:1: =3D=3D=3Dmwifiex driverinfo dump = end=3D=3D=3D [ 2101.314313] mwifiex_sdio mmc2:0001:1: =3D=3D mwifiex dump information t= o /sys/class/devcoredump start [ 2101.314586] mwifiex_sdio mmc2:0001:1: =3D=3D mwifiex dump information t= o /sys/class/devcoredump end [ 2101.314610] mwifiex_sdio mmc2:0001:1: PREP_CMD: FW is in bad state [ 2101.314638] mwifiex_sdio mmc2:0001:1: PREP_CMD: FW is in bad state [ 2101.317997] mwifiex_sdio mmc2:0001:1: PREP_CMD: card is removed [ 2101.318029] mwifiex_sdio mmc2:0001:1: deleting the crypto keys [ 2101.318037] mwifiex_sdio mmc2:0001:1: PREP_CMD: card is removed [ 2101.318044] mwifiex_sdio mmc2:0001:1: deleting the crypto keys [ 2101.318051] mwifiex_sdio mmc2:0001:1: PREP_CMD: card is removed [ 2101.318057] mwifiex_sdio mmc2:0001:1: deleting the crypto keys [ 2101.318064] mwifiex_sdio mmc2:0001:1: PREP_CMD: card is removed [ 2101.318071] mwifiex_sdio mmc2:0001:1: deleting the crypto keys [ 2101.318078] mwifiex_sdio mmc2:0001:1: PREP_CMD: card is removed [ 2101.318084] mwifiex_sdio mmc2:0001:1: deleting the crypto keys [ 2101.318091] mwifiex_sdio mmc2:0001:1: PREP_CMD: card is removed [ 2101.318098] mwifiex_sdio mmc2:0001:1: deleting the crypto keys [ 2101.321278] mwifiex_sdio mmc2:0001:1: info: shutdown mwifiex... [ 2101.323214] mwifiex_sdio mmc2:0001:1: PREP_CMD: card is removed [ 2101.323250] mwifiex_sdio mmc2:0001:1: PREP_CMD: card is removed [ 2101.324427] mwifiex_sdio mmc2:0001:1: PREP_CMD: card is removed [ 2101.419786] mmc2: queuing unknown CIS tuple 0x50 [40 1e fd d1 c0 46 70 = 47 00 b5 23 48 24 49 01 60 24 48 24 49 01 60 24 49 08 47 1f 48 24 49 01 60]= (32 bytes) [ 2101.460850] mmc2: queuing unknown CIS tuple 0x70 [53 f0 21 e3 1e ff 2f = e1 10 1f 11 ee 00 00 50 e3 02 2a a0 e3 02 10 c1 01 02 10 81 11 10 1f 01 ee = 1e ff 2f e1 01 00 a0 e3 f6 ff ff eb ea ff ff fa 48 00 9f e5 54 10 9f e5 54 = 20 9f e5 ef ff ff eb] (71 bytes) [ 2101.532495] mmc2: queuing unknown CIS tuple 0xe8 [2f 07 ee 1e ff 2f e1 = 0e 30 a0 e1 00 00 a0 e3 ea ff ff eb e5 ff ff fa 03 e0 a0 e1 2c 30 9f e5 13 = ff 2f e1 00 10 80 e5 1a 9f 00 ee 12 ff 2f e1 04 21 00 80 c0 00 10 80 04 22 = 00 80 06 0a 46 02 48] (144 bytes) [ 2101.598922] mmc2: queuing unknown CIS tuple 0x9d [29 15 1d 01 00 4d 61 = 72 76 65 6c 6c 20 42 6c 75 65 74 6f 6f 74 68 20 44 65 76 69 63 65 00 00 ff = 20 04 df 02 32 91 21 02 0c 00 22 2a 01 01 00 00 00 00 00 00 00 00 00 00 00 = 02 00 00 00 00 00 00] (162 bytes) [ 2101.599647] mmc2: tried to HW reset card, got error -2 [ 2101.599699] mwifiex_sdio mmc2:0001:1: SDIO HW reset failed: -2 (besides cmd id 0xa4 also 0xce is often seen in these dumps). One of these operations which would cause the timeout reliably was initiating a SSH connection into the phone over the WiFi and this was used for tracking down the issue. The other known ones are heavier usage of the XMPP client Dino on the phone and any more than basic browsing in Firefox. It was however verified that the mwifiex driver works without issues on the vendor Samsung kernel with the proper support for the chip added, although the stock Android on the phone doesn't use mwifiex but instead a specialized driver for the chip which however is very similar to mwifiex. A support for the phone and it's components essential for the WiFi function were thus backported to the v3.14 kernel on whose stable branch the stock kernel was based and it was verified that the WiFi (namely SSH over WiFi) also works there without timeouts. Afterwards, a bisect was performed which first indicated the commit 808bbebcc8fc ("mwifiex: add Tx status support for EAPOL packets") introduced in the v3.18-v3.19 cycle. Reverting this commit (and the following one, commit 18ca43823f3c ("mwifiex: add Tx status support for ACTION frames"), to facilitate a clean revert) fixed the timeouts for v3.19, but during the next cycle, v3.19-v4.0, another breakage was introduced via commit 84b313b35f81 ("mwifiex: make tx packet 64 byte DMA aligned"). Reverting all three commits fixed the timeouts on the current mainline kernel also. This patch contains the minimal changes needed to achieve that derived from the full revert commits. Note that a few timeouts were still observed on mainline Linux even with these changes, however they were all on a particular network and don't have a known reproducer. On other networks, the chip performs flawlessly as far as it was tested so far. These changes also don't mitigate the observed firmware loading issues: [ 68.698674] mwifiex_sdio mmc2:0001:1: FW download, write iomem (0) fail= ed @ 208016 [ 68.698711] mwifiex_sdio mmc2:0001:1: prog_fw failed ret=3D0xffffffff These were however also seen with the old kernels and as such are likely caused either by some inherent incompatibility of the driver with the chip in this regard or, more likely given their occasional nature, by an issue at some other level, such as the stability of the SDIO (the occurrence of the problem does seem to loosely correlate with the load exerted on the phone while the FW loading is performed (i. e. mainly on startup)). Note that Bluetooth on the phone (provided by the same chip) has also been seen crashing in a similar way as the WiFi without this patch, although seemingly less frequently/deterministically, and a similar change might thus be needed in the btmrvl driver if it is to be used for the phone's BT without issues. Signed-off-by: Karel Balej --- drivers/net/wireless/marvell/mwifiex/fw.h | 4 +--- drivers/net/wireless/marvell/mwifiex/sta_tx.c | 10 ++-------- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/fw.h b/drivers/net/wirele= ss/marvell/mwifiex/fw.h index e9e896606912..5c4c3363c7de 100644 --- a/drivers/net/wireless/marvell/mwifiex/fw.h +++ b/drivers/net/wireless/marvell/mwifiex/fw.h @@ -690,9 +690,7 @@ struct txpd { u8 priority; u8 flags; u8 pkt_delay_2ms; - u8 reserved1[2]; - u8 tx_token_id; - u8 reserved[2]; + u8 reserved1; } __packed; =20 struct rxpd { diff --git a/drivers/net/wireless/marvell/mwifiex/sta_tx.c b/drivers/net/wi= reless/marvell/mwifiex/sta_tx.c index 9d0ef04ebe02..857eb22f4c24 100644 --- a/drivers/net/wireless/marvell/mwifiex/sta_tx.c +++ b/drivers/net/wireless/marvell/mwifiex/sta_tx.c @@ -41,8 +41,8 @@ void mwifiex_process_sta_txpd(struct mwifiex_private *pri= v, =20 pkt_type =3D mwifiex_is_skb_mgmt_frame(skb) ? PKT_TYPE_MGMT : 0; =20 - pad =3D ((uintptr_t)skb->data - (sizeof(*local_tx_pd) + hroom)) & - (MWIFIEX_DMA_ALIGN_SZ - 1); + pad =3D (4 - (((void *)skb->data - NULL) & 0x3)) % 4; + skb_push(skb, sizeof(*local_tx_pd) + pad); =20 local_tx_pd =3D (struct txpd *) skb->data; @@ -58,12 +58,6 @@ void mwifiex_process_sta_txpd(struct mwifiex_private *pr= iv, local_tx_pd->pkt_delay_2ms =3D mwifiex_wmm_compute_drv_pkt_delay(priv, skb); =20 - if (tx_info->flags & MWIFIEX_BUF_FLAG_EAPOL_TX_STATUS || - tx_info->flags & MWIFIEX_BUF_FLAG_ACTION_TX_STATUS) { - local_tx_pd->tx_token_id =3D tx_info->ack_frame_id; - local_tx_pd->flags |=3D MWIFIEX_TXPD_FLAGS_REQ_TX_STATUS; - } - if (local_tx_pd->priority < ARRAY_SIZE(priv->wmm.user_pri_pkt_tx_ctrl)) /* --=20 2.51.1 From nobody Mon Feb 9 09:54:30 2026 Received: from smtp1.ms.mff.cuni.cz (smtp-in1.ms.mff.cuni.cz [195.113.20.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF4B22E92DA; Sun, 26 Oct 2025 18:27:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.113.20.234 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761503281; cv=none; b=pNFQT3B/K74CWib0yd3xwiC1osBrfYR3J4HSvWPLe+ls7JizXpGLm+jI3PZvY2yLwptzqZ3RwoppzRCYmdIjefpO0DAxnWTp3RflaYLVqbmZxJ32QCsFEtxYkasPtG2pvl82d4Zmh4nf/+UqGCtlT1JOs8j5MLWSQngU75CiT7g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761503281; c=relaxed/simple; bh=0HhYOYWxfjpg+9Kq7lCk7i1xML9Xo3LVDTHR8xeZOSk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H4FLMvrXMNcEQi9+nuTQRMbouIzMwu4YZJOed5edh/TwQblvxbGUL1qiIR/2s4S8ZNwDLjqayYkKc5fEoS9jjY3KY87njE3o2MXh5wPqAQWS1qd/L8/zqAtYTO1E7cQkc8GXezKNNOzghYE67hsyJWjIH8iRX/q3xx375MXwILg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=matfyz.cz; spf=pass smtp.mailfrom=matfyz.cz; dkim=pass (2048-bit key) header.d=mff.cuni.cz header.i=@mff.cuni.cz header.b=Alvj1afz; arc=none smtp.client-ip=195.113.20.234 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=matfyz.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=matfyz.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mff.cuni.cz header.i=@mff.cuni.cz header.b="Alvj1afz" X-SubmittedBy: id balejk@matfyz.cz subject /postalCode=110+2000/O=Univerzita+20Karlova/street=Ovocn+5CxC3+5CxBD+20trh+20560/5/ST=Praha,+20Hlavn+5CxC3+5CxAD+20m+5CxC4+5Cx9Bsto/C=CZ/CN=Karel+20Balej/emailAddress=balejk@matfyz.cz serial F5FD910E8FE2121B897F7E55B84E351D issued by /C=NL/O=GEANT+20Vereniging/CN=GEANT+20Personal+20CA+204 auth type TLS.CUNI DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mff.cuni.cz; s=submission; t=1761503228; x=1762803228; bh=thIl0eoythKb01PWr+ANwhU9Ff6R4yl+rTHFbaUTblI=; h=From; b=Alvj1afza8dYCwi0s/dGQRKNnatbHJflZbyYAYLJg0iaHsYdPTg3Ak3CnTSa4Mj0T H7D49mQ8BjVd6krsOK2qcgoUc+ziHnYRt+izW8yW5fOTXibom0SCSpm5T8R+lez2wG IH+5VJA0oCzOJikDRjHyosg72fInAPlXBsxFcGOlsemuBl4w+5/qAhGjowantpx9Nt 4bbE3S4MQwnMaQBd1z/FRxlpSFbfr+lyJyfPOiogPMx5p/QPF4w4FsIpWTMybkc9+1 mgO4TnvKR32d8Bbl9mpwf9iyFCHyr9+hCHs9VY70agWF1DWPTFUBAutZ6YDA5NVFF5 Y4GCS7skZiphQ== Received: from localhost (internet5.mraknet.com [185.200.108.250]) (authenticated) by smtp1.ms.mff.cuni.cz (8.16.1/8.16.1) with ESMTPS id 59QIR6Wb043073 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=OK); Sun, 26 Oct 2025 19:27:08 +0100 (CET) (envelope-from balejk@matfyz.cz) From: Karel Balej To: Johannes Berg , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?q?Duje=20Mihanovi=C4=87?= , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Brian Norris , Francesco Dolcini , Ulf Hansson , Frank Li , linux-wireless@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Karel Balej , Jeff Chen , Peng Fan Subject: [DONOTAPPLY RFC PATCH v2 4/4] arm64: dts: samsung,coreprimevelte: add wifi node Date: Sun, 26 Oct 2025 19:20:41 +0100 Message-ID: <20251026182602.26464-5-balejk@matfyz.cz> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251026182602.26464-1-balejk@matfyz.cz> References: <20251026182602.26464-1-balejk@matfyz.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a node for the phone's WiFi serviced by the Marvell SD8777 chip a communication with which happens over the SDIO. Also enable a regulator without which it is not possible to connect to networks although they are discovered properly. Signed-off-by: Karel Balej --- .../mmp/pxa1908-samsung-coreprimevelte.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/arch/arm64/boot/dts/marvell/mmp/pxa1908-samsung-coreprimevelte= .dts b/arch/arm64/boot/dts/marvell/mmp/pxa1908-samsung-coreprimevelte.dts index b2ce5edd9c6a..36d6ae4e902e 100644 --- a/arch/arm64/boot/dts/marvell/mmp/pxa1908-samsung-coreprimevelte.dts +++ b/arch/arm64/boot/dts/marvell/mmp/pxa1908-samsung-coreprimevelte.dts @@ -475,6 +475,14 @@ ldo14: ldo14 { regulator-min-microvolt =3D <1200000>; regulator-max-microvolt =3D <3300000>; }; + + /* + * Needs to be enabled in order for the WiFi to be able + * to connect to networks. + */ + ldo15 { + regulator-always-on; + }; }; }; }; @@ -523,6 +531,13 @@ &sdh1 { pinctrl-1 =3D <&sdh1_fast_pins_0 &sdh1_fast_pins_1 &sdh1_pins_2>; bus-width =3D <4>; non-removable; + #address-cells =3D <1>; + #size-cells =3D <0>; + + wifi@1 { + compatible =3D "marvell,sd8777"; + reg =3D <1>; + }; }; =20 &pwm3 { --=20 2.51.1