From nobody Sat Feb 7 12:19:38 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59492207A22 for ; Sun, 26 Oct 2025 16:44:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761497080; cv=none; b=X1Mlg50iFReJw9Xu3SYSThneaLvsQDaApneJOFApV/wQwMDIzXoG39x8M6mRXfxiKMUgZ/KwHLq2IMx4AtncDVVf9NjiiB3nZehLZVJcEm3N1CSpDSwmlgRRiXC5yTFoHwtObJcxYT8VWgRogph6vKRGdDMmKbZHZ7qLOic1QhQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761497080; c=relaxed/simple; bh=eQUOoR9FD3UwTeZyPSZWJNKIzcKibTzjwuLGuN9r9W8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=EaeiPZcQ3bDYLhDOcvbAMwGrFRGSVHLbYrGlhIUTYXfFG7wUul3OFKb7pqj95W/MsTTwwGqSHiLyZgmE9OJNXsfbKTLrZvJq9Ml3XKEAdsu1tnYhTxsGYhFrGgY6SSaGAa8wgINqsFrg2TzF9tBy8WFw+JNjoCz/3qy1Slc/enY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ac6DUDQD; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ac6DUDQD" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-781ea2cee3fso3551813b3a.0 for ; Sun, 26 Oct 2025 09:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761497079; x=1762101879; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OFfVLgzVjo4apr0F+9sFbXPgvyArU5e8XxuMCreDUBs=; b=Ac6DUDQDiSqha8TOhpNWOy1v4k4BWEPkFUBk1QP17CIF8yHldefaXWI5zassdy+prA g4N2SlPHpaaoQ4FBct+YD4Eahk6TU6cWdOZVy+ImjTiMWa7rXG4V7ZoiqSyk39iLlgnA Ex1rKWoOpHTHwEYEOVEKOORBXLK5bhWtr6KLAewwf9x4yU6fkTMmVu5DYlb0P8XOzkkM Lu4pddOAZk0KwUO5NFoSFh7FqoIvmAcRPBSiU6srzeU1W7LLm27MdqZvxQTfZIJiHNwJ 4yrDENrUACx21mLAxbjsdNIp/NV7ORfWcCxuFEm/QFNeVvZrOdsrptiuEvctu9czYL2n xmjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761497079; x=1762101879; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OFfVLgzVjo4apr0F+9sFbXPgvyArU5e8XxuMCreDUBs=; b=wTQOn41PwnB9L91CjyAdha3rKroPjyUPz9OSv+hWPueN6grQTHseihamQNjgBZho+p kaRPrAOBIw2I9+u9mhe3f3tf8mSPZD1YjkR4CCF989To7gU5FwSwvArPIIDxrWmrMJL/ IvS+b1qyUiy9FYZVViVZaxNxALRgJqzjkuugAxC9XnoZGl9bAl+aluUvGBHCQJAywxMy DOsOvhYPfxVAJi8CoVvY22hKJV63/r+iN2QwFJgQMS+kl20HPkjizmzVqQGbjgDQdA34 EF2VFM1ZtsIU/JLBZCzTPCYV04XXaSeOIWoWh1O8AcLjzhpZz+sMXShrHlGL4yOF786s lqCA== X-Forwarded-Encrypted: i=1; AJvYcCUeOvynrHAGpBLYouugRCebSlgJjAxRxGo2eWumTLpKIeBml1XviHqDb6KM/IM5OOs516zx6kVCIvNOfj4=@vger.kernel.org X-Gm-Message-State: AOJu0YysKOoMc42Ev/v+LPcE4iG3hZ8UqwOjdSiVvy91b/Q0w90ptv+m DYBW+yyWF14L9LoNzbwmAmI3In/4x7l0KACaypgAoEqcp25nQkBk/rVm X-Gm-Gg: ASbGncv7v6NX6cX/EwwWl8vWva7PPoRWOQs/a8KMXtX3HIvPITJbAoNOJ/ccrYh91BN CCUKK/d1Bmqc9RVymS4XpYzdNtJMyx1nHaRuHeAILYognsbNUB06nY95IIuZTeu3tORkCvyjfJh PMpnZpXivsWeE46WbKkYrPWP5/57lLpFc5Nee6e5+pe35v81RXv5AkZbUR7/z5Q7OPpshhTGzpm Oq4XG1DTV2ukQfT5Yk4AtwR9Va4eybv3NF6Loj/hEgmhKmGjIIMN/mAa54zroEEY85FIetEu4wt litN75rHEpv4v7/2+2uNY9EAJIgoqhIwhQTbxTVDmUMj2/QjJK9GF+0/+ZQBKmwT4nWut/JrGYf mF94p1F5RavI2oHBpo6c60lmAQTPkizU5pHnVdVhZIX0/YNT3DWlsGti4QFhk/gKJulIeWLTJnJ DMusqh75zsoF6TQVCb5Wj15xO96oJgV3Kf X-Google-Smtp-Source: AGHT+IG49PJG/CbqXkaLHQC41z6X6jQK0xuoXYiEh+MDaaZLvv+6LBLNMogH8+OEV/PxbJSmU+sHyg== X-Received: by 2002:a05:6a20:7d9f:b0:262:1611:6528 with SMTP id adf61e73a8af0-33deae4e085mr11445565637.29.1761497078563; Sun, 26 Oct 2025 09:44:38 -0700 (PDT) Received: from localhost.localdomain ([124.77.218.104]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7a414072492sm5307768b3a.53.2025.10.26.09.44.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 26 Oct 2025 09:44:38 -0700 (PDT) From: Miaoqian Lin To: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Yu-Che Cheng , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com, stable@vger.kernel.org Subject: [PATCH] thermal/of: Fix reference count leak in thermal_of_cm_lookup Date: Mon, 27 Oct 2025 00:44:22 +0800 Message-Id: <20251026164422.58128-1-linmq006@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function calls of_parse_phandle() to get a device node, which increments the reference count of the node. However, the function fails to call of_node_put() to decrement the reference. This leads to a reference count leak. This is found by static analysis and similar to the commit a508e33956b5 ("ipmi:ipmb: Fix refcount leak in ipmi_ipmb_probe") Fixes: 423de5b5bc5b ("thermal/of: Fix cdev lookup in thermal_of_should_bind= ()") Cc: stable@vger.kernel.org Signed-off-by: Miaoqian Lin --- drivers/thermal/thermal_of.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c index 1a51a4d240ff..932291648683 100644 --- a/drivers/thermal/thermal_of.c +++ b/drivers/thermal/thermal_of.c @@ -284,8 +284,12 @@ static bool thermal_of_cm_lookup(struct device_node *c= m_np, int count, i; =20 tr_np =3D of_parse_phandle(child, "trip", 0); - if (tr_np !=3D trip->priv) + if (tr_np !=3D trip->priv) { + of_node_put(tr_np); continue; + } + + of_node_put(tr_np); =20 /* The trip has been found, look up the cdev. */ count =3D of_count_phandle_with_args(child, "cooling-device", --=20 2.39.5 (Apple Git-154)