From nobody Sun Dec 14 22:15:43 2025 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C95925392A for ; Sun, 26 Oct 2025 16:43:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761497020; cv=none; b=QQ6YmE7/E7Bwwvc4awDbxIN7iPHRKhks1/nfsOFqk8GsctTatkTTLI3q7U76TUBPjCo5MsTyUZ+944q4tG5ysS+xISmRaBXlQBz6576W+ty07Afg2BqTy7PY5z9u0R+U3jd6jYfFOtqcuYFp8kuamp4VaAbuLsKQVm2I+Q1jZuE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761497020; c=relaxed/simple; bh=2blCvwW/JNfSePtiQhOpyFAVkiDR84ySlcLJfmQoOvc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=YCgUlFavY80OxAeo7v2Y7MxBmYCj4OQqOgH46TOnsHJN2k7/0Nim1wLKpiCVaprXF2EaPx8cM4Hu5Gaq2xFhyT3QpbWsdzr+Ys+FKQVvqqASI85OIC9fEp0OdusU5Vs+5YEBLsaxGv79tISkDI/YbDhOIXLvTNC1HRW/Psj56x4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DxAXl5sQ; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DxAXl5sQ" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-7a4176547bfso929124b3a.2 for ; Sun, 26 Oct 2025 09:43:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761497018; x=1762101818; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jCF061NAS8FhFP3hNpS05moHDGkV+h3U/U3CN5+nY3Y=; b=DxAXl5sQtELRP1vcSZKU/GpY9atRPG/tlMzgWNQqc6HLf0hkZWybnzK7UbPByM98hn Za0+1LO4s9ryppsa1kUqDjYSOxw0yMVtUAQwNo80OkcPKVh6Xmz55KvA0704fhyd4edn dgqFKS4Dj1l/wHvZJqaeMPE054Yc+NqKGL5aefM5iba2iVEbzsUqvxcAthlx76k+ri7f uE1RdSVkJvk8Kq0zgLEnp/rjyBNQQvp7UMmqjYE+LOo6aoIgRpohGWilR9XYq81sy0QS F1WEzUBKhEVM5LCJqcrOD26IWhmOtvRU7/GGDzf28RQV2diUrJrX9ABeMt9rOYSPNL2E wkig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761497018; x=1762101818; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jCF061NAS8FhFP3hNpS05moHDGkV+h3U/U3CN5+nY3Y=; b=gFFbDAheD+9pTc5qL4uchHx9kd9JQzc2NJJ52mI0LxiJPHoKr5bIIEQj0Cj3ayw/XS 4VN7FoS6pDCh61ZtbkHhmdBQkdWm2y5fyGEhlibQx793X/dWEQXNP4B9QGcQt9yHlfWW 8E3mBeNrLsbdoDLypVbi/2VKRNLiSfPM2oF6DwfT/tqUOnEmWepKdRoACExo7TSZmb8e i+D2SXiePWN11bqWLmZVW2+8i0kPffcBDBrgB1yInv2lP7hA4bHjHv5x4wFtbbr0iH3h 3ZSi4dI+gu15iEl3eTdUO6/1JBWsIIr5ZQTpk9q6ZwMvsJVTHhH+is1sDocDk5z6FJku nAOw== X-Forwarded-Encrypted: i=1; AJvYcCVLEFm6NGMFfRIC21YSxRO7uwXbhfxnsNYOmUh1yl+WpufhvWns4aIRgvEHlAdlC1jRXxYVU4ilmEsWVzc=@vger.kernel.org X-Gm-Message-State: AOJu0YwMgYv6W4BEd2M+riNwltHsSO6kmN9ealkK/g24za/r2jIO3HY1 en07/J6vnqKpl9s+lERJtJs4XmgtMfWOwYYvVSn1A1hnvUpN60VVZfxH X-Gm-Gg: ASbGncsDFYPx3AxSOfQxkuvbPmRGT61pg1hi8G73rquzCt8Byp9KOwG/JShVgKQyEj1 9lK/vofdh+ouQBGydRPiH2j6UqHOhjV4hYLm6TolXFTJyLkJ52KI4zkML/Qy/0cK3rXUAAPcxYu Cxm5uhL0F5Tj45wZ7jWWuGgLa7VzsWv5/zK4Hy0FYonYDwvYSOJNg4ciP0uGhljnTcBXYWInu6R +Miio7BqLMJS/B/lLDZiPN749gjytkbEGdbBzhV1qdT5Ut+8mxBIi1m21rNqYce2nTuRm0zbthF mBGvOKoJ+468n+mo1+mHl4++IDc8Wmb5oyVklT7aKox3nTdpyt/7K74xCPCPG29PlszJDdVcFee EOrjyl6Yc2F8+O/sm/89xteMxHvTMrS7JzzT5ngPWozNnDV2ujhwo7MgTq7gnVt4o1D7MMQMD5K uB2ZRWlLtOSYG7K6z1Xmuu7deD66C1ECdnn9ZZ4xyhcWE= X-Google-Smtp-Source: AGHT+IFf+qjeyS6hjsC0nfYxfHIiI+ppqXHvuLXgsxBumfjvvdYcGEtHm3eqB+rkAU1cSh6c7pSxUA== X-Received: by 2002:a17:903:2446:b0:290:6b30:fb3 with SMTP id d9443c01a7336-2948b97658bmr102681155ad.16.1761497017589; Sun, 26 Oct 2025 09:43:37 -0700 (PDT) Received: from localhost.localdomain ([124.77.218.104]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-33fee8014f6sm2961731a91.0.2025.10.26.09.43.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 26 Oct 2025 09:43:37 -0700 (PDT) From: Miaoqian Lin To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Oleksij Rempel , Xu Yang , Yuichiro Tsuji , Max Schulze , =?UTF-8?q?Krzysztof=20Ha=C5=82asa?= , David Hollis , Greg Kroah-Hartman , David Brownell , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com, stable@vger.kernel.org Subject: [PATCH v2] net: usb: asix_devices: Check return value of usbnet_get_endpoints Date: Mon, 27 Oct 2025 00:43:16 +0800 Message-Id: <20251026164318.57624-1-linmq006@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The code did not check the return value of usbnet_get_endpoints. Add checks and return the error if it fails to transfer the error. Found via static anlaysis and this is similar to commit 07161b2416f7 ("sr9800: Add check for usbnet_get_endpoints"). Fixes: 933a27d39e0e ("USB: asix - Add AX88178 support and many other change= s") Fixes: 2e55cc7210fe ("[PATCH] USB: usbnet (3/9) module for ASIX Ethernet ad= apters") Cc: stable@vger.kernel.org Signed-off-by: Miaoqian Lin --- - v1:http://lore.kernel.org/all/20250830103743.2118777-1-linmq006@gmail.com changes in v2: - fix the blank line. - update message to clarify how this is detected - add Cc: stable --- drivers/net/usb/asix_devices.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c index 85bd5d845409..232bbd79a4de 100644 --- a/drivers/net/usb/asix_devices.c +++ b/drivers/net/usb/asix_devices.c @@ -230,7 +230,9 @@ static int ax88172_bind(struct usbnet *dev, struct usb_= interface *intf) int i; unsigned long gpio_bits =3D dev->driver_info->data; =20 - usbnet_get_endpoints(dev,intf); + ret =3D usbnet_get_endpoints(dev, intf); + if (ret) + goto out; =20 /* Toggle the GPIOs in a manufacturer/model specific way */ for (i =3D 2; i >=3D 0; i--) { @@ -848,7 +850,9 @@ static int ax88772_bind(struct usbnet *dev, struct usb_= interface *intf) =20 dev->driver_priv =3D priv; =20 - usbnet_get_endpoints(dev, intf); + ret =3D usbnet_get_endpoints(dev, intf); + if (ret) + return ret; =20 /* Maybe the boot loader passed the MAC address via device tree */ if (!eth_platform_get_mac_address(&dev->udev->dev, buf)) { @@ -1281,7 +1285,9 @@ static int ax88178_bind(struct usbnet *dev, struct us= b_interface *intf) int ret; u8 buf[ETH_ALEN] =3D {0}; =20 - usbnet_get_endpoints(dev,intf); + ret =3D usbnet_get_endpoints(dev, intf); + if (ret) + return ret; =20 /* Get the MAC address */ ret =3D asix_read_cmd(dev, AX_CMD_READ_NODE_ID, 0, 0, ETH_ALEN, buf, 0); --=20 2.39.5 (Apple Git-154)