From nobody Sat Feb 7 22:55:03 2026 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6D47212B31 for ; Sun, 26 Oct 2025 16:38:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.188 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761496731; cv=none; b=gMxliBv1l4iNiDGrYiwZt5wolFSK0L7hy6rmyg+nKJWFiC+nRdMUWNtNcPXiUTixXMd1NabnE0EkU6t6PSPz+pNKVIj34SEIVdsR+fVPiRvskw7mmZPipDaf+bLwAUU4aB2OX2SvTIy8aeKGdx6NkC6G1IxVSglh5ql9oia8aA4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761496731; c=relaxed/simple; bh=DEw7ZOeAhejnvjJ1BDBFz3PfQdtqnj7GFeIhTc3OuG0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EeSts5ONfMRcLq9FajBqPKrZmqB5rLQINqE5jkLEgeReIQkeAOTKPIWwQH4smz9n28ilS1YeO1WOp3mHBdMFan6RhlHUKKs5EOJjdsx/Xqtg/gu/dxigkq5qjgzRw9pNdyJETTY2sDpQrB2gEhR2iPpjLqzai9dQcrPGrTFMLV8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=LzSQOpsJ; arc=none smtp.client-ip=91.218.175.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="LzSQOpsJ" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1761496727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HFoJR/u0IaB/0PpKtMKlYiR9B8oxdFtp8dSKC4xgXkY=; b=LzSQOpsJHn6rFsK+TfZWJOs4aaD/pVMhAHOY7TtByt2X/ef4VXy8Ycy/E2zHUZLDkEmcth wvzNb6T5mXqUyzqvrZAI6tPdjcqa09KbyDEoCvvcfZ07nZ0VqFzqa9i8GCrHdcepqmHzCg A77mM81A8q33C3GBRRAa0e/EGqhNbbI= From: KaFai Wan To: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, shuah@kernel.org, paul.chaignon@gmail.com, m.shachnai@gmail.com, memxor@gmail.com, harishankar.vishwanathan@gmail.com, colin.i.king@gmail.com, kafai.wan@linux.dev, luis.gerhorst@fau.de, shung-hsi.yu@suse.com, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: syzbot+c950cc277150935cc0b5@syzkaller.appspotmail.com Subject: [PATCH bpf-next 1/2] bpf: Fix tnum_overlap to check for zero mask first Date: Mon, 27 Oct 2025 00:38:05 +0800 Message-ID: <20251026163806.3300636-2-kafai.wan@linux.dev> In-Reply-To: <20251026163806.3300636-1-kafai.wan@linux.dev> References: <20251026163806.3300636-1-kafai.wan@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Syzbot reported a kernel warning due to a range invariant violation in the BPF verifier. The issue occurs when tnum_overlap() fails to detect that two tnums don't have any overlapping bits. The problematic BPF program: 0: call bpf_get_prandom_u32 1: r6 =3D r0 2: r6 &=3D 0xFFFFFFFFFFFFFFF0 3: r7 =3D r0 4: r7 &=3D 0x07 5: r7 -=3D 0xFF 6: if r6 =3D=3D r7 goto After instruction 5, R7 has the range: R7: u64=3D[0xffffffffffffff01, 0xffffffffffffff08] var_off=3D(0xffffffff= ffffff00; 0xf) R6 and R7 don't overlap since they have no agreeing bits. However, is_branch_taken() fails to recognize this, causing the verifier to refine register bounds and end up with inconsistent bounds: 6: if r6 =3D=3D r7 goto R6: u64=3D[0xffffffffffffff01, 0xffffffffffffff00] var_off=3D(0xffffffff= ffffff00, 0x0) R7: u64=3D[0xffffffffffffff01, 0xffffffffffffff00] var_off=3D(0xffffffff= ffffff00, 0x0) The root cause is that tnum_overlap() doesn't properly handle the case where the masks have no overlapping bits. Fix this by adding an early check for zero mask intersection in tnum_overla= p(). Reported-by: syzbot+c950cc277150935cc0b5@syzkaller.appspotmail.com Fixes: f41345f47fb2 ("bpf: Use tnums for JEQ/JNE is_branch_taken logic") Signed-off-by: KaFai Wan --- kernel/bpf/tnum.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/bpf/tnum.c b/kernel/bpf/tnum.c index f8e70e9c3998..af2f38b4f840 100644 --- a/kernel/bpf/tnum.c +++ b/kernel/bpf/tnum.c @@ -163,6 +163,8 @@ bool tnum_overlap(struct tnum a, struct tnum b) { u64 mu; =20 + if ((a.mask & b.mask) =3D=3D 0) + return false; mu =3D ~a.mask & ~b.mask; return (a.value & mu) =3D=3D (b.value & mu); } --=20 2.43.0 From nobody Sat Feb 7 22:55:03 2026 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23AED2E8E16 for ; Sun, 26 Oct 2025 16:38:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761496738; cv=none; b=FgVYN3CcLh3H3JBj6diWXA4nnTlE7ISQFb7r0flFF6edsR90M78FrNHnghqdfQ7xblJhsPzSZff9e9zN1WA67ntBJkGj84GjqsGUnYWUJ82XpPyWLmxdyXAUEKqMuzZqp6iz+7W1d6G9bmtvwU3qCAwKHDyNuRdcXTsWEKjDvkI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761496738; c=relaxed/simple; bh=HYd2qH7FWSYKEo+EVxagg1RUtl38TekujFQnRYEMBtY=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=axJJETHFr2CPid89OiGACfgSdFKTTAlZsKdOFMeNrEb2uw3NhIgkx/NH1fjZkZfToF8q+/mKPFzlhiJScSfSSZTDULON6Zp8gl2+yqh/7yL+ueyUvRLs/uxLi2oh6pnkizS1hAvaqG/gRMtHgRw7N6GffFjV3gwlOLl/sVvLt8M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=SXjuy59a; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="SXjuy59a" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1761496735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FBxBqu3N+DlOX27bsFsVYIxqbBpbd6ybHXvJvZNNT5E=; b=SXjuy59ahh3w+VrMyR309CrXCHXNiM3FjCgKOoHtccqeUsyUNSVP/uT5On83uo6AiMA5++ Chuvw2x21hwyatCb+D/eupYeDviCex0uhCsr++UJ0485Fh4cQ/QeXgkVkCB/V5yV+kBqFJ ioFECGwK6xo7KQnFQR5qdvkq3YV7vYE= From: KaFai Wan To: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, shuah@kernel.org, paul.chaignon@gmail.com, m.shachnai@gmail.com, memxor@gmail.com, harishankar.vishwanathan@gmail.com, colin.i.king@gmail.com, kafai.wan@linux.dev, luis.gerhorst@fau.de, shung-hsi.yu@suse.com, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH bpf-next 2/2] selftests/bpf: Range analysis test case for JEQ Date: Mon, 27 Oct 2025 00:38:06 +0800 Message-ID: <20251026163806.3300636-3-kafai.wan@linux.dev> In-Reply-To: <20251026163806.3300636-1-kafai.wan@linux.dev> References: <20251026163806.3300636-1-kafai.wan@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" This patch adds coverage for the warning detected by syzkaller and fixed in the previous patch. Without the previous patch, this test fails with: verifier bug: REG INVARIANTS VIOLATION (true_reg1): range bounds violation u64=3D[0xffffffffffffff01, 0xffffffffffffff00] s64=3D[0xffffffffffffff01, 0xffffffffffffff00] u32=3D[0xffffff01, 0xffffff00] s32=3D[0xffffff00, 0xffffff00] var_off=3D(0xffffffffffffff00, 0x0) verifier bug: REG INVARIANTS VIOLATION (true_reg2): range bounds violation u64=3D[0xffffffffffffff01, 0xffffffffffffff00] s64=3D[0xffffffffffffff01, 0xffffffffffffff00] u32=3D[0xffffff01, 0xffffff00] s32=3D[0xffffff01, 0xffffff00] var_off=3D(0xffffffffffffff00, 0x0) Signed-off-by: KaFai Wan --- .../selftests/bpf/progs/verifier_bounds.c | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/tools/testing/selftests/bpf/progs/verifier_bounds.c b/tools/te= sting/selftests/bpf/progs/verifier_bounds.c index 0a72e0228ea9..304ab5a07a3b 100644 --- a/tools/testing/selftests/bpf/progs/verifier_bounds.c +++ b/tools/testing/selftests/bpf/progs/verifier_bounds.c @@ -1550,6 +1550,29 @@ l0_%=3D: r0 =3D 0; \ : __clobber_all); } =20 +SEC("socket") +__description("dead branch on jeq, does not result in invariants violation= error") +__success __log_level(2) +__retval(0) __flag(BPF_F_TEST_REG_INVARIANTS) +__naked void jeq_range_analysis(void) +{ + asm volatile (" \ + call %[bpf_get_prandom_u32]; \ + r6 =3D r0; \ + r6 &=3D 0xFFFFFFFFFFFFFFF0; \ + r7 =3D r0; \ + r7 &=3D 0x07; \ + r7 -=3D 0xFF; \ + if r6 =3D=3D r7 goto l1_%=3D; \ +l0_%=3D: r0 =3D 0; \ + exit; \ +l1_%=3D: r0 =3D 1; \ + exit; \ +" : + : __imm(bpf_get_prandom_u32) + : __clobber_all); +} + /* This test covers the bounds deduction on 64bits when the s64 and u64 ra= nges * overlap on the negative side. At instruction 7, the ranges look as foll= ows: * --=20 2.43.0