From nobody Sun Feb 8 20:32:59 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B179199FAB for ; Sun, 26 Oct 2025 09:19:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761470369; cv=none; b=gF17H6RGjjV6xse48ykJbKAjX/TmE6aJeR981wP/IQmnUV7dNiRqVNxqoYP5TzI9XvL9FXdBRXT+igIwoGTcEX3kpbnwpKumos4CZ7frEy/tP7p6AQaWz+1z0js3NAWN3IYYSdVk1IABj0psJawbgS4UtArkX/X7O4rmE8eMHLk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761470369; c=relaxed/simple; bh=m5dBsLXxcjfd/Jg1/TXpqHofhyi2GbaizAwo22sE+Vo=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=nE+PusK6RaHO3xM/iTbY7nXgL3Ciqn5WtiIafyXRYdtZsUYh7U2YPPG0Trv5TLyk+xIDJb8Zj0skpY7KmGRQjW49NtVK1H5jgdOU9GRXFK7Lj1giYT4kj5rA0rOYm390bnMOAtFbqgArkzdStQT9Uzv65PkNGON2jw3PnealoMw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ml0MAfpw; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ml0MAfpw" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-33ba5d8f3bfso3102637a91.3 for ; Sun, 26 Oct 2025 02:19:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761470367; x=1762075167; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=udg3CwQcBQ0BBJcZyhfktrzA11lxinS2ppEpd97MHiI=; b=Ml0MAfpwNv3AzOq4d0mscFCR4XbuUZTc5LaQIziZ3sXzatAdnA/iSDuLm6LfVqmHFR KGqYc6CM6Mc43M2cyXKmib4L/LsyAB5g7v83jjDFrvh2sgd4W8G0kFr6RHbwF9LF5hrR NLgDNhYpL09IvciYyQLgkIvB1Kj0DSS1p2P6D9bI5Rv65dGV7963YnrBfUZyHS0sCXUn lZusZ5ba/efn9DM0tV5AKCEmABeSA59u5ulEp4zSmIcyXuRcu8F3fSwmD+PebSs7alk+ KbizxaRy9+h3qr8bSEJvyW64j/rDeFRpinfhsboK4Zq8poE5EHKAvTLxIHIMY8n8VNVO Ceew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761470367; x=1762075167; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=udg3CwQcBQ0BBJcZyhfktrzA11lxinS2ppEpd97MHiI=; b=VfeB+AYxzCj35Cfe2mSRCkjRbavaOP9mY41Y3iimHHbGGvoAebJ1jM7tCn362YhexA 53FhwG1T5efqLMm7rVLbufcTPjEKq2yuVHQhy3vik/5jZ+OMyZsPA/d7lNVE/WuRkJdz 6InJxVIJ9sPTCIvLQju0/deHEZGk6inyTycMdQVmJdoCmvxeR8tGzAiq+WhDxp8cnjkT F37VrRB2aJK8j0pDpPKtrzaL0hGWK+hLk5kY+ztshcijZZ+4dZdq027YBWHPFkCKSjza nrLkCnqdhxllk+hKAS0dh7ohsljW9fPVorHZm3OxyP/KIh3XD20GmmRSCk1Jnf/CCqSC EfqQ== X-Forwarded-Encrypted: i=1; AJvYcCXf8WzCPk2MAy4e3BNojLPz8lQWuAHEWx/CgmYlTxdGpv2KlvjdbqTlY8ErNqnwQUI4okLqlP9dDR3cJ/g=@vger.kernel.org X-Gm-Message-State: AOJu0Yzy1gX4jDNC2rZWQQfFwK8oV+Jbqd9vwx2tP0PLV3DsyGgDhNv/ HP62LJps+9fw/EZcflCgaQnxOQ8qxvITz+g3huuT8jqSgXo9Pe/GJtlG X-Gm-Gg: ASbGnctxlkW/3SCP2TVYYah3JgKo+gy/QIDLAGWAJakkslWKn9bDM3hYzbi+m8w3SI6 wBKD7rIu3UpzJq1WsCb5aojlFV7ngUh2uckTX1bQvaz6esWD+Ob/KELeDM8UOTBscYsKtYTR7CL kdUgMnOd1zy/RU5aGwz/pYYwuclRbC2EmjgmoPUpmFLPXTogTbFds17VRv3y2akyVd0MjWWRY6i VHWEqb5LWS7g8rr2SAbddNFTTVK2dpQebmcUJLcxWzAJ6E6X1fHpC2mG+xxKXqiqwY6HhHzob9p RndAE7tMiYsXBCQLFYdILS2sr5Sat3ZN+/LICDYl4NRpZ5P0B9nRkBi/Of9DDZKbwBXHCEA1FDj nOCYSn9otXB9Cg/x/Sc+hGzuQK34Nu54BeMCQsiENLQCLthbC0RalPRnfjDbt9fFjKJFN+G2DG0 zE+x8jFw5n+kp8Fyxkq9JiEQ== X-Google-Smtp-Source: AGHT+IH6eN+njVM8GBwTsi7fLGE3YNfCJKSism0LE4927eZ8Rab/oS7OTOf02WSA0mHpx2ydqTM/Bg== X-Received: by 2002:a17:90b:4c48:b0:32e:936f:ad7 with SMTP id 98e67ed59e1d1-33bcf8f8737mr8845587a91.27.1761470367609; Sun, 26 Oct 2025 02:19:27 -0700 (PDT) Received: from localhost.localdomain ([124.77.218.104]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-33fee418419sm1947131a91.12.2025.10.26.02.19.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 26 Oct 2025 02:19:27 -0700 (PDT) From: Miaoqian Lin To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Samuel Holland , Andrew Jones , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Cc: linmq006@gmail.com, stable@vger.kernel.org Subject: [PATCH] riscv: Fix memory leak in module_frob_arch_sections() Date: Sun, 26 Oct 2025 17:19:08 +0800 Message-Id: <20251026091912.39727-1-linmq006@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The current code directly overwrites the scratch pointer with the return value of kvrealloc(). If kvrealloc() fails and returns NULL, the original buffer becomes unreachable, causing a memory leak. Fix this by using a temporary variable to store kvrealloc()'s return value and only update the scratch pointer on success. Found via static anlaysis and this is similar to commit 42378a9ca553 ("bpf, verifier: Fix memory leak in array reallocation for stack state") Fixes: be17c0df6795 ("riscv: module: Optimize PLT/GOT entry counting") Cc: stable@vger.kernel.org Signed-off-by: Miaoqian Lin --- arch/riscv/kernel/module-sections.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/riscv/kernel/module-sections.c b/arch/riscv/kernel/module= -sections.c index 75551ac6504c..1675cbad8619 100644 --- a/arch/riscv/kernel/module-sections.c +++ b/arch/riscv/kernel/module-sections.c @@ -119,6 +119,7 @@ int module_frob_arch_sections(Elf_Ehdr *ehdr, Elf_Shdr = *sechdrs, unsigned int num_plts =3D 0; unsigned int num_gots =3D 0; Elf_Rela *scratch =3D NULL; + Elf_Rela *new_scratch; size_t scratch_size =3D 0; int i; =20 @@ -168,9 +169,12 @@ int module_frob_arch_sections(Elf_Ehdr *ehdr, Elf_Shdr= *sechdrs, scratch_size_needed =3D (num_scratch_relas + num_relas) * sizeof(*scratc= h); if (scratch_size_needed > scratch_size) { scratch_size =3D scratch_size_needed; - scratch =3D kvrealloc(scratch, scratch_size, GFP_KERNEL); - if (!scratch) + new_scratch =3D kvrealloc(scratch, scratch_size, GFP_KERNEL); + if (!new_scratch) { + kvfree(scratch); return -ENOMEM; + } + scratch =3D new_scratch; } =20 for (size_t j =3D 0; j < num_relas; j++) --=20 2.39.5 (Apple Git-154)