From nobody Mon Feb 9 04:29:00 2026 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B84C020408A for ; Sun, 26 Oct 2025 01:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761443866; cv=none; b=psmHUAjl4DuBeJIH43G19cT2/l+ppOcJsOkeqkBVwOEwa/onBI1sqFEZ4fG25BQBs8oJPhsqrXdhAVA+ipUkysRvH1KGa/xBrcC9Z3w8/INPuZM0ZGyiDT3oHectg3sRB32+OCosUWq0A5JeuT3HQF8UzuMRUPCC4fG4jeaCsyE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761443866; c=relaxed/simple; bh=oPikvwt45BVYvYTWxBgaE9XM1ulsKhp78n5H8z0kqm8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=enu3Eomv7j7zXCLZZc1P5fNyIoD/JnQUGCgW5Sdr7qYywgpqHtWgE3y2JsHfeUv2v9pxOSoN/Pl2lARUgFTTDCuDBKI/gAMyrUqUzYbXhfjggNCV2Q9ie1r4w2EGS8b2FLgOiwTwVUpNzgILbqEqt/P0PKj6uzBog+npga+y7wQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=kG4OjdpU; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="kG4OjdpU" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1761443861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=NNgxyD0sVa6QuTrTPdQX4llkf4PVAjU/F33ptCCYNVk=; b=kG4OjdpU0+3I1DUsjRelaOu4+EkP8cPzC//YKkR9DZ2xL1QhSQLZymHhhacB7XaH8WWA/Q s1w7Jd6ad7jzZ8TQtHKaRCmKwl14M8WFzwuJFu8oH/MhAWgeLyzWtYxXqjMWhpSydOPEpY IiqZunVO0cpvDPfo+YgnBwmdbev//qw= From: Thorsten Blum To: Giovanni Cabiddu , Herbert Xu , "David S. Miller" , Andy Shevchenko , Jack Xu , Suman Kumar Chakraborty , Qianfeng Rong Cc: Thorsten Blum , qat-linux@intel.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] crypto: qat - use simple_strtoull to improve qat_uclo_parse_num Date: Sun, 26 Oct 2025 02:57:07 +0100 Message-ID: <20251026015710.1368-1-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Replace the manual string copying and parsing logic with a call to simple_strtoull() to simplify and improve qat_uclo_parse_num(). Ensure that the parsed number does not exceed UINT_MAX, and add an approximate upper-bound check (no more than 19 digits) to guard against overflow. Signed-off-by: Thorsten Blum Acked-by: Giovanni Cabiddu Reviewed-by: Andy Shevchenko Reviewed-by; Andy Shevchenko --- Changes in v2: - Use simple_strtoull(), return -EINVAL, and guard against overflow as suggested by Andy - Link to v1: https://lore.kernel.org/lkml/20251022123622.349544-1-thorsten= .blum@linux.dev/ --- drivers/crypto/intel/qat/qat_common/qat_uclo.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/crypto/intel/qat/qat_common/qat_uclo.c b/drivers/crypt= o/intel/qat/qat_common/qat_uclo.c index 18c3e4416dc5..06d49cb781ae 100644 --- a/drivers/crypto/intel/qat/qat_common/qat_uclo.c +++ b/drivers/crypto/intel/qat/qat_common/qat_uclo.c @@ -200,20 +200,12 @@ qat_uclo_cleanup_batch_init_list(struct icp_qat_fw_lo= ader_handle *handle, =20 static int qat_uclo_parse_num(char *str, unsigned int *num) { - char buf[16] =3D {0}; - unsigned long ae =3D 0; - int i; - - strscpy(buf, str, sizeof(buf)); - for (i =3D 0; i < 16; i++) { - if (!isdigit(buf[i])) { - buf[i] =3D '\0'; - break; - } - } - if ((kstrtoul(buf, 10, &ae))) - return -EFAULT; + unsigned long long ae; + char *end; =20 + ae =3D simple_strtoull(str, &end, 10); + if (ae > UINT_MAX || str =3D=3D end || (end - str) > 19) + return -EINVAL; *num =3D (unsigned int)ae; return 0; } --=20 2.51.0