From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40D683054F0 for ; Sat, 25 Oct 2025 16:40:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410432; cv=none; b=cu8QWbOMxkf71J2yh6RO0xvDCURQQf5dxvpNM7HasmK6wj4gYBxxjhUaLyJB8U/PmQcOVRi6q72IXCM6BARUbU0Xhi8VuxIfHiKdFnkTkBcj3pGPIUetMgKVNYEiD6HnVn1E2C/hnfX6VlK7TvC5x2YIa/b5bLCvXK7aXgevKko= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410432; c=relaxed/simple; bh=GD9r0peLG2k6Dz8bSnVBhsVzehUcmhQIE13Y757qu+E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dtPikHNkzxlp6SMPyXQanhA6qMUlSuHLbbAaPPEDrBW28kuMp3U/xgzds7bYLWED+p8nb/MvCpgOU+Q7fUiFFd8f0KCxsrVGdp4p8SOhYygIwlW4WDHL7uTMiH7wG3SCj6AMcfC/Dt327fB13mxocdnJ/TeJ0saL24A1JH1Ztpc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BJoM4DfG; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BJoM4DfG" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-89f54569415so73511485a.1 for ; Sat, 25 Oct 2025 09:40:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410429; x=1762015229; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ww+ea11r2mZcngIR6hS8TfeQOLbyKE40FtRbqCbDFPg=; b=BJoM4DfG9wK31lFgLUsi57DMe3DhvVrSiAC+ylUk1oqVHKZvgCBHvJbRbW8lv2X2g3 dlY5oWipda1XyIYgmjsCkT10Hg2+NuIKaAX6Lwp39PZbauNI4uA63k0PDrdOOFIsVUPS dfeXmWeEYqVPIV48IF7Rv3YccPyHioRjoHSnp2x5kwMrdji+GEQO6Z1kTA4AnyVgDcyl /vwM9KwRrdnQAhiDp/Smj+VwrQFyCm1luehyTQT6d62vVkZKPeVkRfxdnHZT6vUL4P0L YHXx+79yy2o1cjFlxbfqIbaNv4qph7VSGcKTmKCvM1qOt+3P8DiA0KtHg8ZCHWMkQK4i f4Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410429; x=1762015229; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ww+ea11r2mZcngIR6hS8TfeQOLbyKE40FtRbqCbDFPg=; b=ZX4s6TnUsR/I2OBZCLKeCnIB7cAfeJorfa8LZFuVX8L9hkn06HakVCl8IylQVHjY6m L/Q3f9XHQGPu9BnfaCM5QpqxsttfSIG9T/ooVExqSQXEyV16neU08qdf0nRlMSpQOJCM Xk6/s8LEyYVLiQIvI7dPFx4sNFYKM6Dq80ru31pJwi0yh2MvpYxM1dFTk1/Ph1relilI j/2OAuRDWxoQQRBaw3Lp101j0nNCEgQmsrIyYllsXlyn/Zr9AbZ8QAaHgoPERRDYKm+1 0RttWdtPCzDgY6iXnHJgHfdw1qwKEu53B4PzVeGm/SWgNXfT/3IybB5jag7WHLyYm+ki SnXg== X-Forwarded-Encrypted: i=1; AJvYcCX5EyvRBht+RYvflaS+Vbezuzpqj/dlQj/z60Z8gDg2p9n/kcSaz7JSitOQfoh9Ior2cVGLs6w0GTMfiiA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxs2ohQHBk0L7ReH+kc4PaEk7hrP4R+fUkJomDzoxYOZkXr6io1 +WDsEOy7jGQhpSdVxTT96gxnP1shuPNFShdux8FUtSVD6EbQkbz5A/uk2TDGMA== X-Gm-Gg: ASbGnctfZjIHOay9vh2KBIt5IjNtac0z9SJJ/Wd30oNx90kC979Tii3UD+xc+I9Dq5e Jfzc25tJxawjebud9Ib2i7oqQFEgpayZKi3aiAT1P0zw0GFavmNPR378I9FBfYxCIiDZ4oLmVSw Y2v1e9VFi7zdrqTGg5TAFFVy5jihaO4dKRZqRfnMFpc9oFS8UdNJaAGaUXBRsJIW8wrXYbd4H/1 S30ule11zZ3eWGJpwnsrhrQIJylXWhwFFqrLKFpk2pSw40EIV4IcaRRVhUJ74aaCYudLQgj9fOs 7jfTRwqDfTDMsK7a7ZZCum9rkzzto6uZmZqIP6XeKCQvD5lKqwSf7nAobT9Q6EHfGfGbChwmRAT rFHkofbbUc+3wkqgJlQT34sQ4KRZlStkbiGA30KEmkLm0EU0/ee6EsiUKY2Bce6UOLHfw1KQcrs naoeCzQfE= X-Google-Smtp-Source: AGHT+IHMdqlFeu8BI7FJC9DYq4MkB7WRJcWrEHjGd9KY+lWmSJWGgFzsvJj5kc4aXjfAmRF+KHNOqg== X-Received: by 2002:a05:620a:2550:b0:82f:10ac:450b with SMTP id af79cd13be357-890707f986emr3891276185a.65.1761410429030; Sat, 25 Oct 2025 09:40:29 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f24cd592bsm175393385a.18.2025.10.25.09.40.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:40:28 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Vineet Gupta , "Yury Norov (NVIDIA)" , linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Rasmus Villemoes Subject: [PATCH 01/21] arc: disasm: rename BITS() for FIELD() Date: Sat, 25 Oct 2025 12:40:00 -0400 Message-ID: <20251025164023.308884-2-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In preparation for adding generic BITS() macro, rename the local one. Signed-off-by: Yury Norov (NVIDIA) --- arch/arc/include/asm/disasm.h | 62 +++++++++++++++++------------------ arch/arc/kernel/disasm.c | 46 +++++++++++++------------- 2 files changed, 54 insertions(+), 54 deletions(-) diff --git a/arch/arc/include/asm/disasm.h b/arch/arc/include/asm/disasm.h index 61fb4d7affa7..33a0e88e1e8c 100644 --- a/arch/arc/include/asm/disasm.h +++ b/arch/arc/include/asm/disasm.h @@ -29,44 +29,44 @@ enum flow { }; =20 #define IS_BIT(word, n) ((word) & (1<> (s)) & (~((-2) << ((e) - (s))))) +#define FIELD(word, s, e) (((word) >> (s)) & (~((-2) << ((e) - (s))))) =20 -#define MAJOR_OPCODE(word) (BITS((word), 27, 31)) -#define MINOR_OPCODE(word) (BITS((word), 16, 21)) -#define FIELD_A(word) (BITS((word), 0, 5)) -#define FIELD_B(word) ((BITS((word), 12, 14)<<3) | \ - (BITS((word), 24, 26))) -#define FIELD_C(word) (BITS((word), 6, 11)) +#define MAJOR_OPCODE(word) (FIELD((word), 27, 31)) +#define MINOR_OPCODE(word) (FIELD((word), 16, 21)) +#define FIELD_A(word) (FIELD((word), 0, 5)) +#define FIELD_B(word) ((FIELD((word), 12, 14)<<3) | \ + (FIELD((word), 24, 26))) +#define FIELD_C(word) (FIELD((word), 6, 11)) #define FIELD_u6(word) FIELDC(word) -#define FIELD_s12(word) sign_extend(((BITS((word), 0, 5) << 6) | \ - BITS((word), 6, 11)), 12) +#define FIELD_s12(word) sign_extend(((FIELD((word), 0, 5) << 6) | \ + FIELD((word), 6, 11)), 12) =20 /* note that for BL/BRcc these two macro's need another AND statement to m= ask * out bit 1 (make the result a multiple of 4) */ -#define FIELD_s9(word) sign_extend(((BITS(word, 15, 15) << 8) | \ - BITS(word, 16, 23)), 9) -#define FIELD_s21(word) sign_extend(((BITS(word, 6, 15) << 11) | \ - (BITS(word, 17, 26) << 1)), 12) -#define FIELD_s25(word) sign_extend(((BITS(word, 0, 3) << 21) | \ - (BITS(word, 6, 15) << 11) | \ - (BITS(word, 17, 26) << 1)), 12) +#define FIELD_s9(word) sign_extend(((FIELD(word, 15, 15) << 8) | \ + FIELD(word, 16, 23)), 9) +#define FIELD_s21(word) sign_extend(((FIELD(word, 6, 15) << 11) | \ + (FIELD(word, 17, 26) << 1)), 12) +#define FIELD_s25(word) sign_extend(((FIELD(word, 0, 3) << 21) | \ + (FIELD(word, 6, 15) << 11) | \ + (FIELD(word, 17, 26) << 1)), 12) =20 /* note: these operate on 16 bits! */ -#define FIELD_S_A(word) ((BITS((word), 2, 2)<<3) | BITS((word), 0, 2)) -#define FIELD_S_B(word) ((BITS((word), 10, 10)<<3) | \ - BITS((word), 8, 10)) -#define FIELD_S_C(word) ((BITS((word), 7, 7)<<3) | BITS((word), 5, 7)) -#define FIELD_S_H(word) ((BITS((word), 0, 2)<<3) | BITS((word), 5, 8)) -#define FIELD_S_u5(word) (BITS((word), 0, 4)) -#define FIELD_S_u6(word) (BITS((word), 0, 4) << 1) -#define FIELD_S_u7(word) (BITS((word), 0, 4) << 2) -#define FIELD_S_u10(word) (BITS((word), 0, 7) << 2) -#define FIELD_S_s7(word) sign_extend(BITS((word), 0, 5) << 1, 9) -#define FIELD_S_s8(word) sign_extend(BITS((word), 0, 7) << 1, 9) -#define FIELD_S_s9(word) sign_extend(BITS((word), 0, 8), 9) -#define FIELD_S_s10(word) sign_extend(BITS((word), 0, 8) << 1, 10) -#define FIELD_S_s11(word) sign_extend(BITS((word), 0, 8) << 2, 11) -#define FIELD_S_s13(word) sign_extend(BITS((word), 0, 10) << 2, 13) +#define FIELD_S_A(word) ((FIELD((word), 2, 2)<<3) | FIELD((word), 0, 2)) +#define FIELD_S_B(word) ((FIELD((word), 10, 10)<<3) | \ + FIELD((word), 8, 10)) +#define FIELD_S_C(word) ((FIELD((word), 7, 7)<<3) | FIELD((word), 5, 7)) +#define FIELD_S_H(word) ((FIELD((word), 0, 2)<<3) | FIELD((word), 5, 8)) +#define FIELD_S_u5(word) (FIELD((word), 0, 4)) +#define FIELD_S_u6(word) (FIELD((word), 0, 4) << 1) +#define FIELD_S_u7(word) (FIELD((word), 0, 4) << 2) +#define FIELD_S_u10(word) (FIELD((word), 0, 7) << 2) +#define FIELD_S_s7(word) sign_extend(FIELD((word), 0, 5) << 1, 9) +#define FIELD_S_s8(word) sign_extend(FIELD((word), 0, 7) << 1, 9) +#define FIELD_S_s9(word) sign_extend(FIELD((word), 0, 8), 9) +#define FIELD_S_s10(word) sign_extend(FIELD((word), 0, 8) << 1, 10) +#define FIELD_S_s11(word) sign_extend(FIELD((word), 0, 8) << 2, 11) +#define FIELD_S_s13(word) sign_extend(FIELD((word), 0, 10) << 2, 13) =20 #define STATUS32_L 0x00000100 #define REG_LIMM 62 diff --git a/arch/arc/kernel/disasm.c b/arch/arc/kernel/disasm.c index ccc7e8c39eb3..926b67c40346 100644 --- a/arch/arc/kernel/disasm.c +++ b/arch/arc/kernel/disasm.c @@ -100,12 +100,12 @@ void __kprobes disasm_instr(unsigned long addr, struc= t disasm_state *state, =20 case op_LD: /* LD a,[b,s9] */ state->write =3D 0; - state->di =3D BITS(state->words[0], 11, 11); + state->di =3D FIELD(state->words[0], 11, 11); if (state->di) break; - state->x =3D BITS(state->words[0], 6, 6); - state->zz =3D BITS(state->words[0], 7, 8); - state->aa =3D BITS(state->words[0], 9, 10); + state->x =3D FIELD(state->words[0], 6, 6); + state->zz =3D FIELD(state->words[0], 7, 8); + state->aa =3D FIELD(state->words[0], 9, 10); state->wb_reg =3D FIELD_B(state->words[0]); if (state->wb_reg =3D=3D REG_LIMM) { state->instr_len +=3D 4; @@ -121,11 +121,11 @@ void __kprobes disasm_instr(unsigned long addr, struc= t disasm_state *state, =20 case op_ST: state->write =3D 1; - state->di =3D BITS(state->words[0], 5, 5); + state->di =3D FIELD(state->words[0], 5, 5); if (state->di) break; - state->aa =3D BITS(state->words[0], 3, 4); - state->zz =3D BITS(state->words[0], 1, 2); + state->aa =3D FIELD(state->words[0], 3, 4); + state->zz =3D FIELD(state->words[0], 1, 2); state->src1 =3D FIELD_C(state->words[0]); if (state->src1 =3D=3D REG_LIMM) { state->instr_len +=3D 4; @@ -160,7 +160,7 @@ void __kprobes disasm_instr(unsigned long addr, struct = disasm_state *state, is_linked =3D 1; =20 fieldCisReg =3D 0; - op_format =3D BITS(state->words[0], 22, 23); + op_format =3D FIELD(state->words[0], 22, 23); if (op_format =3D=3D 0 || ((op_format =3D=3D 3) && (!IS_BIT(state->words[0], 5)))) { fieldC =3D FIELD_C(state->words[0]); @@ -192,7 +192,7 @@ void __kprobes disasm_instr(unsigned long addr, struct = disasm_state *state, break; =20 case 40: /* LPcc */ - if (BITS(state->words[0], 22, 23) =3D=3D 3) { + if (FIELD(state->words[0], 22, 23) =3D=3D 3) { /* Conditional LPcc u7 */ fieldC =3D FIELD_C(state->words[0]); =20 @@ -207,12 +207,12 @@ void __kprobes disasm_instr(unsigned long addr, struc= t disasm_state *state, break; =20 case 48 ... 55: /* LD a,[b,c] */ - state->di =3D BITS(state->words[0], 15, 15); + state->di =3D FIELD(state->words[0], 15, 15); if (state->di) break; - state->x =3D BITS(state->words[0], 16, 16); - state->zz =3D BITS(state->words[0], 17, 18); - state->aa =3D BITS(state->words[0], 22, 23); + state->x =3D FIELD(state->words[0], 16, 16); + state->zz =3D FIELD(state->words[0], 17, 18); + state->aa =3D FIELD(state->words[0], 22, 23); state->wb_reg =3D FIELD_B(state->words[0]); if (state->wb_reg =3D=3D REG_LIMM) { state->instr_len +=3D 4; @@ -237,7 +237,7 @@ void __kprobes disasm_instr(unsigned long addr, struct = disasm_state *state, case 10: /* MOV */ /* still need to check for limm to extract instr len */ /* MOV is special case because it only takes 2 args */ - switch (BITS(state->words[0], 22, 23)) { + switch (FIELD(state->words[0], 22, 23)) { case 0: /* OP a,b,c */ if (FIELD_C(state->words[0]) =3D=3D REG_LIMM) state->instr_len +=3D 4; @@ -258,7 +258,7 @@ void __kprobes disasm_instr(unsigned long addr, struct = disasm_state *state, default: /* Not a Load, Jump or Loop instruction */ /* still need to check for limm to extract instr len */ - switch (BITS(state->words[0], 22, 23)) { + switch (FIELD(state->words[0], 22, 23)) { case 0: /* OP a,b,c */ if ((FIELD_B(state->words[0]) =3D=3D REG_LIMM) || (FIELD_C(state->words[0]) =3D=3D REG_LIMM)) @@ -281,7 +281,7 @@ void __kprobes disasm_instr(unsigned long addr, struct = disasm_state *state, =20 /* 16 Bit Instructions */ case op_LD_ADD: /* LD_S|LDB_S|LDW_S a,[b,c] */ - state->zz =3D BITS(state->words[0], 3, 4); + state->zz =3D FIELD(state->words[0], 3, 4); state->src1 =3D get_reg(FIELD_S_B(state->words[0]), regs, cregs); state->src2 =3D get_reg(FIELD_S_C(state->words[0]), regs, cregs); state->dest =3D FIELD_S_A(state->words[0]); @@ -289,13 +289,13 @@ void __kprobes disasm_instr(unsigned long addr, struc= t disasm_state *state, =20 case op_ADD_MOV_CMP: /* check for limm, ignore mov_s h,b (=3D=3D mov_s 0,b) */ - if ((BITS(state->words[0], 3, 4) < 3) && + if ((FIELD(state->words[0], 3, 4) < 3) && (FIELD_S_H(state->words[0]) =3D=3D REG_LIMM)) state->instr_len +=3D 4; break; =20 case op_S: - subopcode =3D BITS(state->words[0], 5, 7); + subopcode =3D FIELD(state->words[0], 5, 7); switch (subopcode) { case 0: /* j_s */ case 1: /* j_s.d */ @@ -308,7 +308,7 @@ void __kprobes disasm_instr(unsigned long addr, struct = disasm_state *state, direct_call : indirect_jump; break; case 7: - switch (BITS(state->words[0], 8, 10)) { + switch (FIELD(state->words[0], 8, 10)) { case 4: /* jeq_s [blink] */ case 5: /* jne_s [blink] */ case 6: /* j_s [blink] */ @@ -367,8 +367,8 @@ void __kprobes disasm_instr(unsigned long addr, struct = disasm_state *state, /* note: we are ignoring possibility of: * ADD_S, SUB_S, PUSH_S, POP_S as these should not * cause unaligned exception anyway */ - state->write =3D BITS(state->words[0], 6, 6); - state->zz =3D BITS(state->words[0], 5, 5); + state->write =3D FIELD(state->words[0], 6, 6); + state->zz =3D FIELD(state->words[0], 5, 5); if (state->zz) break; /* byte accesses should not come here */ if (!state->write) { @@ -385,7 +385,7 @@ void __kprobes disasm_instr(unsigned long addr, struct = disasm_state *state, =20 case op_GP: /* LD_S|LDB_S|LDW_S r0,[gp,s11/s9/s10] */ /* note: ADD_S r0, gp, s11 is ignored */ - state->zz =3D BITS(state->words[0], 9, 10); + state->zz =3D FIELD(state->words[0], 9, 10); state->src1 =3D get_reg(26, regs, cregs); state->src2 =3D state->zz ? FIELD_S_s10(state->words[0]) : FIELD_S_s11(state->words[0]); @@ -405,7 +405,7 @@ void __kprobes disasm_instr(unsigned long addr, struct = disasm_state *state, break; =20 case op_B_S: - fieldA =3D (BITS(state->words[0], 9, 10) =3D=3D 3) ? + fieldA =3D (FIELD(state->words[0], 9, 10) =3D=3D 3) ? FIELD_S_s7(state->words[0]) : FIELD_S_s10(state->words[0]); state->target =3D fieldA + (addr & ~0x03); --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97CAF3064BA for ; Sat, 25 Oct 2025 16:40:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410434; cv=none; b=Zn1ihjsm/wZDzjm3QwFIuKU7dfL5NT8H7rIkkB9ju6qIhAN1UsjOXiIynd+PShO/Xyp0LN+DjSqi7V54PnAiGnRmFNZaqGLuSVRwGT6DFUzCpSFmKn4rNixqh20z4F/8X3GzY0HYy+Gntfe2t7clxhgdEjQ4bsjbL/qsMSMVW+0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410434; c=relaxed/simple; bh=142ZarbauOc/OnyndUEIR7x0gLhU0Vf39KWkHIFGmYg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qtxa4WoXf6icwmdvmYZ8fVjCbXD6eBrTwXLTeKXHlFOPym/v3oejrU6HRIwGKq3I3w+4EKn7bLF5zkAkfK5I4uu7wzGx/2/qeZf2xYF7RwQllVGljm9HM6boUIyh5j6L2EKeDoEmkbeM6YGk+Flqq9SqjSAyy0v8RxgGX5jx5HM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E2bffbq4; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E2bffbq4" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-89ead335959so134027785a.2 for ; Sat, 25 Oct 2025 09:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410431; x=1762015231; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EVD9Zxv6Y0ifC9xZiOG7Ki+TEfCe0ib+yy9r9fDGLQc=; b=E2bffbq4Ds02AQpl5Qu4A6vUW9DDnxFSCVuvwODdRYBO87m9APxmbbdz/OMSE3eYX0 31KuLZR1HTiahp9XODbFezyTjr/+r0lHsBySNOlOhhLiORMTQ0wKRounf8UJdkYEIb/q PI3lzI7VG55iMAWHWZ2DsgAcJap1EzIGk3zpWWqw2TKrcQTSZPseqXx6ls0jb2I9sico g2wXlJcC0uCAGV+c/Y4Mt/1gP5qNHC+imvs+0X8U74QKspC9OUoCa+HOJUd9x+DZ+Frf S3+mjLQI74L6MYnws9eSSQcFt3eX5FWzPDmKcbHPO+l7vdzzUp62tRJp1Km8+EMA5Pgs MNKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410431; x=1762015231; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EVD9Zxv6Y0ifC9xZiOG7Ki+TEfCe0ib+yy9r9fDGLQc=; b=pXe1OsyepflFcr+NaTlcK7fPaPYmRIw16DQLydfMeCzFPMoTWYzB5/l7BtXvkDpWvM lsQF9Ehnfdf/oWFbQU9PnHVmwBegzIdN26V4IGp+tIjNfqaohWdCKivlQoCI2oD5E95z B4q01oEV8Pha03IxiZx2TjCp0LQ5i2dQuHuZIp+sDsYxLQuUoEv9uhFH/zDSkj1T284u V3tuYx3ej8Z9dLv8l08la4w26100/Yk1+kW+q1LZ5NOhl1jjlTE1Ap0GiZClCU7scOzf 5zVp60gLBXtFhBcfEOCS6O13nkSz7EqUZUWN4T6vtXWiIU5ptxR/hxW5SXNUi/gqKkkK Fgjg== X-Forwarded-Encrypted: i=1; AJvYcCWFmUNNeukKZSb3M47V1sc2fosasBQmarqWz3OdbJPoP8vHvW2uALMTRtsVVMJQ171Drfi37yoJgneXsz0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzl8FLNqNsjCzLZX0MYVEQeMlFMS6wPKo9FoYNsY+VchuTS14h0 5aeS2ANkKazHOuuYi94G8YKWYRNq8d2w/IKVdNMCqypmjx2nydvv+Ae+ X-Gm-Gg: ASbGncs2A83XJrTBkQXh3TBlSVyIxq05otBiJAkEN8D/p71Ee3lywYb33/9UO07Yvwe bMXJBsJhwvM2nb0xbP02kJ+5rAxuGfBKvrESl2l/z+yt/xWnQ7pOIlsy6TmI3XzLThdVSZJWHum QetTPWN6/rURHMz3J3i955Fc2t3JJFg5NY1MEcxUBIz9udeVTRNASZ+0/XwWALPkeYrUIvEkzcZ UbCtGc6zurIaf29TngLNV1k4jt/601YqJOBj9f0yLfC1KOHKtTfCd6hA0Y+d6lVR5w9EXAEAyap qMMBb6Qa75FCVBPxb2wXfnHVN7dm+PCjXyTHWEFReE8dr9r+Jj+LVNrXj4adU1m4hU1JPnRSfcE iarDKE3yAyq7aUa+cVQX/BxIhL8hYKxFMNnZOPvd4VLNaPFkmWDbEapdL8EQB7T71CsQNs4pO X-Google-Smtp-Source: AGHT+IHi0SzLVtyyhZwoQbQ1wMM4wPKEE+MJJFPaEhrXN5x+mdVgxlbnahirAfa9H7ObZoH6VLCARw== X-Received: by 2002:a05:620a:2a06:b0:891:e26f:512d with SMTP id af79cd13be357-891e27ea1acmr3419884985a.59.1761410431571; Sat, 25 Oct 2025 09:40:31 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f2421f8b8sm175760385a.7.2025.10.25.09.40.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:40:31 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Miri Korenblit , "Yury Norov (NVIDIA)" , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rasmus Villemoes Subject: [PATCH 02/21] iwlwifi: drop unused BITS() Date: Sat, 25 Oct 2025 12:40:01 -0400 Message-ID: <20251025164023.308884-3-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" BITS() is unused in iwlwifi. Drop it. Signed-off-by: Yury Norov (NVIDIA) --- drivers/net/wireless/intel/iwlwifi/fw/api/coex.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/api/coex.h b/drivers/net= /wireless/intel/iwlwifi/fw/api/coex.h index ddc84430d895..b0d68b4c504b 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/api/coex.h +++ b/drivers/net/wireless/intel/iwlwifi/fw/api/coex.h @@ -11,8 +11,6 @@ #include #include =20 -#define BITS(nb) (BIT(nb) - 1) - enum iwl_bt_coex_lut_type { BT_COEX_TIGHT_LUT =3D 0, BT_COEX_LOOSE_LUT, --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBE32308F1B for ; Sat, 25 Oct 2025 16:40:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410437; cv=none; b=H4wCxxdwuelndVF7CJVQSu+gCbdof80OFXrgFseD7ZLBwiade3hJDKwWdOMKljJdOaxROoYm+NsHkw7hROTqVoeXOVxCQOeoq02I4Lsaeb/bt3Bmj7/tolgD7wsVrcMH6mU/u00B+TUICPgHyKbxyYwVdlaAQFJIwGXe/D0ceTw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410437; c=relaxed/simple; bh=zAr2NN3Jns2OMOMJhebylpaZ7+Fr+NR7SMgQK33hi4Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LKTI1IGB/eqUJDnSyZPgoKHxDI6wDV0mdPtfLxlxO2ae3UOEwWayT2wmNuSe3YNW15e1pbNhvdCSYHQiDchV63YZLShKYa1oKvC8jn526mAe8oBeLfwQaJgvutOVQ4FF8sUfEHZVsYFMw/W9LHOQtiVDpCP8pZpbQ6LXxfWgkvQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BsmtDUEl; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BsmtDUEl" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4e88a1bbf5fso34500631cf.3 for ; Sat, 25 Oct 2025 09:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410435; x=1762015235; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FdGq6o03y1IFQKw38Yd5zNXdE2p5YkP/ZYXUEcu9OkE=; b=BsmtDUElEEHd7wsJHh8jVIKKqXTIIb0JCzAZ7T1NHZJtkr4OUMtnb2U7NW30yvJSP+ Okeg2HgeZc8I+qUbWfcOvzLUkWYDIHOb5oFSJzOhmgRTjATGWoq68gw2LJtTswHzkBPY GlwlGcF2hQlfiUcSjS3pN6lnSbRHT6FtMnX+hDkA4B7h4YuJ4EaRWH+TsznlSyiDpIw6 9GHIbLgZB3oCA55AOsiU3RnCWfemfhxBy0Bxcd/WjagLptzDZjLhi7ppR3XRv9bN4m7V HR199Zfw37czgFaP0nZMH+P6Bjp9Mxqe1yiAYTpF1z7mXJvlTLMbzw66QFfRhV6KqYeu HvCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410435; x=1762015235; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FdGq6o03y1IFQKw38Yd5zNXdE2p5YkP/ZYXUEcu9OkE=; b=sgwBsbnh+VFULqzFwQVKk0GicoJVi7KLw+jrx3qmPEtop+ldt6IT67BHQ1VVYEanIx bK33yH5qf6D0DEG1gdVCIanKjfWBEUzLYvJYBeLBM9MUlnYK8xccTrQbVJ//MsO4hm6A a4O275Xf9SB5DSX/ov2RSmIPzCDNRl6Pz6vYj63hyMpHPPwGu7YxfH1KmLtaNeA0+sCy QNjVWJxV1nzY35o2BmJirGWj93hZatzSU5/XZPepU38lEUXTdZlv1wlgwS8nQiIIDf/a JiO5yxjk1Oh+8lqPo2xhasEFZXuEoUIeHanvn0CJ2TcS7qtUhaFIBkAzr9ih1sgV76Yn FDSg== X-Forwarded-Encrypted: i=1; AJvYcCVWs9vTD67nql7wwRDYtOdYScRyPmmpN33yZx/lbK/e0swKIV9bDNKg7eHM+eL5HHe0eByROnHhs++6y1c=@vger.kernel.org X-Gm-Message-State: AOJu0Yxi/n+Xjt8R8UMNi6zyrJlX7M0vfxNUH5cQ8AJsvOhX/hRaBQta 1N+W9h6Cj6S6zz6PBFTzd+qmAw50w+EnuX172bUjL6VTVubmdjEIjnnSEz66sg== X-Gm-Gg: ASbGnctEnGOgua276QmclVkQ0dfQbGh+Mp7meSNfL01b9/lNlhDG5cF0G+bFyQ5Djv0 ncTbhzxy7kQMvfM4JOu1BniPWkzhqAEb9k5wHKbonvoUFg+Z+Xw6KcepYn2IAIU5zIHBvHzgYIn pQac1MIdjmZTikFQSE7gzRD41YDyPZlbkpQyaYq6p9Wy3jGq34vBdA7jrpjeCpq6oikqJjWcBaA wq6/fVBrXvm4ODOa7nNrGDULGgW/irPf9fsdMUsVXe/uoCBAVy7aBUzbis7QeVcP5p9icUOYUpw yLbhudcYjkxj4/bIyJA72fbXLzZNbCY++552u5tIq/gN60aHl2QqU/YeJwZb+hepyHp+joYt4Sf qemBuFZUXboBTJA0ywpAce4RamDuYDSJ6UUw+NfCymWcF1+hGqzK4gVkxOIDXQii/QU4QCTtG6o lM1ITxYxw= X-Google-Smtp-Source: AGHT+IHB7MFietozAVdiQPNgtEHZprXNbg0Ck/iHgJxOsJrH00g2y91+bZyBuwOOlRMQWPVBX5Z1jA== X-Received: by 2002:a05:622a:1a97:b0:4ec:a568:7b1c with SMTP id d75a77b69052e-4eca5688377mr14668911cf.21.1761410434693; Sat, 25 Oct 2025 09:40:34 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4eba3e193bdsm14687091cf.10.2025.10.25.09.40.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:40:33 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Alexander Viro , Christian Brauner , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" , Rasmus Villemoes Subject: [PATCH 03/21] select: rename BITS() to FDS_BITS() Date: Sat, 25 Oct 2025 12:40:02 -0400 Message-ID: <20251025164023.308884-4-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In preparation for adding generic BITS() macro, rename the local one. Signed-off-by: Yury Norov (NVIDIA) Reviewed-by: Jan Kara --- fs/select.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/select.c b/fs/select.c index 082cf60c7e23..ad5bfb4907ea 100644 --- a/fs/select.c +++ b/fs/select.c @@ -412,7 +412,7 @@ void zero_fd_set(unsigned long nr, unsigned long *fdset) #define FDS_OUT(fds, n) (fds->out + n) #define FDS_EX(fds, n) (fds->ex + n) =20 -#define BITS(fds, n) (*FDS_IN(fds, n)|*FDS_OUT(fds, n)|*FDS_EX(fds, n)) +#define FDS_BITS(fds, n) (*FDS_IN(fds, n)|*FDS_OUT(fds, n)|*FDS_EX(fds, n)) =20 static int max_select_fd(unsigned long n, fd_set_bits *fds) { @@ -428,7 +428,7 @@ static int max_select_fd(unsigned long n, fd_set_bits *= fds) open_fds =3D fdt->open_fds + n; max =3D 0; if (set) { - set &=3D BITS(fds, n); + set &=3D FDS_BITS(fds, n); if (set) { if (!(set & ~*open_fds)) goto get_max; @@ -438,7 +438,7 @@ static int max_select_fd(unsigned long n, fd_set_bits *= fds) while (n) { open_fds--; n--; - set =3D BITS(fds, n); + set =3D FDS_BITS(fds, n); if (!set) continue; if (set & ~*open_fds) --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44D363093C1 for ; Sat, 25 Oct 2025 16:40:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410441; cv=none; b=AIS2cj1+a+UiJ8/OXmCXrts6XJbdOMWxyGwkCJMY+orLpG2jDDRDUwd1s1gCUcLX9e/cjPTc2dFZdrwUo1dCSImOqZWOZ06MITZXVJy9NKPrHs2GaBnGv2Lb1COSAVUEiYEdHahPV+G53MVdmGEK/DLqF80q2lRFpNjHTmSBRTs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410441; c=relaxed/simple; bh=r1ZSvL7GYSBh/Cee0SXgYuJ/pWOJXGQu2D5xFAme0AE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JE+pcFrVl9llE4dRZs2FFLOp2T24pQBlpXRPzWDPrP7EDA1pgLkh3iKkkXR+bgu4FxkGjGFM/whGpzr19t1+6jsOmCUSNfJ7wtx2f3HmjlrvzBLTy69ENt7FslJVux8YJ5rQ/XiaE5C5IDlAzyPVbd/93Rlfj8dsTRrORDGeha0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lfH+o0wb; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lfH+o0wb" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-78ea15d3489so27625676d6.3 for ; Sat, 25 Oct 2025 09:40:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410437; x=1762015237; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mxeCOI9icR7/UFiwtRNvJHOt4NesbHGx93HWxIm5tv4=; b=lfH+o0wbFcKnBcLqetfiVUhdNCb9XnBsKZwY96o9jLcYUsu493Ya44FsdUrZJ1e4+l bxVxm7ju/wDa57wp8hlaUJwWjKKSqAGX0ku0X4bRBgvzPWQ1PEe7Q1PWXSNUFtMw5y90 ITtndAEnv7SKqIvSwpYPBK7WjDmq+9uWz9YaIfLPLmRr8VmG0pvRGJTBR4ZqX/Ey4gyJ KSe2BZmWUqlJS6Fa8RfxdzWg2EbVs6ZvzaQZklU5eNdXSq4oXuW3Iw9imMJe8ydwgGqE mmoDcAP/2gx2O7e3Tvyjfr+mAFwqCNCC79zE3tDMYt9piFsZLCeNUVAPEPcCbK9Ky1iQ rzLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410437; x=1762015237; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mxeCOI9icR7/UFiwtRNvJHOt4NesbHGx93HWxIm5tv4=; b=QibPr679R2oqAPCMxYXCCojRQAXu9IwH74/z8SubDA36jHFSXl5sCaMBctuFtvQskL EWYK3MKcg88YGGJdDX54agScKALj4Tvx0TrukMvYEap+cB1I0eA9CXDkusOEFmtHAl67 XAcNquKEJcOwLkTMsQ/q0R+ggWC0PWf3ZWZJns8qY3nHA7ISeQphQCKj3E6kLNcQoXSy P4BRNdfnP69rxz+32syQrqGt7iKFMoCOVLuVsn+3Yjd9YOgxElLwtm9rzXwfglAqiGNU PE5lNHoYJB4K9CdK631SIIeDSocCm+JazVa5RXFmgz2lq3iOAsdkP5QfAIfWNXv17S6m SIfA== X-Forwarded-Encrypted: i=1; AJvYcCWvOimAIzz2LT2Vn1azmV/G2aDHK6fo08SCQ5lH6ZnGqV8YUuih8Oiqb/X6kMPWHRPNXjOEHRvlXYENwow=@vger.kernel.org X-Gm-Message-State: AOJu0YxJDSuikkadVzkEfYlql/pXe8nKT78I+NWR7p3hsWNzA0I3iNJt MDGbYfzZTK7u4bd7cKyxXIWJwXDMm8CaLei0zODbBzuixRkUIJddh6Gw X-Gm-Gg: ASbGncujkOIuYJiYO08M9al5CgX/dj34VbZGaZNzcmQJJht+xowCFosWhWRP9YeVgxi XRiAwnoyt6czd3rxBKbj0DHUXtHVwvxNoKASfHJQShgurLvz5azoO+1RYYMxkdhnmYk93+ucMl3 KtpLySpR1+2Dv65BMceMMLClNq94zAtrK6pqlc8eaZPhMS2WrtHSnqykTmVk1uHPSxAVlq8ICJz vSKKVxaqv/JIJxxUGvz9eU5ye0vEEweUhkhyCSC8wDnBoHjd967B6ghe/m5i6x5fIFQ2eMegnMc fa0Xz+OoOUr5fTNGBXNZ6WprDYwktiWUfbwveFHWGULNPj11qNkloAwl9gnxAZnrlSMWBZpgI9s /C9md9aUFxgTCpzrH1Y7VdvVdomSAV1SnPcDUj2GOGzaVFRXiMxKSUjkEeF240/Jour1hAdUN X-Google-Smtp-Source: AGHT+IGA1DGszT7xZjIANsU8O6rvui0sqJn95mFqcuxChrfDbaomUSTYNAUrPgKr6w9KBJpYTpgUWA== X-Received: by 2002:a05:6214:808f:b0:87c:2275:4bf5 with SMTP id 6a1803df08f44-87c22754bfdmr400398756d6.28.1761410437167; Sat, 25 Oct 2025 09:40:37 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc4944a84sm16377846d6.36.2025.10.25.09.40.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:40:36 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Jaroslav Kysela , Takashi Iwai , "Yury Norov (NVIDIA)" , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rasmus Villemoes Subject: [PATCH 04/21] ALSA: rename BITS to R_BITS Date: Sat, 25 Oct 2025 12:40:03 -0400 Message-ID: <20251025164023.308884-5-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In preparation for adding generic BITS() macro, rename the local one. Signed-off-by: Yury Norov (NVIDIA) --- sound/core/oss/rate.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/core/oss/rate.c b/sound/core/oss/rate.c index b56eeda5e30e..90a40221e4ce 100644 --- a/sound/core/oss/rate.c +++ b/sound/core/oss/rate.c @@ -25,8 +25,8 @@ #include "pcm_plugin.h" =20 #define SHIFT 11 -#define BITS (1< 32767) @@ -162,7 +162,7 @@ static void resample_shrink(struct snd_pcm_plugin *plug= in, } if (pos & ~R_MASK) { pos &=3D R_MASK; - val =3D S1 + ((S2 - S1) * (signed int)pos) / BITS; + val =3D S1 + ((S2 - S1) * (signed int)pos) / R_BITS; if (val < -32768) val =3D -32768; else if (val > 32767) @@ -191,7 +191,7 @@ static snd_pcm_sframes_t rate_src_frames(struct snd_pcm= _plugin *plugin, snd_pcm_ return 0; data =3D (struct rate_priv *)plugin->extra_data; if (plugin->src_format.rate < plugin->dst_format.rate) { - res =3D (((frames * data->pitch) + (BITS/2)) >> SHIFT); + res =3D (((frames * data->pitch) + (R_BITS/2)) >> SHIFT); } else { res =3D DIV_ROUND_CLOSEST(frames << SHIFT, data->pitch); } @@ -226,7 +226,7 @@ static snd_pcm_sframes_t rate_dst_frames(struct snd_pcm= _plugin *plugin, snd_pcm_ if (plugin->src_format.rate < plugin->dst_format.rate) { res =3D DIV_ROUND_CLOSEST(frames << SHIFT, data->pitch); } else { - res =3D (((frames * data->pitch) + (BITS/2)) >> SHIFT); + res =3D (((frames * data->pitch) + (R_BITS/2)) >> SHIFT); } if (data->old_dst_frames > 0) { snd_pcm_sframes_t frames1 =3D frames, res1 =3D data->old_src_frames; --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD624308F1B for ; Sat, 25 Oct 2025 16:40:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410442; cv=none; b=K1G3herzI40nlAygXmp3PB7aqAVzvIOW6efRRmOdQkAgdkN5LsVGkSObi0Sef93+bGcLS9Q7PS2RaXmbpC/I1n8/O6Xib6kcjoZH10jDI2sjeyXxIxVKaaC75oKx7Oca+wCXk9t4fgNIV33HL/k9Lj840DHDdDoTRL5z3g5haH4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410442; c=relaxed/simple; bh=vSOmrnKl9j6cBNY7sSNJF+HbPImP5X3RfSSeVaTTTB8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kR7z0xnUmJPwXEuvKbBWMV0dyIQHrFiEKLar9Un5g8mi7qKv8JFmjpHw23SW+FoUtX054I8Rneq9KrL3omQnNVfSaaIXNPspIkER+L+Jw8IYJ4cmt2jNDb32estr4RtY7hLhBWOjpHg+fxjaPTQUuyLFeZc+u8GoA2mJrZIgbns= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J/pBvg4b; arc=none smtp.client-ip=209.85.219.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J/pBvg4b" Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-87eed34f767so30567686d6.2 for ; Sat, 25 Oct 2025 09:40:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410440; x=1762015240; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sJO+MeQ4RtFqJ9ACNBMsRAE4YNMhC0BoZJ57Lb9WxOM=; b=J/pBvg4bD6nlrmhy2WkpCtAYiRy1NsaQHVYzjHOattRRHA73ly1OSYpP/cz+gKvRpS zUk02V+ewAGOf/q1qBLWGa4fQG/InW5QStc10DMHarCXjVIHKwpR80C5xjO/GtSHbLaw BR5Pxt4EX3PqXRdpQy74eg3szRQTzXuC7uCmyXtUSDZYuIi4SrPNMmLNrYmVLjWkYwso F+k//7Ne2SytIH4mpdY0vAiLtD5SkexjyxRTeesp9xvXSlEFRR9TSHH0Cjx95j40CvVK T5b836tWes+YOH97wiVm/fEjWCeywikOG/PbEfFkQ06KURz4KKjNcZIo6YAxlLz+YXSv VhVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410440; x=1762015240; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sJO+MeQ4RtFqJ9ACNBMsRAE4YNMhC0BoZJ57Lb9WxOM=; b=RVLvfmxq2vBk0IVOY4iTlMsvdYCR1+BJ2E1jft4jusG13KUg5cO71Q+34Ef6rnZ6XL znm4bLwhlHke3+LCbjR9Rnqu8tBZ0CSa4D6mbXstzBwclag6/8onrCtLDWnRZZedUFhv VYkviDFC1E8iHfdtcBidyXNYMAe3W2H0mVbdQYat5irfvgFOnsfLfYFFWJapr38EQN/n I+PQWVgUQDtICAJy25nT8BzJA9hmM7EF4h8BgbklsTjnPctd5P+eniuMeUxqUDXZpFQc r00jyAQhKaDD5eYa82m6N7x5nd9YL3WzPifTRKFe8Exuw8TMan99Yh4wJhTM4Vw+3eNE /fCg== X-Forwarded-Encrypted: i=1; AJvYcCWW/d6CHhf0HELhDEvUnUxrRTv0hSNwvcEkyRLmGhlcYYqSGKyX/XobyHS42j0woNJF16lvniUpVsgMDJ0=@vger.kernel.org X-Gm-Message-State: AOJu0YxvoJVDuxWqvEEETl3W8uXvSdn53VSRRlBMug7ocldKYjVapOAf pm8XRR8KHBgES71BHjmbR5qU7UsedzBoNy0qEKZ9yWICzG650ceSyLRW X-Gm-Gg: ASbGnctSkbqGkk31IAa6gpcuDraqWS5E+MUYbYXE4u7b3rmVVdKC9YoDeoYkuSo4qMQ p1YVQmaw5egKgoqc+JhcCN9y2qOAdwutHvhXQ04OYAhuuKb5P0PIKPhQwgPkTCNeQ9R5p17xIoT faDJXD2O36znC7tAYob5V2n4cVGdFKy4xy4njBYuZvCqy3SOTxE6//BFEkr0JPQCvoYtd7nfvcW iAQh18a/To78eqmxJZAabsxI1IgUNjW8gTq85HT4vGetPZHdIkufC6Z6JRnlSIc97yKB2pSo/w7 Ly9QLmTFWik12dQqLFiTP5XF7lsfsK6Ou2n/5wEjcsu2TkWAhQn5NwvAnbEmMNp78FS3QShFzJG +GQTcUNz4lL1Oxva8+lK3WjTYxmkWnHr/JSN5jaqpJptggdyS/ELhEpNRjO3WkHGSBwrwnAH8 X-Google-Smtp-Source: AGHT+IEjzlUxBHT5SKcjYBFCzIkSq3QG+F9tz4biOwCVVJqf15/90wSyKHSXScePaTErfc6IgULEng== X-Received: by 2002:ad4:5c46:0:b0:746:e5b3:e123 with SMTP id 6a1803df08f44-87fb647acfbmr81429146d6.59.1761410439724; Sat, 25 Oct 2025 09:40:39 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc48a6fedsm16348196d6.2.2025.10.25.09.40.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:40:38 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , "Yury Norov (NVIDIA)" , linux-kernel@vger.kernel.org Cc: Rasmus Villemoes Subject: [PATCH 05/21] zlib: rename BITS() to LOWBITS() Date: Sat, 25 Oct 2025 12:40:04 -0400 Message-ID: <20251025164023.308884-6-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In preparation from adding generic BITS() macro, rename the local one. Signed-off-by: Yury Norov (NVIDIA) --- lib/zlib_inflate/inflate.c | 48 +++++++++++++++++++------------------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/lib/zlib_inflate/inflate.c b/lib/zlib_inflate/inflate.c index d1efad69f02b..3102137b51c2 100644 --- a/lib/zlib_inflate/inflate.c +++ b/lib/zlib_inflate/inflate.c @@ -229,7 +229,7 @@ static int zlib_inflateSyncPacket(z_streamp strm) } while (0) =20 /* Return the low n bits of the bit accumulator (n < 16) */ -#define BITS(n) \ +#define LOWBITS(n) \ ((unsigned)hold & ((1U << (n)) - 1)) =20 /* Remove n bits from the bit accumulator */ @@ -270,16 +270,16 @@ static int zlib_inflateSyncPacket(z_streamp strm) is: =20 NEEDBITS(n); - ... do something with BITS(n) ... + ... do something with LOWBITS(n) ... DROPBITS(n); =20 where NEEDBITS(n) either returns from inflate() if there isn't enough - input left to load n bits into the accumulator, or it continues. BITS(= n) + input left to load n bits into the accumulator, or it continues. LOWBIT= S(n) gives the low n bits in the accumulator. When done, DROPBITS(n) drops the low n bits off the accumulator. INITBITS() clears the accumulator and sets the number of available bits to zero. BYTEBITS() discards just enough bits to put the accumulator on a byte boundary. After BYTEBITS() - and a NEEDBITS(8), then BITS(8) would return the next byte in the strea= m. + and a NEEDBITS(8), then LOWBITS(8) would return the next byte in the st= ream. =20 NEEDBITS(n) uses PULLBYTE() to get an available byte of input, or to re= turn if there is no input available. The decoding of variable length codes = uses @@ -295,7 +295,7 @@ static int zlib_inflateSyncPacket(z_streamp strm) case STATEw: while (want < need) { NEEDBITS(n); - keep[want++] =3D BITS(n); + keep[want++] =3D LOWBITS(n); DROPBITS(n); } state =3D STATEx; @@ -369,18 +369,18 @@ int zlib_inflate(z_streamp strm, int flush) } NEEDBITS(16); if ( - ((BITS(8) << 8) + (hold >> 8)) % 31) { + ((LOWBITS(8) << 8) + (hold >> 8)) % 31) { strm->msg =3D (char *)"incorrect header check"; state->mode =3D BAD; break; } - if (BITS(4) !=3D Z_DEFLATED) { + if (LOWBITS(4) !=3D Z_DEFLATED) { strm->msg =3D (char *)"unknown compression method"; state->mode =3D BAD; break; } DROPBITS(4); - len =3D BITS(4) + 8; + len =3D LOWBITS(4) + 8; if (len > state->wbits) { strm->msg =3D (char *)"invalid window size"; state->mode =3D BAD; @@ -416,9 +416,9 @@ int zlib_inflate(z_streamp strm, int flush) break; } NEEDBITS(3); - state->last =3D BITS(1); + state->last =3D LOWBITS(1); DROPBITS(1); - switch (BITS(2)) { + switch (LOWBITS(2)) { case 0: /* stored block */ state->mode =3D STORED; break; @@ -465,11 +465,11 @@ int zlib_inflate(z_streamp strm, int flush) break; case TABLE: NEEDBITS(14); - state->nlen =3D BITS(5) + 257; + state->nlen =3D LOWBITS(5) + 257; DROPBITS(5); - state->ndist =3D BITS(5) + 1; + state->ndist =3D LOWBITS(5) + 1; DROPBITS(5); - state->ncode =3D BITS(4) + 4; + state->ncode =3D LOWBITS(4) + 4; DROPBITS(4); #ifndef PKZIP_BUG_WORKAROUND if (state->nlen > 286 || state->ndist > 30) { @@ -484,7 +484,7 @@ int zlib_inflate(z_streamp strm, int flush) case LENLENS: while (state->have < state->ncode) { NEEDBITS(3); - state->lens[order[state->have++]] =3D (unsigned short)BITS= (3); + state->lens[order[state->have++]] =3D (unsigned short)LOWB= ITS(3); DROPBITS(3); } while (state->have < 19) @@ -505,7 +505,7 @@ int zlib_inflate(z_streamp strm, int flush) case CODELENS: while (state->have < state->nlen + state->ndist) { for (;;) { - this =3D state->lencode[BITS(state->lenbits)]; + this =3D state->lencode[LOWBITS(state->lenbits)]; if ((unsigned)(this.bits) <=3D bits) break; PULLBYTE(); } @@ -524,21 +524,21 @@ int zlib_inflate(z_streamp strm, int flush) break; } len =3D state->lens[state->have - 1]; - copy =3D 3 + BITS(2); + copy =3D 3 + LOWBITS(2); DROPBITS(2); } else if (this.val =3D=3D 17) { NEEDBITS(this.bits + 3); DROPBITS(this.bits); len =3D 0; - copy =3D 3 + BITS(3); + copy =3D 3 + LOWBITS(3); DROPBITS(3); } else { NEEDBITS(this.bits + 7); DROPBITS(this.bits); len =3D 0; - copy =3D 11 + BITS(7); + copy =3D 11 + LOWBITS(7); DROPBITS(7); } if (state->have + copy > state->nlen + state->ndist) { @@ -584,7 +584,7 @@ int zlib_inflate(z_streamp strm, int flush) break; } for (;;) { - this =3D state->lencode[BITS(state->lenbits)]; + this =3D state->lencode[LOWBITS(state->lenbits)]; if ((unsigned)(this.bits) <=3D bits) break; PULLBYTE(); } @@ -592,7 +592,7 @@ int zlib_inflate(z_streamp strm, int flush) last =3D this; for (;;) { this =3D state->lencode[last.val + - (BITS(last.bits + last.op) >> last.bits)]; + (LOWBITS(last.bits + last.op) >> last.bits)]; if ((unsigned)(last.bits + this.bits) <=3D bits) break; PULLBYTE(); } @@ -619,14 +619,14 @@ int zlib_inflate(z_streamp strm, int flush) case LENEXT: if (state->extra) { NEEDBITS(state->extra); - state->length +=3D BITS(state->extra); + state->length +=3D LOWBITS(state->extra); DROPBITS(state->extra); } state->mode =3D DIST; fallthrough; case DIST: for (;;) { - this =3D state->distcode[BITS(state->distbits)]; + this =3D state->distcode[LOWBITS(state->distbits)]; if ((unsigned)(this.bits) <=3D bits) break; PULLBYTE(); } @@ -634,7 +634,7 @@ int zlib_inflate(z_streamp strm, int flush) last =3D this; for (;;) { this =3D state->distcode[last.val + - (BITS(last.bits + last.op) >> last.bits)]; + (LOWBITS(last.bits + last.op) >> last.bits)]; if ((unsigned)(last.bits + this.bits) <=3D bits) break; PULLBYTE(); } @@ -653,7 +653,7 @@ int zlib_inflate(z_streamp strm, int flush) case DISTEXT: if (state->extra) { NEEDBITS(state->extra); - state->offset +=3D BITS(state->extra); + state->offset +=3D LOWBITS(state->extra); DROPBITS(state->extra); } #ifdef INFLATE_STRICT --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D6ED30BF6A for ; Sat, 25 Oct 2025 16:40:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410446; cv=none; b=ibR0fIUPSUq/joXoSMkJ9mG1xvM4OWsRfil0qV/R2BI6luK479/NfhFszH/WKRhlNgi1TM7eWhstjJMEzjBeXubtzuz6MWr7vo3ciDNhpWTroI3ttkUwF9lid5aq+pR9BML2tKbxcoTc3Y2Q60nIuPPQoy40W2pUZCi5L8qNJ7k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410446; c=relaxed/simple; bh=HkqvAUV2gBzhJnul/mGo7LdzjzJg+2pG+539ApHOXFA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TL6rI5BMUNHyYyS1RzMoAYSc/w+LSS5zqVV1U16fvCnvYXCTuP5gnrfU2GfBUaQWwrpVQyRs8G/+elb7QScyE0nKdcEg96IxNrhthPflMxaykESTsvzMteH1OIgInjzgkEFKhFNx0hGdvVL5SNDf7yYwWKe6HyLh+TCy29vmy7w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YVN14onw; arc=none smtp.client-ip=209.85.219.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YVN14onw" Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-795be3a3644so17802966d6.0 for ; Sat, 25 Oct 2025 09:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410442; x=1762015242; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZXemVp+XP5C7K8PhG6mE03zKRPQX07LLYcr9/0qBaeY=; b=YVN14onwG2Ww1dUHuVA8kXevdVznYfaJfJPACF32GtrqG4BQ40tDrTfXnDzCmbSTG1 oPf++8Win6glHMH6XlcUqJkXFW94QcsEhu0dqExF9w/R1Gs9EnFsQCJdaNyp/XC6/JiK wZYtPge/GIkO4RtdFV7w4wA8yVr1FLy0BtMhPugI+he4S0dC+LxRXU8u/ZnqopQ/gf9+ 6gUCycJyDpxqzLpR7rQbrbzJf6wpHZ3qW8q3s1L/P9XgfGoTE4jpJOSg9juuyjlH3aFJ h2ommn6oVF8oQAp9rJkdqjTLN+fc44+fAbwabz2Z/TUEOIYvRn29+/7y5chUX17qn5/Z x+dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410442; x=1762015242; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZXemVp+XP5C7K8PhG6mE03zKRPQX07LLYcr9/0qBaeY=; b=oDHcdXyICpR0hu4jFMP3/5GJJmeusDJ+r/bVd1eCz7Pw8f83mnWLrJ6pghYhCdVpam LSfYDTHdunsFFdlN6qY4D4cT3+r9yGU8Re3o+HfH85JkwhJYUy8JP2iBbCeWgs5vG8Vq 7Qz53W/sPMOl7QPTZW4lTC7vAnZBeo04i1urteEsm94jQo/5PJ4iZY48NBIt2so4Qh7n esTkJPM9fE68UmA1tV4AQSQInjNEaiulzWgFSX1lkGnc2SL+7G38TtMirHNZbdqniBrM e4ReG48ix/MjrL9QT09KiM+eQlupMgPxf5329LIMpt8X60G1yKxECl95uVU0TprEGGgU SaCw== X-Forwarded-Encrypted: i=1; AJvYcCVIy5vq3WU1fiTjK1HwB38Nn1eTlLcbZADOS0TQb4avHbx3MLwrMwTO/jEwF1qNGD4b3foWYa6PhpDJpZA=@vger.kernel.org X-Gm-Message-State: AOJu0YzDiL0TAakop9boRK3yemDi9NHuHsGd5cm5WGlP5PjrWkVinOTG GMApgBInXPB27lVwfDegkRH/oITWJyTBVUmJa+qC0nsv9UOZCRq4fQCU X-Gm-Gg: ASbGncsaMCOlotithfw4tVKtKu50nAj22aH37xTieiafl55TbBBpKiSULRJKsqkEFKO xp9e4+piQdaHWSBWKDZ8sT9Bmo+pjbwa/FaYAD3IBVAzYCu6aHeFkPvVlhxBTi8xQmoOUmvDIjV BxucrnXjrNdtH7APvx4PZJrHKY2Yup/fsB6oxG2DpYgeOpgylnxViZa8k1TQ0Xs6KS7t5HJhucb Jn5kf2JHfchBMOk+AHexkRZXt/g5sJybA5Hc8Pk5Fn/DCw625QV6OfFt+tOEqp9JKvV6grpsMaV JM7mhdIIAAoVy/so7+Ex3336QJDAwis4PJ74z1hKOpFqb4RmJ/gRHMb5mC62ppGUpB9nnTf8YIP gTlITlVoB2eHl04HgKEFnIlOJF5Ssi/aGNy0D+axw7QD5NNPLGsrQsYilGpOZHwm6dG/Z5PYgnO jMSe6IzuQ= X-Google-Smtp-Source: AGHT+IFkeV9A6Ptus3JmqPV8qa6Aad4UN1X85QS76U9hx0IlT5Ln2gOuZnWRlM9bH9mA3BFWyYon/A== X-Received: by 2002:ac8:7e84:0:b0:4e8:b793:1c3b with SMTP id d75a77b69052e-4e8b79325e2mr295994671cf.61.1761410442323; Sat, 25 Oct 2025 09:40:42 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4eba37db728sm15162421cf.12.2025.10.25.09.40.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:40:41 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" , Rasmus Villemoes Subject: [PATCH 06/21] mfd: prepare to generalize BITS() macro Date: Sat, 25 Oct 2025 12:40:05 -0400 Message-ID: <20251025164023.308884-7-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In preparation for adding generic BITS() macro, add an #undef directive for the existing BITS(). The following patches will drop it entirely. Signed-off-by: Yury Norov (NVIDIA) --- drivers/mfd/db8500-prcmu-regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/db8500-prcmu-regs.h b/drivers/mfd/db8500-prcmu-reg= s.h index 75fd1069372c..25d2d5966211 100644 --- a/drivers/mfd/db8500-prcmu-regs.h +++ b/drivers/mfd/db8500-prcmu-regs.h @@ -12,6 +12,7 @@ #ifndef __DB8500_PRCMU_REGS_H #define __DB8500_PRCMU_REGS_H =20 +#undef BITS #define BITS(_start, _end) ((BIT(_end) - BIT(_start)) + BIT(_end)) =20 #define PRCM_ACLK_MGT (0x004) --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6393430BF66 for ; Sat, 25 Oct 2025 16:40:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410447; cv=none; b=V6oUAADWxrCjjp3y83dlWp9jyHGNHWGl0ANLOiRwx5Fau9u2CUspzwLf8XvSdelQA1cPQSlcr5ZQ0qyn2PGdICbejYJlgfeFIByO6Lmw5fgmBDko2b0m/7jVfg3932qODHdyDOVlcGrJsmzeLsQR5dFmb+U/HRGPMukaGJGGupU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410447; c=relaxed/simple; bh=6VtH0YRJIJT6wM7OnyxPz0sTaONVtRxS45ztLq91gUI=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CsbuGxuFBywyGyBhYE/IExeAntheqpsV/A+kUL8oJYFdfSoHs6w/uWACMzkTPxFTi7B5grcXELFw6IIAEP/KykJRZ+axPXOmTK32W5KVrDVl6/Qm1H6HZ+ATmkM1el7fV+NfaJ+d//vi05MPGRKSGrGLN6zwdkf7f8JasGlS5+A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kvDZsl/F; arc=none smtp.client-ip=209.85.219.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kvDZsl/F" Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-7f7835f4478so22924946d6.1 for ; Sat, 25 Oct 2025 09:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410444; x=1762015244; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=rg54zbsiDVSwYkKftv5+NDhQ1U50ovc7eDauHPziXJ4=; b=kvDZsl/Fl7oBZpOxXZCdNS92r8JKczW4/ODkzUDS3nBDpG+CQ8lubiDUy9kVXoqamH Mz+19/1Z4MkcQyw1syWRCc2cu+PnfT43EcWNNkXz0sS8VPcaDs/05Hg2Dwz0uHgpHBUu maDY5AYRAMRc7YyaQ/ojX2DpqfsEDMWQ+M1gZ3RLuvXHnQ++x5UTZwyUtuhVy8+ZACVN psj73tc8voCa1z2c3Wfdlznu6Nia5NyKODMF0YwWbrRY9MYniWNh9o3MznzePB9jbKk8 phk05XLO8WGPfLpPYro4OGMAHvsbQnenJGhSrrafvT4076+aNxuFdhr0/Lv4q8zJ3fZm /Dew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410444; x=1762015244; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rg54zbsiDVSwYkKftv5+NDhQ1U50ovc7eDauHPziXJ4=; b=PMmj9mfjESi4q1NtM9y1EoCSOMmosw5H8t7NSfIqolGYyiw/MbCkltdQ1u4yWypD3V UDeKwDhQsrQBRxlSq75rzlmOxA0fb6DpRK8F3PKoyg7MLKJXol4kkcxkNZIzQHnyi3Lt UUg0vYT9sSY4oEi4TWag+b/q8k7ipIzkUHnv/PYuC+5TkM+COGGUUXYHXCseRKRJy5sR 7/SpKBdkoFW77wDxvlzR1uGypdq2s6pEDXlsfugdQdzgrtw10tYh0/DeC9KCUYRTJaVS RTCySi9oQnh+qIDWKtHu9V6+qCyvfy2h02yilG+aLyfBfwSXoIAieMY0LbwrhVsma3BO Cs5g== X-Forwarded-Encrypted: i=1; AJvYcCWo2SnfMz48nGsdtcrbsjrzRb0wdCDAOJgHtymdFjOPVQ9EjZ8pZJIE1iTtTFNefqX1RdbhEyURDG1Rz2s=@vger.kernel.org X-Gm-Message-State: AOJu0YxbtsDpIB4RzBCpZ8HKxBKOCaXupMsWKY30mLlTXVurVoA07zdo Plwt4JH7yZ8WH5nTv7XSC8V81xRtn9t+10YELxbj8QoJPjSmzj+S4fmF X-Gm-Gg: ASbGncujhqL7E7tt/RheVzYBJG24IJfkb+r2G0eqbYORZowAPjTmrdt1kVmzLC2jScN jz5gcMw78JCsMvc2vNzWdzoF7vZgtUNa1PCGp9jDrm69ZRPEMrh6YKa/3+DVX0qKrcTlQZTTofm atN655/NhHlGLpJ9hCpcpNDKfFD/OPK8lo2+9sBn0L8Cwthke25qthrT4yFx9wDmdEvvmedJvOj s9ZqFg2xUy8CEGsTtExdqC+FexaGTFd+Mzbjnp2kXbKn+1SRGuT+n7VVw0UHMfaJBzE2qgDleu7 JHPkO14INzaWlvpp270pRQEw9/OVT6JC3PhNgh7Je5ENEOGNvDDaktslMhM2h1nHXVcV8vNsWsJ OkKZwI9RdDfz7Ui2TKmcAjHOGvmhVP3klI1FhjWN83xUh1BsoVxUucqSpRqRFCcENGAEn51FT3f U17PZ8Cg0= X-Google-Smtp-Source: AGHT+IGKsc2keEHm/1YFQYrnIMTwMslANRJ4raDN9IkDXbXLCbSXAIKbrJmhJuMSjVOFvhRcYi6AIw== X-Received: by 2002:a05:6214:43c4:b0:87c:20f5:84e2 with SMTP id 6a1803df08f44-87c20f5873cmr525350756d6.25.1761410444250; Sat, 25 Oct 2025 09:40:44 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc51e3809sm15359146d6.26.2025.10.25.09.40.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:40:43 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Yury Norov , Rasmus Villemoes , linux-kernel@vger.kernel.org Subject: [PATCH 07/21] bits: Add BITS() macro Date: Sat, 25 Oct 2025 12:40:06 -0400 Message-ID: <20251025164023.308884-8-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The BITS(low, high) macro is preferable over a similar GENMASK(high, low) because (low, high) parameters order is more natural. The (high, low) order is confusing and has a record of misuse. To enforce unintuitive parameters order, GENMASK() is enforced with compile time checks. In addition, fixed-width versions of GENMASK() had been developed. They make sense in describing hardware registers. In generic code, using standard ordering (low to high) is more preferable, and fixed-width features are not that useful. In non-driver code, BITS() must be taken over GENMASK(). In drivers code, BITS() is preferable over GENMASK(). The following pattern of using GENMASK() is highly unfavorable: /* Status register (SR) */ #define I2C_SR_OP GENMASK(1, 0) /* Operation */ #define I2C_SR_STATUS GENMASK(3, 2) /* controller status */ #define I2C_SR_CAUSE GENMASK(6, 4) /* Abort cause */ #define I2C_SR_TYPE GENMASK(8, 7) /* Receive type */ #define I2C_SR_LENGTH GENMASK(19, 9) /* Transfer length */ Suggested-by: Linus Torvalds Link: https://lore.kernel.org/all/CAHk-=3DwhoOUsqPKb7OQwhQf9H_3=3D5sXGPJrDb= fQfwLB3Bi13tcQ@mail.gmail.com/ Signed-off-by: Yury Norov (NVIDIA) --- include/linux/bits.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/bits.h b/include/linux/bits.h index a40cc861b3a7..c7c587e90e2d 100644 --- a/include/linux/bits.h +++ b/include/linux/bits.h @@ -57,6 +57,9 @@ #define GENMASK_U64(h, l) GENMASK_TYPE(u64, h, l) #define GENMASK_U128(h, l) GENMASK_TYPE(u128, h, l) =20 +#define BITS(l, h) GENMASK(h, l) +#define BITS_ULL(l, h) GENMASK_ULL(h, l) + /* * Fixed-type variants of BIT(), with additional checks like GENMASK_TYPE(= ). The * following examples generate compiler warnings due to -Wshift-count-over= flow: --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6804230BF6A for ; Sat, 25 Oct 2025 16:40:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410450; cv=none; b=RkUD1cHSaD4zjtpLYLpfo7Xj6ftYi+Je1N7gl4/i9REPhBQme+9JLkzpGzhRHrAxCoI7+MXzO7AOXn8O+lK7i+ecfWAfdLuSy5roco61aarXMaMyFg/3NfgtDFMEf6xP5jauY/CBwjsZ124/mQ2V42lL8OMjYic7nk6nOczuMCA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410450; c=relaxed/simple; bh=+heAOJdpmDquFU3lSVmqK3nMR1KJgJ3fOnV2yC6kTTY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s1NjtyXwBmulEy5QlsoNipFJStMnUCHv3SU++1TYJY1lG7PxcIEPHu3GQ9bBLzgpC7AOaLuRxMMkOgh3qDES2YQcVZVq+jwkhY780S0913TYT8f+Bw3hoB2l9fgO47WqrKAj8s6oaVEmvlMfsHhBgkBPkeAgqtJBraRuQvD3IPQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VNWs5z91; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VNWs5z91" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-88f2b29b651so335034685a.0 for ; Sat, 25 Oct 2025 09:40:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410446; x=1762015246; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QoCiVofkihU7HPUi3IX0CnSOHLAMfManJqPdcZxdW10=; b=VNWs5z910prLyyOsXX7ycqBE3nK+WVdVwsIb8ikH924cZMr+047PJleWj7BRPHia8O PDg6qYj+XOLDHvgEkEg0TMGkY7kZKrng5hMgo7kmPOfPqvtFK7SDGJR5Fia8uwTtIsSj XXasSqftcuwzGCRzNh928GT2EaUv3Ac/31BSDn/ZAWNir32Nul8tuK/JbhisGC4pWkCN C9MSWiPPFl48ol9SUHUKtLeQVABf9G1XJLqn1EV7aGw3lxeVOTs1zZgsXyf/8d5pkZnm s398CcOm1Wz/Lneq2X+4aR0FJGzU8IeoogX6nRXjTUaVG4SrYSzmnuWBe8y53Hjq/VXD yVEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410446; x=1762015246; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QoCiVofkihU7HPUi3IX0CnSOHLAMfManJqPdcZxdW10=; b=CTrLRHFheQH8vP6ZeLiFVGCHazbAwsZjMPSileLwD8EQwwG0t9jQFoD1i4LNkfWhUZ 1MpTGfQhmf+RAFSXpILPfk9ifmfM8OmKGixoy4XeAwOuRK7ds3bgjJ0Ig5ggPzzDwwRe hIJz15SA6nKpmTnWjywByRAso7S6abI00TVQ/ni7MvvsOpvM7klX3h2Bxr7IasJt/j7H fK0kuL7rX1v9wqYBhIMZJfDtx0qsa3nONL/gqwp3dK435OVpJxWWS36z6fqCCk1R2i2k hWvp35RUzOtCUaCrbtT9b7aGsE3WpAc1xyS3fDlcoF4hJs5z78qspJFeKSWZlIyX16uE CPaw== X-Forwarded-Encrypted: i=1; AJvYcCXSoCBZ2m87PVQjcZf25FQLiAhdVjbd8VKZa7+Es1O++zKIq3rvmhVNBxfZROFu4Ix5ha6eCPB+5hvPpK4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5TeQSjp6O5ViBla4LL2ad3/8t0A8ihifB462bUKddOYnl+00q 21LQpBLN4bJVY2Gs3wAjAvndJERM5xFH03EvLNHqcRDs8353eYcvrj/k X-Gm-Gg: ASbGnctfcqmMGn5EFNGhMbKzJSm7K3VpTNAUm9HhDo0XWeXzjUIWRFWKzZKUp1fpJhD uPGnq2rpRBXoqzxnAnuH1VTRXCiEKCbB1Srpbs2pBBvvEse2rvRk06aOc1D2rz3RdfkL3WwQYKQ 2uCJs2vDqj4sj8IFBqZR7ir676Z7aKAGdD/c/s5Zj7TkLFFd2iyqaFWxMN5eSKO/mLh88CgEk4E kdO2BpkeqYCRUXoVdHXzbrXh/n6hu9uVGIqTNhfveTgldcPwmNsQX9rFx9ypriPDy35zylDlYEy XLdk6UjrYbmge6WmnAiBIxZymCv4SUzNSx9UnynwvzTuGBfko7sblOebSeQNHelXCZbHSnJnXfD qJ3KQi/9JgEfJkRRCo70ahbtkTDJU/iU/EHpl3B+fdG1xNculmIWFNnH0KhuDdGIfC3pgr3PQrM 8IgAhKjnA= X-Google-Smtp-Source: AGHT+IEzwEpSPArjLqlG0LYeyDVza7kBw4d+eUFvxpdvGPlHshputst68kEyacFkSxRzJzhEcVF1nw== X-Received: by 2002:a05:620a:44d0:b0:892:7394:e9f9 with SMTP id af79cd13be357-89c0fecd235mr1189899385a.23.1761410446137; Sat, 25 Oct 2025 09:40:46 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f25c8b849sm173105485a.46.2025.10.25.09.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:40:45 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" , Rasmus Villemoes Subject: [PATCH 08/21] mfd: drop local BITS() macro Date: Sat, 25 Oct 2025 12:40:07 -0400 Message-ID: <20251025164023.308884-9-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Now that generic BITS() is introduced, drop the local one. Signed-off-by: Yury Norov (NVIDIA) --- drivers/mfd/db8500-prcmu-regs.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/mfd/db8500-prcmu-regs.h b/drivers/mfd/db8500-prcmu-reg= s.h index 25d2d5966211..c2bbf325efb9 100644 --- a/drivers/mfd/db8500-prcmu-regs.h +++ b/drivers/mfd/db8500-prcmu-regs.h @@ -12,9 +12,6 @@ #ifndef __DB8500_PRCMU_REGS_H #define __DB8500_PRCMU_REGS_H =20 -#undef BITS -#define BITS(_start, _end) ((BIT(_end) - BIT(_start)) + BIT(_end)) - #define PRCM_ACLK_MGT (0x004) #define PRCM_SVAMMCSPCLK_MGT (0x008) #define PRCM_SIAMMDSPCLK_MGT (0x00C) --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B7573101B4 for ; Sat, 25 Oct 2025 16:40:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410450; cv=none; b=BgQKRydvXz9fLtp0N8Ow2UXia4zgyDcHmFEvG1ZNjEMLQNxWcY2iPFH4cVhvEwq/BtcExkxJPBAZ74c7brPnrLZWpVqRDrVQFas4YfN6fI0DRfp6RfqnX7XV9yhRjYbBhtXd29tIdffNp9Zm3bTjfgh6IL5nKTZePU6O322xlFI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410450; c=relaxed/simple; bh=TQ6xv3dIaxpajiHEhlYy8yfOY1BsNMosBwcumiYnhcI=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Hx9C9VCwdnfSJNa2Hfb71EgKrNKFHqZ2X52jpL9XiFtV9fmJ7n7q6Qa4F8cV0rU81gOSRm+jHXsCsD+G0eZte8T8vIlZggZrL7Q3eOI4YIVpoFgiOAW7Gs7CkPdkErLEnrIRIpqMsUSl+MjmQc2hGUHU9esEOcqb8ztpcWQJ8cQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ln/OxjXg; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ln/OxjXg" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-891667bcd82so404806785a.1 for ; Sat, 25 Oct 2025 09:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410448; x=1762015248; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=7/JFSnIjaD6DTDEOO1oZNxHniLLcLZti7jNstgpjRDc=; b=Ln/OxjXgsOPS2s9LFBtqbJKkYsSJV7QxVb1DON30EnuJXURjWtTy8Tf7JuOPBPUSPA grM4G/+m4E34rHzlV3dFG07sh7Ym1qqwtujngCZMj+jnQFldnuYMBH18OusDE6uySlaK e+xXYTMUlXKsbGSlYYZ8zNW6C1gMN8oOhqaVCuBRpugP2vWN8vMcVycEkoZE1q07sCzu PjcyC9oOl1GGemEx6ZAb/1K3upFglkSzTX4rwo1SNI2FOpR3sSAqlB2bPLbn++iZxmJH xRxqkhaMt8r5URdZCVhjePinplkH9VhtWhlVPbxeZn0ySWYVSJj8zXa3qJOJn8zmLW1E dy8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410448; x=1762015248; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7/JFSnIjaD6DTDEOO1oZNxHniLLcLZti7jNstgpjRDc=; b=OXwdHRjPshN9Q9iK+6Or14xRAkf4NQn5Tg8VCIMiTtBF21GcRs2IupqJzzZiGUwN8Z 51tNucnBHqmZVckG9UGQp355uMBbizt/C6dl1npqZ+2XRDJ1+MYxhjeJBt2AqEvm+2ME z8JHV//jG8ukNg6jpoZAh7nxV1ADrOoJ7m2qFczv0cQfxo5c3kZTRXZJYDwIzvwK0ugH XoylW5cgITvY0v8Jku/Vomg+LhPOItJ3AWvHl9u6Y9YkfyB7ayleTY+k6az2wYT7hmcA 0YaBxZxIGW4Lv1UrdtDCS/0WJ3XmxfwZ/O489h0fye/RgFxUJU6aQdoOVEI6a3LklwsU g8ag== X-Forwarded-Encrypted: i=1; AJvYcCUPxWv94ueVR9HQxFJVM0asptKlimRxR+GXpcB4v9PrjBVyedrY13cRXtFtr4SJXv16hY8JJcgXAk0h6fE=@vger.kernel.org X-Gm-Message-State: AOJu0YxyuE5lohqA1Ci8/sYgLNFim/y+DXtwxe1bz1QVd9BXhNOpFgh1 scjyo1cLM3/zqSVfKrz0qU8krmWU0aDzDES4rgMcGZkzOIHyO6k6DegE X-Gm-Gg: ASbGncvZ3M/RdRd/YZnLxbP69/y+FSFIg1CTeGreDXw3QA1WBoynv0pSx5nCmVLQonS xFGnJqNkqQ4hFWML6mGc0IPeVJj4SuoBOuQN77ZPG6kUk23Bc1CB5sEuM/fgGP/mEIFKNg7BgsR /ae9D/owWHySDQRP581iK7qY/u/g/UeHPzpaFGX6J9CZLpI0qdphFe9pn0TzScOPbm4EcMpkiO7 RXfW/lZT4nGxy1kGPttyvLejWhaFYTz9UsCt9kK2nUS6s6scXn+fgShASztbH69NpuwMmnDFnpK LecmC3Cf90DXLhB5dc/fSz/2bkhTRuiOmC7qnyKiZ1eMTWl85GEBkjFBWqsTDI9tTf3Dv+vHca/ nPbnP7ASct/uQeKSHd5UJJK/3ykw9rNHY/LFxgFMc39oiYysxzkXK7B2VSsR06TrYnRGGkE71xz 1zFQFs8nw= X-Google-Smtp-Source: AGHT+IE7AlR8jMohfV6h5jj0NgFvybCbCIQqSaGfiLRRZ1bsf15FEk08CzXrd6JfM3gPkthDb4WjTg== X-Received: by 2002:a05:620a:44d3:b0:89d:3318:a811 with SMTP id af79cd13be357-89da08560d8mr834089585a.15.1761410448026; Sat, 25 Oct 2025 09:40:48 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f2421fc4csm174332885a.10.2025.10.25.09.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:40:47 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Yury Norov , Rasmus Villemoes , linux-kernel@vger.kernel.org Subject: [PATCH 09/21] bits: generalize BITMAP_{FIRST,LAST}_WORD_MASK Date: Sat, 25 Oct 2025 12:40:08 -0400 Message-ID: <20251025164023.308884-10-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The macros are helpful in many non-bitmap places too. Move them from bitmap.h to bits.h. Signed-off-by: Yury Norov (NVIDIA) --- include/linux/bitmap.h | 7 +++++-- include/linux/bits.h | 8 ++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h index 595217b7a6e7..fbe2d12bceab 100644 --- a/include/linux/bitmap.h +++ b/include/linux/bitmap.h @@ -223,8 +223,11 @@ void bitmap_onto(unsigned long *dst, const unsigned lo= ng *orig, void bitmap_fold(unsigned long *dst, const unsigned long *orig, unsigned int sz, unsigned int nbits); =20 -#define BITMAP_FIRST_WORD_MASK(start) (~0UL << ((start) & (BITS_PER_LONG -= 1))) -#define BITMAP_LAST_WORD_MASK(nbits) (~0UL >> (-(nbits) & (BITS_PER_LONG -= 1))) +#define BITMAP_FIRST_WORD_MASK(start) LAST_BITS(start) +#define BITMAP_LAST_WORD_MASK(nbits) FIRST_BITS(nbits) + +#define BITMAP_FIRST_WORD_MASK_ULL(start) LAST_BITS(start) +#define BITMAP_LAST_WORD_MASK_ULL(nbits) FIRST_BITS(nbits) =20 #define bitmap_size(nbits) (ALIGN(nbits, BITS_PER_LONG) / BITS_PER_BYTE) =20 diff --git a/include/linux/bits.h b/include/linux/bits.h index c7c587e90e2d..0d2950b80a3b 100644 --- a/include/linux/bits.h +++ b/include/linux/bits.h @@ -5,6 +5,14 @@ #include #include =20 +/* Mask with first nbist set */ +#define FIRST_BITS(nbits) (~0UL >> (-(nbits) & (BITS_PER_LONG - 1))) +#define FIRST_BITS_ULL(nbits) (~0ULL >> (-(nbits) & (BITS_PER_LONG_LONG - = 1))) + +/* Mask with all bits before start unset */ +#define LAST_BITS(start) (~0UL << ((start) & (BITS_PER_LONG - 1))) +#define LAST_BITS_ULL(start) (~0ULL << ((start) & (BITS_PER_LONG_LONG - 1)= )) + #define BIT_MASK(nr) (UL(1) << ((nr) % BITS_PER_LONG)) #define BIT_WORD(nr) ((nr) / BITS_PER_LONG) #define BIT_ULL_MASK(nr) (ULL(1) << ((nr) % BITS_PER_LONG_LONG)) --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1259E3101D3 for ; Sat, 25 Oct 2025 16:40:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410452; cv=none; b=eDJMMbceZPBwd2g+BE99Z4RMJOWLN5dVTKJhJQrIlpsklM/DCHCvwpWzdEn/HKzb9BIvUwLyhg/iPr5Oo02xP3z6F6znId4tJm5sIQ9ef8vEt+I7l0Gm4L1FxOLEbfdzRLQkBhGVrOAfBcCOkxTx9WmnaEBHA+czkpdrMVnUdzE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410452; c=relaxed/simple; bh=miSwCWAWlgSls2mz8C4vY/8512hTOCwNwE82bGQwr34=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H1HIZOpoF+WywrK3W4J52cb5cfs/kNeal42x6JgcgvxfbksCIynM/aHBeEYwfqJDzwTUhb2mKHQwnrg5cPc0WzSMKm8JJGHw9tKQe7Y3YJ3VdwkLs7hMHjIOf/Kljbneb3lmSKX/wczQCiSoPaWhWTezb3Auws/iJirxVn9/siI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=epYhg3gv; arc=none smtp.client-ip=209.85.160.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="epYhg3gv" Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-4e4d9fc4316so34504051cf.2 for ; Sat, 25 Oct 2025 09:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410450; x=1762015250; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fhEz+tkYwuCSnU6LNYxfD5DkxTKdrSyEg2dThddkEgo=; b=epYhg3gvZzKHKHOJgQngb8ty+no/S030Bw2bPZcIikPfhcCFkDCvAEuCOudSywR4ZX LjXgG+dhg/7YWCFHvpLjnhqrY2+Zk171kJNnvw6sw7pzI0nqHWuNGWLScLi7m7uBR/Mw lpbzm2P+3j6qMP2vJa+rOOasmnZVYrmEO2VbYfXj6oicn/DHc5HrGMNfcPQsiEgHeIJE zkJhdRoWyhpYj4lSLJibNnztw2+eB9qpSinEqISekDz8gF9rvUSCMnqNLt871pPnTlq6 RAnZoTlEmPNEitmJU3AtHUNxD1R90exH3Dytfh2gxad5drz0bSRaFv2U6fjk/xqASl3K OYOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410450; x=1762015250; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fhEz+tkYwuCSnU6LNYxfD5DkxTKdrSyEg2dThddkEgo=; b=agXwau00fdeU/imEfDSjN/iEr2G2J08loq0QPsdhjoTEiq31dAwFrag9mtGqaKhRVc oIb/gtAq3icKmTBO9UBC0LSkmSpRds1NIYQ6xO71ixJmc73Gd8BkOZpoIsbiYvYYS93h tPin24nm4FV+yo/pP4j8HUndcQbKanuVUFCBRKZp8AqE87H0iC+fy0qkWF5csfLnO8+M 7LT69MXlEAqz7em6R7kfNmJhvXo0m+q/4ws9ylBKp+FmbdaQ3eFNC0ZTRLT1BVoYWkG/ 0Yna4UN+zySf/pTevFWnDSKOBPpxzVeCQqSyjzKPaky1OwS2CAIyfPy41pbyKDHaU+P8 5MGQ== X-Forwarded-Encrypted: i=1; AJvYcCV9CUa0kw29/e0Z/dPvknrU/T7NvaLtfaFVfHM4gq8Ip4J13YIdaWM/DD/7Xll3+jKy1H2ELLj4FL/dC6A=@vger.kernel.org X-Gm-Message-State: AOJu0YzoF3UrZapjVsw1fzu/NlZploc9YtZ26SG43pnBcl+LhNM2Nu1U 1jF4PV3A+yH4iPVaNgaIJk5oDRizQLvrlp0xrZyOykzbwBr4cbCxOEYY X-Gm-Gg: ASbGnct2r3HfeKs1fYsXo4i5IPdNS5iFBWNq4W1miUAN9Z7QAWZliFCm5x8b+PYuJxr CeqsoCaeFJz+rfeParOkP2ti8zy0DQUB5IFT99469FG3wP14m9Ox3XyPutYsKHpIXWFLM3CKAZu amUJ0mCzBuDsxYaCZvPmWRoUM3XPH3PBUmu2IvL9ATM6wnwI6nXLXNDnbOccjSBZS7hdBwWeDp1 sZeHNgpUhDI4iSR9WNJI5NYRgVy1uR/Ipl4TKThwdqNXv/UMdHrezDzwLgKgRLy/XCfXtjRXajg ak86dGf7x4ZEoNAP65hPTUX8cOv6TWcRK8a0rBUtjikIi8jZJJxTU7fvgu4tHDV8b2C1lCc2ZCW lL2WT+/odQkfF58HYp4YCzgcdVDgEg3Q57OfJa2eDuwQGWKKGikrV23o3kFa/DqU2p1L57wOC X-Google-Smtp-Source: AGHT+IFg107k/tCYFMcohq67EzH90IUaPmb/gULgz0xOuwcBmv/ppnfnMODk2cLJXAhzPksQP0R0Mw== X-Received: by 2002:a05:622a:153:b0:4e8:bae7:4d0a with SMTP id d75a77b69052e-4e8bae74e00mr318957881cf.51.1761410449893; Sat, 25 Oct 2025 09:40:49 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4eba3860692sm15069131cf.30.2025.10.25.09.40.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:40:49 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Andi Shyti , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" , Rasmus Villemoes Subject: [PATCH 10/21] i2c: nomadik: don't use GENMASK() Date: Sat, 25 Oct 2025 12:40:09 -0400 Message-ID: <20251025164023.308884-11-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(high, low) notation is confusing. Switch to BITS() or FIRST_BITS() where appropriate. Suggested-by: Linus Torvalds Link: https://lore.kernel.org/all/CAHk-=3DwhoOUsqPKb7OQwhQf9H_3=3D5sXGPJrDb= fQfwLB3Bi13tcQ@mail.gmail.com/ Signed-off-by: Yury Norov (NVIDIA) --- drivers/i2c/busses/i2c-nomadik.c | 44 ++++++++++++++++---------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-noma= dik.c index 19b648fc094d..4c79ada5e1d4 100644 --- a/drivers/i2c/busses/i2c-nomadik.c +++ b/drivers/i2c/busses/i2c-nomadik.c @@ -53,9 +53,9 @@ =20 /* Control registers */ #define I2C_CR_PE BIT(0) /* Peripheral Enable */ -#define I2C_CR_OM GENMASK(2, 1) /* Operating mode */ +#define I2C_CR_OM BITS(1, 2) /* Operating mode */ #define I2C_CR_SAM BIT(3) /* Slave addressing mode */ -#define I2C_CR_SM GENMASK(5, 4) /* Speed mode */ +#define I2C_CR_SM BITS(4, 5) /* Speed mode */ #define I2C_CR_SGCM BIT(6) /* Slave general call mode */ #define I2C_CR_FTX BIT(7) /* Flush Transmit */ #define I2C_CR_FRX BIT(8) /* Flush Receive */ @@ -63,31 +63,31 @@ #define I2C_CR_DMA_RX_EN BIT(10) /* DMA Rx Enable */ #define I2C_CR_DMA_SLE BIT(11) /* DMA sync. logic enable */ #define I2C_CR_LM BIT(12) /* Loopback mode */ -#define I2C_CR_FON GENMASK(14, 13) /* Filtering on */ -#define I2C_CR_FS GENMASK(16, 15) /* Force stop enable */ +#define I2C_CR_FON BITS(13, 14) /* Filtering on */ +#define I2C_CR_FS BITS(15, 16) /* Force stop enable */ =20 /* Slave control register (SCR) */ -#define I2C_SCR_SLSU GENMASK(31, 16) /* Slave data setup time */ +#define I2C_SCR_SLSU BITS(16, 31) /* Slave data setup time */ =20 /* Master controller (MCR) register */ #define I2C_MCR_OP BIT(0) /* Operation */ -#define I2C_MCR_A7 GENMASK(7, 1) /* 7-bit address */ -#define I2C_MCR_EA10 GENMASK(10, 8) /* 10-bit Extended address */ +#define I2C_MCR_A7 BITS(1, 7) /* 7-bit address */ +#define I2C_MCR_EA10 BITS(8, 10) /* 10-bit Extended address */ #define I2C_MCR_SB BIT(11) /* Extended address */ -#define I2C_MCR_AM GENMASK(13, 12) /* Address type */ +#define I2C_MCR_AM BITS(12, 13) /* Address type */ #define I2C_MCR_STOP BIT(14) /* Stop condition */ -#define I2C_MCR_LENGTH GENMASK(25, 15) /* Transaction length */ +#define I2C_MCR_LENGTH BITS(15, 25) /* Transaction length */ =20 /* Status register (SR) */ -#define I2C_SR_OP GENMASK(1, 0) /* Operation */ -#define I2C_SR_STATUS GENMASK(3, 2) /* controller status */ -#define I2C_SR_CAUSE GENMASK(6, 4) /* Abort cause */ -#define I2C_SR_TYPE GENMASK(8, 7) /* Receive type */ -#define I2C_SR_LENGTH GENMASK(19, 9) /* Transfer length */ +#define I2C_SR_OP BITS(0, 1) /* Operation */ +#define I2C_SR_STATUS BITS(2, 3) /* controller status */ +#define I2C_SR_CAUSE BITS(4, 6) /* Abort cause */ +#define I2C_SR_TYPE BITS(7, 8) /* Receive type */ +#define I2C_SR_LENGTH BITS(9, 19) /* Transfer length */ =20 /* Baud-rate counter register (BRCR) */ -#define I2C_BRCR_BRCNT1 GENMASK(31, 16) /* Baud-rate counter 1 */ -#define I2C_BRCR_BRCNT2 GENMASK(15, 0) /* Baud-rate counter 2 */ +#define I2C_BRCR_BRCNT2 FIRST_BITS(16) /* Baud-rate counter 2 */ +#define I2C_BRCR_BRCNT1 BITS(16, 31) /* Baud-rate counter 1 */ =20 /* Interrupt mask set/clear (IMSCR) bits */ #define I2C_IT_TXFE BIT(0) @@ -339,7 +339,7 @@ static int init_hw(struct nmk_i2c_dev *priv) #define DEFAULT_I2C_REG_CR (FIELD_PREP(I2C_CR_OM, I2C_OM_MASTER) | I2C_CR_= PE) =20 /* grab top three bits from extended I2C addresses */ -#define ADR_3MSB_BITS GENMASK(9, 7) +#define ADR_3MSB_BITS BITS(7, 9) =20 /** * load_i2c_mcr_reg() - load the MCR register @@ -1028,11 +1028,11 @@ static void nmk_i2c_of_probe(struct device_node *np, } =20 static const unsigned int nmk_i2c_eyeq5_masks[] =3D { - GENMASK(5, 4), - GENMASK(7, 6), - GENMASK(9, 8), - GENMASK(11, 10), - GENMASK(13, 12), + BITS(4, 5), + BITS(6, 7), + BITS(8, 9), + BITS(10, 11), + BITS(12, 13), }; =20 static int nmk_i2c_eyeq5_probe(struct nmk_i2c_dev *priv) --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11E8B31194C for ; Sat, 25 Oct 2025 16:40:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410454; cv=none; b=V/M1+CXudZ4/ZUk8ESLEm/m+1/Etgbm6HQdmygWwsEmniNQuLbPCSdVZqmt1L4pigx5OxFbWTZUNmIdgMAL2F1wfQtY4e3AOCo01idxK2+M9KgXSB1ZxI1TrrYjqyTqxkcVH9UmEHPomVu+XHl7O6403FgGzzfWogs3t8V1Mz48= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410454; c=relaxed/simple; bh=iv3iCCSDVeRbyipC1ke5q3yTI1qFQp4/PoyLN2PjHKI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oEW/fA+VrXeJ9cxMSAzOMcjvvBD1Hyd2++/XOL11OpNevkzt1WlovSvrcUpRynDJ7yEuTzfVkiX67p7KLWojobwg/vyDAziR0Bsd771d9/j1Fhn2aecgMgR+I+EysJHOaCbSLJHLZPUNtFVjWER4MM6phq604zhGcHIOB0BR45Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CH5Pt97D; arc=none smtp.client-ip=209.85.219.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CH5Pt97D" Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-87c11268b97so33359806d6.3 for ; Sat, 25 Oct 2025 09:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410452; x=1762015252; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pQlnwek1lWpij8LeOBWh+sxDT7KmBEOhz8ZE1R1F1kI=; b=CH5Pt97DrMy2adK69ctT5bhrxVunqRAx0H+/jUSxxs0fBx9mXoxCN+96EnjVPD78Dj JX/gpwFnMB7lEXqbIDA9nBFJ4gKX810Oo0mpidTm+41TLfVhK/Ll+X2r9G5t6mDNjpNK SJWbZy+7wPvojWR9OGaCq3Hkw5avHHe0s7ig8hhBWR3ykmS+kWFktI+Sboa2cc1aim3O NATH6Canhs0gTSJLSwAUZU/orkyOVDGhCHrukY4UmxtqkxcxlN1QBbDbmO54GJvJdYvn tdy2Lk9A8BEW/y7tEaLkHKogkn0+c78bvtgMJmThPgkRKOvw8d2AEy+IZl2gMxnBTrWU fbLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410452; x=1762015252; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pQlnwek1lWpij8LeOBWh+sxDT7KmBEOhz8ZE1R1F1kI=; b=v9DRaKThSamDu2LmiPmvYFXN3Z2sm2L7byhPVj+IbZuiPo8ZsSlXZq99Pod/PAEqej LoKYucWpsLFYIJ8zMqcBWjSQzFwHQ9ILdhNmEBhfbSGRRy15vAl2HYYsNsbMfZUXTc3c Hi5sIR7DmXlpHtM1n20vi1s20GSaL69SCq3tj4ezDlju9ZdLS/oOpJgn/eapsxnRmHDp iajSQRHhQEWYV9yGrV4s43qUI7eSH0GAct20cKz1mar5VH4TeYUPfREVrGRwA7ED7zkE yWgEkP/X7vvrofQDR7sUIscuieBWamj7la6e/GGvuweMQS5dHZ11q07CMBACXN4MoAIw g65A== X-Forwarded-Encrypted: i=1; AJvYcCXculmcZmSIaKdUTI/sU5J1fEAxahuKRaNiqU5Ax+WCvNBmNk5VKtSluC/tDocheLs/qnfIqNIk39pD1KQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx//uiX6GWsQ1PacuoQNEN1cSCLsZsEpjObGxKs3MrEfD9TsUmM sJgb/aB6txESjZ4Np9deOly28Sn6B14qwnEcoqNTIY/mOMVYdxGw8oYz X-Gm-Gg: ASbGnct3J8dXIPbqK0ggCi11X6qyvUYve5jtaDHsNuzZOPyjNk9ziw7KO18BRuI0lZU iIDM3vxYcn5Q1P80AQGpKTXQG2mE/eHyhSyR0+sRdUkfeuM8/JXG02DTQGsFxpV0uKbWIeeisbd 7y1ENhLdVfH/2fWPB+bZGT7v2D4rzdKAh3BpEBdjKmRwx6JwEujVDMoV+/BxEw8Xk8HbYKzRnt6 gNtz4Dzq84YJr5Dd1dlGCLKsV2T0hfnCldoct2Qyfcp5l02Thafe5inltigfmLmk4QInCEbH0t4 GPbfOVtOddD+KZkkCQ0GQvcvLmGho0+xkrslfxkGr6T1LMQ+p1wm+X9SLmivICqiWX5sNnY/qB4 uBoQyiS6mtfHjW8ELyU59PAPFHyltqc9Nps9b6cIWT8IoLxO8uc/d0cIDwEfeGaipLnGRRO5vtC lMBLzP4BU= X-Google-Smtp-Source: AGHT+IHlyjol8Bie8F99hAjP80rz8ZMg2F2ufGY62yGvqxUFdDm1aK3+hSTgiT9hRW2DHU1QiGn1gA== X-Received: by 2002:ad4:5aae:0:b0:787:8e43:5761 with SMTP id 6a1803df08f44-87fb6473b5fmr66116636d6.56.1761410451896; Sat, 25 Oct 2025 09:40:51 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc49b98b0sm16464616d6.54.2025.10.25.09.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:40:51 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Sandy Huang , =?UTF-8?q?Heiko=20St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shreeya Patel , Mauro Carvalho Chehab , Jaehoon Chung , Ulf Hansson , Nicolas Frattaroli , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , "Yury Norov (NVIDIA)" , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, kernel@collabora.com, linux-mmc@vger.kernel.org, linux-sound@vger.kernel.org Cc: Rasmus Villemoes Subject: [PATCH 11/21] drivers: don't use GENMASK() in FIELD_PREP_WM16() Date: Sat, 25 Oct 2025 12:40:10 -0400 Message-ID: <20251025164023.308884-12-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Recently added FIELD_PREP_WM16() in a few places uses GENMASK. It's confusing and may mislead readers. Switch to BITS() or FIRST_BITS() as appropriate. Suggested-by: Linus Torvalds Link: https://lore.kernel.org/all/CAHk-=3DwhoOUsqPKb7OQwhQf9H_3=3D5sXGPJrDb= fQfwLB3Bi13tcQ@mail.gmail.com/ Signed-off-by: Yury Norov (NVIDIA) Reviewed-by: Nicolas Frattaroli --- drivers/gpu/drm/rockchip/rockchip_lvds.h | 2 +- drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 4 ++-- drivers/media/platform/synopsys/hdmirx/snps_hdmirx.h | 4 ++-- drivers/mmc/host/dw_mmc-rockchip.c | 4 ++-- drivers/soc/rockchip/grf.c | 4 ++-- sound/soc/rockchip/rockchip_i2s_tdm.h | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.h b/drivers/gpu/drm/roc= kchip/rockchip_lvds.h index 2d92447d819b..e79e6031be59 100644 --- a/drivers/gpu/drm/rockchip/rockchip_lvds.h +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.h @@ -115,7 +115,7 @@ #define PX30_LVDS_INVERT_DCLK(val) FIELD_PREP_WM16(BIT(5), (val)) =20 #define PX30_LVDS_GRF_PD_VO_CON1 0x438 -#define PX30_LVDS_FORMAT(val) FIELD_PREP_WM16(GENMASK(14, 13), (val)) +#define PX30_LVDS_FORMAT(val) FIELD_PREP_WM16(BITS(13, 14), (val)) #define PX30_LVDS_MODE_EN(val) FIELD_PREP_WM16(BIT(12), (val)) #define PX30_LVDS_MSBSEL(val) FIELD_PREP_WM16(BIT(11), (val)) #define PX30_LVDS_P2S_EN(val) FIELD_PREP_WM16(BIT(6), (val)) diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm= /rockchip/rockchip_vop2_reg.c index 38c49030c7ab..438fea5f6f6d 100644 --- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c +++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c @@ -1698,7 +1698,7 @@ static unsigned long rk3588_set_intf_mux(struct vop2_= video_port *vp, int id, u32 val =3D rk3588_get_hdmi_pol(polflags); regmap_write(vop2->vop_grf, RK3588_GRF_VOP_CON2, FIELD_PREP_WM16(BIT(1),= 1)); regmap_write(vop2->vo1_grf, RK3588_GRF_VO1_CON0, - FIELD_PREP_WM16(GENMASK(6, 5), val)); + FIELD_PREP_WM16(BITS(5, 6), val)); break; case ROCKCHIP_VOP2_EP_HDMI1: div &=3D ~RK3588_DSP_IF_EDP_HDMI1_DCLK_DIV; @@ -1711,7 +1711,7 @@ static unsigned long rk3588_set_intf_mux(struct vop2_= video_port *vp, int id, u32 val =3D rk3588_get_hdmi_pol(polflags); regmap_write(vop2->vop_grf, RK3588_GRF_VOP_CON2, FIELD_PREP_WM16(BIT(4),= 1)); regmap_write(vop2->vo1_grf, RK3588_GRF_VO1_CON0, - FIELD_PREP_WM16(GENMASK(8, 7), val)); + FIELD_PREP_WM16(BITS(7, 8), val)); break; case ROCKCHIP_VOP2_EP_EDP0: div &=3D ~RK3588_DSP_IF_EDP_HDMI0_DCLK_DIV; diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.h b/drivers= /media/platform/synopsys/hdmirx/snps_hdmirx.h index b13f58e31944..14df3f53ff8f 100644 --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.h +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.h @@ -12,8 +12,8 @@ #include #include =20 -#define UPDATE(x, h, l) FIELD_PREP(GENMASK((h), (l)), (x)) -#define HIWORD_UPDATE(v, h, l) FIELD_PREP_WM16(GENMASK((h), (l)), (v)) +#define UPDATE(x, h, l) FIELD_PREP(BITS((l), (h)), (x)) +#define HIWORD_UPDATE(v, h, l) FIELD_PREP_WM16(BITS((l), (h)), (v)) =20 /* SYS_GRF */ #define SYS_GRF_SOC_CON1 0x0304 diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-r= ockchip.c index 82dd906bb002..7fac1a7281bf 100644 --- a/drivers/mmc/host/dw_mmc-rockchip.c +++ b/drivers/mmc/host/dw_mmc-rockchip.c @@ -148,10 +148,10 @@ static int rockchip_mmc_set_internal_phase(struct dw_= mci *host, bool sample, int =20 if (sample) mci_writel(host, TIMING_CON1, - FIELD_PREP_WM16(GENMASK(11, 1), raw_value)); + FIELD_PREP_WM16(BITS(1, 11), raw_value)); else mci_writel(host, TIMING_CON0, - FIELD_PREP_WM16(GENMASK(11, 1), raw_value)); + FIELD_PREP_WM16(BITS(1, 11), raw_value)); =20 dev_dbg(host->dev, "set %s_phase(%d) delay_nums=3D%u actual_degrees=3D%d\= n", sample ? "sample" : "drv", degrees, delay_num, diff --git a/drivers/soc/rockchip/grf.c b/drivers/soc/rockchip/grf.c index 344870da7675..89fd4a4c69eb 100644 --- a/drivers/soc/rockchip/grf.c +++ b/drivers/soc/rockchip/grf.c @@ -125,8 +125,8 @@ static const struct rockchip_grf_info rk3566_pipegrf __= initconst =3D { #define RK3576_SYSGRF_SOC_CON1 0x0004 =20 static const struct rockchip_grf_value rk3576_defaults_sys_grf[] __initcon= st =3D { - { "i3c0 weakpull", RK3576_SYSGRF_SOC_CON1, FIELD_PREP_WM16_CONST(GENMASK(= 7, 6), 3) }, - { "i3c1 weakpull", RK3576_SYSGRF_SOC_CON1, FIELD_PREP_WM16_CONST(GENMASK(= 9, 8), 3) }, + { "i3c0 weakpull", RK3576_SYSGRF_SOC_CON1, FIELD_PREP_WM16_CONST(BITS(6, = 7), 3) }, + { "i3c1 weakpull", RK3576_SYSGRF_SOC_CON1, FIELD_PREP_WM16_CONST(BITS(8, = 9), 3) }, }; =20 static const struct rockchip_grf_info rk3576_sysgrf __initconst =3D { diff --git a/sound/soc/rockchip/rockchip_i2s_tdm.h b/sound/soc/rockchip/roc= kchip_i2s_tdm.h index 0171e05ee886..eee6db372ee7 100644 --- a/sound/soc/rockchip/rockchip_i2s_tdm.h +++ b/sound/soc/rockchip/rockchip_i2s_tdm.h @@ -287,7 +287,7 @@ enum { #define I2S_TDM_RXCR (0x0034) #define I2S_CLKDIV (0x0038) =20 -#define HIWORD_UPDATE(v, h, l) (FIELD_PREP_WM16_CONST(GENMASK((h), (l)), (= v))) +#define HIWORD_UPDATE(v, h, l) (FIELD_PREP_WM16_CONST(BITS((l), (h)), (v))) =20 /* PX30 GRF CONFIGS */ #define PX30_I2S0_CLK_IN_SRC_FROM_TX HIWORD_UPDATE(1, 13, 12) --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75E1C31194C for ; Sat, 25 Oct 2025 16:41:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410467; cv=none; b=meSEBN+FJWUIdDMDQ0gPbZ2RZHdszE1uV8keC+Bt6gQ5Hx72G4mgKbd33zTtJPDzhztJe3B8gLkp5Ga3CcNexILd7kHJrwEfXh2okVpijT0PcoViFF6zMjUs37DCIqroj3Ux1w4H9o2VZHvEsuhTrf7h14vxRYzQ60nMQOs32SI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410467; c=relaxed/simple; bh=/FqtaDoZDiEkgJ775gUA1lnv4tNmr3AkN5xeLieFs6M=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fBTPZv01zUDkBa7OYja85OYrx7TWrmaReoplX2rlFLeTMGDcf8WKNvq7zDTzI3dJGcwA62fVjq8z1+atgSR1jJmVugi4riAjudGC+iwPW5Sci/CnhKjmUnXnpNT6Mecebw8WhED3L7ZASHuknViAhI5KHYrG7i3it8cdNG3EERQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A2WTiFvK; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A2WTiFvK" Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-89f4779fe03so75715085a.3 for ; Sat, 25 Oct 2025 09:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410464; x=1762015264; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=fSxoEFGAAolVhXFywte18CkthEXwJuFOJ2hIbnLSDSg=; b=A2WTiFvKW012MPlO3NSsz7bZsmDUpB6Nz/56w4BEHypZbx7SQKn92AO9AOB9Qx6+Fk reoZ7FRasRvyNHfZHlWOXe5VkqN8xrMqno0Hh/JJwIjGnYwxtRUGGp4ho2/URhj6C28R hdthsQBgyYZiVoy+PRQ6rVDKV8yA4wYKMDeRHySs4pK/mzMDEtkHXn+5IYng3YgH1m32 Xk6pWoWqgc/ztYxOooIotks+csnOxuPAcvd5YTebUIACaqQ/FJLwe2P6muPFYgWKOjB9 cDXeAumq10/VBsAqbWvzIh/ix2HXQXs2oMlddvbzs6ust0By7NviIvIG85oDMKwlzqKh zd+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410464; x=1762015264; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fSxoEFGAAolVhXFywte18CkthEXwJuFOJ2hIbnLSDSg=; b=urSzhBTUbAoHZcfreQKJvDlfMDcEoWu45DzerBKPnocPRU5TogDlGNhSyi/p3GSnN9 OmNCW+yxAGhkxBFX6+jRwF8BM6srF4v0Wj8N2GCwzFSlfSgmKKx3nrputLqvqoKuSzZA 0BMmKFJUo5nXyhhqT0kYghZJgyO9TfqYdo4Vx02MKkUr1urkoMh5DCKsllS9buylAv0q x1jowoFZY7x4VB+0Rbu2uQMiwAWgAB36wMXYohpI8c7Lzw4ifSehi/MgOMBrFNEQcf2Z MPwA3cAmu13nW7WoEN7JGo0DeJRF4Pn7GKBVPeQ3yrlF3bQKHcthBMGphV8V2UWkcQOq 9SVw== X-Forwarded-Encrypted: i=1; AJvYcCX+ibSAtjC4xcla2q5hcZrMZ+yJvI2Q7RX6KmR4sAGo1Nm/05Rl2oR3tPct6A5RGoMyfzt3ARjVcZ6/ZUQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyYCpVNWc3XM7gNKGGQXfjQdTncYpIodLc0EiBg+QrU5n8pIun2 0h9OkJjKRsgljKcUGFPykuLY1EUhU0hsXK8+8MiZhW3pu7/LTxSx6fQN X-Gm-Gg: ASbGncvSIbytmuN/bT7dgXE5lG5wio2OquGXBL2vJ6wwnG5psLbfekOipvBe9XqSotk Wt0m5fQyNtDUIcCQ2IW6msFXPq37A5Ok1E09OAUjYpzcTs/Ukoh5IgZn1buVnFrz2Iot/A3hXCD NzBRnPmDBYt/MCmxlHR+mhaxXl5bcCZCGsjGf0nOBcTXOe/HIQUsP/5QrY0iwm6avF+4FIGQOsi jbya1yyu00yimA6rWsncCK0q+AS1/Gx6tlYHBm87fn+WOMpNK+5CJglOBiTqROQh0qeA/pTeANP nqAuD3gN4H7w83cra4SBU0k7w/GyTcUcYZVxR1ShUfmTGiYZyx7qPfp2+qcqiDVK3jmh7GtCHDY n0UyRq2rYcyHZFBJoEeMiDspc8gq0eB7c+4ixQJKJrPxiM/tKyYIjcRP+3Mesv+aH4rHA9AkWg5 RcqKdzNUk= X-Google-Smtp-Source: AGHT+IEJ+VGIE9njWqp738nyLBuC4v8CoidtGMfLmNNjfj41Zy6EVk/dYE8QJdM3J56MYC03DWdagw== X-Received: by 2002:a05:620a:2990:b0:829:b669:c791 with SMTP id af79cd13be357-890712b8ca4mr3696698185a.78.1761410464404; Sat, 25 Oct 2025 09:41:04 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f262716efsm172607385a.59.2025.10.25.09.41.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:41:03 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Yury Norov , Rasmus Villemoes , Andrew Morton , linux-kernel@vger.kernel.org Subject: [PATCH 12/21] bitmap: don't use GENMASK() Date: Sat, 25 Oct 2025 12:40:11 -0400 Message-ID: <20251025164023.308884-13-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(high, low) notation is confusing. Switch to a more natural BITS(low, high) mask generator, or FIRST/LAST_BITS() as appropriate. Signed-off-by: Yury Norov (NVIDIA) --- include/linux/bitmap.h | 4 ++-- include/linux/find.h | 34 +++++++++++++++++----------------- lib/bitmap.c | 2 +- lib/test_bitmap.c | 14 +++++++------- 4 files changed, 27 insertions(+), 27 deletions(-) diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h index fbe2d12bceab..3bed29f1780b 100644 --- a/include/linux/bitmap.h +++ b/include/linux/bitmap.h @@ -473,7 +473,7 @@ void bitmap_set(unsigned long *map, unsigned int start,= unsigned int nbits) if (__builtin_constant_p(nbits) && nbits =3D=3D 1) __set_bit(start, map); else if (small_const_nbits(start + nbits)) - *map |=3D GENMASK(start + nbits - 1, start); + *map |=3D BITS(start, start + nbits - 1); else if (__builtin_constant_p(start & BITMAP_MEM_MASK) && IS_ALIGNED(start, BITMAP_MEM_ALIGNMENT) && __builtin_constant_p(nbits & BITMAP_MEM_MASK) && @@ -489,7 +489,7 @@ void bitmap_clear(unsigned long *map, unsigned int star= t, unsigned int nbits) if (__builtin_constant_p(nbits) && nbits =3D=3D 1) __clear_bit(start, map); else if (small_const_nbits(start + nbits)) - *map &=3D ~GENMASK(start + nbits - 1, start); + *map &=3D ~BITS(start, start + nbits - 1); else if (__builtin_constant_p(start & BITMAP_MEM_MASK) && IS_ALIGNED(start, BITMAP_MEM_ALIGNMENT) && __builtin_constant_p(nbits & BITMAP_MEM_MASK) && diff --git a/include/linux/find.h b/include/linux/find.h index 9d720ad92bc1..24d7266fd02b 100644 --- a/include/linux/find.h +++ b/include/linux/find.h @@ -66,7 +66,7 @@ unsigned long find_next_bit(const unsigned long *addr, un= signed long size, if (unlikely(offset >=3D size)) return size; =20 - val =3D *addr & GENMASK(size - 1, offset); + val =3D *addr & BITS(offset, size - 1); return val ? __ffs(val) : size; } =20 @@ -96,7 +96,7 @@ unsigned long find_next_and_bit(const unsigned long *addr= 1, if (unlikely(offset >=3D size)) return size; =20 - val =3D *addr1 & *addr2 & GENMASK(size - 1, offset); + val =3D *addr1 & *addr2 & BITS(offset, size - 1); return val ? __ffs(val) : size; } =20 @@ -127,7 +127,7 @@ unsigned long find_next_andnot_bit(const unsigned long = *addr1, if (unlikely(offset >=3D size)) return size; =20 - val =3D *addr1 & ~*addr2 & GENMASK(size - 1, offset); + val =3D *addr1 & ~*addr2 & BITS(offset, size - 1); return val ? __ffs(val) : size; } =20 @@ -157,7 +157,7 @@ unsigned long find_next_or_bit(const unsigned long *add= r1, if (unlikely(offset >=3D size)) return size; =20 - val =3D (*addr1 | *addr2) & GENMASK(size - 1, offset); + val =3D (*addr1 | *addr2) & BITS(offset, size - 1); return val ? __ffs(val) : size; } =20 @@ -185,7 +185,7 @@ unsigned long find_next_zero_bit(const unsigned long *a= ddr, unsigned long size, if (unlikely(offset >=3D size)) return size; =20 - val =3D *addr | ~GENMASK(size - 1, offset); + val =3D *addr | ~BITS(offset, size - 1); return val =3D=3D ~0UL ? size : ffz(val); } =20 @@ -206,7 +206,7 @@ static __always_inline unsigned long find_first_bit(const unsigned long *addr, unsigned long size) { if (small_const_nbits(size)) { - unsigned long val =3D *addr & GENMASK(size - 1, 0); + unsigned long val =3D *addr & FIRST_BITS(size); =20 return val ? __ffs(val) : size; } @@ -235,7 +235,7 @@ unsigned long find_nth_bit(const unsigned long *addr, u= nsigned long size, unsign return size; =20 if (small_const_nbits(size)) { - unsigned long val =3D *addr & GENMASK(size - 1, 0); + unsigned long val =3D *addr & FIRST_BITS(size); =20 return val ? fns(val, n) : size; } @@ -261,7 +261,7 @@ unsigned long find_nth_and_bit(const unsigned long *add= r1, const unsigned long * return size; =20 if (small_const_nbits(size)) { - unsigned long val =3D *addr1 & *addr2 & GENMASK(size - 1, 0); + unsigned long val =3D *addr1 & *addr2 & FIRST_BITS(size); =20 return val ? fns(val, n) : size; } @@ -291,7 +291,7 @@ unsigned long find_nth_and_andnot_bit(const unsigned lo= ng *addr1, return size; =20 if (small_const_nbits(size)) { - unsigned long val =3D *addr1 & *addr2 & (~*addr3) & GENMASK(size - 1, 0= ); + unsigned long val =3D *addr1 & *addr2 & (~*addr3) & FIRST_BITS(size); =20 return val ? fns(val, n) : size; } @@ -315,7 +315,7 @@ unsigned long find_first_and_bit(const unsigned long *a= ddr1, unsigned long size) { if (small_const_nbits(size)) { - unsigned long val =3D *addr1 & *addr2 & GENMASK(size - 1, 0); + unsigned long val =3D *addr1 & *addr2 & FIRST_BITS(size); =20 return val ? __ffs(val) : size; } @@ -339,7 +339,7 @@ unsigned long find_first_andnot_bit(const unsigned long= *addr1, unsigned long size) { if (small_const_nbits(size)) { - unsigned long val =3D *addr1 & (~*addr2) & GENMASK(size - 1, 0); + unsigned long val =3D *addr1 & (~*addr2) & FIRST_BITS(size); =20 return val ? __ffs(val) : size; } @@ -364,7 +364,7 @@ unsigned long find_first_and_and_bit(const unsigned lon= g *addr1, unsigned long size) { if (small_const_nbits(size)) { - unsigned long val =3D *addr1 & *addr2 & *addr3 & GENMASK(size - 1, 0); + unsigned long val =3D *addr1 & *addr2 & *addr3 & FIRST_BITS(size); =20 return val ? __ffs(val) : size; } @@ -385,7 +385,7 @@ static __always_inline unsigned long find_first_zero_bit(const unsigned long *addr, unsigned long= size) { if (small_const_nbits(size)) { - unsigned long val =3D *addr | ~GENMASK(size - 1, 0); + unsigned long val =3D *addr | ~FIRST_BITS(size); =20 return val =3D=3D ~0UL ? size : ffz(val); } @@ -406,7 +406,7 @@ static __always_inline unsigned long find_last_bit(const unsigned long *addr, unsigned long size) { if (small_const_nbits(size)) { - unsigned long val =3D *addr & GENMASK(size - 1, 0); + unsigned long val =3D *addr & FIRST_BITS(size); =20 return val ? __fls(val) : size; } @@ -537,7 +537,7 @@ unsigned long find_next_zero_bit_le(const void *addr, u= nsigned if (unlikely(offset >=3D size)) return size; =20 - val =3D swab(val) | ~GENMASK(size - 1, offset); + val =3D swab(val) | ~BITS(offset, size - 1); return val =3D=3D ~0UL ? size : ffz(val); } =20 @@ -550,7 +550,7 @@ static __always_inline unsigned long find_first_zero_bit_le(const void *addr, unsigned long size) { if (small_const_nbits(size)) { - unsigned long val =3D swab(*(const unsigned long *)addr) | ~GENMASK(size= - 1, 0); + unsigned long val =3D swab(*(const unsigned long *)addr) | ~FIRST_BITS(s= ize); =20 return val =3D=3D ~0UL ? size : ffz(val); } @@ -570,7 +570,7 @@ unsigned long find_next_bit_le(const void *addr, unsign= ed if (unlikely(offset >=3D size)) return size; =20 - val =3D swab(val) & GENMASK(size - 1, offset); + val =3D swab(val) & BITS(offset, size - 1); return val ? __ffs(val) : size; } =20 diff --git a/lib/bitmap.c b/lib/bitmap.c index b97692854966..ec11cc36624e 100644 --- a/lib/bitmap.c +++ b/lib/bitmap.c @@ -876,7 +876,7 @@ void bitmap_to_arr64(u64 *buf, const unsigned long *bit= map, unsigned int nbits) =20 /* Clear tail bits in the last element of array beyond nbits. */ if (nbits % 64) - buf[-1] &=3D GENMASK_ULL((nbits - 1) % 64, 0); + buf[-1] &=3D FIRST_BITS_ULL(nbits); } EXPORT_SYMBOL(bitmap_to_arr64); #endif diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c index c83829ef557f..c198fc7a66d2 100644 --- a/lib/test_bitmap.c +++ b/lib/test_bitmap.c @@ -692,10 +692,10 @@ static void __init test_bitmap_arr64(void) } =20 if ((nbits % 64) && - (arr[(nbits - 1) / 64] & ~GENMASK_ULL((nbits - 1) % 64, 0))) { + (arr[(nbits - 1) / 64] & ~FIRST_BITS_ULL(nbits))) { pr_err("bitmap_to_arr64(nbits =3D=3D %d): tail is not safely cleared: 0= x%016llx (must be 0x%016llx)\n", nbits, arr[(nbits - 1) / 64], - GENMASK_ULL((nbits - 1) % 64, 0)); + FIRST_BITS_ULL(nbits)); failed_tests++; } =20 @@ -1217,7 +1217,7 @@ static void __init test_bitmap_const_eval(void) * in runtime. */ =20 - /* Equals to `unsigned long bitmap[1] =3D { GENMASK(6, 5), }` */ + /* Equals to `unsigned long bitmap[1] =3D { BITS(5, 6), }` */ bitmap_clear(bitmap, 0, BITS_PER_LONG); if (!test_bit(7, bitmap)) bitmap_set(bitmap, 5, 2); @@ -1229,9 +1229,9 @@ static void __init test_bitmap_const_eval(void) /* Equals to `unsigned long var =3D BIT(25)` */ var |=3D BIT(25); if (var & BIT(0)) - var ^=3D GENMASK(9, 6); + var ^=3D BITS(6, 9); =20 - /* __const_hweight<32|64>(GENMASK(6, 5)) =3D=3D 2 */ + /* __const_hweight<32|64>(BITS(5, 6)) =3D=3D 2 */ res =3D bitmap_weight(bitmap, 20); BUILD_BUG_ON(!__builtin_constant_p(res)); BUILD_BUG_ON(res !=3D 2); @@ -1241,8 +1241,8 @@ static void __init test_bitmap_const_eval(void) BUILD_BUG_ON(!__builtin_constant_p(res)); BUILD_BUG_ON(!res); =20 - /* BIT(2) & GENMASK(14, 8) =3D=3D 0 */ - res =3D initvar & GENMASK(14, 8); + /* BIT(2) & BITS(8, 14) =3D=3D 0 */ + res =3D initvar & BITS(8, 14); BUILD_BUG_ON(!__builtin_constant_p(res)); BUILD_BUG_ON(res); =20 --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53172314D2D for ; Sat, 25 Oct 2025 16:41:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410469; cv=none; b=JIcnHjqs0yyKHWcSzChPKIbdXO4vtNDcllMV3Zmpo14UyCiLz+TyEdGy+HOzw0Frh1JcucEjtZwVFTPYzLd5WEkTq3MeV4J7anMIns96yBOGmQ2kdZ3HYMitFxuyZ3SRoxIgAYsw6hCbuU01cuzQOeu5wE4JXgMt7LlXjN68qd0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410469; c=relaxed/simple; bh=XhV4d6vVAyK94tJmHv/pzX7uso4PaLhZOAOHlwMKMkY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TULMSAl2H/lmEHZTexyhsyxxhm0laoNuHKBYOYC4fbKNJe/mQjXzpidk2exbdVnwwHhe7Tu8e8efwh5unubfXENuYhXxXhF72HGYmwI0CI71ErcjZwHsYQsg54dtHhUebhIHBzG18BUTlEKdtA+mVS/kvWiFbPDmpsnxFakI86Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aidmQ6Id; arc=none smtp.client-ip=209.85.219.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aidmQ6Id" Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-78e4056623fso32594506d6.2 for ; Sat, 25 Oct 2025 09:41:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410466; x=1762015266; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ehiUcUt6iLCen11Ncs28J2yHpJNhGkVkWPyWS3jNXxY=; b=aidmQ6Id21oJUCYTKFpnRu/3uu5cLBBKQfFHDg6UqHM+oQ3eIbMTasl4LFPnWNWWtb TIaRe7dD6hA5zNu1nztSmKMu/rU3YMMGJgv8b5YD98SHeTOelHmCuQKj7A1M8R5kyYiE yQXF2slqIhWD44xiLUEv/rQ023S1+ggrFQ54zucCz4vkMkqAl28fRLxX5urqY8m4ZRbw 6+qMPY1XoSUrKpBx6Cg7GuEdLBYV6/VsSvynH8BJwRWsI0QMeTzsyy0vCBWLNU3Qz2VT lleVdUZyqpmqYsxhidB56+k6+/0FiKvBxcTpwzVqgV5pciVQhF2YmSs8MeW/Lrp5Yler FwSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410466; x=1762015266; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ehiUcUt6iLCen11Ncs28J2yHpJNhGkVkWPyWS3jNXxY=; b=DfYaIHvgytsKxZiofzA3NfFw0rdGoQqyYpVyeF+GF0QFvWxe+xJqBcM4B5IIGZmjKv IEcOSvIa+cH/qGx2tUYSUYg7a37SKGPrgFBSw7UmKoWOq6xBYl9DzDErc/G0enbDd62e afZqrhstkJwoIPmUH5mKKE7iGCJJ1bQo3EI+xEEvBQyqqNCj9EMpiKvoYEBhCe8g/LVs /HvJOMGYt9S28Zxp43jXmNtEMDNwIwCvyeAhuBajVgozE1EGgKRNzAI61IMlofpzR/bi kDj1ml+3jGR08psBcliK4uYph9Lpj21qJSj61ZXKRydjAuqIswYHAc3LjFRWbV1TCUln IN8Q== X-Forwarded-Encrypted: i=1; AJvYcCXgG2wmwV/9CEPQ+SD7D7TSstUD/lYShVkFeqBX+jJdJ2nxdzWsGoEz2J3qn2wswkPJ0CxTBp8zZuin0MM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6a1hS05ky1IZv7p6Et1nu63SVBdtlFKv0t0tnHx/dFQmhSjG9 6pgM8Z7jY496oF3f7OwZm5oN0hAtPuXZKoxro8dF0JGvUzbp2Z+HT8HY X-Gm-Gg: ASbGnctEVwp3CDoneh6lyTLNiKp+rAWrefEHQznDaITca1Gd/NZwvvrZcRBfxdB6KjV vOtKyMXrmbLFQzyq0DpghbuUV4mFpbALXgT8CJcsmN/T3dicGk3l+bVtnHd4+crdrDdajsBbmhJ nzNO/eUCwwwi1K6F13PTkFhkCpFjZp/s2BktGGdJxwAd9iHKgErtbrIer/qVr5fxYsnYgSIh20t 5BUQWJ/aDhRR3xVacrRgAGDZDqeKlK7Cv/PrFIJb9dmJ/p8IvZruRw3GXX6hQGFcVg/jLPzR1Vc 1xMf4z/DY8ABLBnpTzywQhVUZKct8NwG5lK1rEiXTA4CWmTiV5R8CsOxk36pUWot6MxvLIiXs/L x81UxHxdURJD7knFGzcqge+P+GzOY3+p5Ftrc9S+0meFuFpbxQJFAoZTN/lQ644Nh9MAbut2K98 grNkAo2rU= X-Google-Smtp-Source: AGHT+IHdUbKQhz7684jsgoRDJdwRjaQ2Xzm+lx6YWL84J4FmuB+pEZxn/rvpLnFKlTlrkm8ZxkpTCg== X-Received: by 2002:ad4:5ca9:0:b0:87c:11cb:6d0c with SMTP id 6a1803df08f44-87c20573120mr383057026d6.17.1761410466214; Sat, 25 Oct 2025 09:41:06 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc49a9d92sm16338826d6.51.2025.10.25.09.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:41:05 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Steven Rostedt , Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" , Rasmus Villemoes Subject: [PATCH 13/21] trace: don't use GENMASK() Date: Sat, 25 Oct 2025 12:40:12 -0400 Message-ID: <20251025164023.308884-14-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(high, low) notation is confusing. FIRST_BITS() is more appropriate. Signed-off-by: Yury Norov (NVIDIA) --- kernel/trace/fgraph.c | 10 +++++----- kernel/trace/trace_probe.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/trace/fgraph.c b/kernel/trace/fgraph.c index 484ad7a18463..4f21bd837055 100644 --- a/kernel/trace/fgraph.c +++ b/kernel/trace/fgraph.c @@ -106,10 +106,10 @@ * (RESERVED or BITMAP) */ #define FGRAPH_FRAME_OFFSET_BITS 10 -#define FGRAPH_FRAME_OFFSET_MASK GENMASK(FGRAPH_FRAME_OFFSET_BITS - 1, 0) +#define FGRAPH_FRAME_OFFSET_MASK FIRST_BITS(FGRAPH_FRAME_OFFSET_BITS) =20 #define FGRAPH_TYPE_BITS 2 -#define FGRAPH_TYPE_MASK GENMASK(FGRAPH_TYPE_BITS - 1, 0) +#define FGRAPH_TYPE_MASK FIRST_BITS(FGRAPH_TYPE_BITS) #define FGRAPH_TYPE_SHIFT FGRAPH_FRAME_OFFSET_BITS =20 enum { @@ -123,7 +123,7 @@ enum { * FGRAPH_INDEX (12-27) bits holding the gops index wanting return callb= ack called */ #define FGRAPH_INDEX_BITS 16 -#define FGRAPH_INDEX_MASK GENMASK(FGRAPH_INDEX_BITS - 1, 0) +#define FGRAPH_INDEX_MASK FIRST_BITS(FGRAPH_INDEX_BITS) #define FGRAPH_INDEX_SHIFT (FGRAPH_TYPE_SHIFT + FGRAPH_TYPE_BITS) =20 /* @@ -135,12 +135,12 @@ enum { * data_size =3D=3D 0 means 1 word, and 31 (=3D2^5 - 1) means 32 words. */ #define FGRAPH_DATA_BITS 5 -#define FGRAPH_DATA_MASK GENMASK(FGRAPH_DATA_BITS - 1, 0) +#define FGRAPH_DATA_MASK FIRST_BITS(FGRAPH_DATA_BITS) #define FGRAPH_DATA_SHIFT (FGRAPH_TYPE_SHIFT + FGRAPH_TYPE_BITS) #define FGRAPH_MAX_DATA_SIZE (sizeof(long) * (1 << FGRAPH_DATA_BITS)) =20 #define FGRAPH_DATA_INDEX_BITS 4 -#define FGRAPH_DATA_INDEX_MASK GENMASK(FGRAPH_DATA_INDEX_BITS - 1, 0) +#define FGRAPH_DATA_INDEX_MASK FIRST_BITS(FGRAPH_DATA_INDEX_BITS) #define FGRAPH_DATA_INDEX_SHIFT (FGRAPH_DATA_SHIFT + FGRAPH_DATA_BITS) =20 #define FGRAPH_MAX_INDEX \ diff --git a/kernel/trace/trace_probe.h b/kernel/trace/trace_probe.h index 08b5bda24da2..88de129dcde0 100644 --- a/kernel/trace/trace_probe.h +++ b/kernel/trace/trace_probe.h @@ -401,7 +401,7 @@ static inline int traceprobe_get_entry_data_size(struct= trace_probe *tp) #define TPARG_FL_USER BIT(4) #define TPARG_FL_FPROBE BIT(5) #define TPARG_FL_TPOINT BIT(6) -#define TPARG_FL_LOC_MASK GENMASK(4, 0) +#define TPARG_FL_LOC_MASK FIRST_BITS(5) =20 static inline bool tparg_is_function_entry(unsigned int flags) { --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F7DE315789 for ; Sat, 25 Oct 2025 16:41:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410472; cv=none; b=gS8j8S1a71NI5/w2X8L5/YSdAsNURM7XvEiAz/oKQe9oqHlTm2haC4yjqG0fLrbrjFwSUj66TM1qXKtgKKLwx/fO1UPfIbZ3RieYTfr9QNQtSf1XEs68Ki4LRlSo6N+A0VQPURwv5YWkM8m0YDzCxqIcp98oNxj3FyY0aGvJuRE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410472; c=relaxed/simple; bh=D84nUkpISPhfH1Ms4tl5/Hw+IaaftxzZv+6ev+Kp2IE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Pr15gNaLol7hSXoB+WvVTIU1WpN5Fv4vWIAWR33TkOFph/RD7GmIEzSIC+cUaXGBjUIXs9aS+5XzXxgk9lZnR4dllB5EuQL1oF140049rVec3qDXhR2jB6IrezJ653tc2m3xzdWJdEHIHZTwvl/bnYtBRuUIKp3+0/wpO2HNb1Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L47YjkAC; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L47YjkAC" Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-891667bcd82so404831385a.1 for ; Sat, 25 Oct 2025 09:41:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410469; x=1762015269; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+SI4944tmBFmU7KoVih1y0isAHqVxAR8yUSqEtfDae0=; b=L47YjkACejz1Y4+ttUd3BvqLxbiUtV6rru4b28XnY9s89anzhUCVxsVeGNI9aYTsz2 ybixOlT7lFYdlB6s8LK99p7iNPc1X/OMmF/ZufOzsxPIqzfRK3cJOzRmU/AN4UyPbseB wgsSvKGPTwzvJj5HX6xnIVZHm9twsXnkgro2vmuXX+QXcooI2JwRT1PWLoWapgllSuLj qO0L/KLaB1c0+KCZ8qnNN3/tvprqpALWGCR8kyVTVy0TuGzkP6KIj0ug6+I0NSGOqSyX BkRwVmKIwdasnJwdSWcTtD9RjkIdaYMfOeNvYs8SgvFRAtGxXFhi4tDA7bFSf6s9ebwS hy8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410469; x=1762015269; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+SI4944tmBFmU7KoVih1y0isAHqVxAR8yUSqEtfDae0=; b=iYeW+rvVtPz0qiKrLkP/qGyIBTfKTjMlcUifdUoT5vrgHSm72KMMq5sL5L6XGygjhn D3j8HRpDgOYi3ut4xJ/T+rWnV/yYGuYEItG1ufYA1Bh5NMxWOdRipL/ewfCFZncKw6Sl LkZagfEDPcfTbBgzIhlHo2ViJ0EBYd8P3g0uMYs0Hg6Z0UC8mZ8O0EBOTNaq56t/Eaki +ZX8iw+o0hwswmFjpFuSAccS/8rYRliS/zTu6oyYxn0Db+EdeAxSZVwLhQBzT86vkvez dJ0Ktnlkj1REZtLSkNCoprJXfYa1LgN5k4bSTTGI6d5BovUsKoQLL+m4f17QA+JVVKoG J5Zw== X-Forwarded-Encrypted: i=1; AJvYcCX6jz8Xy0i/3seBHbPDshS9rqobe9tCNNpalyzuaSRtU/G/RY1A7W6zXscywa4PxiUXWceTLz6OxF51o1M=@vger.kernel.org X-Gm-Message-State: AOJu0YycF2WUVBY0mwPcihRxiNELvr9cDDlNTyPy/nlnO8xisKrDsPdh VY0acOi+1hEdrcFYqkVCMakR3xA7DBslzmhL05Z8UoE5+zOkj5Qool0k X-Gm-Gg: ASbGncsV3x3zmQDCCL3py4F2KYu+c4OJ4DeBt8Xb/NYGnD9jU5qRVz3x7kjXFo+v5LM sTSpEwyYq0l05Ovru9XdYCoqoB5nFZI9trf4b39buapPPsM+ZPOH7/5tY5V8yXCtyovwpN+h8sR 0Fr6DP+okSXOmzdMck1/A0Xpfo/8WEaIuyMJFweWUB04lEioYZ6Y4hGpQOZCVrUNyOqA8vEo32w WQUv61CJkSdgAtXV6FvFWXYxfv2jjAxsgVnXNKvFY69FrC2SYUroCOkDl6h/fxn9tWe+PY0oUKI T1lKyACGiAexFZEzI/XZFSBqd6Uv3TrZ9Ojl2jhNUzLMWKIUdNoxSYw1eIv40p1GAiL5TIxsqBB Un2CfFB8HXxd0VVAKWC1NkMfkjXNiD5uRpD+zL9sgpNXU3IG6gnMJ6OYhW36MjEvNpX2Jynyil0 Ha6m1JjjA= X-Google-Smtp-Source: AGHT+IHKHIQ9LbaP+/C3YxY1PuYJDoDrDeVpEVRry3GCVvQrvkqZnCWFlPH08io6/ufIBsMsF6TVcg== X-Received: by 2002:a05:620a:31a0:b0:891:6a36:1bf8 with SMTP id af79cd13be357-89da08560ffmr911543585a.14.1761410469301; Sat, 25 Oct 2025 09:41:09 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f261747cbsm173632685a.54.2025.10.25.09.41.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:41:08 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Haren Myneni , linux-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" , Rasmus Villemoes Subject: [PATCH 14/21] lib: 842: don't use GENMASK_ULL() Date: Sat, 25 Oct 2025 12:40:13 -0400 Message-ID: <20251025164023.308884-15-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK_ULL(high, low) notation is confusing. FIRST_BITS_ULL() is more appropriate. Signed-off-by: Yury Norov (NVIDIA) --- lib/842/842_compress.c | 2 +- lib/842/842_decompress.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/842/842_compress.c b/lib/842/842_compress.c index 055356508d97..83b68c85904f 100644 --- a/lib/842/842_compress.c +++ b/lib/842/842_compress.c @@ -161,7 +161,7 @@ static int __split_add_bits(struct sw842_param *p, u64 = d, u8 n, u8 s) ret =3D add_bits(p, d >> s, n - s); if (ret) return ret; - return add_bits(p, d & GENMASK_ULL(s - 1, 0), s); + return add_bits(p, d & FIRST_BITS_ULL(s), s); } =20 static int add_bits(struct sw842_param *p, u64 d, u8 n) diff --git a/lib/842/842_decompress.c b/lib/842/842_decompress.c index 582085ef8b49..0520f20f4121 100644 --- a/lib/842/842_decompress.c +++ b/lib/842/842_decompress.c @@ -115,7 +115,7 @@ static int next_bits(struct sw842_param *p, u64 *d, u8 = n) else *d =3D be64_to_cpu(get_unaligned((__be64 *)in)) >> (64 - bits); =20 - *d &=3D GENMASK_ULL(n - 1, 0); + *d &=3D FIRST_BITS_ULL(n); =20 p->bit +=3D n; =20 --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46D653161AD for ; Sat, 25 Oct 2025 16:41:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410474; cv=none; b=UGTFKERguwcvK7ugM3/rCApSt82dPwZspt/k7yDswyvPv09G16sxeocmojXpToEDEOZNiPytCUTrhFc/oRpk60KNK/njYnqn9+qy+lps4yFvYQoUU2LtKQNgMWmvMmaCrMRz8WdmUble2AWXkDFBrKTtGjSODFGFZqbDM474CnI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410474; c=relaxed/simple; bh=BQ3V3TJBGcgRl9M8TTeR9VPGV9MIeZxMNrPM3NKIWvY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RCE+qRDrphCfe3LTweGZAZYEL3ddBeWWz5e+it36LimsL93so/7m3fZxAsJJiOVWvGvGFWBPDjvyyhBQYAr44NxFfDyd6+xPRS7hd7LRCAHo6UwhHZkh9zgbVLmb7FZHyRw2rV+a8J2ZwbezPQ7u+lL4kTQBp/SedFz4rv5k9DU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WsqXuqo/; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WsqXuqo/" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-87c148fb575so33744696d6.2 for ; Sat, 25 Oct 2025 09:41:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410471; x=1762015271; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fsJVQgpn61zq+Ge6F8BtEeBoOu3oJNRDvnauUG9sJYA=; b=WsqXuqo/Tuhsx8Pu0PZaNI1ZZo6qxE87GS5+EtiO+N9LGzOtQ0k5M+00e2KHd+385p j5yXdY/w0jMFqwq/onjBqTNQ8Y0u8pEGljdMCSje/jq0JsBcwi3VB79cWCQtzOFmOdye 4cL9exeCbeQ+uBHJ1vG8Y7quQKeLMwHy7229GKW6zW7+9d1noMeGoI7TnN9bQ3vI4qRl +detcSFdjJZH66iobjs66pNk3Dcju2KrfPnoE9CHyqKlSagJT5Exukig/i6+uSC6uMIw QCWGGGkyk1Yj3bVgea9m7NlkeEmjUvjQZZWemkavL35xK3kxORktOPwPcI38y2fD8TJh 1RVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410471; x=1762015271; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fsJVQgpn61zq+Ge6F8BtEeBoOu3oJNRDvnauUG9sJYA=; b=K0+GiSKZyHr93RBZ+g7My8PlEgZJ7EaS6vZ91SzKkul6BcQPo9hGIl1K2R1TP5kIZV y6Hb2GNAzYXZUwz+SBa/5alw6euJbNdctDDVCwqU39HjRy4PqK+VsVLF4CfeQOAWUgR8 Vo3qgj5TGb1bo/8X+ZxxX8GeZbIntkdSnxPIxw7LXUuoUcTryb1f3QuduuE/2dnPJeDO kwPcR7uJw1RpMp6jzcwzMKjvmmn9EgXFY8MvktSThTBIDbVAn3e8eDzdFjNmjD0tWKay oYEs103y0cBFte7bxMhmTteJQMtnPKwKYU1bV8P88AacLGm4fSxX4KH7o388Kv8VLaNb jvpQ== X-Forwarded-Encrypted: i=1; AJvYcCWB1PmlJJs3LV4B4z6dgIoYXtCXo7bUxJmim6apDeVI8zbl2/M4ugq6O9XsiaOR39KngL8ljdAwbLWEqhg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3GvMNaXOHwa43QojUkbSPSieLd6oFBNvNcvgPZS5n5oolSXN5 4ysVyxbyKeBI8LdWJJeTVP/NdxeXZllwqpBvSyNC7oT54leZBXIv/cSZ X-Gm-Gg: ASbGnctJ2j1GMxINuymTQHvYBBcqSMV3pW1QZzxLxmkGm1bP1snnar7pQfayGW6l7bM UiePD69s6aCqsxtiL57eUa9ZnQjc/sma+5YeiAFncfPbEEIhk1Bvr4bZjJcaIMrnrJC3s5MXDhq cnw0E/7be35AaC2kFNZMHg8kVHOfR06t/HBl6tvibMRasmO3+YgGYHdrS++36kcjvm9rbzQ90Ix YY8mcf6TAKen8T8KqQrU1d1nAIAPdK+Il3CmyuPZVIjcZ/7aj7bqu+NFBPok6XN+j+Tz9JiPKt3 X4yyH/pfqB0H0bbz+MhZH5MyNPcmEKF+etlnD2yewjayu/lUBWsZ8wfLCD2XuhU+RB7xtzjovCI 9hne3DFA8/mjRdkQdt3gx/WeeWcPR8CYlcaczhy/9nrMkyPiGjiwyGG/7fJ1hC0rjcWCmLWHA X-Google-Smtp-Source: AGHT+IEL1Dx+4HYqw+4sQyuOiRieC9Old4SO4wr/AN35TA8qAjfv9mLDb5RqV2L9cyVVu7WfD8Eouw== X-Received: by 2002:a05:6214:2aa2:b0:87f:bb8e:410f with SMTP id 6a1803df08f44-87fbb8e4dfamr72431596d6.50.1761410471178; Sat, 25 Oct 2025 09:41:11 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc49783eesm16403476d6.44.2025.10.25.09.41.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:41:10 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , bpf@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" , Rasmus Villemoes Subject: [PATCH 15/21] bpf: don't use GENMASK() Date: Sat, 25 Oct 2025 12:40:14 -0400 Message-ID: <20251025164023.308884-16-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(high, low) notation is confusing. BITS(low, high) is more appropriate. Signed-off-by: Yury Norov (NVIDIA) --- kernel/bpf/verifier.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index ff40e5e65c43..a9d690d3a507 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -17676,7 +17676,7 @@ static void mark_fastcall_pattern_for_call(struct b= pf_verifier_env *env, * - includes R1-R5 if corresponding parameter has is described * in the function prototype. */ - clobbered_regs_mask =3D GENMASK(cs.num_params, cs.is_void ? 1 : 0); + clobbered_regs_mask =3D BITS(cs.is_void ? 1 : 0, cs.num_params); /* e.g. if helper call clobbers r{0,1}, expect r{2,3,4,5} in the pattern = */ expected_regs_mask =3D ~clobbered_regs_mask & ALL_CALLER_SAVED_REGS; =20 @@ -24210,7 +24210,7 @@ static void compute_insn_live_regs(struct bpf_verif= ier_env *env, def =3D ALL_CALLER_SAVED_REGS; use =3D def & ~BIT(BPF_REG_0); if (get_call_summary(env, insn, &cs)) - use =3D GENMASK(cs.num_params, 1); + use =3D BITS(1, cs.num_params); break; default: def =3D 0; --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 527773164A8 for ; Sat, 25 Oct 2025 16:41:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410475; cv=none; b=p4yIMItgr53EfYq5BbXrI+44Xv2sxbvAXZ0wCFBJ5bZW0juV+rgxcZun6DjyW9fz8QiA4AJti2pYIQuzAeSYXzdUH1KPvCWBlJOKb+/Pt+lQjjspVdV3ttWXrQfhfwyU7Aamng+r2H9U2UDp+hIaoGBPL7rVMoMimBvk8R7Be5Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410475; c=relaxed/simple; bh=+b2D4vP+c+kh3wd/DS3NcNXJ9L+1kZpJcsBrgvelyh0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Nz1RtZVlZgDp8oDLNpfxlpkbJIFfbeRrLdr3sqp3tOqQbQF6q723K5nVGOsIS9fQUXFidBaEdRYJmwAVOcUEMYsX5iF0Gnqv5ZfVFDQ2Q/cvezm7iTQ0IRuT38BpQZcKpWghckKgX5dlwX8eeEW0uOIFmvySCVOCoRRe10RC59g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nYD/Vwxh; arc=none smtp.client-ip=209.85.219.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nYD/Vwxh" Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-879b99b7ca8so35251466d6.0 for ; Sat, 25 Oct 2025 09:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410473; x=1762015273; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QSGBaOZhD7YMIGtASkoY94KR31YSs6yG4R1SCYeYD08=; b=nYD/Vwxh5DzzjbOSCUe+NVazQ4qdcD3uJBk8V5wd1q4aa315MUnT1QIBHVkuUE/gli 8+cQ2CkvHs5ffMaCnkxhYr3eIhPvVgZ5vS54ReR/BF6e1M2mIQiO+XLTctvIkfBuw5gS 4jjugNJurf8YLw4Dlf1QsA1f6SGvBjNcrRA5GpIlUGyYTRBZZTEfnzuYA3S61NsgGCUq 5w9BjX1yMmRoNTmMHYeIDX4myaXdGB9airko2oNP/iDUfTW6yvTyOUTp62cZCbveWCpg Zp/fWF52HX0HrMAaHBJJ09T5vRO7BwkXa7D8gdReiOhdWwyoNZmJPPtYOMC1raxObkxY /DIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410473; x=1762015273; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QSGBaOZhD7YMIGtASkoY94KR31YSs6yG4R1SCYeYD08=; b=PAxETfzpd6XgXuDDIx2F9rEHunXERPJJYo/B+fzVF9eXHhsbX9Bvzx+HF7eETZkBqM DdcZuxwKsu+S0mxwYrCvYWEJlxXtPimlZNA+vMtv4Y9kEwC8Dj541Lip1Ztwz/j2pR1V fg+IH+X+qNqUw/QJKxN5HSqAAotctUaeMOk4XsmOS3HgxMqUCPKjJ+M4ZIHPMF9tFzu3 xKqAgsVDub99UId3kn6LSjm/hMFfSwD7tGy/1jOzuYrduLqQ7PZm9U0FpN/7yg8zVbqm /RnZarEUWjBcjpY/GygWYxWq1d5mzeKauJtxXIvxCtNVvhNSkNYPz2W4PRN6VksTsAe0 RgVA== X-Forwarded-Encrypted: i=1; AJvYcCUdOTkN562CknjFohSxfGMyrodbFLZ66naxHpEyZyulF/I4EErpw40RJYOuxPcuYZkqttzHwF61vYLJqhQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7KAz0VdVGjsdT2PdKCy84CEDTaCSkH39DCBH784YKarvhsqpm TeMEEsiHZQDXbh0SHyFTVOmd6ypuF+36pz75r2t9e0uU8zWmUP6QwEa8 X-Gm-Gg: ASbGncuuwTJbUrjUUJC+Kl84kMl8JomgLSEBt9PXdRrOooGRjOK8SOkCwE92crvqbSO Pc2pzcXDqBIdoe6s1UXtsjF6etqFBOx8LD5A+oCvDBIdVFva0uiH6Hbg9y2MDgix4MamdDk2gEB zsNXBLy1ILRkLG5mgo5OumlLQBFczTSYQTxFdzvGu3TT/Up4lp09d4dCZR6558Fyf1/3F1kPqkB kBsZkbB3MtXFhbluX5+9eI/x9YhE4GTHzS/yNx50ZdKQgIZfmf9wJ4etrXbOvIJKd+gZpGcHx8s e8ZhSNOU7gcj/MU43cL8H1L2k8y6UvNy9I80G7vcQOJjXormN5iSQSjARScE+Tsl11kPSG/MfF5 GqR9SlTlMlBiGlw7JWZ2utwL6LLBdXxpDd2WP8kbheH2xNdRANzcsV69OnkEEcU3qDqTSPYeiuU 8bB5BM2bA= X-Google-Smtp-Source: AGHT+IET2ieKd7HClaxmc2UuGKPF0U/OBuKh4tSzjlCkAHwEFQ6XG5lTAKnqA569CDimliHjdRoa4A== X-Received: by 2002:a05:6214:da9:b0:87c:20ae:68d2 with SMTP id 6a1803df08f44-87fb636016dmr79581736d6.1.1761410473001; Sat, 25 Oct 2025 09:41:13 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc49783eesm16403966d6.44.2025.10.25.09.41.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:41:12 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" , Rasmus Villemoes Subject: [PATCH 16/21] kcsan: don't use GENMASK() Date: Sat, 25 Oct 2025 12:40:15 -0400 Message-ID: <20251025164023.308884-17-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(high, low) notation is confusing. Use BITS(low, high) and FIRST_BITS() where appropriate. Signed-off-by: Yury Norov (NVIDIA) --- kernel/kcsan/encoding.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/kcsan/encoding.h b/kernel/kcsan/encoding.h index 170a2bb22f53..3a4cb7b354e3 100644 --- a/kernel/kcsan/encoding.h +++ b/kernel/kcsan/encoding.h @@ -44,8 +44,8 @@ =20 /* Bitmasks for the encoded watchpoint access information. */ #define WATCHPOINT_WRITE_MASK BIT(BITS_PER_LONG-1) -#define WATCHPOINT_SIZE_MASK GENMASK(BITS_PER_LONG-2, WATCHPOINT_ADDR_BITS) -#define WATCHPOINT_ADDR_MASK GENMASK(WATCHPOINT_ADDR_BITS-1, 0) +#define WATCHPOINT_ADDR_MASK FIRST_BITS(WATCHPOINT_ADDR_BITS) +#define WATCHPOINT_SIZE_MASK BITS(WATCHPOINT_ADDR_BITS, BITS_PER_LONG-2) static_assert(WATCHPOINT_ADDR_MASK =3D=3D (1UL << WATCHPOINT_ADDR_BITS) - = 1); static_assert((WATCHPOINT_WRITE_MASK ^ WATCHPOINT_SIZE_MASK ^ WATCHPOINT_A= DDR_MASK) =3D=3D ~0UL); =20 --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 982BE306D57 for ; Sat, 25 Oct 2025 16:41:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410478; cv=none; b=NsgSoBrj6RJXESlSari30aYQaNwucefKKTtTXulDpeLEewAPVyQnbm69go0RVfQ49mlDdvxUGp1xh50Xi6sHV2+yAUVjxaWfQNPOmKGQBlmaSKrJBsF3rmK1iidlL0JgLeXXxb/KcIc9U+2m98mQfPGNAvyM4PqqHqZRpxeaGuw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410478; c=relaxed/simple; bh=1bcynx9xewGI6dVd6TNDYQ5HTZ9qbz+hT47nRzvSCxE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sEiWxlpJo34NXeJBLVUgGKSCp9H8p2Hk68YCtLjQ1JdPwsD5txnyKH72GFHGxbWck8u1GQwSmbFG5r68MuATQHLuLx5CdrA3fKsChubqZ6Yw0kNGcSbY7ghG7HqVsm0KUF3Cr66D014wvuSernXC5CE4lJKtx40E4zrowdNbDzo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d6bMcV1N; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d6bMcV1N" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-88f2b29b651so335075685a.0 for ; Sat, 25 Oct 2025 09:41:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410475; x=1762015275; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0GldqH8fEtUrzkHne1rF5BgiofNp7hGD1Vw1w37mqgw=; b=d6bMcV1NyxUvtSagw/2W53yzNS7fNBEJl5S4XnCxW5cbGbSThZ56pYuTXHP66y272E Z+hi61y/D5eB6nzkCtYq9KwUoiU54foQdVdk1h0MfqKolhgZSHsD9BNO458QUn16+Whc sr568QI0H+8rqxjKzCw0UaTpn0YLEWgY8S8HzQT5u3Ah5234+ymvx89/89UbQ22Wvryx KNChdmR0N4IekiPV5uWl8wI6TP3KIIxNx2PGB54MoFOMPhJ9eCJlFMxdmSsJ0rc3Sb+e K/WJV00fNI4WyFDXSjEceLJnK/Ym/FrTAHwcscWaE+SgJYvbMycVj56zVKyKSlUFbpih dEfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410475; x=1762015275; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0GldqH8fEtUrzkHne1rF5BgiofNp7hGD1Vw1w37mqgw=; b=qbqElnm0fHFlAWzJRkoeWxOje93jiX0KGYDoHRDnITSsuEzqsb/d+0wIBsoUGvIpbn RJpQogC86f+i8HsBEgcN8ZEqSAhysjAkCE1S0uUi9snL6Y5hs4uy6tnVS6NIuwiExyXb d4HepLd+sGajelZU+y0LMT9mDkozvzqbEJo8Bam0nkWedQON2tjNTbO43XegQOj+akwV RFCQsksNy/YQRIYvDqd2YkwcUHIiESNcuRyxuMG0LY05H/ngZXjOeJzB1Z/V8ZNDJDh3 DSLr3oHAyxzAX3vGppzfH7NwsOIP5bVRxy4Goof6l6I+i/w+t/8Y7Skw/70vR6vuh1gw PG1g== X-Forwarded-Encrypted: i=1; AJvYcCURCSuRICsSEjcco6hXF7hPrpDEJDWU2qd+qsVPB+ZhYkD41IXW78F2RO9RYgOQh7ZRF5GWpV9w/Z2Ib0g=@vger.kernel.org X-Gm-Message-State: AOJu0YwGsN1BOFbmmiQdEBNTbnizd35rIv57+tuXuzNX5A+4wrEfNe7X 1efsAjclRJK1DrrjmY4DpZdyZGPcWn7h/Oh9WVGLSfgePDimkxEC00QvqYPbkA== X-Gm-Gg: ASbGnctKKhH7AxSbxaG1/b09GD9+p3No0nInU3GAbSUZaqyx2OOIVS8hs+Okvo4MJDy i9+ttqjsPMIQjS+bOpUYx1yR9YDn4kZ37LcjHREjw/dfvGWe86mki7VGe3sMv66cNH3NgVXOsaE deNvaZZcjy6wSCo/R4ODMe1m1ugGd7qL9Lt0/uQNKsAVx47oNO4NrEDbUVI+M8b3WNHkpTts7sI PlMgxeN4ZvD6hJNOirhxdUyzFhGA2QCCXfwg6408U0X17Q0sq2C/NEKtNebmsYAhPf8aygTt552 lB1iXrUEo+Uu9SklBkdKKctESPvbPatE6F9asuSnzOSWy2JHh1kTo8PudaetF20RI0WtLNZBFsm YWLtPYSuJO1ySroZUJT4+MM1wEbEp2VPxx9ClzKRN0/ESYPP/0RP89wJY7nQhl9iI/kH9NHIUdX Ua3sVJrfw= X-Google-Smtp-Source: AGHT+IGJ5EoIFI83t52hIGo3M/2FHLwpmX4KGwa2Lw/NwuS3C1UYigsffJIqRTq4YJBeHeKmK7LHUw== X-Received: by 2002:a05:620a:1a0b:b0:88e:991e:cf2a with SMTP id af79cd13be357-89c11e631cemr1286912085a.44.1761410475508; Sat, 25 Oct 2025 09:41:15 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f24cd5938sm173525585a.20.2025.10.25.09.41.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:41:14 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" , Rasmus Villemoes Subject: [PATCH 17/21] mm: don't use GENMASK() Date: Sat, 25 Oct 2025 12:40:16 -0400 Message-ID: <20251025164023.308884-18-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(high, low) notation is confusing. FIRST_BITS() is more appropriate. Signed-off-by: Yury Norov (NVIDIA) --- mm/debug_vm_pgtable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index 830107b6dd08..b722dc3c091b 100644 --- a/mm/debug_vm_pgtable.c +++ b/mm/debug_vm_pgtable.c @@ -40,7 +40,7 @@ * expectations that are being validated here. All future changes in here * or the documentation need to be in sync. */ -#define RANDOM_NZVALUE GENMASK(7, 0) +#define RANDOM_NZVALUE FIRST_BITS(8) =20 struct pgtable_debug_args { struct mm_struct *mm; --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3675A318135 for ; Sat, 25 Oct 2025 16:41:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410480; cv=none; b=W/khAsiL34cW0Yt/qxTNuz1UpPVMLEHbSux3AOEXjGjn4lJuI3Hk2CtMsE/8MRvl1hpc4MKFk0YDs3G20NZjVM9iirr0wi1Pf5Bki0T1lVmJs00KVLagYno3AmaF766gltPZG7S6VrSMbX9m/NHAEh8pcW19+FjQOZYg4xJjWM0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410480; c=relaxed/simple; bh=/qN13PxTPUF7Pj/bbigcTnyf8UWTFD28fitKT4TB900=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PMT4Y9JcT65KUt8z1R/ExOcnF43+LffGMRXjkzhgPBr/eUuMIPPENMNbTQ1JfUK4cj9WWsqz2vG0ikAyknXYaiYzSYKOtbhzONEwoOG4kMVia1J75pGl7B1rktGk2zUjqhAf0EH21nQL6JkwHkcd5kTJYo/0KlMNsB73VWqAxK8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CgS7FhGV; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CgS7FhGV" Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-4eb75e8e47eso39409941cf.0 for ; Sat, 25 Oct 2025 09:41:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410478; x=1762015278; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FgpdQly6UAXSTR5MLgLdCsEnF7u6zwKVu6ylG76tjIg=; b=CgS7FhGVg8fFqEhBJbb0kDUmXQ2pmzjMaG8/WeYHyxGL/QlfuYZjCRof6QXqY+WBPG QAcUcFWvoSmJ5/6YRoGpBO180ia6S94cNbVo/dm4q+P7F7nF/+Utkjsgd/GiDMIxfxkA eZLdu9t0W6ELmPSChAAM2B6n/UmYA5PKVi5JfQLexSjQPBDrFQwKEiKHcPaVaURJt5BO DYlFMCI3+uK79vyknH/4jbYNUjIC1JdUcYa5Ijc8Bmsc5LVRAbnoLMTXyAOUTY4IY9Yn yHhE0L+KbPykcjz5ewqreNySG8mjDlR6WYCVOf5coTMl20OBcE/MFf5QT76pTx62+yyK wjSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410478; x=1762015278; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FgpdQly6UAXSTR5MLgLdCsEnF7u6zwKVu6ylG76tjIg=; b=mcFTyi6cjCXX2xTZ6CCKIys4lpCeEOKidKdlF6yY/LPOVkFm5Pq57uEHpj+v4TjEka CsDY3rJRTCcG+HLkWTx/cN6VMPjqHTlarbJ1EyMcxePROcj4UQdQCGms431q8SA2kwHD BGa+zEeYolgNp6l59aY4hTmCLi8Xi5Kxxvxr3k3IXjAsM/Hux0bEhlM1V0mH/Phoyeqj mI3NfU+M0tFBfCHNP/0Av7N/4zJU5KhK3TPHnkyuk2sIQ9//OAOFu33fnW59Z610zc/e KRqo/MqznS/rZMG4tytFn08LPXkrPPVfMyH0wyDEV5nKsB2L4JjV08bnQAc23XT2fWuw 0gkw== X-Forwarded-Encrypted: i=1; AJvYcCVpe5MTFC+C0TWYvNJwwqnpvXSyh+TuEe8GTFndjVXaHGkR8bhXth1kPrViE0PCGnjX45rvZXnUUafkHB8=@vger.kernel.org X-Gm-Message-State: AOJu0YwxkAEqjhZK/8NsfAb7OTGfMlvW/JARlOSUbTxpj5+xHo4x+m66 rETFIP+EDNooGmX1CtVl4BO5QfOJqX70BbGHw75HWDdQ6VqbhhvH7N2K X-Gm-Gg: ASbGncuk7fk8+8weWDrJPNHeL/w9XVQbyWZT7Ygajbz/eIRsjzWZhoJdSDvMZDKbJ9I wgC7/4UCtYHaVm4NcNIm0ZFhuUbYc54RxU8/dtAeWCCqBh7GbmFr35v5bm3JA+3r5iGEBz9m7Hz UA42ZWa4gK2+Ci2aD9aKt5LWxzH8QNxToIlWYnOIENtda94UVUBN2PWwPZXhoGQEH/JyLWkh832 0o5qK00weCR636qEIN+2T5KK1MIU/o+/1sOholh0CnS6KcM7fiUxmt3FmcfqUzhURAtTsDBU7aU jH3FEF4nWv7lmlp519Kl5jKfRan1iaZWhI0EYcVYp5riQuXFuGVf30mAh8cUJxx+ToVJ94vM5PU lu4uyfVCPRk3AAC/TWWJ0rtlpRXG/L0k/2qDnQaA4OzHda2ByCWGscnBggK13neDaFuM27vMm6S vWGVUqo3hnsPYEUjJlZg== X-Google-Smtp-Source: AGHT+IFkd2wHzM2bhvAxcegsRzuQmKhnwqeGyXDU7KQiqF7VzEOSt8dgBNcFI9XF+zOOfS1sMpRDCw== X-Received: by 2002:a05:622a:101:b0:4eb:a668:f80a with SMTP id d75a77b69052e-4eba668fd4bmr28177301cf.32.1761410478191; Sat, 25 Oct 2025 09:41:18 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f2421fba6sm175785685a.4.2025.10.25.09.41.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:41:17 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Arnd Bergmann , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" , Rasmus Villemoes Subject: [PATCH 18/21] fprobe: don't use GENMASK() Date: Sat, 25 Oct 2025 12:40:17 -0400 Message-ID: <20251025164023.308884-19-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(high, low) notation is confusing. FIRST/LAST_BITS() are more appropriate. Signed-off-by: Yury Norov (NVIDIA) --- include/asm-generic/fprobe.h | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/include/asm-generic/fprobe.h b/include/asm-generic/fprobe.h index 8659a4dc6eb6..bf2523078661 100644 --- a/include/asm-generic/fprobe.h +++ b/include/asm-generic/fprobe.h @@ -16,17 +16,14 @@ #define ARCH_DEFINE_ENCODE_FPROBE_HEADER =20 #define FPROBE_HEADER_MSB_SIZE_SHIFT (BITS_PER_LONG - FPROBE_DATA_SIZE_BIT= S) -#define FPROBE_HEADER_MSB_MASK \ - GENMASK(FPROBE_HEADER_MSB_SIZE_SHIFT - 1, 0) +#define FPROBE_HEADER_MSB_MASK FIRST_BITS(FPROBE_HEADER_MSB_SIZE_SHIFT) =20 /* * By default, this expects the MSBs in the address of kprobe is 0xf. * If any arch needs another fixed pattern (e.g. s390 is zero filled), * override this. */ -#define FPROBE_HEADER_MSB_PATTERN \ - GENMASK(BITS_PER_LONG - 1, FPROBE_HEADER_MSB_SIZE_SHIFT) - +#define FPROBE_HEADER_MSB_PATTERN LAST_BITS(FPROBE_HEADER_MSB_SIZE_SHIFT) #define arch_fprobe_header_encodable(fp) \ (((unsigned long)(fp) & ~FPROBE_HEADER_MSB_MASK) =3D=3D \ FPROBE_HEADER_MSB_PATTERN) --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 635D231960D for ; Sat, 25 Oct 2025 16:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410485; cv=none; b=qsZKds2LrUHaggz3gyJxnu7NiS3K5AcHfEaQerOMKJk+UJfTrnsurTgQf16GGbndQ2wSwNM0LlybIJcmAt7pazKKlUlB92CDsLU6ep8PokpwslaKOxpVQZaKec7cR9Ih6wkbVVXlddx0uB19HI+oFYViFtAShPO9+f2PG2IAgFs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410485; c=relaxed/simple; bh=M6vYwiDXFrwliwHjWTkr6oRqx2KgbMTp+xr1SyvsQ5Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W8C3S+amxJBV1RYmSdFo1en9/Kvv9o2B5mZgoWInN6Nekxdvt4l4VhamggkQ3D1B9Sf9PE/r1EhOlz4hIlfgMO2l+gQnUoDDpAx+TqADWLFDCcU04nGDb+iP4USu201eQCyYfMajJSofkqIjeSlFRoopdSwr6bcTOBQxoIzhsRE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ao47nZRp; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ao47nZRp" Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-4e8b90e9328so23782601cf.1 for ; Sat, 25 Oct 2025 09:41:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410481; x=1762015281; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v+kdgwxqgLpSk+BXagyhyh0KizQR0PlmXlxRpNRvoio=; b=ao47nZRpcW2eXLIVAQJTziNI7xHxLdffM/OF8QltmHhwe8KAkjLBY6zR5qLij43lv/ PKI+QP3pla1Yq7f8CZ7RVGuWQFLliJPYqkvV/b0Ib2jUBRyEiYzV6orh3eBuOBVfUKh/ jzh40TVdZZ8umoloAWbtHGzKxtZLufdEcrnrOB3bbo1NTyh0jzK7qc3vEwugiSsPYzSJ PBtm8JmwKiPm1U8vlRxiaDpkN5Qu+qpBzKDZxdVw36Vbuq3Z+h08+4pf+iHrKQZK5+US Ln9qgbZkBjMA5vb07ROKrDW2CltDrhf4TsvqsWoJBiY8dNT3d70duChqB0aiiRnBJ6Px eT8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410481; x=1762015281; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v+kdgwxqgLpSk+BXagyhyh0KizQR0PlmXlxRpNRvoio=; b=L6rtwoSGGdFWx0XwhPR/M7QHN0Wk3Y/szJE6Q51hgv7zSK50h/T1gAGyRfz2FOLJgq MlTzF6rL6epnCbamGvioYr6JFxyGP4YKUx0U9WdX/90dYSR4RmWEl83TUy6UjB6/Pf5K J7klQ1mX5t5EH0mMj+WZoK6HE3520OKpou8xKmC1aDlY8mCzfhbNDhFPpXGD6/Qa68bR +6YytKE5s6VulyqEgCPaW19wW2iNtnkTpFwOb53hlrF+H75tCx+EVqfvZUomhTJat8Jr h/tviIC+wgd322pO2fDEGup4x+C1j1IjsH4V7Fs9SEpRAIIrsPAfV0okLLT5IFLg4kN4 WS+A== X-Forwarded-Encrypted: i=1; AJvYcCW84liskmVNYDhifsTwnPzHv1qZnQik4e52809mgCic6+vv5AIpDeApYc2PDDEh5z6MzFaTybOlz9kScYw=@vger.kernel.org X-Gm-Message-State: AOJu0YybEsmdH84pf9+poeY3eUv9ZlZWc5DzjXdC5s7k26qtOOT4Wm4i NxA86iLpAh6nE+FbDbCU9WrSGdctwfZ5yBznajyswBOXP6uLMUlIGhW2 X-Gm-Gg: ASbGncvrVxH8Z5QWxIRqwJ9+3RRYVV8zlfFPVfU5D43gpY2VswovQH0ZvUgeWEn2M8v auXqS760yjLW4b88Ur78vbqgqiCUSDe+E6YVrJLNk+idNTV2CX8mPbfJ/hyTie9WPCO59f4IYi9 1Fog/SKWagxFcYxi5BdKdRl0/oWs6iUib+dy2YNmMq0ZzmXclwQghLT41tFhNRv4vx4OCw47Fwz LuE+h38Ep+GcjsHuDXTV9OlcQuiw6P6TFbMyaTwMylCf4KLFgQjI1nMJM/6BpA73JBykHpGhp97 Tpp8KAUNqHu9rFIEjGKK803NJRG5JoJgjflrd9AlJatWgvdypsAMqdBp+3ZTuuR1rUlUdSzlTCI ZpYAkefgY6ADjMfNHvRQF3yRxqhECxnHVUhtkidctDWU2x6vfl1M7TaeLOD3A4Zj9F1AXA120 X-Google-Smtp-Source: AGHT+IEbSTHOPYn/ssbsalfndo2SE/aquOPMKCRUcU70dpCWt75EhJinxXayNqNWEpmv6XMRvXc8Dg== X-Received: by 2002:a05:622a:48f:b0:4e8:aad2:391c with SMTP id d75a77b69052e-4e8aad23e00mr349567941cf.1.1761410481317; Sat, 25 Oct 2025 09:41:21 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4eba3858f1esm15257191cf.29.2025.10.25.09.41.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:41:20 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Jaegeuk Kim , Tony Luck , Reinette Chatre , Dave Martin , James Morse , Babu Moger , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Vlastimil Babka , Suren Baghdasaryan , Jinjiang Tu , Baolin Wang , Ryan Roberts , Andrei Vagin , linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" , Rasmus Villemoes Subject: [PATCH 19/21] fs: don't use GENMASK() Date: Sat, 25 Oct 2025 12:40:18 -0400 Message-ID: <20251025164023.308884-20-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(high, low) notation is confusing. FIRST/LAST_BITS() are more appropriate. Signed-off-by: Yury Norov (NVIDIA) --- fs/erofs/internal.h | 2 +- fs/f2fs/data.c | 2 +- fs/f2fs/inode.c | 2 +- fs/f2fs/segment.c | 2 +- fs/f2fs/super.c | 2 +- fs/proc/task_mmu.c | 2 +- fs/resctrl/pseudo_lock.c | 2 +- include/linux/f2fs_fs.h | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h index f7f622836198..6e0f03092c52 100644 --- a/fs/erofs/internal.h +++ b/fs/erofs/internal.h @@ -250,7 +250,7 @@ static inline u64 erofs_nid_to_ino64(struct erofs_sb_in= fo *sbi, erofs_nid_t nid) * Note: on-disk NIDs remain unchanged as they are primarily used for * compatibility with non-LFS 32-bit applications. */ - return ((nid << 1) & GENMASK_ULL(63, 32)) | (nid & GENMASK(30, 0)) | + return ((nid << 1) & LAST_BITS_ULL(32)) | (nid & FIRST_BITS(31)) | ((nid >> EROFS_DIRENT_NID_METABOX_BIT) << 31); } =20 diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 775aa4f63aa3..ef08464e003f 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -416,7 +416,7 @@ int f2fs_target_device_index(struct f2fs_sb_info *sbi, = block_t blkaddr) =20 static blk_opf_t f2fs_io_flags(struct f2fs_io_info *fio) { - unsigned int temp_mask =3D GENMASK(NR_TEMP_TYPE - 1, 0); + unsigned int temp_mask =3D FIRST_BITS(NR_TEMP_TYPE); unsigned int fua_flag, meta_flag, io_flag; blk_opf_t op_flags =3D 0; =20 diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index 8c4eafe9ffac..42a43f558136 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -524,7 +524,7 @@ static int do_read_inode(struct inode *inode) fi->i_compress_level =3D compress_flag >> COMPRESS_LEVEL_OFFSET; fi->i_compress_flag =3D compress_flag & - GENMASK(COMPRESS_LEVEL_OFFSET - 1, 0); + FIRST_BITS(COMPRESS_LEVEL_OFFSET); fi->i_cluster_size =3D BIT(fi->i_log_cluster_size); set_inode_flag(inode, FI_COMPRESSED_FILE); } diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index b45eace879d7..64433d3b67d4 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -5425,7 +5425,7 @@ static int do_fix_curseg_write_pointer(struct f2fs_sb= _info *sbi, int type) wp_block =3D zbd->start_blk + (zone.wp >> log_sectors_per_block); wp_segno =3D GET_SEGNO(sbi, wp_block); wp_blkoff =3D wp_block - START_BLOCK(sbi, wp_segno); - wp_sector_off =3D zone.wp & GENMASK(log_sectors_per_block - 1, 0); + wp_sector_off =3D zone.wp & FIRST_BITS(log_sectors_per_block); =20 if (cs->segno =3D=3D wp_segno && cs->next_blkoff =3D=3D wp_blkoff && wp_sector_off =3D=3D 0) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index db7afb806411..96621fd45cdc 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -4501,7 +4501,7 @@ static void save_stop_reason(struct f2fs_sb_info *sbi= , unsigned char reason) unsigned long flags; =20 spin_lock_irqsave(&sbi->error_lock, flags); - if (sbi->stop_reason[reason] < GENMASK(BITS_PER_BYTE - 1, 0)) + if (sbi->stop_reason[reason] < FIRST_BITS(BITS_PER_BYTE)) sbi->stop_reason[reason]++; spin_unlock_irqrestore(&sbi->error_lock, flags); } diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index fc35a0543f01..71de487b244c 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -1845,7 +1845,7 @@ struct pagemapread { =20 #define PM_ENTRY_BYTES sizeof(pagemap_entry_t) #define PM_PFRAME_BITS 55 -#define PM_PFRAME_MASK GENMASK_ULL(PM_PFRAME_BITS - 1, 0) +#define PM_PFRAME_MASK FIRST_BITS_ULL(PM_PFRAME_BITS) #define PM_SOFT_DIRTY BIT_ULL(55) #define PM_MMAP_EXCLUSIVE BIT_ULL(56) #define PM_UFFD_WP BIT_ULL(57) diff --git a/fs/resctrl/pseudo_lock.c b/fs/resctrl/pseudo_lock.c index 87bbc2605de1..45703bbd3bca 100644 --- a/fs/resctrl/pseudo_lock.c +++ b/fs/resctrl/pseudo_lock.c @@ -30,7 +30,7 @@ */ static unsigned int pseudo_lock_major; =20 -static unsigned long pseudo_lock_minor_avail =3D GENMASK(MINORBITS, 0); +static unsigned long pseudo_lock_minor_avail =3D FIRST_BITS(MINORBITS + 1); =20 static char *pseudo_lock_devnode(const struct device *dev, umode_t *mode) { diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h index 6afb4a13b81d..9996356b79e0 100644 --- a/include/linux/f2fs_fs.h +++ b/include/linux/f2fs_fs.h @@ -356,7 +356,7 @@ enum { OFFSET_BIT_SHIFT }; =20 -#define OFFSET_BIT_MASK GENMASK(OFFSET_BIT_SHIFT - 1, 0) +#define OFFSET_BIT_MASK FIRST_BITS(OFFSET_BIT_SHIFT) =20 struct f2fs_node { /* can be one of three types: inode, direct, and indirect types */ --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34AE531961E for ; Sat, 25 Oct 2025 16:41:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410486; cv=none; b=ZL2NsTFVTWnj/i7Ow43tL/AjD736YzCwMI0+trFoxhorkcPq2lfG+x52XnQcoaVnd3upVOA/UpM5zXBV/Ue1P0c7DKlQYhGmyENPWa9mtPGJP1oCF4MtuOt2OmSOyns2j4cxs8mI+IxEpK/+v/hPRvGALjiwdsElnNxiYsiPQZY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410486; c=relaxed/simple; bh=7GwbfwFI4OnHwDpWdSIvynNWO47LZso8CXPD0pWl0FI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hIE04NXD5t2aKQ9bp8MG64vf/y2Iem5Am2tpWI4WRRPUcpnNNQV7mHR8lZjMSrxR/5y4pZBdC6GFevvKt8UAcJbZyt1LQmzI2C2haQISQ0rEoFQ62wbS5PdBHR6pnGgk+cEZpx3GmCW+peYSoIaMftdSAw9iNTObV4svP/wFuOY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nMoRVw/e; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nMoRVw/e" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4e88a1bbf5fso34505731cf.3 for ; Sat, 25 Oct 2025 09:41:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410484; x=1762015284; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Cxuvcw+5BokTf5KtZwOgkWEs4upe9ufMvZQ/niv/DKU=; b=nMoRVw/e47Ca2PFeJxQGcilQ0+7K/pEDLQw7tmgRePfrLJna7o3M4YgejGBdeZLUrE S3dkSVkPnYssItysHDNziPNz5ani9VPDt5wnM0lFVl/EEWlfABAT6vg9vyLR14/bM+se wYGzV9Z6exKNx9La/3E8WKdzQqG5wKpwkPooGNdiL5t6v2STACEUnGqZQvmdYtQ8Ld18 bI+uVQqfk3/vDnzetw35OgPfnGNCLkeWB0nQ8qa+Dztpb8zTK/sjoy2q+4+FwBihknoC SKciyHsJUBU4KqBDmxil+LjI+CO6tw2Wxbp2EDtyRXelqLB4/wGWfss7AZm+H3opj8jo +Iog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410484; x=1762015284; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cxuvcw+5BokTf5KtZwOgkWEs4upe9ufMvZQ/niv/DKU=; b=JiVdmhLLXX5fNRUHXbXVUzJa/EnhrLX4rSMyQpkRHo9ezhEbR9WdjILGmcC2ciR7DK amMYMxlkpkI/E6mYwZLvV8dnPw90ghHnn56NYq2ZGn3o4eCSXbW6c+MBU16iXFUDwegy 6Ed6+5vwwEg3hgLRxwr75ZNv4V4pd3vQq0EHq2r4KTkXK5pkhS4Wf66LOwY364HyJYwq PQTdFaZ76s+iJhNVIQ4SqULvvKOE1MeiCiiorfaeNHT+KelhSAvYxARRafmLn+z8giZ9 PdAtyWLeS3un58pvneh7J+kF8divQSzjrc5IRLGM3k+FN+wQ9zF4V+G+sGKEdserYhMO TIFg== X-Forwarded-Encrypted: i=1; AJvYcCUFTA5ofnQoq9QnF4LqA1UlGwFvD6ZhrzAMoojGuMHkc2FVX/6SXCX5YfRXABpPkWsRR4631d+pEpPT0DE=@vger.kernel.org X-Gm-Message-State: AOJu0Ywx75l1CZRIWKB6nNUHa3a+r1xfgQvJoiIOneyaBiltX3JNAvWr pJ2rvAiQEtRMlwj+1JaeOqO2IW5FYS8rz25gHhLSi1+FjDz1jEcoQL+C X-Gm-Gg: ASbGncuXA+b9bdS2Cte0FoDxsONi5zlDgw8ortEFJL2ge5fn1jI8CalOYbXKr33MIob COzWQrYNrM6v6aArEupylxSy7zOOBRKDec6iTMfWkZINpR4etR2Jac10/Y8afMPBqltkezCKbin eQ80RZjCcyaVECjnqh/iKo3bLmnfR7HTBIPmPSD8Knkj7A4/Y0ndgcN3+uQigdQddoFP2QPu2mW ZCVCtQcqVuJSNYnrg/oqYb8U1EWCX7K6WVadLUs6RewdRuW8m1uBqcEEje1qFeUHQN1PYUOOYIx lCWnBDb0rNKCLOtx+fxelDOxujC8/DMUYiXlgN7Y9F3txI0ybnAU/x5tKwzxKO7EF0k5qE2z1+N oSU5kpwDxiWML2WA/KvwkBPkynzbIGqsz2lbWgTw/zKWWz5DbDukdsh9Iou0CfR4ypdwdDqQZWi TPrC6oOO0= X-Google-Smtp-Source: AGHT+IH+bChMnhrke25hcunXp4ctYBzAwgqUPi/DPNGDmVtSwY5Yr5lQoJiKtZxVaRD5EDx9mjp5Qg== X-Received: by 2002:ac8:7dd2:0:b0:4e7:37fe:b619 with SMTP id d75a77b69052e-4e89d3a5549mr397523541cf.65.1761410484101; Sat, 25 Oct 2025 09:41:24 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f24dd30c3sm174457985a.21.2025.10.25.09.41.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:41:22 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Kees Cook , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" , Rasmus Villemoes Subject: [PATCH 20/21] fortify-string: don't use GENMASK() Date: Sat, 25 Oct 2025 12:40:19 -0400 Message-ID: <20251025164023.308884-21-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(high, low) notation is confusing. BITS(low, high) is more appropriate. Signed-off-by: Yury Norov (NVIDIA) --- include/linux/fortify-string.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/fortify-string.h b/include/linux/fortify-string.h index b3b53f8c1b28..0c95cdcca736 100644 --- a/include/linux/fortify-string.h +++ b/include/linux/fortify-string.h @@ -11,9 +11,9 @@ #define __RENAME(x) __asm__(#x) =20 #define FORTIFY_REASON_DIR(r) FIELD_GET(BIT(0), r) -#define FORTIFY_REASON_FUNC(r) FIELD_GET(GENMASK(7, 1), r) +#define FORTIFY_REASON_FUNC(r) FIELD_GET(BITS(1, 7), r) #define FORTIFY_REASON(func, write) (FIELD_PREP(BIT(0), write) | \ - FIELD_PREP(GENMASK(7, 1), func)) + FIELD_PREP(BITS(1, 7), func)) =20 /* Overridden by KUnit tests. */ #ifndef fortify_panic --=20 2.43.0 From nobody Sat Feb 7 09:30:19 2026 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8ED031A050 for ; Sat, 25 Oct 2025 16:41:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410489; cv=none; b=eQwU0+cgFxQnhAaPYDwuGCzl67latUtbwa1UCeJFHAac3Z3WGUfxmNjvd3ldJfJp/r3vA+YfRDps8w8V1I7MOdzo0Jl4wJ4VahMfHitR3Aa6N4lgtm5TfsZX6Awl1MhoqzlNa5xWtwYHf7AC0//PqbQMzpQ5d8p2bwl5iXegCZM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410489; c=relaxed/simple; bh=W0pTJAcfrpLd3MSeWjU9C4zToTzxqvWOKJPAJegCRgo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ae+Sz/K0cRpAFGt4amAYboiTq5QBJd3aUupDU4nflaOjoe7PbFKPUT4F7rOyL+vmkmNik/6/qjwdhfo83AiqokNbFqjVXsQtjH50fKDVeumAI/3PFJS6+yVNGjH9O/Q2tpcSnx2PO/hgver/wyY723K7QuNPqx7+JCzpS6PA1yA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HmdkCzlR; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HmdkCzlR" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-89048f76ec2so357616185a.1 for ; Sat, 25 Oct 2025 09:41:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410486; x=1762015286; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lCukDE2Wz/llmJRA1Dhhk+dKRYCeKOkr6t5vR7uoeBo=; b=HmdkCzlR2ZV181sY1F/mM051AIewCxk4RD++RSXV/4eyJ6IOO5xFkp5K47ZeLSxExR CVKkV49imAR9XLihFoy26xUnIm/67GwVVbS8GkCY4t2LuFdAI+n48O5Dn/jX3KrOaeJb VppNAKgxyJGqSMPRcUyIpouAMTXEuxbkOwTzqv3MySV8rXeDShyYkdl4fWUYxJWId6s3 4wrATqS3p6T3HaITk/P8lWs5zRlOKFnEWfKP+aE7oKmbm/kewrPkES4JDuZNXTqU0ePM wx5uIhsmoo1R3Wuid/0fLO5+82UkdRowsq+JEWeQoDYOs8BFfS3a79DI7SZGW6FU1Qio +b2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410486; x=1762015286; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lCukDE2Wz/llmJRA1Dhhk+dKRYCeKOkr6t5vR7uoeBo=; b=YUVn5Nk8UrzRC70EIkSYdBAXsIRtTKnAVPjZRjtvcDp3R9CZFABphOcGcYAqZd2Dhf FWWGFB0FwRpLukd8sq5zOLZ+mtoyoNfCbRYdDBSmVMImE8l0Lbu7Pl8sWc21p4fkYeF1 QseLTexLVOzILgQ+FtS9hDme8/8i/k6XqxLmzStaVy9aE5afLHrppYpl653vMHC/DOzQ sTRn9UcNSoDkE4KCEXUk3p4EawCKnTByZSX9XrQ2TS4eWDo2bdM0RI/R6QntpPje1sQx bgL1YWJHUSDhVZfBnC/7Eye0hpAsOOhZo/aWjmQBvSSigykPXE2jO+3TX3WQalhm0tWj bqRw== X-Forwarded-Encrypted: i=1; AJvYcCUjjeSBqnw/mp0q4yasqepC8B4Qd1Evlf9LGOyO/8hKwr9tG1qr3IlcZx7pqFNDt2Lz67zdAYl6ujBQ0IY=@vger.kernel.org X-Gm-Message-State: AOJu0YyxXGin7sSAmoYPOWMmuZd6gOjKh02hq6abBkvRpJo5FMdU0cJ8 vXXzH6TOGop/7S1tANlTEQuljNsPYNUk7Ac604LbEoWMuFbr87VC0+AqU3BKkA== X-Gm-Gg: ASbGncuRARTKOxBIGAvPz3k296uNSeXxsjIKp0zfZNMfqMGuXgHp46D98m9/2VeDkRX /lwcy7cTI5cBwcNxTT2IkOM7XDBSIPK69HKMfHVjZ4pg0MrxJLW19nTAsQXo7YcWhGET0JA34p7 RmNQ8RTlT998++s3br33XpgSdihC0wpjg1V8I/5GbeS0Z42HdV3BdS3d7zqUyxSiGBL0n4K6ZNu tHx8I4dZu6ayTmM2oeMTKr90ND6+e5qREMB3nVDAk74ZuHnE4mTQMqIFNj1bxFhO4wX4LUN8aJo UojxhWJ7TGuUg5Bpb9VI/T41jUUAKMvcENRt6TMkq+xzSCCNPkYRZdTyyt8z5tFd7iuuUl83sjY SEDcpry9UAO915eMfZ59n7FT9XK8f7dQN30C8AauE0W64T6+sJ8O+JbgLXTG/qejbZ8zM2BYS X-Google-Smtp-Source: AGHT+IEqr7DdALG20ZOSBwW3gigwHtT069Vv0Qyq2izolgtR2Xh/1150BfEGa5vrjghcvepsgiDnaQ== X-Received: by 2002:a05:620a:40c3:b0:85e:429b:b5c9 with SMTP id af79cd13be357-890712b9494mr3891854585a.83.1761410486528; Sat, 25 Oct 2025 09:41:26 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4eba37d72ecsm15371681cf.9.2025.10.25.09.41.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:41:25 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Jonathan Corbet , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" , Rasmus Villemoes Subject: [PATCH 21/21] Docs: add Functions parameters order section Date: Sat, 25 Oct 2025 12:40:20 -0400 Message-ID: <20251025164023.308884-22-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025164023.308884-1-yury.norov@gmail.com> References: <20251025164023.308884-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Standardize parameters ordering in some typical cases to minimize confusion. Signed-off-by: Yury Norov (NVIDIA) --- Documentation/process/coding-style.rst | 48 ++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/Documentation/process/coding-style.rst b/Documentation/process= /coding-style.rst index d1a8e5465ed9..dde24148305c 100644 --- a/Documentation/process/coding-style.rst +++ b/Documentation/process/coding-style.rst @@ -523,6 +523,54 @@ below, compared to the **declaration** example above):: ... } =20 +6.2) Function parameters order +------------------------------ + +The order of parameters is important both for code generation and readabil= ity. +Passing parameters in an unusual order is a common source of bugs. Listing +them in standard widely adopted order helps to avoid confusion. + +Many ABIs put first function parameter and return value in R0. If your +function returns one of its parameters, passing it at the very beginning +would lead to a better code generation. For example:: + + void *memset64(uint64_t *s, uint64_t v, size_t count); + void *memcpy(void *dest, const void *src, size_t count); + +If your function doesn't propagate a parameter, but has a meaning of copyi= ng +and/or processing data, the best practice is following the traditional ord= er: +destination, source, options, flags. + +for_each()-like iterators should take an enumerator the first. For example= :: + + for_each_set_bit(bit, mask, nbits); + do_something(bit); + + list_for_each_entry(pos, head, member); + do_something(pos); + +If function operates on a range or ranges of data, corresponding parameters +may be described as ``start - end`` or ``start - size`` pairs. In both cas= es, +the parameters should follow each other. For example:: + + int + check_range(unsigned long vstart, unsigned long vend, + unsigned long kstart, unsigned long kend); + + static inline void flush_icache_range(unsigned long start, unsigne= d long end); + + static inline void flush_icache_user_page(struct vm_area_struct *v= ma, + struct page *page, + unsigned long addr, int len); + +Both ``start`` and ``end`` of the interval are inclusive. + +Describing intervals in order ``end - start`` is unfavorable. One notable +example is the ``GENMASK(high, low)`` macro. While such a notation is popu= lar +in hardware context, particularly to describe registers structure, in cont= ext +of software development it looks counter intuitive and confusing. Please s= witch +to an equivalent ``BITS(low, high)`` version. + 7) Centralized exiting of functions ----------------------------------- =20 --=20 2.43.0