From nobody Mon Feb 9 10:12:38 2026 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28CFD30AAD2 for ; Sat, 25 Oct 2025 16:33:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410004; cv=none; b=YL/2jIvTyWuKfITZ8354xOW1txjG/ZVanPmrHHnpBYBhSnUuTcH1UxSZUIAbte9oYdmu9BI/2p6SWqnvztaI9Ioi68mL/UT6yMFak8un3k4OzVFPsI0NpE3ZWwRO6RBkhaTA+03/Gm/C/PLu2R0MzcHf9o7w5nyXEJqqlDbhXV0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410004; c=relaxed/simple; bh=XhV4d6vVAyK94tJmHv/pzX7uso4PaLhZOAOHlwMKMkY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t7xJRRCAFz812ogmrxdAPr8Oyei2fQTkapsf8KYHyZrbZgjv37BOkAd9c5jDD1/8OmTSJYxj+u9gMK4UdbM7qf230lgD4wltkCex52cIcQGo5prBKfew+EYHGKYpSts59yxY7G4EzhZxn9FEDoKMkC22PxxoUCyMtQADVMQMyU0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=THIp+Tct; arc=none smtp.client-ip=209.85.160.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="THIp+Tct" Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-4e891a8980bso31441221cf.1 for ; Sat, 25 Oct 2025 09:33:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410002; x=1762014802; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ehiUcUt6iLCen11Ncs28J2yHpJNhGkVkWPyWS3jNXxY=; b=THIp+TctYck+HX5Byp5ZPzTzj5Sg8X2gcojiJOtbOEIYmT24sPfsm3qZ1pSbF/4fXl 8sqLi+qUSzaUgf69MUNmLz+mZpp6f253cH2n+x/QF4j2vvyUJ3cY1FBNs8HqeH/ECDUx OAV1gxrjRZM9pPU0StleSU/uTsDhAGvHjdYoQHcCjIRJd01DtdKqWXhvYjvlYHPeGlwg ObV49OEQh/CLsodFyrJYcYb/U3ckEC/YcEYnnIhIYjEA8Z/xdStHSx/QxRZQdHG/502I cQ4/svw9Mto42wUDFJvktG1T7q4aWSYJ5mRTPkf0ragBR9KuwfIkQdaVGDrlN0BZX49r k7Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410002; x=1762014802; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ehiUcUt6iLCen11Ncs28J2yHpJNhGkVkWPyWS3jNXxY=; b=QICAewdiOK+hNDp+4Zw5/tytjf5q3PJEtBZLRzAl9887k7i3shDY+QVP6wl9vMEoGb EntVrGbfpffT3Qv78IX/UHyI3sWdCyHuBhumB4Txso5gP2UDgc+Qj2XYyWjzQYUeSxJ/ UERObiDOP/mgRUnql+pGVqTlR7pwzGwWSGtRMv/eckiqG9hT5WecQPQ+iL/4+UBc1ahq ZFnc9/y6JY8ZWcOwJOZDj8kU1CIFdHgZVq6pEM9xu718fRqByP81GdVzMf02sxUtewa1 cx/DnG5WdJVv3dNJxlGfh29zTGDbQXZQiXksZEMc/Q+ysHXjaz1FXVvhKomcCAOlfk44 dLGw== X-Forwarded-Encrypted: i=1; AJvYcCUibvk4QxZYX9iziKY1pKxMnVm8d9ScW9RTBXIoC/GYpCU2rxFFNmqt8OfWIVraz4Jb6Zz1rFFflaDaurs=@vger.kernel.org X-Gm-Message-State: AOJu0YxOfXr+IWpvWmi9JnT2Bn7rCKCoWjsGuaPeUxMDa5dZuDV1SUdP h4v0epf9SpAuGAN+6CrZiXaQf7k3b/npMHaswXKOGGjNPvKuuyfYQ0MW X-Gm-Gg: ASbGncsyI1PVFnuS54D1AsIWuNEVnAVPVbni4j0I3AiqDrGyMBmfk4JtHY1tjZaXwqj JvSytW4udvcvkbjh9UzVF8PX5vz9+ceviB4dNVrzU6TNdWh1iKZQSXUF2j5iF69HP+fnykLnwS7 LjeZkk4fqNoAJ6uGIsmI1IGNADEJc08W+6r474/bprtVfJV/BCi0cihdtAIRmFG0Q6S2qwoBOF+ hv1M7JrMPB7eyqL9Jkh3b+5kjoT84u7TwQt4XJBJGTLYY7HgZI/BwCUJAicvI46icZYnrxFuzb9 5r9VjoE25+hMAll6wsfybXYDnXYIPQjnT7eCUF4uPcfHUYTpwcp2u73bVGNrGIZUzNToJGB16KP sLsDdv3bTGp9jjA/IWp6b4g7kp9FoXGylFdGJa3S4qCw7yTWjKkNwRFOtucC7pMirAShntDngQY pbucTIdYM= X-Google-Smtp-Source: AGHT+IHHeWoXJKdNINlOiRKJ3a2nDIiOuVj8p9HhufLAzf+qZUQhC2Mssatfy2OZ9T8hXqauxRLp9w== X-Received: by 2002:ac8:58c9:0:b0:4ec:ee54:b141 with SMTP id d75a77b69052e-4ecee54b1f4mr8454481cf.26.1761410002057; Sat, 25 Oct 2025 09:33:22 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f262716efsm171531585a.59.2025.10.25.09.33.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:33:21 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Walleij , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" Subject: [PATCH 13/21] trace: don't use GENMASK() Date: Sat, 25 Oct 2025 12:32:55 -0400 Message-ID: <20251025163305.306787-6-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(high, low) notation is confusing. FIRST_BITS() is more appropriate. Signed-off-by: Yury Norov (NVIDIA) --- kernel/trace/fgraph.c | 10 +++++----- kernel/trace/trace_probe.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/trace/fgraph.c b/kernel/trace/fgraph.c index 484ad7a18463..4f21bd837055 100644 --- a/kernel/trace/fgraph.c +++ b/kernel/trace/fgraph.c @@ -106,10 +106,10 @@ * (RESERVED or BITMAP) */ #define FGRAPH_FRAME_OFFSET_BITS 10 -#define FGRAPH_FRAME_OFFSET_MASK GENMASK(FGRAPH_FRAME_OFFSET_BITS - 1, 0) +#define FGRAPH_FRAME_OFFSET_MASK FIRST_BITS(FGRAPH_FRAME_OFFSET_BITS) =20 #define FGRAPH_TYPE_BITS 2 -#define FGRAPH_TYPE_MASK GENMASK(FGRAPH_TYPE_BITS - 1, 0) +#define FGRAPH_TYPE_MASK FIRST_BITS(FGRAPH_TYPE_BITS) #define FGRAPH_TYPE_SHIFT FGRAPH_FRAME_OFFSET_BITS =20 enum { @@ -123,7 +123,7 @@ enum { * FGRAPH_INDEX (12-27) bits holding the gops index wanting return callb= ack called */ #define FGRAPH_INDEX_BITS 16 -#define FGRAPH_INDEX_MASK GENMASK(FGRAPH_INDEX_BITS - 1, 0) +#define FGRAPH_INDEX_MASK FIRST_BITS(FGRAPH_INDEX_BITS) #define FGRAPH_INDEX_SHIFT (FGRAPH_TYPE_SHIFT + FGRAPH_TYPE_BITS) =20 /* @@ -135,12 +135,12 @@ enum { * data_size =3D=3D 0 means 1 word, and 31 (=3D2^5 - 1) means 32 words. */ #define FGRAPH_DATA_BITS 5 -#define FGRAPH_DATA_MASK GENMASK(FGRAPH_DATA_BITS - 1, 0) +#define FGRAPH_DATA_MASK FIRST_BITS(FGRAPH_DATA_BITS) #define FGRAPH_DATA_SHIFT (FGRAPH_TYPE_SHIFT + FGRAPH_TYPE_BITS) #define FGRAPH_MAX_DATA_SIZE (sizeof(long) * (1 << FGRAPH_DATA_BITS)) =20 #define FGRAPH_DATA_INDEX_BITS 4 -#define FGRAPH_DATA_INDEX_MASK GENMASK(FGRAPH_DATA_INDEX_BITS - 1, 0) +#define FGRAPH_DATA_INDEX_MASK FIRST_BITS(FGRAPH_DATA_INDEX_BITS) #define FGRAPH_DATA_INDEX_SHIFT (FGRAPH_DATA_SHIFT + FGRAPH_DATA_BITS) =20 #define FGRAPH_MAX_INDEX \ diff --git a/kernel/trace/trace_probe.h b/kernel/trace/trace_probe.h index 08b5bda24da2..88de129dcde0 100644 --- a/kernel/trace/trace_probe.h +++ b/kernel/trace/trace_probe.h @@ -401,7 +401,7 @@ static inline int traceprobe_get_entry_data_size(struct= trace_probe *tp) #define TPARG_FL_USER BIT(4) #define TPARG_FL_FPROBE BIT(5) #define TPARG_FL_TPOINT BIT(6) -#define TPARG_FL_LOC_MASK GENMASK(4, 0) +#define TPARG_FL_LOC_MASK FIRST_BITS(5) =20 static inline bool tparg_is_function_entry(unsigned int flags) { --=20 2.43.0