From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC1FA3126C5 for ; Sat, 25 Oct 2025 16:29:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409746; cv=none; b=WUsRFLKHvsGUt6QtaONfZyuitfr64n3e/KPQ/Z6evNJv0i3YhyFkhPqBe63P8X9tmau5GePSJrV5htaWlWs7oAItpOY+frGgYUDJKzZQ7DnTlxcsDmtZ4Fl9tv9rNwNB6hAVOQIfh9N0bNDH2BK9C3efy+2g4tgxq31379u9Btc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409746; c=relaxed/simple; bh=GD9r0peLG2k6Dz8bSnVBhsVzehUcmhQIE13Y757qu+E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d3lGlmXM/IYfFgtrg5p43FVYuImMzCDKliqIvxXLrV0y3ZrpVjKMRlAXpkQxAVhf2SevYh8swjdYyiEqjhxd5QFcgZd+UkjuMd2QwZoiw45gZp3KSGt9JW4HKouVEyMADxb/J6/7WnQT2eZBXQNieROr4AuwbCMcULqNYV19q5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PsGl6vNV; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PsGl6vNV" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-89ead335934so135953485a.2 for ; Sat, 25 Oct 2025 09:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761409743; x=1762014543; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ww+ea11r2mZcngIR6hS8TfeQOLbyKE40FtRbqCbDFPg=; b=PsGl6vNV9PYk2X5uqMq0IiLez13P/2344KqCF95BJWd5Y/Exxa8KMXUKUnayJofwqS p+rpIoxesTyUqvoWO7cj0mJ7UPpRyyr2HfWYE+yOMbhqx/f/DaKO49xqSk1wt2xpDuEo YPUQkbQaYik+K8E55ThLxNNjm7oUyOQWI+6B/kwvGzswWSDpOrXob0kZHW2C4oCi3MoB L/V/YfQNqEQLj1exBnO5cPuN5I9kC4zvvR5c9ZKJtWk8qAvPtBJk16hhMxw5BknEjZsC HxbUaAzja2XH0DtnqNSyuMfeSwY/4WOobME5q+0+RgQJWzo1EmqG++iaWArZSABgbxys 1YhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761409743; x=1762014543; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ww+ea11r2mZcngIR6hS8TfeQOLbyKE40FtRbqCbDFPg=; b=tNt3HVEzalGPYVuCOeaJAakERlAu0f/K521VxCPAyx+4q2krxNk7arjj7KUxGKtAGn b+4EL74UqOiLkoKJso3bV/8F41cUQJNYJAGXs5ERmZlDA1wEF9wVJKhPRwdjkmftpSEu dHJNzJsIuPxAMl71p/aiyzShfkjw1fj/yzgcRlOS1uCYY0PCWEqgvWqur+VxI4jO9Ybn syGQhlF+e46OJsRiTAylKWXHrSYnMBmIFmUelZdRJN3GBlGyq3SsKevni8VbhLv9pOx+ Qn+DhXm+y80BCP2Gs+v/tCWQyjThYw2iuQ1nzNkwBOca+UthAaj89JhWLOBM1X7sIXiX 5cNg== X-Forwarded-Encrypted: i=1; AJvYcCXoQAouSRaOtfzfxPBB07DxhKfDhogScpKVb1+RAQsS1CuOvAbsrpcAzi7VCKBPP/podGE9TwCUCPFcBVk=@vger.kernel.org X-Gm-Message-State: AOJu0YzkShUONMTTlA6QOczvOMcP/c9yKMoYGpyTwnw3WX9CAaj0qkDy UwMfJ4TS98Hg9koVvUDiibyqPFEnqqGfmHk/SJSRqb152Qs0/dunw0g0 X-Gm-Gg: ASbGncttN5cpaV1uFxxJ/JpqIDCdUpmOamiXrW9lAxE5wA3+sNv6d23GSoEYR2iGny2 hePDk3+7QS0ntMtmFocWAAQ6rbXcBqDyV7OL7PD2w2kjueeGjAqZwo1ZH6VuFiFuC9ofBX9t08k Yr0wg6y+bmIit7/CjFadFc1Fg1vH2DQonlDf75NlYvFWvPSp7EbTMh1/Vb9ws5XS18MFz0r9l3j Ax7JZUHYyTb6sN0a+I5QSl8snDJ14Kdc+sOAsqrKjM1FFvtG8ZOpFE1mTRW3YOcEYlnv22jv6DQ T9sXJXAGu75YMTyfnt+qsSVH/fNyds+ve2fr9gdMRQJdnKeKXUHeGG2w7L1YstkRu8y4zBn6aVr bIxBfmXSdKIWIG3doeelK4gLCkfvdwAqhDr4WEbPWG5afLJEvb2/IhuoPgk8S/+MfS/vm2rf+ X-Google-Smtp-Source: AGHT+IHMZ4dTmg9rBoFgf4k6Xv8Sl8LTQqiUABCpUVik33hBUWlLJwkT2aFro3ElO6setbLK2gCNyQ== X-Received: by 2002:a05:620a:7108:b0:89f:3bd5:cadb with SMTP id af79cd13be357-89f3bd5d9c8mr332094585a.49.1761409743386; Sat, 25 Oct 2025 09:29:03 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f254abccbsm171351185a.31.2025.10.25.09.29.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:29:02 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Vineet Gupta , "Yury Norov (NVIDIA)" , linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Rasmus Villemoes Subject: [PATCH 01/21] arc: disasm: rename BITS() for FIELD() Date: Sat, 25 Oct 2025 12:28:37 -0400 Message-ID: <20251025162858.305236-2-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In preparation for adding generic BITS() macro, rename the local one. Signed-off-by: Yury Norov (NVIDIA) --- arch/arc/include/asm/disasm.h | 62 +++++++++++++++++------------------ arch/arc/kernel/disasm.c | 46 +++++++++++++------------- 2 files changed, 54 insertions(+), 54 deletions(-) diff --git a/arch/arc/include/asm/disasm.h b/arch/arc/include/asm/disasm.h index 61fb4d7affa7..33a0e88e1e8c 100644 --- a/arch/arc/include/asm/disasm.h +++ b/arch/arc/include/asm/disasm.h @@ -29,44 +29,44 @@ enum flow { }; =20 #define IS_BIT(word, n) ((word) & (1<> (s)) & (~((-2) << ((e) - (s))))) +#define FIELD(word, s, e) (((word) >> (s)) & (~((-2) << ((e) - (s))))) =20 -#define MAJOR_OPCODE(word) (BITS((word), 27, 31)) -#define MINOR_OPCODE(word) (BITS((word), 16, 21)) -#define FIELD_A(word) (BITS((word), 0, 5)) -#define FIELD_B(word) ((BITS((word), 12, 14)<<3) | \ - (BITS((word), 24, 26))) -#define FIELD_C(word) (BITS((word), 6, 11)) +#define MAJOR_OPCODE(word) (FIELD((word), 27, 31)) +#define MINOR_OPCODE(word) (FIELD((word), 16, 21)) +#define FIELD_A(word) (FIELD((word), 0, 5)) +#define FIELD_B(word) ((FIELD((word), 12, 14)<<3) | \ + (FIELD((word), 24, 26))) +#define FIELD_C(word) (FIELD((word), 6, 11)) #define FIELD_u6(word) FIELDC(word) -#define FIELD_s12(word) sign_extend(((BITS((word), 0, 5) << 6) | \ - BITS((word), 6, 11)), 12) +#define FIELD_s12(word) sign_extend(((FIELD((word), 0, 5) << 6) | \ + FIELD((word), 6, 11)), 12) =20 /* note that for BL/BRcc these two macro's need another AND statement to m= ask * out bit 1 (make the result a multiple of 4) */ -#define FIELD_s9(word) sign_extend(((BITS(word, 15, 15) << 8) | \ - BITS(word, 16, 23)), 9) -#define FIELD_s21(word) sign_extend(((BITS(word, 6, 15) << 11) | \ - (BITS(word, 17, 26) << 1)), 12) -#define FIELD_s25(word) sign_extend(((BITS(word, 0, 3) << 21) | \ - (BITS(word, 6, 15) << 11) | \ - (BITS(word, 17, 26) << 1)), 12) +#define FIELD_s9(word) sign_extend(((FIELD(word, 15, 15) << 8) | \ + FIELD(word, 16, 23)), 9) +#define FIELD_s21(word) sign_extend(((FIELD(word, 6, 15) << 11) | \ + (FIELD(word, 17, 26) << 1)), 12) +#define FIELD_s25(word) sign_extend(((FIELD(word, 0, 3) << 21) | \ + (FIELD(word, 6, 15) << 11) | \ + (FIELD(word, 17, 26) << 1)), 12) =20 /* note: these operate on 16 bits! */ -#define FIELD_S_A(word) ((BITS((word), 2, 2)<<3) | BITS((word), 0, 2)) -#define FIELD_S_B(word) ((BITS((word), 10, 10)<<3) | \ - BITS((word), 8, 10)) -#define FIELD_S_C(word) ((BITS((word), 7, 7)<<3) | BITS((word), 5, 7)) -#define FIELD_S_H(word) ((BITS((word), 0, 2)<<3) | BITS((word), 5, 8)) -#define FIELD_S_u5(word) (BITS((word), 0, 4)) -#define FIELD_S_u6(word) (BITS((word), 0, 4) << 1) -#define FIELD_S_u7(word) (BITS((word), 0, 4) << 2) -#define FIELD_S_u10(word) (BITS((word), 0, 7) << 2) -#define FIELD_S_s7(word) sign_extend(BITS((word), 0, 5) << 1, 9) -#define FIELD_S_s8(word) sign_extend(BITS((word), 0, 7) << 1, 9) -#define FIELD_S_s9(word) sign_extend(BITS((word), 0, 8), 9) -#define FIELD_S_s10(word) sign_extend(BITS((word), 0, 8) << 1, 10) -#define FIELD_S_s11(word) sign_extend(BITS((word), 0, 8) << 2, 11) -#define FIELD_S_s13(word) sign_extend(BITS((word), 0, 10) << 2, 13) +#define FIELD_S_A(word) ((FIELD((word), 2, 2)<<3) | FIELD((word), 0, 2)) +#define FIELD_S_B(word) ((FIELD((word), 10, 10)<<3) | \ + FIELD((word), 8, 10)) +#define FIELD_S_C(word) ((FIELD((word), 7, 7)<<3) | FIELD((word), 5, 7)) +#define FIELD_S_H(word) ((FIELD((word), 0, 2)<<3) | FIELD((word), 5, 8)) +#define FIELD_S_u5(word) (FIELD((word), 0, 4)) +#define FIELD_S_u6(word) (FIELD((word), 0, 4) << 1) +#define FIELD_S_u7(word) (FIELD((word), 0, 4) << 2) +#define FIELD_S_u10(word) (FIELD((word), 0, 7) << 2) +#define FIELD_S_s7(word) sign_extend(FIELD((word), 0, 5) << 1, 9) +#define FIELD_S_s8(word) sign_extend(FIELD((word), 0, 7) << 1, 9) +#define FIELD_S_s9(word) sign_extend(FIELD((word), 0, 8), 9) +#define FIELD_S_s10(word) sign_extend(FIELD((word), 0, 8) << 1, 10) +#define FIELD_S_s11(word) sign_extend(FIELD((word), 0, 8) << 2, 11) +#define FIELD_S_s13(word) sign_extend(FIELD((word), 0, 10) << 2, 13) =20 #define STATUS32_L 0x00000100 #define REG_LIMM 62 diff --git a/arch/arc/kernel/disasm.c b/arch/arc/kernel/disasm.c index ccc7e8c39eb3..926b67c40346 100644 --- a/arch/arc/kernel/disasm.c +++ b/arch/arc/kernel/disasm.c @@ -100,12 +100,12 @@ void __kprobes disasm_instr(unsigned long addr, struc= t disasm_state *state, =20 case op_LD: /* LD a,[b,s9] */ state->write =3D 0; - state->di =3D BITS(state->words[0], 11, 11); + state->di =3D FIELD(state->words[0], 11, 11); if (state->di) break; - state->x =3D BITS(state->words[0], 6, 6); - state->zz =3D BITS(state->words[0], 7, 8); - state->aa =3D BITS(state->words[0], 9, 10); + state->x =3D FIELD(state->words[0], 6, 6); + state->zz =3D FIELD(state->words[0], 7, 8); + state->aa =3D FIELD(state->words[0], 9, 10); state->wb_reg =3D FIELD_B(state->words[0]); if (state->wb_reg =3D=3D REG_LIMM) { state->instr_len +=3D 4; @@ -121,11 +121,11 @@ void __kprobes disasm_instr(unsigned long addr, struc= t disasm_state *state, =20 case op_ST: state->write =3D 1; - state->di =3D BITS(state->words[0], 5, 5); + state->di =3D FIELD(state->words[0], 5, 5); if (state->di) break; - state->aa =3D BITS(state->words[0], 3, 4); - state->zz =3D BITS(state->words[0], 1, 2); + state->aa =3D FIELD(state->words[0], 3, 4); + state->zz =3D FIELD(state->words[0], 1, 2); state->src1 =3D FIELD_C(state->words[0]); if (state->src1 =3D=3D REG_LIMM) { state->instr_len +=3D 4; @@ -160,7 +160,7 @@ void __kprobes disasm_instr(unsigned long addr, struct = disasm_state *state, is_linked =3D 1; =20 fieldCisReg =3D 0; - op_format =3D BITS(state->words[0], 22, 23); + op_format =3D FIELD(state->words[0], 22, 23); if (op_format =3D=3D 0 || ((op_format =3D=3D 3) && (!IS_BIT(state->words[0], 5)))) { fieldC =3D FIELD_C(state->words[0]); @@ -192,7 +192,7 @@ void __kprobes disasm_instr(unsigned long addr, struct = disasm_state *state, break; =20 case 40: /* LPcc */ - if (BITS(state->words[0], 22, 23) =3D=3D 3) { + if (FIELD(state->words[0], 22, 23) =3D=3D 3) { /* Conditional LPcc u7 */ fieldC =3D FIELD_C(state->words[0]); =20 @@ -207,12 +207,12 @@ void __kprobes disasm_instr(unsigned long addr, struc= t disasm_state *state, break; =20 case 48 ... 55: /* LD a,[b,c] */ - state->di =3D BITS(state->words[0], 15, 15); + state->di =3D FIELD(state->words[0], 15, 15); if (state->di) break; - state->x =3D BITS(state->words[0], 16, 16); - state->zz =3D BITS(state->words[0], 17, 18); - state->aa =3D BITS(state->words[0], 22, 23); + state->x =3D FIELD(state->words[0], 16, 16); + state->zz =3D FIELD(state->words[0], 17, 18); + state->aa =3D FIELD(state->words[0], 22, 23); state->wb_reg =3D FIELD_B(state->words[0]); if (state->wb_reg =3D=3D REG_LIMM) { state->instr_len +=3D 4; @@ -237,7 +237,7 @@ void __kprobes disasm_instr(unsigned long addr, struct = disasm_state *state, case 10: /* MOV */ /* still need to check for limm to extract instr len */ /* MOV is special case because it only takes 2 args */ - switch (BITS(state->words[0], 22, 23)) { + switch (FIELD(state->words[0], 22, 23)) { case 0: /* OP a,b,c */ if (FIELD_C(state->words[0]) =3D=3D REG_LIMM) state->instr_len +=3D 4; @@ -258,7 +258,7 @@ void __kprobes disasm_instr(unsigned long addr, struct = disasm_state *state, default: /* Not a Load, Jump or Loop instruction */ /* still need to check for limm to extract instr len */ - switch (BITS(state->words[0], 22, 23)) { + switch (FIELD(state->words[0], 22, 23)) { case 0: /* OP a,b,c */ if ((FIELD_B(state->words[0]) =3D=3D REG_LIMM) || (FIELD_C(state->words[0]) =3D=3D REG_LIMM)) @@ -281,7 +281,7 @@ void __kprobes disasm_instr(unsigned long addr, struct = disasm_state *state, =20 /* 16 Bit Instructions */ case op_LD_ADD: /* LD_S|LDB_S|LDW_S a,[b,c] */ - state->zz =3D BITS(state->words[0], 3, 4); + state->zz =3D FIELD(state->words[0], 3, 4); state->src1 =3D get_reg(FIELD_S_B(state->words[0]), regs, cregs); state->src2 =3D get_reg(FIELD_S_C(state->words[0]), regs, cregs); state->dest =3D FIELD_S_A(state->words[0]); @@ -289,13 +289,13 @@ void __kprobes disasm_instr(unsigned long addr, struc= t disasm_state *state, =20 case op_ADD_MOV_CMP: /* check for limm, ignore mov_s h,b (=3D=3D mov_s 0,b) */ - if ((BITS(state->words[0], 3, 4) < 3) && + if ((FIELD(state->words[0], 3, 4) < 3) && (FIELD_S_H(state->words[0]) =3D=3D REG_LIMM)) state->instr_len +=3D 4; break; =20 case op_S: - subopcode =3D BITS(state->words[0], 5, 7); + subopcode =3D FIELD(state->words[0], 5, 7); switch (subopcode) { case 0: /* j_s */ case 1: /* j_s.d */ @@ -308,7 +308,7 @@ void __kprobes disasm_instr(unsigned long addr, struct = disasm_state *state, direct_call : indirect_jump; break; case 7: - switch (BITS(state->words[0], 8, 10)) { + switch (FIELD(state->words[0], 8, 10)) { case 4: /* jeq_s [blink] */ case 5: /* jne_s [blink] */ case 6: /* j_s [blink] */ @@ -367,8 +367,8 @@ void __kprobes disasm_instr(unsigned long addr, struct = disasm_state *state, /* note: we are ignoring possibility of: * ADD_S, SUB_S, PUSH_S, POP_S as these should not * cause unaligned exception anyway */ - state->write =3D BITS(state->words[0], 6, 6); - state->zz =3D BITS(state->words[0], 5, 5); + state->write =3D FIELD(state->words[0], 6, 6); + state->zz =3D FIELD(state->words[0], 5, 5); if (state->zz) break; /* byte accesses should not come here */ if (!state->write) { @@ -385,7 +385,7 @@ void __kprobes disasm_instr(unsigned long addr, struct = disasm_state *state, =20 case op_GP: /* LD_S|LDB_S|LDW_S r0,[gp,s11/s9/s10] */ /* note: ADD_S r0, gp, s11 is ignored */ - state->zz =3D BITS(state->words[0], 9, 10); + state->zz =3D FIELD(state->words[0], 9, 10); state->src1 =3D get_reg(26, regs, cregs); state->src2 =3D state->zz ? FIELD_S_s10(state->words[0]) : FIELD_S_s11(state->words[0]); @@ -405,7 +405,7 @@ void __kprobes disasm_instr(unsigned long addr, struct = disasm_state *state, break; =20 case op_B_S: - fieldA =3D (BITS(state->words[0], 9, 10) =3D=3D 3) ? + fieldA =3D (FIELD(state->words[0], 9, 10) =3D=3D 3) ? FIELD_S_s7(state->words[0]) : FIELD_S_s10(state->words[0]); state->target =3D fieldA + (addr & ~0x03); --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7019132142E for ; Sat, 25 Oct 2025 16:29:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409748; cv=none; b=p9QtL+wVeg7IJVNzJeCh0+dnbex7TBwsu5Q83QUMwK3OUF1pZ0lWYsvuWruFhpbbGgJ9PrMBZ/wF8NoB5loCyAHiIKQxu1rQq2kYCEQVbTowUzAgxHn+imxxbjpZQZIMrou7IuCa2x7GIH3YNomlBu3ppmjCp0hkJRNquqvmWEk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409748; c=relaxed/simple; bh=142ZarbauOc/OnyndUEIR7x0gLhU0Vf39KWkHIFGmYg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZqwQEW8xw+hyNtzZezZ4NniCcT62Wpd0q8uyN5FqyVKvWBTLLLpr2MPRBaZO1fomI2MFU5rxdJibPkPlEr8RZIdGS2knh3OzceGCYwZuKFpJiWp8VBgo4dD0mTwsQogK6YdR48WdvpDSXJd2q7v+dUMjwXIiSshB+RES/JyB/3c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dAyPZs15; arc=none smtp.client-ip=209.85.219.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dAyPZs15" Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-87c148fb575so33671246d6.2 for ; Sat, 25 Oct 2025 09:29:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761409745; x=1762014545; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EVD9Zxv6Y0ifC9xZiOG7Ki+TEfCe0ib+yy9r9fDGLQc=; b=dAyPZs15q4VutsdWz/C6jbNfCmaVmvughf723RdKM16dn8vRKk0Sy6i9IMDOOu9n2M ulbbC4hCEQTFI6lVAejlPE6+mGwHCQSCHtoktKxGyoSNjMS8mJ7JFe7fZJZ5350ZDbN6 OymL0S4qkidMTtmoojhI07mDa2Hn07aDHxYcT2aVWuQV4Q31wuq/a0QOgLVD0skGIXeV o2AsjLycCKcNO+WSIqDEtxC864eY8TVzRiRXZ1qIy8MhhD/VE6Z2l+ahRRugIk3Bj52e 2E9TsZnxRHV+rIF7f9vrz54cS2oF/mvG+wEW7dLjpxQvWBnyIBZtNHrBWjydX7uUUN1G gUQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761409745; x=1762014545; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EVD9Zxv6Y0ifC9xZiOG7Ki+TEfCe0ib+yy9r9fDGLQc=; b=m7/RxXpKyvUn1udfYI37bueshIcLhDaGoERXjydpRDhLYmjXBJu7cKfrGCbzJeEvdS kbEjXzT74HQpOdHsBrQmcPl/M0P+qhu1M38AEiAP0W9uJWwMnrvcORDeDa2cudQc8AVE WdD72qGo6unMuzlHro8j+rTxNHC3MksJEdQjAktqaU8OJeflnq+R5Xu2RCqvufBhIHsx YK7VHQddol3lBing7ccWvKMHlDGt0YVT6KZMKUJvdhRNm+CJ1mmMu3a3KEMNwltkklsX ohY60iFEfWIU4EEpJM1taOwybdyi3DEz/8DemUJj2sRy18lpLuemRuNsTMFx2Yu5guZS OEbA== X-Forwarded-Encrypted: i=1; AJvYcCUCT5KHGpVcSNHfWkj+6Cquqv/fVromRDwcncX9vEySvRA0ZWmZJ9lyaBbtjecddZZvZ/SNjllRe/OmQlI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+9vIeq320QSNWt0ypJHj4VddZ+NK4NWQvEp7NxFWQDRvVZ7yK JHVPwH3TXoqoT6ogXsuAOb/aPJxgXW7cyiSopNOmxXvMZ3ZwcLT0znHy X-Gm-Gg: ASbGnctTEgF334EKnCspMuRI4YT+Q+MGiq6hDVY2+C2ij9Ud72x7cTRFrwhSyPvbJcB Jj3G8KRFlunPWWgxD2hLLrEXtXbE2jlYArVl5kiV2S18pYW7ZZFM8tpwT8g2TtWkkgRjmZBoWuc dLyucXU753G1XUco6w9WCUgqWbDRWBpfC5o/6TowvQO1W1C1WOlMlY4ZR8mZWTqoD/nCGi/ZeTA 3lmBkfFut005aDARmITLoU4HAQzQ3mRnuwbqHz0P37edt7AlLx8v/KNMw+5U+TBOwZkn/VAYsvD y5BADQbDzbqXMKwGcwbGjo5krHGv439FYt81WwuqEbydNx6fx9TzJ6YsJCtRpFhI5ZirYT+zamo Cnq/x2W87gBbZQW903DPmlUqYEPqxuouXKr5qz4XZLQLYkBgIWojKfUVNhmDj/c4n/uGRMf0uqM KI8/QYpRQ= X-Google-Smtp-Source: AGHT+IGDln+XKp5LwgnfkE2q9ztXbMdtXgqcPHZRtmmRDeFAZFQKeTU/cmkG7iWpntvS8l1BZEDptQ== X-Received: by 2002:a05:6214:2a8d:b0:7f7:777e:39c5 with SMTP id 6a1803df08f44-87c2056890amr536634466d6.25.1761409745396; Sat, 25 Oct 2025 09:29:05 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc4944a84sm16223506d6.36.2025.10.25.09.29.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:29:04 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Miri Korenblit , "Yury Norov (NVIDIA)" , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rasmus Villemoes Subject: [PATCH 02/21] iwlwifi: drop unused BITS() Date: Sat, 25 Oct 2025 12:28:38 -0400 Message-ID: <20251025162858.305236-3-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" BITS() is unused in iwlwifi. Drop it. Signed-off-by: Yury Norov (NVIDIA) --- drivers/net/wireless/intel/iwlwifi/fw/api/coex.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/api/coex.h b/drivers/net= /wireless/intel/iwlwifi/fw/api/coex.h index ddc84430d895..b0d68b4c504b 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/api/coex.h +++ b/drivers/net/wireless/intel/iwlwifi/fw/api/coex.h @@ -11,8 +11,6 @@ #include #include =20 -#define BITS(nb) (BIT(nb) - 1) - enum iwl_bt_coex_lut_type { BT_COEX_TIGHT_LUT =3D 0, BT_COEX_LOOSE_LUT, --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F7E6322C65 for ; Sat, 25 Oct 2025 16:29:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409751; cv=none; b=ijtr79wad9w6eTA1uiIkz+sZCOQn/KJEE/NqxsHrGrL55w41DG9CIbRVSE/CoGdgO+RNWb7LC5YFpa5Chy4o9oSUjxwHunBztlDiEwU/FAfupMWzdyfqFsuYQMCnVCdXhCb2ccxjsVsRYVX4U+B+kD9sZpdxIJaHmVmdCCv8bs0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409751; c=relaxed/simple; bh=zAr2NN3Jns2OMOMJhebylpaZ7+Fr+NR7SMgQK33hi4Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XmlgfLEuvTHzMgRYRC/Ryt+VON47WlU/2xxal4OwGWfYVlKch52T1WK1M60RCrTrTAMHa0y+HwYarT8IJiquzS7WOBL8sDFAD/Vae7Qo1lxE6b++r7lLZCNSpRwX3G2BecNJXvqcQLviuWHpJKC40YfRlAtNpYDdH/pBa4/X8RA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i6Bz5I2O; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i6Bz5I2O" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-795be3a3644so17769096d6.0 for ; Sat, 25 Oct 2025 09:29:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761409748; x=1762014548; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FdGq6o03y1IFQKw38Yd5zNXdE2p5YkP/ZYXUEcu9OkE=; b=i6Bz5I2O9jVbID42iDVIbOzlEr5XwhUAAjk8FWt0wYGbdmgSQ7+rQOE3yf8siJqS2c LKwXvWYtS4g4AsyaLon14YeHlKq5s7rAVUp3v0VbAvkEPuE4ZzZ3HswDQtJ8umgRzqFO 5UVGrtYlOrOoc3RmNYTVseuQ+Og+2oo92dJ9CIuPws6U68ALLIwe9Ei+onlmo2aGCM+L OhkYxevNLYgCRp4TeKfHuMvyU/c2ZB0ZIEsyPKmPQN0XwW3vN1JHEqx4QVii8Seh2TOY zIcQBi1OjFRHwLHH1wHwcqIF8eKWtuz4u4nAgbvxP3jYwQ1xHM03ZW2FQVZg50/uuZeZ j8Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761409748; x=1762014548; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FdGq6o03y1IFQKw38Yd5zNXdE2p5YkP/ZYXUEcu9OkE=; b=TGJuQ6K5t3t36m/Bp2EPPo0j2/O18Oj+GSHLytZndrCtH/eIdkcvM4bWVeA+2bzjW5 2g/Dh4C1ChUPA9KvsJq7UEXQ+63ojea5zD/5xVimm3InBMah6kRfv9HWids1h375XC+5 rbVlt3trHxVn8wCbH0YsCWP1R/Qs5blR6y0MS6/S0ILV4/jU/11cEsGRWhRcZDdjwFW4 jrYNW81fv/NPnlynLwaAleLNd/dJz6EmV2L/+IiP//X2dn/yfE35584bbC1D85jIgt/8 AM6cGl7cVrgRpuPr87zN4g5wxWeJ1q6jQdEn9aVP1FXBQX0McRVzYta0tinAgdm+HkRy tcGQ== X-Forwarded-Encrypted: i=1; AJvYcCVzXjHydxaZKTRCCnhrMvt6woBk97pVlc9suVfdWEAMy17DaI8FlZozAo0mlh9RBPvyR5oQOxt+npNacL8=@vger.kernel.org X-Gm-Message-State: AOJu0Yzm3A9Hmse7Q/v2Bd6tk8azpkmkEDekp2lymRVD8uxh4rLBpVhD rH8JN1zGNblmDq7U9O0NXgDBH8EIEOGf2yJlJdj0yEzSZ8SVM8LF9L/H X-Gm-Gg: ASbGncuDzX5JKmCNthPBddVb4zQWZMBxu+8ATS7XXUwv6bpBfYVWcG+m9+/SkSmHMMs BO05FCiOgTptpX2rtibTV5+S+QSbxr8NtimCee4gwrqNRI86Gg/OI34EkETIBp/9t174TAB2RTA y30w2mGU1/1Rinq9YhwrhXyEeE2JObq48SLQ1w7ROz70/6txspNCrBx71O7Aj1rxAH/5fwq5b6r S96SlcClfSt4yhEwkUdX1GHdj/eEh1e+FFSnuTgFfQ9ckv23XPNV8DtUrdYoAU/75t7m6lc6NQU Rf933DfaQ8pYvibP2zeWClHv632EU8w5ym29bA0mMZNxD2u7d/vu5Gb90powyyLINHqqsJWL3VM i271QJ9yMElDwNRor8N8UIOKQkWZfpXg+4cZWvR1tHNAxmtdLpnTVDawsuZ/yPrbjaTVduxgt90 hqWfzvy+SO8Zamqd+AxQ== X-Google-Smtp-Source: AGHT+IEWdMIG+klSNN4Q5YLgAGeFSgXTpZGuYAcS8sJZ75faWnXPFFjnzC68BJ5CVQ3F20pqCi+JnQ== X-Received: by 2002:a05:6214:450d:b0:87d:fee6:727c with SMTP id 6a1803df08f44-87dfee67d65mr177200556d6.59.1761409748012; Sat, 25 Oct 2025 09:29:08 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc4944d57sm16187276d6.35.2025.10.25.09.29.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:29:07 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Alexander Viro , Christian Brauner , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" , Rasmus Villemoes Subject: [PATCH 03/21] select: rename BITS() to FDS_BITS() Date: Sat, 25 Oct 2025 12:28:39 -0400 Message-ID: <20251025162858.305236-4-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In preparation for adding generic BITS() macro, rename the local one. Signed-off-by: Yury Norov (NVIDIA) --- fs/select.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/select.c b/fs/select.c index 082cf60c7e23..ad5bfb4907ea 100644 --- a/fs/select.c +++ b/fs/select.c @@ -412,7 +412,7 @@ void zero_fd_set(unsigned long nr, unsigned long *fdset) #define FDS_OUT(fds, n) (fds->out + n) #define FDS_EX(fds, n) (fds->ex + n) =20 -#define BITS(fds, n) (*FDS_IN(fds, n)|*FDS_OUT(fds, n)|*FDS_EX(fds, n)) +#define FDS_BITS(fds, n) (*FDS_IN(fds, n)|*FDS_OUT(fds, n)|*FDS_EX(fds, n)) =20 static int max_select_fd(unsigned long n, fd_set_bits *fds) { @@ -428,7 +428,7 @@ static int max_select_fd(unsigned long n, fd_set_bits *= fds) open_fds =3D fdt->open_fds + n; max =3D 0; if (set) { - set &=3D BITS(fds, n); + set &=3D FDS_BITS(fds, n); if (set) { if (!(set & ~*open_fds)) goto get_max; @@ -438,7 +438,7 @@ static int max_select_fd(unsigned long n, fd_set_bits *= fds) while (n) { open_fds--; n--; - set =3D BITS(fds, n); + set =3D FDS_BITS(fds, n); if (!set) continue; if (set & ~*open_fds) --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73E57324B2E for ; Sat, 25 Oct 2025 16:29:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409754; cv=none; b=RNtVpaviK7bbufF2nKaPg+WPP8v1fs7z7Elhqd6FrM8fL13cwtsVWTRmeIJ7/xPgs79BEwFXFBpstNpUEmi6be1C+w7VthMDsuX1hk1PxzMSILXDQ5iXaWibcnH2pCVc4ofCUdmeU19ydAQzGdjbhL5Ib5YlkrSOPfaVarm5FWk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409754; c=relaxed/simple; bh=r1ZSvL7GYSBh/Cee0SXgYuJ/pWOJXGQu2D5xFAme0AE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OH8U4Ker5S0zx7Anh3a4Pfmv7VEcCkysu3D9+PmKqJ10HUelDMx5KaxqtL6+kim4cGq7JEE5hHHfODi0jd7hkrjtknJroWyM7BSJ7DzK+X0MmZW286qWjm9Jo1FPBwR0S952EHPm+qEo/NbefW5SA1ppjWfJ8/BtZ53IRhnUGiw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CGIt3x7h; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CGIt3x7h" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-4e8850b09eeso31811741cf.0 for ; Sat, 25 Oct 2025 09:29:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761409751; x=1762014551; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mxeCOI9icR7/UFiwtRNvJHOt4NesbHGx93HWxIm5tv4=; b=CGIt3x7hQWmYFABG6jUfTFmtphR0f6nf6bDA5fcyMyUX0XToDHYKQdphpuOhaMgZh9 62kNPNvK7LStwr9lmNBGJY1/+K3QtLYxaHyw6gPG7kUP8LOo2NQTu3Do9+mqlzMcztQ5 FpiHgsu2oErrMzvo6Kggd0XCPkx02VxKQjjz6b8y2aTEjwjNEOpPpr2aBdxkviQk5467 8LiPAezz8CxjQ3MKcFnVU4j28x8GvWbxLUJLUEROWpnJbzm0LKmg+QjzPlyQqdSP+1lS VMQX9ZeH4+Yb3Plqwg5kZP6oYSGwxgBqPnDWxb+8hKccUo8me3L1Fc6wzE6gq3MCeEET 2oyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761409751; x=1762014551; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mxeCOI9icR7/UFiwtRNvJHOt4NesbHGx93HWxIm5tv4=; b=GK44j0aj4/rC2ZU4jHbRgyT6YLguuLux+Xu1DIXT9hgdIBB+iQ6qYqwvNSlD8dLmzu bMIjNuztWZWw33AmqMp9OMplSh+dQJHp/H7DenmoVqppziq8aKv/XqY1gXRUVYiFWSud 8NScZtdOshUtBWaUzR22z/Jp4aRkMmOdXavu+eFT9w3hwI7TsdA/UlTwZ+C+Nlh5D1I3 tUb9knU0C5qUaMYNmheEXsmEothdJVzJ3sBenudfJn744rnSz7fCfV8SuBmZyD5O4klj +hj+rwlQFXOacMDszVqlStIKVm3FCwcC5n9vtg5GLObDrJdrL3jjInVoGLcd+l5r5uTG WFQw== X-Forwarded-Encrypted: i=1; AJvYcCWJ70WUBfBEmrfpodiw0G6CKWBWUgx5u7RY2m82iAwskITfIlyCwfJWbrV4tXqbUsxV5oqhoNxWf6FySnE=@vger.kernel.org X-Gm-Message-State: AOJu0YzsoRopA7ecTlZREMPW/qbyJzvcslWIbHzXxQ0k3eyfrmmnovjO E4lg1OnPhNp0HyIieAvQAX/Kc6Co4HCIirnxnN4dkgn2Nb7dk25RypzV X-Gm-Gg: ASbGncu2FtCCco6ldejo+xx/BakjTQeoBX+J3KJrrR9OmldFLOA9tdN3AOQrkEPt8JZ wB8Ue/MYOUaiXZ6u10PuFLkK/3HohC3bhMoIpNii4zvp74wWlImkjw6CPsJ/Kc1oMnZa68fKEHJ vq0y9QuAvObyN5K+B2vNEJ4hlWbxpKmh6IhbDgesDLlqfNoxtsB3QLmIV296jmBVDBjDvJo44fR mDin0FmTi75DGt45tpE2Bj0FfCoK6x4x8/83duJdpdHJ3cqsPzHL2SeL1kBGSmx0FbkW+CWqRIz ZDFMKF0Q18JxCOVcK28xzjOZYemJyd8GhPl4QT8Dfjw+pjx01yjbqkoEAE/z+u2hQ5QNox4YCzx Yx8p9t/Nk3ji4CPSam5BZbP7qm/zwvq67e0GSTQkzNiBrurFK+UvN2oT+zmWqMERWn1Y3dQEX X-Google-Smtp-Source: AGHT+IHE/cxtBB92jOlmZMcoUVK7+rMqdx2Thi4RMGOFfo0VELRSYvXVDUaBSTA5+Nf8oaPoFuNrpA== X-Received: by 2002:ac8:57c3:0:b0:4e8:a7d6:bc07 with SMTP id d75a77b69052e-4e8a7d6c0d8mr369172781cf.71.1761409751421; Sat, 25 Oct 2025 09:29:11 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4eba387fdb2sm14761791cf.37.2025.10.25.09.29.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:29:10 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Jaroslav Kysela , Takashi Iwai , "Yury Norov (NVIDIA)" , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rasmus Villemoes Subject: [PATCH 04/21] ALSA: rename BITS to R_BITS Date: Sat, 25 Oct 2025 12:28:40 -0400 Message-ID: <20251025162858.305236-5-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In preparation for adding generic BITS() macro, rename the local one. Signed-off-by: Yury Norov (NVIDIA) Acked-by: Takashi Iwai --- sound/core/oss/rate.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/core/oss/rate.c b/sound/core/oss/rate.c index b56eeda5e30e..90a40221e4ce 100644 --- a/sound/core/oss/rate.c +++ b/sound/core/oss/rate.c @@ -25,8 +25,8 @@ #include "pcm_plugin.h" =20 #define SHIFT 11 -#define BITS (1< 32767) @@ -162,7 +162,7 @@ static void resample_shrink(struct snd_pcm_plugin *plug= in, } if (pos & ~R_MASK) { pos &=3D R_MASK; - val =3D S1 + ((S2 - S1) * (signed int)pos) / BITS; + val =3D S1 + ((S2 - S1) * (signed int)pos) / R_BITS; if (val < -32768) val =3D -32768; else if (val > 32767) @@ -191,7 +191,7 @@ static snd_pcm_sframes_t rate_src_frames(struct snd_pcm= _plugin *plugin, snd_pcm_ return 0; data =3D (struct rate_priv *)plugin->extra_data; if (plugin->src_format.rate < plugin->dst_format.rate) { - res =3D (((frames * data->pitch) + (BITS/2)) >> SHIFT); + res =3D (((frames * data->pitch) + (R_BITS/2)) >> SHIFT); } else { res =3D DIV_ROUND_CLOSEST(frames << SHIFT, data->pitch); } @@ -226,7 +226,7 @@ static snd_pcm_sframes_t rate_dst_frames(struct snd_pcm= _plugin *plugin, snd_pcm_ if (plugin->src_format.rate < plugin->dst_format.rate) { res =3D DIV_ROUND_CLOSEST(frames << SHIFT, data->pitch); } else { - res =3D (((frames * data->pitch) + (BITS/2)) >> SHIFT); + res =3D (((frames * data->pitch) + (R_BITS/2)) >> SHIFT); } if (data->old_dst_frames > 0) { snd_pcm_sframes_t frames1 =3D frames, res1 =3D data->old_src_frames; --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C5E8324B2F for ; Sat, 25 Oct 2025 16:29:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409756; cv=none; b=gNFEOjA/ZfDtgyDB3F2vSUetvy1FmPa+2lDdSLpXjCaEjyBtKhToX1Nbwyfh1vpq6FLZ55TfSL6Bl59uxiI/SPsMR+fYRgUohctzJHC42IoL4T50ThF6XM3CxULCUX33jgs9Su4RQlcqpAUvP9InQXch5aQ4bj2HUW/fKxtWCwg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409756; c=relaxed/simple; bh=vSOmrnKl9j6cBNY7sSNJF+HbPImP5X3RfSSeVaTTTB8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bOEC5V01tveW1RQ4ZKeqp1FbW+qJf7xRT8f/S5sM41SYVPeCt7GKvpVuEqGUCbFBKS7cA9bPETb3dK6q8IqiTdnjBTUnvIbB3Du03k3g/fPWPq8p6ApF0tu3moDX2uBMtRAPge/gpsGHAuAAChaLKwoaZjbfJIYiBhVplgMgzWk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gHMQtyGN; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gHMQtyGN" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-8a114591f15so29345185a.1 for ; Sat, 25 Oct 2025 09:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761409753; x=1762014553; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sJO+MeQ4RtFqJ9ACNBMsRAE4YNMhC0BoZJ57Lb9WxOM=; b=gHMQtyGNHqaGs40F7wIBmCDbZyWtl7y6iRZL7ITBgu3KXCEJBQNGHC5ktC0SaQp5eq CYeNzHJF0EV48k/T80bpx2AeOCz3M8lbFSnplH3egU0vB5mcqwVhRtMRhqjOJu2xEAqO ODNtUj0yXgcyAdcIn/t1FxQoiHUbe2YitCMWoysztIM19sIpQOQwhCrVawWVLlKj5prc yub9NqMvB8vP7hjip1C4dXpf0naeeLKJNhgcHa9H96Rf2oZKB6MYMsCBBeHLA2GnAdtx w9gzoSkIJebT3GXFuzh3eWrVZN90aT5ojrRUyGHU21iKFB8hfZ163o6GXvQ8tOEqw4+Z 5tKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761409753; x=1762014553; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sJO+MeQ4RtFqJ9ACNBMsRAE4YNMhC0BoZJ57Lb9WxOM=; b=iFtm3eBfFJTLW/GNjy0SvtUUtf1GsMrii0Y7aPiD0Ku/jiMP+U4/BRBYRswWZRskWk v+qSNYnojdF40PeUFWuEtA7VamsMFvTxuC4yfW6M2pWRs/Voy8LEIH0ehc9uvWlzEA3R UCaEIxX7ZzAkamA/pLqn/MbjDSPFYSvERCNIG48QjADW0bkSxkxFMJhlY9nQWs7Yz666 PGKVvMyD+o9/PBHgU0stYsb+27dkywNzUuM/4C937zjqfufeNtEG9hNZHI3magyqvmW1 L2gq8D83vT4pEr0HDkV49Qa/MuPaeUyCiAU3mh8N8OE1EscdXTFSFtHBphQsmQko8SzP MQrQ== X-Forwarded-Encrypted: i=1; AJvYcCXdLgR2mw5f1cQWKKtZhYwjBvyHaF5pqneOXyaJKxwrAT1xtEYMk4671jbsX0a2orEphFY4xcfqqzPY8XY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1vSri0ho9WkyhDyVChrKaWrKTeOTWPdbH4X4SiSy/FaNcT9kS rymrYQrZGCYlrYi+dHVz5NGnX4yi09/8KxR9NyGssRP93w4ZYqNHirek X-Gm-Gg: ASbGncsz8s2jpXNnqzbOHGfEijkkDhQ+O3FZV0Llf23Ad5ZX28BW3CWi+B1Ql3RYEPM /gO9ORi3NIT0F/cytV07jdUVQ2GFFTU1rW/Li1q7VtXgG4lPgfktOL6MGMvNrDoFAS7PsyxB1Ms 4+JP4r3t3CbjSJeZvX4dhANIsgo5tU5siNpdanJW5WCnTLGpDqhymUcXDPD5ban2wU4c/sbeUJ5 9FcvkClJAIchLoMVKA5fiSPs3+CilnAaK7u/W0ijdsV8zqaEm1q6F6kqkuL4H0sSG815xAYGunD 1Ler1zM0a4Fo9edDe2T80ofVKV7x2iQa26otIg23ROkcy4tvMFG5TfkDDmlmzxaktYPtv0XMftR TPAgIgYkq549ezDP/TtQe/JS0ktAvs5ZSIlHijDmCUR63EtJUXCAT4/ir9CndWxA7ISSmQCOB X-Google-Smtp-Source: AGHT+IH6uNIrkZmsMoZ8MZ+ODlZIL9OIXHsVfJ9kwXcOeEFldBGDrvl1xoiZUliWzp4QZq0d8LiTBA== X-Received: by 2002:a05:620a:4627:b0:890:e60c:de2c with SMTP id af79cd13be357-89da018d159mr957294285a.14.1761409753403; Sat, 25 Oct 2025 09:29:13 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f24cd592bsm173777985a.18.2025.10.25.09.29.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:29:12 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , "Yury Norov (NVIDIA)" , linux-kernel@vger.kernel.org Cc: Rasmus Villemoes Subject: [PATCH 05/21] zlib: rename BITS() to LOWBITS() Date: Sat, 25 Oct 2025 12:28:41 -0400 Message-ID: <20251025162858.305236-6-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In preparation from adding generic BITS() macro, rename the local one. Signed-off-by: Yury Norov (NVIDIA) --- lib/zlib_inflate/inflate.c | 48 +++++++++++++++++++------------------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/lib/zlib_inflate/inflate.c b/lib/zlib_inflate/inflate.c index d1efad69f02b..3102137b51c2 100644 --- a/lib/zlib_inflate/inflate.c +++ b/lib/zlib_inflate/inflate.c @@ -229,7 +229,7 @@ static int zlib_inflateSyncPacket(z_streamp strm) } while (0) =20 /* Return the low n bits of the bit accumulator (n < 16) */ -#define BITS(n) \ +#define LOWBITS(n) \ ((unsigned)hold & ((1U << (n)) - 1)) =20 /* Remove n bits from the bit accumulator */ @@ -270,16 +270,16 @@ static int zlib_inflateSyncPacket(z_streamp strm) is: =20 NEEDBITS(n); - ... do something with BITS(n) ... + ... do something with LOWBITS(n) ... DROPBITS(n); =20 where NEEDBITS(n) either returns from inflate() if there isn't enough - input left to load n bits into the accumulator, or it continues. BITS(= n) + input left to load n bits into the accumulator, or it continues. LOWBIT= S(n) gives the low n bits in the accumulator. When done, DROPBITS(n) drops the low n bits off the accumulator. INITBITS() clears the accumulator and sets the number of available bits to zero. BYTEBITS() discards just enough bits to put the accumulator on a byte boundary. After BYTEBITS() - and a NEEDBITS(8), then BITS(8) would return the next byte in the strea= m. + and a NEEDBITS(8), then LOWBITS(8) would return the next byte in the st= ream. =20 NEEDBITS(n) uses PULLBYTE() to get an available byte of input, or to re= turn if there is no input available. The decoding of variable length codes = uses @@ -295,7 +295,7 @@ static int zlib_inflateSyncPacket(z_streamp strm) case STATEw: while (want < need) { NEEDBITS(n); - keep[want++] =3D BITS(n); + keep[want++] =3D LOWBITS(n); DROPBITS(n); } state =3D STATEx; @@ -369,18 +369,18 @@ int zlib_inflate(z_streamp strm, int flush) } NEEDBITS(16); if ( - ((BITS(8) << 8) + (hold >> 8)) % 31) { + ((LOWBITS(8) << 8) + (hold >> 8)) % 31) { strm->msg =3D (char *)"incorrect header check"; state->mode =3D BAD; break; } - if (BITS(4) !=3D Z_DEFLATED) { + if (LOWBITS(4) !=3D Z_DEFLATED) { strm->msg =3D (char *)"unknown compression method"; state->mode =3D BAD; break; } DROPBITS(4); - len =3D BITS(4) + 8; + len =3D LOWBITS(4) + 8; if (len > state->wbits) { strm->msg =3D (char *)"invalid window size"; state->mode =3D BAD; @@ -416,9 +416,9 @@ int zlib_inflate(z_streamp strm, int flush) break; } NEEDBITS(3); - state->last =3D BITS(1); + state->last =3D LOWBITS(1); DROPBITS(1); - switch (BITS(2)) { + switch (LOWBITS(2)) { case 0: /* stored block */ state->mode =3D STORED; break; @@ -465,11 +465,11 @@ int zlib_inflate(z_streamp strm, int flush) break; case TABLE: NEEDBITS(14); - state->nlen =3D BITS(5) + 257; + state->nlen =3D LOWBITS(5) + 257; DROPBITS(5); - state->ndist =3D BITS(5) + 1; + state->ndist =3D LOWBITS(5) + 1; DROPBITS(5); - state->ncode =3D BITS(4) + 4; + state->ncode =3D LOWBITS(4) + 4; DROPBITS(4); #ifndef PKZIP_BUG_WORKAROUND if (state->nlen > 286 || state->ndist > 30) { @@ -484,7 +484,7 @@ int zlib_inflate(z_streamp strm, int flush) case LENLENS: while (state->have < state->ncode) { NEEDBITS(3); - state->lens[order[state->have++]] =3D (unsigned short)BITS= (3); + state->lens[order[state->have++]] =3D (unsigned short)LOWB= ITS(3); DROPBITS(3); } while (state->have < 19) @@ -505,7 +505,7 @@ int zlib_inflate(z_streamp strm, int flush) case CODELENS: while (state->have < state->nlen + state->ndist) { for (;;) { - this =3D state->lencode[BITS(state->lenbits)]; + this =3D state->lencode[LOWBITS(state->lenbits)]; if ((unsigned)(this.bits) <=3D bits) break; PULLBYTE(); } @@ -524,21 +524,21 @@ int zlib_inflate(z_streamp strm, int flush) break; } len =3D state->lens[state->have - 1]; - copy =3D 3 + BITS(2); + copy =3D 3 + LOWBITS(2); DROPBITS(2); } else if (this.val =3D=3D 17) { NEEDBITS(this.bits + 3); DROPBITS(this.bits); len =3D 0; - copy =3D 3 + BITS(3); + copy =3D 3 + LOWBITS(3); DROPBITS(3); } else { NEEDBITS(this.bits + 7); DROPBITS(this.bits); len =3D 0; - copy =3D 11 + BITS(7); + copy =3D 11 + LOWBITS(7); DROPBITS(7); } if (state->have + copy > state->nlen + state->ndist) { @@ -584,7 +584,7 @@ int zlib_inflate(z_streamp strm, int flush) break; } for (;;) { - this =3D state->lencode[BITS(state->lenbits)]; + this =3D state->lencode[LOWBITS(state->lenbits)]; if ((unsigned)(this.bits) <=3D bits) break; PULLBYTE(); } @@ -592,7 +592,7 @@ int zlib_inflate(z_streamp strm, int flush) last =3D this; for (;;) { this =3D state->lencode[last.val + - (BITS(last.bits + last.op) >> last.bits)]; + (LOWBITS(last.bits + last.op) >> last.bits)]; if ((unsigned)(last.bits + this.bits) <=3D bits) break; PULLBYTE(); } @@ -619,14 +619,14 @@ int zlib_inflate(z_streamp strm, int flush) case LENEXT: if (state->extra) { NEEDBITS(state->extra); - state->length +=3D BITS(state->extra); + state->length +=3D LOWBITS(state->extra); DROPBITS(state->extra); } state->mode =3D DIST; fallthrough; case DIST: for (;;) { - this =3D state->distcode[BITS(state->distbits)]; + this =3D state->distcode[LOWBITS(state->distbits)]; if ((unsigned)(this.bits) <=3D bits) break; PULLBYTE(); } @@ -634,7 +634,7 @@ int zlib_inflate(z_streamp strm, int flush) last =3D this; for (;;) { this =3D state->distcode[last.val + - (BITS(last.bits + last.op) >> last.bits)]; + (LOWBITS(last.bits + last.op) >> last.bits)]; if ((unsigned)(last.bits + this.bits) <=3D bits) break; PULLBYTE(); } @@ -653,7 +653,7 @@ int zlib_inflate(z_streamp strm, int flush) case DISTEXT: if (state->extra) { NEEDBITS(state->extra); - state->offset +=3D BITS(state->extra); + state->offset +=3D LOWBITS(state->extra); DROPBITS(state->extra); } #ifdef INFLATE_STRICT --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5B0D325499 for ; Sat, 25 Oct 2025 16:29:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409759; cv=none; b=uB+DTE7HpoQbO7rga+07kmUemRsyzs1euQ9pwggvn0w/YNidhuOSfyVjmTBxozjx2iioyb0cobqNPd2wN8P3bH1yTMcL9i8adbogU+zpvFTgb+wPIJWLbv3Zu9YC16t3lmRiSLBO9oLNdeeVgFmSzYf6mea2Q2c/jmhGMAd+HlU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409759; c=relaxed/simple; bh=HkqvAUV2gBzhJnul/mGo7LdzjzJg+2pG+539ApHOXFA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LZxG56qu5qj/P9uRKZSQ6FxNN3xTSQAuQuTj6rg0O3074FYsZxi713O+eVYKwhMUR2aHtGweclY3MKcQ6G0WkF7wwPhE+oRRc/M40nn8ssyRNTB23qh7SZitm7cqnP3Gc134W9kjqsdSS0Ak6wSVxeLA12VOtOI/IqTereGY7OI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BAlH4WjY; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BAlH4WjY" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-4e8850b09eeso31812151cf.0 for ; Sat, 25 Oct 2025 09:29:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761409757; x=1762014557; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZXemVp+XP5C7K8PhG6mE03zKRPQX07LLYcr9/0qBaeY=; b=BAlH4WjYhecUsYZEjLlGoW1SyTKA/DfDx40EXXgmemoZJ4jYYC7+wqIKNP4NSJHXh4 avjqWcox3Te/nA0tS2z4G+zmy0sJ0vSXRhTc0M2RxOQJ5Y8C1lzrmKGkAfQxUsQc/dXr mQIFJraHF4L69/cCFDRwOPzJpZpJWup8ocDEkXC/6k9WCkPBQMmgbCqzPDCcO/xC9/xi CMCLLd9RLm3WoRij+L6FB1aEBMFItzWObRc7H/JMezDbWG4bD8xYQ5CLJvUeNvI0m87E wv7G85HZzmzNxgzvAWLvpOiklEdqF/u7ELxUP/4inf/COi3szM1qXvNeRbTzvDUsQFq5 EX0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761409757; x=1762014557; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZXemVp+XP5C7K8PhG6mE03zKRPQX07LLYcr9/0qBaeY=; b=nYCT99lmaMtI/038bqlq0oA285/T3jx0QlzFKgn3QuNy2M7oL6/fmMYsCPO3brt6uD PTR5Lp4Xt4kbfu0xklIPFUkOnbMh+KiwNvIyY/gzBgvtZeFE2l1O86aC7I72z5rccuOu 0bCUDz8apmVyyYrQwUA5QlbHU0OGfWK3anYfWhYB7sKcfW6jG5r1LSnaU793QErnnbdc +9Z79hKYItD2TjVWAoJWRJJESnZRj/s/DL7WVICTZFzQXI9skWlj6jBhaHmgX5l9KhzJ HQjhndK2+VudcvShrfO1kdOVLrjl5LgCgbLwBOsJSzrKluq1fFDn4HsvoM/rEewYk/a7 Mpaw== X-Forwarded-Encrypted: i=1; AJvYcCXKbrIHjzqHf+8KEeUp4xNyvso3HQ9p6CpSZv7Sa36NyUBKQmHXXEHBOpMVtYB2vdHMtx5oKjeFTAaMkUg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+BVhY6iPF0m/vzZxLZTZqkrPimOgZ31ANEKN1WUXWkvtpGym8 DYaQtL0eQrFa3eQhm8RTplgPGK5s7wGJ//TrotcafxbkPURMD79g2oKb X-Gm-Gg: ASbGncutrDWWPwHWs+NU9lZBT1lk/NUvgxAB0vg9OLUtUC08Pb6RO4u8bTHQbwZHwQm 4el5DJsdu1/0oatNGw15e10zr3QhCwhTloI2e186DMyugQrRBYKKBdrVnO0eoOjYg6bYG22EKKO XVIJ1PHscDkq2sW6DD3sYPbRywpJxlT9R/8tKeGzpUhLlmVxRAjx5U01sOFjELVhneLrno47N+a szJmppvQ0se2dZ9qdA+s6LiM96AMsn87l8PZdohH5vXRTwIErMv33h4UrmDI+IKvOlmekwoFiH0 a99nEIBvytt4l2eoeusQjRJS6QuJrrOZjapRUFL3Z8xCArvIJgnduSPyindIk5cYyHsNlJol+mm lhfDyGFb+z02A6sR6Cx3VNa+AxKkdC6bKjZplJanYJH38+mdqETJDVkngoz1S8X3I+MRWTZk8 X-Google-Smtp-Source: AGHT+IHpyFrHKiL1MaHe1LWs1dN16AdeBx6FjJoNTEhnZ8XH3TR+6NumbQnfk6ta4v10mj6oyfvxsw== X-Received: by 2002:ac8:5d8a:0:b0:4eb:a8f4:270d with SMTP id d75a77b69052e-4eba8f48ad8mr17559461cf.65.1761409756596; Sat, 25 Oct 2025 09:29:16 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f25c91d9csm170613485a.49.2025.10.25.09.29.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:29:15 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" , Rasmus Villemoes Subject: [PATCH 06/21] mfd: prepare to generalize BITS() macro Date: Sat, 25 Oct 2025 12:28:42 -0400 Message-ID: <20251025162858.305236-7-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In preparation for adding generic BITS() macro, add an #undef directive for the existing BITS(). The following patches will drop it entirely. Signed-off-by: Yury Norov (NVIDIA) --- drivers/mfd/db8500-prcmu-regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/db8500-prcmu-regs.h b/drivers/mfd/db8500-prcmu-reg= s.h index 75fd1069372c..25d2d5966211 100644 --- a/drivers/mfd/db8500-prcmu-regs.h +++ b/drivers/mfd/db8500-prcmu-regs.h @@ -12,6 +12,7 @@ #ifndef __DB8500_PRCMU_REGS_H #define __DB8500_PRCMU_REGS_H =20 +#undef BITS #define BITS(_start, _end) ((BIT(_end) - BIT(_start)) + BIT(_end)) =20 #define PRCM_ACLK_MGT (0x004) --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8E94326D77 for ; Sat, 25 Oct 2025 16:29:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409761; cv=none; b=IdNruqRUepwVieVCGDYaqGzQXy2VxkdEP5hJRcK/3d4jYQ131VMCusLLmoRALHX+CIvwzDvm56B0O1mmKAPVd35fNl7hF2MqmEGJR+ZqBCQAIFQhQI3XWY98jT/dZ+MzD8owsl9d1O/0Atx80PnfBiMp7GgPZeNxZ00pfs3E8TY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409761; c=relaxed/simple; bh=6VtH0YRJIJT6wM7OnyxPz0sTaONVtRxS45ztLq91gUI=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Evy9HRu3GFk1NMZ0fwG9COv5f7XQ3ClOALC/gXh7RmD2yd7Z2oRPZmYSnfi25kjYytJTPUWEmk6lzDgY8HLr3Z7Azofr4rWpsRyisYqvj04Z3iEmO/k/Z3c1i+inD83+TzPRQb0Ic2TzmtKwrrQHo/NCnFV1l4L24h/6MzvkEu0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pv40gj7U; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pv40gj7U" Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-4ecee585f23so903501cf.0 for ; Sat, 25 Oct 2025 09:29:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761409759; x=1762014559; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=rg54zbsiDVSwYkKftv5+NDhQ1U50ovc7eDauHPziXJ4=; b=Pv40gj7UnkIqzAZrfy8BLHFb/OrnxCgnnZPlALPg5bMl6J1tK8XzFnZGgbXk8xJ5kd b1tV6vgmA8JTyYHOqlp8e3RhCAxKrOkjczzTnq8WTrPB2QunsvL29I8Kaw8P8AyQrwc8 rkkVY3VLNTgn1rILtKmcHHrk+HRz9RppP8MT9AGnIP1pK66QVicfX+W1gnQf6JeGzve6 3KVv767PNmYmOyxFEmheRpZ2d9Ca0u/655/xwilCKK8UvFCO5mCxbo2ne8SBCsyiYvRh 6D9HSiDVRyZaeC6DHRp5IAB/LSqVDOlr02JnbnV/dK00ICpbcBzWki/cwju9mNRmHBxD p4YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761409759; x=1762014559; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rg54zbsiDVSwYkKftv5+NDhQ1U50ovc7eDauHPziXJ4=; b=ayCfovW2RNGam6KUyGYNfAGWYmyitnSFe2NK0/ZKoXT1pJi98qaQ0BlSJzr0TcDdHE LZLEQkrZxsDe90QLDK7yTru+ShD2W1H4ZrxAjdyIHWO5nCuWFDowwdd9dGdS9wr7DiQO l3wX2NwXHlen262sxeCY+O/Ou0urcrqgpMYgEHWnZnKjwX4wzOGPqiAhoJgbeMuMtxQI oqlBcpB7DuLF68ILYbZs4EgdqfjjDBuSTMMlstq/6MT07DzA6B/CKzTrNMy3F4/t/9K0 BrgkA7xHLdtQHv0+PkazINEuHxV90JuUzsfsNBsCKJ42uAaJjsxFHx9TOXlZ3JdEp3iJ PHfA== X-Forwarded-Encrypted: i=1; AJvYcCW9INTQVB2lFW1HgSi66ZrMsjRd2Xxw/PenOdv/+IGzlasFuEvS/wmOo0mSaw2z5gzKrMRCg3lfrDUOkfE=@vger.kernel.org X-Gm-Message-State: AOJu0YxzC5Ji1znWCG4k6pZ5BqVq4xrJ3sV089EUae0+9Vyl+BKIp/BL edpiuUwL2SG9M7OeZbaf9ykbibyUvsFlLJB9B8AJs53i4domttfC+KcZ X-Gm-Gg: ASbGnctVQuBeE8VSuyOt3iybQ1wDeXEB8tX66T46hMvsVp3Zo02w6eJw+exBDWJlzOi vMHKplEKr/vkR2gJSnR/JCckpbSjlcMbfzhWY9KKgqYGFcnLwB4t+AxPFY7RjCJnJk5Rs9jTKSR UTrk+Us1gZmQJ1ANRC9ZqlFQwseI5IVgCbi7MJzXuYzkYEmCEebc2EOQhIymlFuUaLcQqmCTwY+ 5Lpg6xGmaOO9C9seovWxmw1sxHjFTwPGkbOIWnvYlBiT4DojRMTy9ivD1DJ9sR6oKof9eq19mdB Za1b7JrlZW1CVa4szPKFV0+yVnZr/RcO/ymTWhv62fC+RgABCxviIG9a2EduuAV+ZJoa6wY3eHm WTdbd4A+3dRapdGADt2Rxut9+7nGEhyzlTFJ9sjFnuSdZNR5m2T/OCdQe+51HbiKCEzl0lqFS+x Qe45TCajE= X-Google-Smtp-Source: AGHT+IGLUImymLRUarqsG2KCT+ABE5J6HOGR+UWY59nzAscKl2lLvmhKB1esOHduNRD5/GEXTnJpNw== X-Received: by 2002:ac8:5a08:0:b0:4d2:b9e3:c400 with SMTP id d75a77b69052e-4e89d292b40mr409532031cf.26.1761409758552; Sat, 25 Oct 2025 09:29:18 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4ecef8c5850sm66241cf.15.2025.10.25.09.29.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:29:18 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Torvalds , Linus Walleij , Nicolas Frattaroli , Yury Norov , Rasmus Villemoes , linux-kernel@vger.kernel.org Subject: [PATCH 07/21] bits: Add BITS() macro Date: Sat, 25 Oct 2025 12:28:43 -0400 Message-ID: <20251025162858.305236-8-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The BITS(low, high) macro is preferable over a similar GENMASK(high, low) because (low, high) parameters order is more natural. The (high, low) order is confusing and has a record of misuse. To enforce unintuitive parameters order, GENMASK() is enforced with compile time checks. In addition, fixed-width versions of GENMASK() had been developed. They make sense in describing hardware registers. In generic code, using standard ordering (low to high) is more preferable, and fixed-width features are not that useful. In non-driver code, BITS() must be taken over GENMASK(). In drivers code, BITS() is preferable over GENMASK(). The following pattern of using GENMASK() is highly unfavorable: /* Status register (SR) */ #define I2C_SR_OP GENMASK(1, 0) /* Operation */ #define I2C_SR_STATUS GENMASK(3, 2) /* controller status */ #define I2C_SR_CAUSE GENMASK(6, 4) /* Abort cause */ #define I2C_SR_TYPE GENMASK(8, 7) /* Receive type */ #define I2C_SR_LENGTH GENMASK(19, 9) /* Transfer length */ Suggested-by: Linus Torvalds Link: https://lore.kernel.org/all/CAHk-=3DwhoOUsqPKb7OQwhQf9H_3=3D5sXGPJrDb= fQfwLB3Bi13tcQ@mail.gmail.com/ Signed-off-by: Yury Norov (NVIDIA) --- include/linux/bits.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/bits.h b/include/linux/bits.h index a40cc861b3a7..c7c587e90e2d 100644 --- a/include/linux/bits.h +++ b/include/linux/bits.h @@ -57,6 +57,9 @@ #define GENMASK_U64(h, l) GENMASK_TYPE(u64, h, l) #define GENMASK_U128(h, l) GENMASK_TYPE(u128, h, l) =20 +#define BITS(l, h) GENMASK(h, l) +#define BITS_ULL(l, h) GENMASK_ULL(h, l) + /* * Fixed-type variants of BIT(), with additional checks like GENMASK_TYPE(= ). The * following examples generate compiler warnings due to -Wshift-count-over= flow: --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19E61302170 for ; Sat, 25 Oct 2025 16:33:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409992; cv=none; b=uXdop49EABUPr2qPizABRtQAMfee6IfXlmbK0LCmaRWOu6H0dklmSXdnVR3ixunM+HyuTt0p78GSuCI96S9/pWxr2VvSJNcuJ7zzSW7oaddSj63a5VyeRUKicFsINR/NT908Ob5ZpFfneC6lA9EjjPzYqRfXPAO34gFK1sjL6d0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409992; c=relaxed/simple; bh=+heAOJdpmDquFU3lSVmqK3nMR1KJgJ3fOnV2yC6kTTY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IOPvlDzIatJzAadlFoemKbezTOweEVtDwjwLLlIbz9rKcXz5HIRDEHoVf0+OD9EfnKuoco68T41Yf/seIs3BF6h6p5KX1VSe08fGYiTNEdfh5DFWh2LxIRqjSwx/Iv6ltwc44IFwV0Y7mWiQ0hhQowfHU5Z9Zfpc8TReEZQRr1g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=njZ5IjSe; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="njZ5IjSe" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-87d8fa51993so36647126d6.1 for ; Sat, 25 Oct 2025 09:33:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761409989; x=1762014789; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QoCiVofkihU7HPUi3IX0CnSOHLAMfManJqPdcZxdW10=; b=njZ5IjSeYG1umnUTL7lttRp/9FMj0M/kJUZHTdbav5i/qM0Xf9IgUzK8oo4JLaWYdb aRNgiZXwToiRS53eWX0EpuRe9hPfm4bJDbfgU2YLQeigKpcpLwdHscivxWQRBaY+VXbv DZsVdODpTuKAm5NmxP4xauZzvXxUOeWXDRDXcluN4udt5YcnvYN1Jmhm4dvZ86UMZdEN sD53zHn0gRxfmCM61Ug1U+vEpPwmER0PKD2CiKyMkISDdqQGlriBloiUgSBS5+NbqhoT NkBu+5+U/RL+hZCY+9CQZ61il78Wc6qiQlRc1Iy4S7JalqTFyTaQsomslfLfNe5q2Rcd lujA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761409989; x=1762014789; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QoCiVofkihU7HPUi3IX0CnSOHLAMfManJqPdcZxdW10=; b=sV5yOVdbfvT0aCfgFxG+q2hzcZSBLiRI7ilD1EzvN+mnsbAtzz9QgKl/poLibSrnA2 d86llKP860G8Fgmo2eV5NuevHSR1TsNRVDVYiILc1kWIqHSGmQNMuwigutX+Qq+kiTCh My39bPsCZrO+Tlzjav7YS75DEG/hD1sks+qiNLM+OxOEvUJpQvNhkvl4yLxxEZORTFJ4 QF+6L9alQofVCBjrLN9bCKWUg1Rabtf3Pb9jVEbGvGEJG4I+QePMshRPRLx085i1EtFx sJIIo7lek5IFOe6ZvAUoDJgUgmG2pcz457sHzaSTH/reCxLJkB1gUqTKbPH987NBOVRr ZnSg== X-Forwarded-Encrypted: i=1; AJvYcCUrIwVoDF55Vn9sPdF3yuYgGbfivYrzEIhiHSxgPnGp8ZNMwOTCq43bMuisUnNoplLx5PviVAPWiD8mKBE=@vger.kernel.org X-Gm-Message-State: AOJu0YwykeflrDNdmHyoYLEYF/F+DdqGmazPK7JdURx1ekuiy2IHVLv+ f+AnBSLNFGRk+vdb0NR9mpBISK1LGlQ5nrri18J1Dx+okajrqokB7rQFrXUZNg== X-Gm-Gg: ASbGncsML2ttrIfnw4GqNFRTVHj6x4afU0vaV3GMpL8c15v7hhGOxH+Z2fY5WrUG3j3 eluQ7AbOmdeUrrLivgHs0S2CNbn3BdCck/TYeUhmfIAapxtm/7mH2B6ckpAI/ckPJUcOe2wLbMB QbGZ3GQzJIJE69tTUqUryFTixaqxNIKRY8WTC6osdm70gKKd70GFzCXJJi8YSgU7XuTUpexs9QS IiQhy91MC8uaxVa7rA0RdgcItgDbBNAK7mh/FOudqwzx5FbUAjEU+4bu3aFIntKCz1yQdNBV8Le KgMfk9eNRagzSZYKz9KqT/IL9YL3ST/yRkm7bTKmMVuRvwuXdAj5Di6K8Gr7ksbFRYqQv0RCNOh IVancJUDAK6PsFgBdvYfFIPfFCQpJrXe4p+pyWglUP9MBWXyAKLjnlW4rpfDFMKq+x7PXc0wg X-Google-Smtp-Source: AGHT+IGH02bA/hRDTKDZFiOYcreM6dX0URruEDzc6HE9hqOeDZU2lVRtUdzNlu49mj64aBg33Sqn1g== X-Received: by 2002:a05:6214:4e01:b0:87c:21db:cbbe with SMTP id 6a1803df08f44-87c21dbcdfamr369300846d6.26.1761409988610; Sat, 25 Oct 2025 09:33:08 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc49ee9a0sm16415796d6.60.2025.10.25.09.33.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:33:08 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Walleij , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" Subject: [PATCH 08/21] mfd: drop local BITS() macro Date: Sat, 25 Oct 2025 12:32:50 -0400 Message-ID: <20251025163305.306787-1-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Now that generic BITS() is introduced, drop the local one. Signed-off-by: Yury Norov (NVIDIA) Reviewed-by: Linus Walleij --- drivers/mfd/db8500-prcmu-regs.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/mfd/db8500-prcmu-regs.h b/drivers/mfd/db8500-prcmu-reg= s.h index 25d2d5966211..c2bbf325efb9 100644 --- a/drivers/mfd/db8500-prcmu-regs.h +++ b/drivers/mfd/db8500-prcmu-regs.h @@ -12,9 +12,6 @@ #ifndef __DB8500_PRCMU_REGS_H #define __DB8500_PRCMU_REGS_H =20 -#undef BITS -#define BITS(_start, _end) ((BIT(_end) - BIT(_start)) + BIT(_end)) - #define PRCM_ACLK_MGT (0x004) #define PRCM_SVAMMCSPCLK_MGT (0x008) #define PRCM_SIAMMDSPCLK_MGT (0x00C) --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5756E303C96 for ; Sat, 25 Oct 2025 16:33:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409995; cv=none; b=GE0pSSGB7XNvo8RPFcqVtpjuAyUfbxCvIBXSXcZ7T9WkWoOOb1XHP9Mwj8SoRVbKTryRX4XwjHHgrpBrS186LMwWFgoxXkSd+YLowT73lxypDlvDhjy2yYu488gxdC4OeN/QF35CnFEBqDCzQuM5mQt0gajd1g25XzkZd9fgrv0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409995; c=relaxed/simple; bh=TQ6xv3dIaxpajiHEhlYy8yfOY1BsNMosBwcumiYnhcI=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FJQ3tpFcxYc4igDWIWlTiWiV/TJUUkY1FIAZeiIl9Z4zPH2ltC/egOcMKzYpaD3HwReUHJsiqQSwUnBezTocwvQ920xbrHN6X+hzun6SWTuzRsvkZ6VvB7jGVyEtR79ElV3uOJ9L7EJLJabBBRRE1qJKLTQ4plPBHcLdnOFGVt0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lKFrXs1e; arc=none smtp.client-ip=209.85.219.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lKFrXs1e" Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-87fc4d29301so14031946d6.2 for ; Sat, 25 Oct 2025 09:33:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761409992; x=1762014792; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=7/JFSnIjaD6DTDEOO1oZNxHniLLcLZti7jNstgpjRDc=; b=lKFrXs1e6e6lPHpHa9z4ZxbRt7T8MGKjd1J2bi015MzRQRc6KUZTrcFReIhQ51DXfo j89TGYltFajWRc24+geH9TyA6bNoFIb1ujVo9capuSlRu38d1GBkDEN14X0sTH5/qtKn CQSvNCtszJU/SWXaUmAhK+AkmA9JF/ORG1atSqLipkDAuTJ8EzUG/QSJnCVGs96ou5A9 pQNzOZMiOaN7O4ejI9mTZlqkM2Ssv0UCCene1k8ST7QgOFFV+3mmL/51cFTl/RIvQfRt Cr2rp4IQhD4JcaQyS4Vvt4x2aGc70GDuxibggMb5S5PE7AdzG3uAWMU6dG8/0lDmT43g BFNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761409992; x=1762014792; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7/JFSnIjaD6DTDEOO1oZNxHniLLcLZti7jNstgpjRDc=; b=s+K3YBSUYRkRr+Nh3SedRPecZm+f3h88Sld0QoTHLtd4o8VBJLYaVgpMyCJTK6EEyF vq0eVgga9yHZ9S32BAeaRh2YBr5p16v61yUjLMjPYg3kgQVSlEmEHdy1PDtuAt/vpfxy X4dpyGgi6P3QRaGMMvCEyZUjZHizM3srUrEEcY/Gp7MFQKBb0fwB2nvpldyeyoJla7V+ laxfcY2WW+Mt2ja1sZ3dpp4427A59qyxm0UOCeQHtokvg4wkK2abxSZL/X0JEjIRtCAm aNCKMLBICbtDgW+CjZCa9oJsMBoF2nhkY08BmcAGsj03J3cLKxYoShcmpGCsyERgvJk1 tBUg== X-Forwarded-Encrypted: i=1; AJvYcCXx9uyjyOtFzirzVLDgVkQ9ZFbUFPx4Gk+wgvLhQo8+w7raDa8DqJKClTVR4qJJzzboyRS66uq6ABtWLkI=@vger.kernel.org X-Gm-Message-State: AOJu0YwwbiQdkQslVFLV7qx88ftolgR5kRA2VNjM/2Q8I4TrjKVrztRF /7UGypA91tcHiOSLY2MHqRCWjuZk65zj8Rxn47hwlhq0Wj5gpkRvah0h X-Gm-Gg: ASbGnctEmmitRO8mWr9QfIqdnTG/tChwgp6/UnLksYQFNUqE8o/sIJnqCPWCOoy0fCp pgnVY2IJGx8MAhaJmE2YJkzZuQO6orOKEG6qOA1np9tNWZWikTHXyrxioPgQ3jX9izHW331+TuL NMqpF7ZX/fZii63vIDygSRTRio3sl6pdciab37hSe8R/rT++j3E+O4QxTmMuyk3GQtgRFt3ltQ7 sgPPTxmqrQdGr8e7CrSyel+9pr2wu9luIZKL2nbNJmc46yEvpwEy3l5k7RMJ2nnmEmrn1l9yFiT YLkG9QHA/Dd9qEfyyJNPOHyOuwCIuQkASh36A2NyW+F1pBpWjgwpqPcN/2968hynKJm31c1sN18 bubnQv64dAgQz7/CLOgzsxSQGWNJ3ziu+iEJ9eQYW0b5CgCiX3yDrCqfWWm7bbdbLLQcIyZVEza afEtzBjSM= X-Google-Smtp-Source: AGHT+IHVYDsqKWbYt2Nmb/p8bTfk7JqCLafoGcRUy2c7z6Z4BfX/omQyQkhSyRFtxDz8s1NdOAjCIw== X-Received: by 2002:a05:6214:248a:b0:7a3:b6ab:6f2 with SMTP id 6a1803df08f44-87c206612e2mr191871606d6.63.1761409991997; Sat, 25 Oct 2025 09:33:11 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc51e3809sm15261996d6.26.2025.10.25.09.33.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:33:10 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Walleij , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yury Norov , Rasmus Villemoes Subject: [PATCH 09/21] bits: generalize BITMAP_{FIRST,LAST}_WORD_MASK Date: Sat, 25 Oct 2025 12:32:51 -0400 Message-ID: <20251025163305.306787-2-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The macros are helpful in many non-bitmap places too. Move them from bitmap.h to bits.h. Signed-off-by: Yury Norov (NVIDIA) --- include/linux/bitmap.h | 7 +++++-- include/linux/bits.h | 8 ++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h index 595217b7a6e7..fbe2d12bceab 100644 --- a/include/linux/bitmap.h +++ b/include/linux/bitmap.h @@ -223,8 +223,11 @@ void bitmap_onto(unsigned long *dst, const unsigned lo= ng *orig, void bitmap_fold(unsigned long *dst, const unsigned long *orig, unsigned int sz, unsigned int nbits); =20 -#define BITMAP_FIRST_WORD_MASK(start) (~0UL << ((start) & (BITS_PER_LONG -= 1))) -#define BITMAP_LAST_WORD_MASK(nbits) (~0UL >> (-(nbits) & (BITS_PER_LONG -= 1))) +#define BITMAP_FIRST_WORD_MASK(start) LAST_BITS(start) +#define BITMAP_LAST_WORD_MASK(nbits) FIRST_BITS(nbits) + +#define BITMAP_FIRST_WORD_MASK_ULL(start) LAST_BITS(start) +#define BITMAP_LAST_WORD_MASK_ULL(nbits) FIRST_BITS(nbits) =20 #define bitmap_size(nbits) (ALIGN(nbits, BITS_PER_LONG) / BITS_PER_BYTE) =20 diff --git a/include/linux/bits.h b/include/linux/bits.h index c7c587e90e2d..0d2950b80a3b 100644 --- a/include/linux/bits.h +++ b/include/linux/bits.h @@ -5,6 +5,14 @@ #include #include =20 +/* Mask with first nbist set */ +#define FIRST_BITS(nbits) (~0UL >> (-(nbits) & (BITS_PER_LONG - 1))) +#define FIRST_BITS_ULL(nbits) (~0ULL >> (-(nbits) & (BITS_PER_LONG_LONG - = 1))) + +/* Mask with all bits before start unset */ +#define LAST_BITS(start) (~0UL << ((start) & (BITS_PER_LONG - 1))) +#define LAST_BITS_ULL(start) (~0ULL << ((start) & (BITS_PER_LONG_LONG - 1)= )) + #define BIT_MASK(nr) (UL(1) << ((nr) % BITS_PER_LONG)) #define BIT_WORD(nr) ((nr) / BITS_PER_LONG) #define BIT_ULL_MASK(nr) (ULL(1) << ((nr) % BITS_PER_LONG_LONG)) --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C56D2305943 for ; Sat, 25 Oct 2025 16:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409999; cv=none; b=T3/b0pZGWMzmUk7jtpTpmkpwpImB6+Dgjq4UZKX0dQW+zQcJ/ej1UnoD/zIYnwJU3WEuT2tpBckddgftlnjaZ4mGb7XfLKFoJPUGJ8dQEmTslHiTOQ/ux+RpDPQY/kgHn4DeoRhm0aaTuyYbTS9OdUzN7kGYzy/TQlPCT3VuX/U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761409999; c=relaxed/simple; bh=miSwCWAWlgSls2mz8C4vY/8512hTOCwNwE82bGQwr34=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ewyu/hn0DslIVasYstlBY+e3sSE6x7btxJGCJk3jj2lneYQzn5MdgQ8rs6va1XfIhY80IBoke7cBuAdsSJ4c4zgZGLhz5TRYO39FMz+TL1dx2aThRQOy8Ccznzy4AtFJrm3tzgGoI9LuY8dil0MBDJ1VJdXWkr3h1zXIc36qzdA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lNnPT9JD; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lNnPT9JD" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-89ec7919c71so136825685a.1 for ; Sat, 25 Oct 2025 09:33:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761409995; x=1762014795; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fhEz+tkYwuCSnU6LNYxfD5DkxTKdrSyEg2dThddkEgo=; b=lNnPT9JDvNdft6l0Uo98joHCwEP2lpuHXb1pBz28Fx4uY1P85iYzNuVFAQdW1533U2 t303A0RPZ4Xa1Susp82zygD1snjYmhzHFDDI6dFMAWWIgE6Fr2sWlT3ACXH0NdCcsIn+ mHL0+hlilKvqRybrNPWETkmCclOlF8Bw8eWcYOrbPABIyltdAqNEp/gr/WMcoz2CRx17 GAqQWUkMCXOdIlQVFV1NPXrdO0rWApm/suR/6Q4hZfP8R0T7m3dp3kW3Gj2sMV5miKe7 CTUWckFq12qH47pT2pZdMHkd5y72TNErDhQHaJZrloCGPYbWQc9iK/x2MF7LEeuTc6cS K+mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761409995; x=1762014795; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fhEz+tkYwuCSnU6LNYxfD5DkxTKdrSyEg2dThddkEgo=; b=oMuiZRC5ujwf1TDUxRx1mEA3VZsfvSwZ2fabfS/u5p8sW2JLOE5ObPw/noR+600m+z KnlOQWcxqwVn1SpyQIvCh4RxxEXoR7cWNyKIaWiHvcVkpTIsiPyYuaB4XwS1u42WbUN7 9QwDYROF5KiRy2aqsIkEfkl1aBSxXwiSRKz+7A7IGsi1LExJloX6TFny8/jvixojvjJW QjvZUe9nWKkUHnnn1Tp8AVkSqVjet+aPLSXn+qytwvQgByqPR5lCeVgoYY7ctEhkkoFf skCEBEdNTEUTaVW72S4mOIveu9nuvlb0eBeusg2cpyrEcyG1PSEjIktKVAYF1qd6n8fJ Y8TQ== X-Forwarded-Encrypted: i=1; AJvYcCWhmFDiPjhT3j6fTJx5Z/a46BSw08OM+ef85sFXE1mppJ/Az/eNAGc/mUaQqBmiztE7oUHT6FSBR0OHBms=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0JBUQBQMmM2V146ucncQ2uVOJ2XM/8YdtqmvoHkjigIQquElS yKu+XnFQo1SEMvrvaXQVbpgCEdcPPnuP4t3ouUQEh1g8NULvciu9USYG X-Gm-Gg: ASbGncsTeS/6OVujNEuRPmbjC0fCnroGu4ROALxvppOV5IYeWh+QD5P4fulNk64ie2s GFka+Ke4Fkh8FXc8Bntxy91CyU8btMwdvwFFNAYdtI3GzWDs4G4nS9CZbtqqlQ4pbUac7Yncofs 8Tw/dcW4e8vVTMSYDUYa5X1bi17b5+GSpL6F5lH0lA2GCMwM08aBT/vkaZ2pVY/cZxoWs9zYOoo M8vSXtYknnivxvHd+5k6WAV1Lp7K2TOWniDGxOmw8Op/Gf0qsoXvuUfdSZxToxlOwidHkKtREYR OkanTjJRAjxZIRPjllV7zmSNT6ZCnXz9JixFlhMn3C3vkOK7rUw4tpn4PSutZUSMJjLfLSQShu5 kHUmPyGrxh8lAi5KNO9DD2ek1W8pcnFSJR3RJ3g0a/l/ARRJCZjsk5NlGcucIuX2YOMAWZNTSBn ZFkKV8mXk= X-Google-Smtp-Source: AGHT+IFDvjrbgHR4c+YHa9gstK3rUAjMPa1JntDOFoEPIMpUO9JHPoIw8Cykn+I5mIOdA49QSX5xZw== X-Received: by 2002:a05:620a:aa01:b0:8a1:e059:cea0 with SMTP id af79cd13be357-8a1e059d294mr36247085a.84.1761409994607; Sat, 25 Oct 2025 09:33:14 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f254a297dsm174758885a.28.2025.10.25.09.33.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:33:13 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Walleij , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andi Shyti , linux-i2c@vger.kernel.org Cc: "Yury Norov (NVIDIA)" , Linus Torvalds Subject: [PATCH 10/21] i2c: nomadik: don't use GENMASK() Date: Sat, 25 Oct 2025 12:32:52 -0400 Message-ID: <20251025163305.306787-3-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(high, low) notation is confusing. Switch to BITS() or FIRST_BITS() where appropriate. Suggested-by: Linus Torvalds Link: https://lore.kernel.org/all/CAHk-=3DwhoOUsqPKb7OQwhQf9H_3=3D5sXGPJrDb= fQfwLB3Bi13tcQ@mail.gmail.com/ Signed-off-by: Yury Norov (NVIDIA) Reviewed-by: Linus Walleij --- drivers/i2c/busses/i2c-nomadik.c | 44 ++++++++++++++++---------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-noma= dik.c index 19b648fc094d..4c79ada5e1d4 100644 --- a/drivers/i2c/busses/i2c-nomadik.c +++ b/drivers/i2c/busses/i2c-nomadik.c @@ -53,9 +53,9 @@ =20 /* Control registers */ #define I2C_CR_PE BIT(0) /* Peripheral Enable */ -#define I2C_CR_OM GENMASK(2, 1) /* Operating mode */ +#define I2C_CR_OM BITS(1, 2) /* Operating mode */ #define I2C_CR_SAM BIT(3) /* Slave addressing mode */ -#define I2C_CR_SM GENMASK(5, 4) /* Speed mode */ +#define I2C_CR_SM BITS(4, 5) /* Speed mode */ #define I2C_CR_SGCM BIT(6) /* Slave general call mode */ #define I2C_CR_FTX BIT(7) /* Flush Transmit */ #define I2C_CR_FRX BIT(8) /* Flush Receive */ @@ -63,31 +63,31 @@ #define I2C_CR_DMA_RX_EN BIT(10) /* DMA Rx Enable */ #define I2C_CR_DMA_SLE BIT(11) /* DMA sync. logic enable */ #define I2C_CR_LM BIT(12) /* Loopback mode */ -#define I2C_CR_FON GENMASK(14, 13) /* Filtering on */ -#define I2C_CR_FS GENMASK(16, 15) /* Force stop enable */ +#define I2C_CR_FON BITS(13, 14) /* Filtering on */ +#define I2C_CR_FS BITS(15, 16) /* Force stop enable */ =20 /* Slave control register (SCR) */ -#define I2C_SCR_SLSU GENMASK(31, 16) /* Slave data setup time */ +#define I2C_SCR_SLSU BITS(16, 31) /* Slave data setup time */ =20 /* Master controller (MCR) register */ #define I2C_MCR_OP BIT(0) /* Operation */ -#define I2C_MCR_A7 GENMASK(7, 1) /* 7-bit address */ -#define I2C_MCR_EA10 GENMASK(10, 8) /* 10-bit Extended address */ +#define I2C_MCR_A7 BITS(1, 7) /* 7-bit address */ +#define I2C_MCR_EA10 BITS(8, 10) /* 10-bit Extended address */ #define I2C_MCR_SB BIT(11) /* Extended address */ -#define I2C_MCR_AM GENMASK(13, 12) /* Address type */ +#define I2C_MCR_AM BITS(12, 13) /* Address type */ #define I2C_MCR_STOP BIT(14) /* Stop condition */ -#define I2C_MCR_LENGTH GENMASK(25, 15) /* Transaction length */ +#define I2C_MCR_LENGTH BITS(15, 25) /* Transaction length */ =20 /* Status register (SR) */ -#define I2C_SR_OP GENMASK(1, 0) /* Operation */ -#define I2C_SR_STATUS GENMASK(3, 2) /* controller status */ -#define I2C_SR_CAUSE GENMASK(6, 4) /* Abort cause */ -#define I2C_SR_TYPE GENMASK(8, 7) /* Receive type */ -#define I2C_SR_LENGTH GENMASK(19, 9) /* Transfer length */ +#define I2C_SR_OP BITS(0, 1) /* Operation */ +#define I2C_SR_STATUS BITS(2, 3) /* controller status */ +#define I2C_SR_CAUSE BITS(4, 6) /* Abort cause */ +#define I2C_SR_TYPE BITS(7, 8) /* Receive type */ +#define I2C_SR_LENGTH BITS(9, 19) /* Transfer length */ =20 /* Baud-rate counter register (BRCR) */ -#define I2C_BRCR_BRCNT1 GENMASK(31, 16) /* Baud-rate counter 1 */ -#define I2C_BRCR_BRCNT2 GENMASK(15, 0) /* Baud-rate counter 2 */ +#define I2C_BRCR_BRCNT2 FIRST_BITS(16) /* Baud-rate counter 2 */ +#define I2C_BRCR_BRCNT1 BITS(16, 31) /* Baud-rate counter 1 */ =20 /* Interrupt mask set/clear (IMSCR) bits */ #define I2C_IT_TXFE BIT(0) @@ -339,7 +339,7 @@ static int init_hw(struct nmk_i2c_dev *priv) #define DEFAULT_I2C_REG_CR (FIELD_PREP(I2C_CR_OM, I2C_OM_MASTER) | I2C_CR_= PE) =20 /* grab top three bits from extended I2C addresses */ -#define ADR_3MSB_BITS GENMASK(9, 7) +#define ADR_3MSB_BITS BITS(7, 9) =20 /** * load_i2c_mcr_reg() - load the MCR register @@ -1028,11 +1028,11 @@ static void nmk_i2c_of_probe(struct device_node *np, } =20 static const unsigned int nmk_i2c_eyeq5_masks[] =3D { - GENMASK(5, 4), - GENMASK(7, 6), - GENMASK(9, 8), - GENMASK(11, 10), - GENMASK(13, 12), + BITS(4, 5), + BITS(6, 7), + BITS(8, 9), + BITS(10, 11), + BITS(12, 13), }; =20 static int nmk_i2c_eyeq5_probe(struct nmk_i2c_dev *priv) --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7FCE306D48 for ; Sat, 25 Oct 2025 16:33:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410001; cv=none; b=ivIcIXVd7aO4hGXdY3fS1nXYiWsTDw+NGHK3wU1j9J1CVL7/3XXLHJKWfDNSMq2ULGolZy9AVQ3ukFWjTXmrQYRSYX0aeOWa1dPaeBP4unKAU5ccZ9Vokk4y9VOCBUPJQpEBoRsbHej9ikgaXp5FxPXjrtcL+iVLGzV/O2ULLUc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410001; c=relaxed/simple; bh=iv3iCCSDVeRbyipC1ke5q3yTI1qFQp4/PoyLN2PjHKI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YBxcyjA9J7NuAjnb/vNjvqO/haE88YbFMqrfU2vdG/HXNGFELToNkQOqIAq8JlGv4J/mRAJRVOk9tdghkr5PZ4IrQfFqL9xWYok2r6MIky2JSN1sjM9PVfqjsnYAh7YRdDPlHFHecam4G6eb/Nmdz5R3TOqntw4VBzWoE4WU6Uw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TyazQo4e; arc=none smtp.client-ip=209.85.160.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TyazQo4e" Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-4e89ffd95b9so35637081cf.0 for ; Sat, 25 Oct 2025 09:33:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761409997; x=1762014797; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pQlnwek1lWpij8LeOBWh+sxDT7KmBEOhz8ZE1R1F1kI=; b=TyazQo4eXQpDlEchskrTFZdIOaTy8wv/yf77Ss+z9m8I9H1nHQcjTQ3Jv73z+B0Nb9 R8Dkg+/E5n3Q9FoyzJa0csh2Clye8+VWjMxN6DeKZInVDGQVMAzhlP8Sj0dnB4TRd2Ua 7MIP/ZErduqjWs2gK2pgNJrndI/dP/Wi2L0TAqL2UN9AsSuqCZ8y/2VkIdpzJYurpOf2 w8MLPLGJ0YTkrnSu9nj+pADysISf6QZnLlsjfUZkHvBdWDAGaMT9F6eeSiFQIisChYQQ YPpMX3TDMb+udrv1wcikNDy2dIcatt47WFDRaahBMbmH6+n/N9OVba4c6nl7HzB7xura u/Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761409997; x=1762014797; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pQlnwek1lWpij8LeOBWh+sxDT7KmBEOhz8ZE1R1F1kI=; b=JblCbPWHv564SQ3Gp0GiFi47WzOcS09pORveCbN32kFZPqpPwxMKkkTmGqHmWS0IfM cGkkeQxS1IaC2j8Si/4U5vpDhAnsilHL09LYdlL4x+MDy5FtTzD1OBmLgUUL5KiYUCzh IfriDkFbv/dqz73Ls6NretENlxEvPY1MX6L7gk7bETJiEjKrXBLF30qc9pzk/BB8Kqae 9MvinjOM2+Yl86oxOLKkO5gcicq8WUQgkhbzXJVkOM4GNCvU9Lc7dDH/0eciUsaRSaud L6cOV7tqyvNyDxx/Bo9PVqdeFX1vK17ZSKi/VspRSKM0U+CsFnTl7gl5L6ldN7tj46T/ 5YRw== X-Forwarded-Encrypted: i=1; AJvYcCXmN1Yoaofi0hvOxJK2W611bLY3NJBn71zlmkiJUs5Bn8BNW7hDJZF7mRSOOaIKKliqHXbpkkEYep6QSaI=@vger.kernel.org X-Gm-Message-State: AOJu0YzTN15fZ6Q4spWy4TxY1AoD2OJEOc3AV+GWoETgqCHxb5IisVK+ gr1FykgocDXx6ypQ2kiI1DrkFjZAV82AUfokcN36METmm0dWGZxYlhf7 X-Gm-Gg: ASbGncu86aK1opyJ4l+WanmqvjvI9dSSG4KvQHn7kr4cHKeIybeoLczKMSJzW01CnEi MNa5v+t/cKG+xr5iSY22j7/vhsKmUIpPUU2Y5VO607+oT+i3ksXlaTXxngu+RTHQ+/TNsRJIQ7x Zy1VPxIsOGB1tifjV+AYobXLrvX8CiaUMnS68nrEw2iBs5LJcxH7V9xjvQqDRJDFGRxyrvyTTa6 qcafRBVq9hE6FeXHpeYth4VbdnEXXzW480qwdkGt+kpqEdCZWxF5R2M/wL+mMbIUR82CohKoloU jSwEdcgabZLuaR+koclSAXlQIQXYAYDFHwR0UUMeOYgNzRXW4cSUWVZg1c7zglhK5X5w/oWWjT/ UzDuQG/b361WwTEipMtDypT68COha5JfeCLm71vKrS07rSczmf8PirBOOSc0CuQy2IjbRN1Ri X-Google-Smtp-Source: AGHT+IHyRdZCFKENEK5U2sVSqsYLQGnrThog0TUtBDXhz5Rjdgg8+4ZbO+vQpnHhnn4XFJ14+JpZIQ== X-Received: by 2002:a05:622a:1817:b0:4b5:e8ae:2c4f with SMTP id d75a77b69052e-4eb943824a5mr76637061cf.51.1761409997366; Sat, 25 Oct 2025 09:33:17 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4eba37b96d0sm15170181cf.6.2025.10.25.09.33.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:33:16 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Walleij , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sandy Huang , =?UTF-8?q?Heiko=20St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shreeya Patel , Mauro Carvalho Chehab , Jaehoon Chung , Ulf Hansson , Nicolas Frattaroli , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , "Yury Norov (NVIDIA)" , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-media@vger.kernel.org, kernel@collabora.com, linux-mmc@vger.kernel.org, linux-sound@vger.kernel.org Cc: Linus Torvalds Subject: [PATCH 11/21] drivers: don't use GENMASK() in FIELD_PREP_WM16() Date: Sat, 25 Oct 2025 12:32:53 -0400 Message-ID: <20251025163305.306787-4-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Recently added FIELD_PREP_WM16() in a few places uses GENMASK. It's confusing and may mislead readers. Switch to BITS() or FIRST_BITS() as appropriate. Suggested-by: Linus Torvalds Link: https://lore.kernel.org/all/CAHk-=3DwhoOUsqPKb7OQwhQf9H_3=3D5sXGPJrDb= fQfwLB3Bi13tcQ@mail.gmail.com/ Signed-off-by: Yury Norov (NVIDIA) --- drivers/gpu/drm/rockchip/rockchip_lvds.h | 2 +- drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 4 ++-- drivers/media/platform/synopsys/hdmirx/snps_hdmirx.h | 4 ++-- drivers/mmc/host/dw_mmc-rockchip.c | 4 ++-- drivers/soc/rockchip/grf.c | 4 ++-- sound/soc/rockchip/rockchip_i2s_tdm.h | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.h b/drivers/gpu/drm/roc= kchip/rockchip_lvds.h index 2d92447d819b..e79e6031be59 100644 --- a/drivers/gpu/drm/rockchip/rockchip_lvds.h +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.h @@ -115,7 +115,7 @@ #define PX30_LVDS_INVERT_DCLK(val) FIELD_PREP_WM16(BIT(5), (val)) =20 #define PX30_LVDS_GRF_PD_VO_CON1 0x438 -#define PX30_LVDS_FORMAT(val) FIELD_PREP_WM16(GENMASK(14, 13), (val)) +#define PX30_LVDS_FORMAT(val) FIELD_PREP_WM16(BITS(13, 14), (val)) #define PX30_LVDS_MODE_EN(val) FIELD_PREP_WM16(BIT(12), (val)) #define PX30_LVDS_MSBSEL(val) FIELD_PREP_WM16(BIT(11), (val)) #define PX30_LVDS_P2S_EN(val) FIELD_PREP_WM16(BIT(6), (val)) diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm= /rockchip/rockchip_vop2_reg.c index 38c49030c7ab..438fea5f6f6d 100644 --- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c +++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c @@ -1698,7 +1698,7 @@ static unsigned long rk3588_set_intf_mux(struct vop2_= video_port *vp, int id, u32 val =3D rk3588_get_hdmi_pol(polflags); regmap_write(vop2->vop_grf, RK3588_GRF_VOP_CON2, FIELD_PREP_WM16(BIT(1),= 1)); regmap_write(vop2->vo1_grf, RK3588_GRF_VO1_CON0, - FIELD_PREP_WM16(GENMASK(6, 5), val)); + FIELD_PREP_WM16(BITS(5, 6), val)); break; case ROCKCHIP_VOP2_EP_HDMI1: div &=3D ~RK3588_DSP_IF_EDP_HDMI1_DCLK_DIV; @@ -1711,7 +1711,7 @@ static unsigned long rk3588_set_intf_mux(struct vop2_= video_port *vp, int id, u32 val =3D rk3588_get_hdmi_pol(polflags); regmap_write(vop2->vop_grf, RK3588_GRF_VOP_CON2, FIELD_PREP_WM16(BIT(4),= 1)); regmap_write(vop2->vo1_grf, RK3588_GRF_VO1_CON0, - FIELD_PREP_WM16(GENMASK(8, 7), val)); + FIELD_PREP_WM16(BITS(7, 8), val)); break; case ROCKCHIP_VOP2_EP_EDP0: div &=3D ~RK3588_DSP_IF_EDP_HDMI0_DCLK_DIV; diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.h b/drivers= /media/platform/synopsys/hdmirx/snps_hdmirx.h index b13f58e31944..14df3f53ff8f 100644 --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.h +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.h @@ -12,8 +12,8 @@ #include #include =20 -#define UPDATE(x, h, l) FIELD_PREP(GENMASK((h), (l)), (x)) -#define HIWORD_UPDATE(v, h, l) FIELD_PREP_WM16(GENMASK((h), (l)), (v)) +#define UPDATE(x, h, l) FIELD_PREP(BITS((l), (h)), (x)) +#define HIWORD_UPDATE(v, h, l) FIELD_PREP_WM16(BITS((l), (h)), (v)) =20 /* SYS_GRF */ #define SYS_GRF_SOC_CON1 0x0304 diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-r= ockchip.c index 82dd906bb002..7fac1a7281bf 100644 --- a/drivers/mmc/host/dw_mmc-rockchip.c +++ b/drivers/mmc/host/dw_mmc-rockchip.c @@ -148,10 +148,10 @@ static int rockchip_mmc_set_internal_phase(struct dw_= mci *host, bool sample, int =20 if (sample) mci_writel(host, TIMING_CON1, - FIELD_PREP_WM16(GENMASK(11, 1), raw_value)); + FIELD_PREP_WM16(BITS(1, 11), raw_value)); else mci_writel(host, TIMING_CON0, - FIELD_PREP_WM16(GENMASK(11, 1), raw_value)); + FIELD_PREP_WM16(BITS(1, 11), raw_value)); =20 dev_dbg(host->dev, "set %s_phase(%d) delay_nums=3D%u actual_degrees=3D%d\= n", sample ? "sample" : "drv", degrees, delay_num, diff --git a/drivers/soc/rockchip/grf.c b/drivers/soc/rockchip/grf.c index 344870da7675..89fd4a4c69eb 100644 --- a/drivers/soc/rockchip/grf.c +++ b/drivers/soc/rockchip/grf.c @@ -125,8 +125,8 @@ static const struct rockchip_grf_info rk3566_pipegrf __= initconst =3D { #define RK3576_SYSGRF_SOC_CON1 0x0004 =20 static const struct rockchip_grf_value rk3576_defaults_sys_grf[] __initcon= st =3D { - { "i3c0 weakpull", RK3576_SYSGRF_SOC_CON1, FIELD_PREP_WM16_CONST(GENMASK(= 7, 6), 3) }, - { "i3c1 weakpull", RK3576_SYSGRF_SOC_CON1, FIELD_PREP_WM16_CONST(GENMASK(= 9, 8), 3) }, + { "i3c0 weakpull", RK3576_SYSGRF_SOC_CON1, FIELD_PREP_WM16_CONST(BITS(6, = 7), 3) }, + { "i3c1 weakpull", RK3576_SYSGRF_SOC_CON1, FIELD_PREP_WM16_CONST(BITS(8, = 9), 3) }, }; =20 static const struct rockchip_grf_info rk3576_sysgrf __initconst =3D { diff --git a/sound/soc/rockchip/rockchip_i2s_tdm.h b/sound/soc/rockchip/roc= kchip_i2s_tdm.h index 0171e05ee886..eee6db372ee7 100644 --- a/sound/soc/rockchip/rockchip_i2s_tdm.h +++ b/sound/soc/rockchip/rockchip_i2s_tdm.h @@ -287,7 +287,7 @@ enum { #define I2S_TDM_RXCR (0x0034) #define I2S_CLKDIV (0x0038) =20 -#define HIWORD_UPDATE(v, h, l) (FIELD_PREP_WM16_CONST(GENMASK((h), (l)), (= v))) +#define HIWORD_UPDATE(v, h, l) (FIELD_PREP_WM16_CONST(BITS((l), (h)), (v))) =20 /* PX30 GRF CONFIGS */ #define PX30_I2S0_CLK_IN_SRC_FROM_TX HIWORD_UPDATE(1, 13, 12) --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C63730ACE1 for ; Sat, 25 Oct 2025 16:33:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410005; cv=none; b=GSZEJ/u2ZMSZxPZOszOb6kQG5nPAm8PH0NByEE1vxiTJFv7TzopvrGB+AY20gudq51emoIx5/reFXa4tVKsN6rpJE0CVErNXQ35ghmF6Lp2Q+/DBzA6ZAHQcyS53gao7RVOj2zqsbY9GmwG3kLHw9RFPevlKH+RqQVwsQuLw7pY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410005; c=relaxed/simple; bh=/FqtaDoZDiEkgJ775gUA1lnv4tNmr3AkN5xeLieFs6M=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H9RMlC6Nn3/8y4TLdhdAMvpHfhc/ySVFbAIzPeizDShjcn3apitceLGD3NL2iHu9XvbobGYVvhoBdOZDvECdyyp/cECq9bpPLx0bljMzm34JjFrlzd0e/ykCMsmcMFX0KQVb7xCAJVwIyLQZr0R4few0W8QvKaMaKcr/FvMd3fY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d2dLhgpi; arc=none smtp.client-ip=209.85.160.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d2dLhgpi" Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-4e3117ea7a2so36144441cf.2 for ; Sat, 25 Oct 2025 09:33:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410000; x=1762014800; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=fSxoEFGAAolVhXFywte18CkthEXwJuFOJ2hIbnLSDSg=; b=d2dLhgpik+l7LTkQEQ+GQEuerIDG704GlZnNJiYr5Lltuvmu6ClmZ0i49K7lVePRjb yYOrB6ELEk5fsBbgTvnFXDQOql+60pWyQIqVh13mN1xoBdaNMWLUWXraLyoCIbOwP9+B zcYBaGe04CllApiUTNtZJYrTl3AvtdegUqh5nY2JHpE36NElmiz8QFXg6T9Q98pkpi/h 1dU3WoMPsgJpl0jAFfEuTQ7+hwLjQv2Ssc5HZ1MEk6/6Y5w6B3f9wsZRBoVBuZIamsKo 1Pge2MeDO8g4xgal7zcQA5gasssL+qQCe/uu2sNSN7nwW7iuB4qakoE42+NsPO9kcDw6 YbdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410000; x=1762014800; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fSxoEFGAAolVhXFywte18CkthEXwJuFOJ2hIbnLSDSg=; b=f+9NFF1WH49mQdtUXHAtA8iaeZyia7lzPsAEGZ5d3WttRYDLAQoY2Jj08kU9SXdXIm 4hFPcAY0a6q17j1jWmmqjksy0JFCiIIZO9dC/E0pVrDUb/G3zx2HQbw9aWp3AaL7/YFo yBVOIoHuwFuWANSn176aE+FRc/ygAaMsmwW4X1FZkkQXvu0Jfka29itDYGZLyu4hwIxY fsUd1bsCIYWKMtgI9Ak02/tGg1Y0zPe4bogUxXDIMzm6XmvbqfOJ/rSke1a4qLV0hl1j 0AJHw2a627QEGMhVYnp1os+YzNHBe3n5F67vB2Gj728L+CmaxspDZsJGrr/ngmW+kGu/ HeBw== X-Forwarded-Encrypted: i=1; AJvYcCVUgqXMIFDv5tWzNPorP262Y+5bQaTn5AyvfdA2fsdZIZh0By/fBtQ+3JkISrOzIGRDZdbE42VlihTkbCs=@vger.kernel.org X-Gm-Message-State: AOJu0YzxzGHirA11JwTFTiDdEcjBDoucmvxStF8BEF9TnB01yB/G+z/K iIQJ/0w94SorTUiUtuZmiaqzyj9Lgdy6RxqzSeaQPHTtNqXCaiZCflrH X-Gm-Gg: ASbGnct/7lOxce5i4lUIvNGdASoKx5T5Mf8lk1aMIlKLhHQZlH2kmyUTCtpC7Z9cHFf V1zrbrlR7r0Tqd1R6jN95bn+W0rDYvHId3da3w8CyAw4+HhG3jli1EaBqUKopnx69H607MPzfn3 N1y0A1IEHAHmEFVXFkT/sVPE7PFcQ/m7IwqiVO5pPEsmZiqDnKIce8xXaV2yNWSbjlhDykDcrAn Nf9ogSOPaUHPC6h35Y6Wu6lpRytrdWoQ1JFHevfBWzrfUc8LeUx/M4Fmig/pGDoy15+19b+EIY4 r6RfiCkUMs8hXvlvW+qnB2SZm+Nm3s5vqphTg15HKARb86qRhDkqZPncR0j9PTyrhAsAdJ/YPuX 6hxZ+xrMMagFZlrQA+h9vCa8PD+ZviJ7vOoAg6GMK0k+en/IYN4KZDqYYNYLUKr8gHqhvWFGv X-Google-Smtp-Source: AGHT+IFwY9Y3BAwsQLIpG2h0HJ31eBt8/+nMYp6HoC42JMSxN357FYrFvS1io5FJ90lWGu4fEjCzyg== X-Received: by 2002:a05:622a:4d48:b0:4eb:a915:c213 with SMTP id d75a77b69052e-4eba915c5a0mr20033121cf.65.1761410000104; Sat, 25 Oct 2025 09:33:20 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc48ca5bcsm16552366d6.13.2025.10.25.09.33.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:33:19 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Walleij , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yury Norov , Rasmus Villemoes , Andrew Morton Subject: [PATCH 12/21] bitmap: don't use GENMASK() Date: Sat, 25 Oct 2025 12:32:54 -0400 Message-ID: <20251025163305.306787-5-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(high, low) notation is confusing. Switch to a more natural BITS(low, high) mask generator, or FIRST/LAST_BITS() as appropriate. Signed-off-by: Yury Norov (NVIDIA) --- include/linux/bitmap.h | 4 ++-- include/linux/find.h | 34 +++++++++++++++++----------------- lib/bitmap.c | 2 +- lib/test_bitmap.c | 14 +++++++------- 4 files changed, 27 insertions(+), 27 deletions(-) diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h index fbe2d12bceab..3bed29f1780b 100644 --- a/include/linux/bitmap.h +++ b/include/linux/bitmap.h @@ -473,7 +473,7 @@ void bitmap_set(unsigned long *map, unsigned int start,= unsigned int nbits) if (__builtin_constant_p(nbits) && nbits =3D=3D 1) __set_bit(start, map); else if (small_const_nbits(start + nbits)) - *map |=3D GENMASK(start + nbits - 1, start); + *map |=3D BITS(start, start + nbits - 1); else if (__builtin_constant_p(start & BITMAP_MEM_MASK) && IS_ALIGNED(start, BITMAP_MEM_ALIGNMENT) && __builtin_constant_p(nbits & BITMAP_MEM_MASK) && @@ -489,7 +489,7 @@ void bitmap_clear(unsigned long *map, unsigned int star= t, unsigned int nbits) if (__builtin_constant_p(nbits) && nbits =3D=3D 1) __clear_bit(start, map); else if (small_const_nbits(start + nbits)) - *map &=3D ~GENMASK(start + nbits - 1, start); + *map &=3D ~BITS(start, start + nbits - 1); else if (__builtin_constant_p(start & BITMAP_MEM_MASK) && IS_ALIGNED(start, BITMAP_MEM_ALIGNMENT) && __builtin_constant_p(nbits & BITMAP_MEM_MASK) && diff --git a/include/linux/find.h b/include/linux/find.h index 9d720ad92bc1..24d7266fd02b 100644 --- a/include/linux/find.h +++ b/include/linux/find.h @@ -66,7 +66,7 @@ unsigned long find_next_bit(const unsigned long *addr, un= signed long size, if (unlikely(offset >=3D size)) return size; =20 - val =3D *addr & GENMASK(size - 1, offset); + val =3D *addr & BITS(offset, size - 1); return val ? __ffs(val) : size; } =20 @@ -96,7 +96,7 @@ unsigned long find_next_and_bit(const unsigned long *addr= 1, if (unlikely(offset >=3D size)) return size; =20 - val =3D *addr1 & *addr2 & GENMASK(size - 1, offset); + val =3D *addr1 & *addr2 & BITS(offset, size - 1); return val ? __ffs(val) : size; } =20 @@ -127,7 +127,7 @@ unsigned long find_next_andnot_bit(const unsigned long = *addr1, if (unlikely(offset >=3D size)) return size; =20 - val =3D *addr1 & ~*addr2 & GENMASK(size - 1, offset); + val =3D *addr1 & ~*addr2 & BITS(offset, size - 1); return val ? __ffs(val) : size; } =20 @@ -157,7 +157,7 @@ unsigned long find_next_or_bit(const unsigned long *add= r1, if (unlikely(offset >=3D size)) return size; =20 - val =3D (*addr1 | *addr2) & GENMASK(size - 1, offset); + val =3D (*addr1 | *addr2) & BITS(offset, size - 1); return val ? __ffs(val) : size; } =20 @@ -185,7 +185,7 @@ unsigned long find_next_zero_bit(const unsigned long *a= ddr, unsigned long size, if (unlikely(offset >=3D size)) return size; =20 - val =3D *addr | ~GENMASK(size - 1, offset); + val =3D *addr | ~BITS(offset, size - 1); return val =3D=3D ~0UL ? size : ffz(val); } =20 @@ -206,7 +206,7 @@ static __always_inline unsigned long find_first_bit(const unsigned long *addr, unsigned long size) { if (small_const_nbits(size)) { - unsigned long val =3D *addr & GENMASK(size - 1, 0); + unsigned long val =3D *addr & FIRST_BITS(size); =20 return val ? __ffs(val) : size; } @@ -235,7 +235,7 @@ unsigned long find_nth_bit(const unsigned long *addr, u= nsigned long size, unsign return size; =20 if (small_const_nbits(size)) { - unsigned long val =3D *addr & GENMASK(size - 1, 0); + unsigned long val =3D *addr & FIRST_BITS(size); =20 return val ? fns(val, n) : size; } @@ -261,7 +261,7 @@ unsigned long find_nth_and_bit(const unsigned long *add= r1, const unsigned long * return size; =20 if (small_const_nbits(size)) { - unsigned long val =3D *addr1 & *addr2 & GENMASK(size - 1, 0); + unsigned long val =3D *addr1 & *addr2 & FIRST_BITS(size); =20 return val ? fns(val, n) : size; } @@ -291,7 +291,7 @@ unsigned long find_nth_and_andnot_bit(const unsigned lo= ng *addr1, return size; =20 if (small_const_nbits(size)) { - unsigned long val =3D *addr1 & *addr2 & (~*addr3) & GENMASK(size - 1, 0= ); + unsigned long val =3D *addr1 & *addr2 & (~*addr3) & FIRST_BITS(size); =20 return val ? fns(val, n) : size; } @@ -315,7 +315,7 @@ unsigned long find_first_and_bit(const unsigned long *a= ddr1, unsigned long size) { if (small_const_nbits(size)) { - unsigned long val =3D *addr1 & *addr2 & GENMASK(size - 1, 0); + unsigned long val =3D *addr1 & *addr2 & FIRST_BITS(size); =20 return val ? __ffs(val) : size; } @@ -339,7 +339,7 @@ unsigned long find_first_andnot_bit(const unsigned long= *addr1, unsigned long size) { if (small_const_nbits(size)) { - unsigned long val =3D *addr1 & (~*addr2) & GENMASK(size - 1, 0); + unsigned long val =3D *addr1 & (~*addr2) & FIRST_BITS(size); =20 return val ? __ffs(val) : size; } @@ -364,7 +364,7 @@ unsigned long find_first_and_and_bit(const unsigned lon= g *addr1, unsigned long size) { if (small_const_nbits(size)) { - unsigned long val =3D *addr1 & *addr2 & *addr3 & GENMASK(size - 1, 0); + unsigned long val =3D *addr1 & *addr2 & *addr3 & FIRST_BITS(size); =20 return val ? __ffs(val) : size; } @@ -385,7 +385,7 @@ static __always_inline unsigned long find_first_zero_bit(const unsigned long *addr, unsigned long= size) { if (small_const_nbits(size)) { - unsigned long val =3D *addr | ~GENMASK(size - 1, 0); + unsigned long val =3D *addr | ~FIRST_BITS(size); =20 return val =3D=3D ~0UL ? size : ffz(val); } @@ -406,7 +406,7 @@ static __always_inline unsigned long find_last_bit(const unsigned long *addr, unsigned long size) { if (small_const_nbits(size)) { - unsigned long val =3D *addr & GENMASK(size - 1, 0); + unsigned long val =3D *addr & FIRST_BITS(size); =20 return val ? __fls(val) : size; } @@ -537,7 +537,7 @@ unsigned long find_next_zero_bit_le(const void *addr, u= nsigned if (unlikely(offset >=3D size)) return size; =20 - val =3D swab(val) | ~GENMASK(size - 1, offset); + val =3D swab(val) | ~BITS(offset, size - 1); return val =3D=3D ~0UL ? size : ffz(val); } =20 @@ -550,7 +550,7 @@ static __always_inline unsigned long find_first_zero_bit_le(const void *addr, unsigned long size) { if (small_const_nbits(size)) { - unsigned long val =3D swab(*(const unsigned long *)addr) | ~GENMASK(size= - 1, 0); + unsigned long val =3D swab(*(const unsigned long *)addr) | ~FIRST_BITS(s= ize); =20 return val =3D=3D ~0UL ? size : ffz(val); } @@ -570,7 +570,7 @@ unsigned long find_next_bit_le(const void *addr, unsign= ed if (unlikely(offset >=3D size)) return size; =20 - val =3D swab(val) & GENMASK(size - 1, offset); + val =3D swab(val) & BITS(offset, size - 1); return val ? __ffs(val) : size; } =20 diff --git a/lib/bitmap.c b/lib/bitmap.c index b97692854966..ec11cc36624e 100644 --- a/lib/bitmap.c +++ b/lib/bitmap.c @@ -876,7 +876,7 @@ void bitmap_to_arr64(u64 *buf, const unsigned long *bit= map, unsigned int nbits) =20 /* Clear tail bits in the last element of array beyond nbits. */ if (nbits % 64) - buf[-1] &=3D GENMASK_ULL((nbits - 1) % 64, 0); + buf[-1] &=3D FIRST_BITS_ULL(nbits); } EXPORT_SYMBOL(bitmap_to_arr64); #endif diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c index c83829ef557f..c198fc7a66d2 100644 --- a/lib/test_bitmap.c +++ b/lib/test_bitmap.c @@ -692,10 +692,10 @@ static void __init test_bitmap_arr64(void) } =20 if ((nbits % 64) && - (arr[(nbits - 1) / 64] & ~GENMASK_ULL((nbits - 1) % 64, 0))) { + (arr[(nbits - 1) / 64] & ~FIRST_BITS_ULL(nbits))) { pr_err("bitmap_to_arr64(nbits =3D=3D %d): tail is not safely cleared: 0= x%016llx (must be 0x%016llx)\n", nbits, arr[(nbits - 1) / 64], - GENMASK_ULL((nbits - 1) % 64, 0)); + FIRST_BITS_ULL(nbits)); failed_tests++; } =20 @@ -1217,7 +1217,7 @@ static void __init test_bitmap_const_eval(void) * in runtime. */ =20 - /* Equals to `unsigned long bitmap[1] =3D { GENMASK(6, 5), }` */ + /* Equals to `unsigned long bitmap[1] =3D { BITS(5, 6), }` */ bitmap_clear(bitmap, 0, BITS_PER_LONG); if (!test_bit(7, bitmap)) bitmap_set(bitmap, 5, 2); @@ -1229,9 +1229,9 @@ static void __init test_bitmap_const_eval(void) /* Equals to `unsigned long var =3D BIT(25)` */ var |=3D BIT(25); if (var & BIT(0)) - var ^=3D GENMASK(9, 6); + var ^=3D BITS(6, 9); =20 - /* __const_hweight<32|64>(GENMASK(6, 5)) =3D=3D 2 */ + /* __const_hweight<32|64>(BITS(5, 6)) =3D=3D 2 */ res =3D bitmap_weight(bitmap, 20); BUILD_BUG_ON(!__builtin_constant_p(res)); BUILD_BUG_ON(res !=3D 2); @@ -1241,8 +1241,8 @@ static void __init test_bitmap_const_eval(void) BUILD_BUG_ON(!__builtin_constant_p(res)); BUILD_BUG_ON(!res); =20 - /* BIT(2) & GENMASK(14, 8) =3D=3D 0 */ - res =3D initvar & GENMASK(14, 8); + /* BIT(2) & BITS(8, 14) =3D=3D 0 */ + res =3D initvar & BITS(8, 14); BUILD_BUG_ON(!__builtin_constant_p(res)); BUILD_BUG_ON(res); =20 --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28CFD30AAD2 for ; Sat, 25 Oct 2025 16:33:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410004; cv=none; b=YL/2jIvTyWuKfITZ8354xOW1txjG/ZVanPmrHHnpBYBhSnUuTcH1UxSZUIAbte9oYdmu9BI/2p6SWqnvztaI9Ioi68mL/UT6yMFak8un3k4OzVFPsI0NpE3ZWwRO6RBkhaTA+03/Gm/C/PLu2R0MzcHf9o7w5nyXEJqqlDbhXV0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410004; c=relaxed/simple; bh=XhV4d6vVAyK94tJmHv/pzX7uso4PaLhZOAOHlwMKMkY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t7xJRRCAFz812ogmrxdAPr8Oyei2fQTkapsf8KYHyZrbZgjv37BOkAd9c5jDD1/8OmTSJYxj+u9gMK4UdbM7qf230lgD4wltkCex52cIcQGo5prBKfew+EYHGKYpSts59yxY7G4EzhZxn9FEDoKMkC22PxxoUCyMtQADVMQMyU0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=THIp+Tct; arc=none smtp.client-ip=209.85.160.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="THIp+Tct" Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-4e891a8980bso31441221cf.1 for ; Sat, 25 Oct 2025 09:33:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410002; x=1762014802; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ehiUcUt6iLCen11Ncs28J2yHpJNhGkVkWPyWS3jNXxY=; b=THIp+TctYck+HX5Byp5ZPzTzj5Sg8X2gcojiJOtbOEIYmT24sPfsm3qZ1pSbF/4fXl 8sqLi+qUSzaUgf69MUNmLz+mZpp6f253cH2n+x/QF4j2vvyUJ3cY1FBNs8HqeH/ECDUx OAV1gxrjRZM9pPU0StleSU/uTsDhAGvHjdYoQHcCjIRJd01DtdKqWXhvYjvlYHPeGlwg ObV49OEQh/CLsodFyrJYcYb/U3ckEC/YcEYnnIhIYjEA8Z/xdStHSx/QxRZQdHG/502I cQ4/svw9Mto42wUDFJvktG1T7q4aWSYJ5mRTPkf0ragBR9KuwfIkQdaVGDrlN0BZX49r k7Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410002; x=1762014802; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ehiUcUt6iLCen11Ncs28J2yHpJNhGkVkWPyWS3jNXxY=; b=QICAewdiOK+hNDp+4Zw5/tytjf5q3PJEtBZLRzAl9887k7i3shDY+QVP6wl9vMEoGb EntVrGbfpffT3Qv78IX/UHyI3sWdCyHuBhumB4Txso5gP2UDgc+Qj2XYyWjzQYUeSxJ/ UERObiDOP/mgRUnql+pGVqTlR7pwzGwWSGtRMv/eckiqG9hT5WecQPQ+iL/4+UBc1ahq ZFnc9/y6JY8ZWcOwJOZDj8kU1CIFdHgZVq6pEM9xu718fRqByP81GdVzMf02sxUtewa1 cx/DnG5WdJVv3dNJxlGfh29zTGDbQXZQiXksZEMc/Q+ysHXjaz1FXVvhKomcCAOlfk44 dLGw== X-Forwarded-Encrypted: i=1; AJvYcCUibvk4QxZYX9iziKY1pKxMnVm8d9ScW9RTBXIoC/GYpCU2rxFFNmqt8OfWIVraz4Jb6Zz1rFFflaDaurs=@vger.kernel.org X-Gm-Message-State: AOJu0YxOfXr+IWpvWmi9JnT2Bn7rCKCoWjsGuaPeUxMDa5dZuDV1SUdP h4v0epf9SpAuGAN+6CrZiXaQf7k3b/npMHaswXKOGGjNPvKuuyfYQ0MW X-Gm-Gg: ASbGncsyI1PVFnuS54D1AsIWuNEVnAVPVbni4j0I3AiqDrGyMBmfk4JtHY1tjZaXwqj JvSytW4udvcvkbjh9UzVF8PX5vz9+ceviB4dNVrzU6TNdWh1iKZQSXUF2j5iF69HP+fnykLnwS7 LjeZkk4fqNoAJ6uGIsmI1IGNADEJc08W+6r474/bprtVfJV/BCi0cihdtAIRmFG0Q6S2qwoBOF+ hv1M7JrMPB7eyqL9Jkh3b+5kjoT84u7TwQt4XJBJGTLYY7HgZI/BwCUJAicvI46icZYnrxFuzb9 5r9VjoE25+hMAll6wsfybXYDnXYIPQjnT7eCUF4uPcfHUYTpwcp2u73bVGNrGIZUzNToJGB16KP sLsDdv3bTGp9jjA/IWp6b4g7kp9FoXGylFdGJa3S4qCw7yTWjKkNwRFOtucC7pMirAShntDngQY pbucTIdYM= X-Google-Smtp-Source: AGHT+IHHeWoXJKdNINlOiRKJ3a2nDIiOuVj8p9HhufLAzf+qZUQhC2Mssatfy2OZ9T8hXqauxRLp9w== X-Received: by 2002:ac8:58c9:0:b0:4ec:ee54:b141 with SMTP id d75a77b69052e-4ecee54b1f4mr8454481cf.26.1761410002057; Sat, 25 Oct 2025 09:33:22 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f262716efsm171531585a.59.2025.10.25.09.33.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:33:21 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Walleij , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" Subject: [PATCH 13/21] trace: don't use GENMASK() Date: Sat, 25 Oct 2025 12:32:55 -0400 Message-ID: <20251025163305.306787-6-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(high, low) notation is confusing. FIRST_BITS() is more appropriate. Signed-off-by: Yury Norov (NVIDIA) --- kernel/trace/fgraph.c | 10 +++++----- kernel/trace/trace_probe.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/trace/fgraph.c b/kernel/trace/fgraph.c index 484ad7a18463..4f21bd837055 100644 --- a/kernel/trace/fgraph.c +++ b/kernel/trace/fgraph.c @@ -106,10 +106,10 @@ * (RESERVED or BITMAP) */ #define FGRAPH_FRAME_OFFSET_BITS 10 -#define FGRAPH_FRAME_OFFSET_MASK GENMASK(FGRAPH_FRAME_OFFSET_BITS - 1, 0) +#define FGRAPH_FRAME_OFFSET_MASK FIRST_BITS(FGRAPH_FRAME_OFFSET_BITS) =20 #define FGRAPH_TYPE_BITS 2 -#define FGRAPH_TYPE_MASK GENMASK(FGRAPH_TYPE_BITS - 1, 0) +#define FGRAPH_TYPE_MASK FIRST_BITS(FGRAPH_TYPE_BITS) #define FGRAPH_TYPE_SHIFT FGRAPH_FRAME_OFFSET_BITS =20 enum { @@ -123,7 +123,7 @@ enum { * FGRAPH_INDEX (12-27) bits holding the gops index wanting return callb= ack called */ #define FGRAPH_INDEX_BITS 16 -#define FGRAPH_INDEX_MASK GENMASK(FGRAPH_INDEX_BITS - 1, 0) +#define FGRAPH_INDEX_MASK FIRST_BITS(FGRAPH_INDEX_BITS) #define FGRAPH_INDEX_SHIFT (FGRAPH_TYPE_SHIFT + FGRAPH_TYPE_BITS) =20 /* @@ -135,12 +135,12 @@ enum { * data_size =3D=3D 0 means 1 word, and 31 (=3D2^5 - 1) means 32 words. */ #define FGRAPH_DATA_BITS 5 -#define FGRAPH_DATA_MASK GENMASK(FGRAPH_DATA_BITS - 1, 0) +#define FGRAPH_DATA_MASK FIRST_BITS(FGRAPH_DATA_BITS) #define FGRAPH_DATA_SHIFT (FGRAPH_TYPE_SHIFT + FGRAPH_TYPE_BITS) #define FGRAPH_MAX_DATA_SIZE (sizeof(long) * (1 << FGRAPH_DATA_BITS)) =20 #define FGRAPH_DATA_INDEX_BITS 4 -#define FGRAPH_DATA_INDEX_MASK GENMASK(FGRAPH_DATA_INDEX_BITS - 1, 0) +#define FGRAPH_DATA_INDEX_MASK FIRST_BITS(FGRAPH_DATA_INDEX_BITS) #define FGRAPH_DATA_INDEX_SHIFT (FGRAPH_DATA_SHIFT + FGRAPH_DATA_BITS) =20 #define FGRAPH_MAX_INDEX \ diff --git a/kernel/trace/trace_probe.h b/kernel/trace/trace_probe.h index 08b5bda24da2..88de129dcde0 100644 --- a/kernel/trace/trace_probe.h +++ b/kernel/trace/trace_probe.h @@ -401,7 +401,7 @@ static inline int traceprobe_get_entry_data_size(struct= trace_probe *tp) #define TPARG_FL_USER BIT(4) #define TPARG_FL_FPROBE BIT(5) #define TPARG_FL_TPOINT BIT(6) -#define TPARG_FL_LOC_MASK GENMASK(4, 0) +#define TPARG_FL_LOC_MASK FIRST_BITS(5) =20 static inline bool tparg_is_function_entry(unsigned int flags) { --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E5FF30AD15 for ; Sat, 25 Oct 2025 16:33:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410007; cv=none; b=tLO0P6DeokMwLwx1C03DahTGCeUoMRSow9aTgxDyYfIqBK4NJDZ0xySLn8IY2AHoJBDZ6FxtlM90vCfWL2wLfJQy3gv0PKh798ElJck/UGgmh3YphrWHYcDx1XMZXzHDHL0VkxgI+kxDay/RxhiB21K1n7wAzxQQFv+6lfv8NUg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410007; c=relaxed/simple; bh=D84nUkpISPhfH1Ms4tl5/Hw+IaaftxzZv+6ev+Kp2IE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CjyLMnkThx21zxtaqyjNgz++TUVbZm9JTP5HOlZJB4AcF0iipu/ww9ZLxwMnd1yt8ug8AciDeTv3d2kO8dhffPz5YAoXdjIq/ekqjUYwCfIFsrV7ZYy4St4bEouykbt5pHcSoraO0bgSmRfbQT8agjqsRwQ5veBDrVd0nazxj08= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KyICDsI0; arc=none smtp.client-ip=209.85.219.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KyICDsI0" Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-87c103928ffso30450596d6.1 for ; Sat, 25 Oct 2025 09:33:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410004; x=1762014804; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+SI4944tmBFmU7KoVih1y0isAHqVxAR8yUSqEtfDae0=; b=KyICDsI0aArKWfsJpRBFDhudAeA+Xl9SyHa2qnJttJZyFZE8un2Hq2OAXzwXX3CUVW +EjrBurHYvnV7+/KaXuzCRE4AZjun9cnSi5Pj0PYLAGRwIEV5OpvezY/SHhY0992twLU Lvde9CxyvymxD26crgWS4ZPceQT8++st2as9u9GHAJVjg40UT9VAmRnyP4BMhxkWHEoX crpYR1s/l6njnE3oXQjH2lutBvN6oVXVxcm2yQTJIa1QXD8WQctgTj16Nmhygs275ScU gIqGg5GDE0DdqCCFVebDBpKVGtyiLxjmgT6JseD2bqIpl9x7C/S1xRixCt7la1SkFe8K 40Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410004; x=1762014804; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+SI4944tmBFmU7KoVih1y0isAHqVxAR8yUSqEtfDae0=; b=kuH+kMjMn3ZlJRVWU93KVZd5BvtyTJeFZI6mtVUvgR4Ldwsj38i0zPZ9dSgmISXok+ 5T9Uc91Erklu9DcMlB+9ydz53TVjykDDaGI+kf1wc279er/O8+VC/hNZk3FF1zenV2+F zopehjmZ2Bnrx/ICt+uktrOwNnOgcoHdxME5ASzOAthaMK85H1v/dUPnHp9fKPQeE0Wz pnjvekv8w0ADkOq5NnqG2v0XarB2H3RUDh/XnFnGO4bFdpYmjSbRN7gg2mTFjrKuVSAW kEjX8sHl5tg37rTdALBLHkRnlAEKr8RdhzhOe8NGTV2c+jKkYp22XSdzyXIG4H0Tp8yt W5Ow== X-Forwarded-Encrypted: i=1; AJvYcCUAYwEVs28eYSjcuvQ6gWABrCq55c9XDi4HHWzd7pwQIxppSX0H+nXve43gYwpxrildriNYKwZxSTtyZvY=@vger.kernel.org X-Gm-Message-State: AOJu0YyeBpB4gEFHhUn7lw8hkdDj7qFBtfqTWTH3X9OXoUUi5aIJfCr9 TFkLIcar5j1DmgxoItkTHhghFy9/b4u75XdH1fd6da/ilIuZ9TE8pbS1 X-Gm-Gg: ASbGnctMbZnpkk3M6PwC1yLFVPOtGmemK4PGwheYSHB5JqTg3/mdQ0OAFoM9xDCzbec 5FqPhkYEP8zxpNcG8zbk3H1P87RuC0Joo9m2kasr1l9qbxa16RLD5fHoX3vaP/yVS9ACVOFQq2p HEYwDDr56JOvJWE5o3wPxfq8pWWquuKGnkjweGcOT9bP/f9GI/D1bxaVzQyI8EN0gXpBzifkcLY 6KqNli/RWENo8VdsXihNVW7nTDIW9U+kGtDcmdyYIClfq2SUZNJeKCvK7ao8gEO6IcWEaC0Qtp9 MeTbC7+cKegjxS6zhNNUkEZoIfNxQCR23fbg8jSUISajU3RFAclFUX7pIOxN2plOlDrbS/1XImM p3232icBTo+58FiEqjUYCntiJJLPGLxPNDQ8QPoDu+4GBm0x9ZhrgulyvZk1tk5AuCvj8AXDM5C cNM5fVpB8= X-Google-Smtp-Source: AGHT+IH+pYoj7JDrVlr9V1K521EK2v4HXmacCPBcsmD1pov0NzWw0TEKhAqqwTmJ6pEikmRZLBQ+vQ== X-Received: by 2002:ad4:5ec8:0:b0:87d:cbb9:5459 with SMTP id 6a1803df08f44-87dcbb968bamr327845146d6.40.1761410004528; Sat, 25 Oct 2025 09:33:24 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc48d91a2sm16538466d6.17.2025.10.25.09.33.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:33:24 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Walleij , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Haren Myneni Cc: "Yury Norov (NVIDIA)" Subject: [PATCH 14/21] lib: 842: don't use GENMASK_ULL() Date: Sat, 25 Oct 2025 12:32:56 -0400 Message-ID: <20251025163305.306787-7-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK_ULL(high, low) notation is confusing. FIRST_BITS_ULL() is more appropriate. Signed-off-by: Yury Norov (NVIDIA) --- lib/842/842_compress.c | 2 +- lib/842/842_decompress.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/842/842_compress.c b/lib/842/842_compress.c index 055356508d97..83b68c85904f 100644 --- a/lib/842/842_compress.c +++ b/lib/842/842_compress.c @@ -161,7 +161,7 @@ static int __split_add_bits(struct sw842_param *p, u64 = d, u8 n, u8 s) ret =3D add_bits(p, d >> s, n - s); if (ret) return ret; - return add_bits(p, d & GENMASK_ULL(s - 1, 0), s); + return add_bits(p, d & FIRST_BITS_ULL(s), s); } =20 static int add_bits(struct sw842_param *p, u64 d, u8 n) diff --git a/lib/842/842_decompress.c b/lib/842/842_decompress.c index 582085ef8b49..0520f20f4121 100644 --- a/lib/842/842_decompress.c +++ b/lib/842/842_decompress.c @@ -115,7 +115,7 @@ static int next_bits(struct sw842_param *p, u64 *d, u8 = n) else *d =3D be64_to_cpu(get_unaligned((__be64 *)in)) >> (64 - bits); =20 - *d &=3D GENMASK_ULL(n - 1, 0); + *d &=3D FIRST_BITS_ULL(n); =20 p->bit +=3D n; =20 --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2189B30E0F9 for ; Sat, 25 Oct 2025 16:33:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410009; cv=none; b=WGS7y71j2r4RAn/CG4oUmgR3wyDkRrD6grGP9x3og+/g3KdRYZVtEK88mWzJngEYUF930Zs0Z3hsICI4VzMBmGZyNPGh8lngqi+4dAU3DPFWDq6EdjrLfi69XzrGHazewj5MaKSQ/7GvbJirkqs1OahfHydxfXZRjqttmedkYn8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410009; c=relaxed/simple; bh=BQ3V3TJBGcgRl9M8TTeR9VPGV9MIeZxMNrPM3NKIWvY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=siyvk4zqE/rTd7DTbzpf0Ok/td85HxrjfnvhNAjy/NxGfmA4/0ztm0pdteruFn8KnWOrS1lPsV3zf+e8vxsu/GGRwU3SfaNiw5Ofzm5GwUkG4sNOIHqr5qa0/0Qfs/0/zqaVtPAbhGyLf+B/7w0REdFMOy/oy2wbnY3rMTUf9G0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MgGPhXIg; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MgGPhXIg" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4e8b6144288so26294461cf.0 for ; Sat, 25 Oct 2025 09:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410007; x=1762014807; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fsJVQgpn61zq+Ge6F8BtEeBoOu3oJNRDvnauUG9sJYA=; b=MgGPhXIg0rTs9nmYtvb/bgsKyqiLVN7NdRQ4G2mUrJJ24tquypioARmvbsG+6FkCBB szepg08P5WF4NdGZqI0Xo7O8CDdNIiHW0NIeL37ESqFd7lRzgRTmFLOWrq11fPdVjDtl K7J0NuKz2cxxrT07ZUXP3dIQAOWjQ8FtWkS2DLI0YqbFSP5QAYiwuPndTkvuwkz+sRTD 0KRkl62eFG8JDwll390+qZ3Aq1c4aUpQ15vVVOL5GCsMn2xAK8lN+x2f5eJDprckfdOM +ol53XJfFVdmcHYbhxZ0ZRWz1nysaDRKGRXj1MDAkbIA9VSsDeADodehyZQYIjpVLeYr N1fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410007; x=1762014807; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fsJVQgpn61zq+Ge6F8BtEeBoOu3oJNRDvnauUG9sJYA=; b=OuV8kNB/wlm2aElU+3x117eJUh3RGsFr/hmbvrWORa0eucRt2hTZAp6oRcMBvinqgf y76YHA7VPpjqVPzNwlfyn65W6Efc4yq/qHBLodepTssgQ8S+YjyhGgwGYe5C2erp+pWg quCx+/KT2FaD03q8Fauy8svOLC9hTayH7ulsKuYqEYplqPuD3/xvTDMumdegMVN1S28m YsCsCqHEOoJz0Ob3eLetI3EhwPYwfTjhhS28l+UawXmlu1di12DKwRzRDcAjawIjWYQA ZkLiunpwni6yEhQe87MMV+EqeU4kMMpYEOmHQxd7YrmdT+1NTxxr1Qf4oDlsnFc8TICx 7otg== X-Forwarded-Encrypted: i=1; AJvYcCXHGfJGp0ejMFw+zYCF4uiCVM6f+sNjlGEuBjA05Q+3F2kzjTNNUlyyMyOYZ+peVpXP0DNT83rm8FPm95I=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+Ab/77B40xcU2HYu/AchFIH+OOPBOU+V2bizmluDH29cWSyxF m2rnAszdg+gMKiJmDNzA/QvHIQ7+ovNQgfSbTZX46Gy3q+Z8vZy3y3bY X-Gm-Gg: ASbGncuX4O3VbhGMeFpFxac6zxKgqf9Bae9XUqLkMgPT5fdOhWb0u2XwY9cHaQwmRk1 tPymd4z8x/YAGrk9MvNQTUk9UhIJ0NQSPvn/9tlOqujVMRdQDOVcaITaI8QwQakXVmXklQtheIt qlt7fotg+qodFIib8OxwyOS11G7NkgIgR9VwkIHacOOsPtimjMDQtaUqpU+HfVuV/7N2EBSeQ97 urNVYhdTC9h3bN8Nf5uV7ZmRquYzocIlxptY4eADKdlnjDGZoUTSynbD7/8DIi6kBPntd+4aSSo 4uNtuMTTrnqoL9idvWSXp7LoWRe27lA9jBMIATJKfJTk6MsIpzOloy/Nlze0f46sLVeg4WodFWb rNGmcEC1juW46BALX7VeqRJwc2TOJpCSITrPFLrPyRqXJSrQg5ahhqeN4XEUkK9HCbxvda7z1VU 2QzoqMscE= X-Google-Smtp-Source: AGHT+IEi0gU3nsclmOfIhkatsK1ylhMxi3V/RcKHP2qNLsK4jpBPuV25o1zZOF+JE24zBQDJY9wwQA== X-Received: by 2002:ac8:5d13:0:b0:4e8:a2dd:34a8 with SMTP id d75a77b69052e-4eb94912a08mr76566831cf.64.1761410007043; Sat, 25 Oct 2025 09:33:27 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f25896d52sm172754385a.38.2025.10.25.09.33.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:33:25 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Walleij , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , bpf@vger.kernel.org Cc: "Yury Norov (NVIDIA)" Subject: [PATCH 15/21] bpf: don't use GENMASK() Date: Sat, 25 Oct 2025 12:32:57 -0400 Message-ID: <20251025163305.306787-8-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(high, low) notation is confusing. BITS(low, high) is more appropriate. Signed-off-by: Yury Norov (NVIDIA) --- kernel/bpf/verifier.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index ff40e5e65c43..a9d690d3a507 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -17676,7 +17676,7 @@ static void mark_fastcall_pattern_for_call(struct b= pf_verifier_env *env, * - includes R1-R5 if corresponding parameter has is described * in the function prototype. */ - clobbered_regs_mask =3D GENMASK(cs.num_params, cs.is_void ? 1 : 0); + clobbered_regs_mask =3D BITS(cs.is_void ? 1 : 0, cs.num_params); /* e.g. if helper call clobbers r{0,1}, expect r{2,3,4,5} in the pattern = */ expected_regs_mask =3D ~clobbered_regs_mask & ALL_CALLER_SAVED_REGS; =20 @@ -24210,7 +24210,7 @@ static void compute_insn_live_regs(struct bpf_verif= ier_env *env, def =3D ALL_CALLER_SAVED_REGS; use =3D def & ~BIT(BPF_REG_0); if (get_call_summary(env, insn, &cs)) - use =3D GENMASK(cs.num_params, 1); + use =3D BITS(1, cs.num_params); break; default: def =3D 0; --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B954730EF84 for ; Sat, 25 Oct 2025 16:33:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410012; cv=none; b=QqnTh98w0DD5IPWplLR3aWXgxPXTjkAZaPAITqcmhfdUqzY4HNro/KJOxvG9SBJEDtiKVfwE/ivv/MPE5pa63lxyhnVLdTYis81kpBmjG97cbdvTvuKtjLPafDgcCLZdJCEQl4uzNjEoYv4mxs212wvJgQg8tfyulr6UxPBUTPQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410012; c=relaxed/simple; bh=+b2D4vP+c+kh3wd/DS3NcNXJ9L+1kZpJcsBrgvelyh0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I757kh3oLKI8bo4bZJUaldPWQa3SWeWj22kU3+bwkWwCBAyMSiJL99NQHgTLknysOjf/kyJqgTU2FhyaXpNRcui0gOxPoDCcF7RcrPUuuKF68QyV3jybS4grcXgrcJrd0MjSnkoCXY2i1rodypL/fuL7JnsrF9vKwSZVOjK4+jY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bkSaTt1O; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bkSaTt1O" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-89ead335934so136257085a.2 for ; Sat, 25 Oct 2025 09:33:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410010; x=1762014810; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QSGBaOZhD7YMIGtASkoY94KR31YSs6yG4R1SCYeYD08=; b=bkSaTt1O/+sEEm8n2rHDZlpIfOLlmrQHzBf67p259dd56VJunDvQhn4WlX/J1aIkF4 b6gLzl8vPHpFV5WhijlPePIxcEPJ8H2/b0ijo4LsJMOupOdmGnUgYtqr9QUPlUwBC8vo VNpmazjXF+g9cD9MSFzXIMQcj0lhpCTUMOP73et5Qrqib3a5pLXb4nRxsWHAOYOJ2xC3 uwusAUbz4jVGYeRLyq+LUHL1N3qFDEjuM9pgn7XtCL2X1OhEPij/9jmDnGCIUvcdBeJT fsTloWNt/6Fq5GnJ1DZAbcUe7Pt11m8Py8HIDFVpaH3YNUPns0pDJwLQ6U71DkNl6asM V61A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410010; x=1762014810; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QSGBaOZhD7YMIGtASkoY94KR31YSs6yG4R1SCYeYD08=; b=T4KgJ7nTv6Qf8JkkF/DAj/mkIqTJb4FO7lqUavSPVcX/oCMElZLb8KEuZaVHq83toV YCdXSPEpm4k2HInPALs5j/sWkpMqXOvHSd1Cc57AeZdYyt/+iKtDRSTXEm25+8dPuyUW m83Qc9kbTCW04/hsrQA9ptjJTs5rZi5jxmIrvH12N86Enk2Tka7r+P5rSC752sRUBNiP QodbOL6NR+Y23hWhD8rcDdYaCNAX06C1gJBjHVPBqv11Y256CrIys0KV6b7HONOjPwm+ M0UHhryfddiflPGwT1eyXYdy1q2h2KZkjEalwU2/NrxSdI5vYwRkfg4FGfpHxNUsILAB N5DQ== X-Forwarded-Encrypted: i=1; AJvYcCWZhtOIn3RQu0uc15vw+1RKcRY5VEiCyGJliPDmYmlP004WSRTXXyxGxgDJbTMkft5X6lD3dcDSGav0APc=@vger.kernel.org X-Gm-Message-State: AOJu0YwYEoLqYEx7vQ+xxI72PdhRehvs21q0XjbAJ9VVErgH4PrZJxaQ PQ0wyqlFfbeaGNEysdAubn5vDCFgLDW8Ttf+DnD8WqrN9y/fHQAQuNiM X-Gm-Gg: ASbGnctS07ar5tKe8vT+0zyaL4RyFwo3KxUZxd50xIUBRjRHhD5fc1DhYReKcf7PEkS dnGEJta4f5dKQRN3gxioePqCwbUs1aIUYwLIRK5f42RnqJtKbd6bYHSWT8a2DZJqXw96BbKKipw bPOSNWYnERsNi/UsPWl0+t/067dPpupXVAzFHUwETT1Qh/Zj7AAUQ6u3NNW8SgK54NiBDxzASUH v0bq8L+Mkf9jiEAZ82RVA6lr5gPW9o1TKOOcWRkF/PSQr41VhekjD9J98SRRWH6Og58xVLLRkJU 6kctdqRBwXfohcoI1fjCzNqPuG5ahK2D9KqP1B9fc8C+xiJ/kcvRRju/NuT1kGd3npybNAkxeeB P5wtbmLFIm3ui1KxH7hUFx6fK1rViXW6KHTv4d/fio00EKNGslqhRYO8t/xFOZO+pUplkU7FN4n hucJSAWCY= X-Google-Smtp-Source: AGHT+IEwse5jmtf5o3/IBBOm0kKgX0Hal7s087GbKSjPCM9MuS1VqssBnXXTT034Qa8iz97Crbuo3g== X-Received: by 2002:a05:6214:e4c:b0:87d:fef8:6155 with SMTP id 6a1803df08f44-87f9eeac1bfmr115745596d6.52.1761410009628; Sat, 25 Oct 2025 09:33:29 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc48f64aasm16321246d6.27.2025.10.25.09.33.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:33:28 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Walleij , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com Cc: "Yury Norov (NVIDIA)" Subject: [PATCH 16/21] kcsan: don't use GENMASK() Date: Sat, 25 Oct 2025 12:32:58 -0400 Message-ID: <20251025163305.306787-9-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(high, low) notation is confusing. Use BITS(low, high) and FIRST_BITS() where appropriate. Signed-off-by: Yury Norov (NVIDIA) --- kernel/kcsan/encoding.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/kcsan/encoding.h b/kernel/kcsan/encoding.h index 170a2bb22f53..3a4cb7b354e3 100644 --- a/kernel/kcsan/encoding.h +++ b/kernel/kcsan/encoding.h @@ -44,8 +44,8 @@ =20 /* Bitmasks for the encoded watchpoint access information. */ #define WATCHPOINT_WRITE_MASK BIT(BITS_PER_LONG-1) -#define WATCHPOINT_SIZE_MASK GENMASK(BITS_PER_LONG-2, WATCHPOINT_ADDR_BITS) -#define WATCHPOINT_ADDR_MASK GENMASK(WATCHPOINT_ADDR_BITS-1, 0) +#define WATCHPOINT_ADDR_MASK FIRST_BITS(WATCHPOINT_ADDR_BITS) +#define WATCHPOINT_SIZE_MASK BITS(WATCHPOINT_ADDR_BITS, BITS_PER_LONG-2) static_assert(WATCHPOINT_ADDR_MASK =3D=3D (1UL << WATCHPOINT_ADDR_BITS) - = 1); static_assert((WATCHPOINT_WRITE_MASK ^ WATCHPOINT_SIZE_MASK ^ WATCHPOINT_A= DDR_MASK) =3D=3D ~0UL); =20 --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93CD230F532 for ; Sat, 25 Oct 2025 16:33:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410014; cv=none; b=LJKyyTNKGAKY0BWNKZEUsB1+CHf4Ev+hMUndOLBk8bsnfivmq/VaSF947wif6VOGC3II72uWDIgwBBv09kBzAbSujTBHxIJyq2jFdmZ6ZFnWcRl3bhz6D435wAUcI1roWwKzmSiz+D0hnqhbQ5oaPCz9/QE0lVNjyCFYfC3VFA0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410014; c=relaxed/simple; bh=1bcynx9xewGI6dVd6TNDYQ5HTZ9qbz+hT47nRzvSCxE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=J0kIzq73Zd9KskKM/mGNVNS7rPILEfCXB+lbN3V49QbLtP+cAYPydWCs7tk8Qo+mvMnblwMdgeOeaCD8bFfNmneJWwyVc9Um8b9/d4KcKczXylbD4f1Nq0HQMmVunFNmSqNt6nWEqf06C4h4ed6QPGyNnghbQtrVE8rsB5/mn3A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CezVpZbP; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CezVpZbP" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-87c1f607e72so36389766d6.0 for ; Sat, 25 Oct 2025 09:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410011; x=1762014811; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0GldqH8fEtUrzkHne1rF5BgiofNp7hGD1Vw1w37mqgw=; b=CezVpZbP3pH5LRxpguyNt/Z4ptFP/nfVlKj9ioNKbrVfmu+Vi/QdWgM2GeHRux+eL6 mTItHuU94j53UEz+AmG6ta5NYFLnxwWW/K+/TR8nGVDKsqCMXMX7ruG2Kug7TIfwsETe 6aAEQuqRdsc1bXK7zT1pvlNYubjv+M8v1bVg8SCZQcSL2ejGYhkcjMbrgfWklB6lmV8O 27CsuB4osWquggTchYt8AapkX3z5WQcqJYIdLPfjlP7Kp93D+rQqgBCu4ebkcuCyAfqc f4ba+MSGAZL4CkgagsJTuUqxOt+CuMTeBg7x7cALg7HVE8046LIAlFwYIpRkxkOtkWgC HWmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410011; x=1762014811; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0GldqH8fEtUrzkHne1rF5BgiofNp7hGD1Vw1w37mqgw=; b=WP88khh2gGn56h7L/qHFRJwYvXUADhg6ZXvRaTqEOMSndVXW//AQq8oNf5kqH8Lnjy qlJmUumSi/h6XgQtxEs6UR8o+cW5WLN0w2wmw6pQjpMUo/6IQR4Su5MEtAcSKkCgiPy5 x9R6BV/OirpPnL4RSDKEIItzig+byBPl03PvC01x9XDP4EUR/gHaG7aCc9clQZs8Mm8a AUKyUj9uCOgPGHa2pEIgx2+/uzYLVlgCy2hvhN3ldw5lsEznLT3TJSQnNwBqNt4s4Uk3 ezomKwYdbD5+fuM9c85z97WgP6uLE5OVSx+P3Qpi4sJ9MoRV6cVLUI2pRg8lCGi5Vr2Q jwMw== X-Forwarded-Encrypted: i=1; AJvYcCVdOK8wULHtwWzmUZWvo27G7L1mXXKdK5WNG8ea6DIpBGDtOuUMMNR4QqFYmnkW0MQUDZm7+l5vJ0lMkbI=@vger.kernel.org X-Gm-Message-State: AOJu0YxlpJPcG7Srq4Y3kem9QgbTempbWsUX0DmA04dVbbei6XEv5az0 m2cxShZ8ujLqTE44yQgmRrevFg0Ske3ZZyrVtrf5kV4dNueMhXXXYikG X-Gm-Gg: ASbGncs5vQ6N4rDHeZgrW2zjBjVPUK2VJveuhVndXhz/2XlWA0WZ0JflNf2ILZZ2APe hmep+BIPlVHoW4RMToZnHSgNrXlYjO6mLXZou/CJLU8L5ObnBCWgonwe1RsRdHpGhwlP6bdM5QJ zOmlITibe4yx4UyX6oFWxofiG2vODx0gzAgtaIna3mYV4L94QpDJpEG8uUbM6SFWEHjhEqjn9/m 3+VBP5UKc9I5KS7NI6yxLMZ1kfzUU0RukAypW7PxxhKTGfQ89a9TEVSY00zDj+R5HfvdZbFw8HI ojVlYIfvMZzTDBHxGpNdaOAaClkZhXTjXM7XNPqvFNQyYNlmzPG7IqmUCG75Yyf5I6rNVfw0G2v cA8hA8iipELHEARUnjUWhaBLY/xLIyJezAm2GRM75EgKeFv9tGi+2bkndPXfpiOudsQxP38FIRn /ifGXiwqw= X-Google-Smtp-Source: AGHT+IF5C8Vr5mRwg1oABB1oICMMdDXxfhjBtJc4JAfiQSgZg7djSzMhTj3NDF8UyFf8e6ttXMnqDg== X-Received: by 2002:ad4:5d67:0:b0:78f:48ef:d8c with SMTP id 6a1803df08f44-87fb40f481emr83956716d6.22.1761410011494; Sat, 25 Oct 2025 09:33:31 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc48a7467sm16284746d6.5.2025.10.25.09.33.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:33:30 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Walleij , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Morton , linux-mm@kvack.org Cc: "Yury Norov (NVIDIA)" Subject: [PATCH 17/21] mm: don't use GENMASK() Date: Sat, 25 Oct 2025 12:32:59 -0400 Message-ID: <20251025163305.306787-10-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(high, low) notation is confusing. FIRST_BITS() is more appropriate. Signed-off-by: Yury Norov (NVIDIA) --- mm/debug_vm_pgtable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index 830107b6dd08..b722dc3c091b 100644 --- a/mm/debug_vm_pgtable.c +++ b/mm/debug_vm_pgtable.c @@ -40,7 +40,7 @@ * expectations that are being validated here. All future changes in here * or the documentation need to be in sync. */ -#define RANDOM_NZVALUE GENMASK(7, 0) +#define RANDOM_NZVALUE FIRST_BITS(8) =20 struct pgtable_debug_args { struct mm_struct *mm; --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3804330F81A for ; Sat, 25 Oct 2025 16:33:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410016; cv=none; b=g451W45C2Euueo0vvl0qFitelSvLNOBvgvi+jMgMwTBGkUJ806KNgH1xYvmZePZ1j1ErI2r8l+XGqza4SETgzOgW6YnpN90Z0mz1qU90EMP26nZKNagNjG5bUl8pzhw1p4NaswP95gYVpG8iIpLBu0ZtvPCP6O+gL5qGpzD2jEg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410016; c=relaxed/simple; bh=/qN13PxTPUF7Pj/bbigcTnyf8UWTFD28fitKT4TB900=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ikjSvwthj6UMzoyuhFKOhJNMIlfoyI+6ldJ9bI/oGVPP5UrCrD7o/kWgovOBQXiDzE0Ln2MbImSERO1G5DX8H+7mH1+qjzgZWN+IEvDSF5G3Uy9VCgPIhQFZDxAZVhny2TiRaShu5Cmv2dGb5orocBzdhBqwa5WMKUqw8w9N2Yc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J16YheW/; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J16YheW/" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-87c167c0389so33792836d6.3 for ; Sat, 25 Oct 2025 09:33:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410014; x=1762014814; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FgpdQly6UAXSTR5MLgLdCsEnF7u6zwKVu6ylG76tjIg=; b=J16YheW/d0Kpj6oKToqWNL82YGbzgixD1KVDzgU5DDcnKRodOb4Bx3nf3jFshxOQTU vHGup94W8nAwA4vhCQSuIY6dLNKHkmVvj9RNv2d2Xo7cIfI53G8Yb1K8ZQMKrUp4Vot9 S0S66jF8eCszW2JfnjLsXQsmDQeB+Ih16S65uvhepxLQxz9out54bD1wrNnzc8MaWtRc gU7fzQlTagVNGasJQ4D4sYhdw3g+QdQ6jbs2jS231xdD55jCDtn6JZYlD3yid+ziyNXS ZY0EHt9/ZWB8QvVWspjpjlHR77eeXO8QCfXdzOpK9j5mPA2kPKabEHgsRf1yr+uxCije yP5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410014; x=1762014814; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FgpdQly6UAXSTR5MLgLdCsEnF7u6zwKVu6ylG76tjIg=; b=gWHaTDyhSA9PkOJzQ3zruUvK9qfl2MPIiN7ko7fk5e+MYJAJkTklACjLTSV30UfB3w kPE+zwqYQ4hT+0ttq7BG4vbB3dtJyWXb4tlIFWoI2e5fc3llR7TKe5/KFTH1UGgKQqB4 bQF6dTnP/ilVnRq3f9V1dsZn5I820ZWrx/Fzu467FNEXwzBHTFcfwAQLPEBpb8aSQgiP XVlBmn3qLPCPFrTbAEemF7apy9atvo012IEaRauS53TfwQ9eA94puwoYtUvvu80i1v+Y OsqAflZAbOUnfH+BZ8Y08mEyX0jR3X2J4nnvwTdNj5Nisk9v83Jhaae7pE460pcIJuMA 0yxA== X-Forwarded-Encrypted: i=1; AJvYcCU8Zkny1dU8VYQ1Xg1yAMETfZLbzvN3nNWeDdFduLniNvTVFSKIrGHaB8Nb9GBU/5fkWUxM6sr9x0Rau7c=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/eKP6DcgUKqM421CrhPSUQTZeCPA/ECpXT94GZu8Ei+ud41V2 /ufnSRAbUn3xCI8waMlXcdcrW5BXxFrLrnpW3/4N9aJXhUwvLCtwt+bl X-Gm-Gg: ASbGncs+2MPZ31CTHlcqMEBbCcbd/sYQtWgWLHT2CZfWQV6bDKzkFoNVmXCgQ2DZi64 NpjQNh9ymU1ko0gyvzjYJQp0DBqpKmLXKMhtTG8lt1NdFVgqGXgZvcV3BTOpmeBtpv3zDAi2sNw rJxtvDbrKBH7SRlNzEFNslXTNu3a0sChiZYfht85KI9rYLGsiXyB3iXk4vIHQuIL2ximws/jY40 uz92v/RMTUu785g6iH/e+Q9GrFoDzT7ApeA9JfNt7CJ0lk4o/rUU84sGovgTUNaomMTd6RRcHHc +I94CqGOBSlkiYpadxl3Q1R93z/ed4Latko1JrHJMj+cduSQmDpOq7A+wg50C7FTV4TbyJJN2py ZOadMezo+eyvMjZks8U9VHNsurIqkluSjeOwiDV+oHX0Vu/vXFF27phi0kd2Y/9WoWu6tvCw4 X-Google-Smtp-Source: AGHT+IGaxqILFk1sWEKYs4/aKTapgVfZamjsAKwhDmFO0q/do78fw/vH+Xpzx9XExIL+rzfn38dWcw== X-Received: by 2002:a05:6214:500a:b0:87c:2797:4942 with SMTP id 6a1803df08f44-87c27974b5dmr317695766d6.15.1761410014091; Sat, 25 Oct 2025 09:33:34 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc49fde48sm16301696d6.61.2025.10.25.09.33.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:33:32 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Walleij , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Arnd Bergmann , linux-arch@vger.kernel.org Cc: "Yury Norov (NVIDIA)" Subject: [PATCH 18/21] fprobe: don't use GENMASK() Date: Sat, 25 Oct 2025 12:33:00 -0400 Message-ID: <20251025163305.306787-11-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(high, low) notation is confusing. FIRST/LAST_BITS() are more appropriate. Signed-off-by: Yury Norov (NVIDIA) --- include/asm-generic/fprobe.h | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/include/asm-generic/fprobe.h b/include/asm-generic/fprobe.h index 8659a4dc6eb6..bf2523078661 100644 --- a/include/asm-generic/fprobe.h +++ b/include/asm-generic/fprobe.h @@ -16,17 +16,14 @@ #define ARCH_DEFINE_ENCODE_FPROBE_HEADER =20 #define FPROBE_HEADER_MSB_SIZE_SHIFT (BITS_PER_LONG - FPROBE_DATA_SIZE_BIT= S) -#define FPROBE_HEADER_MSB_MASK \ - GENMASK(FPROBE_HEADER_MSB_SIZE_SHIFT - 1, 0) +#define FPROBE_HEADER_MSB_MASK FIRST_BITS(FPROBE_HEADER_MSB_SIZE_SHIFT) =20 /* * By default, this expects the MSBs in the address of kprobe is 0xf. * If any arch needs another fixed pattern (e.g. s390 is zero filled), * override this. */ -#define FPROBE_HEADER_MSB_PATTERN \ - GENMASK(BITS_PER_LONG - 1, FPROBE_HEADER_MSB_SIZE_SHIFT) - +#define FPROBE_HEADER_MSB_PATTERN LAST_BITS(FPROBE_HEADER_MSB_SIZE_SHIFT) #define arch_fprobe_header_encodable(fp) \ (((unsigned long)(fp) & ~FPROBE_HEADER_MSB_MASK) =3D=3D \ FPROBE_HEADER_MSB_PATTERN) --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3400930F925 for ; Sat, 25 Oct 2025 16:33:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410018; cv=none; b=l9h/y7eZiP3OKhbkoewosOAdSXtapkw3VHtjJw1GENpnPlWXrR9cMB5r3FTnm0nYY7iuR9oveCrhnTPp2L2jrIzyEHCD6FXUjIQtSLLLgubvRMa6kVTVc2rhKf63/qXoycpSfQ7LqQlgJ8q4Ivo1G5MVfpsXFh038jvN+dYAtDU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410018; c=relaxed/simple; bh=M6vYwiDXFrwliwHjWTkr6oRqx2KgbMTp+xr1SyvsQ5Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lnxwzv10a/i37+sn0TJU3A8bqlI22P+Haziu+sJZgEEiv5PYtbuYSqYa0eq9lM1kTrxmkSHFYWnFj5FqoHm7x2zP90EMFuAtloNHBEqeU9rAAxtJxFLBEguXydtOAm/ZnePVf0yo9Gl5CLTN9Dx647Qt95qHLtSmiBpMDHoPdnU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AoyZHVbb; arc=none smtp.client-ip=209.85.219.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AoyZHVbb" Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-78f30dac856so36046796d6.2 for ; Sat, 25 Oct 2025 09:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410016; x=1762014816; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v+kdgwxqgLpSk+BXagyhyh0KizQR0PlmXlxRpNRvoio=; b=AoyZHVbbRAvOaJGXPLjkMkTctIl63Ov23pOWONsZDBYQ/jhUFeCcIgaouH7PufBH+I 92EIaf12QJgGdkwSGz70I9OL/XMJzqyFKP0ZGKndgJtFRZTcM1aiwjGly+stXZ+FLFOO X1MlfSbOTl2L6SPmRRaoJK0MeMy15jLII6kb00JsCwhhVX5RqVawIp/3E7pNfbWCY23h ET/KX94ZG27Ptsg3zkHet/sZ1KYTU0xbIoBi7iRkB8Q1VWTNTlj0OFjtreE3rwr/uh1L WSgBMayHJAagyDFo4rbHBj6qni4LCE2md66wLRbiunDSHHPf/5ZckIM+/+mV3bg8Gdj1 TfQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410016; x=1762014816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v+kdgwxqgLpSk+BXagyhyh0KizQR0PlmXlxRpNRvoio=; b=lYfeH//M2+6+cak5BsCsMYoGLqb3CUM7MuuI+7begd/puGDiyEKKYjB5HTgnKflfxe OoAEe1fpCaRPdctPWZDoCskbng9m6iBjxlvnT/6+IzT3MOXwtrSCvHK+1cOyJKKJGZ4j JPcwpO/iTk3FSqZkbz8/5eG52WlM9disKTSUFmZ704uQuESEEfeAQBiYzF1VWRf76KVY 1gwAWOvLGuh4OWM5ABqwDOdph/vazfPQVQZVAkh+KIqJ6p8JG1nnK2hc/Et0GeODQudp gJPKl0jYpMElJF6qNb/Pfi21ZgvSnujcvNmC0LGulBmi+aadbHGw61uGElp9fVE8r8du 7suw== X-Forwarded-Encrypted: i=1; AJvYcCVj7uGH+vIcKgQ7pulBErUpqgdlNIYSYzFkGh+ZNh40jG7/3yhbUN0mMn2bvWHJ+QkEUAxKYFkY8N+FQSI=@vger.kernel.org X-Gm-Message-State: AOJu0YwjmwTxix8zHw0LoZL8bcbfapwiDVeGFSwQF072cCSSculAknHH 0lQhGDOqe3CIODY+rDYSD3Fa8r9bCGyQvVZ5mCb/JCq90g+852hA6tyz X-Gm-Gg: ASbGncuu4ZQDW2XFrta7pqetVvJhZ3bafjs3ez0XQQQyvLKr6/HWPOkI9uW6+dvXe/n IT1/uLTgAxAzmlcLQB3KgLzSPvjF4igQ0uzplL0KkahWJN4m7WTdJQi0PrD2CMbRd74fZIbdKaf BeXPThYE60ZbtIv+b2+bFJ1HCrfRTfSJPVobjm5P8SxaeEj4fRiQvbcxRcF86BG+NS61IRATGUB IXegSXnuQgOr6jKHV44kBPWml0ucd7kNVyiIJmmUQZWsDbm4/CzWlHvU1GEHPQDt9KKjgC8JOj7 s5sAk2ccprCmAJDZqLU8VR2ikSar0UVlLmsR1QVFhgwP1IyNDob3C3EcrYFKqpuSu9f2UmQAihk 75qW0xnz6rfJr1rCzdZ6ZVGfmuIs8ap8sZgb+9WkXvENwDdEAesnOLdcAkK7IGNqNysOMPgTE X-Google-Smtp-Source: AGHT+IFUNq9E9F5tkFvF4iIGRPUJo2bGn0CXF3o3/vXLG4KH0hAs0g3n//wSNOK/rhmKbOn3qmKqqg== X-Received: by 2002:a05:6214:f6d:b0:87c:1032:e849 with SMTP id 6a1803df08f44-87f9edc81b9mr140672916d6.30.1761410016037; Sat, 25 Oct 2025 09:33:36 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc48a8bc4sm16252346d6.7.2025.10.25.09.33.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:33:35 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Walleij , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Jaegeuk Kim , Tony Luck , Reinette Chatre , Dave Martin , James Morse , Babu Moger , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Vlastimil Babka , Suren Baghdasaryan , Jinjiang Tu , Baolin Wang , Ryan Roberts , Andrei Vagin , linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" Subject: [PATCH 19/21] fs: don't use GENMASK() Date: Sat, 25 Oct 2025 12:33:01 -0400 Message-ID: <20251025163305.306787-12-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(high, low) notation is confusing. FIRST/LAST_BITS() are more appropriate. Signed-off-by: Yury Norov (NVIDIA) --- fs/erofs/internal.h | 2 +- fs/f2fs/data.c | 2 +- fs/f2fs/inode.c | 2 +- fs/f2fs/segment.c | 2 +- fs/f2fs/super.c | 2 +- fs/proc/task_mmu.c | 2 +- fs/resctrl/pseudo_lock.c | 2 +- include/linux/f2fs_fs.h | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h index f7f622836198..6e0f03092c52 100644 --- a/fs/erofs/internal.h +++ b/fs/erofs/internal.h @@ -250,7 +250,7 @@ static inline u64 erofs_nid_to_ino64(struct erofs_sb_in= fo *sbi, erofs_nid_t nid) * Note: on-disk NIDs remain unchanged as they are primarily used for * compatibility with non-LFS 32-bit applications. */ - return ((nid << 1) & GENMASK_ULL(63, 32)) | (nid & GENMASK(30, 0)) | + return ((nid << 1) & LAST_BITS_ULL(32)) | (nid & FIRST_BITS(31)) | ((nid >> EROFS_DIRENT_NID_METABOX_BIT) << 31); } =20 diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 775aa4f63aa3..ef08464e003f 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -416,7 +416,7 @@ int f2fs_target_device_index(struct f2fs_sb_info *sbi, = block_t blkaddr) =20 static blk_opf_t f2fs_io_flags(struct f2fs_io_info *fio) { - unsigned int temp_mask =3D GENMASK(NR_TEMP_TYPE - 1, 0); + unsigned int temp_mask =3D FIRST_BITS(NR_TEMP_TYPE); unsigned int fua_flag, meta_flag, io_flag; blk_opf_t op_flags =3D 0; =20 diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index 8c4eafe9ffac..42a43f558136 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -524,7 +524,7 @@ static int do_read_inode(struct inode *inode) fi->i_compress_level =3D compress_flag >> COMPRESS_LEVEL_OFFSET; fi->i_compress_flag =3D compress_flag & - GENMASK(COMPRESS_LEVEL_OFFSET - 1, 0); + FIRST_BITS(COMPRESS_LEVEL_OFFSET); fi->i_cluster_size =3D BIT(fi->i_log_cluster_size); set_inode_flag(inode, FI_COMPRESSED_FILE); } diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index b45eace879d7..64433d3b67d4 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -5425,7 +5425,7 @@ static int do_fix_curseg_write_pointer(struct f2fs_sb= _info *sbi, int type) wp_block =3D zbd->start_blk + (zone.wp >> log_sectors_per_block); wp_segno =3D GET_SEGNO(sbi, wp_block); wp_blkoff =3D wp_block - START_BLOCK(sbi, wp_segno); - wp_sector_off =3D zone.wp & GENMASK(log_sectors_per_block - 1, 0); + wp_sector_off =3D zone.wp & FIRST_BITS(log_sectors_per_block); =20 if (cs->segno =3D=3D wp_segno && cs->next_blkoff =3D=3D wp_blkoff && wp_sector_off =3D=3D 0) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index db7afb806411..96621fd45cdc 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -4501,7 +4501,7 @@ static void save_stop_reason(struct f2fs_sb_info *sbi= , unsigned char reason) unsigned long flags; =20 spin_lock_irqsave(&sbi->error_lock, flags); - if (sbi->stop_reason[reason] < GENMASK(BITS_PER_BYTE - 1, 0)) + if (sbi->stop_reason[reason] < FIRST_BITS(BITS_PER_BYTE)) sbi->stop_reason[reason]++; spin_unlock_irqrestore(&sbi->error_lock, flags); } diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index fc35a0543f01..71de487b244c 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -1845,7 +1845,7 @@ struct pagemapread { =20 #define PM_ENTRY_BYTES sizeof(pagemap_entry_t) #define PM_PFRAME_BITS 55 -#define PM_PFRAME_MASK GENMASK_ULL(PM_PFRAME_BITS - 1, 0) +#define PM_PFRAME_MASK FIRST_BITS_ULL(PM_PFRAME_BITS) #define PM_SOFT_DIRTY BIT_ULL(55) #define PM_MMAP_EXCLUSIVE BIT_ULL(56) #define PM_UFFD_WP BIT_ULL(57) diff --git a/fs/resctrl/pseudo_lock.c b/fs/resctrl/pseudo_lock.c index 87bbc2605de1..45703bbd3bca 100644 --- a/fs/resctrl/pseudo_lock.c +++ b/fs/resctrl/pseudo_lock.c @@ -30,7 +30,7 @@ */ static unsigned int pseudo_lock_major; =20 -static unsigned long pseudo_lock_minor_avail =3D GENMASK(MINORBITS, 0); +static unsigned long pseudo_lock_minor_avail =3D FIRST_BITS(MINORBITS + 1); =20 static char *pseudo_lock_devnode(const struct device *dev, umode_t *mode) { diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h index 6afb4a13b81d..9996356b79e0 100644 --- a/include/linux/f2fs_fs.h +++ b/include/linux/f2fs_fs.h @@ -356,7 +356,7 @@ enum { OFFSET_BIT_SHIFT }; =20 -#define OFFSET_BIT_MASK GENMASK(OFFSET_BIT_SHIFT - 1, 0) +#define OFFSET_BIT_MASK FIRST_BITS(OFFSET_BIT_SHIFT) =20 struct f2fs_node { /* can be one of three types: inode, direct, and indirect types */ --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25D0B31352C for ; Sat, 25 Oct 2025 16:33:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410020; cv=none; b=GnErW9z3OJccd1ZZCD1/i1W2sVHs6VW1SB58JRoIA42HhahDEt/pmxRxNW4RKJaCwGY+Sl6Pyo3HKKfDq209jUOE2d723sAY7tIJymiv2QiQqCpONnLTG7cbyLXegsASdttJd3LjXb8YiWllPyLXKiaJPqgU4dHJIn63TZi93gE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410020; c=relaxed/simple; bh=7GwbfwFI4OnHwDpWdSIvynNWO47LZso8CXPD0pWl0FI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JgQrFLLCNo4ArHHujz0phbaJV3a6NaCVzGIYaq2SfQ11yS0cnvWJrq1hMCBWkHBhxNx5DOt9Qhn/wl5m7UVc7409zFVhyJX+rVVx4VCsvrD6v9Rdq9oc5QqYhwALg88FHwDXXBJZ+EnV1T2ANNQGcm9NPBDN1z/K9aRzMx+rYlw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k61x73+Y; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k61x73+Y" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-81fdd5d7b59so31066506d6.3 for ; Sat, 25 Oct 2025 09:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410018; x=1762014818; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Cxuvcw+5BokTf5KtZwOgkWEs4upe9ufMvZQ/niv/DKU=; b=k61x73+Y1RYjuUy31WY8Bh5vjekgdLShcM1zhnsOhVlzkYY6Nlm9ftAa5Q6NQ3MMw6 Q1OcUXhqeyV1iogg1y9xps6jNUErn75QVfXIfwBeFV980xGjDaLF+vFwUUb52Mw1toc+ SuyY9yls6ExAltaagEBPCInvdrjl4Nn3ECeS2AFA4+UW5OA3IR1fZXHge1fLoDczZHvD mLbqiQRShAWLI/5e5Ygf5gjk7rcSWpDiSyHOYAX2hhauhSxB7bWYUfi+P0wI3T/r7XZW 16qEImeIIL4h+MB4wZRwh6gwAtulubNFg+sFy+4Cl/gnPoB0QVRDaeRieaKyF88rZ91j G61w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410018; x=1762014818; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cxuvcw+5BokTf5KtZwOgkWEs4upe9ufMvZQ/niv/DKU=; b=Xnq7nzih2nDvx77kdL+bHiLpVdFmaYhF8ESt+OCyJBfH8FuUXmpzZwKHCnRoVG6O1C v7NvxWux43DowLYKfLxoCfn/oax/l8i0JVqNQ+GscXi8sTvsIcG2O93tRmZ+GKvZwj10 JnSk+pfIntGuQPas3i3mTo1UaCzoVhvWXuMRzlT9lyvn4zEKmSBqHo6UbJXaDWRuEMs5 1DHuNuBbByB9WajCQaARs5m+nGIjLC4wJz3HOdkulT462LjyWJOcQcTzVKaTI962bL0l Tx0D8LgQEH+xLSn8QPqUe+TBIkjVbM959werk9BfDya/FvIRRme/KnUJ3K9h/9LbX/sv pH8w== X-Forwarded-Encrypted: i=1; AJvYcCXBHhlfFcu18I4f6P9AG/YFCw499+i2aAJ+JFV525nRsF1w33RRObbDfb0QNjpbzGpZxHMHE3emWo4KcVQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxIPss8zE+wL41guud36pqhMim2tWHI1xhhwfZy/RTpsiIBTMM+ +QG57f+053zE8B6jK2kXOVAfgwz1nG9ZL1eCIWkRUPp2V/7HhfZ6+ayL X-Gm-Gg: ASbGncvxiPYrYla4n9ihdd/rCWMu+843HR04ivGikhG4zipAkIrhbI+h8udjkxt5qZL PNVjDIMxlrvT636TN8IuqUyflFdfZamjcdpveNz0XVNAZsLVREEGvIZl0mFG8ZY67vn7aP0ZLty XYMhp1FzMG9Zj9Fx2WlOjcnyJK/y+wu4CueirTubmiJzKpokHwdzz8QU2LeKMpCZvpmM/xUX/Hk hlfNkUqgD3ph6fxeeDduoyDBSTwXrcFZJXVkD13kado3BFEYXszgrBhr4/5uLpJ0bLoEMK1lhCc 45TlteY7aZkbAd845P2FTBnL4qgT5xGGTE/9wnGoAk9djOdNCEi+sRusyhA9zbNx2qBEGX/QZhb Px5polLKTDQ3DiG3vUk8gQ9uYB/cPYKfloXeYl1CMXXUT0ltE5Yzu2cgZmk266gVeuUNVse6qnT ezRp7MDR8= X-Google-Smtp-Source: AGHT+IHWOynP91XK0eWWEmP39+HpO2WIYG1FD6QWp9GErpLHI7PIM/nM4hfHX/dVKVXslC7yeirnSA== X-Received: by 2002:a05:6214:508f:b0:87c:27c2:2c0e with SMTP id 6a1803df08f44-87c27c22f10mr333708616d6.59.1761410018091; Sat, 25 Oct 2025 09:33:38 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc48a8a1bsm16461146d6.8.2025.10.25.09.33.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:33:37 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Walleij , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kees Cook , linux-hardening@vger.kernel.org Cc: "Yury Norov (NVIDIA)" Subject: [PATCH 20/21] fortify-string: don't use GENMASK() Date: Sat, 25 Oct 2025 12:33:02 -0400 Message-ID: <20251025163305.306787-13-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(high, low) notation is confusing. BITS(low, high) is more appropriate. Signed-off-by: Yury Norov (NVIDIA) --- include/linux/fortify-string.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/fortify-string.h b/include/linux/fortify-string.h index b3b53f8c1b28..0c95cdcca736 100644 --- a/include/linux/fortify-string.h +++ b/include/linux/fortify-string.h @@ -11,9 +11,9 @@ #define __RENAME(x) __asm__(#x) =20 #define FORTIFY_REASON_DIR(r) FIELD_GET(BIT(0), r) -#define FORTIFY_REASON_FUNC(r) FIELD_GET(GENMASK(7, 1), r) +#define FORTIFY_REASON_FUNC(r) FIELD_GET(BITS(1, 7), r) #define FORTIFY_REASON(func, write) (FIELD_PREP(BIT(0), write) | \ - FIELD_PREP(GENMASK(7, 1), func)) + FIELD_PREP(BITS(1, 7), func)) =20 /* Overridden by KUnit tests. */ #ifndef fortify_panic --=20 2.43.0 From nobody Sun Feb 8 05:37:10 2026 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B0313148AC for ; Sat, 25 Oct 2025 16:33:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410025; cv=none; b=VJfrBjI7dw1PxyxOGAxNYkTgQkmYHZi6NMVJml7y08zK/e/bB4nPXLBmG1+byUmqqycGI3YpvPUUoF/I/wDukHhjUTFX+Wp800AKjYdqDcEGvjkaU8BJQg39g14NNlavkHDjM2HDAJDkZd/H4O7y4Bh+rI/i+gT2sqY/NnDtVsQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761410025; c=relaxed/simple; bh=W0pTJAcfrpLd3MSeWjU9C4zToTzxqvWOKJPAJegCRgo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dzr4XyN14qmNPuadTwb5p0D6mfNJhcdzAS+FNqS18ENBo+AU+igNXV0YZtXk3iV91uXSX9trKT+QUmYRnpoRgoZAgVTk+xA75yUdMZ14LQqMY7pdfbwRoNW2dmIIngHH38QZ6isnyGfmouQKd7oFnGhatKNCSA1W/LoolZGdVWM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W3GxsZcQ; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W3GxsZcQ" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-89f4779fe03so75235085a.3 for ; Sat, 25 Oct 2025 09:33:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761410021; x=1762014821; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lCukDE2Wz/llmJRA1Dhhk+dKRYCeKOkr6t5vR7uoeBo=; b=W3GxsZcQ0AjbfViWXfh+9q20Q/hqRqnWMrVwf3Lu3jxrZlLYZzR8fqV64fofyiCOsc AQycqC1WssYOjDuAsqnRJoC21rHmhmQI0ZmOVelCYow4SxouzLe2dGOcW2rGPuX0ytRy mP0nhuwEiE6cQuHjJrkETrZf3zbhEjyq+Ed3jQapIMRSiNNrHhXXzvgYmE/cs5qtEkcZ fafAAxxSj7k25jMJvEzRtknXyICbUpOo2GZphZh5Pw3/1bb9lfiJI/eW6y6RcHwgHiyP O7/JvbzuIlG4lvE168bPoIxVmpT8Cp441DPOVQmHnfT0bqaaWiYcPVebjmY/mzSojYlD YCsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761410021; x=1762014821; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lCukDE2Wz/llmJRA1Dhhk+dKRYCeKOkr6t5vR7uoeBo=; b=pxUASSoJvxm8UICvz6Ony15ItthSs+ieVb0EsHCoakfI21kexco7GPVGM9bQLDhqux mgqIbJu2TD+3NgCCSoOasp5Fq0UA1/bqBWciZcJnB4WwWXquMKXrGuOPE+8M0tsK3Paz auq2ICQqw1aVfJPkWLzt0Hmh+uvUKOt06vJratb80lWMgfOTxxhRIBCoXAy2Hp0f4+wm 5z0oSq2aelwAkES+mVk4pKE4cMqigDZUdc6vXsjGQYZLMU5hSudDcMi/lcdT2hDS53NX oi3MId/UEy72QxylGJa1l9WSpMiode9uMJtwicFYfv09/RxExYtNdeP4HCePWmqS3PZ1 xPJQ== X-Forwarded-Encrypted: i=1; AJvYcCXyL7vlU4Zu/n0+0uUI6WcyiHmI3OyZPXb9RIXhZpxruT8hN58Eso58rBqk3E1FvAITY0s0BQSY++9a7yU=@vger.kernel.org X-Gm-Message-State: AOJu0YzGCE4VFyWHRuZyk2LosO3hNItQ5TaGVi4I35Eiv0SqKsoPmKFM igvUDuS/x8bKMNFDHeYi2/LXhpHRFRmZwDboDorfWr8oPGGu2nwpLXRH X-Gm-Gg: ASbGncu8Oo6J6K7QId3bG1oNcsLmf+9Ye9LsXEYxLrJr/PSIMrLJdNYnF7w/MOknEGo 3b45MOFDoqgARLifCtkraP3FLYHd7DSPUnIEWBRAuitiF+GylNU32NKtaROJjYpRfxC5b3X5Rm7 2wgCjXg95YGxpUdkKMgFrHRnj1Zz7uLXtJ5yBwkXg15lAPpYcj5038lU2lSYvdiYuFsN6/s1q51 yj2YTMqXr1ajvHmtnaq1TNW8pI8CIKgLPR0TC9a1LZS8aL5T0SfIyjBXZaSRh1P3r8I8Nz1E72n gP0yNpaCCPUAGmDn6+solH8tZl3wQ8fKIEilrsxIxGU9ZWZ2lWdRSpK7MIqXRVFtD34RyeAtHH0 H0LPnOLWnVxdjPWU8C1SKBCrm/IaylH6kIy2owEHButVh1/25xVl6OgFQ65epQARnRXg+jO4bHL NDrE0cCEE= X-Google-Smtp-Source: AGHT+IFZUXzUCKjX2GS7KVjFpxXVayhaSU18PSnROxCbmg4ehcl8/3L/N8ey4/nagW/qyG5Qi/ofXg== X-Received: by 2002:a05:620a:2990:b0:829:b669:c791 with SMTP id af79cd13be357-890712b8ca4mr3694996585a.78.1761410021395; Sat, 25 Oct 2025 09:33:41 -0700 (PDT) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f254a41cdsm172336185a.29.2025.10.25.09.33.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 09:33:40 -0700 (PDT) From: "Yury Norov (NVIDIA)" To: Linus Walleij , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jonathan Corbet , workflows@vger.kernel.org, linux-doc@vger.kernel.org Cc: "Yury Norov (NVIDIA)" Subject: [PATCH 21/21] Docs: add Functions parameters order section Date: Sat, 25 Oct 2025 12:33:03 -0400 Message-ID: <20251025163305.306787-14-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251025162858.305236-1-yury.norov@gmail.com> References: <20251025162858.305236-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Standardize parameters ordering in some typical cases to minimize confusion. Signed-off-by: Yury Norov (NVIDIA) --- Documentation/process/coding-style.rst | 48 ++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/Documentation/process/coding-style.rst b/Documentation/process= /coding-style.rst index d1a8e5465ed9..dde24148305c 100644 --- a/Documentation/process/coding-style.rst +++ b/Documentation/process/coding-style.rst @@ -523,6 +523,54 @@ below, compared to the **declaration** example above):: ... } =20 +6.2) Function parameters order +------------------------------ + +The order of parameters is important both for code generation and readabil= ity. +Passing parameters in an unusual order is a common source of bugs. Listing +them in standard widely adopted order helps to avoid confusion. + +Many ABIs put first function parameter and return value in R0. If your +function returns one of its parameters, passing it at the very beginning +would lead to a better code generation. For example:: + + void *memset64(uint64_t *s, uint64_t v, size_t count); + void *memcpy(void *dest, const void *src, size_t count); + +If your function doesn't propagate a parameter, but has a meaning of copyi= ng +and/or processing data, the best practice is following the traditional ord= er: +destination, source, options, flags. + +for_each()-like iterators should take an enumerator the first. For example= :: + + for_each_set_bit(bit, mask, nbits); + do_something(bit); + + list_for_each_entry(pos, head, member); + do_something(pos); + +If function operates on a range or ranges of data, corresponding parameters +may be described as ``start - end`` or ``start - size`` pairs. In both cas= es, +the parameters should follow each other. For example:: + + int + check_range(unsigned long vstart, unsigned long vend, + unsigned long kstart, unsigned long kend); + + static inline void flush_icache_range(unsigned long start, unsigne= d long end); + + static inline void flush_icache_user_page(struct vm_area_struct *v= ma, + struct page *page, + unsigned long addr, int len); + +Both ``start`` and ``end`` of the interval are inclusive. + +Describing intervals in order ``end - start`` is unfavorable. One notable +example is the ``GENMASK(high, low)`` macro. While such a notation is popu= lar +in hardware context, particularly to describe registers structure, in cont= ext +of software development it looks counter intuitive and confusing. Please s= witch +to an equivalent ``BITS(low, high)`` version. + 7) Centralized exiting of functions ----------------------------------- =20 --=20 2.43.0