From nobody Sat Feb 7 18:21:05 2026 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B4F51FBEAC for ; Sat, 25 Oct 2025 12:41:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761396083; cv=none; b=Xu9iYFwjBytAOUv+kw/fmc3es08I+yQDwLztVvvVb8IZ6DThqdsSHPeN3vey4hSy3Ws+VIdJWXQQy0hF4mpWd2F40z2YaKbIgk5Y3JmvVktsin99bE8NprngBCeXOOLqScbicCSVG5yOiH9mRgcu5spmKfhhXfQF301lGazyzRM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761396083; c=relaxed/simple; bh=DbhyxMxq4lUaU8IP69H+5X/6jxTC3W56/g+TqGuwKpA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cowmOS+uvwMRe3C7Bcy0votKI4XkWrb6DnceA7KwchLsgOQ25g8Tpgr98XOMFTfauzL7CAK8yWj0JECRMXMUE7CCurplvYz8RguI5o3fseowFBcgVC3Hou5IEabtrg9c9lTostk7meo5vyqPKPMcqQ6QiMNsdLvaL0k7r0x/6GE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yj9VtxGr; arc=none smtp.client-ip=209.85.210.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yj9VtxGr" Received: by mail-pf1-f193.google.com with SMTP id d2e1a72fcca58-794e300e20dso3680177b3a.1 for ; Sat, 25 Oct 2025 05:41:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761396081; x=1762000881; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wmZntVTHHXX7vvT4or3/vlXQkt3zScSQQ5D3QkdreyU=; b=Yj9VtxGr6qS+aC8sOnV7DzsafLrQb0Mdd6O41N1Byx/wFjvHqyVSiKh9yMKfJhesog HivT9S53UOw6WQNjv1gyXwVAfzHhn5fhXD8Cm+25y+frUoUPFOl4plJNrTvVnqrW5WjF dNjLinUNuuPHE9TXW1q5Us6sh3GxyXZOHUVSxt0s2HPwpCt+5CbkVH6B7uEWNwaRBBnp Ts93w9gPIN9dF31MwqAaykUD7g67CHJJmYVDpJhkOOtE4GYhDIrDQ6Z5iRMjAsiynq0z tjxapjKdPSaevagsmn3GajANGwkzI1sUFnu4DBDXrGxhjmQxmq/Y1Ea02XGXyxO/GETE GGaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761396081; x=1762000881; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wmZntVTHHXX7vvT4or3/vlXQkt3zScSQQ5D3QkdreyU=; b=mlj78lsozm9e8WQCqILcnapR9LxH/4+hRvQVWk1PyQ0U2AGftn3TkxnK3GWxe+ijO5 7CuwU4bwsqtyyi6Z3H7RSwNICBehHsFCqNYQiK1KkJzCLU99oSX6b8GMcWtSF1l0Ezkl MQthfuvVVryRjVX5/A5pm1BKUlwtN/KP81bq6nt713PolZl4b17uuDeEmIKoyAr65N3b vLftQSBMqptWHZ0ZGfrlaXzQ9I70ydLKmf0q+iXpBRPEKElRl4VLq1M18E1zJ4be1MXc THXRbm9KWCOzJCWPJt1vA3xPsSairMJUdZLJDNwiOEnrtfKt30YXCpstFSNOyZbQ/35p u7+g== X-Forwarded-Encrypted: i=1; AJvYcCXdIyjQtQ3V15eiA/gxCwaC28hNd/HkQTiWhQ57z3V6SrMUwiqGmdiNZUhdG9CbZ56F/8xHYOBMtBwREUk=@vger.kernel.org X-Gm-Message-State: AOJu0YzotzZNV8i9MY7HRvAtcvd2IWVsfsXvto4U2L4xVI+fflFHBJaY RBLvh8sgcErgvxVNB3V62ZqqJNxS7qSBl+XQ+ByQoUUj3Vta3dHIEDyv X-Gm-Gg: ASbGncuBwLyq6UzvFfrlCJw/oCRkqxJ2Mb2yD7B5GlI8myYVKg9IbBD8074VA+Cz7Ou V4btGliqcwG2clZYOI7WddwPoPiytO8gLNQ0AoX7QxK/K8IST6Y03U+Rla79FjNJNtGttKJWGtI JEuPFRt3jInJMOJtt/wic5dLv4QFDCfpHIHIz3KFTGG/Fut4m0BNBig3hV6BojXfTu/kuxEKWdn cU388emoi/SQhKrcJguR/EBGh5anE6AHtgbdcsYfPeDAYyOjKVsF1qg+ceKDzJNvh3gRfbk+Jjy cbHC23or45qADsr3hn4keiAb3EvAcBFnGpppj63+oqBlcda+bbcn4nqFG0bkrijQ/v/RP9HOPZZ HsKDcfC3ptxVkpHvfyQeffr6dVJRA+xgvVXmj3m57i+WeeLSuShc8MG+U0DddqUMQmk5B2aML6H O0t3C5p0E= X-Google-Smtp-Source: AGHT+IHzNs/eLQNOngxeYDWlhwSANW/kUwt/EM86jh34NmnaHE0YhhBpGRAv70D0RhfuygrVqhJNRg== X-Received: by 2002:a17:902:d547:b0:273:ef4c:60f3 with SMTP id d9443c01a7336-29489d70d8bmr73531765ad.4.1761396081179; Sat, 25 Oct 2025 05:41:21 -0700 (PDT) Received: from Ubuntu24.. ([157.32.121.71]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29498e42f5csm22263395ad.104.2025.10.25.05.41.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 05:41:20 -0700 (PDT) From: Shrikant Raskar To: hverkuil@kernel.org, mchehab@kernel.org Cc: skhan@linuxfoundation.org, david.hunter.linux@gmail.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, Shrikant Raskar Subject: [RFC PATCH v2] media: saa6588: Remove dprintk macro and use v4l2_info() Date: Sat, 25 Oct 2025 18:11:07 +0530 Message-ID: <20251025124107.4921-1-raskar.shree97@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The existing 'dprintk' macro used an unwrapped 'if' statement which was flagged by checkpatch, but instead of wrapping it, the debug handling can be simplified. This patch removes the 'dprintk' macro entirely and replaces all its usages with v4l2_info() helper. The unused 'PREFIX' macro is also removed. Signed-off-by: Shrikant Raskar --- Changelog: Changes since v2: - Removed dprintk macro - Replaced 'dprintk' with v4l2_info().=20 - Removed PREFIX macro. Link to v1: https://lore.kernel.org/all/20250923175927.4380-1-raskar.shree97@gmail.com/ --- drivers/media/i2c/saa6588.c | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/media/i2c/saa6588.c b/drivers/media/i2c/saa6588.c index fb09e4560d8a..d2cb85a2d226 100644 --- a/drivers/media/i2c/saa6588.c +++ b/drivers/media/i2c/saa6588.c @@ -49,8 +49,6 @@ MODULE_LICENSE("GPL"); /* ---------------------------------------------------------------------- = */ =20 #define UNSET (-1U) -#define PREFIX "saa6588: " -#define dprintk if (debug) printk =20 struct saa6588 { struct v4l2_subdev sd; @@ -144,14 +142,14 @@ static bool block_from_buf(struct saa6588 *s, unsigne= d char *buf) =20 if (s->rd_index =3D=3D s->wr_index) { if (debug > 2) - dprintk(PREFIX "Read: buffer empty.\n"); + v4l2_info(&s->sd, "Read: buffer empty.\n"); return false; } =20 if (debug > 2) { - dprintk(PREFIX "Read: "); + v4l2_info(&s->sd, "Read: "); for (i =3D s->rd_index; i < s->rd_index + 3; i++) - dprintk("0x%02x ", s->buffer[i]); + v4l2_info(&s->sd, "0x%02x ", s->buffer[i]); } =20 memcpy(buf, &s->buffer[s->rd_index], 3); @@ -162,7 +160,7 @@ static bool block_from_buf(struct saa6588 *s, unsigned = char *buf) s->block_count--; =20 if (debug > 2) - dprintk("%d blocks total.\n", s->block_count); + v4l2_info(&s->sd, "%d blocks total.\n", s->block_count); =20 return true; } @@ -222,11 +220,11 @@ static void block_to_buf(struct saa6588 *s, unsigned = char *blockbuf) unsigned int i; =20 if (debug > 3) - dprintk(PREFIX "New block: "); + v4l2_info(&s->sd, "New block: "); =20 for (i =3D 0; i < 3; ++i) { if (debug > 3) - dprintk("0x%02x ", blockbuf[i]); + v4l2_info(&s->sd, "0x%02x ", blockbuf[i]); s->buffer[s->wr_index] =3D blockbuf[i]; s->wr_index++; } @@ -242,7 +240,7 @@ static void block_to_buf(struct saa6588 *s, unsigned ch= ar *blockbuf) s->block_count++; =20 if (debug > 3) - dprintk("%d blocks total.\n", s->block_count); + v4l2_info(&s->sd, "%d blocks total.\n", s->block_count); } =20 static void saa6588_i2c_poll(struct saa6588 *s) @@ -257,7 +255,7 @@ static void saa6588_i2c_poll(struct saa6588 *s) SAA6588 returns garbage otherwise. */ if (6 !=3D i2c_master_recv(client, &tmpbuf[0], 6)) { if (debug > 1) - dprintk(PREFIX "read error!\n"); + v4l2_info(&s->sd, "read error!\n"); return; } =20 @@ -267,7 +265,7 @@ static void saa6588_i2c_poll(struct saa6588 *s) blocknum =3D tmpbuf[0] >> 5; if (blocknum =3D=3D s->last_blocknum) { if (debug > 3) - dprintk("Saw block %d again.\n", blocknum); + v4l2_info(&s->sd, "Saw block %d again.\n", blocknum); return; } =20 @@ -370,12 +368,13 @@ static void saa6588_configure(struct saa6588 *s) break; } =20 - dprintk(PREFIX "writing: 0w=3D0x%02x 1w=3D0x%02x 2w=3D0x%02x\n", - buf[0], buf[1], buf[2]); + if (debug) + v4l2_info(&s->sd, "writing: 0w=3D0x%02x 1w=3D0x%02x 2w=3D0x%02x\n", + buf[0], buf[1], buf[2]); =20 rc =3D i2c_master_send(client, buf, 3); if (rc !=3D 3) - printk(PREFIX "i2c i/o error: rc =3D=3D %d (should be 3)\n", rc); + v4l2_info(&s->sd, "i2c i/o error: rc =3D=3D %d (should be 3)\n", rc); } =20 /* ---------------------------------------------------------------------- = */ base-commit: 6fab32bb6508abbb8b7b1c5498e44f0c32320ed5 --=20 2.43.0