From nobody Sun Feb 8 13:40:23 2026 Received: from canpmsgout08.his.huawei.com (canpmsgout08.his.huawei.com [113.46.200.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C852D2EA724; Sat, 25 Oct 2025 10:13:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.223 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761387185; cv=none; b=AopjV6VsLP6KwGLm47CvWYRaUcn3xQZVCWNAdnr363d+wNXPaUWgnXUAm4S6WHg0o9OwoCCnDOuORGGgyypiaOvzcdzKrwOvV0sIV60+dxdfrT7qOPFGKgeen/HkbG2PKLIBhU+UemPg/jV/lm1KCOEum2Jvgx5nrg7JCEIYvX4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761387185; c=relaxed/simple; bh=kcA8YEqHImNn0MbJy1QtUH1Ue8bic05+uzxAxwZVvXg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CFh7h8WMlkIQPPF/1cdzIs0mBRvu8HTr8bLS4CXSJ83vQUJP/7BuMqHikUws3H7iDRkualo6YSiXwItkXzX0v6c/9xY5yumjGobkoVRFMY+iFbtPpQ71GbxciD/YG1asOXj3MgwqNXw7tmQJYYasmrpIJPbp6BLX45ZS2J4dhD4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=r1v2Bt55; arc=none smtp.client-ip=113.46.200.223 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="r1v2Bt55" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=mdASmNNiofJ4T+tv6nJdiPRoAlyXw68u2bmmWiaXYAg=; b=r1v2Bt55ize23V/6QAu29ofj/cL8CH7lvnqJs2ElJ0aZxtZ+kkktTjcZS/luxJq7HGneyEZOB U6N0+k5dwxc/NWDG19f4O38bwQ4M/PRu5jMjQWqr8QqsVOUi0/x5voz8WgwydXpEie6y7GC2cEz dEtblcD6xZqJYF3Lso+SpX8= Received: from mail.maildlp.com (unknown [172.19.163.44]) by canpmsgout08.his.huawei.com (SkyGuard) with ESMTPS id 4ctwYt1B8zzmV8F; Sat, 25 Oct 2025 18:12:34 +0800 (CST) Received: from dggemv705-chm.china.huawei.com (unknown [10.3.19.32]) by mail.maildlp.com (Postfix) with ESMTPS id 8BC4F140276; Sat, 25 Oct 2025 18:13:00 +0800 (CST) Received: from kwepemq200001.china.huawei.com (7.202.195.16) by dggemv705-chm.china.huawei.com (10.3.19.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 25 Oct 2025 18:13:00 +0800 Received: from localhost.huawei.com (10.90.31.46) by kwepemq200001.china.huawei.com (7.202.195.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 25 Oct 2025 18:12:59 +0800 From: Chenghai Huang To: , CC: , , , , , , , Subject: [PATCH 1/4] crypto: hisilicon/qm - add the save operation of eqe and aeqe Date: Sat, 25 Oct 2025 18:12:55 +0800 Message-ID: <20251025101258.2793179-2-huangchenghai2@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20251025101258.2793179-1-huangchenghai2@huawei.com> References: <20251025101258.2793179-1-huangchenghai2@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems100001.china.huawei.com (7.221.188.238) To kwepemq200001.china.huawei.com (7.202.195.16) Content-Type: text/plain; charset="utf-8" From: nieweiqiang The eqe and aeqe are device updated values that include the valid bit and queue number. In the current process, there is no memory barrier added, so it cannot be guaranteed that the valid bit is read before other processes are executed. Since eqe and aeqe are only 4 bytes and the device writes them to memory in a single operation, saving the values of eqe and aeqe ensures that the valid bit and queue number read by the CPU were written by the device simultaneously. Signed-off-by: nieweiqiang Signed-off-by: Chenghai Huang --- drivers/crypto/hisilicon/qm.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c index 30e44cfb57ee..8274da8b37ca 100644 --- a/drivers/crypto/hisilicon/qm.c +++ b/drivers/crypto/hisilicon/qm.c @@ -64,10 +64,10 @@ #define QM_EQE_AEQE_SIZE (2UL << 12) #define QM_EQC_PHASE_SHIFT 16 =20 -#define QM_EQE_PHASE(eqe) ((le32_to_cpu((eqe)->dw0) >> 16) & 0x1) +#define QM_EQE_PHASE(dw0) (((dw0) >> 16) & 0x1) #define QM_EQE_CQN_MASK GENMASK(15, 0) =20 -#define QM_AEQE_PHASE(aeqe) ((le32_to_cpu((aeqe)->dw0) >> 16) & 0x1) +#define QM_AEQE_PHASE(dw0) (((dw0) >> 16) & 0x1) #define QM_AEQE_TYPE_SHIFT 17 #define QM_AEQE_TYPE_MASK 0xf #define QM_AEQE_CQN_MASK GENMASK(15, 0) @@ -976,23 +976,23 @@ static void qm_get_complete_eqe_num(struct hisi_qm *q= m) { struct qm_eqe *eqe =3D qm->eqe + qm->status.eq_head; struct hisi_qm_poll_data *poll_data =3D NULL; + u32 dw0 =3D le32_to_cpu(eqe->dw0); u16 eq_depth =3D qm->eq_depth; u16 cqn, eqe_num =3D 0; =20 - if (QM_EQE_PHASE(eqe) !=3D qm->status.eqc_phase) { + if (QM_EQE_PHASE(dw0) !=3D qm->status.eqc_phase) { atomic64_inc(&qm->debug.dfx.err_irq_cnt); qm_db(qm, 0, QM_DOORBELL_CMD_EQ, qm->status.eq_head, 0); return; } =20 - cqn =3D le32_to_cpu(eqe->dw0) & QM_EQE_CQN_MASK; + cqn =3D dw0 & QM_EQE_CQN_MASK; if (unlikely(cqn >=3D qm->qp_num)) return; poll_data =3D &qm->poll_data[cqn]; =20 - while (QM_EQE_PHASE(eqe) =3D=3D qm->status.eqc_phase) { - cqn =3D le32_to_cpu(eqe->dw0) & QM_EQE_CQN_MASK; - poll_data->qp_finish_id[eqe_num] =3D cqn; + while (QM_EQE_PHASE(dw0) !=3D qm->status.eqc_phase) { + poll_data->qp_finish_id[eqe_num] =3D dw0 & QM_EQE_CQN_MASK; eqe_num++; =20 if (qm->status.eq_head =3D=3D eq_depth - 1) { @@ -1006,6 +1006,8 @@ static void qm_get_complete_eqe_num(struct hisi_qm *q= m) =20 if (eqe_num =3D=3D (eq_depth >> 1) - 1) break; + + dw0 =3D le32_to_cpu(eqe->dw0); } =20 poll_data->eqe_num =3D eqe_num; @@ -1098,15 +1100,15 @@ static irqreturn_t qm_aeq_thread(int irq, void *dat= a) { struct hisi_qm *qm =3D data; struct qm_aeqe *aeqe =3D qm->aeqe + qm->status.aeq_head; + u32 dw0 =3D le32_to_cpu(aeqe->dw0); u16 aeq_depth =3D qm->aeq_depth; u32 type, qp_id; =20 atomic64_inc(&qm->debug.dfx.aeq_irq_cnt); =20 - while (QM_AEQE_PHASE(aeqe) =3D=3D qm->status.aeqc_phase) { - type =3D (le32_to_cpu(aeqe->dw0) >> QM_AEQE_TYPE_SHIFT) & - QM_AEQE_TYPE_MASK; - qp_id =3D le32_to_cpu(aeqe->dw0) & QM_AEQE_CQN_MASK; + while (QM_AEQE_PHASE(dw0) =3D=3D qm->status.aeqc_phase) { + type =3D (dw0 >> QM_AEQE_TYPE_SHIFT) & QM_AEQE_TYPE_MASK; + qp_id =3D dw0 & QM_AEQE_CQN_MASK; =20 switch (type) { case QM_EQ_OVERFLOW: @@ -1134,6 +1136,7 @@ static irqreturn_t qm_aeq_thread(int irq, void *data) aeqe++; qm->status.aeq_head++; } + dw0 =3D le32_to_cpu(aeqe->dw0); } =20 qm_db(qm, 0, QM_DOORBELL_CMD_AEQ, qm->status.aeq_head, 0); --=20 2.33.0 From nobody Sun Feb 8 13:40:23 2026 Received: from canpmsgout12.his.huawei.com (canpmsgout12.his.huawei.com [113.46.200.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5033A2EA735; Sat, 25 Oct 2025 10:13:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761387185; cv=none; b=uETStwoevUHTo5ZTWxY10CGcF+RZHEP3a0+52kdse+CNIz1DObkRe5UjL3sOtYe3huHUOT8BNUcaYf/dugfSotw23kz0K7mEwqneWdnZ8bGxa/DZnB/fNO/a9W678JD6jJMEx9EN2QK/jRdoGGjyvfNHU6JODNdqzljJeFudfhA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761387185; c=relaxed/simple; bh=/sNgSAdf8Cd5KPAOTHV6fHNexKiZAdfuzHqQLFaO2hI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=T2191UMEF+HCAeN4qo298ytJTwjhgj9zv6x7Kp/jl5iOjA6YGtkyiDV968DEaUJeV9u+I4fNksigZsUokl/yQQbLTUaKi9J5j/8YsnwgYwyvZ95LMG05RM19cYBF53t1aFW0Yo1N9Ag5kRSrOqgoZ3ozVCO5z4wg8kMxxAOU/Gs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=1tIssE9y; arc=none smtp.client-ip=113.46.200.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="1tIssE9y" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=+vvg9scQ6IncnhGrN5fA/hR1Wev2paxZFanOz8GdgIM=; b=1tIssE9ys9J8aF3aJlKmwGv4VBqXsYO/ylNHmQ9W5WgCM/Oh//QYxztO/nmQGJQ2LPP7oXjv3 E0Sw5w3CUbkRXxqEu3aNTGnqInK672tTC04MUgyUoCjL6pir9Sn55LFtnT+1sntgKRb7ieOFfu+ Ju4nuo8Stj/mcYEm9RYIGIY= Received: from mail.maildlp.com (unknown [172.19.88.163]) by canpmsgout12.his.huawei.com (SkyGuard) with ESMTPS id 4ctwYd4CTKznTW3; Sat, 25 Oct 2025 18:12:21 +0800 (CST) Received: from dggemv706-chm.china.huawei.com (unknown [10.3.19.33]) by mail.maildlp.com (Postfix) with ESMTPS id 09E341800CE; Sat, 25 Oct 2025 18:13:01 +0800 (CST) Received: from kwepemq200001.china.huawei.com (7.202.195.16) by dggemv706-chm.china.huawei.com (10.3.19.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 25 Oct 2025 18:13:00 +0800 Received: from localhost.huawei.com (10.90.31.46) by kwepemq200001.china.huawei.com (7.202.195.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 25 Oct 2025 18:13:00 +0800 From: Chenghai Huang To: , CC: , , , , , , , Subject: [PATCH 2/4] crypto: hisilicon/qm - add concurrency protection for variable err_threshold Date: Sat, 25 Oct 2025 18:12:56 +0800 Message-ID: <20251025101258.2793179-3-huangchenghai2@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20251025101258.2793179-1-huangchenghai2@huawei.com> References: <20251025101258.2793179-1-huangchenghai2@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems100001.china.huawei.com (7.221.188.238) To kwepemq200001.china.huawei.com (7.202.195.16) Content-Type: text/plain; charset="utf-8" From: nieweiqiang The isolate_strategy_store function is not protected by a lock. If sysfs operations and functions that depend on the err_threshold variable,such as qm_hw_err_isolate(), execute concurrently, the outcome will be unpredictable. Therefore, concurrency protection should be added for the err_threshold variable. Signed-off-by: nieweiqiang Signed-off-by: Chenghai Huang --- drivers/crypto/hisilicon/qm.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c index 8274da8b37ca..c58f67567c12 100644 --- a/drivers/crypto/hisilicon/qm.c +++ b/drivers/crypto/hisilicon/qm.c @@ -2655,10 +2655,10 @@ static int qm_hw_err_isolate(struct hisi_qm *qm) } } list_add(&hw_err->list, &isolate->qm_hw_errs); - mutex_unlock(&isolate->isolate_lock); =20 if (count >=3D isolate->err_threshold) isolate->is_isolate =3D true; + mutex_unlock(&isolate->isolate_lock); =20 return 0; } @@ -2667,12 +2667,10 @@ static void qm_hw_err_destroy(struct hisi_qm *qm) { struct qm_hw_err *err, *tmp; =20 - mutex_lock(&qm->isolate_data.isolate_lock); list_for_each_entry_safe(err, tmp, &qm->isolate_data.qm_hw_errs, list) { list_del(&err->list); kfree(err); } - mutex_unlock(&qm->isolate_data.isolate_lock); } =20 static enum uacce_dev_state hisi_qm_get_isolate_state(struct uacce_device = *uacce) @@ -2700,10 +2698,12 @@ static int hisi_qm_isolate_threshold_write(struct u= acce_device *uacce, u32 num) if (qm->isolate_data.is_isolate) return -EPERM; =20 + mutex_lock(&qm->isolate_data.isolate_lock); qm->isolate_data.err_threshold =3D num; =20 /* After the policy is updated, need to reset the hardware err list */ qm_hw_err_destroy(qm); + mutex_unlock(&qm->isolate_data.isolate_lock); =20 return 0; } @@ -2740,7 +2740,10 @@ static void qm_remove_uacce(struct hisi_qm *qm) struct uacce_device *uacce =3D qm->uacce; =20 if (qm->use_sva) { + mutex_lock(&qm->isolate_data.isolate_lock); qm_hw_err_destroy(qm); + mutex_unlock(&qm->isolate_data.isolate_lock); + uacce_remove(uacce); qm->uacce =3D NULL; } --=20 2.33.0 From nobody Sun Feb 8 13:40:23 2026 Received: from canpmsgout07.his.huawei.com (canpmsgout07.his.huawei.com [113.46.200.222]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A5E12EA744; Sat, 25 Oct 2025 10:13:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.222 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761387186; cv=none; b=LiCh/imlu3BKytawd2YWOVpHkiW7a27BdHviDMvDprkgDUzTJ3lv2PoqdMAfvWKIulBumMDFFEUxrvmcPROhHu5N4ZWO6bQdLJOvijQwekcXgOqHWmH3vrMX8b5CHCFDM0YmL/uQJTPj6yBmBrGtgMMg8CiX2UsvhVTqmg+zBLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761387186; c=relaxed/simple; bh=Dvn1o72U62CdSqo9ZyxTIhHzvNSKMh9CoVY2VL8+UtY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WKXo8UKxhw4ZduWTOn+xu6LaQTBHn+bA5KiXc89WkKEpjC/7VguamTvoT6voyhTsynHbZCJwDrwEwGaDmFcvkG7AKXU6EXPvZmNjPJ0t3thMV5tOv0qNZsO31MExcS1Z7xazfJqSKl5Uokbe9f6x8rOkrjtbk9bLSFnj+wyVGDc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=6d5utqZi; arc=none smtp.client-ip=113.46.200.222 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="6d5utqZi" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=04ySr9M3DOvDpWiPMzdKjL50HWC8oyWtjt0IA3JB2DM=; b=6d5utqZiVXI2ng7YvwRqMHqanJNv5EAJxNiiiuZIgd2UQdqyOO/uTABdDwhYmMLy8jC2Ef86n w4WYKDYmpd1bVZ3j47aOJvzKCZsGWh7y2M7iAZFY4KR5lbjle867OFjb1ctV8niUO/fDUDXGW/E oT4RLTj+ejp3JOJKp3Pn14w= Received: from mail.maildlp.com (unknown [172.19.163.17]) by canpmsgout07.his.huawei.com (SkyGuard) with ESMTPS id 4ctwYt72WJzLlZ1; Sat, 25 Oct 2025 18:12:34 +0800 (CST) Received: from dggemv712-chm.china.huawei.com (unknown [10.1.198.32]) by mail.maildlp.com (Postfix) with ESMTPS id 6CC2E1A0188; Sat, 25 Oct 2025 18:13:01 +0800 (CST) Received: from kwepemq200001.china.huawei.com (7.202.195.16) by dggemv712-chm.china.huawei.com (10.1.198.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 25 Oct 2025 18:13:01 +0800 Received: from localhost.huawei.com (10.90.31.46) by kwepemq200001.china.huawei.com (7.202.195.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 25 Oct 2025 18:13:00 +0800 From: Chenghai Huang To: , CC: , , , , , , , Subject: [PATCH 3/4] crypto: hisilicon/sgl - remove unnecessary checks for curr_hw_sgl error Date: Sat, 25 Oct 2025 18:12:57 +0800 Message-ID: <20251025101258.2793179-4-huangchenghai2@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20251025101258.2793179-1-huangchenghai2@huawei.com> References: <20251025101258.2793179-1-huangchenghai2@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems100001.china.huawei.com (7.221.188.238) To kwepemq200001.china.huawei.com (7.202.195.16) Content-Type: text/plain; charset="utf-8" From: nieweiqiang Before calling acc_get_sgl(), the mem_block has already been created. acc_get_sgl() will not return NULL or any other error. so the return value check can be removed. Signed-off-by: nieweiqiang Signed-off-by: Chenghai Huang --- drivers/crypto/hisilicon/sgl.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/crypto/hisilicon/sgl.c b/drivers/crypto/hisilicon/sgl.c index 7a9ef2a9972a..24c7b6ab285b 100644 --- a/drivers/crypto/hisilicon/sgl.c +++ b/drivers/crypto/hisilicon/sgl.c @@ -245,11 +245,6 @@ hisi_acc_sg_buf_map_to_hw_sgl(struct device *dev, stru= ct scatterlist *sgl, } =20 curr_hw_sgl =3D acc_get_sgl(pool, index, &curr_sgl_dma); - if (IS_ERR(curr_hw_sgl)) { - dev_err(dev, "Get SGL error!\n"); - ret =3D -ENOMEM; - goto err_unmap; - } curr_hw_sgl->entry_length_in_sgl =3D cpu_to_le16(pool->sge_nr); curr_hw_sge =3D curr_hw_sgl->sge_entries; =20 --=20 2.33.0 From nobody Sun Feb 8 13:40:23 2026 Received: from canpmsgout10.his.huawei.com (canpmsgout10.his.huawei.com [113.46.200.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2E442EA744; Sat, 25 Oct 2025 10:13:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.225 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761387192; cv=none; b=dZ60nMyi31oyTRoOHcO4tDu3Y/r6ZTPytcymdkTAj/nflNXgK/Bg9niZMi+cyTu8lh3ZLdWKIUmhN5PhDKc3VRltKCasxBSuplgYEvD7sFDXBWUAY7i7HONufAz6kQVtlQGzExkfQ4IHKcNaRcyivWPnclfT46SspJ64QBhZKEE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761387192; c=relaxed/simple; bh=7qAFrOqHQqL/N9b2GOMeXhE1wZha/G4+phmlaVglsw4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ad30Pyu1jVRtLYkJL282o0oMiv4WTZoGvoT/26MzZVdZhl+59YeCDzoNJvW1PmlwyBHJ1lCtdEaTvvIYxuY4fiGqKdlifgNV49XJlMwNtCl4pSYQ2QyfKJ1WNApmPV2kt1lq8UnjS5QGEFfKZjJwKrI6Z8EEj2Lw+leLJAwTvNY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=2Z+M4ydR; arc=none smtp.client-ip=113.46.200.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="2Z+M4ydR" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=dImqEllVv0WBv8WKcE++wx2EPyDK7ZOeok9lsbf3yUo=; b=2Z+M4ydRJ+rc8Y7w1vUaHPmwPCtunmxGlBe3lPDAJSyVsQREMiKDcjizvLVENb+R+sM6khCPV Fv2StPKu7BbgR6Qaj4HURq8eTxPWHiG8EOjrmM13NdchWpnlABmASg387RI1Qj/C9FfPWpY1m8Y faIPc6jwOOdQiCnmkxXk9dE= Received: from mail.maildlp.com (unknown [172.19.162.112]) by canpmsgout10.his.huawei.com (SkyGuard) with ESMTPS id 4ctwYw1NJDz1K97v; Sat, 25 Oct 2025 18:12:36 +0800 (CST) Received: from dggemv705-chm.china.huawei.com (unknown [10.3.19.32]) by mail.maildlp.com (Postfix) with ESMTPS id E78041402C4; Sat, 25 Oct 2025 18:13:01 +0800 (CST) Received: from kwepemq200001.china.huawei.com (7.202.195.16) by dggemv705-chm.china.huawei.com (10.3.19.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 25 Oct 2025 18:13:01 +0800 Received: from localhost.huawei.com (10.90.31.46) by kwepemq200001.china.huawei.com (7.202.195.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 25 Oct 2025 18:13:01 +0800 From: Chenghai Huang To: , CC: , , , , , , , Subject: [PATCH 4/4] crypto: hisilicon/qm - add missing default in switch in qm_vft_data_cfg Date: Sat, 25 Oct 2025 18:12:58 +0800 Message-ID: <20251025101258.2793179-5-huangchenghai2@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20251025101258.2793179-1-huangchenghai2@huawei.com> References: <20251025101258.2793179-1-huangchenghai2@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems100001.china.huawei.com (7.221.188.238) To kwepemq200001.china.huawei.com (7.202.195.16) Content-Type: text/plain; charset="utf-8" From: nieweiqiang Add default case to avoid warnings and meet code style requirements. Signed-off-by: nieweiqiang Signed-off-by: Chenghai Huang --- drivers/crypto/hisilicon/qm.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c index c58f67567c12..a016a7d6059c 100644 --- a/drivers/crypto/hisilicon/qm.c +++ b/drivers/crypto/hisilicon/qm.c @@ -1286,6 +1286,13 @@ static void qm_vft_data_cfg(struct hisi_qm *qm, enum= vft_type type, u32 base, (factor->cbs_s << QM_SHAPER_FACTOR_CBS_S_SHIFT); } break; + /* + * Note: The current logic only needs to handle the above three types + * If new types are added, they need to be supplemented here, + * otherwise undefined behavior may occur. + */ + default: + break; } } =20 --=20 2.33.0