From nobody Sun Feb 8 01:30:18 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 979562E6CB9 for ; Sat, 25 Oct 2025 07:43:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761378242; cv=none; b=Bg5cUfjdCe+mxn4Fw2PMwhS+fdLCsoaE79DSdiBvnHd7HF+Q9zEhQxLjvohQl2sOl9L7Ek3CPA3dJwXSoLKeA8NzmMZChaZcAiRNAdTakcGVBTuLFsbUD0IMqYRGstMT92/0fGBxFrFV5hnmn83B/H3wyxs7oMH/79x5ZyrmSjU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761378242; c=relaxed/simple; bh=m/7BPONg68GpSItsiRmhbTDWbchfGgM+P5xwH8qJZCU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jF6c1z7NdbkSji7N6tt4FZTEgTDIsqz4WEUZjvkMhEATTIRY1zKKjWXzN2q6HRU5CJ4jJiEi68SY5ILIzqzJve97Ti/u9z9hByle5QKOIRsX1Oa0xmggK6w2hi+KZBsiCc6gc3qqKvaaeCggyuLziAWLHPwEf9iJf3v4Nu7DmF4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G8WUl0bw; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G8WUl0bw" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-79ef9d1805fso3175915b3a.1 for ; Sat, 25 Oct 2025 00:43:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761378239; x=1761983039; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yAWi08Lab8Pg0FL7IYkK8ydZGRVaUiT7SC194s0JYPE=; b=G8WUl0bweiBaj+0V7YRznPlhSg894PknHJWVabF96EwMPVkqNeBdduYijeN/b5inIp rEtn2R8oykoCgzKs1p7b/v6cDpHhcZP65DWNOQwaxyN8wUh2z0r3f6uSRtfe3qnZpVAb IRAa0gZKhqUADh7vy/Xh1T1gOb95TkCNHqM+tNj4/76adUzK+d7o70e4WcygVpL5j+YL 976nOJZrQB6eyPiD+SGw+OlpCVWftyZJa9QBNCojEONZKB3yhPRwnl/z7r/OIvrhxHV8 ts2Cam/1bpQ2S2R8QEWE7UAEdSzbui2vDoKjT2VFFSzKSjOD8i+s+sbenbTmvVWfZELQ axgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761378239; x=1761983039; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yAWi08Lab8Pg0FL7IYkK8ydZGRVaUiT7SC194s0JYPE=; b=tmKkJ2Z9TshX0Q/xtanfTJUmsnVeaPweWrbGOCCG94IB+sl+0x8X0m0VT0kQJ3rvRx 76hWuvVgs7BJZizRbB1qEUzFsmLGHlUXdUZ+KfO1rfLv9g3mBP34rWx1iaKWRUXRR5vr T01dKcWS988GOw9VZWYvdeGqi/tmuIAubWCELg/nv1SE85Q0tdbGvqKlE2fT1G4HRAst BDW9A9FaiIp0vMOTk/pTmx6kfeblYPd/mBJ/WSSEo9eAOwJfsAJleifAYFlACH+dYJlq 54b5jtCtteNRg/8j/sdlbQaJrfCt7AD58SKm0fBOeypLFnYlK6nJgPILkq5Qu2pVnCcn lteQ== X-Forwarded-Encrypted: i=1; AJvYcCV/IycPaE1ap289sramO13UJ8ZjznZFA3vWsg9L9IxJKYKh02ulu6RSOKMCe+mtCDiFgwtBqpbBlsNiXDE=@vger.kernel.org X-Gm-Message-State: AOJu0YwMl838ps8R9AzU0OiYsmpaBfiAAqLB6IUamsS1tUrACdHYNeZw 4my4NqORzSJmVoaHUjvZll7YIXwqCSQ0A8O+bPS7F96UejPwvDaU+QkF X-Gm-Gg: ASbGncv/M2xG8GwL+G7jLhkfqcolcHGG52rBNCPHpIy4iTt38WuE6zXhKRyt8AZgzUV 90sz1GhohX53CudvsHlEx5SJac8brrOQmRD5X4krz25pTm0Nldsj9JnOO3/hUkXDgSq8fJ7zWQ6 c1DmYUE7HW+n70OroElsv3bV1iOces1cu56VGp6BT12QKbg3eGq7agwKN9ZoofLDZV+0cJW12m8 dssqZlhqBiyaqi5pi2lq+ZVPoPV9cFJEHgxVD4FUfworNDwX/m0AtstKD2/RCRS62cxihfo4RIp M9A7xHRN13KO6Ufggo9pysq7NFE9Z0qOnB3jMJK3hTrdvzN3vpzAkPyQQxI3SlUtKoAzbapxr3q 73OZYFkRiaSkGl0nTUoW95vWfoUfuCYmOt0YsCfYt4g59YJN9wcLGFoYxmusyQfcc8kHtlR/b4C bt4+Dv6ZOtele9vxjQCp0= X-Google-Smtp-Source: AGHT+IGHRGT9hB86/YyYWO+q0YYgQ20bBMxTaREfTvNN83eWQaMSQ0mxbxIpiJAX3TL83FC5ARBuiA== X-Received: by 2002:a05:6a20:1590:b0:334:b732:6e5c with SMTP id adf61e73a8af0-33c600a5574mr9633829637.13.1761378239355; Sat, 25 Oct 2025 00:43:59 -0700 (PDT) Received: from rockpi-5b ([45.112.0.108]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7a41404d760sm1395083b3a.39.2025.10.25.00.43.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 00:43:58 -0700 (PDT) From: Anand Moon To: Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , linux-omap@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-pci@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-arm-kernel@lists.infradead.org (moderated list:PCI DRIVER FOR TI DRA7XX/J721E), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon , Markus Elfring , Dan Carpenter Subject: [PATCH v2 2/2] PCI: j721e: Use inline reset GPIO assignment and drop local variable Date: Sat, 25 Oct 2025 13:13:32 +0530 Message-ID: <20251025074336.26743-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251025074336.26743-1-linux.amoon@gmail.com> References: <20251025074336.26743-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The result of devm_gpiod_get_optional() is now assigned directly assigned to pcie->reset_gpio. This removes a superfluous local gpiod variable, improving code readability and compactness. The functionality remains unchanged, but the code is now more streamlined Cc: Siddharth Vadapalli Reviewed-by: Siddharth Vadapalli Signed-off-by: Anand Moon --- v2: fix the commit message. v1: Add Rb - Siddharth --- drivers/pci/controller/cadence/pci-j721e.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/contr= oller/cadence/pci-j721e.c index b678f7d48206..633fe8f93102 100644 --- a/drivers/pci/controller/cadence/pci-j721e.c +++ b/drivers/pci/controller/cadence/pci-j721e.c @@ -477,7 +477,6 @@ static int j721e_pcie_probe(struct platform_device *pde= v) struct j721e_pcie *pcie; struct cdns_pcie_rc *rc =3D NULL; struct cdns_pcie_ep *ep =3D NULL; - struct gpio_desc *gpiod; void __iomem *base; u32 num_lanes; u32 mode; @@ -589,12 +588,12 @@ static int j721e_pcie_probe(struct platform_device *p= dev) =20 switch (mode) { case PCI_MODE_RC: - gpiod =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); - if (IS_ERR(gpiod)) { - ret =3D dev_err_probe(dev, PTR_ERR(gpiod), "Failed to get reset GPIO\n"= ); + pcie->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW= ); + if (IS_ERR(pcie->reset_gpio)) { + ret =3D dev_err_probe(dev, PTR_ERR(pcie->reset_gpio), + "Failed to get reset GPIO\n"); goto err_get_sync; } - pcie->reset_gpio =3D gpiod; =20 ret =3D cdns_pcie_init_phy(dev, cdns_pcie); if (ret) { @@ -616,9 +615,9 @@ static int j721e_pcie_probe(struct platform_device *pde= v) * This shall ensure that the power and the reference clock * are stable. */ - if (gpiod) { + if (pcie->reset_gpio) { msleep(PCIE_T_PVPERL_MS); - gpiod_set_value_cansleep(gpiod, 1); + gpiod_set_value_cansleep(pcie->reset_gpio, 1); } =20 ret =3D cdns_pcie_host_setup(rc); --=20 2.50.1