From nobody Sun Feb 8 10:23:37 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51A552D0C73 for ; Fri, 24 Oct 2025 20:28:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761337715; cv=pass; b=aekncGO11eI+1jbQNRxKvQa0AaEFUxZi+x9rlXvtgGNd7kQT7HiGH3OKMyJY1kVTLY6pua3vwtf2G6BM2y1vgu3iSF+bcrIq85SaPW80pX1S+MQZR9mbI82jjr8RpPOk01/QYwRRnRhym9/ARVWO+R30b531vFMpPl5dzZme8N8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761337715; c=relaxed/simple; bh=QGkyq/h5Ueq5Zz3xvXnNG90p/83x3z1w4yjbbQeh1NU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CZrMvNQkQCGcR2NQ3YUJlAjqbGmweLdaSoCTdGXVOu5KkkCF8gS+dopXsnpxwjv7kAJuOTGC1dc9D/20HagtXTAI2+ks1ZyDMZXqjQqY9Mw8gTER+G8IFWAi9uJnxzYFye9bKTakn3Kczku/xghb/gCtUFEuXHbFiH+CVbFcvW0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=ariel.dalessandro@collabora.com header.b=QqwrA7/+; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=ariel.dalessandro@collabora.com header.b="QqwrA7/+" ARC-Seal: i=1; a=rsa-sha256; t=1761337688; cv=none; d=zohomail.com; s=zohoarc; b=SEArvOlfH74vbjfMVG1sMPtbC93q5M1zvlCuU2xI0VJgmLY6aMI1AYvVBIj98RnkZU+WOFV9hFzb+uTGmZBGDA2vt7VAx3K+WhGbYTV3n+h+xTikesZtPOkl6z/8VZUphMxnIT0kfHsFgxJjRKKee2Y+8T4T7A17VCfS+NghSyY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761337688; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=vOr8Rrr+mnTgf6ee9RR/hGBWYF0gos8pVivXS5bthXk=; b=e/yWhpTf2ghOdv+R0yhXNxrmu4PZ0YDPf9t1/YlklAawpyi9fa2/UbbrcSz0PC8Ik3jyf1kbcOFI0A8nq4MxLb7V9I+YvJbP4TRMa9H7hJzwmfZZaytCKeLFnqR6IlGEXPs/VOng0q1nD+g1pHz9hK+iDkVyzMnrnlGT0Ixt0dA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=ariel.dalessandro@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1761337688; s=zohomail; d=collabora.com; i=ariel.dalessandro@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=vOr8Rrr+mnTgf6ee9RR/hGBWYF0gos8pVivXS5bthXk=; b=QqwrA7/+ngNK0OlEGLSZVwKegylTw5G5SwQBuhL6vhvuPu2OtdKmcWcSTag4gY5R FZiYfRrdTFyhIRZq0Ivlj5yClWpjbnhy+/ROBgCYEr2Rs1OnvNKD6ROVVwxzmfM4xHf VbFtapebmfdacOZCa0lAfgIy1LGY/rCN2dAfwX/c= Received: by mx.zohomail.com with SMTPS id 1761337687432824.4758348720163; Fri, 24 Oct 2025 13:28:07 -0700 (PDT) From: Ariel D'Alessandro To: chunkuang.hu@kernel.org, p.zabel@pengutronix.de, airlied@gmail.com, simona@ffwll.ch, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, greenjustin@chromium.org, sjoerd@collabora.com Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com, Ariel D'Alessandro Subject: [PATCH] drm/mediatek: Disable AFBC support on Mediatek DRM driver Date: Fri, 24 Oct 2025 17:27:56 -0300 Message-ID: <20251024202756.811425-1-ariel.dalessandro@collabora.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Content-Type: text/plain; charset="utf-8" Commit c410fa9b07c32 ("drm/mediatek: Add AFBC support to Mediatek DRM driver") added AFBC support to Mediatek DRM and enabled the 32x8/split/sparse modifier. However, this is currently broken on Mediatek MT8188 (Genio 700 EVK platform); tested using upstream Kernel and Mesa (v25.2.1), AFBC is used by default since Mesa v25.0. Kernel trace reports vblank timeouts constantly, and the render is garbled: ``` [CRTC:62:crtc-0] vblank wait timed out WARNING: CPU: 7 PID: 70 at drivers/gpu/drm/drm_atomic_helper.c:1835 drm_ato= mic_helper_wait_for_vblanks.part.0+0x24c/0x27c [...] Hardware name: MediaTek Genio-700 EVK (DT) Workqueue: events_unbound commit_work pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=3D--) pc : drm_atomic_helper_wait_for_vblanks.part.0+0x24c/0x27c lr : drm_atomic_helper_wait_for_vblanks.part.0+0x24c/0x27c sp : ffff80008337bca0 x29: ffff80008337bcd0 x28: 0000000000000061 x27: 0000000000000000 x26: 0000000000000001 x25: 0000000000000000 x24: ffff0000c9dcc000 x23: 0000000000000001 x22: 0000000000000000 x21: ffff0000c66f2f80 x20: ffff0000c0d7d880 x19: 0000000000000000 x18: 000000000000000a x17: 000000040044ffff x16: 005000f2b5503510 x15: 0000000000000000 x14: 0000000000000000 x13: 74756f2064656d69 x12: 742074696177206b x11: 0000000000000058 x10: 0000000000000018 x9 : ffff800082396a70 x8 : 0000000000057fa8 x7 : 0000000000000cce x6 : ffff8000823eea70 x5 : ffff0001fef5f408 x4 : ffff80017ccee000 x3 : ffff0000c12cb480 x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff0000c12cb480 Call trace: drm_atomic_helper_wait_for_vblanks.part.0+0x24c/0x27c (P) drm_atomic_helper_commit_tail_rpm+0x64/0x80 commit_tail+0xa4/0x1a4 commit_work+0x14/0x20 process_one_work+0x150/0x290 worker_thread+0x2d0/0x3ec kthread+0x12c/0x210 ret_from_fork+0x10/0x20 Reviewed-by: CK Hu Reviewed-by: Daniel Stone Reviewed-by: Macpaul Lin ---[ end trace 0000000000000000 ]--- ``` Until this gets fixed upstream, disable AFBC support on this platform, as it's currently broken with upstream Mesa. Signed-off-by: Ariel D'Alessandro --- drivers/gpu/drm/mediatek/mtk_plane.c | 24 +----------------------- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_plane.c b/drivers/gpu/drm/mediate= k/mtk_plane.c index 02349bd440017..788b52c1d10c5 100644 --- a/drivers/gpu/drm/mediatek/mtk_plane.c +++ b/drivers/gpu/drm/mediatek/mtk_plane.c @@ -21,9 +21,6 @@ =20 static const u64 modifiers[] =3D { DRM_FORMAT_MOD_LINEAR, - DRM_FORMAT_MOD_ARM_AFBC(AFBC_FORMAT_MOD_BLOCK_SIZE_32x8 | - AFBC_FORMAT_MOD_SPLIT | - AFBC_FORMAT_MOD_SPARSE), DRM_FORMAT_MOD_INVALID, }; =20 @@ -71,26 +68,7 @@ static bool mtk_plane_format_mod_supported(struct drm_pl= ane *plane, uint32_t format, uint64_t modifier) { - if (modifier =3D=3D DRM_FORMAT_MOD_LINEAR) - return true; - - if (modifier !=3D DRM_FORMAT_MOD_ARM_AFBC( - AFBC_FORMAT_MOD_BLOCK_SIZE_32x8 | - AFBC_FORMAT_MOD_SPLIT | - AFBC_FORMAT_MOD_SPARSE)) - return false; - - if (format !=3D DRM_FORMAT_XRGB8888 && - format !=3D DRM_FORMAT_ARGB8888 && - format !=3D DRM_FORMAT_BGRX8888 && - format !=3D DRM_FORMAT_BGRA8888 && - format !=3D DRM_FORMAT_ABGR8888 && - format !=3D DRM_FORMAT_XBGR8888 && - format !=3D DRM_FORMAT_RGB888 && - format !=3D DRM_FORMAT_BGR888) - return false; - - return true; + return modifier =3D=3D DRM_FORMAT_MOD_LINEAR; } =20 static void mtk_plane_destroy_state(struct drm_plane *plane,