From nobody Sun Feb 8 15:28:48 2026 Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55FE836A611 for ; Fri, 24 Oct 2025 19:16:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761333363; cv=none; b=RUFoYEGWDuiuB5XZsArN7bfvWQL6Ge8LnD1ztOpPqPjJukWMC39i3wSrYEy9FA8vKra7LC2zZu4XG+nwB5uLt07HqjyocZTPieKh7V3OdU3bqWd64CVXAVM/JveBG+PYCxBmJB0jSeEQm5OShTFU+9U6CEKudHEQAEDzgBVCYMQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761333363; c=relaxed/simple; bh=GdKb+Uk6ps8nMgwL/qeWK8J0hHUVDxnEmafXGXdT8Uw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bu9vKUU3sDosKlRikZ9naDREgEDCJT4PgdSSKTfRvzBTSV0Crh14NL6Oq9fx+AGJI41TiD42n7RF43lW75J7N4e792Fhp+i/mM5GIDHGtDX5J3XDl65iPsCPF6/nVVPnIGSbciCu0yfx9i+JeZa/pxHzUmK3Muy5hs1Wu07Pjpo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=rRLK2RNN; arc=none smtp.client-ip=209.85.166.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="rRLK2RNN" Received: by mail-il1-f171.google.com with SMTP id e9e14a558f8ab-430ae09ea23so9905745ab.0 for ; Fri, 24 Oct 2025 12:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1761333360; x=1761938160; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bdm2X0Uh+6QoNIFH/yUFpeoxSayQYwUIia5PVqWIucY=; b=rRLK2RNNF/0qlsQJt/38SbCoilQXm6gy4bAelaxyAE+dPXVBy3kkNdNB1D+YXMngX3 RyCEJ+hTt3Q7LjGmA2/S8ZZIZ97bi9y3EGvS2wMW6ublJzNQUixSEkR5n7nBDpmBtCXX Ok483E8k7fRdsl8jR3oWYp5RowGEwMSL43NkjTVzy6XwsX7Fi5ILOvCNeiOfci2KWYVL RgW8f6/LIZ+PjRcBlZA9p5F3CQwaiM93H2fSLiEYd4eZGCt5uYyjL0Pp5EBsbyu0CrLG Ua+b1W5ZGjGZBYRXBKsPVercO+wcyoFF9yy5fGESal59Oh+qvA4Cr2KCpJHu50QFo01E V8Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761333360; x=1761938160; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bdm2X0Uh+6QoNIFH/yUFpeoxSayQYwUIia5PVqWIucY=; b=XpZ/OiHlH7pi20DsEPeQwE84uHcEtGkorUFk8mgVnJ6UyTA/Q6nQkWfwmuuAz3JknD WbaPrPlEB0XldHRyjCNgOZtnHNUwjKBT+TNusmwewVGOh+aC+zYABP7qmnFX62YWuuHI J1dDn6EW2ndqDIFz1CncqPiUCgO5CVbXGRgRf2aHImELvRcwg/QbigWaGi+dSghVQyPf s10SHYXBUh0HUBEz2SYf0k8AEL5g1RN3YkpWw0avFaXHJ+UDFwenxLec9TH4O3lcG9Jh 9uzjJDhvngyq0gwfRK5dHRcKFE2jbZ+agRD0XIQt8dTCnyzrt+7TH9bJwuAEJP3uGkI6 x9Hg== X-Forwarded-Encrypted: i=1; AJvYcCWBPJYOfTTIVhl4lX8nyRMEjFmTMVU9M4kIMrZRS80jbfTZA6tpF2mASZ8Z+bOv/HYArUMezyXUGy7N77c=@vger.kernel.org X-Gm-Message-State: AOJu0Yzu598TYdolJIlea0kTeB4lFRk//1T9GC5KqCKLbvKas93Fp1li 9De6CGLU03LtWTj+pEuBPSXn8ENm3gBYZ2G9NBQuRYXcCWdZDLz+fY+G/lHSyIiUF78= X-Gm-Gg: ASbGncuQ6uO4hGDU09nO9mvN0q0YGuoGmseAI0lvLXXSArQCVJtvLF0ISXJUxPvsdHF m+worcbPevMHTEEFbRmcESn5wApgeZXuWPTbK/WzPvCfglX69HKFzYWy+6L+10lhnC/W2d8Hmbp puee0Res6TAwdeGpMtjvn3BHyX882cQ8l3dEDRW++/cYvHBfpVI4zb+KJU63CY3ODNoSd6EruTZ QgijeBQOpiCJpBfW2aX893Vbce+aMFA/8Hlk/TpyIPSKPmf+0Ysj0xed9xrbBM2Lj/eIySIwG34 wB3xjT3JoBFSb9y74zXeIyIc3DB5ewvp5dW63Cb4xOhh51B/+vCwizy4QB/QceOKixslYruOtA6 EGUpTxV2Ze2tt68f8pEXn9TGNVo7fJDb2IdImZIIEPmmmvS6EL34zN8Aq1q6DtXnfM+Kf+MlrSo 0XBp7Dh2YfbEPJWn8IC/bbrKQQ+Cd8eziSiEcEa/oyB4o= X-Google-Smtp-Source: AGHT+IElepsQIkPTyqRqx2ZlqiV2TkOUrhFpvX3uGDnya5yADO7YFKd2LUmYcqJ1EtE3DJar2SatmQ== X-Received: by 2002:a05:6e02:144e:b0:42f:9353:c7bc with SMTP id e9e14a558f8ab-430c5209537mr363720175ab.6.1761333360521; Fri, 24 Oct 2025 12:16:00 -0700 (PDT) Received: from zippy.localdomain (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-5abb7fdb7c7sm2427824173.44.2025.10.24.12.15.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Oct 2025 12:16:00 -0700 (PDT) From: Alex Elder To: han.xu@nxp.com, broonie@kernel.org Cc: dlan@gentoo.org, Frank.li@nxp.com, guodong@riscstar.com, linux-spi@vger.kernel.org, imx@lists.linux.dev, spacemit@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 5/9] spi: fsl-qspi: add a clock disable quirk Date: Fri, 24 Oct 2025 14:15:45 -0500 Message-ID: <20251024191550.194946-6-elder@riscstar.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20251024191550.194946-1-elder@riscstar.com> References: <20251024191550.194946-1-elder@riscstar.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The SpacemiT K1 SoC QSPI implementation needs to avoid shutting off the clock when changing its rate. Add a new quirk to indicate that disabling and enabling the clock should be skipped when changing its rate. Signed-off-by: Alex Elder Reviewed-by: Frank Li --- v3: - needs_clk_disable() is no longer inline drivers/spi/spi-fsl-qspi.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-fsl-qspi.c b/drivers/spi/spi-fsl-qspi.c index 1944e63169d36..2c030dd6facc7 100644 --- a/drivers/spi/spi-fsl-qspi.c +++ b/drivers/spi/spi-fsl-qspi.c @@ -197,6 +197,11 @@ */ #define QUADSPI_QUIRK_USE_TDH_SETTING BIT(5) =20 +/* + * Do not disable the "qspi" clock when changing its rate. + */ +#define QUADSPI_QUIRK_SKIP_CLK_DISABLE BIT(6) + struct fsl_qspi_devtype_data { unsigned int rxfifo; unsigned int txfifo; @@ -306,6 +311,11 @@ static bool needs_tdh_setting(struct fsl_qspi *q) return !!(q->devtype_data->quirks & QUADSPI_QUIRK_USE_TDH_SETTING); } =20 +static bool needs_clk_disable(struct fsl_qspi *q) +{ + return !(q->devtype_data->quirks & QUADSPI_QUIRK_SKIP_CLK_DISABLE); +} + /* * An IC bug makes it necessary to rearrange the 32-bit data. * Later chips, such as IMX6SLX, have fixed this bug. @@ -536,15 +546,18 @@ static void fsl_qspi_select_mem(struct fsl_qspi *q, s= truct spi_device *spi, if (needs_4x_clock(q)) rate *=3D 4; =20 - fsl_qspi_clk_disable_unprep(q); + if (needs_clk_disable(q)) + fsl_qspi_clk_disable_unprep(q); =20 ret =3D clk_set_rate(q->clk, rate); if (ret) return; =20 - ret =3D fsl_qspi_clk_prep_enable(q); - if (ret) - return; + if (needs_clk_disable(q)) { + ret =3D fsl_qspi_clk_prep_enable(q); + if (ret) + return; + } =20 q->selected =3D spi_get_chipselect(spi, 0); =20 --=20 2.48.1