From nobody Sat Feb 7 18:55:37 2026 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B07BF1F1527 for ; Fri, 24 Oct 2025 14:34:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761316492; cv=none; b=Kivw5ucxvb5J/29MNoGPKutJ03HqdbloZVMg9lI79xU2tdipPLOe8aLXPZ6OC7IFehr5vM/B6ed5B2naNl+g+Z1f6OUbhKHCRwjO7wZLKRLL2HA2bvTV8FauQgO21KySoOp1q3yQAMOd4stq/w+eGeJZe6zjx/75Ss5fH7gdfTk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761316492; c=relaxed/simple; bh=a27ALe2yhOhsvti6rryDm6Ym6QY92NcDKqoAWfwQi2Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cvuQjTchECF4gzIwRHSFgMWd/4FExBsrEmWJUo0ybKppWHqIFlhoxAH+dNo9y+D9AIitRlMPjB0BdZrXe1+gMVbU7mIJUjGaK8vyHf4eiy8JbHgSDbKPMFWkTwKDonnNICPtPW12zwAgcj3voHmIK1rvLx5srDTVczuzJWx7mso= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LHYW7dRh; arc=none smtp.client-ip=209.85.215.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LHYW7dRh" Received: by mail-pg1-f196.google.com with SMTP id 41be03b00d2f7-b6cf1a95273so1567273a12.1 for ; Fri, 24 Oct 2025 07:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761316490; x=1761921290; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iQj29ABrwrijpvys50cDvqcS4VYVuuORqVZjjQai77I=; b=LHYW7dRhkJQVqCczSJ1nFqp6lBAog5W2mMpQ5vAe34oOHiehZxG+2pq9JWETM7/FLE 0fweWG8QQRXH6K1cf2taGMxlYQRpOP7/mLOFqWx11SIw0ZV9VnuOL4NLSLdXpapLbLMu 0lvmBjal6QzKE5wS4z9hZUoupCyk8+VZ+fQARFv51AfkOU7CpQWBmFFbBLZb161TAIom MxPTtnWh1CUqDN5WFVsw2/rZ/U8euub9lNm/Wr6L99etrSzjve8sGrul3qgxMK9rCpEB K8Lvar5vw1ZJy2LBxB/lUGzrfCMfwbKVKfuojrUSDbczE1kD0/q6VFUEPX2hB0A4qhJ3 wCSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761316490; x=1761921290; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iQj29ABrwrijpvys50cDvqcS4VYVuuORqVZjjQai77I=; b=nfZ7go+e1AEXy2EWWXdah5qDIMf2LRgvrvdvuGlXo1FKhm8UJX+HND1huv/M+9/OUM J2RJPusstr3wdO3fOs3YLPK74AyVNEZJPk7WMZL9mgSfbJDj/D64Q4Ef+8h7Fs48N0td QwRYp3ETZqwWcbUxzaZIfFn0t00FirXjtSrZ2NliYpbD6Er8DnwMFYdnrd8JbZi0KrCI 4glwsPf0Ed4ljvpIvibD8GinowjVODwhmz7f9ToobgttNc8Sczss+hnfiXd6cvOF2vpk j+AJSfjmLLVNmDt5hkbASIJTwLEzgCIcBDu970UZxoBINyGxcs0i6ojEAcQBz0/c8gZ+ 4IdA== X-Forwarded-Encrypted: i=1; AJvYcCVUMpOzjZqx7QrLgmYBgLxVT0se5xyarNsFo0SH0q5E/M0WbLZbWv+zU4QxQomWVxPVAWsd5CPrdF5+N4Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwLxo9yxhycUUtsZOLoyKCSJF9MMm/7Y7oZTSCIbQjIRUvzUd43 6ffP5EDSki8x6njYDpFihcWDeWfhidBWWCytvjN1qKWgDPfzpsw64cqJ X-Gm-Gg: ASbGncsK0Vu0jJzxh6gIYksl6DcUX5xniY/J7tWVQT40seET1AjDZvwToI+4nphXxuL spVmHRt4QKHH2Y+xm32fXrJ6zZmhUhujU5ELOBC+cxIWEXNO6wXDk6y1z4mmFJ8/gRCZkJ0oZ/r 2kTw2lDs2jHLkfp9z81mRBen1UPrPxUun4BXdWbm8t9EHFphOR0XjE5+5UlqYnDvzCTbGjF6Rge 8loRec8kI8gDmsu9GOQU6LJmsQpDJRFPQT5+uH7ieHrZeB2SjfJTboX8TS3QeDaU5xOSaadLrkw AmO5A8+OpOMoqAG+I/AA1NCRwfV/3hInnC9j6bdv9aK5hDzhocyfwxfowaoDclpm8W5VGVGvWki QGaN5WBZbrpr3x1gkvjnKlmdHCUf0q0IsMl6T7hiUruU7NCcjU5m7j3IQI1ObkRsZ4RPyyVAO4Y Ttvw0= X-Google-Smtp-Source: AGHT+IErBmFAi51GQfjC8jK8NrYQnDRXpNCqWG1VH5g/DWOWsQEd2w+wLD8u7UXeR1pIgqcyE2avew== X-Received: by 2002:a17:903:384c:b0:27e:d9a0:ba08 with SMTP id d9443c01a7336-290cb27dae5mr359060835ad.43.1761316489794; Fri, 24 Oct 2025 07:34:49 -0700 (PDT) Received: from sf2-6.. ([110.93.227.81]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2946de00dc7sm57822215ad.39.2025.10.24.07.34.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Oct 2025 07:34:49 -0700 (PDT) From: Ali Tariq To: kernel@esmil.dk Cc: alitariq45892@gmail.com, brgl@bgdev.pl, hal.feng@starfivetech.com, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] pinctrl: starfive: use dynamic GPIO base allocation Date: Fri, 24 Oct 2025 14:33:53 +0000 Message-ID: <20251024143353.71753-1-alitariq45892@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The JH7110 pinctrl driver currently sets a static GPIO base number from platform data: sfp->gc.base =3D info->gc_base; Static base assignment is deprecated and results in the following warning: gpio gpiochip0: Static allocation of GPIO base is deprecated, use dynamic allocation. Set `sfp->gc.base =3D -1` to let the GPIO core dynamically allocate the base number. This removes the warning and aligns the driver with current GPIO guidelines. Tested on VisionFive 2 (JH7110 SoC). Signed-off-by: Ali Tariq Reviewed-by: Emil Renner Berthing --- Changes in v2 - Remove unused gc_base field from struct jh7110_pinctrl_soc_info - Drop unused JH7110_SYS_GC_BASE and JH7110_AON_GC_BASE defines - Remove .gc_base assignments from jh7110_sys_pinctrl_info and jh7110_aon_= pinctrl_info - No functional change otherwise --- drivers/pinctrl/starfive/pinctrl-starfive-jh7110-aon.c | 2 -- drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c | 2 -- drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c | 2 +- drivers/pinctrl/starfive/pinctrl-starfive-jh7110.h | 1 - 4 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-aon.c b/drive= rs/pinctrl/starfive/pinctrl-starfive-jh7110-aon.c index cf42e204cbf0..3433b3c91692 100644 --- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-aon.c +++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-aon.c @@ -29,7 +29,6 @@ #include "pinctrl-starfive-jh7110.h" =20 #define JH7110_AON_NGPIO 4 -#define JH7110_AON_GC_BASE 64 =20 #define JH7110_AON_REGS_NUM 37 =20 @@ -138,7 +137,6 @@ static const struct jh7110_pinctrl_soc_info jh7110_aon_= pinctrl_info =3D { .pins =3D jh7110_aon_pins, .npins =3D ARRAY_SIZE(jh7110_aon_pins), .ngpios =3D JH7110_AON_NGPIO, - .gc_base =3D JH7110_AON_GC_BASE, .dout_reg_base =3D JH7110_AON_DOUT, .dout_mask =3D GENMASK(3, 0), .doen_reg_base =3D JH7110_AON_DOEN, diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c b/drive= rs/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c index 03c2ad808d61..9b67063a0b0b 100644 --- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c +++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c @@ -29,7 +29,6 @@ #include "pinctrl-starfive-jh7110.h" =20 #define JH7110_SYS_NGPIO 64 -#define JH7110_SYS_GC_BASE 0 =20 #define JH7110_SYS_REGS_NUM 174 =20 @@ -410,7 +409,6 @@ static const struct jh7110_pinctrl_soc_info jh7110_sys_= pinctrl_info =3D { .pins =3D jh7110_sys_pins, .npins =3D ARRAY_SIZE(jh7110_sys_pins), .ngpios =3D JH7110_SYS_NGPIO, - .gc_base =3D JH7110_SYS_GC_BASE, .dout_reg_base =3D JH7110_SYS_DOUT, .dout_mask =3D GENMASK(6, 0), .doen_reg_base =3D JH7110_SYS_DOEN, diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c b/drivers/p= inctrl/starfive/pinctrl-starfive-jh7110.c index 05e3af75b09f..eb5cf8c067d1 100644 --- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c +++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c @@ -938,7 +938,7 @@ int jh7110_pinctrl_probe(struct platform_device *pdev) sfp->gc.set =3D jh7110_gpio_set; sfp->gc.set_config =3D jh7110_gpio_set_config; sfp->gc.add_pin_ranges =3D jh7110_gpio_add_pin_ranges; - sfp->gc.base =3D info->gc_base; + sfp->gc.base =3D -1; sfp->gc.ngpio =3D info->ngpios; =20 jh7110_irq_chip.name =3D sfp->gc.label; diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.h b/drivers/p= inctrl/starfive/pinctrl-starfive-jh7110.h index a33d0d4e1382..2da2d6858008 100644 --- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.h +++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.h @@ -38,7 +38,6 @@ struct jh7110_pinctrl_soc_info { const struct pinctrl_pin_desc *pins; unsigned int npins; unsigned int ngpios; - unsigned int gc_base; =20 /* gpio dout/doen/din/gpioinput register */ unsigned int dout_reg_base; --=20 2.43.0