From nobody Wed Feb 11 00:56:44 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2FB32D0611 for ; Fri, 24 Oct 2025 11:50:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761306611; cv=none; b=Wb7+zue4T1kT4zAmLK4MehiTD6i25CiNf/q8tnJeHjKZ/MEWM6LZNdijUionImJE3gH/eJwmHP+QCp+1fhBrkn3Rbvg61GK9D30IqDmhch8Fmcw7S7qH8+pGLkHciTmV50um132KNivyKRB5G2bldmVrjGOh7nVTjCrLTQJPAZ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761306611; c=relaxed/simple; bh=y29lFhXLeue2fLW/T0fFDgVBn4WVWzZgaoMEythXz/o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JAWmBKXsLqrP8nqMEl8Kdc/ZisxC2QdIYX8npKAmaYmpYEdyy0E0yLwsl5EqvaceaJm4mxF4gdfrlkmvQEdXAT8rat4h0knuZChUCPMJUOYuz1e10v2Wj3nCwGHuA7Bf44KHquIaO/JK5G64qpmDBdHCOuh+poYjFbTtpzKNKqI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=ratatoskr.trumtrar.info) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1vCGJ4-0002FG-Bx; Fri, 24 Oct 2025 13:50:06 +0200 From: Steffen Trumtrar Date: Fri, 24 Oct 2025 13:49:53 +0200 Subject: [PATCH v5 01/10] net: stmmac: dwmac-socfpga: don't set has_gmac Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251024-v6-12-topic-socfpga-agilex5-v5-1-4c4a51159eeb@pengutronix.de> References: <20251024-v6-12-topic-socfpga-agilex5-v5-0-4c4a51159eeb@pengutronix.de> In-Reply-To: <20251024-v6-12-topic-socfpga-agilex5-v5-0-4c4a51159eeb@pengutronix.de> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dinh Nguyen , Maxime Chevallier , Maxime Coquelin , Alexandre Torgue , Matthew Gerlach Cc: kernel@pengutronix.de, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Steffen Trumtrar X-Mailer: b4 0.14.3 X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: s.trumtrar@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Instead of setting the has_gmac or has_xgmac fields, let stmmac_probe_config_dt()) fill these fields according to the more generic compatibles. Without setting the has_xgmac/has_gmac field correctly, even basic functions will fail, because the register offsets are different. Signed-off-by: Steffen Trumtrar --- drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/= net/ethernet/stmicro/stmmac/dwmac-socfpga.c index 354f01184e6cc..7ed125dcc73ea 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c @@ -497,7 +497,6 @@ static int socfpga_dwmac_probe(struct platform_device *= pdev) plat_dat->pcs_init =3D socfpga_dwmac_pcs_init; plat_dat->pcs_exit =3D socfpga_dwmac_pcs_exit; plat_dat->select_pcs =3D socfpga_dwmac_select_pcs; - plat_dat->has_gmac =3D true; =20 plat_dat->riwt_off =3D 1; =20 --=20 2.51.0