From nobody Sun Feb 8 06:54:12 2026 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AC8C2C15BB for ; Thu, 23 Oct 2025 20:50:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761252660; cv=none; b=NQuHiG94zJ/btD6/k4EICgdQfOUOz00flIw3TksrzV1pshWg2+cQDImmMNqqSr1zwU7BMBzEGaYxRGcToQSsGP0ePmzv0bxw5i9lwbYAM7ohIanaQdeHv/sDteZZk/QSbYmOUVNfGvzUHqgCjQSPJfRq1Ql37BzPXcVi+W175Mk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761252660; c=relaxed/simple; bh=C/1zX22wjI4qtmE/Rs+0jxW/rC4laO75J74Tq/ISSYo=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=uRRo2UZzKI6tVxWwXU7A1NGMdTKz0EKrNwMzMWgfrmn0tOmhe0Xo6pPERMp3QWI4nMYCZR/xX/UStg4gnqdjEfeV5JgJ0Zy24IlygnIZAxreuSFyH9K54l2lFwkXFw4fsFcKOIQ6DnNsl/gOXOJlWKnCjwxZIKPA2291STkfZq0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--willmcvicker.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=pIB0NClm; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--willmcvicker.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pIB0NClm" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-3307af9b55eso978637a91.2 for ; Thu, 23 Oct 2025 13:50:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1761252658; x=1761857458; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=n3ErCVLsFFmYy6ztYolejF5Ple6tVW26MCiEzz3ldVw=; b=pIB0NClmaULvLSTNIHcjIhIQz2exfmdB0n7aPUlM2BudOddYi9/tdy3QsMLB116Zyk 0R9up3sxyKMTBQyUNimYHGMXdD/u7SNZUWFFmUJdBom6mywJxCcahQXUJyCyryKh5Fqt cu1l+Boj3wrje/zynYz68QeWN8d8hO/t5I8qu/9jgUXm3OTGG2FMhMrYC4DAR79o16IF zrj2ruM2OYZ8/pmvIfJmzueZuFm3jAls/NSBRnzMyssQQeZd0LKMAb9ursVzARTq9iap DFMreHkKM07mt5FKUrz22bsK8XN1fl7LXSyA/WfBxmPwFeV0KCJXrcLLDxJrFpDc8CLe BrgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761252658; x=1761857458; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n3ErCVLsFFmYy6ztYolejF5Ple6tVW26MCiEzz3ldVw=; b=huHvYVrDFQgXaIGBboujd73mW81uIaAIJJZsXMKJGLDA5dErMXZks4qk/u75hGT+Wb bKe0WptOeTGil0s2869Tk055qvHcK3v0O3e/uOOU9ptm+KMuuy4NTn38+VXXH+Gbgv6l 5+ZxAeLogbEFDvGzXLIHw4FxLovP0eFkm2qTewu7wp2ywH5qmslGBnb8c7Du+ZX2Oozu aVDIvLbpc/rvLe7RQtoOkKekjvRKJOooFczndelQUmBFQZcgJNnLiaQdYI1ZHr88fnK7 NYBZSM1PEPrhOeLZIzm4TWqH6q5k9QQSeOmly1lOzVxYMxBllpLL/enpSB/EBOe/qQmr /M3Q== X-Forwarded-Encrypted: i=1; AJvYcCXRmsCfv54dhUUyVtgp+AMryUcJ2no9yim4sZsRdt/dgZf5/xYurqj3Y6IlkKDRnhamYYZGaLr2wBMyhcc=@vger.kernel.org X-Gm-Message-State: AOJu0YwUvIAulcWGSFEPgSVT3iXZ1S7eq1FftOC9EJpUyyaXamRfzGG2 CxOSoe4n3Az3ew1gycLBlnJ8PX33x6Nk9KttbEkcZZAiCihmM7Me9qcKAQjftyeSoUQeWmv2+PZ wybfP1/mWb/EJxY3fxQF7OMR2vc3kOA== X-Google-Smtp-Source: AGHT+IHJvKbU9UgJaSGXWAUX+DnipcUlKhq0hmwyYZnhUYzOqrdpDg7R1VNHjGHXBcYDkXnRvHh8GcGOhqCddYEK0g4= X-Received: from pjbsb7.prod.google.com ([2002:a17:90b:50c7:b0:33b:51fe:1a94]) (user=willmcvicker job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:33c3:b0:32e:8c14:5d09 with SMTP id 98e67ed59e1d1-33fafb97551mr5184629a91.7.1761252658519; Thu, 23 Oct 2025 13:50:58 -0700 (PDT) Date: Thu, 23 Oct 2025 20:50:31 +0000 In-Reply-To: <20251023205041.2027336-1-willmcvicker@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251023205041.2027336-1-willmcvicker@google.com> X-Mailer: git-send-email 2.51.1.821.gb6fe4d2222-goog Message-ID: <20251023205041.2027336-6-willmcvicker@google.com> Subject: [PATCH 5/7] clocksource/drivers/exynos_mct: Fix uninitialized irq name warning From: Will McVicker To: Russell King , Catalin Marinas , Will Deacon , Daniel Lezcano , Thomas Gleixner , Krzysztof Kozlowski , Alim Akhtar , Peter Griffin , Ingo Molnar , Youngmin Nam , Will McVicker , Hosung Kim Cc: Donghoon Yu , Rob Herring , Saravana Kannan , John Stultz , Tudor Ambarus , "=?UTF-8?q?Andr=C3=A9=20Draszik?=" , Conor Dooley , Marek Szyprowski , linux-samsung-soc@vger.kernel.org, kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Exynos MCT driver doesn't set the clocksource name until the CPU hotplug state is setup which happens after the IRQs are requested. This results in an empty IRQ name which leads to the below warning at proc_create() time. When this happens, the userdata partition fails to mount and the device gets stuck in an endless loop printing the error: root '/dev/disk/by-partlabel/userdata' doesn't exist or does not contain = a /dev. To fix this, we just need to initialize the name before requesting the IRQs. Warning from Pixel 6 kernel log: [ T430] name len 0 [ T430] WARNING: CPU: 6 PID: 430 at fs/proc/generic.c:407 __proc_create+0x= 258/0x2b4 [ T430] Modules linked in: dwc3_exynos(E+) [ T430] ufs_exynos(E+) phy_exynos_ufs(E) [ T430] phy_exynos5_usbdrd(E) exynos_usi(E+) exynos_mct(E+) s3c2410_wdt(E) [ T430] arm_dsu_pmu(E) simplefb(E) [ T430] CPU: 6 UID: 0 PID: 430 Comm: (udev-worker) Tainted: ... 6.14.0-next-20250331-4k-00008-g59adf909e40e #1 ... [ T430] Tainted: [W]=3DWARN, [E]=3DUNSIGNED_MODULE [ T430] Hardware name: Raven (DT) [...] [ T430] Call trace: [ T430] __proc_create+0x258/0x2b4 (P) [ T430] proc_mkdir+0x40/0xa0 [ T430] register_handler_proc+0x118/0x140 [ T430] __setup_irq+0x460/0x6d0 [ T430] request_threaded_irq+0xcc/0x1b0 [ T430] mct_init_dt+0x244/0x604 [exynos_mct ...] [ T430] mct_init_spi+0x18/0x34 [exynos_mct ...] [ T430] exynos4_mct_probe+0x30/0x4c [exynos_mct ...] [ T430] platform_probe+0x6c/0xe4 [ T430] really_probe+0xf4/0x38c [...] [ T430] driver_register+0x6c/0x140 [ T430] __platform_driver_register+0x28/0x38 [ T430] exynos4_mct_driver_init+0x24/0xfe8 [exynos_mct ...] [ T430] do_one_initcall+0x84/0x3c0 [ T430] do_init_module+0x58/0x208 [ T430] load_module+0x1de0/0x2500 [ T430] init_module_from_file+0x8c/0xdc Signed-off-by: Will McVicker Reviewed-by: Peter Griffin Reviewed-by: Youngmin Nam Tested-by: Youngmin Nam --- drivers/clocksource/exynos_mct.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_= mct.c index 1429b9d03a58..fece6bbc190e 100644 --- a/drivers/clocksource/exynos_mct.c +++ b/drivers/clocksource/exynos_mct.c @@ -465,8 +465,6 @@ static int exynos4_mct_starting_cpu(unsigned int cpu) per_cpu_ptr(&percpu_mct_tick, cpu); struct clock_event_device *evt =3D &mevt->evt; =20 - snprintf(mevt->name, sizeof(mevt->name), "mct_tick%d", cpu); - evt->name =3D mevt->name; evt->cpumask =3D cpumask_of(cpu); evt->set_next_event =3D exynos4_tick_set_next_event; @@ -567,6 +565,14 @@ static int __init exynos4_timer_interrupts(struct devi= ce_node *np, for (i =3D MCT_L0_IRQ; i < nr_irqs; i++) mct_irqs[i] =3D irq_of_parse_and_map(np, i); =20 + for_each_possible_cpu(cpu) { + struct mct_clock_event_device *mevt =3D + per_cpu_ptr(&percpu_mct_tick, cpu); + + snprintf(mevt->name, sizeof(mevt->name), "mct_tick%d", + cpu); + } + if (mct_int_type =3D=3D MCT_INT_PPI) { =20 err =3D request_percpu_irq(mct_irqs[MCT_L0_IRQ], --=20 2.51.1.821.gb6fe4d2222-goog