From nobody Sat Feb 7 12:11:29 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97B8530BB8F for ; Thu, 23 Oct 2025 11:01:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761217296; cv=none; b=R5fE5NeYTtlg+G1kzFoXm6O/LMzG9QgdHeM4bIdk1hu8927jixSWUjg6XZlx/rrezpoirGcPWwJvtPGwuXEEp0C0oqOsEzIvFFML2caP/+f/9rNc5dX7OhIrXO4c4M/dtaVs7ol38CiicBLcLk6+lzeLjVILjQQWJtBBi+knW18= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761217296; c=relaxed/simple; bh=ckT98u80k2JPgEu+6Gv0oxnOuy5Dosa++TXfIwkXVAU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=owRewZOJsBfz7M/Ikg9k20Z8X+7F/pjPSsXPqiSHxs+8gyAkIK0TsVG/3EOhZlqbcpwFZJqhfgA+Y1DO+fWEmgniSZR0TTr6KCEKNby2FqvtrTSRro6coSjgG5REnZ1DTnquoUkU8+5XY/NdjvxHorodKx0IsDrwKauydMMHhws= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lfJzA+IB; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lfJzA+IB" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3f99ac9acc4so670965f8f.3 for ; Thu, 23 Oct 2025 04:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761217293; x=1761822093; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=owxL1umZEz3jsHmxQLyhIGhFWsk4nNmdHrzJn8PWwkM=; b=lfJzA+IBszt379wa/2JpSY+SFoQTORwl7DWkVfuOcH47HZkbXrqs+8mT23c6pps6dH 71zNlAz54HWxbMzICgAV0MucUii62oCJk+pD8LDB4MJvh+MEWEvSXSzh1/u5wl3SB0by Ek898SPNpB6Rj+Gb8OIMGO46fXuPKqNtXrns+8eodyByUo4zt6Y8QBXnztY5dTtYjz0x ra+nnIQwEKcohi36w/eg2eVU4cFmYhkj9WH5/MzI46+Ujf7SSdYXdrPaSqACBNoUUUq6 2509US43cgD8BfpK/DXfPKpM/x3BNft3JpRW6Erq13Y8mBpDFedlzb6+TUmZ938tbFJD 4KUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761217293; x=1761822093; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=owxL1umZEz3jsHmxQLyhIGhFWsk4nNmdHrzJn8PWwkM=; b=GudrsPo/xbrp8Py2EHWhiPo/dug4BN0QsLbFPmz6x40bV0nSI0mwMcE4GVmlociXOw YsFns6ytvyWlBfFwyT7/sAad67Aw5fu7j8TZITEAtHBqJfFgpGjd16txGN48B2+SRKjz Y617ku3omsAc0wpbtdo/NnYmJJ/ZKTqq1HSqlFjNJXqYCF51JKEE7ohVvaLgVo5VGw+T 3fzQt33hv8xBAIMhvC/aL2k1JhFE/DLk0UX2sQD8x6j6BBisE+0VGYosintcC8ob6gYq qTk138bv0OCUEYU7Eu1nlKX0lbWdlzGCXqAuJ81XHclSjZFkXrkeFQeH9oka4pnZUwad Jr5Q== X-Forwarded-Encrypted: i=1; AJvYcCWOhiN5LMzgqLMtMVObsRwqv0QKgTs08Jwz9lXTzT4KHLpx1xL+EU/EEYBzCB3M5T0Puwgcw6ESsqZvIx0=@vger.kernel.org X-Gm-Message-State: AOJu0YweFPjW3zVmVlU92Hp5NfgLkqxVicDRGVNXLEtjG63OJSTrIFAK eoXHfsTM+ETl6vj6gCGey/v/rhq5XrCTlNqw1uv4HGRmBlUDqv4OVJU9 X-Gm-Gg: ASbGnctxnqgnqaJ/DN1AnR3aswD13CVFRt/gdByheSq6fbT1XehU35gPymCwY3b75xT x0lksWKYTVDaXHr9ezS+9eYToATnlfARFuJtg/iN+5Y+Jkoj1QXR2MPFfYVr6GXjwrwsSPkDEdx f81jiuZeLrvYJ84pDsnR/rSGwRp17pPBQSGadvHhbMElUJAry9ZSwhM1aoBkUNe4aJ8HUDK/nQa Dswm2yLJLvJCwCi7ilbcL4+z9nN21epJXpx+r8ZOHnDj3Q1xXAT8T6/ivv4hCjaWNvb3Yw1MK+1 Stb42FW50jztQdjWG4b8UkXya0vErCNI6LnBhfyflUMSbfyZWpj3TgnWW258nrLE9ExzDSLELw3 hxdDH/11pIcFwpY0vT9LBLpGzpWL9SSJEm5pqMQjhuM9nhkckAR8cx3BIbSpZ4QgPKJsBRfalWj ouBYr9 X-Google-Smtp-Source: AGHT+IG4jDcJj8/UVPX8uaNqcl2k5SJb3kroiwvAz8vuEMgmB/p84+nOmThVkFeBVC9mV9z+ryZanQ== X-Received: by 2002:a05:6000:4205:b0:401:70eb:eec7 with SMTP id ffacd0b85a97d-42704db8ccbmr14342758f8f.43.1761217292775; Thu, 23 Oct 2025 04:01:32 -0700 (PDT) Received: from shift.. ([86.124.201.90]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429898adf78sm3596420f8f.32.2025.10.23.04.01.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Oct 2025 04:01:32 -0700 (PDT) From: Cezar Chiru To: andi.shyti@kernel.org, wsa+renesas@sang-engineering.com Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Cezar Chiru Subject: [PATCH v1 1/2] i2c: pcf8584: Move 'ret' variable inside for loop, goto out if ret < 0. Date: Thu, 23 Oct 2025 14:01:16 +0300 Message-ID: <20251023110118.7940-2-chiru.cezar.89@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251023110118.7940-1-chiru.cezar.89@gmail.com> References: <20251023110118.7940-1-chiru.cezar.89@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Require spaces around '=3D' and '<'. Add spaces around binary operators. Enforce error fixing based on checkpatch.pl output on file. Move 'ret' variable inside for loop. Then check if (ret < 0) goto out. This improves usage of ret variable. Signed-off-by: Cezar Chiru --- drivers/i2c/algos/i2c-algo-pcf.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/algos/i2c-algo-pcf.c b/drivers/i2c/algos/i2c-algo-= pcf.c index 41a81d37e880..06b9fd355bff 100644 --- a/drivers/i2c/algos/i2c-algo-pcf.c +++ b/drivers/i2c/algos/i2c-algo-pcf.c @@ -183,7 +183,7 @@ static int pcf_sendbytes(struct i2c_adapter *i2c_adap, = const char *buf, struct i2c_algo_pcf_data *adap =3D i2c_adap->algo_data; int wrcount, status, timeout; =20 - for (wrcount=3D0; wrcountalgo_data; struct i2c_msg *pmsg; int i; - int ret=3D0, timeout, status; + int timeout, status; =20 if (adap->xfer_begin) adap->xfer_begin(adap->data); @@ -284,9 +284,10 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap, goto out; } =20 - for (i =3D 0;ret >=3D 0 && i < num; i++) { - pmsg =3D &msgs[i]; + for (i =3D 0; i < num; i++) { + int ret; =20 + pmsg =3D &msgs[i]; ret =3D pcf_doAddress(adap, pmsg); =20 /* Send START */ @@ -321,6 +322,9 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap, ret =3D pcf_sendbytes(i2c_adap, pmsg->buf, pmsg->len, (i + 1 =3D=3D num)); } + + if (ret < 0) + goto out; } =20 out: --=20 2.43.0