From nobody Sat Feb 7 16:39:28 2026 Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFAB32F28E3 for ; Wed, 22 Oct 2025 20:07:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761163633; cv=none; b=kXQhxV2VeykS0VNfShPLRsu9kCx3hDNd9APWeVi/c+c/SEIXzZ6kSouXEO+fSe3HGB8QnlrBuBfbjciyBCjcrwuBCaOU8Ies1IVkhasxU87UHR+9u+K6DnrGrEpu1mMz0cJsCbDjZf78qyR9WW8mzZ8zfYZYgiZ005Kl7uYkvKw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761163633; c=relaxed/simple; bh=DztsLj3vdv3FYw0cPl2uS2ogmDunqfckdWo1ml2REqg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Gl7o17z4BZu68g70TR5+No1Jnpx839fidwpla37Muzlhmg20yTdLQHjX96JKOacq1XJNcF2HVe482LnwQhLZ/veQmWDwZwqYQVEZlCtz2jYsdwagmArnbhu5u+VX1DAEUBAa6Ljc+s3ttK6xVoriKUR9oUKpo8F2Pi2Sg6CDnvc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hz1qgeCp; arc=none smtp.client-ip=209.85.166.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hz1qgeCp" Received: by mail-il1-f174.google.com with SMTP id e9e14a558f8ab-430da09aa87so392165ab.2 for ; Wed, 22 Oct 2025 13:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761163631; x=1761768431; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VwbN+wurLTlI3kZfG9YY+LmisCptQEnBinwXCuD+yAQ=; b=hz1qgeCpqBUZZFb5VyO/yLXkt3Fm0AHzgo8yuuor30thglPC58BBNZ4D3ihi5z/cEM TAN3tpCkzn7jf9Ry82Uj3fItsgdMXyDRBkjIiYEqwfu9a/Dpcttd5AhrXNEThXxvovDV HWnvkN7jrcuyJSnXvzoD0dJiqWDUTm4pCq6jc3h8fmkOs+DpB8lPmYMfYAaFZf6FlJ3I l/5w7hBe5MmoynaNj2VYl7H+aZgoUbaREH0H0sPHveXN8imSuyOXEEgAZWafUAEm8ZKn Kf/BZhMFgrZp/qGK9Mmyq3e3S/OSc9LbSJ04eaPWRkuR7nYogQvHiNAuAAr/TadYgRN6 j+0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761163631; x=1761768431; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VwbN+wurLTlI3kZfG9YY+LmisCptQEnBinwXCuD+yAQ=; b=Ohtp5fR5+5ajhf10mfBcQPPdvYAszW6Smnpl9Nc7o/BKO5tIBm82PX1xHX56kvxLac KW8zvlT7ghVCun1c0qiKD3SBL+fCJiRiRw3TtgRiohITvYMOW7Iy2BLqLEHeCqLsFp9p 929CePzEVm3LveSthOpnZYAvASUD9GogeJZ4SqlxRN86+QlP6S2WFiU9VTYVLDXvIHYd nGTumtH8z0lNb1uYxsx7U3ocl17kHwyOACW6sVi7auP/n8X0jaEQz60BZrZSlM6KLLf2 ODlnEk0IjEBMksF1dqSz3MIiev5JRAqGGriTRZ9AE8fdXkSTuCo8XAiIEKxa9CZeScLI ETIA== X-Forwarded-Encrypted: i=1; AJvYcCXJdPgPfkqohI7YdASOM2bZELp4Q+DnNQhNZMzNbg/dty8EvdYXuvdTWVFo7VrF0pNAUsJ7UcdlspLU+Wc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3RDVoLHi3SeDGN8S3SGATajttVzqG6jQTcvQzisD2c5M79TE2 WISuS34NKaxtzFAH+e+JLdDoomF5FmRGXhXE+Jo6hqvmewjqq2H0hj2QSCJzdkCrFuw= X-Gm-Gg: ASbGncvDHMrEgMg6pFm6W8APUHMTCprnEi0GtTESBjStuU+fvLH2cUOM0ZP5RS0Kkmw LnUb2kheXs1r5z0m62PhzP2ZZVhEUoxQTPGMXp2Q1xFyHiL4LD5GqLOP5VBnBVwaO/EAVilz8c+ 4zSMQpptentudomLLqxlf/iFiJkprTJhC/7kdkjPIUX1AZR7HMICfC+zXckfapsMRLz8A1+/m4E cC/YQ22gxCVheHUFANAQjqayJLBxBz1Ttq3bVmLXtcfYntyqAFUkSIHr6Kmfsio2E04mz9TuMaX 5S6b3CUjeqa0KWJm95duzdyz4aDra6ADNiH22gvroxeDechNt2WudneoDJHg+3GYpq4EeHvhs1d oueYu1B85rdBoHVAGA8RqIX7r/4/lAVkqh+swSopZeZitfLo5MMvqMVcda4xQhgNb+oxN5/qEDO EkvaTfNRmcIOqNc3eP0RkPN5VEt5izXZw+HV8AGJs44SfAgOGtqSyfnGJgAhGmQUst+4quDe81f Z2P X-Google-Smtp-Source: AGHT+IEi13vxAW3QWGvs47oIZZEeT5MJtjo5ggN538BbVhSvNenvFcif8+DslNFd6WG9e5ojjv5SEQ== X-Received: by 2002:a05:6e02:156c:b0:430:ad98:981f with SMTP id e9e14a558f8ab-430c524b96bmr287934085ab.4.1761163630603; Wed, 22 Oct 2025 13:07:10 -0700 (PDT) Received: from abc-virtual-machine.localdomain (c-76-150-86-52.hsd1.il.comcast.net. [76.150.86.52]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-5abb5432ca5sm18991173.16.2025.10.22.13.07.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Oct 2025 13:07:10 -0700 (PDT) From: Yuhao Jiang To: "Rafael J . Wysocki" Cc: Len Brown , Hans de Goede , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Yuhao Jiang Subject: [PATCH v3] ACPI: video: Fix use-after-free in acpi_video_switch_brightness() Date: Wed, 22 Oct 2025 15:07:04 -0500 Message-Id: <20251022200704.2655507-1-danisjiang@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The switch_brightness_work delayed work accesses device->brightness and device->backlight, which are freed by acpi_video_dev_unregister_backlight() during device removal. If the work executes after acpi_video_bus_unregister_backlight() frees these resources, it causes a use-after-free when acpi_video_switch_brightness() dereferences device->brightness or device->backlight. Fix this by calling cancel_delayed_work_sync() for each device's switch_brightness_work in acpi_video_bus_remove_notify_handler() after removing the notify handler that queues the work. This ensures the work completes before the memory is freed. Fixes: 8ab58e8e7e097 ("ACPI / video: Fix backlight taking 2 steps on a brig= htness up/down keypress") Cc: stable@vger.kernel.org Signed-off-by: Yuhao Jiang Reviewed-by: Hans de Goede --- Changes in v3: - Move cancel_delayed_work_sync() to acpi_video_bus_remove_notify_handler() instead of acpi_video_bus_unregister_backlight() for better logic placeme= nt - Link to v2: https://lore.kernel.org/all/20251022042514.2167599-1-danisjia= ng@gmail.com/ --- drivers/acpi/acpi_video.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c index 103f29661576..be8e7e18abca 100644 --- a/drivers/acpi/acpi_video.c +++ b/drivers/acpi/acpi_video.c @@ -1959,8 +1959,10 @@ static void acpi_video_bus_remove_notify_handler(str= uct acpi_video_bus *video) struct acpi_video_device *dev; =20 mutex_lock(&video->device_list_lock); - list_for_each_entry(dev, &video->video_device_list, entry) + list_for_each_entry(dev, &video->video_device_list, entry) { acpi_video_dev_remove_notify_handler(dev); + cancel_delayed_work_sync(&dev->switch_brightness_work); + } mutex_unlock(&video->device_list_lock); =20 acpi_video_bus_stop_devices(video); --=20 2.34.1