From nobody Sat Feb 7 08:42:32 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FE5C34D933; Wed, 22 Oct 2025 15:26:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761146815; cv=none; b=NVjmAJDWkqBwUUjLT3izVteJJLCGw0ruhXKRd6d6026ptO0fm7xT/3Y1Sm6WLZ0WOIMntzp6f1snJB7qJp0vedTS7Jwj2HZPzayWIBMEFE8Rh9WYA39BzQYQdInjzIGRvwDyymMYCAuLR5YqC5CaygMRIL89B34oIZLhLrtHro0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761146815; c=relaxed/simple; bh=Dx85VVs25HOQaToVZX33ToHNqh/5RZl7+mhYzPCaM7s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CEbodm1BTz8/89Tti7o9Y3HF6mvqoBLBLXlyshJkZZTXPWZrPA5g4PPT6jRiIbaPJh0nU5Vcxh74R+LMfgh8NNERgpJCY8oeA9D8PtOZ/rS4dqrFvDpwk/sSwJYTz4oLPQrkerkvY6hUFqqELfK/hSKbXMzjiGpWyD8KeuogziU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rgAzVxLw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rgAzVxLw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A103C16AAE; Wed, 22 Oct 2025 15:26:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761146813; bh=Dx85VVs25HOQaToVZX33ToHNqh/5RZl7+mhYzPCaM7s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rgAzVxLw0wVb97glM2wQle1hRxHi347Tg3ocAD7dp/WhPgvO8EMf0EyYRFqg19oYh 3uyVMXWY/URD5iNY7/6SLu1Le5b5cPFzsuV5fV0cwFHe80xY5gcDwBrgu6iZMWs9Sb JsETR7cnCx45yZzpa7NA3maqQVNliz7GRFsqZaOGpRAhEDxW6FEEZ4ELrlxM3jgEyY SLhHVRpCtSW3pMvUAehWZUAnCcyh0Vlm4ll+fyD7AWmTjM/OjAfb4Kmq2p25qfw4Tz W35BipQnYVqRkzH4OUDIEbGTmUjm+sHi0BUDFr81uTaoFvuhtFPpOCljVE3PnbfvUb LUH9CXuzaZ9VQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vBajs-000000006JV-0inT; Wed, 22 Oct 2025 17:27:00 +0200 From: Johan Hovold To: Johan Hovold Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 7/8] USB: serial: kobil_sct: clean up set_termios() Date: Wed, 22 Oct 2025 17:26:39 +0200 Message-ID: <20251022152640.24212-8-johan@kernel.org> X-Mailer: git-send-email 2.49.1 In-Reply-To: <20251022152640.24212-1-johan@kernel.org> References: <20251022152640.24212-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Clean up set_termios() by using a shorter identifier for the control request value, replacing a ternary operator and adding some missing braces to make it more readable. Signed-off-by: Johan Hovold --- drivers/usb/serial/kobil_sct.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/usb/serial/kobil_sct.c b/drivers/usb/serial/kobil_sct.c index 3c13410520ec..cad3cfc63ce7 100644 --- a/drivers/usb/serial/kobil_sct.c +++ b/drivers/usb/serial/kobil_sct.c @@ -435,9 +435,9 @@ static void kobil_set_termios(struct tty_struct *tty, { struct kobil_private *priv; int result; - unsigned short urb_val =3D 0; int c_cflag =3D tty->termios.c_cflag; speed_t speed; + u16 val; =20 priv =3D usb_get_serial_port_data(port); if (priv->device_type =3D=3D KOBIL_USBTWIN_PRODUCT_ID || @@ -450,28 +450,34 @@ static void kobil_set_termios(struct tty_struct *tty, speed =3D tty_get_baud_rate(tty); switch (speed) { case 1200: - urb_val =3D SUSBCR_SBR_1200; + val =3D SUSBCR_SBR_1200; break; default: speed =3D 9600; fallthrough; case 9600: - urb_val =3D SUSBCR_SBR_9600; + val =3D SUSBCR_SBR_9600; break; } - urb_val |=3D (c_cflag & CSTOPB) ? SUSBCR_SPASB_2StopBits : - SUSBCR_SPASB_1StopBit; + + if (c_cflag & CSTOPB) + val |=3D SUSBCR_SPASB_2StopBits; + else + val |=3D SUSBCR_SPASB_1StopBit; + if (c_cflag & PARENB) { if (c_cflag & PARODD) - urb_val |=3D SUSBCR_SPASB_OddParity; + val |=3D SUSBCR_SPASB_OddParity; else - urb_val |=3D SUSBCR_SPASB_EvenParity; - } else - urb_val |=3D SUSBCR_SPASB_NoParity; + val |=3D SUSBCR_SPASB_EvenParity; + } else { + val |=3D SUSBCR_SPASB_NoParity; + } + tty->termios.c_cflag &=3D ~CMSPAR; tty_encode_baud_rate(tty, speed, speed); =20 - result =3D kobil_ctrl_send(port, SUSBCRequest_SetBaudRateParityAndStopBit= s, urb_val); + result =3D kobil_ctrl_send(port, SUSBCRequest_SetBaudRateParityAndStopBit= s, val); if (result) { dev_err(&port->dev, "failed to update line settings: %d\n", result); --=20 2.49.1