From nobody Thu Dec 18 08:52:07 2025 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDA3C34BA4D for ; Wed, 22 Oct 2025 14:21:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761142899; cv=none; b=BI+mZ6y0H8z9Ogt6uaH4tXy2sUbqwb3P2dcDzc7iHCoLzubB3R40tcJ5Si1qp5gYjebDRSabU/0T8RLRtaA/kVHq0f9zvah0FnvVuNFkO3L6/D1Mex5xOpsjFdpliMJmHPh3Q8dge0Ujf9Ibn+jmBsjrblWz6VFn1I3KRyWTbL0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761142899; c=relaxed/simple; bh=u+qJVWyapenrodgmMyyh5sdeoJQIHo+UHZurPNrBBEU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mZAoexYKR7PTOkiWKQDQrUjpK0ejsDlln0mX5rs9VWUaDDN+dahMVcKE88wp8Ketk0gH6O3vNvLzxaZlD4PJAfbT9N/12eGTtmxTFPxb3b0vYzmT42Y/rP3Heqgw/AMEGwIogVxqQU615bUPgdnM1sU6wntYesPBlPggLkrIndk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dRW3mYGu; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dRW3mYGu" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-47117f92e32so46783645e9.1 for ; Wed, 22 Oct 2025 07:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761142893; x=1761747693; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oNnZ9HXiG4U5oHkge6rfZLR0dPMVP9tD5A0n1Dg/8XI=; b=dRW3mYGusnM/Qmj4Y0elfbsCR225co2bFqnzUeMQY71kxiDG6gIjouamI/pS8dbXZd PIEdkZzuejc/uJtv2auEXrEzBp2mVsXK9G9CUW1OLiXLnO++rxWZBrlcfJaduayjiLlg liqQDgRSbp9KKzUUbT8Ue/lYFtvanYlxk4nlzHl8VJy0XY1ABF1RsSkA6ENVigxnxD9o cmAUvpQQZAs1XvwHhnir1OXKqiDmtzh2MUcUEYtgwwg18EuuGR2I5RmUSbCMRXZA01U/ xqlASVgBaV4qcyybRNHDTXbNpj6fwTAB24HY410dsaFcLiPPv4KwgNSC9suYdITcpus0 L8Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761142893; x=1761747693; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oNnZ9HXiG4U5oHkge6rfZLR0dPMVP9tD5A0n1Dg/8XI=; b=iWHOE0CJq/klGUqVBMhCd0rKJwP9F2Nuqu9R6lXG9CfXCPTlRT2RlYz4+TTdoSv6kH 7iQXE8f3r4CGwf8fmLxvWRKHLQU017j1Urhj0/Jgqev14IFktWelCD4nAnt8K0wTJXs1 b6ThG1xcd7HuEUEfTQQDddz+D9YYAT9yBU775Y6dnkAP+aNw9JARJJLEJzT5BILgSJ5h xedmIhC2m3C4HnoFVi+7KfDRIkrzk/khF41Wc6eBdhwMErXQE5SPKLcMCUtYqUuAmMX/ yL6uAmK+VRu/um2tu9tS4n9NIFIXiA+LWkhEtIwkRiivDPU90/C57NgLaPWrW9m7QHTl jsZA== X-Forwarded-Encrypted: i=1; AJvYcCWoZkmPDyf6+2SmNjqOW6+4CAzLnHFx/HXh506xU++vxcA5ebqrzzoSqUGuBkOUYewvu+lO0nZK9et2020=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1fRYAoz8R6m5Cwl3kHx7RnHz9z7gZobBdWbzNFThFL3qfEkFA zUBhDkrI0iJyzSYyYS494oXsusjUFO45DupelZJZCnvlRWSUd8ZkjZUj X-Gm-Gg: ASbGncsGrHNUawjdxgUbN99rGlNiUWD/v+36pzK9nSL3GEOa29Q8XzjFNStiPEBUIm8 e7FkB1ekNpR/Hc9urP2OkIKskCDLLV8F+2fRGvyeZHrB+VoSetxEXYtr43c/8JHPAawB7Z0FCKq kVzo8lrAmkVKOqexOMOblcPwwvqp0f0/bjAy6GULlWP8lN2MZy5h3LGugGdsifuOHvbEVIMqo9H e1f/ccjG0nZFw7h+XAgiWh/br/Zn+v+WRppSUZhpGARSpLCwAo1l1H+871PM7HtWy7otavQfv7N 0oWMEkL2xrHeAV0t2NbbiNJXhQkcPICgTIxVcb+j/jarLcoBiGxth36uax8oocEcucvKkaUbdQM yB6wAUqxPCLZbo1443OBmtS91b+eeBPbdtZvjtKWgHqvdHsDzjMbnYZb7unMpgJpRpZuoQjZcx7 RrNUNwzj0H8rgP X-Google-Smtp-Source: AGHT+IEnXWlJDCOikv9Trvtrnq+YEjaVZ6eiwnQHVodVjHM0wnLfQoIbLbeHL/Nmsexg12AMq8heQQ== X-Received: by 2002:a05:600c:518f:b0:46e:4a60:ea2c with SMTP id 5b1f17b1804b1-47117925e1dmr162394545e9.37.1761142893340; Wed, 22 Oct 2025 07:21:33 -0700 (PDT) Received: from xeon.. ([188.163.112.61]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427ea5b3d4csm24803518f8f.19.2025.10.22.07.21.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Oct 2025 07:21:32 -0700 (PDT) From: Svyatoslav Ryhel To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Prashant Gaikwad , Michael Turquette , Stephen Boyd , Mikko Perttunen , Mauro Carvalho Chehab , Greg Kroah-Hartman , Svyatoslav Ryhel , =?UTF-8?q?Jonas=20Schw=C3=B6bel?= , Dmitry Osipenko , Charan Pedumuru , Diogo Ivo , Aaron Kling , Arnd Bergmann Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-clk@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH v5 06/23] staging: media: tegra-video: vi: adjust get_selection op check Date: Wed, 22 Oct 2025 17:20:34 +0300 Message-ID: <20251022142051.70400-7-clamor95@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20251022142051.70400-1-clamor95@gmail.com> References: <20251022142051.70400-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Get_selection operation may be implemented only for sink pad and may return error code. Set try_crop to 0 instead of returning error. Signed-off-by: Svyatoslav Ryhel --- drivers/staging/media/tegra-video/vi.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media= /tegra-video/vi.c index 7c44a3448588..856b7c18b551 100644 --- a/drivers/staging/media/tegra-video/vi.c +++ b/drivers/staging/media/tegra-video/vi.c @@ -476,15 +476,11 @@ static int __tegra_channel_try_format(struct tegra_vi= _channel *chan, fse.code =3D fmtinfo->code; ret =3D v4l2_subdev_call(subdev, pad, enum_frame_size, sd_state, &fse); if (ret) { - if (!v4l2_subdev_has_op(subdev, pad, get_selection)) { + if (!v4l2_subdev_has_op(subdev, pad, get_selection) || + v4l2_subdev_call(subdev, pad, get_selection, NULL, &sdsel)) { try_crop->width =3D 0; try_crop->height =3D 0; } else { - ret =3D v4l2_subdev_call(subdev, pad, get_selection, - NULL, &sdsel); - if (ret) - return -EINVAL; - try_crop->width =3D sdsel.r.width; try_crop->height =3D sdsel.r.height; } --=20 2.48.1