From nobody Thu Dec 18 08:52:39 2025 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22D6334E768 for ; Wed, 22 Oct 2025 14:21:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761142912; cv=none; b=UNFF6Rqx/awus6JdJ40+FJcEoa+5HwE1g/VR2All5CM0Dgn1Iobws0cR5Up06tJxM86rUE1NalO8h0+LGk4ZgDJs+ESFK3/NzEl07pOPZA3mBfvlS3VITrucY/vtZU9cBoWTrif2IaTMd2XIIjE9PEMi2NbkXv83pSnTuoDY7Ak= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761142912; c=relaxed/simple; bh=oogKzOkmRUHqbeJIXHjFVmuliJy7HLFoYw49y22EcBg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qxI6FYeyuQS1/OfGPr6ym1n787PaULN+Vw3PeeULsjJSWq72hYgvcFhxFWpF2dA0WcHqZZJNC3tiJtTD1FlLpzwXc5ponRxvKKLaQ+XXsqmYNGay5XLLwBmcowxKoCYV+f1+Hf5tbTUfDZwasCkrfsz4qLgrdY3qn33dxMuYni0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QWXN0sZs; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QWXN0sZs" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-47106fc51faso82725425e9.0 for ; Wed, 22 Oct 2025 07:21:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761142905; x=1761747705; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/FSRFPudzEKyK76m04qsFR3ktGMJkJD3i+v6OWuiw2c=; b=QWXN0sZsU3lD3l2v9Q8PuhnoxfwaSAPAE5mEMmyupvzcB4RpR3uThFBfgXoK3xJeEW Zp3stkVbuU+z+G3JwP9v1usbZDjQgfQWVRZ/zAFO/Qsva7cKwCLAn334WVxGeTWDvMAN kMMsjbKQnPgEFWP4WTgEsEsKhFShLa5cm9OoDDVOR8zZXwQ9kwisAmdFeFe4Bc4h3PCX k4srZFnT8QcEZlg/G+UcpS2GLOYh0BD8kFdkNUegJZLKlOVqNsYFbrQb/k8GH2kAN3q/ xE7tvZFA+AYEcMXKxqIA44/2gdobONwalgwJ2zJtLtEwQEm29oL6nn8ovunu/two1sQy 2rXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761142905; x=1761747705; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/FSRFPudzEKyK76m04qsFR3ktGMJkJD3i+v6OWuiw2c=; b=aUuSdtFOR9dOXZ6V4TScqN8AAmUTmOxpCxmmoc+3KWsxn4XwIOrDMYHoc5TvuKG4z1 A1QKboHEEW+sRo9XrsHBllMCIVVkXCkzTqEkd/5oeaTaRbvwyztrqMkjgtTUAIBfnucG +iQC9FvrNr6x1Gz/qZJ+BoFwn3d7Ovciqk1xudDPENGYWTb7UsLs4oU2WYXA3iTu1MUC 7/elkJuxo7grznWMj9TjL36fn8wCQSD5bfR7AQ+hfSulEinj4sJITWl5Byd/Gu7RRZwh 934sVw11i+MyXBtX1ao5vvlLU25WtTrF/hRA09YiYnBDSrAKXY6Ryc/4VP2rNt9FY2wY 81qw== X-Forwarded-Encrypted: i=1; AJvYcCVTs26kDwfNeSJ+KeMPKuabOWUn5SLnph/l+KnLnvPu2K+lj16HghJKoqut2nhwSuZtzRpbqZw42jm91n0=@vger.kernel.org X-Gm-Message-State: AOJu0YzSAS2vMoqJdBO3ZTFQiW6Tyo9J1DI6vxrFd69oCYk/RLyWchhY jXzKujsq0WURw3CiJFNhHQdTXTNhbJ9a3oGqnMkURtOl+Vu9LwtlXax0 X-Gm-Gg: ASbGncubKBtYnOmiJi5/3u04B1KFJWQOnHMny7/HP88swki41SlHPMLovz6VRmbrf8v ptAZYmMsRlXTTs6uxVmacmQf5me8jlKnkWj+noLIiAmV0TEtFH/2ADv5W3FUwX3WEjzCJmU3aIg CMyO0HlVVfKqeDVps10tfbiA5vP++SHWkQmRYVxY39gwi7ae9tnCtlQqsJGp4ZZKIeTAqStK4o0 arWducr4Ewc3uAmSrkNbbQuqOQnPy88nxQjVeiBK4gQaQ47+KJmN9ZyJ318MOx9P/nRkTsv0z+v CL0TrZ2gybmhq5x4iCFgt/QrmNPXh1yHK1XtA04z9V84sIKMxWqljvipmMRrhZAjAeIUSqAChfE 3mvzrkW4dngRZPPyUbDiFmOKO0yb+tJrFU1SDIoihwWnNwZOjCKdfy6rUTZBXeEavIPmhWonIle htUQ== X-Google-Smtp-Source: AGHT+IE+R+MFV4kZfuKKlqZW+VRqACGxd+UeQjJKPUWrsEGvn2bnxhzqWlUevwPhO9Lp6LuefqTXKg== X-Received: by 2002:a05:600c:3f08:b0:471:11a3:a6a9 with SMTP id 5b1f17b1804b1-4711791f738mr170626375e9.37.1761142904892; Wed, 22 Oct 2025 07:21:44 -0700 (PDT) Received: from xeon.. ([188.163.112.61]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427ea5b3d4csm24803518f8f.19.2025.10.22.07.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Oct 2025 07:21:44 -0700 (PDT) From: Svyatoslav Ryhel To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Prashant Gaikwad , Michael Turquette , Stephen Boyd , Mikko Perttunen , Mauro Carvalho Chehab , Greg Kroah-Hartman , Svyatoslav Ryhel , =?UTF-8?q?Jonas=20Schw=C3=B6bel?= , Dmitry Osipenko , Charan Pedumuru , Diogo Ivo , Aaron Kling , Arnd Bergmann Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-clk@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH v5 12/23] staging: media: tegra-video: csi: move avdd-dsi-csi-supply from VI to CSI Date: Wed, 22 Oct 2025 17:20:40 +0300 Message-ID: <20251022142051.70400-13-clamor95@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20251022142051.70400-1-clamor95@gmail.com> References: <20251022142051.70400-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The avdd-dsi-csi-supply is CSI power supply not VI, hence move it to proper place. Signed-off-by: Svyatoslav Ryhel Tested-by: Luca Ceresoli # Tegra20 VIP Reviewed-by: Luca Ceresoli Reviewed-by: Mikko Perttunen --- drivers/staging/media/tegra-video/csi.c | 19 ++++++++++++++++++- drivers/staging/media/tegra-video/csi.h | 2 ++ drivers/staging/media/tegra-video/vi.c | 23 ++--------------------- drivers/staging/media/tegra-video/vi.h | 2 -- 4 files changed, 22 insertions(+), 24 deletions(-) diff --git a/drivers/staging/media/tegra-video/csi.c b/drivers/staging/medi= a/tegra-video/csi.c index ef5f054b6d49..7d70478a07aa 100644 --- a/drivers/staging/media/tegra-video/csi.c +++ b/drivers/staging/media/tegra-video/csi.c @@ -710,6 +710,8 @@ static int __maybe_unused csi_runtime_suspend(struct de= vice *dev) =20 clk_bulk_disable_unprepare(csi->soc->num_clks, csi->clks); =20 + regulator_disable(csi->vdd); + return 0; } =20 @@ -718,13 +720,23 @@ static int __maybe_unused csi_runtime_resume(struct d= evice *dev) struct tegra_csi *csi =3D dev_get_drvdata(dev); int ret; =20 + ret =3D regulator_enable(csi->vdd); + if (ret) { + dev_err(dev, "failed to enable VDD supply: %d\n", ret); + return ret; + } + ret =3D clk_bulk_prepare_enable(csi->soc->num_clks, csi->clks); if (ret < 0) { dev_err(csi->dev, "failed to enable clocks: %d\n", ret); - return ret; + goto disable_vdd; } =20 return 0; + +disable_vdd: + regulator_disable(csi->vdd); + return ret; } =20 static int tegra_csi_init(struct host1x_client *client) @@ -802,6 +814,11 @@ static int tegra_csi_probe(struct platform_device *pde= v) return ret; } =20 + csi->vdd =3D devm_regulator_get(&pdev->dev, "avdd-dsi-csi"); + if (IS_ERR(csi->vdd)) + return dev_err_probe(&pdev->dev, PTR_ERR(csi->vdd), + "failed to get VDD supply"); + if (!pdev->dev.pm_domain) { ret =3D -ENOENT; dev_warn(&pdev->dev, "PM domain is not attached: %d\n", ret); diff --git a/drivers/staging/media/tegra-video/csi.h b/drivers/staging/medi= a/tegra-video/csi.h index 3ed2dbc73ce9..1550defb115a 100644 --- a/drivers/staging/media/tegra-video/csi.h +++ b/drivers/staging/media/tegra-video/csi.h @@ -137,6 +137,7 @@ struct tegra_csi_soc { * @client: host1x_client struct * @iomem: register base * @clks: clock for CSI and CIL + * @vdd: vdd regulator for CSI hardware, usually avdd_dsi_csi * @soc: pointer to SoC data structure * @ops: csi operations * @csi_chans: list head for CSI channels @@ -146,6 +147,7 @@ struct tegra_csi { struct host1x_client client; void __iomem *iomem; struct clk_bulk_data *clks; + struct regulator *vdd; const struct tegra_csi_soc *soc; const struct tegra_csi_ops *ops; struct list_head csi_chans; diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media= /tegra-video/vi.c index 04b538e8b514..70607a3eeee1 100644 --- a/drivers/staging/media/tegra-video/vi.c +++ b/drivers/staging/media/tegra-video/vi.c @@ -1417,29 +1417,19 @@ static int __maybe_unused vi_runtime_resume(struct = device *dev) struct tegra_vi *vi =3D dev_get_drvdata(dev); int ret; =20 - ret =3D regulator_enable(vi->vdd); - if (ret) { - dev_err(dev, "failed to enable VDD supply: %d\n", ret); - return ret; - } - ret =3D clk_set_rate(vi->clk, vi->soc->vi_max_clk_hz); if (ret) { dev_err(dev, "failed to set vi clock rate: %d\n", ret); - goto disable_vdd; + return ret; } =20 ret =3D clk_prepare_enable(vi->clk); if (ret) { dev_err(dev, "failed to enable vi clock: %d\n", ret); - goto disable_vdd; + return ret; } =20 return 0; - -disable_vdd: - regulator_disable(vi->vdd); - return ret; } =20 static int __maybe_unused vi_runtime_suspend(struct device *dev) @@ -1448,8 +1438,6 @@ static int __maybe_unused vi_runtime_suspend(struct d= evice *dev) =20 clk_disable_unprepare(vi->clk); =20 - regulator_disable(vi->vdd); - return 0; } =20 @@ -1894,13 +1882,6 @@ static int tegra_vi_probe(struct platform_device *pd= ev) return ret; } =20 - vi->vdd =3D devm_regulator_get(&pdev->dev, "avdd-dsi-csi"); - if (IS_ERR(vi->vdd)) { - ret =3D PTR_ERR(vi->vdd); - dev_err(&pdev->dev, "failed to get VDD supply: %d\n", ret); - return ret; - } - if (!pdev->dev.pm_domain) { ret =3D -ENOENT; dev_warn(&pdev->dev, "PM domain is not attached: %d\n", ret); diff --git a/drivers/staging/media/tegra-video/vi.h b/drivers/staging/media= /tegra-video/vi.h index cac0c0d0e225..bfadde8858d4 100644 --- a/drivers/staging/media/tegra-video/vi.h +++ b/drivers/staging/media/tegra-video/vi.h @@ -94,7 +94,6 @@ struct tegra_vi_soc { * @client: host1x_client struct * @iomem: register base * @clk: main clock for VI block - * @vdd: vdd regulator for VI hardware, normally it is avdd_dsi_csi * @soc: pointer to SoC data structure * @ops: vi operations * @vi_chans: list head for VI channels @@ -104,7 +103,6 @@ struct tegra_vi { struct host1x_client client; void __iomem *iomem; struct clk *clk; - struct regulator *vdd; const struct tegra_vi_soc *soc; const struct tegra_vi_ops *ops; struct list_head vi_chans; --=20 2.48.1