From nobody Sat Feb 7 11:38:21 2026 Received: from mail-pj1-f97.google.com (mail-pj1-f97.google.com [209.85.216.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DC6932143A for ; Wed, 22 Oct 2025 11:07:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.97 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761131236; cv=none; b=rIrhtVh0CQwTegYjQznlxwEKMyCWYHkafoSrSoYw2ljQUGBz9wg52DbgppDTvZM38+bhA+2I47NTcWqkeRWjPJEt/7tidip3zITJuK2mek2fGAezFFCnun8kZm9W6eT0MKtXL5/yN5YLkat1LXr/QUwAA7LdjFxQYVasEP6ObzY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761131236; c=relaxed/simple; bh=tphZkRN4cfZYFVTFehKBYnLpVKDqMthpMvjmWlBcnCk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LNgxfzaHofdaNoaJbBjBfBg5QLIhUhLjfoG4eDkR80zlq8mmQQCIiUhBO4Jf/V6RjtsToyHzEFnjm1JFZjzbh1pfdMs9UNLzC3BFNxTBwnOjHHSGvejEN3JLTMBO5o+RBy6BmioNOHWecwnWIZKLhA8kuit9viYbHXi1JlHur3s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Zgka9XoA; arc=none smtp.client-ip=209.85.216.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Zgka9XoA" Received: by mail-pj1-f97.google.com with SMTP id 98e67ed59e1d1-33b5a3e8ae2so836317a91.1 for ; Wed, 22 Oct 2025 04:07:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761131234; x=1761736034; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kA9Oy21XPeXmPlSwKvLYBk2PQ/Fy4Lvp8jR4DRUe+f8=; b=gRfjOMnPsR5Iq0a3NbzI8NbxDguPs1ELm3begJdS0qcVTnRjmyBt/MIBnkrTfgAHDa uZ8iQe+Tx5aoZ1yIPA4j7yBlw2ezS/meAoYclOSzmd3ey0T7PED+km4U/swDOgLrY9jY O9ALbsKq46jtD8uykY7LGXMgPj4DdSxqPTTQ2FHS1mXs3b9IgYGf+EKHf+Okvm5CWOc0 ITg33p8IQ/vELGK3AVx5V9/VIBDmjZKre7mY7tYT5ft7BSU8r2RiFZmxy0Ulj517rtx8 5LsGVwp6a1lS8qt8RlmyI7YuaqK+yXUUfNr9R3A+9SDkNYxZnHPmhC2TEO5d1Ql+zAkg 87CA== X-Forwarded-Encrypted: i=1; AJvYcCVnxq2Cba00+Ip0ubxXEhj09pQWujllvDMxOzLtK25n20TL3JRQGqeFP054VXQfBOdAbUX1licjd8oU+38=@vger.kernel.org X-Gm-Message-State: AOJu0YxvOuIZFO3znle1m0wdEljlqJs8FdB9uozNK6x9Y6UOxuyvZK0O IX+MUCAMAeHvlbqxqUMbzH6hx7aCTgtmWPOS2qA8KTkM3azTK/lbN/0rvSS9ZmTzjBRAHfrVsvQ UCNJrwJ0AbGyR0kTGVsgB4+ef7972O5JY8CO6rK3Lw5T5YSZtCu0KfJ6FqImua+RVHLWtsUPsb4 pWKjKNpuDbW+q7l1oT1eWQzMC5ApkDzf0NjFuNV4XBRtUjHn/+hJLUCFnqam7zWhiNE+lLTvy1T /3XaM6XZXKEaj5h7YI= X-Gm-Gg: ASbGncslGCgE1EOJD8H4k9hGbyK/m2iPwq+AZ//uwASTlmG/5AsVzLFWxHkrKvN37qY ce7p22fCOxmmIUnCAyEU21x3f5Qcu2R2ydHoLPq6Mu5xgNKBlzykVRoi2wn1RJyTfqD0FA28ZaO FZOa2ZsBGgG9mpfUmR37V1hvGZEZ26G69NBsU8oX+S79dWsaEEwTg1WaeFd5vfRATIpHpmfT1fH XxD7ZfjLWbwR2eA7ECpL/j9PKjaDxrL82FzfyLtVqCih/dhX5tQ7Vm7kKu9Km1y5Nu65HAZciKr Zrf2Xv+lxi2VAcWJhuwFSAYj/b2qD5TeWGBXfuN4G08vzmB+zDuAAoHtJiD8j+SAKspH/rtj/PN qMATxCYCPRMudq0yL4Fr91CVNY/8yAxTc08+6/he12MPi5dMJ5A7pvzjxX6X7ssrcQ2EcAOwt/Q E3naI+Ns4KR00dUfJP0ep5wsVzek1q+RQ= X-Google-Smtp-Source: AGHT+IGH6lOI2ts0P2unOg7QuOSlv5jj0XUTbCSMURU40UOWY/qzud5wETsuS5cuKkWA6PhSVSpzlfGTMDTD X-Received: by 2002:a17:90b:4b44:b0:33d:a6a6:2e26 with SMTP id 98e67ed59e1d1-33e9120495amr1390497a91.13.1761131234358; Wed, 22 Oct 2025 04:07:14 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-14.dlp.protect.broadcom.com. [144.49.247.14]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-33e22421a2esm215116a91.7.2025.10.22.04.07.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Oct 2025 04:07:14 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2909a67aed4so7301895ad.1 for ; Wed, 22 Oct 2025 04:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1761131232; x=1761736032; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kA9Oy21XPeXmPlSwKvLYBk2PQ/Fy4Lvp8jR4DRUe+f8=; b=Zgka9XoA3l7OIOI4OLkeZJH/Na1b5BVlHCBcQKLDnck1NIcLbIgzmR4MS5Zsj+0dh4 819h9Cndr3YHJXCOM+934lRz0i7Ii2UVHfAPWcPSSGwax/PJisvYJDxCIcfvosSEdnyP oLEstaS+13AgAX1EL4M+QDJcuvm8PNY9+8uWQ= X-Forwarded-Encrypted: i=1; AJvYcCV2fkSdpZtwTrEduARA2ZUV5nzKLh3DQj8RofzPxocqwB8b2TJtVqBa9lyrY/knJL4Yn9kOjzuU0mUiRps=@vger.kernel.org X-Received: by 2002:a17:902:f690:b0:28e:873d:8a with SMTP id d9443c01a7336-292ffc0ab76mr41334025ad.15.1761131232541; Wed, 22 Oct 2025 04:07:12 -0700 (PDT) X-Received: by 2002:a17:902:f690:b0:28e:873d:8a with SMTP id d9443c01a7336-292ffc0ab76mr41333645ad.15.1761131232122; Wed, 22 Oct 2025 04:07:12 -0700 (PDT) Received: from photon-dev-haas.. ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29246ffeec3sm135964955ad.52.2025.10.22.04.07.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Oct 2025 04:07:11 -0700 (PDT) From: Ajay Kaher To: kuba@kernel.org, davem@davemloft.net, richardcochran@gmail.com, nick.shi@broadcom.com, alexey.makhalov@broadcom.com, andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com, jiashengjiangcool@gmail.com, andrew@lunn.ch, viswanathiyyappan@gmail.com, vadim.fedorenko@linux.dev, wei.fang@nxp.com, rmk+kernel@armlinux.org.uk, vladimir.oltean@nxp.com, cjubran@nvidia.com, dtatulea@nvidia.com, tariqt@nvidia.com Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, florian.fainelli@broadcom.com, vamsi-krishna.brahmajosyula@broadcom.com, tapas.kundu@broadcom.com, shubham-sg.gupta@broadcom.com, karen.wang@broadcom.com, hari-krishna.ginka@broadcom.com, ajay.kaher@broadcom.com Subject: [PATCH v2 1/2] ptp/ptp_vmw: Implement PTP clock adjustments ops Date: Wed, 22 Oct 2025 10:51:27 +0000 Message-Id: <20251022105128.3679902-2-ajay.kaher@broadcom.com> X-Mailer: git-send-email 2.40.4 In-Reply-To: <20251022105128.3679902-1-ajay.kaher@broadcom.com> References: <20251022105128.3679902-1-ajay.kaher@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Implement PTP clock ops that set time and frequency of the underlying clock. On supported versions of VMware precision clock virtual device, new commands can adjust its time and frequency, allowing time transfer from a virtual machine to the underlying hypervisor. In case of error, vmware_hypercall doesn't return Linux defined errno, converting it to -EIO. Cc: Shubham Gupta Cc: Nick Shi Tested-by: Karen Wang Tested-by: Hari Krishna Ginka Signed-off-by: Ajay Kaher --- drivers/ptp/ptp_vmw.c | 39 +++++++++++++++++++++++++++++---------- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/drivers/ptp/ptp_vmw.c b/drivers/ptp/ptp_vmw.c index 20ab05c4d..7d117eee4 100644 --- a/drivers/ptp/ptp_vmw.c +++ b/drivers/ptp/ptp_vmw.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause /* - * Copyright (C) 2020 VMware, Inc., Palo Alto, CA., USA + * Copyright (C) 2020-2023 VMware, Inc., Palo Alto, CA., USA + * Copyright (C) 2024-2025 Broadcom Ltd. * * PTP clock driver for VMware precision clock virtual device. */ @@ -16,20 +17,36 @@ =20 #define VMWARE_CMD_PCLK(nr) ((nr << 16) | 97) #define VMWARE_CMD_PCLK_GETTIME VMWARE_CMD_PCLK(0) +#define VMWARE_CMD_PCLK_SETTIME VMWARE_CMD_PCLK(1) +#define VMWARE_CMD_PCLK_ADJTIME VMWARE_CMD_PCLK(2) +#define VMWARE_CMD_PCLK_ADJFREQ VMWARE_CMD_PCLK(3) =20 static struct acpi_device *ptp_vmw_acpi_device; static struct ptp_clock *ptp_vmw_clock; =20 +/* + * Helpers for reading and writing to precision clock device. + */ =20 -static int ptp_vmw_pclk_read(u64 *ns) +static int ptp_vmw_pclk_read(int cmd, u64 *ns) { u32 ret, nsec_hi, nsec_lo; =20 - ret =3D vmware_hypercall3(VMWARE_CMD_PCLK_GETTIME, 0, - &nsec_hi, &nsec_lo); + ret =3D vmware_hypercall3(cmd, 0, &nsec_hi, &nsec_lo); if (ret =3D=3D 0) *ns =3D ((u64)nsec_hi << 32) | nsec_lo; - return ret; + + return ret !=3D 0 ? -EIO : 0; +} + +static int ptp_vmw_pclk_write(int cmd, u64 in) +{ + u32 ret, unused; + + ret =3D vmware_hypercall5(cmd, 0, 0, in >> 32, in & 0xffffffff, + &unused); + + return ret !=3D 0 ? -EIO : 0; } =20 /* @@ -38,19 +55,19 @@ static int ptp_vmw_pclk_read(u64 *ns) =20 static int ptp_vmw_adjtime(struct ptp_clock_info *info, s64 delta) { - return -EOPNOTSUPP; + return ptp_vmw_pclk_write(VMWARE_CMD_PCLK_ADJTIME, (u64)delta); } =20 static int ptp_vmw_adjfine(struct ptp_clock_info *info, long delta) { - return -EOPNOTSUPP; + return ptp_vmw_pclk_write(VMWARE_CMD_PCLK_ADJFREQ, (u64)delta); } =20 static int ptp_vmw_gettime(struct ptp_clock_info *info, struct timespec64 = *ts) { u64 ns; =20 - if (ptp_vmw_pclk_read(&ns) !=3D 0) + if (ptp_vmw_pclk_read(VMWARE_CMD_PCLK_GETTIME, &ns) !=3D 0) return -EIO; *ts =3D ns_to_timespec64(ns); return 0; @@ -59,7 +76,9 @@ static int ptp_vmw_gettime(struct ptp_clock_info *info, s= truct timespec64 *ts) static int ptp_vmw_settime(struct ptp_clock_info *info, const struct timespec64 *ts) { - return -EOPNOTSUPP; + u64 ns =3D timespec64_to_ns(ts); + + return ptp_vmw_pclk_write(VMWARE_CMD_PCLK_SETTIME, ns); } =20 static int ptp_vmw_enable(struct ptp_clock_info *info, @@ -71,7 +90,7 @@ static int ptp_vmw_enable(struct ptp_clock_info *info, static struct ptp_clock_info ptp_vmw_clock_info =3D { .owner =3D THIS_MODULE, .name =3D "ptp_vmw", - .max_adj =3D 0, + .max_adj =3D 999999999, .adjtime =3D ptp_vmw_adjtime, .adjfine =3D ptp_vmw_adjfine, .gettime64 =3D ptp_vmw_gettime, --=20 2.40.4 From nobody Sat Feb 7 11:38:21 2026 Received: from mail-pg1-f226.google.com (mail-pg1-f226.google.com [209.85.215.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C366032AABC for ; Wed, 22 Oct 2025 11:07:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.226 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761131239; cv=none; b=BGZJtkywV4HDNqBLbHRDkrQ6o2ejKeAyBsi7GknNiYV6LnlnwCuEw/7cR01c7scIGk8JYz/MeG3cbTcDz79z2Uh/MLn+b4eCyHakRXdfRxc/pbmwuGgwhi1PbUMQBmg7bqcmNlZlK6ihT6DAMp7jVh2V3K78OHGiJuZm4ZkvZTM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761131239; c=relaxed/simple; bh=FwmuKze520gii68OMa9zuCrP0na+LNpw1uC7/S6jaX0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WqxWb4TCPXSp/1BUU81CxYnBJYqR+wSLuvWg6CwhwtDM7b0OUDWcPdmqlayL/UgcU0XpWeg22qVy9/6rcAjI+TM9KsKVlfp2E1EGhGRnv3j5eYLKzS+n07dx3ySrgd8BeI/dCtgfJkR1tV/QdKPzCHZEEh02awvXBB4Op7PSVLo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=aizQs/xl; arc=none smtp.client-ip=209.85.215.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="aizQs/xl" Received: by mail-pg1-f226.google.com with SMTP id 41be03b00d2f7-b6cdba26639so728102a12.1 for ; Wed, 22 Oct 2025 04:07:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761131236; x=1761736036; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7fB5PRpKOjT2mJVqyOTvbhIcOjE9XXiUVHYGkgGRTqY=; b=DWh1JuwSHa4mINVcrxhy+6otXesCk5jQOfrnhUKbX78lum55TOzC9HuQj0jqRllyM6 pxB7fY0Hh8N4hCT+yuPvjFYFeaOtz4hr2c/KCHrrFoXts4cqnaJCas7kySfRCS10B401 DD2RGuStF6EGvfOK6I+fL3anTxlWHGt9iBeG3A2NV7xt13CDp2ffGafmYe7jGGodbq9r bNYs2efqh0kUSG37gmFGwtimQZdr3RR9aCiFYqdLpKBTkE/RNrrwcJcZ4O/yyTas8CSo wyoN/sudJhG7Y5yNGgir1c2ZmYPFUJhyp2J6L/G2YadW82VldvgeUToCADDpFEMbOeMl iJ6Q== X-Forwarded-Encrypted: i=1; AJvYcCWMzBdy+V3HAAYrTLWF4SATNHlv+CGPbgga7VAa17VgC66IHD5OOypbqMY/Z2yWtrfGdaUTvwuN2jGC//M=@vger.kernel.org X-Gm-Message-State: AOJu0YwBwFRYyjppPWgUhUN6seGhRg40FDyyhn/hpDj43IlsULHMesbB 2zVxEjTXXmw7+Df+q2fh9gl0E+YZV9zuiL5XG3E4vqptQokJZA/iVDUBV/Kx8lB3rD1a7sXd5c7 NcitHsawGmOwilpTKKXJyoYgrVy6lNME3myPthnhMSYz+VTa/oukw6nK5cAv3pj/VhuA7V7QioS 4ZxLhiEel/9INffPPJD9OkBUegcTRkYNpAUdQkuwtY1lxRObHavQQDupOA9CbyBZyVxyU/SiEpT 9d+JmNekoO+VOk+5w0= X-Gm-Gg: ASbGncuZfDYoCLEtKSEozB0ceUkOkLqCFAm9G36rInX/F/RjFhECnmNQbR8jDsCJX+1 8MYQffluL14cjbInCUPdEvJtSbDKw9p3w9sHBoBujQBMB9LCJuSGytuIPsxaVatowwo48vPtSse WYYGIuS/x6FU5/2BT6itFXpyn/ktZUswbaXNNwXMKsUUr5t6bvCa303983qRfNB0YkuMY0RQjqP f4nJUWY6zHLTfeGubza5AhBvJ5kwbtdPes9DfvgciNoeXr0+9i/42PhGHTWhTzYiZ3uTggO2FTT ru5iLFf0mw08Hm1TYPWT+e3TXkHcEPT50dPIpv/U1AH90t2Og8ZHltfiReXsj+Yrm1Qj9xVSRO+ 4kxs8RGtLbgJVIkadWTAqU3ijC/cYo9svHOsQ5FDrBtPf2UcumH94qv154TqVoUzq+/Uh81ic9T JZZXRUPVLxd37wcZMxJigBkE5Ts0iiqawxTg== X-Google-Smtp-Source: AGHT+IHC6UXhfJVWFAAAgdeTZc6vXcuiZuPo79UrqpIwmSoqMw6qSBELHay3kjEUxaLSkQeY7VJooPvq7t4Y X-Received: by 2002:a17:903:37c4:b0:290:ad7a:bb50 with SMTP id d9443c01a7336-2935e126d63mr10580785ad.27.1761131236072; Wed, 22 Oct 2025 04:07:16 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-120.dlp.protect.broadcom.com. [144.49.247.120]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-292471c6169sm13917175ad.34.2025.10.22.04.07.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Oct 2025 04:07:16 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-290992f9693so7275715ad.1 for ; Wed, 22 Oct 2025 04:07:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1761131234; x=1761736034; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7fB5PRpKOjT2mJVqyOTvbhIcOjE9XXiUVHYGkgGRTqY=; b=aizQs/xl1mUCkYcHScPFtQ7m6Xo42IEhSXoVn1079raFotWqloKvt13J4bHOCksUzb gdzZyeKpbkjSMGuytQ4A2X60bUX/59GitketaHL/ueN++ZAU/RR7S5ZTWk37c2r+W8uH mY6ELD3BEHGQlWKjjzPUg41NxEAvwoZ3lO5Ag= X-Forwarded-Encrypted: i=1; AJvYcCXyrXXXw1pnLpo/zXARHMMe2m6xh/n0t3v3fRYpRKmo916U7T/lpy2rJQouUwJMnDBR443CDlUR05av4nk=@vger.kernel.org X-Received: by 2002:a17:902:d509:b0:269:8eba:e9b2 with SMTP id d9443c01a7336-292ffc97bfamr41948665ad.29.1761131234306; Wed, 22 Oct 2025 04:07:14 -0700 (PDT) X-Received: by 2002:a17:902:d509:b0:269:8eba:e9b2 with SMTP id d9443c01a7336-292ffc97bfamr41948175ad.29.1761131233780; Wed, 22 Oct 2025 04:07:13 -0700 (PDT) Received: from photon-dev-haas.. ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29246ffeec3sm135964955ad.52.2025.10.22.04.07.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Oct 2025 04:07:13 -0700 (PDT) From: Ajay Kaher To: kuba@kernel.org, davem@davemloft.net, richardcochran@gmail.com, nick.shi@broadcom.com, alexey.makhalov@broadcom.com, andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com, jiashengjiangcool@gmail.com, andrew@lunn.ch, viswanathiyyappan@gmail.com, vadim.fedorenko@linux.dev, wei.fang@nxp.com, rmk+kernel@armlinux.org.uk, vladimir.oltean@nxp.com, cjubran@nvidia.com, dtatulea@nvidia.com, tariqt@nvidia.com Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, florian.fainelli@broadcom.com, vamsi-krishna.brahmajosyula@broadcom.com, tapas.kundu@broadcom.com, shubham-sg.gupta@broadcom.com, karen.wang@broadcom.com, hari-krishna.ginka@broadcom.com, ajay.kaher@broadcom.com Subject: [PATCH v2 2/2] ptp/ptp_vmw: load ptp_vmw driver by directly probing the device Date: Wed, 22 Oct 2025 10:51:28 +0000 Message-Id: <20251022105128.3679902-3-ajay.kaher@broadcom.com> X-Mailer: git-send-email 2.40.4 In-Reply-To: <20251022105128.3679902-1-ajay.kaher@broadcom.com> References: <20251022105128.3679902-1-ajay.kaher@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" For scenerios when ACPI is disabled, allow ptp_vmw driver to be loaded by directly probing for the device using VMware hypercalls. VMware precision clock virtual device is exposed as a platform ACPI device in its virtual chipset hardware. Its driver - ptp_vmw - is registered with the ACPI bus for discovery and binding. On systems where ACPI is disabled, such as virtual machines optimized for fast boot times, this means that the device is not discoverable and cannot be loaded. Since the device operations are performed via VMware hypercalls, the ACPI sub-system can be by-passed and manually loaded. Cc: Shubham Gupta Cc: Nick Shi Tested-by: Karen Wang Tested-by: Hari Krishna Ginka Signed-off-by: Ajay Kaher --- drivers/ptp/ptp_vmw.c | 70 +++++++++++++++++++++++++++++++++++-------- 1 file changed, 58 insertions(+), 12 deletions(-) diff --git a/drivers/ptp/ptp_vmw.c b/drivers/ptp/ptp_vmw.c index 7d117eee4..a3978501a 100644 --- a/drivers/ptp/ptp_vmw.c +++ b/drivers/ptp/ptp_vmw.c @@ -98,25 +98,41 @@ static struct ptp_clock_info ptp_vmw_clock_info =3D { .enable =3D ptp_vmw_enable, }; =20 +static int ptp_vmw_clock_register(void) +{ + ptp_vmw_clock =3D ptp_clock_register(&ptp_vmw_clock_info, NULL); + if (IS_ERR(ptp_vmw_clock)) { + pr_err("ptp_vmw: Failed to register ptp clock\n"); + return PTR_ERR(ptp_vmw_clock); + } + pr_debug("ptp_vmw: ptp clock registered\n"); + return 0; +} + +static void ptp_vmw_clock_unregister(void) +{ + ptp_clock_unregister(ptp_vmw_clock); + ptp_vmw_clock =3D NULL; + pr_debug("ptp_vmw: ptp clock unregistered\n"); +} + /* * ACPI driver ops for VMware "precision clock" virtual device. */ =20 static int ptp_vmw_acpi_add(struct acpi_device *device) { - ptp_vmw_clock =3D ptp_clock_register(&ptp_vmw_clock_info, NULL); - if (IS_ERR(ptp_vmw_clock)) { - pr_err("failed to register ptp clock\n"); - return PTR_ERR(ptp_vmw_clock); - } + int ret =3D ptp_vmw_clock_register(); =20 - ptp_vmw_acpi_device =3D device; - return 0; + if (ret =3D=3D 0) + ptp_vmw_acpi_device =3D device; + return ret; } =20 static void ptp_vmw_acpi_remove(struct acpi_device *device) { - ptp_clock_unregister(ptp_vmw_clock); + ptp_vmw_clock_unregister(); + ptp_vmw_acpi_device =3D NULL; } =20 static const struct acpi_device_id ptp_vmw_acpi_device_ids[] =3D { @@ -135,16 +151,46 @@ static struct acpi_driver ptp_vmw_acpi_driver =3D { }, }; =20 +/* + * Probe existence of device by poking at a command. If successful, + * register as a PTP clock. This is a fallback option for when ACPI + * is not available. + */ +static int ptp_vmw_probe(void) +{ + u64 ns; + + return ptp_vmw_pclk_read(VMWARE_CMD_PCLK_GETTIME, &ns); +} + static int __init ptp_vmw_init(void) { - if (x86_hyper_type !=3D X86_HYPER_VMWARE) - return -1; - return acpi_bus_register_driver(&ptp_vmw_acpi_driver); + int error =3D -ENODEV; + + if (x86_hyper_type !=3D X86_HYPER_VMWARE) { + error =3D -EINVAL; + goto out; + } + + if (!acpi_disabled) { + error =3D acpi_bus_register_driver(&ptp_vmw_acpi_driver); + if (!error) + goto out; + } + + if (!ptp_vmw_probe()) + error =3D ptp_vmw_clock_register(); + +out: + return error; } =20 static void __exit ptp_vmw_exit(void) { - acpi_bus_unregister_driver(&ptp_vmw_acpi_driver); + if (!acpi_disabled && ptp_vmw_acpi_device) + acpi_bus_unregister_driver(&ptp_vmw_acpi_driver); + else if (ptp_vmw_clock) + ptp_vmw_clock_unregister(); } =20 module_init(ptp_vmw_init); --=20 2.40.4