From nobody Mon Feb 9 16:16:54 2026 Received: from canpmsgout02.his.huawei.com (canpmsgout02.his.huawei.com [113.46.200.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7459169AD2; Wed, 22 Oct 2025 02:11:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.217 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761099117; cv=none; b=odsNXkFjtUkucdp5lWShwP9h/iXqULmUbVrTR/NY+qW2tekBvgAi7ENecAemu9ikzvlcoRsye3ruLl101LS+IrBfT04r1LfGArMdeKEIUL1jfYnyvgm/y/5ONwAaz2nXVwnMf0XUVDvtJfEGWG/oI1t6sgTplKuBSIrH4XX5GBs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761099117; c=relaxed/simple; bh=Nsg0Yw+InIRdb8h4r8uxLUjKDvEeGwzHLykxefHFZzE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FCBTaPq5E5wxQwoedCOCA12XclCZFD1ZHt+gmRgXlulr05g4H/mt2JRgWf7gPsgEr1nrt75nHcR1H0wpUvTn5IAFLmrJ77xP9DULsgxqDLQFwjGt6yFzFQ4rHMw15wy1TZdDmaC1ll6suPbPIxetrTcUsV6wcO/P7V1qfhykNC4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=XB8eC3Hw; arc=none smtp.client-ip=113.46.200.217 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="XB8eC3Hw" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=zrDM8N2facYztZNSctpljuVTrGS329FDJZ4nG1IOeaU=; b=XB8eC3HwC27UpN1RJsO/SqlkVkxtVn0yENGCZSnJFq0+HfGCNdvkpbcGA9uMe12qAAG6YlcfZ T8XdXb+eoqR+mgbY5Yl0PMy0Dzc+Pvm6KYIWUKOXTwQ//SUnVkQpbCZLJjXQO5mVKuQD5o2seUN dw1ir6Yltdaoqvqp7hhhWlg= Received: from mail.maildlp.com (unknown [172.19.163.48]) by canpmsgout02.his.huawei.com (SkyGuard) with ESMTPS id 4crt1F5QwLzcb1W; Wed, 22 Oct 2025 10:10:41 +0800 (CST) Received: from dggemv706-chm.china.huawei.com (unknown [10.3.19.33]) by mail.maildlp.com (Postfix) with ESMTPS id 52BF8180080; Wed, 22 Oct 2025 10:11:52 +0800 (CST) Received: from kwepemq200001.china.huawei.com (7.202.195.16) by dggemv706-chm.china.huawei.com (10.3.19.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 22 Oct 2025 10:11:52 +0800 Received: from localhost.huawei.com (10.90.31.46) by kwepemq200001.china.huawei.com (7.202.195.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 22 Oct 2025 10:11:51 +0800 From: Chenghai Huang To: , , CC: , , , , , , Subject: [PATCH v4 2/4] uacce: fix isolate sysfs check condition Date: Wed, 22 Oct 2025 10:11:47 +0800 Message-ID: <20251022021149.1771168-3-huangchenghai2@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20251022021149.1771168-1-huangchenghai2@huawei.com> References: <20251022021149.1771168-1-huangchenghai2@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems500001.china.huawei.com (7.221.188.70) To kwepemq200001.china.huawei.com (7.202.195.16) Content-Type: text/plain; charset="utf-8" uacce supports the device isolation feature. If the driver implements the isolate_err_threshold_read and isolate_err_threshold_write callback functions, uacce will create sysfs files now. Users can read and configure the isolation policy through sysfs. Currently, sysfs files are created as long as either isolate_err_threshold_read or isolate_err_threshold_write callback functions are present. However, accessing a non-existent callback function may cause the system to crash. Therefore, add checks before calling the corresponding ops. Fixes: e3e289fbc0b5 ("uacce: supports device isolation feature") Cc: stable@vger.kernel.org Signed-off-by: Chenghai Huang Acked-by: Zhangfei Gao --- drivers/misc/uacce/uacce.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c index 9b82a6731832..d272db516a65 100644 --- a/drivers/misc/uacce/uacce.c +++ b/drivers/misc/uacce/uacce.c @@ -382,6 +382,9 @@ static ssize_t isolate_strategy_show(struct device *dev= , struct device_attribute struct uacce_device *uacce =3D to_uacce_device(dev); u32 val; =20 + if (!uacce->ops->isolate_err_threshold_read) + return -ENOENT; + val =3D uacce->ops->isolate_err_threshold_read(uacce); =20 return sysfs_emit(buf, "%u\n", val); @@ -394,6 +397,9 @@ static ssize_t isolate_strategy_store(struct device *de= v, struct device_attribut unsigned long val; int ret; =20 + if (!uacce->ops->isolate_err_threshold_write) + return -ENOENT; + if (kstrtoul(buf, 0, &val) < 0) return -EINVAL; =20 --=20 2.33.0