From nobody Sat Feb 7 08:45:35 2026 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E04183101A9 for ; Wed, 22 Oct 2025 10:34:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761129251; cv=none; b=g5FHm7OfYYO3BlUak98eRJWizAksdjA+gvw8kBrq+iQjSplgwr3ZuhO3fDR6IqPMmMjznXfs0xhWWilYLHdw3KmB1Uz/0Qbt3zyvDFhH2bnt1sXL/tlOf1fgnh48lEBiPlPc8GiDuhAZrhBLa101VM8XOwHtYureUYUC0ZlZSwk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761129251; c=relaxed/simple; bh=yYE5CNERKTz2FywTSc6GGp1KpbjkuY9QxAIOCQajP9o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=j4O7sCUQJw2+BJsUKxOfGicNYGZaHeQxSofTJq+NbeFU/iEzq3gcozpCN7tOYNGDS3Piz131fPBsbrfNJq1CRIxMNmdgsk1Ffg9Ca1U0xeYq6z4ZsG5E6fx+UHtebyfL+RU68GDua4r5yEIr3RK/m/b5Mz6SyUXVIWqrSLp331o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=bpQn1S9v; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="bpQn1S9v" Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59M8SFDn017546; Wed, 22 Oct 2025 10:33:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=Od97J/ A15Ke/ThZ/3Q1QlICKHrvcNbuW3doNnpcz9GI=; b=bpQn1S9vbWPFlpJb1Qgy9y J7jQ/VbaxCSNF00EMNGpSYQm/mULhKLzoMttdc+hTCnQ38S0QD2GFKtB7ikTfOzE fv0rQA96A7oNAanUUDeArv9wxOYh6ROQPaiWmUwhUh9DmIRd7YuMLfRfHXCGEXJf eTlUxloe3qvP17MrNoRWftnoRNnSJIIgTBZeONWWjSNK3owqtxbefPv+NCRxxonh QVXsnDGPu8o+feKL2iZ4820jnKs8LeYI7tRD8PnKnxJ7MNiM+PCj+ClNpf2wXE5m EWf0XhlHFpxtnEVfou6wgCKJbw5t41QTt8rnPngqU3WSR5X+PBgXvvYZW+TWvLNg == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49v33fc5wq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Oct 2025 10:33:49 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 59M7kSRH002324; Wed, 22 Oct 2025 10:33:48 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 49vqejfjp0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Oct 2025 10:33:48 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 59MAXjMF42729728 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Oct 2025 10:33:45 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 15AD3200A4; Wed, 22 Oct 2025 10:33:45 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E8E67200A6; Wed, 22 Oct 2025 10:33:44 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 22 Oct 2025 10:33:44 +0000 (GMT) From: Gerd Bayer Date: Wed, 22 Oct 2025 12:33:16 +0200 Subject: [PATCH v2 1/2] nvme-pci: Print error message on failure in nvme_probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251022-nvme_probefail-v2-1-26bbdf94280e@linux.ibm.com> References: <20251022-nvme_probefail-v2-0-26bbdf94280e@linux.ibm.com> In-Reply-To: <20251022-nvme_probefail-v2-0-26bbdf94280e@linux.ibm.com> To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Cc: Niklas Schnelle , Greg Kroah-Hartman , Chaitanya Kulkarni , Wilfred Mallawa , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Gerd Bayer X-Mailer: b4 0.14.2 X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=FMYWBuos c=1 sm=1 tr=0 ts=68f8b30d cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=GWyhmD5H9okkrlSlx5YA:9 a=QEXdDO2ut3YA:10 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-GUID: ZA--MZ6P12ewBNGmzYdtBs95u6_HQSbB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAyMiBTYWx0ZWRfX/iRSg8XHU5U5 V5Y+Q587IR5DLtKB/WoKVQT2ZTkBj1vh0tOwY5WrCc6QU0J935RuxKemRgWrY4c9G22THB7jniN 4dnvs1Jzy4TvdnSyvm1Ci8gOgadut6mmBmvj6Mie1G9ctxxfatS5wkhxIq5sAc6k/IXupbf09F+ WJFKih2XvgxD2QJh0B1/CKTd3PvUHUQ/2O2Mp8FkPmfA+xXK+HdHBT0nuYe6DaEyGUYlLGJsbAe qBLXpfvqm7fLnUj/aCcq5iyuQNJQtyLN6SsOuk05DoPPazbjjy5WbN1hBGIcICOrYJ6uv1Kh7og vYaSLI7ACwdrld9LU0jkcpMqblQYp+6+Ncwy4HbGLUCfw85n4DPXjNOivP72I6XKeGE1NRF1xR/ dyJLLHhiiukhSv1XFSTlgg5OU3Pf4Q== X-Proofpoint-ORIG-GUID: ZA--MZ6P12ewBNGmzYdtBs95u6_HQSbB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-22_03,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 impostorscore=0 priorityscore=1501 adultscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180022 Add a new error message that makes failures to probe visible in the kernel log, like: nvme 0008:00:00.0: error -ENODEV: probe failed This highlights issues with a particular device right away instead of leaving users to search for missing drives. Signed-off-by: Gerd Bayer Reviewed-by: Christoph Hellwig --- drivers/nvme/host/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index c916176bd9f058b49e6e6768675711df52b15765..8c624960c9f67e0cc8409023de5= e532d6ed9b3ac 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -3522,6 +3522,7 @@ static int nvme_probe(struct pci_dev *pdev, const str= uct pci_device_id *id) nvme_uninit_ctrl(&dev->ctrl); out_put_ctrl: nvme_put_ctrl(&dev->ctrl); + dev_err_probe(&pdev->dev, result, "probe failed\n"); return result; } =20 --=20 2.48.1 From nobody Sat Feb 7 08:45:35 2026 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE3C72EC0A9 for ; Wed, 22 Oct 2025 10:33:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761129241; cv=none; b=dq8Ith+9x+8uSuE9+0n9KyTEZmpaAhR6BjLI2DAxGr7MG/jRUsboLzS++is2saF2JnMdzcma5wIaUSDo44qOS6CJ7x7qByyn/9FwZ6wTNm9NHLxKhJBwf6TKruDsyrGv78XxevlzIea1O5DpMiQWWBzRvQGRGKkQl0J2qLIcHmU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761129241; c=relaxed/simple; bh=MsDVyUDRdNmsjKrCMp8miBjHNy8iNy4o1P69vogQSsU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iJH9jj4kb+CkPpQ70m1QF+MK2OubS5CboosRzTrK1j/7P3lKOs2Pqsokulwrjhw0VDguD02pg6if5iF8FJPwQXksD5ZqShnoCl1pGFS4ebBbOTFoWsuiVzdzAKLL1vfZFfTD+4N69ANXLStmh5C5zaLLpKWxyB8Gr6v+vtFLV+o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=omoYXkgk; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="omoYXkgk" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59M1XqhS003010; Wed, 22 Oct 2025 10:33:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=ZmuJhu tMfvig7ABoeqG5Gz+8QdZtaHNzjH8dqMQNPD0=; b=omoYXkgkknYxrXvyJTnEbJ 133tE7t4VqMuSJkYijxW+4ICrDN9FIdA9150RdyDHYqCCNVzB1a6ufw721OQCsqe EITUjnBSSRkkOzjwS8dmlN3vuVIs8t1pVFSAVQSv7sVoglwGxSDdi7iCkzEWHWC+ 0WEQqqqIR0QH5Sd/lPSVJl/s98mc2qpuXeXSJTYxUXAzz7cQqWtgG2f1PPQLDk+x OayHKmJejP5u8f/qKs9V6cV6WpyOpk+oRg6YHqkYJf6L0iqpY7Rdg1WgqQLmX9LO R2IcdjxuFEQDTRYyxOe7PpNaU54NE+cTl1EXMG4moov6CIO+pHb3njiZcrbUYSLg == Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49v30vtqgr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Oct 2025 10:33:49 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 59M6wmuf024987; Wed, 22 Oct 2025 10:33:49 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 49vpqjypj7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Oct 2025 10:33:49 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 59MAXjUx42729730 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Oct 2025 10:33:45 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3B86A200A4; Wed, 22 Oct 2025 10:33:45 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 18DE3200A7; Wed, 22 Oct 2025 10:33:45 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 22 Oct 2025 10:33:45 +0000 (GMT) From: Gerd Bayer Date: Wed, 22 Oct 2025 12:33:17 +0200 Subject: [PATCH v2 2/2] nvme-pci: Add debug message on fail to read CSTS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251022-nvme_probefail-v2-2-26bbdf94280e@linux.ibm.com> References: <20251022-nvme_probefail-v2-0-26bbdf94280e@linux.ibm.com> In-Reply-To: <20251022-nvme_probefail-v2-0-26bbdf94280e@linux.ibm.com> To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Cc: Niklas Schnelle , Greg Kroah-Hartman , Chaitanya Kulkarni , Wilfred Mallawa , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Gerd Bayer , Chaitanya Kulkarni X-Mailer: b4 0.14.2 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: jKMHZT-R5zsH3hTJ1pDsaNwvxmf9B69a X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAyMiBTYWx0ZWRfX+exPNhm5fnSI dFc0WCO0nxFwJznurdG/Ya+bhmNJl1k0eq4X2hxopaKwhxWiS/v8c8iW5LA2J+gntV8cbwphANk cKOErFZGKHYrCtxQEQ0erahH3lhY1ohFZAHCC+nCmKw2DQ9AMddI064Y8f63azkotJNbNo30Onv XQ9GCP6StKZrm12k3ihuThRnxKfCWxOLua8uLKukOojxM74oUArwHmjbl3VS8RGmVOGjY01Bmhl VXYaqqLrayX27W1HdA46JEWcG2BTiHkh3XWsKKi/AC5PV6qqAyOtne6evBd3uj3SbT1c+sjVKOw 2fFlv+DBU9cBJkwmzspwR8DKF4q8tyCkFazcNa7MB7jUzQ3TTxpdO2Dci2w72+BE3ZiNdh6SK0O JRCR78PTi3XYNajYhMEu3lwKFG15nw== X-Authority-Analysis: v=2.4 cv=MIJtWcZl c=1 sm=1 tr=0 ts=68f8b30d cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=JF9118EUAAAA:8 a=Ikd4Dj_1AAAA:8 a=VnNF1IyMAAAA:8 a=Gwek0BahB5A2Lshf9EwA:9 a=QEXdDO2ut3YA:10 a=xVlTc564ipvMDusKsbsT:22 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-ORIG-GUID: jKMHZT-R5zsH3hTJ1pDsaNwvxmf9B69a X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-22_03,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 clxscore=1011 impostorscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180022 Add a debug log spelling out that reading the CSTS register failed - to distinguish this from other reasons for ENODEV. Reviewed-by: Wilfred Mallawa Reviewed-by: Chaitanya Kulkarni Signed-off-by: Gerd Bayer Reviewed-by: Christoph Hellwig --- drivers/nvme/host/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 8c624960c9f67e0cc8409023de5e532d6ed9b3ac..ce563e93d29443a25e9236d0b6d= 8152ee85796d7 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -2906,6 +2906,7 @@ static int nvme_pci_enable(struct nvme_dev *dev) pci_set_master(pdev); =20 if (readl(dev->bar + NVME_REG_CSTS) =3D=3D -1) { + dev_dbg(dev->ctrl.device, "reading CSTS register failed"); result =3D -ENODEV; goto disable; } --=20 2.48.1