From nobody Wed Oct 22 15:56:49 2025 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010020.outbound.protection.outlook.com [52.101.193.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C46B202960; Tue, 21 Oct 2025 18:30:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.20 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761071420; cv=fail; b=iB7n1yXLyqLUadCEUNJF57qDtn5ZlSbam9PYtYjsZT3LOS8jTRYDC25ANJ6rHbb1C3uKynQTkxoqV/I1cBB+ntAMoh9bYVJD0QPWdSRCznMXxfdGcrKMjYnl2QbH0WmnPGlTpnoc0ACKvXRYXlhnYMEzgBl5c9gqusdpjtajM7Q= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761071420; c=relaxed/simple; bh=qwg7fXBV51P0szhN9pegkNw54/HzrplOd1cIfFyAVog=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=PIkHJxBWQ4PPd1r99Y+oVhKtiXLeBGbLBDXMcK1WPodrE/KjvLloFT1AMnL4w4x+9HmUYLO1U9NDL5jkGrI8pOYeYG2n3XLnq704l0cZPEBvYqpSvhHVMGBlDpwRZ6Zmn1x1OfiMOv/+3Yuaf0Gq8NR/frpdduyIhh2Y9kBDwgY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Gv1MUfjT; arc=fail smtp.client-ip=52.101.193.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Gv1MUfjT" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jv0MIOMeeZiAUB0/VbOyfqC2vb1dUt3aPWIxLeKpRycAIZcKV/aj2h6aTOpPeR7bzhQnrKtszkmuDuogoVVqOy46i68g5z/Upt/rdkJhTQmfPtcbdmHif7SZCtje7x/0D5TcenvUKKEw6myQcRLZDBgWISQx3W42UInbnJCk4mbH19zjBllYOqSCXAzwBP/l3U/VvNzG710ZIJrj96IpBVNNifVUWZ0+IiRlf9M2BfIN7COT+Ak5Sth9hW0k953s543Uso60eSXoTXJUvcZdeqSliriuLT0eLW/CuPvWIwEMbeH0EtjV9dlpSUvRTgd/RswcbSdVzgLQXMNdRQQZVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Usx1Sr1FDAlweubt1VdxDA9QuQOcgnDZzd5QvIx5ws8=; b=C+bg/EhUu2PpRFoufuryN75SJKg/w0SQ6VLzefkBco/kzM5IN2D+fwdQXKZLTQhQmOCfk0J+sx8zKicwirhB9CFmNpWc1WHQrUGrKCHXY5sjRxrJMpAwxdT//KNA5QVurO1PvES2ITzuSS7avNcmJcBdbtNbd0lrzybXrrViJ1u31P7D+Us1V8wKmZy0q1M2B7iyGbB2cmnH4yKTTGdexxIZOA0mhm+l1hp/XyqjdAriKpz6IM6hXJgs1DBq68yBMq7wBfy+dm9IkHXjErQ3u4kw6/L6wPp8/BMyYZjWkZBBSJfm/DOO8I5VLU5cWDIQt/mSsPFKpDe37BhwTtjlXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Usx1Sr1FDAlweubt1VdxDA9QuQOcgnDZzd5QvIx5ws8=; b=Gv1MUfjTXBHlmWNSTPgCBNwxFSjKwtTmGQKuXy8R6rKewbFVsDOH2VVYKByn2oWQBSstbnagx7/1rukmDt5PK1mx8Du64/8hE6bFdLDCI78tpEB1a/BpBR1Utye+ALr87xsw8vYa/ivRvmdpRNgcuBK3/yiMjb5YogfZxjHQHQs= Received: from CH2PR16CA0030.namprd16.prod.outlook.com (2603:10b6:610:50::40) by LV2PR12MB5968.namprd12.prod.outlook.com (2603:10b6:408:14f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9228.17; Tue, 21 Oct 2025 18:30:12 +0000 Received: from CH2PEPF00000099.namprd02.prod.outlook.com (2603:10b6:610:50:cafe::5b) by CH2PR16CA0030.outlook.office365.com (2603:10b6:610:50::40) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9253.12 via Frontend Transport; Tue, 21 Oct 2025 18:30:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by CH2PEPF00000099.mail.protection.outlook.com (10.167.244.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9253.7 via Frontend Transport; Tue, 21 Oct 2025 18:30:11 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Tue, 21 Oct 2025 11:30:08 -0700 Received: from satlexmb08.amd.com (10.181.42.217) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 21 Oct 2025 13:30:08 -0500 Received: from xhdsuragupt40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Tue, 21 Oct 2025 11:30:06 -0700 From: Suraj Gupta To: , , CC: , , Subject: [PATCH RESEND] dmaengine: xilinx_dma: Fix uninitialized addr_width when "xlnx,addrwidth" property is missing Date: Wed, 22 Oct 2025 00:00:06 +0530 Message-ID: <20251021183006.3434495-1-suraj.gupta2@amd.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000099:EE_|LV2PR12MB5968:EE_ X-MS-Office365-Filtering-Correlation-Id: 99a4c4c7-729a-4992-54d4-08de10cfdf09 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bvqFlkvPcce5GCNVCWqiOmK0ZYtIwOKk09HfubD53rKSkU3eb1Bd8WXy9T8Y?= =?us-ascii?Q?5kSnohz0nNVnA9KTmWsavON9KHbXqEP19VrYf5/4Pkj6OANyo7q3jpck7ExS?= =?us-ascii?Q?OYD2IpayDnpV3YAu8DK6zR0+66GMmlGjXwNfsdqBmDToQ9N0tPmxCgCzMVyZ?= =?us-ascii?Q?91blWSg6UfYjfrrb1Q/RxlvcAPtCKJMCBZlBjXy9+H7Qz6yCuYSHxZ/l+JPL?= =?us-ascii?Q?93Ceq5jKyCbCO/qqAIppt0gHESsYoI5xBCKl7wC+AL4XEVjbRFxh3C5hdIba?= =?us-ascii?Q?T900/jDQ2ltHcqUzQkCKrxaoA55yXNVhQkXvdZEfecFqV9CiZ3qd8uftmW7j?= =?us-ascii?Q?jAD48jstSrA4F34k7MnH3oqMXKgL7dyXu63ANtLVtAi9nyPS2Aizsl44gaQu?= =?us-ascii?Q?2xXFNfwQNqp2knYrbRPSKhqKqrEXZk5E1yOs/yJmtD4BFfsGvG3fDGeoSRMs?= =?us-ascii?Q?zVsD2b7uC1hE9UEsjuuEVZnhVLDKGEF7PlVLirQb9uI5i0+Fi/ktvdnVE/VQ?= =?us-ascii?Q?UdOuCd6pBpjkPwEI6jHVGqAhHod7/wiYnVo74zJ6ehpYbsYKqftjAz/fRfUk?= =?us-ascii?Q?VifPkRCwRsFFrpITQx4tPtlVD6RPe/7rppA5ag/6E6FVZ47nLHEEzXENZISr?= =?us-ascii?Q?yyyq+NyFwoSd5NHOwZkUzeAk8DTs7R3Z+oCDdyVKsjgNvUlhjlSOoDl1K2wS?= =?us-ascii?Q?VxUbLltc7psCYpXvICqylyF82dKhaTSZDSX8G6m1X2uG/R2DEfXXOtGR1tPK?= =?us-ascii?Q?fVerXr/U9VYnb08Lyu5t3Zpu/KhQhPiIhf/ErC4OlyJKIlgYqH/Q73b0VKCJ?= =?us-ascii?Q?L7mTKNnBqhK07xGRljvWxB7hfMAGotI0SgtEy7jKY7n1PtaXKPfm/ofxzfi/?= =?us-ascii?Q?EfhvMx0qi+sF9B1nwuTTgGGWxKggiMWj4GFZY4emhjg329HPs0YJnONWFif5?= =?us-ascii?Q?b4jpyhGrTvDe2OKRBgTzJdVbH7vVypmFrz5ke9q/+CqGcOqK3O88IRosPJNH?= =?us-ascii?Q?Jw1l1ZMhsnHkZdsYMqM6IvZ0e9RTbMmig/CEBS3hY5v3dDPKA91R52yh0sOF?= =?us-ascii?Q?SbueTPHwqGmrJt7SM4RpOaPBWzIlHjZLg3h6M0nx4ARM9+d/ABIdxpZzqUYN?= =?us-ascii?Q?0Fi9Rn3fDZyp9a0SPiAtDDsQZAvTALFfDeu8qorDxiU/aePieY594sPKZC9w?= =?us-ascii?Q?cwqYY7vM6LUDbSR0ZH/ZXlnbUhQUhFFXwgNJatF4unsVvSaR5jSAWnz/flxL?= =?us-ascii?Q?kLQfZ480Ll9297GH2tYakIYXXmjlAUSOKJpmDphvzlVs6PCMYgvnqKi6+wCB?= =?us-ascii?Q?X7+Q7SDttiU9M3dDNEkilH4A0yEHdFCeNN6Q+s8UfmkzhhKNMYAB9WAMMIx+?= =?us-ascii?Q?yba0QrzujHZmduQXXbfQ8QLv5E1IIl2b8w2Zu+/fX/oEunYmLk6Sr4ao6C0F?= =?us-ascii?Q?PfaJoSwCRz1zdy//TSkydaBmMBKkokRmd/F8t7fSlM3EB4cJHnsa065WE16h?= =?us-ascii?Q?e7MBwzVvzmeqiiCVv1+T1Ax7c1lYDeKkaSJQUpr5hc/RlbiJ8C+VVngixz4P?= =?us-ascii?Q?MxCbG8sWh/PAYAxyNKc=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2025 18:30:11.9080 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 99a4c4c7-729a-4992-54d4-08de10cfdf09 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000099.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5968 Content-Type: text/plain; charset="utf-8" When device tree lacks optional "xlnx,addrwidth" property, the addr_width variable remained uninitialized with garbage values, causing incorrect DMA mask configuration and subsequent probe failure. The fix ensures a fallback to the default 32-bit address width when this property is missing. Signed-off-by: Suraj Gupta Fixes: b72db4005fe4 ("dmaengine: vdma: Add 64 bit addressing support to the= driver") Reviewed-by: Radhey Shyam Pandey Reviewed-by: Folker Schwesinger --- drivers/dma/xilinx/xilinx_dma.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dm= a.c index fabff602065f..89a8254d9cdc 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -131,6 +131,7 @@ #define XILINX_MCDMA_MAX_CHANS_PER_DEVICE 0x20 #define XILINX_DMA_MAX_CHANS_PER_DEVICE 0x2 #define XILINX_CDMA_MAX_CHANS_PER_DEVICE 0x1 +#define XILINX_DMA_DFAULT_ADDRWIDTH 0x20 =20 #define XILINX_DMA_DMAXR_ALL_IRQ_MASK \ (XILINX_DMA_DMASR_FRM_CNT_IRQ | \ @@ -3159,7 +3160,7 @@ static int xilinx_dma_probe(struct platform_device *p= dev) struct device_node *node =3D pdev->dev.of_node; struct xilinx_dma_device *xdev; struct device_node *child, *np =3D pdev->dev.of_node; - u32 num_frames, addr_width, len_width; + u32 num_frames, addr_width =3D XILINX_DMA_DFAULT_ADDRWIDTH, len_width; int i, err; =20 /* Allocate and initialize the DMA engine structure */ @@ -3235,7 +3236,9 @@ static int xilinx_dma_probe(struct platform_device *p= dev) =20 err =3D of_property_read_u32(node, "xlnx,addrwidth", &addr_width); if (err < 0) - dev_warn(xdev->dev, "missing xlnx,addrwidth property\n"); + dev_warn(xdev->dev, + "missing xlnx,addrwidth property, using default value %d\n", + XILINX_DMA_DFAULT_ADDRWIDTH); =20 if (addr_width > 32) xdev->ext_addr =3D true; --=20 2.25.1