From nobody Mon Feb 9 12:11:23 2026 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F101335BCC for ; Tue, 21 Oct 2025 13:20:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761052845; cv=none; b=L2naJfoxvD6KD/Php7QvsUyNb79Dl4S7hGiz1mKBLxI3c1R8sSzcHOKwzI2s+ZJ+XpB9POQkxAt4jg4cY3SLswLgucoxYhqwNjbhZvMkunIEsy62HOrCqhGVa+shJY1FLnWiz340gGG4DIM7vFY148UJdegfSITLFZsmy34oblg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761052845; c=relaxed/simple; bh=bRW96s5K6QK1fhMIG4F+/LZV86w+m746kxeTcv+vD6o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gW2oqK4NoUd7+OL1F/+q4C+FbM6a3g/gVGC5dLO04/PRuTufzbq69jF3pHBWA8nB0cNWNrVT9+0x7MOioLlMc7jBHR2x2udMb+P1FuGdvO5CdMTF1L7TJedtVZfaHiEkZKKgc3ym/qfWrtwcnLfzyMlaqnzTg1VwGzcSc8n4aec= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sartura.hr; spf=pass smtp.mailfrom=sartura.hr; dkim=pass (2048-bit key) header.d=sartura.hr header.i=@sartura.hr header.b=b6aHvt4s; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sartura.hr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sartura.hr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sartura.hr header.i=@sartura.hr header.b="b6aHvt4s" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-b4aed12cea3so941311366b.1 for ; Tue, 21 Oct 2025 06:20:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura.hr; s=sartura; t=1761052841; x=1761657641; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1oycTZzUoDkyJ6pS20q3YjjueHvpdaaRdxxEpcgucsU=; b=b6aHvt4semsPi1UX57Ejx4zzuClW0umBw5uppbI9G4bh+AhcnOIf2NwXvhXYIZ2NQq cEJq2nR3SAKSsHP/EpWsDObyIPxrySKGjd1DwBK21mYJwuqsPLqWk/lpB3CDaztkUuq9 GwDFYpgF+n+5Sb9F8Goy/gnqHut3ZJTMIcBsW4hxRbCv6VIOhRpqzBoVe41nxQLzDura /4RntuVBvWxSs+Up+/YN9xkeI+sui6NODThFBor2lkkR95mcHJbG9fRT1w6zlb9TUzgu FrLZ6UkGn/0fRuPf54mjiGB71AvRgnyELQVwKqVmL8+L2IgqsckjVYFWgFJNo6GEzZgi UEkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761052841; x=1761657641; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1oycTZzUoDkyJ6pS20q3YjjueHvpdaaRdxxEpcgucsU=; b=iky3KbdyEUS/nVfsHsjnwcmULeB/D/zHnekccSWQhAgFmkjsqP6t7RRtOiSKpOUYB7 7XE4+NjXMwLVF/M5H+UfaGOLAu/AmZYqtNTREqqGo7xJAv5ujj2GBdaBIspCdRDlDNUl lZx/s7JfSZ+YbYssvDl7lDKRRltDDISTQEQBSqP9NDIXrb3qbC0b2IusP9clz63qyJ1N 9DSHt2MEKlLwcQLLxS8V5wRFwu0zJ95uAuBiGPOdgjwuybtuApcP8qrK09N+C60lq5t/ 4AfslhZ4FwjmQ9/L5usBO2CRzGCl7iTA/1DNRW70RgPA8Av7OrMX7pHZlf4QWN4J3uok VFMQ== X-Forwarded-Encrypted: i=1; AJvYcCVMKCjRVNoSF4uMvkrOdp9KrNAlhH6HhfEkUNGIoQ+dD4cnhGqdSPnWVrmnqUAJZKGHffXiM+j9TVwNifg=@vger.kernel.org X-Gm-Message-State: AOJu0YwlInLVFSIibF3UYVJEAKbHV4fQ5r5hlXI3Ld/XA6Os54ue7t8V T1PaSGzChVWo3o+78myUsbcNTPTCdrpA6CafwrAV3CjWVNNeS86A/81dMdBRNFNgBDc= X-Gm-Gg: ASbGncsyBOj/CHtjBoAkJXQTPPC1Ia1VEDN09m4dIuxSbFKuYinH2tSmgk2wKcfK7ae cs84eAWSsm6T5A/RWj+fW9ydqLcDa/PTbKye4FglEi+BSxWOphYoFz/6Y0qK9WE2jU6+AR+VT08 TVAsDvjh/OrrJQoB50byV3CP6+36a7CDUyuenCA1tZZvMzCprgrCa2LoGO8Z+E4Ww1h9IR2maG9 2Y6e+Hvg4bl7OyTM3c3o6tLpPmkzYky45jCmAb6Eg1V4PIjSLepr/OtBmDfIuZUH98BH6amFpTE mtabr2vVvpYlhBT6b571jLQwH4tWqx10TIld2bAyMFXYH9L5f5Z1tIocJ71NbgjGtpm6KWS8CuX 3sWSaPxDsM4NAS34crjMl+lCepWzuHLO0Jqma1YziLG5XGJIzklr9vBX3XwUwbyknIaHW2XWWEQ S+q9BRZ82gXsvLnA== X-Google-Smtp-Source: AGHT+IHnkN9J6ls3cCQo+Po0+g62l+AXaT/giOLW+xSQzumCyw88Vb6sghpJAPP8D5BWv1wyco3vDA== X-Received: by 2002:a17:907:9607:b0:b04:2452:e267 with SMTP id a640c23a62f3a-b6475705103mr1935315766b.56.1761052841452; Tue, 21 Oct 2025 06:20:41 -0700 (PDT) Received: from fedora (dh207-14-87.xnet.hr. [88.207.14.87]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-b65e7da2bc7sm1057788566b.16.2025.10.21.06.20.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Oct 2025 06:20:40 -0700 (PDT) From: Robert Marko To: daniel.machon@microchip.com, andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, vadim.fedorenko@linux.dev, horatiu.vultur@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: luka.perkov@sartura.hr, Robert Marko Subject: [PATCH net] net: phy: micrel: always set shared->phydev for LAN8814 Date: Tue, 21 Oct 2025 15:20:26 +0200 Message-ID: <20251021132034.983936-1-robert.marko@sartura.hr> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently, during the LAN8814 PTP probe shared->phydev is only set if PTP clock gets actually set, otherwise the function will return before setting it. This is an issue as shared->phydev is unconditionally being used when IRQ is being handled, especially in lan8814_gpio_process_cap and since it was not set it will cause a NULL pointer exception and crash the kernel. So, simply always set shared->phydev to avoid the NULL pointer exception. Fixes: b3f1a08fcf0d ("net: phy: micrel: Add support for PTP_PF_EXTTS for la= n8814") Signed-off-by: Robert Marko Tested-by: Horatiu Vultur --- drivers/net/phy/micrel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 16855bf8c391..4929f9b81f54 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -4285,6 +4285,8 @@ static int __lan8814_ptp_probe_once(struct phy_device= *phydev, char *pin_name, { struct lan8814_shared_priv *shared =3D phy_package_get_priv(phydev); =20 + shared->phydev =3D phydev; + /* Initialise shared lock for clock*/ mutex_init(&shared->shared_lock); =20 @@ -4340,8 +4342,6 @@ static int __lan8814_ptp_probe_once(struct phy_device= *phydev, char *pin_name, =20 phydev_dbg(phydev, "successfully registered ptp clock\n"); =20 - shared->phydev =3D phydev; - /* The EP.4 is shared between all the PHYs in the package and also it * can be accessed by any of the PHYs */ --=20 2.51.0