From nobody Sun Feb 8 18:44:26 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 576EC27B32C for ; Tue, 21 Oct 2025 07:25:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761031514; cv=none; b=FJncm43M8Oh6r/EglxaVaBff/5PKxseG+y0LCL4z96IGUwdHUd/iUaZfG/WXqabqCb8xLQ3lx42f0ZGejAM85BBgAwTbg1WcJix0O1jTBomUyEXjWeuutcrol7SUN3T/t1ySE5XqUlF2I8CKH6PutSXNO7bra2KnyO5IWBhNQ3Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761031514; c=relaxed/simple; bh=v5W+PezWFbbY+aMfAZycePfJ6MzFRg1UFID2DsbQ5es=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=aCirCZSZmYbzDc3b0mKHORDIFwA4ljRpqEs4rEKJQd3PKY0tGdJ64acF7V4CoKZvKpwbyl7SeQoCOi697lbhDD+FQdRHrRwKr+G/RJ6obiTzXy9H8kGtOu4myHUZogXIGbXSNYRFxdDz8T9Jqya0iEtot5FcyrWMPTgLR8EPe3o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=fdJ3V0jq; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="fdJ3V0jq" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-789fb76b466so4373571b3a.0 for ; Tue, 21 Oct 2025 00:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1761031511; x=1761636311; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=KHwcQhcWUU+WNkFzfBnvB75wkIBZwj0q3GSBNggcMeY=; b=fdJ3V0jq0zG8ummy0RcvkPYxbIcJsY47gAkxOF3sViDqjochYV9/7VF8PuF75AnDcJ DSvRxfA7qv74RktqPlE7G2jXIdmXiy8ac1X9vELkx5Qk0CrXx2RWnLSOv/lzHRUtJajW ekpkm4GHiKEQxntj4w1kEDVCi6zCQRmR93cA/RAsl5uo2yh2z3aYYRRvOeqNlYPJaLvE iNj6HK9hcq5/84xoNdd2LJqlvmvLbIm6RD5c3brb9Yn1ptk3LH7tmGPv5rpCqwnjM6sz ezOiewji3pqV1NlZYFRXs7u097061H3TIabxl34YMkGANUvj/4zmOB/whiEGNcql00uS DJbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761031511; x=1761636311; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KHwcQhcWUU+WNkFzfBnvB75wkIBZwj0q3GSBNggcMeY=; b=MsO0k4QYzB57EpkDaLzbrphFGrCLLXSTOL89tY2VFwnPl86J0zuDXEQv4P+WvKNmBy 82/qKbMt2v5V5GPnAlwMLhUard5qE0uWqER2osXP/qe5y8Ks+ZVMnQt5/ew4zvBQjyPj to58MPGSqc6HYiNrBPLnW3Z5Ra54JTOeue59E+kvI545F+V+Dfeii47s1zSglBZhhWSv oJa76Ljcaoz7wSldYnBseXYyMWjZdd178RK6v3G4iyuBz39MlzzsD8F6BdNmSHMeHbTV BAsxV4ELKu1oBm1TGE189XGZITO0ISZb56VDcjByMrM+6Sfonob68XGM6L3Xy9XXLrsj WTtA== X-Forwarded-Encrypted: i=1; AJvYcCUwphEaufyW+lzDKarS9xJrGAGE0dfzUMT4XHkFepVUCDuh16AmPhnaSvrTNW5BHfVv1/jvk6BkxMBy86U=@vger.kernel.org X-Gm-Message-State: AOJu0YynUN2BXq1VKVf2jCkYjHjmgex7OJC268s5Lzo6fbafGQKvgn7W Fo5QyRIdGt7pC2j5t/UoexE7lllAUOnGWAvt8Y68+jBMiZNqfvxESgu5QxH8tx0A4pQ= X-Gm-Gg: ASbGncs3sJenj8hprvYBpFa99JN198EWUFzOQbkWmzeU0+xI2ju3jr8O0myA5+2SHv2 3tX/fd/HMUYgchqZZWbqQlUUfzhqeKhdzGGAdHaGDxVfF9L/5SLUuqDBQvrMduenVJ7kS6XSUNq TGyNy7xInSE0uEujzBFxjLXVnQjrRs1Xb5nSM+XgABZGB5xCLjcQEhJOWPGFUdos1/0v4diOeHd luOwPc5osvUQczOixmTIbXUOuDUBMMblONUoENG1oW8Gjq9n8V8+D8/0J5mxn8BPzLGNVb6kYgT sqshkOrFOLo+3BQz5tri2WnGZ19MO7f3jinTOHteI/e57cSTShAqJ8WNjRG8oNliLREGfDk5CmO j4ElIFDPbMOdHPzjOLf8uXgx2wyKeOJOZOS42++TUON1kuMIV1O9AUKmhY9axA6bzfGQmuOfzTq SUQbICfpiPY9ko9DtGDaWDDL1PKzOre0J9TnVbYDUiT0nb X-Google-Smtp-Source: AGHT+IEW3GUucNZit6WqpuapaCOEs9zkg77zT4fdoVitcC49LMohym9Orsu/D9cJjo6dGJXKnxnQ7Q== X-Received: by 2002:a17:902:eccb:b0:276:842a:f9a7 with SMTP id d9443c01a7336-290cba4db6emr221777225ad.57.1761031511240; Tue, 21 Oct 2025 00:25:11 -0700 (PDT) Received: from 5CG3510V44-KVS.bytedance.net ([203.208.189.14]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29246fdbe35sm100207415ad.46.2025.10.21.00.25.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Oct 2025 00:25:10 -0700 (PDT) From: Jinhui Guo To: mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com, jsd@semihalf.com, andi.shyti@kernel.org Cc: guojinhui.liam@bytedance.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/1] i2c: designware: Disable SMBus interrupts to prevent storms from mis-configured firmware Date: Tue, 21 Oct 2025 15:24:31 +0800 Message-Id: <20251021072431.3427-2-guojinhui.liam@bytedance.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20251021072431.3427-1-guojinhui.liam@bytedance.com> References: <20251021072431.3427-1-guojinhui.liam@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When probing the I2C master, disable SMBus interrupts to prevent storms caused by broken firmware mis-configuring IC_SMBUS=3D1; the handler never services them and a mis-configured SMBUS Master extend-clock timeout or SMBUS Slave extend-clock timeout can flood the CPU. Signed-off-by: Jinhui Guo Reviewed-by: Andy Shevchenko Acked-by: Mika Westerberg --- drivers/i2c/busses/i2c-designware-core.h | 1 + drivers/i2c/busses/i2c-designware-master.c | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/= i2c-designware-core.h index 347843b4f5dd..436555543c79 100644 --- a/drivers/i2c/busses/i2c-designware-core.h +++ b/drivers/i2c/busses/i2c-designware-core.h @@ -78,6 +78,7 @@ #define DW_IC_TX_ABRT_SOURCE 0x80 #define DW_IC_ENABLE_STATUS 0x9c #define DW_IC_CLR_RESTART_DET 0xa8 +#define DW_IC_SMBUS_INTR_MASK 0xcc #define DW_IC_COMP_PARAM_1 0xf4 #define DW_IC_COMP_VERSION 0xf8 #define DW_IC_SDA_HOLD_MIN_VERS 0x3131312A /* "111*" =3D=3D v1.11* */ diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busse= s/i2c-designware-master.c index 41e9b5ecad20..45bfca05bb30 100644 --- a/drivers/i2c/busses/i2c-designware-master.c +++ b/drivers/i2c/busses/i2c-designware-master.c @@ -220,6 +220,13 @@ static int i2c_dw_init_master(struct dw_i2c_dev *dev) /* Disable the adapter */ __i2c_dw_disable(dev); =20 + /* + * Mask SMBus interrupts to block storms from broken + * firmware that leaves IC_SMBUS=3D1; the handler never + * services them. + */ + regmap_write(dev->map, DW_IC_SMBUS_INTR_MASK, 0); + /* Write standard speed timing parameters */ regmap_write(dev->map, DW_IC_SS_SCL_HCNT, dev->ss_hcnt); regmap_write(dev->map, DW_IC_SS_SCL_LCNT, dev->ss_lcnt); --=20 2.20.1